129e2fdb18
Improve readability, defer close api
2019-06-24 20:48:52 -07:00
cab5d30900
outDir is clearer I suppose
2019-06-24 16:19:32 -07:00
34fda98f4e
Improve typecheck for driver options
2019-06-24 15:23:57 -07:00
8a4776b250
Fixing top level extract call for new translations directory location
2019-06-24 15:18:31 -07:00
c7bf1ce7cd
type check for drivers
2019-06-24 14:39:21 -07:00
e0c20a4202
Merge pull request #4558 from afbjorklund/reportcard-new
...
Fix the reportcard: gofmt, golint and gocyclo
2019-06-24 11:44:42 -07:00
467d8c975f
Clean up profile folder after minikube delete
2019-06-24 09:48:25 -07:00
820f7984da
go fmt
2019-06-24 11:54:20 -03:00
f802c19eeb
making code more readable
2019-06-24 09:31:35 -03:00
ba20534107
we don't disable other container engines when vmdriver==none
2019-06-24 09:31:35 -03:00
e851619553
Merge pull request #4568 from kubernetes/allow-naked-version
...
Allow --kubernetes-version to be specified without the leading v
2019-06-24 13:03:34 +08:00
ce74af2d08
Merge pull request #4455 from djmgit/sudo_message
...
Provide warning message for unnecessary sudo
2019-06-24 12:58:41 +08:00
a9ec145bcb
Allow --kubernetes-version to be specified without the leading v
2019-06-24 10:29:09 +08:00
31354884a5
run goimports
2019-06-23 21:11:42 +08:00
742dee9e4c
Turn console output message into less noisy info message
2019-06-23 21:03:42 +08:00
abff28db7e
Universally redirect stdlog messages to glog
2019-06-23 20:58:11 +08:00
f20f223c02
Decrease cyclomatic complexity
...
Here is the report (from gocyclo), before:
21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
2019-06-22 17:21:42 +02:00
3be580c97c
add comment for top level command and add chinese transkations
2019-06-20 09:55:29 -07:00
2cee972804
Provide warning message for unnecessary sudo
...
If minikube is started with root privilege and vm-driver is
not hyperV or none, then a warning message is displayed.
2019-06-20 07:43:16 +05:30
e8329f6380
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc
2019-06-19 17:59:17 -07:00
97e2cd1153
Simplifying and correcting the extract code. Test passes now.
2019-06-19 17:44:34 -07:00
4610663674
Merge pull request #4398 from josedonizetti/add-kvm-version-flag
...
Add kvm2 --version
2019-06-20 07:41:18 +08:00
2a6b2ad543
Disable unnecessary load image from cache for none driver
...
since we are not are not saving the images in the cache, there is not much trying to load from the cache either.
2019-06-19 08:35:05 -07:00
6cd86b7ca7
don't make extract an end-user command
2019-06-17 11:43:05 -07:00
c10878a8f0
better error handling
2019-06-15 23:51:56 -07:00
a01e6dd569
notify user of skipping
2019-06-15 23:10:06 -07:00
4fd29be51c
lint and comment
2019-06-15 22:55:57 -07:00
5176806eb2
set context on profile
2019-06-15 22:18:23 -07:00
31ab527da5
Improve enable/disable add-on
...
Closes https://github.com/kubernetes/minikube/issues/4417
2019-06-14 10:47:11 -07:00
dae9425aa0
small changes
2019-06-14 10:17:05 -07:00
6ecc1055b3
Automatically add extra options for none driver on ubuntu
...
Automatically add extra options for none driver on ubuntu
2019-06-13 15:13:55 -07:00
b573cb8a21
adding extract cmd file
2019-06-13 11:18:23 -07:00
f452f0cded
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc
2019-06-10 12:00:39 -07:00
610e4f1159
More extractor work
2019-06-06 14:10:32 -07:00
bb78d3eb31
fix ShowDriverDeprecationNotification config setting
2019-06-05 23:30:13 +02:00
a024c6d22a
Add kvm2 --version
2019-06-04 16:45:14 -03:00
6d57b28fdd
changing string driver name to checked type
2019-06-03 20:27:26 -07:00
bbc679be0e
modify to exit.Unavailable and align the code
2019-06-02 13:26:42 +08:00
d40751ff38
Fix nonexistent profile
2019-05-31 21:36:49 +08:00
483f9fb19e
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc
2019-05-30 15:26:20 -07:00
6d507fbcd1
Fixing variable style
2019-05-29 19:19:33 -07:00
34ccd2ad41
Change console style string to enum
2019-05-29 18:45:55 -07:00
db37c03063
Merge pull request #4364 from tstromberg/no-docker-version
...
docker-env: Remove DOCKER_API_VERSION
2019-05-29 10:27:43 -07:00
a3f557d870
Remove dangling references to DockerAPIVersion
2019-05-28 17:21:26 -07:00
2a590682bf
Remove DOCKER_API_VERSION
2019-05-28 17:16:21 -07:00
e809cbd977
Pass minikube stdin to the kubectl command
...
This is needed for doing e.g. "apply -f -"
2019-05-25 09:57:03 +02:00
7dac217a41
Remove whitespace on empty lines
2019-05-23 17:54:52 -04:00
79c52bf1f0
Address style comment
2019-05-23 17:34:00 -04:00
955932b606
Get current profile if no arguments given
2019-05-23 17:04:59 -04:00
57db3e9d39
Replaced dashboard with cpus in the test case
2019-05-22 13:43:30 -07:00
7d3b4036a9
Minor Formatting changes
2019-05-22 13:38:46 -07:00
c991fe576b
Replaced Fatalf with Errorf
2019-05-22 13:38:46 -07:00
97f0472331
Added test case for minikube config unset
2019-05-22 13:38:46 -07:00
f2fc33d980
Make sure to start Docker, before getting version
2019-05-21 20:54:51 +02:00
9d09ff069b
Merge pull request #4229 from medyagh/no_proxy_for_self
...
Allow minikube to function with misconfigured NO_PROXY value
2019-05-20 11:22:12 -07:00
35dc6a2ff2
Merge pull request #3892 from 11janci/jjanik-expose-pod-cidr
...
Expose ‘—pod-network-cidr’ argument in minikube
2019-05-20 08:14:03 -07:00
21b9e95647
Whitelist for kubeadm extra args
2019-05-17 17:11:03 +12:00
6fe47f3677
Expose ‘—pod-network-cidr’ argument in minikube
2019-05-17 16:59:06 +12:00
fa1c092633
Remove stray newline
2019-05-16 15:39:17 -07:00
3ff806a595
Added unittest and rebase
2019-05-16 14:44:01 -07:00
03ebb0e0f5
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc
2019-05-16 13:50:39 -07:00
698f176d31
Remove unused validateCluster, now handled by bootstrapper.WaitCluster
2019-05-16 13:41:59 -07:00
e535268db5
Use kubeadm to restart kube-proxy rather than rolling our own
2019-05-16 13:28:12 -07:00
08d19bf15a
Improve formatting and messages
2019-05-15 15:39:50 -07:00
e878f9badb
Merge remote-tracking branch 'upstream/master' into no_proxy_for_self
2019-05-15 14:19:14 -07:00
6384a2294e
Fix naming and improve public functions singatures
2019-05-15 11:28:31 -07:00
88f34bd0e3
Pass up better error messages
2019-05-15 10:25:34 -07:00
830e18dc62
Updated warn message and remove duplicate warning
2019-05-14 21:57:48 -07:00
8120cdd505
No Proxy for Dashboard and moving logic to proxy package
2019-05-14 21:45:35 -07:00
313cf575fe
Merge branch 'master' into gomods
2019-05-14 21:06:00 -07:00
c55b9160c6
Merge pull request #4177 from hpandeycodeit/master
...
Unset the current-context after minikube stop
2019-05-14 20:28:29 -07:00
6a433d01bf
Fixing K8S Client Config with TranportWrap
2019-05-14 20:16:44 -07:00
25579f5a58
Use consistent names for k8s API imports
2019-05-13 21:57:59 -07:00
6e693d22ee
lint-a-geddon is here
2019-05-13 21:43:52 -07:00
9a9f9edf5f
First pass at lint-ageddon
2019-05-13 18:31:55 -07:00
0b79a570c5
Initial attempt at localization with gotext
2019-05-13 13:24:15 -07:00
8bc0010716
Fix dashboard behind proxy and refactor
2019-05-09 17:29:52 -07:00
0529f0b95a
Added more comment
2019-05-08 15:17:50 -07:00
581b63ac22
Fixed API connectivity with http(s) proxy
2019-05-08 15:10:10 -07:00
a30bf66347
Merge pull request #3937 from laozc/check-gcr-access
...
Select an accessible image repository for some users
2019-05-07 10:00:16 -07:00
756cd0f343
Merge pull request #4197 from dpandhi-git/master
...
Make default output of 'minikube start' consume fewer lines in the terminal
2019-05-07 09:55:40 -07:00
c98ba69216
anged email address for commit & impleted review updates for #4187
2019-05-06 22:05:04 -07:00
498b719f66
Did go format check for travis build #4187
2019-05-06 22:05:04 -07:00
183322f0bd
Changed minikube start output as per #4187
2019-05-06 22:04:27 -07:00
8afeda20f6
Merge pull request #4199 from sharifelgamal/jibber-jabber
...
Add automatic locale detection
2019-05-03 15:03:05 -07:00
e1decae772
move locale detection to main
2019-05-03 14:08:14 -07:00
5f42672c8a
gofmt
2019-05-03 13:01:54 -07:00
0bf293b019
Move setting locale to start
2019-05-03 12:50:02 -07:00
163e74f7ba
Merge pull request #4191 from tstromberg/stale-mount-pid
...
Make handling of stale mount pid files more robust
2019-05-02 18:49:57 -07:00
292f4ec49b
Add new kubectl command
2019-05-02 20:38:52 +02:00
63bfd32ad3
Revert "Initial implementation of kubectl command"
2019-05-02 11:26:04 -07:00
ec6fc41ac5
Merge pull request #3646 from afbjorklund/kubectl
...
Initial implementation of kubectl command
2019-05-02 11:19:53 -07:00
5c154b0e03
Make KillMountProcess more robust, and failures a warning
2019-05-02 10:21:56 -07:00
144f651385
Triggers repository detection only when --image-repository=auto
2019-05-02 19:07:45 +08:00
fb0127f352
Fixed gofmt errors
2019-04-30 16:24:30 -07:00
df0a0ad77c
Unset the current-context on minikube stop
2019-04-30 00:02:05 -07:00
3eb340b527
don't attempt to pull docker images on relaunch when it's not an upgrade
...
fix syntax
2019-04-25 18:30:02 -03:00
167ab2e422
Merge pull request #4049 from RA489/updatecontextfix
...
update-context is confusing with profiles
2019-04-25 13:04:06 -07:00
ca26ae8afb
Initial implementation of kubectl command
2019-04-25 21:07:57 +02:00
39c0ec1fa0
Merge remote-tracking branch 'origin/master' into check-gcr-access
2019-04-24 23:52:34 +08:00
a1637061a0
Improve comments
2019-04-23 13:43:17 -07:00
56bf985dc5
Download ISO image before Docker images, as it's required first
2019-04-23 13:35:16 -07:00
fa175590c4
Merge remote-tracking branch 'origin/master' into check-gcr-access
2019-04-18 20:52:26 +08:00
677c497101
Systemd returns error on inactive, so allow that
...
The SSH infrastructure currently doesn't handle when the command
is _supposed_ to return an error, so allow this case explicitly.
2019-04-14 09:55:17 +02:00
b55507b50c
Another complex function
...
17 cmd runStart cmd/minikube/cmd/start.go:165:1
2019-04-12 20:47:29 +02:00
a73dfc5f9e
Merge branch 'master' into cyclo
2019-04-12 20:03:20 +02:00
84432d7c54
update-context is confusing with profiles
2019-04-12 10:59:16 +05:30
6a2e7efc94
Fix broken build
2019-04-12 14:16:57 +12:00
1e26bb0c0d
Merge branch 'master' into download
2019-04-11 12:20:36 -07:00
903e9c29c7
Merge pull request #4059 from marcosdiez/dont-cache-images-when-vmdriver-is-none
...
Don't cache images when --vmdriver=none
2019-04-10 12:33:05 -07:00
8f5fe19722
politically correct comment
2019-04-10 15:24:04 -03:00
2a826b14df
shorter comment
2019-04-10 15:22:12 -03:00
3deee6322b
removed line as requested
2019-04-06 07:23:16 -03:00
9bc73ebbaf
code comments
2019-04-05 08:36:45 -03:00
3db7e9e252
Don't cache images when --vmdriver=none
2019-04-04 23:01:10 -03:00
d102550644
Fixed status checking with non-default apiserver-port.
2019-04-04 21:43:43 -04:00
f64b343965
```#compdef``` must be the first line
2019-03-28 10:44:32 +08:00
9c94b2fac6
Merge branch 'master' into no-infinite-loops
2019-03-26 17:11:39 -07:00
950421d2d2
Merge pull request #3985 from tstromberg/mount-intr
...
More reliable unmount w/ SIGINT, particularly on kvm2
2019-03-26 15:32:53 -07:00
9edda72985
Block on cache downloads before using the results
2019-03-26 14:59:17 -07:00
807963ac74
Use r for mockRunner instead of h
2019-03-26 14:45:18 -07:00
6f516ff647
Merge branch 'master' into mount-names
2019-03-26 14:30:42 -07:00
7233a2d50d
Allow mount to work when the uid/gid of docker changes
2019-03-26 14:27:50 -07:00
0ebfe462b9
Add --download-only option to start command
...
Make it possible to download files without loading or installing,
and without starting the host... Download: ISO, binaries, images.
2019-03-26 21:43:54 +01:00
adcbcf113b
Refactor: move cache calls into separate functions
...
Need to split out the caching functions, from the loading/copying.
Also need to make the lists accessible from outside the functions.
2019-03-26 21:43:18 +01:00
c861ab7dc1
Switch mount ssh impl from native to CommandRunner
2019-03-26 12:14:06 -07:00
411b1162cb
Fix another high score
...
16 config EnableOrDisableAddon cmd/minikube/cmd/config/util.go:105:1
2019-03-26 20:05:18 +01:00
9deb531889
Merge pull request #3947 from afbjorklund/hidden
...
Add explicit kvm2 flag for hidden KVM signature
2019-03-25 18:58:05 -07:00
a1317476c2
Merge pull request #3931 from tstromberg/bring_ya_errs_to_the_project_maybe_we_can_solve_it
...
Add solution catalog to help users who run into known problems
2019-03-25 18:33:07 -07:00
6491e35c20
Add explicit kvm2 flag for hidden KVM signature
2019-03-24 09:47:38 +01:00
8c28ca4202
Select an accessible image repository for some users
...
Now it's possible to fallback to a mirror site for those users
who cannot access the main k8s.gcr.io repository. You may also
set the --image-mirror-country to forcibly use a known local
mirror in the specific location.
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-03-23 16:58:55 +08:00
702d471308
Merge pull request #3714 from laozc/custom-image-repository
...
Add --image-repository flag so that users can select an alternative repository mirror
2019-03-22 09:24:18 -07:00
daec030cdf
Render asset template when enabling/disabling addon
2019-03-22 15:28:20 +08:00
cbac94a53d
Merge pull request #3879 from marcosdiez/extra_config_for_kubeadm
...
--extra-config now work for kubeadm as well
2019-03-21 22:03:06 -07:00
37e259f7ea
Implement the new problem package
2019-03-21 21:44:51 -07:00
7ae074106c
Merge remote-tracking branch 'origin/master' into custom-image-repository
2019-03-22 10:42:09 +08:00
5b46539be8
Fix merge conflict between e09133892f and 46640cef68
2019-03-21 16:11:16 -07:00
ed58b6fc35
Merge pull request #3917 from tstromberg/cache_me_outside_how_bout_dat
...
start: Set the default value of --cache to true
2019-03-21 14:29:24 -07:00
88c45bf5b2
Merge branch 'master' into lint
2019-03-21 11:34:45 -07:00
20b9cfd0f3
Merge pull request #3897 from u5surf/issue-3878
...
Replace server name in updateKubeConfig if --apiserver-name exists #3878
2019-03-21 11:33:54 -07:00
6bf6290013
Merge pull request #3861 from RA489/featuregate
...
feature-gates via minikube config set
2019-03-21 11:33:41 -07:00
f9a136a2f2
Merge pull request #3841 from afbjorklund/reportcard
...
Address the low-hanging fruit on report card
2019-03-21 11:33:28 -07:00
460ef571e2
Merge branch 'master' into lint
2019-03-21 11:32:47 -07:00
034c5f0252
Merge branch 'master' into mount-intr
2019-03-21 11:24:26 -07:00
2d4e560d30
Merge pull request #3834 from tstromberg/proxy-plumbing
...
Automatically propagate proxy environment variables to docker env
2019-03-21 10:27:37 -07:00
7de36ed9a1
allow --extra-config work on kubeadm as well. example: --extra-config kubeadm.ignore-preflight-errors=SystemVerification
...
missing variable
2019-03-21 06:33:46 -03:00
daeb238766
Merge remote-tracking branch 'origin/master' into custom-image-repository
2019-03-21 13:23:11 +08:00
c848103ab1
start: Set the default value of --cache to true
2019-03-20 21:49:22 -07:00
2579c73e11
Merge pull request #3875 from steved/fix-change-user-none
...
fix CHANGE_MINIKUBE_NONE_USER regression from recent changes
2019-03-20 20:11:06 -07:00
79aafd525f
Merge branch 'master' into mount-intr
2019-03-20 19:56:43 -07:00
6751e394f8
Merge pull request #3833 from afbjorklund/cruntime-version
...
Cruntime version
2019-03-20 19:55:45 -07:00
0d6c92153f
Merge branch 'master' into reportcard
2019-03-20 19:16:02 -07:00
0197b12a82
Make mount type a flag instead of a hardcoded string
2019-03-20 17:13:32 -07:00
4756b15bc1
Merge branch 'master' into lint
2019-03-20 10:16:09 -07:00
a34a9d32e6
Replace server name in updateKubeConfig if --apiserver-name exists #3878
2019-03-18 22:15:56 +09:00
5497b966be
Rename stutter and move classes between packages
...
Removing the kubeconfig module is probably not a big deal,
since it was already hiding under the "util" directory...
But the layout of the Bootstrapper is slightly irritating,
as long as it is contained in a different "kubeadm" module.
2019-03-16 16:57:56 +01:00
dba916a016
Document all exported functions inside minikube
...
Make config get/set more symmetrical, as well.
2019-03-16 16:57:43 +01:00
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
40caf8317c
Merge remote-tracking branch 'upstream/master' into custom-image-repository
2019-03-15 18:01:48 +08:00
a94e0ac2f8
fix CHANGE_MINIKUBE_NONE_USER regression from recent changes
...
6c48048538
2019-03-14 09:05:51 -07:00
8fc1d494fa
[FEATURE] feature-gates via minikube config set
2019-03-12 17:55:07 +05:30
1b67196401
Improve options output
2019-03-11 16:25:43 -07:00
c713b186e8
unmount on sigint/sigterm, --options and --mode, improve mount UI
2019-03-11 16:18:06 -07:00
6d96a67456
Run go vet on all code, not just pkg and cmd
2019-03-10 14:33:24 +01:00
61dd4ab1fd
Address unused error, reported by ineffassign
...
minikube/cmd/minikube/cmd/env.go
Line 330: warning: ineffectual assignment to err (ineffassign)
2019-03-10 13:41:59 +01:00
112a66c21a
Add some error reporting to the version method
2019-03-10 10:18:26 +01:00
9b2fad5710
Show current version of the container runtime
2019-03-10 10:09:59 +01:00
ecb6f3bb31
Automatically propagate proxy environment variables to docker env
2019-03-08 13:12:29 -08:00
56a51ffe0d
Merge branch 'master' into cache_images_int_test2
2019-03-06 15:21:11 -08:00
c4ee5eec08
fix incorrect style name mount
2019-03-04 23:59:46 +02:00
46640cef68
Address all lint except undocumented and stutter
...
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
ba5a02596f
Change --image-repository usage text
2019-02-28 10:15:08 +08:00
e09133892f
Fix docker/containerd caching, improve msgs, add tests
2019-02-27 13:58:33 -08:00
167d1584a6
Add flag for disabling the VirtualBox VTX check
...
Currently this is broken upstream, provide workaround...
Already available in docker-machine, so port to minikube.
2019-02-22 18:29:29 +01:00
3426326ed7
Merge pull request #3719 from tstromberg/none-doc-fix
...
chown command should be against user $HOME, not roots home directory.
2019-02-19 13:08:09 -08:00
245ec739ca
chown command should be against user $HOME, not roots home directory.
2019-02-19 11:47:00 -08:00
7cbe253ef6
Allow specifying image repository for docker images
...
Some users (especially for those in mainland China) may have issue
accessing the default image repository. This patchset allows users
to override the default image repository gcr.io to a different
repository by specifying --image-repository option in the command
line as a simple workaround. Images will be pulled from the
specified image repository instead of the default ones.
Example (using mirror by Aliyun):
minikube start ...
--image-repository
registry.cn-hangzhou.aliyuncs.com/google_containers
2019-02-18 01:00:12 +08:00
19c2f5cb44
Make non-zero ssh error codes less dramatic
2019-02-16 08:36:53 -08:00
637e71fa4c
Improve reporting when docker host/service is down
...
Don't just wait for a timeout, when SSH is not running.
Also improve the message, don't need to comment stderr.
2019-02-16 09:29:46 +01:00
b80498fcb4
Merge from HEAD
2019-02-15 09:24:35 -08:00
4a1feb6531
Reduce text clutter
2019-02-15 07:16:41 -08:00
71eafef5ce
Overhaul how we handle kubectl, as it isn't actually required except for the dashboard
2019-02-14 17:10:03 -08:00
35449f685e
Merge remote-tracking branch 'upstream/master'
2019-02-14 16:21:31 -08:00
5d09d35302
Improve output strings when used by none driver
2019-02-14 16:21:21 -08:00
c2194e191d
Fix merge conflicts
2019-02-14 11:58:07 -08:00
4cfe77294d
Fix style merge conflict
2019-02-14 11:25:42 -08:00
3714bbd787
Merge pull request #3659 from tstromberg/console
...
Clearer output when re-using VM's so that users know what they are waiting on
2019-02-14 11:03:50 -08:00
08da5fe3b5
Add pod logs to 'logs' command, show detected problems during minikube start
2019-02-13 21:29:20 -08:00
69f72ea991
Add exit.go, remove call to exit.Fail
2019-02-13 12:47:02 -08:00
5f65dc80fa
Remove error uploads, consolidate fatal error handling into exit package
2019-02-13 12:37:44 -08:00
1c09ba2a48
Make the output clearer and less cluttered
2019-02-13 09:41:53 -08:00
e74db39783
Issue a poweroff request before deleting a VM. Avoids HyperV hang
2019-02-13 09:21:58 -08:00
00aff6039b
Fix to not execute clusterBootstrapper.Delete when clusterBootstrapper is nil #3662
2019-02-13 10:08:06 +09:00
ade3515f4f
Disable Stackdriver error reporting until we can clean up the interface
2019-02-12 14:33:38 -08:00
3454c83dcf
Clearer output when re-using VM's so that users know what they are waiting on
2019-02-12 13:54:30 -08:00
0a91040434
Add DeleteCluster to bootstrapper
...
This matches StartCluster, and is used to revert
the changes done to reset the VM machine state.
Even if it fails, continue to deleting the VM...
Make sure to handle the case of missing config.
2019-02-12 19:49:19 +01:00
0a5b64eeaf
Improve text strings for existing VM's and setting cluster permissions
2019-02-11 19:28:23 -08:00
452054bf25
Implement PR comments
2019-02-11 15:01:34 -08:00
deb31b4230
Pull upstream, sort out merge conflicts, use ParseBool
2019-02-11 13:56:45 -08:00
73dd006813
Replace string comparison with class method
2019-02-09 20:59:26 +01:00
78806674f3
Merge branch 'master' into defaults
2019-02-09 18:25:27 +01:00
6e1b9d030c
Merge pull request #953 from denji/parallels
...
machine: add parallels support
2019-02-08 15:39:43 -08:00
6c48048538
Merge from hell #2 : refactor start.go because it's terrible
2019-02-08 13:37:29 -08:00
ee8ddd60a8
Merge
2019-02-07 18:21:29 -08:00
0f11c4de8e
Remove unnecessary break statement
2019-02-07 16:14:47 -08:00
e6c59fa135
Add back accidentally removed status line
2019-02-07 15:40:43 -08:00
9f09f02e39
Address PR comments, make sure PullImages code path is exercised
2019-02-07 15:39:31 -08:00
f2d6f45538
More console work
2019-02-07 14:56:29 -08:00
d1b0d0470a
Initial console implementation
2019-02-06 22:00:30 -08:00
966b245dc6
Refactor and centralize container runtime code into a cruntime package
2019-02-05 14:42:12 -08:00
6ff11e44a5
Remove default cni flags from the documentation
2019-02-05 20:05:05 +01:00
0071a940a7
Need to check if changed, not the current value
2019-02-02 19:11:33 +01:00
6e7fc9dbf5
Add cni default for alternative container runtimes
...
If using an alternative container runtime, and not having set
any other parameters already, default to cni plugin and config.
2019-02-02 18:36:46 +01:00
1cb2ba06e1
Refactor: add variables for network configuration
2019-02-02 18:36:42 +01:00
b19526ab6c
minor de-linting: run gofmt, goimports, pre-allocate fields slice
2019-01-25 10:49:58 -08:00
a1cd81bf1c
machine: add parallels support
2019-01-25 10:31:26 +02:00
b61207c233
Merge pull request #3391 from ivans3/logviewer-addon-pr7
...
Initial commit of logviewer addon
2019-01-24 16:00:29 -08:00
ad2b762c51
Merge pull request #3286 from hidekazuna/fix_vm_driver_none
...
Fix to run sudo -E minikube start --vm-driver=none
2019-01-24 15:59:14 -08:00
fd562f81b1
Merge pull request #3565 from twelvelabs/patch-1
...
Remove redundant newline in `minikube status`
2019-01-24 07:33:20 -08:00
34aa0c6895
Remove redundant newline in `minikube status`
...
Both #3502 (which this commit reverts) and #3523 attempted to fix the same issue.
Keeping the change from the latter PR since it fixes it at the source template.
2019-01-21 10:54:25 -06:00
3389344d51
Need to restart crio, after stopping containerd
...
If it fails to start up, it will never try again.
2019-01-20 17:06:37 +01:00
2c0b7da11e
Stop containerd from running, if it is not desired
...
Apparently some grpc services are conflicting with crio
"Failed to start streaming server: listen tcp 10.0.2.15:10010: bind: address already in use"
2019-01-20 17:02:36 +01:00
56f8142e24
Merge pull request #3194 from afbjorklund/crictl.yaml
...
Write /etc/crictl.yaml when starting
2019-01-17 10:34:06 -08:00
f29c0cd329
Merge pull request #3533 from tstromberg/kubeadm-log-output
...
Improve failure output when kubeadm init fails
2019-01-17 10:33:23 -08:00
c563c4d1fb
Write /etc/crictl.yaml when starting
2019-01-17 07:27:28 +01:00
c2bf394378
Minor improvements to output and comments
2019-01-16 12:14:56 -08:00
3aa83674a9
Merge pull request #3441 from brb/2907-no-cni-conf-by-default
...
Do not include the default CNI config by default
2019-01-15 17:14:20 -08:00
303e26cd56
Merge pull request #3494 from knabben/reporterror-test
...
Adding more utils tests
2019-01-15 17:13:23 -08:00
8bc8816c9f
Merge pull request #3521 from nixpanic/addons/gluster
...
Add a storage-provisioner-gluster addon
2019-01-15 17:08:45 -08:00
7b32547cf6
Merge pull request #3108 from sebcworks/sebcworks-customapiserverport
...
Allow to specify api server port through CLI fix #2781
2019-01-15 16:43:42 -08:00
393d1af3c6
mention 'minikube logs' for debugging start failures
2019-01-15 16:37:28 -08:00
bf02c016b3
Make failure prompt text more clear
2019-01-15 16:37:04 -08:00
0a58301e3e
Merge pull request #3502 from narendra2019/master
...
issue# 3499: minikube status missing newline at end of output
2019-01-14 13:24:31 -08:00
3223e044e4
apiserver health: try up to 5 minutes, add newline
2019-01-11 11:49:49 -08:00
b85b6d5eeb
addons: mark the last enabled storage provider as default
...
When a storage provider is enabled (storage-provisioner-glusterfile),
mark it "is-default" and set "is-default" to "false" in all other
StorageClasses.
2019-01-09 20:04:21 +01:00
b0c7341373
addons: when enabling storage-provisioner-gluster, mark other SCs non-default
...
There can only be one StorageClass be marked as default. When the
storage-provisioner-gluster addon is enabled, users expect it to be the
default StorageClass.
Instead of removing the "is-default" annotation from the other
StorageClasses, set it to "false". This leaves only the "glusterfile"
StorageClass as "is-default".
2019-01-09 20:04:21 +01:00
3c3b7368f0
Add storage-provisioner-gluster addon
...
With this addon dynamic provisioning based on Gluster can be enabled:
$ minikube addons enable storage-provisioner-gluster
This will deploy several pods in a new 'storage-gluster' namespace:
- glusterfs, storage service with a 10GB sparse /srv/fake-disk.img
- heketi, a smart Gluster volume manager
- glusterfile-provisioner, external-storage provisioner
In addition, the StorageClass 'glusterfile' will be created. It is
currently not configured as default StorageClass, so PVCs need to refer
to the new StorageClass.
2019-01-09 20:04:21 +01:00
68287a9497
issue# 3499: minikube status missing newline at end of output
...
Done code changes to display newline at the end of the status message
2019-01-04 22:13:33 +05:30
d982c4bf74
Do not include the default CNI config by default
...
Previously, minikube has been shipped with the default CNI config
(/etc/cni/net.d/k8s.conf) in its rootfs. This complicated a lot
when using a custom CNI plugin, as the default config was picked
by kubelet before the custom CNI plugin has installed its own CNI
config. So, the end result was that some Pods were attached to a
network defined in the default config, and some got managed by
the custom plugin.
This commit introduces the flag "--enable-default-cni" to
"minikube start" to trigger the provisioning of the default CNI
config.
Signed-off-by: Martynas Pumputis <m@lambda.lt>
2019-01-03 09:23:29 +01:00
6762fb0096
Adding GetkubeConfig path test
2018-12-28 10:49:50 -02:00
f948bf8136
Adding ReportError test and HTTP Test server reuse
2018-12-28 10:04:45 -02:00
1bd4b05bc8
Increase dashboard retry time from 30 seconds to 3 minutes
2018-12-21 14:14:36 -08:00
f3d158198f
Add helpful dashboard status messages to stderr
2018-12-21 12:00:43 -08:00
dba0c0a0dc
Disable dashboard by default
2018-12-21 11:49:20 -08:00
ab64cb952e
Merge pull request #3479 from tstromberg/stop-retry
...
Make "stop" retry on failure.
2018-12-20 19:46:24 -08:00
c250a3b9d9
Make "stop" retry on failure.
2018-12-20 13:19:53 -08:00
ed7031cbb3
Merge branch 'master' into logviewer-addon-pr7
2018-12-19 17:14:09 -08:00
c7e69fd257
Allow ServiceCIDR to be configured via 'service-cluster-ip-range' flag.
2018-12-18 12:17:33 -05:00
5d910e8937
Save old cluster config in memory before overwriting ( #3450 )
...
* Save old cluster config in memory before overwriting
In PR #3426 , I changed "minikube start" to overwrite the cluster config earlier so that the container runtime could be extracted from it by the buildroot provisioner. This introduced a bug later on, where minikube expected to read the kubernetes version from theold config (which no longer existed, because the config was overwritten).
To fix this, I changed the code to store the old version of the config in memory before overwriting it.
This should fix #3447
2018-12-13 14:31:22 -08:00
8f128a7d10
Enable gvisor addon in minikube ( #3399 )
...
This PR adds the code for enabling gvisor in minikube. It adds the pod
that will run when the addon is enabled, and the code for the image
which will run when this happens.
When gvisor is enabled, the pod will download runsc and the
gvisor-containerd-shim. It will replace the containerd config.toml and
restart containerd.
When gvisor is disabled, the pod will be deleted by the addon manager.
This will trigger a pre-stop hook which will revert the config.toml to
it's original state and restart containerd.
2018-12-07 15:27:22 -08:00
Medya Gh
Sharif Elgamal
Medya Ghazizadeh
Francis
Marcos Diez
Thomas Strömberg
Anders F Björklund
Deepjyoti Mondal
Pradip-Khakurel
josedonizetti
Mike Lewis
Himanshu Pandey
Jan Janik
Deepika Pandhi
Zhongcheng Lao
RA489
Benn Linger
Jat
u5surf
Steven Davidovitz
Tom Reznik
Denis Denisov
Skip Baney
Niels de Vos
Narendra Kangralkar
Martynas Pumputis
Amim Knabben
Balint Pato
Chris Eason
priyawadhwa