Anders F Björklund
ea7a2d7e33
Improve reportcard by refactoring and commenting
...
golint: 99%
pkg/minikube/localpath/localpath.go
Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
pkg/minikube/cluster/cluster.go
Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
cmd/minikube/cmd/start.go
Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
Anders F Björklund
81622e2a00
Minor: change assignment to declaration
...
"warning: ineffectual assignment to updated (ineffassign)"
2020-01-04 10:23:16 +01:00
Medya Ghazizadeh
df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
...
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
fenglixa
c2ba574f2e
generate istio document page and layout
2019-12-26 14:35:13 +08:00
andylibrian
f42c8a49fb
fixed comment
2019-12-21 18:34:40 +07:00
andylibrian
76714aca84
implemented options command #5036
...
This is to fix help command showing invalid "minikube <command> options".
It happened because minikube reuses kubectl templates which expects
options cmd to be there.
2019-12-21 11:09:36 +07:00
Medya Gh
d5f56477bc
code review resolve
2019-12-20 17:14:14 -08:00
Medya Gh
3b2cfa6c32
rename funcs
2019-12-20 16:53:35 -08:00
Medya Gh
83cd426436
refactor more
2019-12-20 16:11:05 -08:00
Medya Gh
cf6bde8eaf
refactor image specific funcs to image package
2019-12-20 16:05:08 -08:00
Medya Gh
be8a1ad107
resolve code reviews
2019-12-20 12:43:13 -08:00
Medya Gh
5eb384cf7d
check error and fix logging msg
2019-12-20 12:24:05 -08:00
Medya Gh
a3e16fae72
add reload command
2019-12-20 12:06:26 -08:00
Medya Gh
2d1fffe1d1
better names
2019-12-20 12:06:26 -08:00
Medya Gh
679a9c114b
more clear func names
2019-12-20 12:06:26 -08:00
Medya Gh
71a896fc0a
unexport func cacheImage
2019-12-20 12:06:25 -08:00
Medya Gh
193d16dd0c
rename funcs for more clarity
2019-12-20 12:06:25 -08:00
Medya Gh
03c717c7b0
unexport cacheImagesInConfigFile func
2019-12-20 12:06:25 -08:00
Medya Ghazizadeh
031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
...
kic-xmas edition
2019-12-20 11:40:46 -08:00
Medya Gh
1014a57ea8
better names for bs type
2019-12-20 01:01:10 -08:00
tstromberg
bf183603c5
Disable StartHost retry. It caused more problems than it solved
2019-12-19 16:10:44 -08:00
Thomas Strömberg
4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
...
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
Thomas Strömberg
aca49067fa
Merge pull request #6110 from digitalcoyote/master
...
Fixed IPv6 format for SSH
2019-12-19 11:51:55 -08:00
Kenta Iso
6316959739
Fix update-context to use KUBECONFIG when the env is set and add integration test
2019-12-19 00:28:39 -08:00
Medya Gh
b8d07daef3
move reusabe parts of kubeadm to a package
2019-12-18 17:22:42 -08:00
Medya Gh
31ad90d3cb
Add place holder bootstrapper for kicbs
2019-12-18 16:11:50 -08:00
Medya Gh
83374f4371
add querytype to nslookup
2019-12-18 15:54:36 -08:00
Medya Gh
19560a631b
Add kic specific machine creation message
2019-12-18 15:53:34 -08:00
Medya Gh
2243847f98
add kic command runner to machine
2019-12-18 13:57:32 -08:00
Medya Gh
c627f58fbb
add default image
2019-12-18 13:04:09 -08:00
tstromberg
98508253a5
--download-only should download drivers
2019-12-18 09:46:36 -08:00
Medya Gh
b6dbf3bd0d
add auto-set container-runtime for kic
2019-12-17 22:19:39 -08:00
Curtis Carter
119d95cb31
Fixed format of IPV6 address and port
2019-12-17 13:23:30 -06:00
Kenta Iso
a840cb7289
Fix update-context to use KUBECONFIG when the env is set and add integration test
2019-12-17 00:58:45 +09:00
Thomas Stromberg
661ebf843f
Merge master
2019-12-10 14:07:02 -08:00
Thomas Strömberg
349f414dee
Merge pull request #5987 from medyagh/cache_fix2
...
cache add: load images to all profiles & skip previously cached images
2019-12-10 13:58:57 -08:00
Thomas Stromberg
14b805d494
Remove unused vars
2019-12-10 08:17:08 -08:00
Thomas Stromberg
8b7aaba627
Sync correct Kubernetes versions from kubeadm constants
2019-12-10 08:12:15 -08:00
priyawadhwa
434648c6fc
Merge pull request #5773 from priyawadhwa/pr-bot
...
Add skeleton for performance analysis service
2019-12-09 18:26:45 -08:00
Medya Gh
60346821d6
move machine path to localpath package
2019-12-09 14:51:10 -08:00
Medya Gh
35ad8e2915
make profile name mandatory for config.Load
2019-12-09 14:47:20 -08:00
Thomas Strömberg
a6c749f905
Merge pull request #5798 from nanikjava/f-fix-2570
...
Make Kubernetes version sticky for a cluster instead of auto-upgrading
2019-12-09 13:47:44 -08:00
Thomas Strömberg
1f36a42203
Merge pull request #5912 from tstromberg/user-mutex2
...
Make lock names uid and path specific to avoid conflicts
2019-12-09 13:34:56 -08:00
Priya Wadhwa
4b78f7bd48
Rebased on head, resolved merge conflict
2019-12-09 12:03:37 -08:00
Medya Gh
d7b6e66038
fix unit tests and improve naming
2019-11-26 20:07:56 -08:00
Medya Gh
95717c4793
add status to profile list
2019-11-26 19:53:27 -08:00
Medya Gh
cdb68a139e
refactor config to allow load profile config
2019-11-26 18:32:59 -08:00
Medya Gh
6c08fedf97
remove cyclic depdenecy and make cluster pkg smaller
2019-11-26 17:48:37 -08:00
Medya Ghazizadeh
72e973027d
Merge pull request #5955 from cheeseandcereal/fix_profile_list_json
...
Fix profile list json command output
2019-11-25 14:59:11 -08:00
Medya Ghazizadeh
c462862a38
Merge pull request #5964 from afbjorklund/config-runtime
...
Fix validation of container-runtime config
2019-11-25 13:19:23 -08:00