Anders F Björklund
ea7a2d7e33
Improve reportcard by refactoring and commenting
...
golint: 99%
pkg/minikube/localpath/localpath.go
Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
pkg/minikube/cluster/cluster.go
Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
cmd/minikube/cmd/start.go
Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
Anders Björklund
06b1cf393a
Merge pull request #6207 from afbjorklund/reportcard-ineffassign
...
Minor: change assignment to declaration
2020-01-06 10:14:42 +01:00
Kubernetes Prow Robot
ecdd9a4a86
Merge pull request #6215 from longkb/remove_duplicated_words
...
Remove duplicated words
2020-01-06 01:13:34 -08:00
Kim Bao Long
f388f69220
Remove duplicated words
...
Although it is spelling mistakes, it might make an affects while reading.
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-06 15:54:27 +07:00
Anders F Björklund
81622e2a00
Minor: change assignment to declaration
...
"warning: ineffectual assignment to updated (ineffassign)"
2020-01-04 10:23:16 +01:00
Anders Björklund
ca5213b2f4
Merge pull request #6199 from afbjorklund/buildroot-2019.02.8
...
Upgrade buildroot minor version
2020-01-04 10:00:34 +01:00
priyawadhwa
5f0ba5492d
Merge pull request #6191 from q384566678/fix-typo
...
Fix a typo 'the the' -> 'the'
2020-01-02 19:52:12 -08:00
Zhou Hao
62bfc39404
Fix comment
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-03 09:31:55 +08:00
Medya Ghazizadeh
72ea2047a2
Merge pull request #6183 from afbjorklund/systemd-amd
...
Add systemd patch for booting on AMD Ryzen
2020-01-02 16:15:50 -08:00
priyawadhwa
279b94c055
Merge pull request #6176 from ydcool/translation-zh
...
update zh translation
2020-01-02 10:36:40 -08:00
Anders F Björklund
9e990f6b87
Upgrade buildroot minor version
2020-01-02 12:52:23 +01:00
Medya Ghazizadeh
4ab2cfdf87
Merge pull request #6188 from GennadySpb/patch-1
...
Update hyperkit.md (fix typo)
2020-01-01 22:14:19 -08:00
GennadySpb
42932b223c
Update hyperkit.md
2019-12-31 19:43:14 +03:00
Medya Ghazizadeh
e5f5abda89
Merge pull request #6179 from q384566678/fix-pause
...
pkg/drivers/kic: fix wrong command in Unpause
2019-12-30 18:42:28 -08:00
Medya Ghazizadeh
d0ec905abb
Merge pull request #6174 from q384566678/oci-info-fix
...
fix kic status comments
2019-12-30 18:41:25 -08:00
Medya Ghazizadeh
630357d80f
Merge pull request #6169 from ttonline6/fix_nvidia
...
fix nvidia GPU docs
2019-12-30 18:40:06 -08:00
Anders F Björklund
bee6dc1a5d
Add systemd patch for booting on AMD Ryzen
...
https://github.com/systemd/systemd/pull/12536
Backported to systemd version 240 for Ubuntu:
[ Jeremy Soller ]
* random-util: eat up bad RDRAND values seen on AMD CPUs.
This fixes AMD Ryzen 3000 series failing to boot (LP: #1835809 )
2019-12-30 18:59:56 +01:00
Zhou Hao
9c4e3fbd3c
pkg/drivers/kic: fix wrong command in Unpause
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:54:48 +08:00
Dominic Yin
e8e4f6f120
update zh translation
...
Signed-off-by: Dominic Yin <yindongchao@inspur.com>
2019-12-30 15:38:56 +08:00
Zhou Hao
ae61e56594
pkg/drivers/kic/oci: fix Status info
...
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:21:03 +08:00
ttonline6
91def7ba10
change NVIDIA's device plugin yaml link
2019-12-30 10:25:17 +08:00
ttonline6
781a1a1f74
fix unreachable url: https://raw.githubusercontent.com/NVIDIA/k8s-device-plugin/v1.10/nvidia-device-plugin.yml
2019-12-28 09:30:35 +08:00
Medya Ghazizadeh
c545b00cc6
Merge pull request #6164 from ttonline6/master
...
fix podman build documentation link
2019-12-27 11:56:59 -08:00
Medya Ghazizadeh
df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
...
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
ttonline6
ea6e46fb9c
fix 404 url: https://github.com/containers/libpod/blob/master/docs/podman-build.1.md
2019-12-27 12:07:08 +08:00
fenglixa
c2ba574f2e
generate istio document page and layout
2019-12-26 14:35:13 +08:00
Medya Ghazizadeh
6b0e2ca121
Merge pull request #6144 from andylibrian/5036-incorrect-subcommand-options
...
implemented options command, fixes #5036
2019-12-24 01:57:07 -08:00
Medya Ghazizadeh
ce4b9503ae
Merge pull request #6137 from q384566678/add-constants-test
...
Add constants_test
2019-12-23 01:13:50 -08:00
andylibrian
f42c8a49fb
fixed comment
2019-12-21 18:34:40 +07:00
andylibrian
76714aca84
implemented options command #5036
...
This is to fix help command showing invalid "minikube <command> options".
It happened because minikube reuses kubectl templates which expects
options cmd to be there.
2019-12-21 11:09:36 +07:00
Medya Ghazizadeh
ef28befa5e
Merge pull request #6051 from medyagh/cache_reload
...
adding feature to reload cache
2019-12-20 19:20:02 -08:00
Medya Gh
d5f56477bc
code review resolve
2019-12-20 17:14:14 -08:00
Medya Gh
3b2cfa6c32
rename funcs
2019-12-20 16:53:35 -08:00
Medya Gh
83cd426436
refactor more
2019-12-20 16:11:05 -08:00
Medya Gh
cf6bde8eaf
refactor image specific funcs to image package
2019-12-20 16:05:08 -08:00
Medya Gh
cde5503d3e
add two mechanism to find local image digest
2019-12-20 14:09:18 -08:00
Medya Gh
9d03e56ece
resolve merge conflict
2019-12-20 12:44:09 -08:00
Medya Gh
be8a1ad107
resolve code reviews
2019-12-20 12:43:13 -08:00
Medya Gh
825d7bbeca
fix integration test
2019-12-20 12:24:05 -08:00
Medya Gh
a283668cdf
fix lint
2019-12-20 12:24:05 -08:00
Medya Gh
688b608197
add comment for test
2019-12-20 12:24:05 -08:00
Medya Gh
3b9fadaa8a
add integration test for cache reload
2019-12-20 12:24:05 -08:00
Medya Gh
5eb384cf7d
check error and fix logging msg
2019-12-20 12:24:05 -08:00
Medya Gh
502f3b7f8f
use docker cli lib to get image id
2019-12-20 12:18:55 -08:00
Medya Gh
4d9e53389a
improve logging
2019-12-20 12:12:48 -08:00
Medya Gh
a3e16fae72
add reload command
2019-12-20 12:06:26 -08:00
Medya Gh
2d1fffe1d1
better names
2019-12-20 12:06:26 -08:00
Medya Gh
679a9c114b
more clear func names
2019-12-20 12:06:26 -08:00
Medya Gh
71a896fc0a
unexport func cacheImage
2019-12-20 12:06:25 -08:00
Medya Gh
193d16dd0c
rename funcs for more clarity
2019-12-20 12:06:25 -08:00