Commit Graph

2702 Commits (dae5d1efb13a0e9a41c082fc13ba2feb3e1e5a7c)

Author SHA1 Message Date
Anders F Björklund 3e4a0202cb Allow loading image from standard input stream 2021-03-16 19:35:58 +01:00
Anders F Björklund 78bc248a89 Allow running kubectl over the ssh connection
The default is to run kubernetes client locally
2021-03-16 07:45:17 +01:00
Anders F Björklund eec6f05ce0 Don't use the generic path name for a variable
It conflicts with the system "path" in module
2021-03-16 07:29:14 +01:00
Steven Powell a369264139 removed isClusterRunning check 2021-03-15 16:41:22 -07:00
Steven Powell 3e38a1954a renamed OutputMinikubeLogs to OutputOffline 2021-03-15 16:33:39 -07:00
Steven Powell eb8f7e65b9 Show last start and audit logs on `minikube logs` if minikube not running 2021-03-15 15:43:11 -07:00
Yanshu Zhao 4072ea7a93 Add header file 2021-03-15 06:37:06 +00:00
Yanshu Zhao 91f9bd6ef9 Add webhook to inject env to redirect inner cluster requests to haproxy
in auto-pause
2021-03-15 05:56:44 +00:00
Anders F Björklund ea1d023c8a Allow loading more than one image at a time
They need to all be cached or all be local, though.
If one appears to be local, then assume that all are.
2021-03-13 14:43:18 +01:00
Anders F Björklund 0d99d18803 Allow loading local images as well as from cache
Previously only allowed loading from daemon or remote
via the cache, and not directly from local tarball.
2021-03-13 14:43:15 +01:00
Medya Ghazizadeh ff0e25ada8
Merge pull request #10793 from afbjorklund/kubectl-cluster
minikube kubectl: The --cluster flags should be prepended
2021-03-12 14:18:21 -08:00
Medya Gh 67172b636c break down usage for no profile found 2021-03-12 12:29:23 -08:00
Anders F Björklund e8a35de28e The --cluster flags should be prepended
Not appended, because it will break exec
2021-03-12 08:39:41 +01:00
jjkiely e2d08bbd06 Updated more information section of validateChangedMemoryFlags function with correct, working link 2021-03-11 16:19:15 +00:00
Medya Ghazizadeh 5147ef3554
Merge pull request #10730 from sharifelgamal/auth-gce
auto-detect gce and do not enable gcp auth addon
2021-03-10 15:26:34 -08:00
Medya Ghazizadeh b3b4807ed8
Merge pull request #10760 from yxxhero/master
add validateImageRepository func for validates --image-repository args
2021-03-10 13:30:44 -08:00
Medya Ghazizadeh df7cb644af
Merge pull request #10763 from afbjorklund/silent-shell
Silent output when talking to a shell
2021-03-10 13:26:41 -08:00
yxxhero f65333730c add unittest for validateImageRepository and optimize validateImageRepository 2021-03-10 13:28:43 +08:00
Medya Ghazizadeh 05bc047dd1
Merge pull request #10732 from afbjorklund/kubectl-mustload
The cluster doesn't have to be healthy for kubectl
2021-03-09 16:46:03 -08:00
Medya Ghazizadeh 5beacff48f
Merge pull request #10734 from afbjorklund/kubectl-crash
Need to exit if unable to cache kubectl
2021-03-09 16:45:26 -08:00
Sharif Elgamal a3544ae90a create detect package 2021-03-09 15:11:54 -08:00
Sharif Elgamal 15c44bf7ac reorganize addons to make force flag more generic 2021-03-09 13:32:09 -08:00
Anders F Björklund 5e566d3039 Silent output when talking to a shell
If the output is not a terminal, then assume that we are running
docker-env or podman-env under "eval" or similar shell construct.

So don't output all the interactive information, but only return
the actual exit code for some further troubleshooting (perhaps).
2021-03-09 17:59:26 +01:00
yxxhero 416f92a8b5 add validateImageRepository func for validates --image-repository args 2021-03-09 13:47:36 +08:00
Sharif Elgamal e6cb33fa6d oh dear global variable 2021-03-08 12:15:05 -08:00
Sharif Elgamal d12afd6ae5 Merge branch 'master' of github.com:kubernetes/minikube into auth-gce 2021-03-08 12:07:28 -08:00
Sharif Elgamal 5a5abedb3e support force in addons enable command 2021-03-08 08:47:39 -08:00
anencore94 109b1e0fe2 make cp commmand allow target path as absolutepath
- only absolute path is allowed

Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2021-03-08 10:51:15 +09:00
anencore94 76f3c72e82 [Feature] Add minikube cp command
- add new feature represents cp local file into minikube
- add functional test for cp command

Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2021-03-08 10:51:15 +09:00
Medya Ghazizadeh 3760bf765e
Merge pull request #10735 from Loyen/correct-message-spelling
Correct spelling in --insecure-registry validation error message
2021-03-06 14:30:55 -08:00
Patrik Freij a39238ece2 Correct spelling of "Expected formats" 2021-03-06 13:30:02 +01:00
Anders F Björklund d5a69dc10e Need to exit if unable to cache kubectl 2021-03-06 13:00:27 +01:00
Anders F Björklund eb89c8a56f Use the default k8s version if there is no profile
The "mustload" module will abort without a profile
2021-03-06 12:42:00 +01:00
Anders F Björklund 651c81df14 The cluster doesn't have to be healthy for kubectl
We only want to match the kubectl version with it
2021-03-06 09:48:04 +01:00
Medya Ghazizadeh 0f4405798a
Merge pull request #10712 from prezha/kvm-check-libvirt-perms
kvm: provide solution if user doesn't belong to libvirt group
2021-03-05 22:19:32 -08:00
Medya Ghazizadeh d2cb052fca
Merge pull request #10653 from Loyen/add-listen-address-flag
Add flag "--listen-address" for docker and podman driver
2021-03-05 12:56:22 -08:00
Predrag Rogic c3cd3bc500
kvm: check if user belongs to libvirt group 2021-03-04 01:33:01 +00:00
Steven Powell cf23cb12cc changed one more Styled back to Step 2021-03-02 17:23:43 -07:00
Steven Powell a2989a119e reverted actions from Styled to Step 2021-03-02 17:23:43 -07:00
Steven Powell e9d16eb42d replaced non-step logging with Styled 2021-03-02 17:23:43 -07:00
Patrik Freij 29a7145e9d Add podman support for --listen-address 2021-03-02 20:59:27 +01:00
phantooom 529881e01c fix: fix kvm2 numa simulate ut&lint 2021-03-02 22:40:42 +08:00
phantooom badc5d4532 add more check for kvm2 support simulate numa node 2021-03-02 22:27:26 +08:00
phantooom e11f23a4c9 kvm2 driver support simulate numa node 2021-03-02 22:27:26 +08:00
Patrik Freij 21636a5466 Move docker only flag to its own area
Confusing to keep it under "docker & podman" when it's only for docker.
2021-03-01 21:52:42 +01:00
Patrik Freij ca81de183f Add --listen-address validation 2021-03-01 21:08:59 +01:00
bharathkkb 015b721f17 feat: add default log_file name
add max log size, add tests, update website docs

fix func comments

address comments

fix docs

fail fast

add tests to TestErrorSpam, switch to using log
2021-02-28 17:12:22 -06:00
Patrik Freij 98633b7e55 Remove unnecessary fmt.Sprintf usage 2021-02-28 23:30:26 +01:00
Patrik Freij cb116e4c1c Add --listen-address for docker driver 2021-02-28 23:14:08 +01:00
Priya Wadhwa fd506460b3 Add README for mkcmp 2021-02-26 13:00:19 -08:00
Medya Ghazizadeh abb403645e
Merge pull request #10617 from ariesliuwei/logche
migrate some logs to structured logging
2021-02-25 11:32:10 -08:00
Medya Ghazizadeh 80219cfa70
Merge pull request #10616 from ariesliuwei/logmod
Migrate kubectl logs to structured logging
2021-02-25 11:31:30 -08:00
Medya Ghazizadeh 33146eac8e
Merge pull request #10615 from ariesliuwei/ari-logfix
Migrate kubectl logs to structured logging
2021-02-25 11:30:50 -08:00
liuwei10 5788d43116 Migrate some logs to structured logging 2021-02-25 18:59:21 +08:00
liuwei10 6ea237047b Migrate kubectl logs to structured logging 2021-02-25 18:47:40 +08:00
liuwei10 f939910a94 Migrate kubectl logs to structured logging 2021-02-25 17:41:38 +08:00
Medya Ghazizadeh 828769b816
Merge pull request #10606 from spowelljr/fixOutOfRange
Check for args length to prevent out of bounds panic
2021-02-24 16:33:09 -08:00
Steven Powell c50bdaabfe Check for args length to prevent out of bounds panic 2021-02-24 16:45:24 -07:00
Medya Gh 4a6f00ba4b add todo with issue numbers 2021-02-24 13:15:36 -08:00
Medya Gh 73772286eb address review comments 2021-02-24 13:07:25 -08:00
Medya Gh 1bd0b6daae add final touch 2021-02-24 12:30:06 -08:00
Medya Gh a162f26f4a spell 2021-02-24 12:30:06 -08:00
Medya Gh 8739e20fef update addon name 2021-02-24 12:30:06 -08:00
Medya Gh 21d9f50e9c adding channels 2021-02-24 12:30:06 -08:00
Medya Gh 191e116d04 autopause prototype 2021-02-24 12:30:06 -08:00
Medya Gh 44a256bc53 add auto-pause binary 2021-02-24 12:30:06 -08:00
Medya Ghazizadeh 460342a5f2
Merge pull request #10575 from hetong07/issue_10519
Improve the error message of setting cgroup memory limit.
2021-02-24 11:53:54 -08:00
Steven Powell 34db47e956
Merge pull request #10465 from spowelljr/addLastStart
Add last start logs to minikube logs output
2021-02-24 10:52:26 -07:00
priyawadhwa 57d33de86a
Merge pull request #10554 from afbjorklund/drivers-default
Don't select Discouraged or Obsolete by default
2021-02-23 17:21:23 -08:00
priyawadhwa 2ef49ae05c
Merge pull request #10321 from BLasan/issue-8040
Move DeletePossibleKicLeftOver function to delete pkg
2021-02-23 17:15:50 -08:00
hetong07 56cf965a7b Rename validateMemoryFlags() -> validateChangedMemoryFlags(). 2021-02-23 16:16:22 -08:00
Steven Powell f0902d4ba5 improved func comment 2021-02-23 16:54:00 -07:00
Steven Powell 7098409bdc optimized file/dir creation logic 2021-02-23 16:51:40 -07:00
Steven Powell 48652fa952 moved import comment 2021-02-23 15:12:21 -07:00
Steven Powell 6794f2055d removed duplicate flag check 2021-02-23 15:04:56 -07:00
Steven Powell b42f8f6af2 Create logs directory if it does not exist 2021-02-23 15:03:04 -07:00
hetong07 abe7d71aee Only validate cgroup memory setting when using container as driver. 2021-02-22 23:14:17 -08:00
hetong07 9a30756d38 Improve the error message of setting cgroup memory limit. 2021-02-22 20:18:22 -08:00
Anders F Björklund 4e4a59901c Don't select Discouraged or Obsolete by default
These drivers require either an active choice (opt-in),
or a previous configuratio (for the warning message).
2021-02-21 18:18:43 +01:00
BLasan 03ae2d2aa3 Fix Rsrc Insufficient System memory issue 2021-02-21 22:46:23 +05:30
Medya Ghazizadeh 9d9aeccf23
Merge pull request #10535 from BLasan/issue-10143
Fix minikube kubectl context switching
2021-02-20 10:06:05 -08:00
BLasan 01d47d6141 Fix minikube kubectl context switching 2021-02-20 16:37:15 +05:30
Medya Ghazizadeh 77e9751229
Merge pull request #10493 from kadern0/issue-8790
Improved insecure registry validation function
2021-02-19 16:22:00 -08:00
Steven Powell 610a97067f Fixed failing if lastStart.txt file does not exist 2021-02-19 13:54:10 -07:00
Steven Powell f390d1ef0b Output last start logs during minikube logs 2021-02-19 13:54:02 -07:00
Steven Powell 91e8c0980b Save start logs to lastStart.txt in minikube dir 2021-02-19 13:51:44 -07:00
Pablo Caderno 6934c85451 Improved insecure registry validation function 2021-02-17 18:06:00 +11:00
Medya Ghazizadeh 27d86a421f
Merge pull request #10388 from BLasan/issue-10386
Add condition to check --cpus count with available cpu count
2021-02-12 12:48:33 -08:00
Medya Ghazizadeh 350f8a2494
Merge pull request #10452 from ilya-zuyev/ilyaz/disable_hyperv_on_m1
Disable all drivers except "docker" and "ssh" on darwin/arm64
2021-02-11 17:10:10 -08:00
BLasan 5c5c2169bc Rename profile.go file as delete.go 2021-02-12 00:13:41 +05:30
BLasan bb80fe355a Rebase changes in PR #10332 2021-02-12 00:13:41 +05:30
BLasan 707e2e969b Move DeletePossibleKicLeftOver function to profile pkg 2021-02-12 00:10:52 +05:30
Medya Ghazizadeh 3512e88020
Merge pull request #10435 from afbjorklund/podman-cleanup
Explicitly remove podman volume and network
2021-02-11 10:27:50 -08:00
Ilya Zuyev a99d545a54 Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message 2021-02-10 17:06:20 -08:00
Ilya Zuyev 3caf9c0f05 Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message 2021-02-10 17:05:16 -08:00
Medya Ghazizadeh a3609d3778
Merge pull request #10380 from daehyeok/profile_list_light
Add -l/--light option for profile list command.
2021-02-10 17:04:39 -08:00
Ilya Zuyev af5b44df12 Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message 2021-02-10 17:03:53 -08:00
Medya Ghazizadeh 984b079821
Merge pull request #10412 from sharifelgamal/crio
remove crio restart hack
2021-02-10 16:55:44 -08:00
Ilya Zuyev 7536f4436c Fix build constraints 2021-02-10 16:15:28 -08:00
Ilya Zuyev d7beb72025 disable hyperkit driver on arm64 2021-02-10 13:47:46 -08:00
Anders F Björklund b7de621033 Explicitly remove podman volume and network
The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)
2021-02-10 20:57:20 +01:00
priyawadhwa 09de7ff62f
Merge pull request #10332 from priyawadhwa/delete-timeout
Add 5 minute timeout to deleting a profile
2021-02-10 10:40:32 -08:00
Daehyeok Mun f457bde02d Add -l/--light option for profile list command.
If option is true, Doens't try to get profiles from container and read
current status.
2021-02-09 16:06:09 -08:00
priyawadhwa 51ec098b05
Merge pull request #10366 from priyawadhwa/mk-image-load
Implement minikube image load command
2021-02-09 14:42:31 -08:00
Priya Wadhwa e8945f2934 Add warning for cache add 2021-02-09 13:36:40 -08:00
Priya Wadhwa 6ed56d842e Rename to delCtx 2021-02-09 10:51:51 -08:00
Sharif Elgamal 57ffa272c9 remove crio restart hack 2021-02-08 16:28:05 -08:00
Priya Wadhwa 53dad6a4ae fix log 2021-02-08 15:26:04 -08:00
Priya Wadhwa 8f02a5851e Time everything via context 2021-02-08 15:24:41 -08:00
Priya Wadhwa 51169d68ea Add context to remaining necessary functions 2021-02-08 15:19:01 -08:00
Priya Wadhwa a6372b35a3 Add 5 minute timeout to deleting leftover cvolumes and containers 2021-02-08 15:15:08 -08:00
Priya Wadhwa 9b147f788d Merge branch 'master' of https://github.com/kubernetes/minikube into delete-timeout 2021-02-08 14:56:13 -08:00
BLasan 948178711b Add advice message to increase cpus 2021-02-08 23:22:48 +05:30
Medya Ghazizadeh 1c8944f790
Merge pull request #10395 from govargo/fix-metallb-addon
Fix configuration of the metallb with empty load balancing IP range
2021-02-08 09:12:48 -08:00
Medya Ghazizadeh 262d102ceb
Merge pull request #10354 from hetong07/issue_10311
Provide advice when running windows binary (.exe) inside WSL
2021-02-08 09:05:54 -08:00
hetong07 bdac73d2fd Put the environment check as a separate if-else clause, and make this check as early as possible. 2021-02-07 17:37:01 -08:00
Kent Iso b1030dc28a Fix configuration of the metallb with empty load balancing IP range 2021-02-07 23:43:05 +09:00
BLasan cc2bf6aa15 Add condition to check --cpus count with available cpu count 2021-02-07 01:08:08 +05:30
Priya Wadhwa 9a9c160b3f Move load test into functional test 2021-02-05 14:28:25 -08:00
Priya Wadhwa 22a65a0c12 Add --all flag to 2021-02-05 10:48:08 -08:00
Priya Wadhwa 0061d72be6 Merge branch 'master' of https://github.com/kubernetes/minikube into mk-image-load 2021-02-05 10:24:23 -08:00
Priya Wadhwa 1d63f085e4 Add command 2021-02-04 14:45:27 -08:00
hetong07 6d8804e10e Use the 'ExProgramUnsupported' as the error code for MK_WRONG_BINARY_WSL error. 2021-02-03 18:29:13 -08:00
hetong07 547f506701 Rephrase the adivce, use the runtime.GOOS to check whether it is .exe binary and modify the error name to address comments in pull request. 2021-02-03 18:06:05 -08:00
hetong07 289bf2fe84 Merge branch 'master' into issue_10311 2021-02-03 17:41:15 -08:00
ilya-zuyev a7489c1bba
Merge pull request #10309 from afbjorklund/ssh-address
Make sure that ssh driver gets an ip address
2021-02-03 11:17:07 -08:00
hetong07 ad08087b44 Allow user to use --force to run windows binary inside WSL. 2021-02-02 23:48:14 -08:00
Priya Wadhwa 0a0f39a112 Implement minikube image load command 2021-02-02 15:47:07 -08:00
Medya Ghazizadeh d97418828d
Merge pull request #10119 from daehyeok/profile_name
Don't allow profile names that conflict with a multi-node name
2021-02-02 15:12:57 -08:00
Anders F Björklund 21206402a9 Check that the ssh-ip-address is a valid IP 2021-02-02 08:36:05 +01:00
Priya Wadhwa 4bda151a62 Fix delete var 2021-02-01 12:47:46 -08:00
Priya Wadhwa d02eabb835 Add 2 minute timeout to deleting a profile 2021-02-01 12:44:43 -08:00
hetong07 276ad6c7c7 First step to address #10311: disallow running minikube.exe insided WSL. 2021-01-31 12:34:05 -08:00
Anders F Björklund f94cb815cf Make sure that ssh driver gets an ip address 2021-01-29 17:12:23 +01:00
Daehyeok Mun a00d632930 Check profile, node name to prevent duplication
Check profile and node name before add to prevent conflict with
machine name on multinode cluster.
2021-01-28 14:42:40 -08:00
Ling Samuel 101d39fc51
Addon custom registry:
* fix missing suffix when using global image repo
* support override global image repo
* change all imagePullPolicy to IfNotPresent
* fix empty global image repo suffix

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:08 +08:00
Ling Samuel 52f0e49a1e
Fix docker.io/ prefix
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:07 +08:00
Ling Samuel de3c901c18
Implement all addons
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:07 +08:00
Ling Samuel b949034e1a
Manage addon images in code, support custom addon images
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:00 +08:00
Medya Ghazizadeh 597091d84b
Merge pull request #10106 from spowelljr/userFlag
Add new flag --user and to log executed commands
2021-01-26 15:44:58 -08:00
Priya Wadhwa 24aefaebb6 Unhide --schedule flag for scheduled stop 2021-01-26 13:05:30 -08:00
Anders F Björklund 7e9d58c468 The gopsutil cpu implementation changed in v3
Was supposed to return the number of vCPU (i.e. nproc)
Before, both "physical" and "logical" returned the same.

The returned information should match cpuinfo and lscpu:
    CPU(s) = Socket(s) x Core(s) each x Thread(s) each
2021-01-26 17:48:52 +01:00
Steven Powell 5058ef3e71 moved username validation to cmd 2021-01-25 10:57:52 -07:00
Steven Powell 81ac8a1677 fixed user name warning possibly not matching what was checked 2021-01-25 09:45:49 -07:00
Steven Powell 14bcd9ddec added user flag validation and improved some test messages 2021-01-22 15:39:15 -07:00
Priya Wadhwa b2623d4d4e make a default container runtime constant so that it is easy to change in the future 2021-01-22 14:00:47 -08:00
Thomas Stromberg 38b74f1910 Merge branch 'master' into docker-info-err 2021-01-21 18:25:59 -08:00
Thomas Stromberg 6b8469e971 Split PROVIDER_DOCKER_NOT_RUNNING into more specific reason codes 2021-01-21 18:25:45 -08:00
Steven Powell 82f7df5b56 Add user flag and log executed commands 2021-01-20 17:30:48 -07:00
Anders F Björklund fc8ef79c37 Avoid warning about the suggested memory size
The recommendation is to use (at least) 2048 MB *for the VM*,
which means that you will end up something like 1992 MB total.
We should not issue warnings when using the recommended size,
so lower the limit to 1900 MB (kubeadm will validate 1700 MB).

The reason it is broken is because it uses different values
for different drivers, if running a VM or on Bare Metal...
There is also no difference anymore between the "usable"
and the "recommended", so this will need revisiting later.
2021-01-20 20:20:13 +01:00
Anders F Björklund 541193c945 Address review comments, rename to ssh-ip-address 2021-01-16 14:44:56 +01:00
Anders F Björklund 4611e2fe76 Merge branch 'master' into generic 2021-01-16 14:34:04 +01:00
Medya Ghazizadeh 8b76fa2c46
Merge pull request #10126 from medyagh/extension_context
add  annotation to kubeconfig to identify contexts/clusters created by minikube
2021-01-14 17:23:17 -08:00
Thomas Stromberg c6a27bd9ea Merge to master 2021-01-14 14:22:55 -08:00
Medya Gh 5ddf54b32f refactor to make testable 2021-01-14 10:01:35 -08:00
Anders F Björklund abb556f7f5 Merge branch 'master' into generic 2021-01-13 20:15:17 +01:00
Medya Ghazizadeh 787591a6a2
Merge pull request #10109 from lingsamuel/fix-docker-env
Ignore non-socks5 ALL_PROXY env var when checking docker status
2021-01-12 13:50:46 -08:00
Anders F Björklund b2121eae39 Rename the generic driver to the ssh driver
Now that we have forked the machine driver
2021-01-09 14:36:32 +01:00
Thomas Stromberg 6ec94aa064 Merge to master 2021-01-08 15:40:24 -08:00
Thomas Stromberg 66a671fc86 Experimental macOS/arm64 work 2021-01-08 15:38:31 -08:00
Daehyeok Mun 36d94a2d88 Migrate MachineName function.
Migrate MachineName function from driver package to config package.
2021-01-08 11:26:10 -08:00
Anders F Björklund d51443bee1 Show remote host info and proper progress 2021-01-08 16:38:27 +01:00
Anders F Björklund 39218369c0 Improve help text for generic driver flags 2021-01-08 07:55:28 +01:00
Anders F Björklund 749843248e Merge branch 'master' into generic 2021-01-08 07:53:49 +01:00
Ling Samuel e127bc23fe
Ignore non-socks5 ALL_PROXY env var when checking docker status
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-08 12:04:36 +08:00
priyawadhwa 857e0a2089
Merge pull request #10100 from priyawadhwa/force-systemd-containerd
Add support for systemd cgroup to containerd runtime
2021-01-07 11:26:50 -08:00
Priya Wadhwa 0b522445ad update flag and documentation 2021-01-06 14:38:15 -08:00
Anders F Björklund 72a0fd6642 Move the constants for flag defaults from drivers
Not using the default libmachine drivers anymore
2021-01-06 20:24:50 +01:00
Anders F Björklund a3b3b55ac0 Add helper for checking the generic driver name 2021-01-06 18:18:00 +01:00
Anders F Björklund 2b5c5b9202 Try to uninstall kubernetes on delete, for generic 2021-01-06 18:03:46 +01:00
Anders F Björklund c07666957a Don't download ISO for the generic VM driver 2021-01-06 18:03:46 +01:00
Anders F Björklund 00763352b6 Add minikube support for the "generic" VM driver
This driver connects to an already existing virtual machine,
using the provided IP address and SSH user/key/port parameters.

On this machine, libmachine will provision the docker daemon
and minikube will bootstrap the kubernetes cluster (as usual).
2021-01-06 18:03:43 +01:00
Yanshu Zhao 7fa6d545d7 Change warning 2021-01-04 07:31:41 +00:00
Yanshu Zhao 58dedbbb18 Delete the existing cluster if guest driver mismatch 2021-01-02 08:35:02 +00:00
Medya Ghazizadeh 6d763a1cc7
Merge pull request #9955 from daehyeok/delete_machine_dirs
Delete subnode's machine directories
2020-12-30 22:23:20 -08:00
Medya Ghazizadeh 3dac483db9
Merge pull request #10028 from azhao155/yzhao/fix/dockerEnvLog
Change exit to warning if can't restart docker in docker-env cmd
2020-12-23 18:00:19 -08:00
Daehyeok Mun b11190c64e Delete subnode's machine directories 2020-12-23 14:06:26 -08:00
Priya Wadhwa e210a72bfa update warning 2020-12-23 14:03:10 -08:00
Priya Wadhwa 322efcb406 Merge branch 'master' of https://github.com/kubernetes/minikube into network-flag 2020-12-23 14:02:22 -08:00
Medya Ghazizadeh 9a0be2e2d2
Merge pull request #10037 from afbjorklund/kubeadm-memory2
The kubernetes memory requirement is for the total
2020-12-23 13:53:05 -08:00
Anders F Björklund 402d31b195 The kubernetes memory requirement is for the total
The kernel will reserve some memory for itself, so if you want
1700 MB free you need to allocate 1800 MB for the VM hardware.

The recommendation is still 2048 (or 2000), with an even 2.0 GiB.
So let's increase the old values with +100, for ~60 overhead.
2020-12-23 22:32:56 +01:00
Yanshu Zhao 68181145bd Add error in the log 2020-12-23 21:05:43 +00:00
Medya Ghazizadeh f68005724c
Merge pull request #9958 from tstromberg/vmwarefusion
Remove obsolete 'vmwarefusion' driver, add friendly message
2020-12-23 12:56:05 -08:00
Anders F Björklund 1413d267b2 The kubeadm bootstrapper now requires 1700M mem
The node requirement is 2 vCPU and 2.0 GiB RAM

You can use --force to bypass the requirement
2020-12-23 21:09:30 +01:00
Yanshu Zhao 6460b61b75 Change exit to warning if can't restart docker in docker-env cmd 2020-12-23 01:48:26 +00:00
Priya Wadhwa 81f00fc3e3 update description 2020-12-21 16:58:49 -08:00
Medya Ghazizadeh 167b6c4399
Merge pull request #10021 from azhao155/yzhao/feature/dockerEnvWaitForApiServerFixCommits
Replace fixed time wait with wait function for docker-env cmd
2020-12-21 16:18:14 -08:00
Medya Ghazizadeh c300a0545a
Merge pull request #9977 from kadern0/issue-8790
Added validation for --insecure-registry values
2020-12-21 16:17:14 -08:00
Yanshu Zhao 3172a6ddfc change log level and change wait function to private 2020-12-21 23:19:41 +00:00
Yanshu Zhao f698ccb52d Increase time out to 30 s 2020-12-21 20:36:34 +00:00
Yanshu Zhao 96104205af fix lint 2020-12-21 20:35:49 +00:00
Yanshu Zhao bb83ce154e Fix lint 2020-12-21 20:34:33 +00:00
Yanshu Zhao a31b851b31 docker-env cmd wait for api server to be up 2020-12-21 20:32:03 +00:00
Pablo Caderno dbbe06664c Added validation for --insecure-registry values
Fixes 8790
2020-12-20 10:00:17 +11:00
Sharif Elgamal 53d59d2c82 remove experimental warning for multinode 2020-12-17 11:13:46 -08:00
Thomas Strömberg 78163cfb90
Merge pull request #9630 from afbjorklund/ssh-host
Add ssh-host command for getting the ssh host keys
2020-12-17 08:09:29 -08:00
Priya Wadhwa 55f496492c fix merge conflict 2020-12-16 10:37:51 -08:00
Thomas Strömberg fdab252f4f
Merge pull request #9873 from lingsamuel/node-param-for-ip-and-ssh-key
Add --node option for command `ip` and `ssh-key`
2020-12-16 08:17:24 -08:00
Thomas Stromberg e5f06a1f13 Remove the vmwarefusion driver 2020-12-14 11:10:43 -08:00
AUT0R3V 375d25db07
Update start_flags.go
Using slicing technique in the place of an Array for line 141.
2020-12-14 15:12:12 +05:30
Anders F Björklund 7822a4e36e Add option to add the ssh-host key to known_hosts
This matches the ssh-add command for identity keys,
it will add the host key to the ssh known_hosts file.

If a ssh key for the host already exists in the file,
it will not be added again so can be run multiple times.
2020-12-12 18:54:33 +01:00
Anders F Björklund a387989c72 Add ssh-host command for getting the ssh host keys
This is similar to the existing minikube "ssh-key" command, but gets
the content of the host key instead of the path to the identity key.

The output of this command can be added to the ~/.ssh/known_hosts,
for strict host key authentication. For instance when using Docker.
2020-12-12 18:54:33 +01:00
Thomas Stromberg dbdbad6e69 Remove obsolete mention of kvm driver, fixes generate-docs issue 2020-12-11 12:43:18 -08:00
Thomas Strömberg 86b9397910
Merge pull request #9888 from tharun208/feat/kubeconfig_status_name
added statusName for kubeconfig
2020-12-11 10:20:33 -08:00
Medya Ghazizadeh e96b05e45e
Merge pull request #9875 from sadlil/kindnet-podcidr
Fix multi node two pods getting same IP and nodespec not having PodCIDR
2020-12-10 16:53:29 -08:00
Sadlil fc10bca4ae Enable KindNet CNI only if multi node is specified 2020-12-10 18:40:20 +00:00
Sharif Elgamal 48c5d2a03d
Merge pull request #9833 from lingsamuel/fix-node-start-master
Fix `node start` master node
2020-12-09 14:08:14 -08:00
Medya Ghazizadeh 877f1553d8
Merge pull request #9548 from afbjorklund/docker-env-ssh
Optionally use ssh for docker-env instead of tcp
2020-12-09 12:22:17 -08:00
Sharif Elgamal 6be118fc29
Merge pull request #9634 from dekkers/saving-extra-config
Fix --extra-config when starting an existing cluster
2020-12-09 11:27:03 -08:00
Thomas Strömberg c0a092e6af
Merge pull request #9379 from Git-Jiro/none_driver_nonroot
Make none driver work as regular user (use sudo on demand)
2020-12-09 10:21:49 -08:00
Tharun af3f1cfe38 added statusName for kubeconfig
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-09 11:08:15 +05:30
priyawadhwa 83f9bd1df3
Merge pull request #9793 from tharun208/feat/show_scheduled_stop_status
feat(minikube) display scheduledstop status in minikube status
2020-12-08 11:42:06 -08:00
Medya Ghazizadeh 3e670f24e0
Merge pull request #9789 from tharun208/fix/config_memory
fix unable to set memory in config
2020-12-08 10:29:11 -08:00
Medya Ghazizadeh 0898ca21e4
Merge pull request #9801 from afbjorklund/podman-env-existing
Add support for restoring existing podman env
2020-12-08 10:25:50 -08:00
Ling Samuel b9eedce002
Add -n, --node option for `ip` and `ssh-key` 2020-12-07 15:59:49 +08:00
Ling Samuel 278f44899e
Fix `node start` master node 2020-12-07 09:30:35 +08:00
Anders F Björklund 45befa0c1d Merge branch 'master' into docker-env-ssh 2020-12-05 13:07:29 +01:00
Tharun 4ca4491124 fixed review feedbacks on clusterstate field and tests
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:34:14 +05:30
Tharun 3f57033c60 added timetostop status in cluster layout 2020-12-05 14:33:39 +05:30
Tharun 81e27dd7b4 fixed review feedbacks
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:33:39 +05:30
Tharun 1b2076122e feat(minikube) display scheduledstop status in minikube status
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:33:39 +05:30
Anders F Björklund cd683b3ab5 Fix whitespace issues for goimports 2020-12-05 09:47:29 +01:00
Medya Ghazizadeh 114faa7d97
Merge pull request #9797 from msedzins/issue_9335
Ability to use a custom TLS certificate with the Ingress
2020-12-04 12:45:51 -08:00
Priya Wadhwa f373155d55 merge conflict 2020-12-03 10:56:41 -08:00
Ling Samuel 8c2e03b2a7
Fix missing InitialSetup in `node start`
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2020-12-03 11:22:44 +08:00
Medya Ghazizadeh 8fc54b430b
Merge pull request #9716 from afbjorklund/podman-network
Add private network implementation for podman
2020-12-02 14:16:41 -08:00
msedzins e1aa07feb2 Ability to use a custom TLS certificate with the Ingress
Tutorial added
2020-11-30 22:53:27 +00:00
priyawadhwa d83b868b4f
Merge pull request #9774 from priyawadhwa/cancel-stop
Add --cancel-scheduled flag to cancel all existing scheduled stops
2020-11-30 10:03:48 -08:00
Anders F Björklund dae980a355 Add support for restoring existing podman env
If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)
2020-11-29 22:56:47 +01:00
Jeroen Dekkers 1490562c2a Fix --extra-config when starting an existing cluster 2020-11-29 12:44:15 +01:00
Tharun 5b8670c4e9 fix unable to set memory in config
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-11-27 01:22:02 +05:30
Martin Schimandl 64729fb03a Remove function 'NeedsRoot' 2020-11-26 19:54:13 +01:00
Sharif Elgamal 2a5289cd00 reintroduce crio hack for testing 2020-11-25 15:42:55 -08:00
Priya Wadhwa 70cb886a39 shorten flag name to --cancel-scheduled 2020-11-24 17:29:46 -08:00
Priya Wadhwa ad3e4a98d0 Add --cancel-scheduled-stop flag and add to integration test to make sure it works 2020-11-24 11:36:34 -08:00
Anders F Björklund 91890693ee Merge branch 'master' into docker-env-ssh 2020-11-24 20:21:21 +01:00
Priya Wadhwa 63e5021065 Merge branch 'master' of https://github.com/kubernetes/minikube into add-tracing 2020-11-24 10:29:06 -08:00
Medya Ghazizadeh 2dc88c58ea
Merge pull request #9756 from medyagh/docker_env_restart
docker-env: "reload" dockerd service first before "restart" to avoid restarting apiserver container
2020-11-24 10:03:55 -08:00
Medya Ghazizadeh 02511f1c70
Merge pull request #9702 from daehyeok/print_node
Add number of nodes for cluster in `minikube profile list`
2020-11-24 09:57:03 -08:00
Sharif Elgamal ee9b5b4d49 remove restart hack for crio now that iso is fixed 2020-11-23 11:39:43 -08:00
Anders F Björklund 807bec0034 Merge branch 'master' into docker-env-ssh 2020-11-22 21:58:08 +01:00
Anders F Björklund fee0f5310a Add private network implementation for podman
Most of it the same as docker, except for the options.

i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
Daehyeok Mun 97db8b5f4c Add number of nodes for cluster in `minikube profile list`
fixes \#6780
Add the Nodes column with the number of nodes the cluster has into
`minikube profile list` output.
2020-11-21 20:45:08 -08:00
Medya Gh 659e4ce1bd lint 2020-11-20 15:47:02 -08:00
Medya Gh 301b24ab2e lint 2020-11-20 15:45:39 -08:00
Medya Gh b498e6b288 typo 2020-11-20 15:35:04 -08:00
Medya Gh 5a443f09fb try reload dockerd first before restart 2020-11-20 15:31:05 -08:00
Anders F Björklund bf73bcc4fe Merge tag 'v1.15.1' into docker-env-ssh
1.15.1 Release
2020-11-19 17:11:02 +01:00
Priya Wadhwa 5a0ab905ed fix merge conflict 2020-11-17 15:11:23 -08:00
Medya Ghazizadeh 8b39f56a60
Merge pull request #9510 from ilya-zuyev/gh_9463_non_dev_dockerhost
Support non-default docker endpoints
2020-11-17 10:17:33 -08:00