ff051f9a33
Make sure gcp-auth addon can be enabled on startup ( #9318 )
...
* fix documentation for gcp-auth addon
* make sure kube-system pods are up before enabling gcp-auth
* fix lint
* add failurePolicy for webhook
* only install addons if asked
* better comment
* slightly less hacky code
* defer addons properly
* simplify code for performance
2020-09-29 13:29:14 -07:00
fba4de74cf
Merge pull request #8787 from saltbo/master
...
fix error usage for the WaitGroup in the pkg addons
2020-09-01 16:21:51 -07:00
2c5e8fdaee
Add detailed JSON & status codes for all error paths
2020-08-30 17:25:11 -07:00
9c23485dfb
Remove list of alternative drivers
2020-07-29 09:40:43 +01:00
4b2974472d
Improve error message text
2020-07-28 22:40:55 +01:00
b27440d4ae
Add warning for ingress addon with driver of none
2020-07-28 22:40:15 +01:00
85f1c4f2dd
Merge pull request #8792 from concaf/concaf/fix/fix-already-started
...
(Addons) Create a new command in every retry
2020-07-21 14:43:14 -07:00
1b6eee675b
Automated GCP Credentials Addon Prototype ( #8682 )
...
* metadata addon works
* Add code for metadata server image and makefile rules
* remove log message
* update to work with v1.13.11
* update readme
* fix metadata addon stuff for newer codebase
* buncha changes
* just so many changes
* ch-ch-ch-ch-changes
* addon works
* update readme
* boilerplate
* revert unrelated change
* move server code to another repo
* switch addon name to gcp-auth
* metadata -> gcp-auth
* missed one
* automate finding of credentials
* remove unnecessary comment
* address comments
* Update README.md
* Update README.md
* use mustload everywhere
* swap selector condition
* upgrade kube-webhook-certgen to 1.3
* move paths to constants
* add notice to user on addon enable
* adding addon documentation
* move addons documentation inside handbook
* remove old addons docs location
Co-authored-by: Priya Wadhwa <priyawadhwa@google.com>
2020-07-21 14:25:58 -07:00
f42f79e56d
(Addons) Create a new command in every retry
...
Whenever a `kubectl apply` fails while enabling an addon, it is
retried with exponential backoff. The command (type `*exec.Cmd`)
that this retry function runs in created outside the function -
which means that it is reused on every retry. This is a problem
because `exec.Cmd` (https://godoc.org/github.com/pkg/exec#Cmd )
states that "... Cmd cannot be reused after calling its Run or
Start methods."
This retry is a common case due to, say, a CRD and its resource
being present in the same YAML file of the addon which causes
a race condition where the resource is created before its CRD is
created in the cluster - this race is fixed by subsequent retries.
I've noticed this in the dashboard and the ambassador addon.
Due to the above mentioned bug, minikube throws errors like
`exec: already started` in every retry and the retry is never
successful, manifests are never deployed and addon creation errors
out.
Related to #8138 #8119 #8372
2020-07-21 21:20:24 +05:30
e00cf6c1e1
fix error usage for the WaitGroup in the pkg addons
2020-07-21 11:57:06 +08:00
bd94872a10
add additional steps
2020-07-07 14:25:27 -04:00
e829341b9d
improve logging
2020-06-26 15:12:15 -07:00
64553e281b
revert debugging
2020-06-26 15:11:03 -07:00
742dcd6b00
add addon status verification for 3 addons
2020-06-26 15:08:38 -07:00
66421a6492
wait for ingress pod be running
2020-06-26 14:22:17 -07:00
52f4e130b5
lint
2020-06-26 13:20:31 -07:00
5fbf197b18
remove unrelated changes
2020-06-26 13:20:31 -07:00
96781c61a2
remove unrelated changes
2020-06-26 13:20:30 -07:00
058a732909
ingress addon validate deployment after enable
2020-06-26 13:20:30 -07:00
c47854b8fd
add validate ingress
2020-06-26 13:20:30 -07:00
a0c33f82c1
ingress addon wait for it
2020-06-26 13:20:30 -07:00
ab58dca23d
replace to metrics-server in case of `minikube start --addons heapster`
2020-06-13 01:07:16 +09:00
803461ddcf
if the specified addon doesn't exist, skip enabling
2020-06-13 00:46:12 +09:00
6969200dd7
addons: fix initial retry delay, double maximum limit
2020-05-04 12:44:30 -07:00
825ba532d1
Merge pull request #7603 from alonyb/w/add-registery-addon
...
Add registry addon feature for docker on mac/windows
2020-04-17 19:50:43 -07:00
fe4fdeec6c
Merge pull request #7752 from medyagh/node_pressure_redo
...
Check node pressure & new option "node_ready" for --wait flag
2020-04-17 19:45:40 -07:00
4e7429695d
address review comments
2020-04-17 14:07:41 -07:00
3a5406f79e
Unify client creation around kapi.Client
2020-04-17 09:58:14 -07:00
bfa45ef79a
delete unnecesary func
2020-04-16 19:49:26 -05:00
bb327e250d
adjust try
2020-04-16 15:14:59 -07:00
0687e2adc0
defer print addon
2020-04-16 13:39:59 -07:00
a023de61a7
defer printing enabling addons
2020-04-16 13:38:17 -07:00
62904e5dcc
fix lint
2020-04-15 09:30:10 -05:00
338e61bd21
change output message icon
2020-04-11 13:31:51 -05:00
4f86c3e5c8
some adjustments
2020-04-11 00:56:34 -05:00
3bd143037b
change output message
2020-04-10 18:49:54 -05:00
428d9ee911
add new addon
2020-04-10 14:45:43 -05:00
bab824a830
Merge pull request #7559 from tstromberg/cert-err2
...
make CommandRunner.Copy/Remove consistent across runners
2020-04-09 17:31:37 -07:00
bf784d8bf3
Refactor CommandRunner.Copy functions for consistency
2020-04-09 13:24:14 -07:00
1e8801ceb8
Make addons.Start thread-safe
2020-04-08 21:23:35 -07:00
93e6eee2e3
Pass correct variable in
2020-04-08 15:20:30 -07:00
22882089af
Address code review comments
2020-04-08 15:17:14 -07:00
5ce7b4b147
Parallelize post-cluster steps
2020-04-08 12:29:23 -07:00
3f16f27540
less tab
2020-04-02 17:20:25 -07:00
9fd6496743
improve messge
2020-04-02 17:19:45 -07:00
77d2b50087
break down the lines
2020-04-02 17:16:00 -07:00
db00506d67
dont allow enabling ingress addon for docker on mac and windows
2020-04-02 17:00:06 -07:00
ea9aa72984
Retry addon application
2020-03-25 13:44:28 -07:00
196a8d7b82
Delete: output underlying status failure, refactor wordy code
2020-03-13 15:51:03 -07:00
bd627f13e4
Plumb config.ClusterConfig throughout addon validation code
2020-03-10 17:49:47 -07:00
Sharif Elgamal
Thomas Strömberg
Dean Coakley
Medya Ghazizadeh
Shubham
Ambor
Priya Wadhwa
Medya Gh
Kenta Iso
Alonyb