dont allow enabling ingress addon for docker on mac and windows

pull/7393/head
Medya Gh 2020-04-02 17:00:06 -07:00
parent a305b651d0
commit db00506d67
2 changed files with 10 additions and 0 deletions

View File

@ -19,6 +19,7 @@ package addons
import (
"fmt"
"path"
"runtime"
"sort"
"strconv"
"strings"
@ -122,6 +123,11 @@ func enableOrDisableAddon(cc *config.ClusterConfig, name string, val string) err
}
}
// to match both ingress and ingress-dns adons
if strings.HasPrefix(name, "ingress") && enable && driver.IsKIC(cc.Driver) && runtime.GOOS != "linux" {
exit.UsageT("Due to {{.driver_name}} networking limitations on {{.os_name}}, {{.addon_name}} addon is not supported for this driver. meanwhile a different driver such as 'hyperkit' or 'virtualbox' or 'hypev'. To track the update on this feature being worked on please check https://github.com/kubernetes/minikube/issues/7332", out.V{"driver_name": cc.Driver, "os_name": runtime.GOOS, "addon_name": name})
}
if strings.HasPrefix(name, "istio") && enable {
minMem := 8192
minCPUs := 4

View File

@ -18,4 +18,8 @@ The Docker driver is the newest minikube driver. which runs kubernetes in contai
- Cross platform (linux, macos, windows)
- No hypervisor required when run on Linux.
## Known Issues.
- The 'ingress' and 'ingress-dns' addons is only supported on Linux and they are not supported in Docker Driver on MacOS and Windows yet. to get updates on the work in progress please check [issue page](https://github.com/kubernetes/minikube/issues/7332)
- a known [docker issue for MacOs](https://github.com/docker/for-mac/issues/1835), a containers on Docker on MacOS might hang and get stuck while other containers can get created. The current workaround is restarting docker.