Commit Graph

1621 Commits (97dd433702498e9cd8cfa7d8f467f5e86bf81150)

Author SHA1 Message Date
josedonizetti 8b42e28d44 Refactor WriteConfig to accept a path 2019-08-02 21:45:01 -03:00
josedonizetti e14c7d9b1f Fix TestSetCurrentContext to use tmpfile 2019-08-02 21:28:16 -03:00
Thomas Strömberg be61eb7bb1
Merge branch 'master' into cherry-3a96b 2019-08-02 15:04:10 -07:00
Thomas Strömberg aabe45b184
Merge pull request #4959 from tstromberg/distro
UI: Add profile name & distro version to intro, clarify other messages
2019-08-02 15:03:08 -07:00
Thomas Strömberg 6a97242f29
Merge pull request #4958 from tstromberg/style-err
Log the underlying template error
2019-08-02 14:56:29 -07:00
tstromberg 6ac5fe2197 Fix merge conflict 2019-08-02 14:48:21 -07:00
tstromberg e717d46030 Decrease ReasonableStartTime from 10 minutes to 5 minutes 2019-08-02 14:42:57 -07:00
tstromberg 2dd3445176 Add container status and container runtime logs 2019-08-02 14:39:56 -07:00
tstromberg ee6b3da231 Remove 'pods' word 2019-08-02 13:47:34 -07:00
tstromberg 45e9cfba8f Opt for shorter output strings 2019-08-02 11:38:37 -07:00
tstromberg 4b9402fc82 Add host distro to minikube start & guest distro to logs 2019-08-02 11:17:52 -07:00
tstromberg 90b75bbab9 Log the underlying template error 2019-08-02 11:08:42 -07:00
Medya Ghazizadeh f872767afe
Merge pull request #4948 from medyagh/paralell_integration_tests4
refactor integration tests to run in parallel
2019-08-02 00:19:46 -07:00
Medya Ghazizadeh ce98918d8b
Merge pull request #4950 from medyagh/none_stop_improve
Improve driver none stop to work on older systems
2019-08-01 20:17:11 -07:00
Medya Gh fdc3b39e49 lower case errors 2019-08-01 13:52:46 -07:00
Medya Gh 1c8a655154 make none stop work on old systemd 2019-08-01 13:52:16 -07:00
Thomas Strömberg e1c485b1e6
Merge pull request #4898 from RA489/ps
hyperv: Powershell was not found in the path
2019-08-01 12:11:30 -07:00
josedonizetti 760707a5fb Fix lint 2019-08-01 15:08:27 -03:00
josedonizetti 021eaa723d Extract writeConfig 2019-08-01 14:54:47 -03:00
josedonizetti 487c104ab9 Rename test to Test_encode 2019-08-01 14:48:45 -03:00
josedonizetti 4a4ae87e9e refactor: Move WriteConfig to pkg/minikube/config 2019-08-01 14:37:30 -03:00
josedonizetti 358750e2e4 Add UnsetCurrentContext tests 2019-08-01 14:32:26 -03:00
Zoltán Reegn de27472759 Remove ingress-nginx default backend
It's not needed since nginx 0.20.0.

See the following pull-requests for context:
* https://github.com/kubernetes/ingress-nginx/pull/3126
* https://github.com/kubernetes/ingress-nginx/pull/3156
2019-08-01 09:51:30 -07:00
josedonizetti 2614069b43 rename TestGet to Test_get 2019-08-01 09:50:31 -07:00
josedonizetti 6d8e33097c rename TestReadConfig to Test_decode 2019-08-01 09:50:31 -07:00
josedonizetti 02c333084a Add closures_and_goroutines documentation 2019-08-01 09:50:31 -07:00
josedonizetti 58288cfbc2 Add test to config ReadConfig 2019-08-01 09:50:31 -07:00
josedonizetti 27664fe134 Improve UnsetTest 2019-08-01 09:50:31 -07:00
Sharif Elgamal 043ebfe397 Update latest kubernetes version to v1.15.1 2019-08-01 09:50:31 -07:00
josedonizetti 8cc1242601 Add TestSetCurrentContext 2019-08-01 13:20:01 -03:00
RA489 0c7d81c9d1 UI: Advice user when minikube profile is deleted 2019-08-01 07:08:28 +05:30
Medya Ghazizadeh 9916d7a438
Merge pull request #4786 from reegnz/remove-nginx-ingress-default-backend
Remove ingress-nginx default backend.
2019-07-30 14:06:14 -07:00
Medya Ghazizadeh 5add11bb59
Merge pull request #4924 from josedonizetti/rename-config-tests
Improve code readability: rename config unit tests
2019-07-30 14:02:33 -07:00
Medya Ghazizadeh db7d7c87da
Merge pull request #4926 from josedonizetti/add-closures-documentation
Add comment for better clarity of closures_and_goroutines documentation
2019-07-30 13:40:22 -07:00
Medya Ghazizadeh feb7231634
Merge pull request #4925 from josedonizetti/add-readconfig-test
Add test to config.ReadConfig
2019-07-30 13:38:28 -07:00
Medya Ghazizadeh 3a718d9e79
Merge pull request #4922 from josedonizetti/deletes-unset-profile
Unset profile when it is deleted
2019-07-30 13:36:21 -07:00
josedonizetti 190830b827 Add closures_and_goroutines documentation 2019-07-30 16:52:42 -03:00
josedonizetti b436a90db5 Add test to config ReadConfig 2019-07-30 15:53:33 -03:00
josedonizetti a531baa25a rename TestGet to Test_get 2019-07-30 15:23:35 -03:00
josedonizetti f9e00f4195 rename TestReadConfig to Test_decode 2019-07-30 15:22:57 -03:00
Medya Gh 9b3f72024a list vms after clean up 2019-07-30 10:42:55 -07:00
Medya Gh d1a41e0015 Added default profile 2019-07-30 10:40:11 -07:00
josedonizetti 483fe644eb Improve UnsetTest 2019-07-30 14:16:51 -03:00
Thomas Strömberg b309750496
Merge pull request #4915 from sharifelgamal/k8s-1.15.1
Update latest kubernetes version to v1.15.1
2019-07-30 10:03:47 -07:00
Zoltán Reegn d1436b40fe Remove ingress-nginx default backend
It's not needed since nginx 0.20.0.

See the following pull-requests for context:
* https://github.com/kubernetes/ingress-nginx/pull/3126
* https://github.com/kubernetes/ingress-nginx/pull/3156
2019-07-30 09:32:02 +02:00
Sharif Elgamal 98e8dd3921
Update latest kubernetes version to v1.15.1 2019-07-29 13:40:35 -07:00
Medya Ghazizadeh 743aeaa859
Merge pull request #4887 from josedonizetti/fix-glog-parse-error
Fix glog parse error
2019-07-29 13:24:19 -07:00
Thomas Strömberg 128bdfbe27
Merge pull request #4674 from kubernetes/docsy2
Switch documentation site to docsy theme, add sample content
2019-07-29 11:51:48 -07:00
Thomas Strömberg a05a26e039
Merge pull request #4758 from blueelvis/4661-force-poweroff-in-hyperv
hyperv: Run "sudo poweroff" before stopping VM
2019-07-29 10:16:23 -07:00
RA489 23391893e8 hyperv: Powershell was not found in the path 2019-07-29 07:36:19 +05:30
josedonizetti 08c86b4010 Add comment explaining pkg/initflag 2019-07-27 11:05:49 -03:00
josedonizetti 7ece838d28 Add license to pkg/initflag 2019-07-27 11:03:56 -03:00
josedonizetti 42a69a9a27 Add pkg/initflag 2019-07-27 10:40:21 -03:00
Jose Donizetti fe00076341
Revert "Fix flag.Parse error logging" 2019-07-25 23:03:04 -03:00
Medya Ghazizadeh 288024fd53
Merge pull request #4867 from josedonizetti/fix-flag-parse-error-logging
Fix flag.Parse error logging
2019-07-25 14:41:58 -07:00
Medya Ghazizadeh c603300781 more reliable stop for none driver (#4871)
* more reliable stop for none driver

* print stop error

* better error logging

* misspell

* error formatting

* Passing lint interfacer nag
2019-07-25 13:19:21 -07:00
josedonizetti 1480ed224d Add package license 2019-07-25 12:05:11 -03:00
josedonizetti cbefe9936e Fix lint 2019-07-25 11:09:46 -03:00
josedonizetti d7f755d67a Fix flag.Parse error logging 2019-07-25 10:31:30 -03:00
josedonizetti 65ac1e3103 Fix tests 2019-07-24 20:35:53 -03:00
josedonizetti 3ec9b1ed2a Bump k8s.io/kubernetes to 1.15.0 2019-07-24 19:51:40 -03:00
Anders Björklund e22b605e72
Merge pull request #4525 from afbjorklund/distro
Show info about the minikube linux distribution
2019-07-23 12:50:00 +02:00
Jose Donizetti 6a5fbbac34 Warn if hyperkit version is old (#4691)
* Add warn if hyperkit driver version is old

* Add hyperkit upgrade documentation

* Improve kvm/hyperkit upgrade warn message

* Move validateDriverVersion to before downloading ISO

* Change executable to use constants
2019-07-22 15:35:42 -07:00
Jituri, Pranav ed94288ac7 Fixed the code as per review comments 2019-07-20 23:05:46 +05:30
Jituri, Pranav c96a3bf1db Add conditional to poweroff on Hyper-V using SSH 2019-07-20 23:05:45 +05:30
Anders F Björklund d1cca9544c Return empty struct instead of nil pointer
Not very friendly to return nil without error
2019-07-20 12:29:02 +02:00
Anders F Björklund f11fc22d9c Use "OS release" instead of "distribution"
Makes it more clear that it is os-release(5)
2019-07-20 12:28:01 +02:00
Anders F Björklund 60ff459cde Show information about the linux distribution
Taking from /etc/os-release, via libmachine provision

Failure to show it is not fatal, just log an error...
2019-07-20 09:47:31 +02:00
Thomas Stromberg 1ba2cd865f merge conflict 2019-07-19 19:25:32 -07:00
Thomas Stromberg 774832b22f Address boilerplate and mixed content linter issues 2019-07-19 19:23:41 -07:00
Sharif Elgamal 6552436311
Console output cleanup (#4825)
* Console output cleanup

* comment fix

* Fixing out.Out stutter

* Fix invalid template

* Change profile_list.go to new console functions

* more merge stuff
2019-07-19 17:00:51 -07:00
Thomas Strömberg 784717c007
Merge pull request #4813 from tstromberg/cluster_test
Make cluster_test and utils_test run in isolation
2019-07-19 16:48:26 -07:00
Thomas Stromberg 4076eb15d6 Remove unused imports 2019-07-19 16:40:34 -07:00
Thomas Stromberg a9309c3237 Remove unused ParseSHAFromURL function 2019-07-19 16:36:26 -07:00
Thomas Strömberg 042af2a0dc
Merge pull request #4823 from tstromberg/sshutil_test2
Make TestNewSSHClient and ssh_mock race-proof
2019-07-19 16:17:49 -07:00
Medya Ghazizadeh 9f42df6209
Merge pull request #4811 from medyagh/add_profile_list_cmd
Add a new command (profile list)
2019-07-19 15:43:50 -07:00
Thomas Stromberg 251a2147b8 Lint issues 2019-07-19 14:11:16 -07:00
Thomas Stromberg e958850a32 ssh mock: Raise errors rather than log them 2019-07-19 14:04:35 -07:00
Thomas Stromberg 6b3eb21be1 Add cleanup to TestNewSSHClient so that it can survive -race -count=100 2019-07-19 12:57:58 -07:00
Medya Gh a2d4c9e14e using ReadDir instead of walk 2019-07-19 11:16:20 -07:00
Medya Gh 51a19625bc Lint and add optional arg to other loaders 2019-07-19 10:45:56 -07:00
Medya Gh 14fcdaa98b make constant profile funcs more testable 2019-07-19 10:21:47 -07:00
Medya Gh cd80371aad Addded unit test for profile list 2019-07-18 22:13:32 -07:00
tstromberg 6f27d77748 Log command, pass T 2019-07-18 18:26:46 -07:00
Medya Gh b17376cccf Refactor profile, detect invalid profiles 2019-07-18 18:23:26 -07:00
tstromberg 22ae10c267 Remove unused getTestArgs struct 2019-07-18 18:17:19 -07:00
tstromberg a3d32758f8 Add mock.Logf functions to avoid panics 2019-07-18 18:12:48 -07:00
tstromberg 14c67d46a5 Remove TestParseSHAFromURL (not well isolated, takes 30 seconds) 2019-07-18 18:12:28 -07:00
tstromberg 172fa046cf Merge 2019-07-18 17:43:00 -07:00
tstromberg 2b49a8d8d9 Segregate cluster_test from existing profiles 2019-07-18 17:28:17 -07:00
Thomas Strömberg 186d2416be
Merge branch 'master' into translation2 2019-07-18 16:27:52 -07:00
Thomas Strömberg e373639d13
Merge pull request #4809 from tstromberg/template2
Add LowPrefix to Empty style, move to beginning of list
2019-07-18 16:27:16 -07:00
Medya Gh 63a6754f9d Add testdata for profile 2019-07-18 16:17:26 -07:00
Medya Gh 5b22779d99 Add comments 2019-07-18 14:31:11 -07:00
Medya Gh 9efc2f579d Added all profile funcs 2019-07-18 14:29:13 -07:00
Medya Gh 6a08732179 Added profile type 2019-07-18 14:27:35 -07:00
Sharif Elgamal 45974d911d
remove test checking for up to date translation files (#4808) 2019-07-18 13:15:09 -07:00
tstromberg 10d4b295f3 Add LowPrefix to Empty style, move to beginning of list 2019-07-18 13:01:00 -07:00
Medya Gh 7d4532fd1f Remove duplicate style 2019-07-18 11:22:46 -07:00
Medya Gh ed11f3ab0c merge upstream 2019-07-18 10:39:28 -07:00
Medya Ghazizadeh 5178c0b300
Merge branch 'master' into translation_outstyle 2019-07-17 18:12:45 -07:00
Sharif Elgamal 93263bc2bc
Templatizing more calls to console 2019-07-17 18:06:06 -07:00
Medya Gh e49d193cd7 Move up nil check the chain 2019-07-17 17:42:20 -07:00
Medya Gh 4fd0f757af Fix OutT 2019-07-17 17:38:25 -07:00
Medya Gh 97ba8854a6 more translation formatting 2019-07-17 17:37:39 -07:00
Thomas Stromberg 054fc946f1 Pass most tests 2019-07-17 17:13:12 -07:00
Thomas Stromberg cbd7d702ef Merge remote-tracking branch 'upstream/master' 2019-07-17 16:55:06 -07:00
Thomas Stromberg 3d7c657eaf Templated output migration 2019-07-17 16:54:56 -07:00
Medya Gh 4e4eccad30 Added more translation formatting 2019-07-17 16:54:29 -07:00
Medya Gh f57f6d724c linting 2019-07-17 16:28:49 -07:00
Sharif Elgamal b40011b2e3
Add T versions of the console convenience functions (#4796)
* Add T versions of the console convenience functions

* more changes

* Make OutT and ErrT more convenient and add WithCodeT:

* add UsageT

* make extract

* translate messages in displayError
2019-07-17 15:19:49 -07:00
Sharif Elgamal 24ad1d82b9
Add test to make sure translations files are up to date. (#4777)
* Add test to make sure translations files are up to date.

* Fix file path sadness so tests work as expected

* make sure we reset the working dir

* switching from bytes.Compare to cmp.Diff

* add better error message

* extract new localized strings

* fix tests
2019-07-17 13:49:39 -07:00
Medya Ghazizadeh 4178c4486d
Merge pull request #4794 from medyagh/hyperkit_errmap
Add advice if crash on hyperkit not installed
2019-07-17 13:03:27 -07:00
Medya Gh f68764cbc3 Add advice for hyperkit install instead of crash 2019-07-17 12:58:58 -07:00
Thomas Strömberg 3555ae5fb4
Merge branch 'master' into not-an-err 2019-07-17 11:14:32 -07:00
Thomas Strömberg 03fb063281
Merge pull request #4790 from tstromberg/issue-url-chooser
Update github issues URL now that we have issue templates
2019-07-17 11:08:09 -07:00
Anders F Björklund df7922881c Add missing ErrMapFile docs, to make golint happy 2019-07-17 19:40:19 +02:00
Jose Donizetti 6ded92edbe Fix darwin constants 2019-07-17 14:19:40 -03:00
tstromberg 1d3cea757b Update github issues URL to chooser 2019-07-17 09:58:31 -07:00
tstromberg 80fc10167f Merge conflicts 2019-07-17 09:41:53 -07:00
Thomas Strömberg bed7b8eb3e
Merge pull request #4729 from afbjorklund/none-info
Show more relevant information, when using none driver
2019-07-17 09:34:48 -07:00
tstromberg 1dc2afc748 Address more merge conflicts 2019-07-17 09:05:47 -07:00
Thomas Strömberg fe6e2b15e2
Merge pull request #4738 from josedonizetti/move-supported-drivers-per-platform
Move supported drivers per platform
2019-07-17 09:02:37 -07:00
tstromberg d0ae6e9d3b Obsolete driver lint issues 2019-07-16 15:16:51 -07:00
tstromberg 6729f6cfe4 Remove remaining DriverXhyve and DriverKvmOld references 2019-07-16 13:54:24 -07:00
tstromberg 914713f388 Remove deprrecated drivers: kvm-old and xhyve 2019-07-16 13:40:00 -07:00
josedonizetti 2ed16a1198 Move supported drivers per platform 2019-07-16 15:06:55 -03:00
Priya Wadhwa 6f65e3f822 Merge branch 'master' of github.com:kubernetes/minikube into gvisor-image 2019-07-15 17:01:24 -07:00
Sharif Elgamal 941c7d5fb2
moving checks to their relevant stops so unit tests work 2019-07-15 13:38:12 -07:00
Sharif Elgamal 77931fb4e2
Merge branch 'master' of github.com:kubernetes/minikube into extract-advice 2019-07-15 13:36:48 -07:00
Sharif Elgamal a7d5309f8e
fix lint 2019-07-15 11:17:08 -07:00
Anders F Björklund 7584d6aa08 Move hostInfo into function, add error checking 2019-07-14 10:19:54 +02:00
Sharif Elgamal 92bb35137b
Make sure err_map.go exists 2019-07-12 15:28:26 -07:00
Thomas Strömberg 76c456b998
Merge pull request #4739 from sharifelgamal/tmo-extract-test
Use tempfile for extract test
2019-07-12 15:14:53 -07:00
Thomas Strömberg b50aa37407
Revert "Refactor status command" 2019-07-12 14:23:38 -07:00
tstromberg 71ab89dfc2 Reduce kubectl restart time from 10 seconds to 600ms 2019-07-12 09:55:15 -07:00
Priya Wadhwa f55b38ec21 Merge branch 'master' of github.com:kubernetes/minikube into gvisor-image 2019-07-11 16:21:39 -07:00
Anders F Björklund 2b986ef638 Fix golint complaint about new OutT/ErrT functions 2019-07-11 22:03:22 +02:00
Priya Wadhwa 1ec4012052 Merge branch 'master' of github.com:kubernetes/minikube into gvisor-image 2019-07-11 12:43:42 -07:00
Sharif Elgamal f16ae95724 check error value 2019-07-11 12:19:41 -07:00
Kubernetes Prow Robot 65c6f9e5a3
Merge pull request #4686 from josedonizetti/refactor-status-cmd
Refactor status command
2019-07-11 11:54:10 -07:00
Sharif Elgamal c8f9562555 Use tempfile for extract test 2019-07-11 11:53:18 -07:00
Thomas Strömberg 82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
Add space after // comments
2019-07-11 11:53:15 -07:00
Thomas Strömberg b0b13e1a7c
Merge pull request #4545 from marcosdiez/dont_disable_container_engines_when_vmdriver_is_none
Don't disable other container engines when --vm_driver=none
2019-07-11 11:17:57 -07:00
Priya Wadhwa e6653b78eb Build and push the gvisor image, setting an environment variable
which can be picked up during integration testing.

I opted to do it this way because the locally built gvisor image wasn't
being picked up by minikube, because the docker daemon wasn't
configured, since minikube isn't up and running yet. Even if the docker daemon was configured to point to
minikube, we wouldn't be able to build the gvisor-image from the test
itself.
2019-07-10 14:13:17 -07:00
Sharif Elgamal 6c2c00b754
fixing lint 2019-07-10 11:44:49 -07:00
Sharif Elgamal ad4d55f0ad
Merge branch 'master' of github.com:kubernetes/minikube into extract-advice 2019-07-10 10:24:36 -07:00
Sharif Elgamal c92e65ec28
Add templating for proper localization (#4677)
* Add templating for proper localization

* Fixing tests for new translation style

* checking errors is important

* fixing more console tests

* good function names make for happy developers

* add test for OutTemplateStyle

* short function names make for happy developers

* better formatting

* more better variable names
2019-07-10 10:17:28 -07:00
Anders F Björklund fdb4f9b167 Show "localhost" information for none driver 2019-07-10 17:27:55 +02:00
Anders F Björklund 4642b66ebc Don't lie about creating a VM with none driver 2019-07-10 13:47:24 +02:00