Thomas Strömberg
13c3826ead
Merge pull request #3970 from tstromberg/bring_ya_errs_to_the_project_maybe_we_can_solve_it
...
Improve console output for new problems package
2019-03-26 14:44:55 -07:00
Thomas Stromberg
53a246b71c
Fix function name case
2019-03-26 14:42:02 -07:00
Thomas Strömberg
0b21fc317c
Merge pull request #3988 from afbjorklund/typo
...
misspell: Fix minor typo in the problems database
2019-03-26 14:38:12 -07:00
Thomas Stromberg
6f516ff647
Merge branch 'master' into mount-names
2019-03-26 14:30:42 -07:00
Thomas Stromberg
7233a2d50d
Allow mount to work when the uid/gid of docker changes
2019-03-26 14:27:50 -07:00
Anders F Björklund
34a36aeb2a
misspell: Fix minor typo in the problems database
2019-03-26 21:58:55 +01:00
Anders F Björklund
0ebfe462b9
Add --download-only option to start command
...
Make it possible to download files without loading or installing,
and without starting the host... Download: ISO, binaries, images.
2019-03-26 21:43:54 +01:00
Anders F Björklund
54f68e068e
Move the cache functions from kubeadm to machine
2019-03-26 21:43:18 +01:00
Anders F Björklund
adcbcf113b
Refactor: move cache calls into separate functions
...
Need to split out the caching functions, from the loading/copying.
Also need to make the lists accessible from outside the functions.
2019-03-26 21:43:18 +01:00
Anders F Björklund
7530fcba90
Allow both tag and digest, for the cache images
2019-03-26 21:29:44 +01:00
Thomas Strömberg
646949004c
Merge pull request #3976 from tstromberg/in_style
...
Rename MINIKUBE_IN_COLOR to MINIKUBE_IN_STYLE
2019-03-26 13:29:25 -07:00
Anders F Björklund
bec7074fe7
Update go-containerregistry library
2019-03-26 21:29:06 +01:00
Thomas Stromberg
9c3488a26f
Make flag substitution cleaner, update tests
2019-03-26 13:04:58 -07:00
Thomas Stromberg
d4edae2d8c
Fix tests than broke with the merge against master
2019-03-26 12:57:19 -07:00
Thomas Strömberg
b26a93e4ee
Merge branch 'master' into v1.14-tmpl
2019-03-26 12:48:54 -07:00
Thomas Stromberg
c861ab7dc1
Switch mount ssh impl from native to CommandRunner
2019-03-26 12:14:06 -07:00
Thomas Stromberg
c91da2a65f
Upgrade addon-manager to v9.0 for compatibility with Kubernetes v1.14
2019-03-26 11:33:42 -07:00
Thomas Stromberg
48e4808b72
Remove special unrelated docker check
2019-03-26 10:54:39 -07:00
Thomas Stromberg
ec135dc4da
Add addon-manager, dashboard, and storage-provisioner to minikube logs
2019-03-26 10:43:03 -07:00
Thomas Stromberg
e878c1a0a0
Rename MINIKUBE_IN_COLOR to MINIKUBE_IN_STYLE
2019-03-26 06:56:10 -07:00
Zhongcheng Lao
a143711b6a
Merge remote-tracking branch 'origin/master' into image-name
2019-03-26 21:15:24 +08:00
Anders F Björklund
4667c28164
Merge branch 'master' into cyclo
2019-03-26 07:16:28 +01:00
Thomas Strömberg
f74751c3b7
Merge pull request #3934 from afbjorklund/more-lint
...
Clean up lint and other small report card issues
2019-03-25 21:42:21 -07:00
Thomas Stromberg
cbda4fc856
Merge branch 'master' into v1.14-tmpl
2019-03-25 20:54:26 -07:00
Thomas Stromberg
17ee8f568b
Minor UI tweaks to problem package
2019-03-25 20:47:35 -07:00
Thomas Strömberg
aec8c78f5d
Merge pull request #3596 from flyingcircle/master
...
Issue #3253 , improve kubernetes-version error string
2019-03-25 18:59:50 -07:00
Thomas Strömberg
89ab0be3b0
Merge pull request #3958 from andahme/no-wait-on-addon-manager
...
Update kubeadm bootstrap logic so it does not wait for addon-manager
2019-03-25 18:58:59 -07:00
Thomas Strömberg
9deb531889
Merge pull request #3947 from afbjorklund/hidden
...
Add explicit kvm2 flag for hidden KVM signature
2019-03-25 18:58:05 -07:00
Thomas Strömberg
4ccc7a2b17
Merge pull request #3961 from afbjorklund/tarball-tmp
...
Use a temp file, when writing the cached image
2019-03-25 18:57:54 -07:00
Thomas Stromberg
294b26b5f1
Update default Kubernetes version to v1.14.0
2019-03-25 18:56:32 -07:00
Thomas Strömberg
a1317476c2
Merge pull request #3931 from tstromberg/bring_ya_errs_to_the_project_maybe_we_can_solve_it
...
Add solution catalog to help users who run into known problems
2019-03-25 18:33:07 -07:00
Thomas Stromberg
9f753c3027
Fix all the kubeadm config generation bugs I could find, add tests across versions
2019-03-25 18:25:01 -07:00
Anders F Björklund
3194ec7026
Use a temp file, when writing the cached image
2019-03-25 21:53:07 +01:00
Thomas Stromberg
e843038597
More refactoring, add INVALID_PROXY_HOSTNAME
2019-03-25 13:28:31 -07:00
Thomas Stromberg
ea57b6149f
Add boilerplate
2019-03-25 13:05:47 -07:00
Thomas Stromberg
82e4db98c2
Rename Solution to Advice, add new known problems
2019-03-25 13:04:16 -07:00
Thomas Strömberg
cc5d4e9724
Merge branch 'master' into rkt-remove
2019-03-25 11:31:09 -07:00
Thomas Strömberg
44a4e290be
Merge pull request #3948 from afbjorklund/status
...
Fix the spelling of API in the template as well
2019-03-25 09:59:13 -07:00
Andy Daniels
3cd76a7984
Update kubeadm bootstrap logic so it does not wait for addon-manager at start
2019-03-25 10:00:03 -05:00
Anders F Björklund
bfc7d7931b
Clean up lint and other small report card issues
...
Add helper for "go vet", and don't use the test files variable.
Also return an exit code from golint (why is this not default?)
2019-03-24 21:30:58 +01:00
Anders F Björklund
348c085a22
Fix the spelling of API in the template as well
...
The matching code was changed in commit 46640ce
2019-03-24 16:09:41 +01:00
Anders F Björklund
6491e35c20
Add explicit kvm2 flag for hidden KVM signature
2019-03-24 09:47:38 +01:00
Anders F Björklund
2590fc7b9a
Remove the rkt container runtime
...
It has not been updated since kubernetes 1.9 or so
2019-03-24 08:50:58 +01:00
Anders F Björklund
ecc484d523
Make gofmt silent again, complaining on assets
2019-03-23 12:24:41 +01:00
Zhongcheng Lao
8c28ca4202
Select an accessible image repository for some users
...
Now it's possible to fallback to a mirror site for those users
who cannot access the main k8s.gcr.io repository. You may also
set the --image-mirror-country to forcibly use a known local
mirror in the specific location.
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-03-23 16:58:55 +08:00
Zhongcheng Lao
aeb1605aff
Remove arch suffixes in image names
...
Removing arch suffixes in image names to make sure image caching
work with kubeadm since 1.12.0.
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-03-23 16:32:17 +08:00
Thomas Strömberg
702d471308
Merge pull request #3714 from laozc/custom-image-repository
...
Add --image-repository flag so that users can select an alternative repository mirror
2019-03-22 09:24:18 -07:00
Thomas Stromberg
2502d2060c
Run gofmt -w -s
2019-03-22 09:19:58 -07:00
flyingcircle
f0d21d7c28
# This is a combination of 2 commits.
...
# This is the 1st commit message:
Issue #3253 , improve kubernetes-version error string
# This is the commit message #2 :
Issue #3253 , improve kubernetes-version error string
2019-03-22 08:25:35 -04:00
Zhongcheng Lao
daec030cdf
Render asset template when enabling/disabling addon
2019-03-22 15:28:20 +08:00
Thomas Stromberg
7e57cf6ec6
Add some ssh issues
2019-03-21 22:24:37 -07:00
Thomas Strömberg
cbac94a53d
Merge pull request #3879 from marcosdiez/extra_config_for_kubeadm
...
--extra-config now work for kubeadm as well
2019-03-21 22:03:06 -07:00
Thomas Stromberg
ce71b0dbd6
Merge branch 'master' into bring_ya_errs_to_the_project_maybe_we_can_solve_it
2019-03-21 22:01:06 -07:00
Thomas Stromberg
1ff174b796
Run: gofmt -s -w
2019-03-21 22:00:14 -07:00
Thomas Stromberg
37e259f7ea
Implement the new problem package
2019-03-21 21:44:51 -07:00
Zhongcheng Lao
7ae074106c
Merge remote-tracking branch 'origin/master' into custom-image-repository
2019-03-22 10:42:09 +08:00
Thomas Strömberg
c4ae58f4d3
Merge pull request #3896 from brb/do-not-wait-for-dns-pod-with-cni
...
Do not wait for k8s-app pods when starting with CNI
2019-03-21 11:49:45 -07:00
Thomas Strömberg
06d9210937
Merge pull request #3927 from tstromberg/noswap-2.0
...
Remove the swap partition from minikube.iso
2019-03-21 11:48:25 -07:00
Thomas Strömberg
88c45bf5b2
Merge branch 'master' into lint
2019-03-21 11:34:45 -07:00
Thomas Strömberg
f9a136a2f2
Merge pull request #3841 from afbjorklund/reportcard
...
Address the low-hanging fruit on report card
2019-03-21 11:33:28 -07:00
Thomas Strömberg
460ef571e2
Merge branch 'master' into lint
2019-03-21 11:32:47 -07:00
Thomas Stromberg
44d490a042
Merge branch 'mount-intr' of github.com:tstromberg/minikube into mount-intr
2019-03-21 11:24:23 -07:00
Thomas Stromberg
cbddc376d2
SIGINT should be exit code 2
2019-03-21 11:23:55 -07:00
Marcos Diez
4e28becd7e
everybody likes passing tests
2019-03-21 06:33:46 -03:00
Marcos Diez
7de36ed9a1
allow --extra-config work on kubeadm as well. example: --extra-config kubeadm.ignore-preflight-errors=SystemVerification
...
missing variable
2019-03-21 06:33:46 -03:00
Zhongcheng Lao
daeb238766
Merge remote-tracking branch 'origin/master' into custom-image-repository
2019-03-21 13:23:11 +08:00
Thomas Stromberg
bf4f6ee91c
Clarify why disabling the Swap preflight is good for certain users
2019-03-20 20:50:20 -07:00
Thomas Stromberg
3d0f722a6c
Remove -q, as it is not available in this version of findmnt
2019-03-20 20:02:35 -07:00
Thomas Stromberg
79aafd525f
Merge branch 'master' into mount-intr
2019-03-20 19:56:43 -07:00
Thomas Strömberg
6751e394f8
Merge pull request #3833 from afbjorklund/cruntime-version
...
Cruntime version
2019-03-20 19:55:45 -07:00
Thomas Strömberg
0d6c92153f
Merge branch 'master' into reportcard
2019-03-20 19:16:02 -07:00
Thomas Strömberg
84b92d1b8f
Merge pull request #3885 from afbjorklund/cache-1.14
...
Update list of cached images for kubernetes 1.14
2019-03-20 19:14:52 -07:00
Thomas Strömberg
fd54141f04
Merge pull request #3810 from tstromberg/k8s114
...
Update minikube to be compatible with Kubernetes v1.14.0-beta.1
2019-03-20 19:10:59 -07:00
Thomas Stromberg
605088ff72
Keep Initializers as the first element, fix v1.14 test which still included Initializers
2019-03-20 17:23:07 -07:00
Thomas Strömberg
7f6eecad37
Merge pull request #3872 from tstromberg/more-logs
...
logs: Add kube-proxy, dmesg, uptime, uname + newlines between log sources
2019-03-20 16:47:34 -07:00
Thomas Stromberg
88091b2323
Fix DefaultLegacyAdmissionControllers comment
2019-03-20 16:45:39 -07:00
Thomas Stromberg
66b18c878c
Merge branch 'master' into k8s114
2019-03-20 16:43:32 -07:00
Thomas Strömberg
c1a0264161
Merge pull request #3832 from tstromberg/k8s-v1.10.0
...
Skip "pull" command if using Kubernetes 1.10, which does not support it.
2019-03-20 16:42:39 -07:00
Thomas Stromberg
7eeb0a7925
Revert "Use --kubeconfig for v1.10.x, instead of skipping the pull"
...
This reverts commit 0c1b51ced3
.
2019-03-20 16:40:12 -07:00
Thomas Strömberg
4756b15bc1
Merge branch 'master' into lint
2019-03-20 10:16:09 -07:00
Thomas Strömberg
177ce6597d
Merge pull request #3830 from tstromberg/find-probelms
...
Add problem detection for #3818 - no providers available
2019-03-20 10:14:04 -07:00
Thomas Stromberg
1eca3e096b
Merge branch 'master' into k8s-v1.10.0
2019-03-20 10:12:49 -07:00
Thomas Stromberg
0c1b51ced3
Use --kubeconfig for v1.10.x, instead of skipping the pull
2019-03-20 10:07:25 -07:00
Marco Vito Moscaritolo
443accf1e0
Update link to drive docs in xhyve driver
...
Signed-off-by: Marco Vito Moscaritolo <mavimo@gmail.com>
2019-03-19 08:53:11 +01:00
Martynas Pumputis
2d8e577b33
Do not wait for k8s-app pods when starting with CNI
...
Previously, minikube was waiting for some pods labeled with
"k8s-app" (e.g. "kube-dns") to be ready before indicating that
"minikube start" was successful. However, in the case of
"network-plugin=cni", network of such pods is managed by a CNI
plugin which is usually started after "minikube start" has returned
making the waiting for the pods to fail with:
Error starting cluster: wait: waiting for k8s-app=kube-dns: timed out
waiting for the condition
This commit omits waiting for "k8s-app" pods if minikube is started
with "network-plugin=cni".
Reported-by: Michal Rostecki <mrostecki@opensuse.org>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
2019-03-18 11:13:55 +01:00
Anders F Björklund
03bdce47ee
Decrease cyclomatic complexity for test
...
Mostly by using the "extract method" pattern.
Here was the report (from gocyclo), before:
17 tunnel TestTunnelManagerCleanup pkg/minikube/tunnel/tunnel_manager_test.go:174:1
44 tunnel TestTunnel pkg/minikube/tunnel/tunnel_test.go:35:1
34 kubeconfig configEquals pkg/util/kubeconfig/config_test.go:420:1
25 integration testMounting test/integration/mount_test.go:36:1
18 integration testTunnel test/integration/tunnel_test.go:37:1
2019-03-16 23:04:24 +01:00
Anders F Björklund
00c9846a19
Decrease cyclomatic complexity for code
...
Mostly by using the "extract method" pattern.
Here was the report (from gocyclo), before:
16 kubeadm (*KubeadmBootstrapper).UpdateCluster pkg/minikube/bootstrapper/kubeadm/kubeadm.go:374:1
16 cluster StartHost pkg/minikube/cluster/cluster.go:64:1
16 tunnel setupRoute pkg/minikube/tunnel/tunnel.go:135:1
16 provision configureAuth pkg/provision/buildroot.go:218:1
21 util setElement pkg/util/config.go:50:1
2019-03-16 22:18:14 +01:00
Anders F Björklund
5497b966be
Rename stutter and move classes between packages
...
Removing the kubeconfig module is probably not a big deal,
since it was already hiding under the "util" directory...
But the layout of the Bootstrapper is slightly irritating,
as long as it is contained in a different "kubeadm" module.
2019-03-16 16:57:56 +01:00
Anders F Björklund
dba916a016
Document all exported functions inside minikube
...
Make config get/set more symmetrical, as well.
2019-03-16 16:57:43 +01:00
Anders F Björklund
edf46f003f
Document all exported functions outside minikube
2019-03-16 16:57:37 +01:00
Zhongcheng Lao
40caf8317c
Merge remote-tracking branch 'upstream/master' into custom-image-repository
2019-03-15 18:01:48 +08:00
Thomas Strömberg
016e3f3178
Merge pull request #3767 from tstromberg/cache_images_int_test2
...
caching: Fix containerd, improve console messages, add integration tests
2019-03-14 08:19:25 -07:00
Thomas Stromberg
0422b9c567
Add kube-proxy and dmesg logs + newlines between log sources
2019-03-13 14:53:14 -07:00
Thomas Stromberg
1ec970a7fd
Remove random unicode character
2019-03-11 16:18:42 -07:00
Thomas Stromberg
c713b186e8
unmount on sigint/sigterm, --options and --mode, improve mount UI
2019-03-11 16:18:06 -07:00
Thomas Strömberg
5f290a1a6e
Merge pull request #3819 from presslabs/fix-tunnel-error
...
Fix tunnel error logging
2019-03-11 09:37:26 -07:00
Anders F Björklund
90527daf72
Update list of cached images for kubernetes 1.14
2019-03-10 15:57:10 +01:00
Anders F Björklund
6d96a67456
Run go vet on all code, not just pkg and cmd
2019-03-10 14:33:24 +01:00
Anders F Björklund
0d8e591a4a
Fix some misc typos, as reported by misspell
...
minikube/pkg/gvisor/enable.go
Line 120: warning: "downlaods" is a misspelling of "downloads" (misspell)
minikube/pkg/minikube/console/style.go
Line 96: warning: "embarassed" is a misspelling of "embarrassed" (misspell)
2019-03-10 13:43:04 +01:00
Anders F Björklund
dabe7665f2
Return error from Close, as reported by go vet
...
minikube/pkg/minikube/tunnel/registry.go
Line 124: error: result of fmt.Errorf call not used (vet)
Line 161: error: result of fmt.Errorf call not used (vet)
2019-03-10 13:40:39 +01:00
Anders F Björklund
7d1fdab6bc
Add unit test for container runtime version
...
This only tests the happy path of the current iso versions.
2019-03-10 10:37:55 +01:00
Anders F Björklund
112a66c21a
Add some error reporting to the version method
2019-03-10 10:18:26 +01:00
Anders F Björklund
0c67b60604
Add Version() function to the Manager interface
...
Helps with troubleshooting container runtimes
2019-03-10 10:09:13 +01:00
Thomas Stromberg
f968cb7709
Don't try to run the images pull command on old versions of kubeadm
2019-03-08 10:52:13 -08:00
Thomas Stromberg
6a36191bb4
Merge branch 'master' into find-probelms
2019-03-08 10:20:39 -08:00
Thomas Stromberg
4a7e68c6b7
Add detection for #3818 - no providers available
2019-03-08 09:51:08 -08:00
Calin Don
229137c06b
Fix tunnel error logging
2019-03-07 11:38:26 +02:00
Thomas Stromberg
56a51ffe0d
Merge branch 'master' into cache_images_int_test2
2019-03-06 15:21:11 -08:00
Thomas Strömberg
a4841d9d72
Merge pull request #3796 from kron4eg/patch-1
...
Change DefaultMountVersion to 9p2000.L
2019-03-06 14:13:50 -08:00
Thomas Stromberg
327fdd8d4b
Update kubeadm config generation to be compatible with v1.14.0-beta.1
2019-03-06 13:32:33 -08:00
Thomas Stromberg
ae27bb1e85
Update default to v1.13.4
2019-03-06 11:37:29 -08:00
Artiom Diomin
1607e9f8ea
Change DefaultMountVersion to 9p2000.L
...
Fixes #2290
2019-03-05 14:45:36 +02:00
Anders F Björklund
5b709b2b0a
Failure to read documentation isn't really a crash
2019-03-04 20:23:23 +01:00
Anders F Björklund
46640cef68
Address all lint except undocumented and stutter
...
These two lint warnings still remain, after the cleanup:
"exported ... should have comment or be unexported"
"type name will be used as foo.FooBar by other packages,
and that stutters; consider calling this Bar"
2019-03-02 22:03:55 +01:00
Thomas Strömberg
794bc6cedd
Merge pull request #3780 from afbjorklund/logs
...
Fix minikube logs for other container runtimes
2019-03-01 15:49:23 -08:00
Anders F Björklund
df5bbc3c8a
Fix minikube logs for other container runtimes
...
It is only Docker that adds the "k8s_" prefix, since CRI
only handles containers that are used by Kubernetes anyway.
Also need to use "sudo" when running all crictl commands,
including logs. And only list containers that are running.
2019-03-01 20:56:45 +01:00
Thomas Stromberg
b9675da28b
Add comment about optimization
2019-03-01 11:03:06 -08:00
Thomas Stromberg
a11e1c3c27
retry updateKubeProxyConfigMap
2019-03-01 10:54:18 -08:00
Thomas Stromberg
eae5b34100
Only restart kube-proxy if necessary, make certain steps retialble
2019-03-01 10:53:55 -08:00
Thomas Stromberg
a2865f183a
Back to the original 10 minute timeout :(
2019-03-01 10:50:39 -08:00
Thomas Stromberg
2f1f52edba
Add reconfiguring style
2019-02-28 16:40:55 -08:00
Thomas Stromberg
c40602b327
ReasonableStartTime = 8, for folks with CrashLooping DNS on none
2019-02-28 16:40:46 -08:00
Thomas Stromberg
a4be5ee438
Have StartCluster/RestartCluster block until system pods are healthy
2019-02-28 16:27:35 -08:00
Thomas Stromberg
3b2a81d409
Increase ReasonableStartTime from 5 to 9 minutes
2019-02-28 16:26:42 -08:00
Thomas Stromberg
4c48753ba0
Docker doesn't need to use sudo
2019-02-28 12:05:30 -08:00
Thomas Stromberg
e09133892f
Fix docker/containerd caching, improve msgs, add tests
2019-02-27 13:58:33 -08:00
Anders F Björklund
167d1584a6
Add flag for disabling the VirtualBox VTX check
...
Currently this is broken upstream, provide workaround...
Already available in docker-machine, so port to minikube.
2019-02-22 18:29:29 +01:00
Zhongcheng Lao
e753a90be0
Add test cases for NewKubeletConfig
2019-02-18 11:03:04 +08:00
Zhongcheng Lao
39fcf1fe20
Add test cases for custom image repository feature
2019-02-18 01:00:22 +08:00
Zhongcheng Lao
7a59d376cf
Turn addon resource with images into template
...
When the user overrides image repository the images will be pulled
from the overrided one instead of the official repositories.
2019-02-18 01:00:18 +08:00
Zhongcheng Lao
7cbe253ef6
Allow specifying image repository for docker images
...
Some users (especially for those in mainland China) may have issue
accessing the default image repository. This patchset allows users
to override the default image repository gcr.io to a different
repository by specifying --image-repository option in the command
line as a simple workaround. Images will be pulled from the
specified image repository instead of the default ones.
Example (using mirror by Aliyun):
minikube start ...
--image-repository
registry.cn-hangzhou.aliyuncs.com/google_containers
2019-02-18 01:00:12 +08:00
Thomas Stromberg
5f77fc6c1a
Only call trySSHPowerOff if we are using hyperv
2019-02-16 07:47:00 -08:00
Thomas Strömberg
4142c6d967
Merge pull request #3680 from tstromberg/better-none
...
none UX: Reword warnings and other strings for accuracy
2019-02-15 10:38:07 -08:00
Anders F Björklund
166b423e6e
Implement CRI method ContainerLogCmd for rkt
2019-02-15 19:24:44 +01:00
Anders Björklund
1473c36fb9
Merge pull request #3678 from afbjorklund/rkt
...
Add implementation of the deprecated rkt runtime
2019-02-15 19:20:30 +01:00
Anders Björklund
4ae8fed6cd
Merge pull request #3675 from afbjorklund/images
...
Upgrade the list of images for 1.12 and 1.13
2019-02-15 19:19:02 +01:00
Thomas Stromberg
54b22649e9
Forgot to remove a warning
2019-02-15 10:07:09 -08:00
Thomas Stromberg
bb752098df
Drop all empty strings from containers list, add fake prefix in log messages
2019-02-15 09:46:15 -08:00
Thomas Stromberg
b80498fcb4
Merge from HEAD
2019-02-15 09:24:35 -08:00
Thomas Stromberg
f345fe4b08
Less warnings, consistent info messages
2019-02-15 09:11:46 -08:00
Thomas Stromberg
cd156b3f98
Merge branch 'master' into container-killing2
2019-02-15 09:10:19 -08:00
Thomas Strömberg
8e5fd5b275
Merge pull request #3686 from tstromberg/7-bit-console
...
Implement 7-bit ASCII prefixes for when MINIKUBE_IN_COLOR=false
2019-02-15 09:08:17 -08:00
Thomas Stromberg
18adab13fa
Remove duplicate keys from merge
2019-02-15 07:21:40 -08:00
Thomas Stromberg
4a1feb6531
Reduce text clutter
2019-02-15 07:16:41 -08:00
Thomas Stromberg
1d0733e1e4
Merge
2019-02-15 07:06:22 -08:00
Thomas Stromberg
5013af7917
Change LowPrefix for internet. It looked strange with the indented options
2019-02-15 07:03:31 -08:00
Thomas Stromberg
3838442440
Implement 7-bit ASCII prefixes
2019-02-15 06:52:33 -08:00
Thomas Strömberg
71971667a0
Merge pull request #3501 from laozc/master
...
addons: Fixes multiple files behavior in files rootfs
2019-02-15 05:34:49 -08:00
Thomas Strömberg
ceb324b4ad
Merge pull request #3660 from tstromberg/hyperkit-debugging
...
Make hyperkit driver more robust: detect crashing, misinstallation, other process names
2019-02-15 05:23:09 -08:00
Thomas Stromberg
07fc64fbe1
Warnf -> Debugf so that it doesn't interfere with output
2019-02-14 20:12:34 -08:00
Thomas Stromberg
2588a98435
Back to Run -- I was mistaken
2019-02-14 17:17:54 -08:00
Thomas Stromberg
71eafef5ce
Overhaul how we handle kubectl, as it isn't actually required except for the dashboard
2019-02-14 17:10:03 -08:00
Thomas Stromberg
c3db098d4a
ListContainers should return empty list when no containers match
2019-02-14 16:10:33 -08:00
Thomas Stromberg
7dd7e5417d
glog, not golog
2019-02-14 14:43:22 -08:00
Thomas Stromberg
531e6b0f72
Use h.SetLogger
2019-02-14 14:40:32 -08:00
Thomas Stromberg
0c8a452e97
lowercase error messages
2019-02-14 14:40:16 -08:00
Thomas Stromberg
ba9492c314
Merge branch 'master' into hyperkit-debugging
2019-02-14 14:03:52 -08:00
Anders F Björklund
dc618b70f9
Add implementation of the deprecated rkt runtime
...
This is currently good for one thing: turning it off!
Using rktlet with kubernetes hasn't worked in a while.
2019-02-14 23:02:08 +01:00
Thomas Stromberg
45303bac07
Code review comments
2019-02-14 13:59:08 -08:00
Balint Pato
5029f8a66e
Update pkg/minikube/exit/exit.go
...
Co-Authored-By: tstromberg <tstromberg@google.com>
2019-02-14 13:17:32 -08:00
Balint Pato
4c2ba19455
Update pkg/minikube/logs/logs_test.go
...
Co-Authored-By: tstromberg <tstromberg@google.com>
2019-02-14 13:16:57 -08:00
Thomas Stromberg
c2194e191d
Fix merge conflicts
2019-02-14 11:58:07 -08:00
Anders F Björklund
a02802d056
Upgrade the list of images for 1.12 and 1.13
...
Getting tired of downloading newer etcd again
2019-02-14 20:48:12 +01:00
Thomas Stromberg
4cfe77294d
Fix style merge conflict
2019-02-14 11:25:42 -08:00
Thomas Strömberg
3714bbd787
Merge pull request #3659 from tstromberg/console
...
Clearer output when re-using VM's so that users know what they are waiting on
2019-02-14 11:03:50 -08:00
Thomas Strömberg
4608a137bd
Merge pull request #3671 from tstromberg/kubeadm-eviction
...
Disable kubelet disk eviction by default
2019-02-14 11:02:58 -08:00
Thomas Strömberg
10d8487417
Merge pull request #3665 from tstromberg/sudo-poweroff
...
Run poweroff before delete, only call uninstall if driver is None
2019-02-14 10:30:31 -08:00
Thomas Stromberg
5c1a72f428
Switch Infof statements to Debugf/Warningf, as they go to stderr
2019-02-14 10:14:41 -08:00
Thomas Stromberg
247e957e8f
Revert accidental indentation
2019-02-13 21:47:54 -08:00
Thomas Stromberg
b34f4a1ed9
Merge branch 'master' into logs-apiserver3
2019-02-13 21:39:31 -08:00
Thomas Stromberg
496bbe00bb
Pluralize problem
2019-02-13 21:35:42 -08:00
Thomas Stromberg
08da5fe3b5
Add pod logs to 'logs' command, show detected problems during minikube start
2019-02-13 21:29:20 -08:00
Thomas Stromberg
6a18ad9bc5
Reduce wait times, and wait more consistently
2019-02-13 21:15:46 -08:00
Thomas Strömberg
c29ef66727
Merge pull request #3650 from bassam/pr-fix-parallels
...
Fix parallels support after #953
2019-02-13 20:56:49 -08:00
Thomas Strömberg
b2a096c650
Merge pull request #3667 from afbjorklund/kubeadm-reset
...
Seems kubeadm reset doesn't have a --config flag
2019-02-13 20:43:44 -08:00
Thomas Stromberg
9fe9cdbc29
Add boilerplate
2019-02-13 15:39:17 -08:00
Thomas Stromberg
de699183c8
Cleanup unsupported driver checks
2019-02-13 15:39:10 -08:00
Thomas Stromberg
caafc66a61
Disable kubelet disk eviction by default
2019-02-13 15:08:06 -08:00
Anders F Björklund
02ff9f5e71
Check that a style exists for all runtimes
...
Including CRI-O, which recently got a "new" name...
It is loaded at runtime, so could break otherwise.
2019-02-13 23:50:39 +01:00
Thomas Stromberg
d974cd6d83
Use stderr instead of stdout
2019-02-13 14:25:25 -08:00
Thomas Stromberg
473f5983cb
Allow driver name to be com.docker.hyper, as seen in integration testing
2019-02-13 13:36:45 -08:00
Thomas Stromberg
4b875ddd7f
Run goimports
2019-02-13 13:35:28 -08:00
Thomas Stromberg
2045dc9ba4
Lint cleanup
2019-02-13 13:35:08 -08:00
Thomas Stromberg
69f72ea991
Add exit.go, remove call to exit.Fail
2019-02-13 12:47:02 -08:00
Thomas Stromberg
5f65dc80fa
Remove error uploads, consolidate fatal error handling into exit package
2019-02-13 12:37:44 -08:00
Anders F Björklund
6c4eb71436
Seems kubeadm reset doesn't have a --config flag
...
However, it does have an annoying interactive prompt...
2019-02-13 20:31:11 +01:00
Thomas Stromberg
eb00fdb3d7
Remove VM/host
2019-02-13 09:42:49 -08:00
Thomas Stromberg
1c09ba2a48
Make the output clearer and less cluttered
2019-02-13 09:41:53 -08:00
Thomas Stromberg
277100d371
add an extra space for consistency
2019-02-13 09:23:56 -08:00
Thomas Stromberg
e74db39783
Issue a poweroff request before deleting a VM. Avoids HyperV hang
2019-02-13 09:21:58 -08:00
Thomas Strömberg
414b8ab9f8
Merge pull request #3657 from afbjorklund/cruntime-crio
...
Complete the cruntime implementation for CRI runtimes
2019-02-12 14:14:41 -08:00
Thomas Stromberg
888978c3a9
Improve VM re-use reliability: detect crashing and/or badly installed hyperkit
2019-02-12 13:58:18 -08:00
Thomas Stromberg
f346e5628b
Add logging around the DHCP discovery process
2019-02-12 13:57:02 -08:00
Thomas Stromberg
3454c83dcf
Clearer output when re-using VM's so that users know what they are waiting on
2019-02-12 13:54:30 -08:00
Anders F Björklund
abb5fc0af0
Show name as CRI-O, even if class is CRIO
...
Should use the proper name for display, even if we use a name more
suitable to naming classes and methods for the implementation...
Also use the --runtime=cri-o when testing, and update the github
repository now that cri-o has graduated from incubator to a sig.
See https://cri-o.io/
2019-02-12 21:03:51 +01:00
Anders F Björklund
de6782cd96
Implement list/kill/stop for CRI runtimes
2019-02-12 20:24:37 +01:00
Anders F Björklund
4b22a10ca3
Fix the CRI runtimes LoadImage implementation
...
ctr (containerd CLI) does not work for crio, so have to use podman
to load images. Unfortunately there is no crictl load, only pull.
2019-02-12 20:24:18 +01:00
Anders F Björklund
0a91040434
Add DeleteCluster to bootstrapper
...
This matches StartCluster, and is used to revert
the changes done to reset the VM machine state.
Even if it fails, continue to deleting the VM...
Make sure to handle the case of missing config.
2019-02-12 19:49:19 +01:00
Thomas Strömberg
ec5107ea96
Merge pull request #3638 from tstromberg/console
...
Initial implementation of 'console' package for stylized & localized console output 😂
2019-02-12 07:15:23 -08:00
Thomas Stromberg
0a5b64eeaf
Improve text strings for existing VM's and setting cluster permissions
2019-02-11 19:28:23 -08:00
Thomas Stromberg
452054bf25
Implement PR comments
2019-02-11 15:01:34 -08:00
Thomas Strömberg
50d69c034e
Merge pull request #3643 from afbjorklund/mutex
...
Avoid double unlock of image load mutex
2019-02-11 13:57:38 -08:00
Thomas Stromberg
deb31b4230
Pull upstream, sort out merge conflicts, use ParseBool
2019-02-11 13:56:45 -08:00
Bassam Tabbara
104f7dee9e
machine: fix parallels support
...
add vendor deps for parallels, fix compile issue, and enable parallels
as a default driver.
Signed-off-by: Bassam Tabbara <bassam@upbound.io>
2019-02-11 08:47:29 -08:00
Zhongcheng Lao
a6332e3c6e
Add unit testcase for addon file patterns
...
afero introduced for mocking a filesystem.
2019-02-10 21:39:22 +08:00
Zhongcheng Lao
0c1d3f2e33
Fixes multiple files behavior in files rootfs
...
Some files may be left uncopied to the VM when there are multiple
files in the .minikube/files directory as the code misinterprets
the last parent dir as parent dirs for all files, which results
some files with the same name were not copied.
This patch fixes the behavior.
2019-02-10 19:51:02 +08:00
Anders F Björklund
73dd006813
Replace string comparison with class method
2019-02-09 20:59:26 +01:00
Anders F Björklund
d3d9c5ed94
Avoid double unlock of image load mutex
...
Causes a runtime crash, with --cache-images:
"fatal error: sync: unlock of unlocked mutex"
2019-02-09 18:08:46 +01:00
Thomas Strömberg
6e1b9d030c
Merge pull request #953 from denji/parallels
...
machine: add parallels support
2019-02-08 15:39:43 -08:00
Thomas Strömberg
91be19c47a
Merge pull request #3258 from darkedges/master
...
When copying assets from .minikube/files on windows, directories get squashed during transfer. ie /etc/ssl/certs/test.pem becomes ~minikube/etcsslcerts/test.pem. This pull request ensures any window style directories are converted into unix style.
2019-02-08 15:31:00 -08:00
Thomas Stromberg
d57d8d1a1e
Fix broken tests: hyperkit driver format mismatch, console spacing mismatch
2019-02-08 13:58:02 -08:00
Thomas Stromberg
6c48048538
Merge from hell #2 : refactor start.go because it's terrible
2019-02-08 13:37:29 -08:00
Thomas Stromberg
ee8ddd60a8
Merge
2019-02-07 18:21:29 -08:00
Thomas Stromberg
92763ca40f
Remove deprecated error message check. Never check text on error messages :(
2019-02-07 16:14:27 -08:00
Thomas Stromberg
9f09f02e39
Address PR comments, make sure PullImages code path is exercised
2019-02-07 15:39:31 -08:00
Thomas Stromberg
f2d6f45538
More console work
2019-02-07 14:56:29 -08:00
Thomas Stromberg
c01bbf4075
Add missing Copyright boilerplate
2019-02-07 09:48:20 -08:00
Thomas Stromberg
2033f8dcec
Further tuning, especially of env override
2019-02-07 09:23:39 -08:00
Thomas Stromberg
5cb89b11ee
Fix bad cut and paste: crio -> containerd
2019-02-07 08:36:40 -08:00
Thomas Stromberg
d1b0d0470a
Initial console implementation
2019-02-06 22:00:30 -08:00
Thomas Stromberg
8193985000
Add cruntime package
2019-02-05 14:51:03 -08:00
Thomas Stromberg
966b245dc6
Refactor and centralize container runtime code into a cruntime package
2019-02-05 14:42:12 -08:00
Himanshu Pandey
0dda33a7df
Updated the default kubernetes version
2019-02-04 16:30:08 -08:00
Kubernetes Prow Robot
a7485e738f
Merge pull request #3601 from jayunit100/patch-4
...
Add breadcrumb logs to demonstrate when minikube's volume provisioner is…
2019-02-02 10:27:22 -08:00
Kubernetes Prow Robot
fd38580772
Merge pull request #3593 from balopat/fix_hyperkit_pid_issues
...
fix stale hyperkit.pid making minikube start hang
2019-01-30 07:40:16 -08:00
Thomas Strömberg
8d304ee172
Merge pull request #2757 from afbjorklund/podman
...
CRI: try to use "sudo podman load" instead of "docker load"
2019-01-30 06:40:56 -08:00
Thomas Strömberg
e1eafcd302
Update pkg/storage/storage_provisioner.go
...
Co-Authored-By: jayunit100 <jayunit100.github@gmail.com>
2019-01-29 16:06:47 -05:00
jay vyas
6faab7136d
Update storage_provisioner.go
2019-01-29 08:40:43 -08:00
jay vyas
1904f1e5d2
Update storage_provisioner.go
2019-01-29 08:18:48 -08:00
jay vyas
0126f92d87
Update storage_provisioner.go
2019-01-29 08:16:13 -08:00
jay vyas
2ed155d5e4
Add breadcrumb logs to demonstrate when minikube's CSI provisioner is actively making volumes
...
Since minikube is the canonical kubernetes deployment for learning and playing with things, this trivial PR makes it easy to see the storage provisioner in action, the current logging shows very little easier to differentiate how volumes are spun up.
2019-01-29 07:55:48 -08:00
balopat
17c0244cf7
reverting unnecessary change
2019-01-28 17:28:57 -08:00
balopat
5af2f1eafc
formatting / removed extra comment
2019-01-28 13:47:24 -08:00
balopat
f70e6a0385
fixing review remarks
2019-01-28 13:42:43 -08:00
balopat
f3034d3c50
parsing ip r output
2019-01-28 11:43:44 -08:00
balopat
2b0651b55d
parsing ip r output
2019-01-28 11:43:01 -08:00
balopat
933356e477
lint
2019-01-25 17:20:57 -08:00
balopat
9b97a85a8f
fix stale hyperkit.pid making minikube start hang
2019-01-25 17:08:31 -08:00
balopat
0fb27c7f38
fix netstat -f error on linux distros
2019-01-25 16:15:27 -08:00
Anders F Björklund
98a2a557c5
Cache just one image at a time, when using podman
...
To not run out of memory due to loading the images, since it
does not have a daemon to serialize things (like Docker does)
2019-01-25 22:08:15 +01:00
Anders F Björklund
25ad2d35d9
Optionally use podman load instead of docker load
2019-01-25 22:04:58 +01:00
Denis Denisov
a1cd81bf1c
machine: add parallels support
2019-01-25 10:31:26 +02:00
Thomas Strömberg
31eb53cbfb
Merge pull request #3560 from afbjorklund/service
...
Still generate docker.service unit, even if unused
2019-01-24 16:06:15 -08:00
Thomas Strömberg
b61207c233
Merge pull request #3391 from ivans3/logviewer-addon-pr7
...
Initial commit of logviewer addon
2019-01-24 16:00:29 -08:00
Thomas Strömberg
a130a09f32
Merge pull request #3262 from mlgibbons/update-parsing-for-k8s-v1.11
...
Add images and improve parsing for kubernetes 1.11
2019-01-24 15:58:17 -08:00
Thomas Strömberg
64640a4d3a
Merge pull request #3387 from jeffwubj/fix-3276
...
Update docker env during minikube start if VM has already been created
2019-01-24 09:51:53 -08:00
Jeff Wu
bb550593e0
fix comments
2019-01-24 23:22:00 +08:00
Anders F Björklund
6f909684e7
Still generate docker.service unit, even if unused
...
The dynamically generated docker.service file should still be there,
otherwise the statically provided docker.socket file gets confused.
2019-01-20 15:22:37 +01:00
Rob Richardson
4d05f3f774
Re-remove kube-dns addon
2019-01-18 22:21:00 -07:00
Thomas Strömberg
f29c0cd329
Merge pull request #3533 from tstromberg/kubeadm-log-output
...
Improve failure output when kubeadm init fails
2019-01-17 10:33:23 -08:00
Thomas Strömberg
e3a814b0e9
Merge pull request #3534 from frapposelli/vmware-unified-driver
...
Add new VMware unified driver to supported list #2
2019-01-16 23:02:37 -08:00
Thomas Stromberg
c2bf394378
Minor improvements to output and comments
2019-01-16 12:14:56 -08:00
Thomas Strömberg
9b45920503
Merge pull request #3252 from mlgibbons/caching-fix
...
Fix Windows cache path issues with directory hierarchies and lower-case drive letters
2019-01-16 11:16:16 -08:00
Fabio Rapposelli
332772be1c
Add VMware unified driver to supported list
2019-01-15 17:53:45 -08:00
Thomas Strömberg
3aa83674a9
Merge pull request #3441 from brb/2907-no-cni-conf-by-default
...
Do not include the default CNI config by default
2019-01-15 17:14:20 -08:00
Thomas Strömberg
8bc8816c9f
Merge pull request #3521 from nixpanic/addons/gluster
...
Add a storage-provisioner-gluster addon
2019-01-15 17:08:45 -08:00
Thomas Strömberg
7b32547cf6
Merge pull request #3108 from sebcworks/sebcworks-customapiserverport
...
Allow to specify api server port through CLI fix #2781
2019-01-15 16:43:42 -08:00
Thomas Strömberg
dde313a878
Merge pull request #3531 from Zyqsempai/add-default-disk-size-to-hyperkit-driver
...
Added defaultDiskSize setup to hyperkit driver
2019-01-15 16:41:10 -08:00
Thomas Stromberg
649b6b9641
Return output, even if CombinedOutput fails
2019-01-15 16:36:26 -08:00
Thomas Stromberg
e8015d9490
Fix awkwardly formatted error message: out is not a command-line.
2019-01-15 16:35:56 -08:00
Thomas Strömberg
a4ca26606a
Merge pull request #3527 from tstromberg/v1.13.2
...
Set default Kubernetes version to v1.13.2 (latest stable)
2019-01-14 14:29:50 -08:00
bpopovschi
0687fea66a
Added defaultDiskSize setup to hyperkit driver
...
fmt fix
2019-01-14 17:04:07 +02:00
Thomas Strömberg
e6b60fb38c
Merge pull request #3442 from brb/2828-network-plugin-cni
...
Pass network-plugin value to kubelet
2019-01-11 11:40:09 -08:00
Thomas Strömberg
c08ae00fb4
Merge pull request #3523 from superbrothers/fix-missing-line-break
...
Fix missing a line break for minikube status
2019-01-11 10:39:26 -08:00
Thomas Strömberg
d69fb2820c
Merge pull request #3485 from tstromberg/no-dashboard
...
Defer dashboard deployment until "minikube dashboard" is executed
2019-01-11 10:33:00 -08:00
Thomas Stromberg
5a0d29ba49
Set default Kubernetes version to v1.13.2 (latest stable)
2019-01-11 09:57:11 -08:00
Kazuki Suda
aab2d250d6
Fix missing a line break for minikube status
2019-01-10 14:29:07 +09:00
Niels de Vos
b85b6d5eeb
addons: mark the last enabled storage provider as default
...
When a storage provider is enabled (storage-provisioner-glusterfile),
mark it "is-default" and set "is-default" to "false" in all other
StorageClasses.
2019-01-09 20:04:21 +01:00
Niels de Vos
b0c7341373
addons: when enabling storage-provisioner-gluster, mark other SCs non-default
...
There can only be one StorageClass be marked as default. When the
storage-provisioner-gluster addon is enabled, users expect it to be the
default StorageClass.
Instead of removing the "is-default" annotation from the other
StorageClasses, set it to "false". This leaves only the "glusterfile"
StorageClass as "is-default".
2019-01-09 20:04:21 +01:00
Niels de Vos
3c3b7368f0
Add storage-provisioner-gluster addon
...
With this addon dynamic provisioning based on Gluster can be enabled:
$ minikube addons enable storage-provisioner-gluster
This will deploy several pods in a new 'storage-gluster' namespace:
- glusterfs, storage service with a 10GB sparse /srv/fake-disk.img
- heketi, a smart Gluster volume manager
- glusterfile-provisioner, external-storage provisioner
In addition, the StorageClass 'glusterfile' will be created. It is
currently not configured as default StorageClass, so PVCs need to refer
to the new StorageClass.
2019-01-09 20:04:21 +01:00
Martynas Pumputis
d982c4bf74
Do not include the default CNI config by default
...
Previously, minikube has been shipped with the default CNI config
(/etc/cni/net.d/k8s.conf) in its rootfs. This complicated a lot
when using a custom CNI plugin, as the default config was picked
by kubelet before the custom CNI plugin has installed its own CNI
config. So, the end result was that some Pods were attached to a
network defined in the default config, and some got managed by
the custom plugin.
This commit introduces the flag "--enable-default-cni" to
"minikube start" to trigger the provisioning of the default CNI
config.
Signed-off-by: Martynas Pumputis <m@lambda.lt>
2019-01-03 09:23:29 +01:00
Chris Eason
082fe50d7e
Merge remote-tracking branch 'origin/master' into tunnel-dns
2019-01-02 14:48:25 -05:00
Chris Eason
335da39434
Test for DNS resolution on Mac
2019-01-02 14:45:57 -05:00
Thomas Strömberg
6a0406611e
Merge pull request #3374 from jeffwubj/dev
...
Tell user given driver has been igored if exising VM has a different …
2018-12-21 19:04:01 -08:00
Thomas Strömberg
a8f54f6f75
Merge pull request #3482 from kubernetes/tstromberg-patch-3
...
Make Kubernetes v1.12.4 the default
2018-12-21 15:01:26 -08:00
Thomas Strömberg
f6af1ce6e2
Update kubeadm restart commands to support v1.13.x ( #3483 )
...
* Minor changes for compatibility with v1.13.1
* etcd subcommand should be local instead of all
2018-12-21 14:32:16 -08:00
Thomas Stromberg
9ca9242320
Disable dashboard by default
2018-12-21 11:49:14 -08:00
Thomas Strömberg
d9487db34a
Update constants.go
2018-12-21 11:20:04 -08:00
Thomas Strömberg
ab64cb952e
Merge pull request #3479 from tstromberg/stop-retry
...
Make "stop" retry on failure.
2018-12-20 19:46:24 -08:00
Thomas Strömberg
ae4221b3fb
Merge pull request #3475 from tstromberg/intlogs
...
tee party: Stream cmd output to tests when -v is enabled, and stream SSH output to logs
2018-12-20 17:21:34 -08:00
Thomas Strömberg
94245d0449
Merge pull request #3477 from tstromberg/retry-loop-0
...
Decrease log noise by logging retry loops after the initial attempt
2018-12-20 17:21:19 -08:00
Thomas Stromberg
c250a3b9d9
Make "stop" retry on failure.
2018-12-20 13:19:53 -08:00
Thomas Stromberg
fcaf89666f
Decrease log noise by logging retry loops after the initial attempt
2018-12-20 10:27:47 -08:00
Thomas Stromberg
b5185c6b3f
err cleanup: include cmd/out/err, but keep messages small and deduped
2018-12-20 10:17:41 -08:00
Thomas Stromberg
7f7587d96c
Rename TeeWithPrefix to TeePrefix to match Go idioms
2018-12-20 09:54:09 -08:00
Balint Pato
ed7031cbb3
Merge branch 'master' into logviewer-addon-pr7
2018-12-19 17:14:09 -08:00
Thomas Stromberg
9b707fe234
Add TeeWithPrefix to ssh_runner as well
2018-12-19 17:03:55 -08:00
Charles-Henri de Boysson
2cabcd5911
Fix CRI socket in Kubernetes >= 1.12.0 kubeadmin config ( #3452 )
...
Use CRI socket from parameter for V1Alpha3 configs instead of hardcoded
dockershim path
2018-12-19 16:51:29 -08:00
Jeffrey Sica
8f1b4d2882
bump dashboard version to v1.10.1 ( #3466 )
2018-12-19 16:38:52 -08:00
Cory Locklear
7d03fa212d
Enable host DNS resolution in virtualbox driver by default ( #3453 )
2018-12-19 15:41:52 -08:00
Thomas Strömberg
2ea91b216e
Merge pull request #3459 from alasdairtran/hide-kvm-signature
...
Hide KVM signature when using GPU passthrough to support more GPU models
2018-12-18 15:15:58 -08:00
Chris Eason
bd150201a9
Add ability to resolve service FQDNs from host during 'minikube tunnel' (MacOS only for now)
2018-12-18 13:22:37 -05:00
Chris Eason
c7e69fd257
Allow ServiceCIDR to be configured via 'service-cluster-ip-range' flag.
2018-12-18 12:17:33 -05:00
Alasdair Tran
7ba01b40a9
Hide KVM signature
2018-12-15 21:47:41 +11:00
Thomas Strömberg
e12550d323
Revert "Revert "Make k8s v1.12.3 the default""
2018-12-14 14:47:27 -08:00
priyawadhwa
5d910e8937
Save old cluster config in memory before overwriting ( #3450 )
...
* Save old cluster config in memory before overwriting
In PR #3426 , I changed "minikube start" to overwrite the cluster config earlier so that the container runtime could be extracted from it by the buildroot provisioner. This introduced a bug later on, where minikube expected to read the kubernetes version from theold config (which no longer existed, because the config was overwritten).
To fix this, I changed the code to store the old version of the config in memory before overwriting it.
This should fix #3447
2018-12-13 14:31:22 -08:00
Martynas Pumputis
e08423c633
Pass network-plugin value to kubelet
...
Previously, when "minikube start" has been invoked with
"--network-plugin=<..>", the value was not passed to kubelet. Therefore,
the additional param "--extra-config=kubelet.network-plugin=<..>"
was required.
This commit ensures that the value is being passed to kubelet, so
the extra-config value is no longer needed.
Signed-off-by: Martynas Pumputis <m@lambda.lt>
2018-12-11 16:20:34 +01:00
Thomas Strömberg
87107b73ba
Merge pull request #3427 from JoeWrightss/patch-1
...
Fix .Info() error message
2018-12-10 09:33:52 -08:00
priyawadhwa
8f128a7d10
Enable gvisor addon in minikube ( #3399 )
...
This PR adds the code for enabling gvisor in minikube. It adds the pod
that will run when the addon is enabled, and the code for the image
which will run when this happens.
When gvisor is enabled, the pod will download runsc and the
gvisor-containerd-shim. It will replace the containerd config.toml and
restart containerd.
When gvisor is disabled, the pod will be deleted by the addon manager.
This will trigger a pre-stop hook which will revert the config.toml to
it's original state and restart containerd.
2018-12-07 15:27:22 -08:00
Thomas Strömberg
ad415e252d
Merge pull request #3401 from tstromberg/cherry-2f81d
...
Add apiserver check to "status", and block "start" until it's healthy.
2018-12-07 15:20:07 -08:00
priyawadhwa
ed8f7124a0
Only restart docker service if container runtime is docker ( #3426 )
...
* Only restart docker service if container runtime is docker
Only allow the buildroot provisioner to restart docker if the container
runtime is docker. This change should fix the bug in #3424 , since now
docker will not be restarted if the container runtime is containerd.
* Added files to fix FileContent--proc-sys-net-bridge-bridge-nf-call-iptables precheck error
From this issue: https://github.com/kubernetes/kubeadm/issues/1062
these files need to be added to prevent this precheck error (which occurs when running any container runtime that isn't docker).
Also, save the machine config on the user's filesystem earlier so that the buildprovisioner can access it.
2018-12-07 12:08:59 -08:00
JoeWrightss
1ddd835a6e
Fix .Info() error message
...
Signed-off-by: JoeWrightss <zhoulin.xie@daocloud.io>
2018-12-08 00:44:47 +08:00
Thomas Strömberg
2847622892
Revert "Make k8s v1.12.3 the default"
2018-12-06 09:05:33 -08:00
Jeff Wu
8905dba07b
Correcting for PR comments
2018-12-05 13:12:53 +08:00
Thomas Stromberg
a74e9faf8b
Make k8s v1.12.3 the default
2018-12-03 21:43:53 -08:00
Thomas Stromberg
71eff5922d
Disable TLS checks, because they don't work while we are waiting for startup
2018-12-03 21:07:30 -08:00
Thomas Stromberg
cb3624dd08
Add apiserver health checks
2018-12-03 20:11:42 -08:00
Thomas Strömberg
bc67a32a7b
Merge pull request #3332 from dlorenc/rmaddons
...
Remove both the CoreDNS and KubeDNS addons. Let Kubeadm install the c…
2018-12-03 17:15:06 -08:00
ivans3
b43b8ccd9d
Initial commit of logviewer addon
2018-12-02 12:58:06 -08:00
Jeff Wu
867233e2ae
fix 3276
2018-11-30 16:44:41 +08:00
wujeff
bae164a217
Tell user given driver has been igored if exising VM has a different driver
2018-11-28 18:31:37 +08:00
Anders Björklund
57f4d9247e
Only require docker for the docker runtime ( #3303 )
...
Closes #3295
2018-11-27 14:15:08 -08:00
Balint Pato
47579273d8
even longer timeout + timeout error is retriable now ( #3370 )
...
* even longer timeout + timeout error is retriable now
* fix for debugging when tunnel test has issues
2018-11-27 13:58:26 -08:00
Peeyush gupta
dc340b06d8
Adding ARCH variable to download kubeadm/kubelet binaries ( #3368 )
2018-11-27 08:34:13 -08:00
Balint Pato
4b11d63da1
debugging improvements and flakiness reduction ( #3363 )
...
Small improvements to debugging and reducing integration test flakiness:
* added logging to kubeadm init in the SSHExecutor
* increasing timeout for RBAC creation via the kubernetes client set
* only log tunnel output to test logger
2018-11-26 10:18:28 -08:00
Balint Pato
a681603daa
Fix `minikube tunnel` for hyperkit ( #3349 )
...
This change is a bit of a hack to make IP routing work over the virtio-net interface - it forces the virtio-net interface (bridge100) created by hyperkit/xhyve to reset via removing and readding the single member of the interface. Without this "reset" packets are just simply lost most of the time, despite a completely healthy IP route.
This error was also the reason for a large percentage of our integration test failures. While reducing the flakiness of tunnel related tests I also increased the timeout requirement and adding retries to the nginx request in TestTunnel.
2018-11-21 13:39:48 -08:00
dlorenc
2091f8c27a
Remove both the CoreDNS and KubeDNS addons. Let Kubeadm install the correct DNS addon.
2018-11-16 14:54:44 -08:00
priyawadhwa
77942bbf94
Restart containerd after stopping alternate runtimes ( #3343 )
...
After stopping any runtimes that aren't being used, if we're using
containerd then we need to restart it. This is because it competes with
cri-o to listen on port 10010, causing a necesary plugin to not be
installed. After stopping cri-o, we need to restart containerd so that
the plugin is installed.
I also added some preflight checks when using alternative runtimes.
kubeadm checks to make sure the Docker service is running, so I disabled
that. It also checks if a few ports are available; these are ports that
containerd uses, so I also added them to the ignore list.
This should finish the work started in #3211 , which stopped alternative
runtimes but didn't restart containerd. I was able to run "minikube
start" with containerd locally with this change.
2018-11-16 11:48:24 -08:00
Anders Björklund
2ceec0d084
Add config parameter for the cri socket path ( #3154 )
...
* Add config parameter for the cri socket path
Closes #3153
* Remove stray newline, when not using criSocket
* Add the --cri-socket parameter to configuration
Also fix the syntax for CRI-O, adding unix://
2018-11-14 16:36:02 -08:00
mikeweiwei
3deef5345d
fix logging calls ( #3315 )
2018-11-13 13:53:50 -08:00
mooncake
1bdc7ba400
Fix typos: containg->contain, reconcilliation->reconciliation
...
Signed-off-by: mooncake <xcoder@tenxcloud.com>
2018-11-13 09:44:04 -06:00
xichengliudui
fd67b2ca80
Modify the correct function name
2018-11-13 09:43:40 -06:00
Bily Zhang
b9a4f9459f
Fix some typos ( #3302 )
...
Signed-off-by: mooncake <xcoder@tenxcloud.com>
2018-11-06 12:36:13 -05:00
xichengliudui
52f37d9623
Fix typo miniube-iso -> minikube-iso
2018-11-05 02:06:30 -05:00
Mark Gibbons
a70d60affa
Correction of image list for K8S v1.11.0
2018-10-30 12:43:10 +00:00
Thomas Strömberg
2621bb3a27
Merge pull request #3187 from tstromberg/consistent_err_formatting
...
Globally replace %s format directives with %v for error strings
2018-10-19 16:44:46 -07:00
Thomas Strömberg
b93c22b6ab
Merge pull request #3221 from tstromberg/iso_errors
...
Include ISO URL and reduce stutter in download error message
2018-10-19 16:18:53 -07:00
Thomas Stromberg
118e9cc016
Apply go 1.11 formatting using `gofmt -s -l -w`
2018-10-19 14:29:56 -07:00
Thomas Stromberg
13e580b588
Fix merge breakage.
2018-10-19 14:16:03 -07:00
Thomas Stromberg
72e596507a
Merge branch 'master' into consistent_err_formatting
2018-10-19 14:08:35 -07:00
Thomas Stromberg
3e256a0463
Fix accidental switch from Println to Printf
2018-10-19 13:48:25 -07:00
Balint Pato
ae9f4b20c7
minikube tunnel ( #3015 )
...
This commit introduces a new command, `minikube tunnel`, a LoadBalancer emulator functionality, that must be run with root permissions.
This command:
* Establishes networking routes from the host into the VM for all IP ranges used by Kubernetes.
* Enables a cluster controller that allocates IPs to services external `LoadBalancer` IPs.
* Cleans up routes and IPs when stopped (Ctrl+C), when `minikube` stops, and when `minikube tunnel` is ran with the `--cleanup` flag
2018-10-18 11:01:47 -07:00
Mark Gibbons
115e48a13b
Updated to add parsing for k8s v1.11
2018-10-18 06:32:51 +01:00
Nicholas Irving
aca02f4fa5
Resolved ordering issue
2018-10-16 22:26:52 +11:00
Nicholas Irving
c05b9697f1
this attempts to resolve
...
https://github.com/kubernetes/minikube/issues/2768
for Windows, by converting \ in directory string to / and using
`path.Join` instead of `filepath.Join` which uses Unix format
instead of using he current OS directory delimeter.
2018-10-16 22:12:52 +11:00
Mark Gibbons
fb68def3ba
Fixes for caching issues
2018-10-14 19:31:55 +01:00
Thomas Strömberg
7365178d53
Merge pull request #3180 from outcoldman/k8s-1.12
...
Initial support for Kubernetes 1.12+
2018-10-05 13:03:21 -07:00
Thomas Stromberg
7e54a16d60
Include ISO URL in download error, make output slightly easier to read.
2018-10-05 12:50:47 -07:00
Denis Gladkikh
cf439dd059
Remove token created by kubectl upgrarde
2018-10-05 12:24:52 -07:00
Thomas Strömberg
583937ac3e
Merge pull request #3210 from tstromberg/dashboard_on_demand
...
Use "kubectl proxy" instead of a NodePort to expose the dashboard.
2018-10-04 14:42:41 -07:00
Thomas Strömberg
36d76c72ff
Merge pull request #3183 from tstromberg/k8s_releases_json_dep
...
Remove refs to k8s_releases.json now that `get-k8s-versions` is gone.
2018-10-04 14:42:12 -07:00
Thomas Stromberg
687b62cfe7
Let gofmt 1.10.4 rewrite service_test.go.
...
NOTE: This differs against what 1.11 would do, but matches our current
Travis CI configuration.
2018-10-04 13:40:08 -07:00
Thomas Stromberg
dc6d1bab8d
Merge branch 'master' into dashboard_on_demand
2018-10-04 13:38:49 -07:00
Fernando Diaz
2ebdf5e1eb
Enhance the Ingress Controller Addon ( #3099 )
...
- Updates Ingress-Controller Version to 0.19.0
- Adds Service Account for Ingress-Controller
- Adds Support for Prometheus
- Fixes bug with TCP/UDP ConfigMaps not Loading
- Adds more resource limits to default-backend
- Use new ingress class name
- Use app.kubernetes.io/xxxxxxxxxxx labels
2018-10-04 16:13:53 -04:00
Thomas Stromberg
7feb46edcb
Removed unneccesary changes to download errors
2018-10-03 15:16:37 -07:00
Thomas Stromberg
8fd45bc751
Block until the proxy URL is healthy.
...
This is necessary now that there is no proper service endpoint to block
on.
2018-10-03 13:00:13 -07:00
Thomas Stromberg
bc2dbe3b08
Improve readability of ISO download errors + include URL.
...
This is a separate issue I bumped into while developing the dashboard
PR.
2018-10-03 12:56:54 -07:00
Thomas Stromberg
df54c6a5b4
Use "kubectl proxy" instead of a NodePort to expose the dashboard.
...
This provides an additional level of security, by enforcing host checking, applying port randomization, and requiring explicit user intent to expose the service to the host.
2018-10-02 22:25:45 -07:00
Thomas Stromberg
3706b3b8ac
Fix dangling format issues.
2018-09-28 16:48:37 -07:00
Thomas Stromberg
e0080c074c
fix: Wrapf format %s has arg perms of wrong type int
2018-09-28 16:38:56 -07:00