even longer timeout + timeout error is retriable now (#3370)

* even longer timeout + timeout error is retriable now
* fix for debugging when tunnel test has issues
pull/3286/head
Balint Pato 2018-11-27 13:58:26 -08:00 committed by GitHub
parent dc340b06d8
commit 47579273d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 2 deletions

View File

@ -20,6 +20,7 @@ import (
"bytes"
"encoding/json"
"html/template"
"net"
"strings"
"github.com/golang/glog"
@ -122,6 +123,10 @@ func elevateKubeSystemPrivileges() error {
}
_, err = client.RbacV1beta1().ClusterRoleBindings().Create(clusterRoleBinding)
if err != nil {
netErr, ok := err.(net.Error)
if ok && netErr.Timeout() {
return &util.RetriableError{Err: errors.Wrap(err, "creating clusterrolebinding")}
}
return errors.Wrap(err, "creating clusterrolebinding")
}
return nil

View File

@ -118,7 +118,7 @@ const (
GithubMinikubeReleasesURL = "https://storage.googleapis.com/minikube/releases.json"
DefaultWait = 20
DefaultInterval = 6
DefaultK8sClientTimeout = 10 * time.Second
DefaultK8sClientTimeout = 60 * time.Second
DefaultClusterBootstrapper = "kubeadm"
)

View File

@ -46,7 +46,9 @@ func testTunnel(t *testing.T) {
runner := NewMinikubeRunner(t)
go func() {
output := runner.RunCommand("tunnel --alsologtostderr -v 8 --logtostderr", true)
t.Log(output)
if t.Failed() {
fmt.Println(output)
}
}()
err := tunnel.NewManager().CleanupNotRunningTunnels()