78ed12265d
Add testing for Start function, make addon enablement testable
2020-01-31 12:19:25 -08:00
6cd3b41bc8
Fix spacing in vm driver selection log
2020-01-31 11:43:18 -08:00
ce68dd19b6
Merge branch 'master' into addons-on-startup
2020-01-31 08:23:21 -08:00
b97124207c
Move addon enablement to addons module + lint fixes
2020-01-30 17:46:25 -08:00
fefa13e9da
Remove some redundance words
...
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-31 08:25:27 +07:00
41687346e3
make it less than 80
2020-01-30 16:06:27 -08:00
d5a83c7b24
Add addon enablement to start
2020-01-30 15:54:04 -08:00
6bd48a86c9
Explicitly say that a cluster is nonexistent
2020-01-30 14:41:45 -08:00
4309de6e8e
Merge pull request #6431 from tstromberg/missing-status-test
...
Add missing status test
2020-01-30 13:05:39 -08:00
d454148990
Add missing status test
2020-01-30 10:16:43 -08:00
3cbe879d7e
node add works
2020-01-30 09:02:01 -08:00
593d3fc73e
moving packages around
2020-01-28 17:09:00 -08:00
178a3a256f
add container runtime info to profile list
2020-01-28 16:40:53 -08:00
317dd41138
moving node package around
2020-01-27 17:59:35 -08:00
8db7f59b1e
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-01-24 16:08:22 -08:00
9a49c587d5
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-01-24 15:54:04 -08:00
82e096a7a1
Merge pull request #6390 from medyagh/kic_bindip
...
kic driver: add multiple profiles and ssh
2020-01-24 15:45:51 -08:00
c6c0046c57
let docker/podman choose hostbind port
2020-01-24 14:15:48 -08:00
c4e390f95c
missed one file
2020-01-24 13:57:47 -08:00
58ba813a9c
controlplane and worker are bools now magiiiiic
2020-01-24 13:54:41 -08:00
0b460e6cb7
master is no longer a thing
2020-01-24 13:24:38 -08:00
ad03309ab6
Adding the initial node cmd and pkg files
2020-01-24 11:40:27 -08:00
9953cc2250
GetMasterNode -> MasterNode
2020-01-24 11:14:55 -08:00
dbeac1b08c
KubernetesConfig.ContainerRuntime
2020-01-24 10:53:18 -08:00
77d838d3d2
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-01-24 10:50:57 -08:00
a9bc13b403
Address pause code review feedback
2020-01-23 15:44:30 -08:00
6a01d6b25b
prefer getting master node over calling Nodes[0]
2020-01-23 13:26:50 -08:00
791f28ff4c
things work now
2020-01-23 13:21:21 -08:00
8b2a05a565
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-01-22 17:18:30 -08:00
1a13055d00
Add integration tests
2020-01-22 15:50:09 -08:00
22de8c110a
Return the number of containers paused
2020-01-22 15:07:44 -08:00
62a72f44e8
Address feedback
2020-01-22 14:21:34 -08:00
5f0420f72e
Merge branch 'master' into pause
2020-01-22 09:48:26 -08:00
e6999caea3
Add paused state to apiserver status
2020-01-22 09:48:16 -08:00
09b2780fb2
Add support for pausing/unpausing specific namespaces
2020-01-21 22:06:05 -08:00
875c4b2d76
Merge pull request #6338 from medyagh/unify_boots
...
unify bootstrappers for both VM and contianer
2020-01-21 20:34:17 -08:00
7e2e9eb15b
Merge conflicts
2020-01-21 20:00:21 -08:00
7f3351476c
Merge upstream
2020-01-21 19:50:49 -08:00
be65e4c2ad
Merge upstream
2020-01-21 19:46:42 -08:00
5a3c13815e
network overlay only for kic
2020-01-21 15:14:51 -08:00
e3bd383d64
Merge pull request #6255 from afbjorklund/kubectl-examples
...
Fix syntax of minikube kubectl example command
2020-01-20 19:36:05 -08:00
e0a8b7dba8
Merge pull request #6325 from afbjorklund/dashboard-crash
...
Stop minikube dashboard from crashing at start
2020-01-20 19:34:18 -08:00
a681f1f00f
Remove stray space from driver selection message
2020-01-20 21:18:34 +01:00
6b0c69986f
Merge remote-tracking branch 'origin' into node-name
2020-01-18 08:09:51 +08:00
774bd5f174
Merge branch 'm2' of github.com:sharifelgamal/minikube into m2
2020-01-17 15:45:11 -08:00
df3dc976b0
let's actually save the node config
2020-01-17 15:44:56 -08:00
0b2d8051bb
remove kicbs
2020-01-17 15:44:22 -08:00
01f6cefd2a
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-01-17 13:28:53 -08:00
9b455aafc4
Customizing host path for dynamically provisioned PersistentVolumes
...
This fix contains few things:
* Used k8s.gcr.io/debian-base-amd64:v2.0.0 as base image to build storage-provisioner
* Modify RBAC permission used to cluster-admin
* Build storage-provisioner as static binary
2020-01-16 12:23:26 +11:00
010d0d4091
adding experimental string to driver detection string
2020-01-15 16:22:48 -08:00
d0fb749842
add displaysupporteddrivers func
2020-01-15 16:03:37 -08:00
a13ea9bea0
add the ability to mark drivers as experimental and mark the docker driver as such
2020-01-15 15:21:47 -08:00
b7f3ff7ead
Stop minikube dashboard from crashing at start
...
If the profile does not exist, it cannot load
2020-01-15 21:32:40 +01:00
804ee14a95
removing node surface stuff for a different PR
2020-01-15 11:36:36 -08:00
dc6c9d7d75
cfg config fun
2020-01-14 16:49:13 -08:00
2c301bd4ef
more node changes yay
2020-01-14 14:25:20 -08:00
2813cf4120
Merge branch 'master' of github.com:sharifelgamal/minikube into m2
2020-01-14 13:44:40 -08:00
71b561e344
Add note to remember to end the minikube flags
...
And add some whitespace before the next section
2020-01-14 18:22:45 +01:00
f645850842
add example to tunnel help
2020-01-13 16:16:36 -08:00
8718a54d91
Merge pull request #6256 from tstromberg/dry-run
...
Add --dry-run option to start
2020-01-13 13:37:15 -08:00
2e3d3e0add
Merge pull request #6274 from medyagh/add_table
...
Improve "addon list" by viewing as a table
2020-01-13 12:54:51 -08:00
f5ce7d9e74
Merge pull request #6292 from afbjorklund/profile-version
...
Handle empty k8s version in existing profile
2020-01-13 12:50:14 -08:00
13e2a3e601
Merge pull request #6276 from tstromberg/qemu-system
...
Pass --kvm-qemu-uri value into kvm2 health check
2020-01-13 11:16:07 -08:00
94b03ff881
Handle empty k8s version in existing profile
2020-01-13 18:33:59 +01:00
1085d47a24
Pass in the value of *kvmQemuURI for behavioral consistency
2020-01-10 16:07:07 -08:00
6c7cadb371
make minikube addons list tabular
2020-01-10 15:39:22 -08:00
75082b6f7e
Merge pull request #6242 from afbjorklund/platform-arch
...
Only print the virtualization system if it exists
2020-01-10 10:39:26 -08:00
19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
...
Experimental verison of kic
2020-01-10 00:42:01 -08:00
b840d1ced0
Call goimports
2020-01-09 11:58:15 -08:00
7acf688f7a
Merge master
2020-01-09 11:13:25 -08:00
c5e917366f
Add --dry-run option to start
2020-01-09 11:10:23 -08:00
3207b27c11
Fix syntax of minikube kubectl example command
...
Need to terminate the minikube flags with --,
before starting with the kubectl command flags.
2020-01-09 19:52:58 +01:00
4a1f33e282
Adds cluster name to kubenetes config
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 20:00:40 +08:00
0512882520
Do not set host-override for kubelet by default
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 19:52:30 +08:00
40a011c49a
use api port for host binding port
2020-01-08 16:09:24 -08:00
cf9e6e512f
fix ineffectual assignment
2020-01-08 15:21:57 -08:00
039f53144a
Only print the virtualization system if it exists
...
Avoids output like (/arm64), with an extra slash
2020-01-08 23:06:59 +01:00
ddf5ab027a
add extra option fail swap for kic
2020-01-08 12:53:29 -08:00
5d8e9dbfc5
Support --force for overriding the ssh check
2020-01-08 11:23:15 -08:00
f46e11f14a
Fixes busybox nslookup does not support queryt type
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 22:31:45 +08:00
be7b52791a
Remove unused var
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 15:41:07 +08:00
96398c73ad
Merge remote-tracking branch 'origin/master' into node-name
2020-01-08 14:45:21 +08:00
d3ff888743
Use profile name as the node name
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 14:42:17 +08:00
f80572bb4c
code review
2020-01-07 13:59:41 -08:00
618b150bcd
fix setup kubeconfig for kic
2020-01-07 13:54:00 -08:00
d298593d8a
refactor api server verification
2020-01-07 13:54:00 -08:00
e9b7451278
auto set podsubnet for kic improve none auto set
2020-01-07 13:54:00 -08:00
860ce25bf2
Add podSubnet to templates
2020-01-07 13:54:00 -08:00
c7bc61af2c
Add overlay network for kic
2020-01-07 13:54:00 -08:00
6cf2554877
add flag for kic host binding port
2020-01-07 13:54:00 -08:00
a358aff093
fix ocibinary
2020-01-07 13:52:47 -08:00
19e7ea4c40
Merge pull request #6217 from tiendc/unit_test_config_get
...
Add unit test for cmd/minikube/cmd/config/get.go
2020-01-07 11:48:11 -08:00
d23b446d2e
Merge pull request #6218 from afbjorklund/reportcard-minor
...
Improve reportcard by refactoring and commenting
2020-01-07 11:42:55 -08:00
60f514c0a5
Add unit test for cmd/minikube/cmd/config/set.go
...
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
2020-01-07 14:02:05 +07:00
af4ee5cf1f
Merge pull request #6124 from priyawadhwa/addon-per-profile-refactor
...
Enable or disable addons per profile
2020-01-06 16:33:01 -08:00
ea7a2d7e33
Improve reportcard by refactoring and commenting
...
golint: 99%
pkg/minikube/localpath/localpath.go
Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
pkg/minikube/cluster/cluster.go
Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
cmd/minikube/cmd/start.go
Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
743c67d40e
Add unit test for cmd/minikube/cmd/config/get.go
...
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
2020-01-06 18:49:31 +07:00
81622e2a00
Minor: change assignment to declaration
...
"warning: ineffectual assignment to updated (ineffassign)"
2020-01-04 10:23:16 +01:00
73608d60e4
Set node name the same as host name by default for none driver
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-03 00:32:05 +08:00
914c34cc2a
Set node name in non-default profile
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-01 13:45:05 +08:00
f9ed4a6460
Allow user to override node name
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-01 13:45:03 +08:00
e47cde6ae4
Rebased on master, moved istio addon into new package
2019-12-30 10:10:05 -05:00
df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
...
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
c2ba574f2e
generate istio document page and layout
2019-12-26 14:35:13 +08:00
f42c8a49fb
fixed comment
2019-12-21 18:34:40 +07:00
76714aca84
implemented options command #5036
...
This is to fix help command showing invalid "minikube <command> options".
It happened because minikube reuses kubectl templates which expects
options cmd to be there.
2019-12-21 11:09:36 +07:00
d5f56477bc
code review resolve
2019-12-20 17:14:14 -08:00
3b2cfa6c32
rename funcs
2019-12-20 16:53:35 -08:00
83cd426436
refactor more
2019-12-20 16:11:05 -08:00
cf6bde8eaf
refactor image specific funcs to image package
2019-12-20 16:05:08 -08:00
be8a1ad107
resolve code reviews
2019-12-20 12:43:13 -08:00
6c25cd3848
Rebased on master
2019-12-20 12:34:48 -08:00
5eb384cf7d
check error and fix logging msg
2019-12-20 12:24:05 -08:00
a3e16fae72
add reload command
2019-12-20 12:06:26 -08:00
2d1fffe1d1
better names
2019-12-20 12:06:26 -08:00
679a9c114b
more clear func names
2019-12-20 12:06:26 -08:00
71a896fc0a
unexport func cacheImage
2019-12-20 12:06:25 -08:00
193d16dd0c
rename funcs for more clarity
2019-12-20 12:06:25 -08:00
03c717c7b0
unexport cacheImagesInConfigFile func
2019-12-20 12:06:25 -08:00
031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
...
kic-xmas edition
2019-12-20 11:40:46 -08:00
1014a57ea8
better names for bs type
2019-12-20 01:01:10 -08:00
bf183603c5
Disable StartHost retry. It caused more problems than it solved
2019-12-19 16:10:44 -08:00
b64a33a6e9
updated dashboard command to use new addons library
2019-12-19 15:39:29 -08:00
4fd929deeb
Merge branch 'master' of github.com:kubernetes/minikube into compare
2019-12-19 14:03:20 -08:00
fa08e18e8d
goimports
2019-12-19 13:33:19 -08:00
859420c083
Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor
2019-12-19 13:06:07 -08:00
f6c61b7a80
Make sure minikube start --addons works
2019-12-19 12:44:32 -08:00
4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
...
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
aca49067fa
Merge pull request #6110 from digitalcoyote/master
...
Fixed IPv6 format for SSH
2019-12-19 11:51:55 -08:00
48b5a1e493
Merge branch 'master' of github.com:kubernetes/minikube into compare
2019-12-19 11:28:11 -08:00
1e5aeb6aa9
Addressed review comments
2019-12-19 11:27:53 -08:00
4c7b94971c
Address review comments
...
Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
2019-12-19 10:41:01 -08:00
3f20aa4e82
fix config import nonsense in start.go
2019-12-19 09:45:00 -08:00
6316959739
Fix update-context to use KUBECONFIG when the env is set and add integration test
2019-12-19 00:28:39 -08:00
921fee7432
Moved unit tests to addons package and refactored them
2019-12-18 22:02:10 -08:00
e72cb80cbf
Enable/disable addons works per profile
...
However, this means that addon information won't persist beyond a 'minikube delete'
2019-12-18 21:35:46 -08:00
b8d07daef3
move reusabe parts of kubeadm to a package
2019-12-18 17:22:42 -08:00
31ad90d3cb
Add place holder bootstrapper for kicbs
2019-12-18 16:11:50 -08:00
83374f4371
add querytype to nslookup
2019-12-18 15:54:36 -08:00
19560a631b
Add kic specific machine creation message
2019-12-18 15:53:34 -08:00
2243847f98
add kic command runner to machine
2019-12-18 13:57:32 -08:00
c627f58fbb
add default image
2019-12-18 13:04:09 -08:00
ba8b723978
Move addon related logic to pkg/addons for better organization
2019-12-18 11:31:29 -08:00
98508253a5
--download-only should download drivers
2019-12-18 09:46:36 -08:00
b6dbf3bd0d
add auto-set container-runtime for kic
2019-12-17 22:19:39 -08:00
e46c586764
more refactor fun
2019-12-17 15:53:37 -08:00
119d95cb31
Fixed format of IPV6 address and port
2019-12-17 13:23:30 -06:00
c295dfd25c
more node crud stuff
2019-12-17 09:00:48 -08:00
a840cb7289
Fix update-context to use KUBECONFIG when the env is set and add integration test
2019-12-17 00:58:45 +09:00
9f2217d803
sketches of the node commands
2019-12-12 17:38:29 -08:00
47d918f1b3
making more arbitrary node changes
2019-12-12 10:35:33 -08:00
661ebf843f
Merge master
2019-12-10 14:07:02 -08:00
349f414dee
Merge pull request #5987 from medyagh/cache_fix2
...
cache add: load images to all profiles & skip previously cached images
2019-12-10 13:58:57 -08:00
14b805d494
Remove unused vars
2019-12-10 08:17:08 -08:00
8b7aaba627
Sync correct Kubernetes versions from kubeadm constants
2019-12-10 08:12:15 -08:00
434648c6fc
Merge pull request #5773 from priyawadhwa/pr-bot
...
Add skeleton for performance analysis service
2019-12-09 18:26:45 -08:00
60346821d6
move machine path to localpath package
2019-12-09 14:51:10 -08:00
35ad8e2915
make profile name mandatory for config.Load
2019-12-09 14:47:20 -08:00
a6c749f905
Merge pull request #5798 from nanikjava/f-fix-2570
...
Make Kubernetes version sticky for a cluster instead of auto-upgrading
2019-12-09 13:47:44 -08:00
1f36a42203
Merge pull request #5912 from tstromberg/user-mutex2
...
Make lock names uid and path specific to avoid conflicts
2019-12-09 13:34:56 -08:00
4b78f7bd48
Rebased on head, resolved merge conflict
2019-12-09 12:03:37 -08:00
d7b6e66038
fix unit tests and improve naming
2019-11-26 20:07:56 -08:00
95717c4793
add status to profile list
2019-11-26 19:53:27 -08:00
cdb68a139e
refactor config to allow load profile config
2019-11-26 18:32:59 -08:00
6c08fedf97
remove cyclic depdenecy and make cluster pkg smaller
2019-11-26 17:48:37 -08:00
3574879fde
rebased on master
2019-11-26 10:32:32 -08:00
72e973027d
Merge pull request #5955 from cheeseandcereal/fix_profile_list_json
...
Fix profile list json command output
2019-11-25 14:59:11 -08:00
c462862a38
Merge pull request #5964 from afbjorklund/config-runtime
...
Fix validation of container-runtime config
2019-11-25 13:19:23 -08:00
3451320ad2
Fix validation of container-runtime config
...
It was trying to load (non-existing) config,
and also confusingly looking for containerd.
Add a unit test as well.
2019-11-23 10:35:12 +01:00
64ee657c49
Fix some bugs, add some logging, have a turkey
2019-11-22 16:12:24 -08:00
337db1707d
First pass at multi-runtime pause/unpause
2019-11-22 15:11:51 -08:00
fbb1d97cf1
feat(virtualbox): Users and set nat-nic-type and host-only-nic-type
2019-11-22 13:50:12 -05:00
f8a2d1da07
fix profile list json command output
...
Signed-off-by: Adam Crowder <adam@adamcrowder.net>
2019-11-20 13:58:05 -08:00
f680d1b1fc
Fix --kubernetes-version for upgrading cluster to correct version
...
This PR fix the issue of checking kubernetes-version and upgrading it. The fix now
will do the following
* Not specifying the --kubernetes-version flag means just use the currently deployed version.
* If an update is available inform the user that they may use --kubernetes-version=<version>.
* When --kubernetes-version is specifically set, upgrade the cluster.
Also add integration testing to test upgrading and downgrading
2019-11-16 21:12:54 +11:00
557339acc2
Recover from aborted kubeadm runs by checking for file existence
2019-11-14 15:00:56 -08:00
1c46502f35
Merge pull request #5848 from hypnoglow/try-ssh-retry
...
Add retry to SSH connectivity check
2019-11-14 14:08:41 -08:00
a750524774
Fix test that made assumption that minikube was valid
2019-11-14 10:56:44 -08:00
33293ed689
Retry on SSH connectivity check
2019-11-13 22:23:50 +03:00
2411895715
Clarify restart code, remove duplicate health check
2019-11-12 21:29:53 -08:00
4ae939244c
Clarify help text for --wait, take #2
2019-11-12 14:23:39 -08:00
55a7002ed7
Clarify help text for --wait
2019-11-12 14:22:53 -08:00
dc3a50e026
Make --wait=false wait for nothing again, change default to --wait=true
2019-11-12 13:38:48 -08:00
c03aee8322
Refactor config.Config to prepare for multinode ( #5889 )
...
* Refactor config.Config to prepare for multinode
* merge conflict
2019-11-11 17:52:15 -08:00
fb5430fd97
Getting rid of GetMachineName() ( #5868 )
...
* removing GetMachineName()
* replacing GetMachineName with a config lookup
* fix tests
* making unit tests happy
* fixing concurrent map writes, only right to viper once
* debugging
* one last test fix
* DeleteAlwaysSucceeds should actually always succeed
* prevent panic when deleting nonexistant cluster
* remove last GetMachineName reference
2019-11-11 14:47:47 -08:00
3f98e12fa9
Remove redundant return
2019-11-11 12:16:13 -08:00
82231dc0ee
Merge
2019-11-11 08:38:29 -08:00
1d0ca6cd68
Merge pull request #5854 from tstromberg/driver-compat-msg
...
Improve message when selected driver is incompatible with existing cluster
2019-11-11 08:22:57 -08:00
108fd082b5
change name monitor to pr-bot
2019-11-07 10:48:55 -08:00
79fcf7172d
Merge pull request #5845 from tstromberg/none-memory
...
none driver: Warn about --cpus, --memory, and --container-runtime settings
2019-11-07 06:54:45 -08:00
9d0c3eda8e
Remove extra word
2019-11-06 15:56:11 -08:00
1b9955f3d6
Improve message when selected driver is incompatible with existing cluster
2019-11-06 15:53:42 -08:00
b02b4e158a
Avoid panic and output correct driver name
2019-11-06 14:18:28 -08:00
6ff68709dd
Merge pull request #5243 from rajalokan/remove-heapster
...
Remove heapster addon
2019-11-06 11:35:35 -08:00
0af762e51f
none driver: Add warnings about --cpus, --memory, and --container-runtime
2019-11-06 10:29:02 -08:00
fb3360da06
Check health of drivers from existing configs
2019-11-05 17:16:23 -08:00
9c2b554ce7
Merge branch 'master' into better-existing-start
2019-11-05 15:04:22 -08:00
8809ab113a
Validate existing drivers too
2019-11-05 14:59:12 -08:00
47fe5b2822
Remove ping, was added in merge conflict
...
Supposed to be removed in 361222f
2019-11-02 08:59:19 +01:00
df1175f51f
Merge branch 'master' into reportcard-again
2019-11-01 18:32:37 +01:00
d7569b375c
Merge pull request #5803 from tstromberg/allow-force
...
Allow CPU count check to be disabled using --force
2019-10-31 12:03:13 -07:00
9cfd2073ba
Allow CPU count check to be disabled using --force
2019-10-31 11:28:34 -07:00
361222f606
Make network validation friendlier, especially to corp networks
2019-10-31 09:49:41 -07:00
c34e865ab6
Improve warning message
2019-10-30 14:06:39 -07:00
e8be75c74a
Warning -> Warningf
2019-10-30 14:06:05 -07:00
4ce2f784f1
Fix failure issues with integration testing for service command
2019-10-30 13:57:08 -07:00
2c0f2a42dd
Append newline to --url output
2019-10-30 12:35:25 -07:00
f60764b07f
service: fix --url mode, add integration tests
2019-10-30 10:44:54 -07:00
ef398338d6
Merge pull request #5530 from medyagh/NewCmdRunner
...
Refactor command runner interface, allow stdin writes
2019-10-29 22:26:14 -07:00
169c3e7479
Add skeleton for performance scanning service
...
This service runs in a VM and is responsible for:
1. Determining which PRs need to be analyzed
2. Running mkcmp against each PR
3. Commenting the results on the PR via minikube-bot
This PR also moves the mkcmp code into its own directory.
2019-10-29 13:53:49 -07:00
74a5d477f2
Merge pull request #5718 from nanikjava/f-fix-test-disable-browser-test
...
Refactor to remove opening browser and just return url(s)
2019-10-29 13:51:33 -07:00
b4ce29d589
Merge pull request #5757 from priyawadhwa/wait_false
...
Set --wait=false to default but still wait for apiserver
2019-10-28 21:52:15 -07:00
994d093766
Add boolean to disable opening browser during test
...
The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.
The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
2019-10-29 13:23:41 +11:00
bd5840aacf
improve comments
2019-10-28 18:02:45 -07:00
f3b1a09c36
Clean up bootstrapper interface to accept list of pods to wait for
...
when waiting for the cluster to start up.
2019-10-28 17:34:04 -07:00
5f12e9afa1
Update docs and add error message to generate-docs
2019-10-28 17:12:03 -07:00
29a015b63f
remove more bin bash c
2019-10-28 14:10:22 -07:00
f5ad9014ae
Merge pull request #5758 from tstromberg/inverted-ssh
...
Do not check sshd for the none driver
2019-10-28 10:56:30 -07:00
f92b308f9a
Rebased on master
2019-10-28 10:46:35 -07:00
cf62ff62b2
Remove extra log
2019-10-28 10:46:14 -07:00
7900b63d2b
Wait for only apiserver by default
...
This PR changes --wait=false to be the default, but to still check for the apiserver in this case. If wait=true, we still wait for all pods to be up and running. This change should speed up `minikube start`, since we won't have to wait for other pods which can take a longer time to start up.
Ref #5681
2019-10-28 10:45:57 -07:00
b1fd21e118
Do not check sshd for the none driver
2019-10-28 10:35:20 -07:00
e2bbf7111e
Merge branch 'master' into NewCmdRunner
2019-10-27 00:18:00 -07:00
d635b8dfc7
Add comments as requested by golint
2019-10-26 13:16:29 +02:00
c3498c593b
Decrease cyclomatic complexity
...
Mostly by using the "extract method" pattern.
Here is the report (from gocyclo), before:
21 cmd runStart cmd/minikube/cmd/start.go:272:1
18 cmd validateNetwork cmd/minikube/cmd/start.go:982:1
16 cmd runDelete cmd/minikube/cmd/delete.go:90:1
16 cmd deleteProfile cmd/minikube/cmd/delete.go:177:1
2019-10-26 13:08:23 +02:00
991d84e9f5
Merge pull request #5732 from tstromberg/config-avail
...
Hide innocuous viper ConfigFileNotFoundError
2019-10-25 12:45:20 -07:00
e46502cfed
Add automatic selection message even when there is only one choice
2019-10-25 10:53:20 -07:00
416f132ebb
Pass --expected-default-driver to the test rather than minikube
...
Improve VBoxManage detection on Windows
Add missing install_test
2019-10-25 10:43:30 -07:00
a7a692d717
Hide viper ConfigFileNotFoundError
2019-10-25 10:37:33 -07:00
ddabc9ef47
remove extra error word
2019-10-24 14:20:07 -07:00
187dfe29f8
getting rid of some of bin bash -c
2019-10-24 14:13:51 -07:00
b0045275a9
Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2
2019-10-24 10:55:40 -07:00
8920a884c3
Minor improvements to the clarity of hypervisor errors
2019-10-24 07:45:40 -07:00
c925f65629
Warn about driver status, add more logging
2019-10-23 22:33:05 -07:00
bdd0f3831f
Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2
2019-10-23 22:15:27 -07:00
dcdac36e98
Add integration tests
2019-10-23 21:45:23 -07:00
5d4bf0848f
Merge branch 'master' into drv-select2
2019-10-23 14:09:03 -07:00
98b3aefcac
Merge pull request #5520 from theVDude/config-cleaup
...
Remove duplicate setting field in config
2019-10-23 11:44:53 -07:00
443ae74719
Make unit tests pass again
2019-10-23 09:34:32 -07:00
1fc11f56f1
Add logic for picking the default driver on a host
2019-10-22 20:38:30 -07:00
fbc1630fc5
Merge pull request #5611 from woodcockjosh/json-output-for-status
...
Add json output for status
2019-10-21 18:37:34 -07:00
64edf25cd5
Merge pull request #5658 from tstromberg/drv-reorg
...
Consolidate driver handling code in pkg/minikube/driver
2019-10-21 14:12:20 -07:00
6faf9cdbe7
lint and code review
2019-10-21 13:01:06 -07:00
f4e59d51be
Add unit tests
2019-10-21 11:55:43 -07:00
342397ab46
convert more to exec.Command
2019-10-21 11:40:10 -07:00
026120ab71
Merge pull request #5655 from tstromberg/simpler-kubectl-check
...
Improve kubectl skew check logic
2019-10-21 11:38:29 -07:00
6bd5d9b157
Merge remote-tracking branch 'upstream/master' into NewCmdRunner
2019-10-21 11:17:28 -07:00
7581cf3e0c
Address merge conflicts
2019-10-21 11:12:06 -07:00
5242dcb0b8
hook up mkcmp command to code to time 'minikube start'
2019-10-21 11:10:49 -07:00
ca7d378aaa
Change default status output to not include the ip. Simplify json output
2019-10-21 12:50:00 -05:00
6aaed92496
Add json output for status
2019-10-21 12:50:00 -05:00
cd9a6526d3
Merge pull request #5548 from blueelvis/5358-purge-flag-for-delete
...
Added flags to purge configuration with minikube delete
2019-10-21 10:26:36 -07:00
723e77ed62
Merge pull request #5601 from woodcockjosh/json-output-for-addons-list
...
Add JSON output for addons list
2019-10-21 10:25:24 -07:00
c8833827c1
Merge pull request #5624 from nanikjava/f-fix-4883
...
Add validation checking for minikube profile
2019-10-21 10:17:26 -07:00
523db2099c
Merge pull request #5640 from sharifelgamal/auto-download-off
...
add ability to override autoupdating drivers
2019-10-21 10:16:49 -07:00
fd5e1d30a1
Merge branch 'master' into simpler-kubectl-check
2019-10-21 10:09:36 -07:00
35f7c9f38a
Merge branch 'master' into drv-reorg
2019-10-21 09:50:08 -07:00
9f38ddff39
Merge pull request #5656 from tstromberg/driver-tests
...
Rewrite cmd/delete_test to run without side effects
2019-10-21 09:49:41 -07:00
667b8b9b5d
Merge pull request #5659 from priyawadhwa/skeleton
...
[performance] add Makefile rule and code skeleton for mkcmp
2019-10-21 09:45:49 -07:00
967ce4867d
Merge pull request #5663 from afbjorklund/lint-again
...
Pick some lint from the recent master commits
2019-10-21 09:44:14 -07:00
d411617f9c
Use opposite operator
2019-10-20 19:11:26 +05:30
b3ccd9ae46
Refactored Delete and fixed linting issues
2019-10-20 13:13:35 +05:30
88fd869a81
Merge branch 'master' into 5358-purge-flag-for-delete
...
# Conflicts:
# cmd/minikube/cmd/delete.go
# pkg/minikube/cluster/cluster.go
2019-10-20 12:14:44 +05:30
2ba9cb4c1a
refactoring for delete
2019-10-20 02:19:18 +05:30
96c39bf050
Pick some lint from the recent master commits
2019-10-19 09:37:20 +02:00
f2900c613e
fix linting error
2019-10-18 17:07:56 -07:00
91b744095d
Fix boilerplate
2019-10-18 17:06:06 -07:00
484a66e082
Add skeleton for mkcmp
...
This PR adds a skeleton for mkcmp, a binary to compare the performance
of two versions of minikube. It adds a Makefile rule out/mkcmp which
builds the binary.
2019-10-18 16:55:58 -07:00
56a23cab4a
Merge pull request #5654 from tstromberg/delete-anyways
...
Ensure that delete succeeds even if cluster is unavailable
2019-10-18 16:06:12 -07:00
13cba07ec8
Fix broken cluster_test
2019-10-18 15:48:26 -07:00
cedab9e0fb
Revert delete_test.go changes, moving to another PR
2019-10-18 15:22:01 -07:00
b9bd1ba8d6
Rewrite delete_test to run without side effects
2019-10-18 15:17:51 -07:00
7cb0cfdf79
Pass lint checks
2019-10-18 13:53:57 -07:00
15daa48ed7
Merge branch 'master' into drv-reorg
2019-10-18 13:01:10 -07:00
6d7d589a52
Consolidate driver-interaction code into pkg/minikube/driver
2019-10-18 13:00:07 -07:00
9db86d91fa
Merge pull request #5592 from tstromberg/sshcheck
...
Add networking validation to validateNetwork
2019-10-18 07:24:09 -07:00
489713b6a8
run goimports
2019-10-17 16:56:38 -07:00
b0109c094d
comparing uints are complicated
2019-10-17 16:56:03 -07:00
235f94c7da
Improve kubectl skew check logic
2019-10-17 16:29:15 -07:00
2180c1405b
Ensure that delete succeeds even if cluster is unavailable
2019-10-17 16:23:21 -07:00
dc94405a34
Merge branch 'master' of github.com:kubernetes/minikube into auto-download-off
2019-10-17 15:32:09 -07:00
a84b3a9c95
Merge pull request #5596 from nanikjava/f-fix-3329
...
Warn if incompatible kubectl version is in use
2019-10-17 15:23:13 -07:00
dd266c751f
Merge pull request #5554 from woodcockjosh/json-output-for-profile-lists
...
Add json output for profile list
2019-10-17 15:21:24 -07:00
ccc2042861
Merge branch 'master' into remove-heapster
2019-10-17 15:14:49 -07:00
b132b04809
Add json output for addons list
2019-10-17 16:47:43 -05:00
6d63e43caf
Merge pull request #5555 from woodcockjosh/fix-addons-output-format-option
...
Fix addons list output format option
2019-10-17 14:46:02 -07:00
824c911c42
Add validation checking for minikube profile
...
Fixes : #4883
New function ProfileNameInReservedKeywords(..) has been added inside
pkg/minikube/config/profile.go
The new function perform validation to make sure the profile name is not
in the list of keywords.
Following are the keywords that are used:
start, stop, status, delete, config, open, profile, addons, cache, logs
The checking is case insensitive to cover combo of upper and lower case
2019-10-18 08:40:18 +11:00
f74ac2095c
Merge pull request #5565 from RickyRajinder/enable-addons-when-minikube-not-running
...
Allow addon enabling and disabling when minikube is not running
2019-10-17 14:38:36 -07:00
acec7e5971
Merge pull request #5626 from govargo/fix-update-context
...
fix "minikube update-context" command fail
2019-10-17 14:29:07 -07:00
d758672c8b
Remove function exports for profile list output types
2019-10-17 16:15:15 -05:00
4b2f962f0c
Add json output for profile list
2019-10-17 16:15:15 -05:00
789cc7a55a
Restructure code based on PR comments.
...
* When nil is returned from function just return back
* Restructure the output so that it will make more sense
for the user
2019-10-18 08:07:09 +11:00
a6d7989bfc
add ability to override autoupdating drivers
2019-10-16 14:51:13 -07:00
8ca74ef186
Use the value of --image-repository for connectivity check
2019-10-16 13:38:47 -07:00
22f2fa7730
Merge branch 'master' into sshcheck
2019-10-16 13:25:45 -07:00
d2557e688c
fix kubeconfig.UpdateIP() argument order
2019-10-15 22:41:59 +09:00
749c34ae6c
adding a logging to make sure jenkins is running right thing
2019-10-12 10:30:54 -07:00
d13f58fc3b
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-11 23:04:23 +02:00
f39ecda4cb
Add tests for addons custom output format
2019-10-11 09:43:00 -05:00
9bf904141c
Warn if incompatible kubectl version is in use
...
Fixes : #3329
Modification is done inside start.go where additional checking on the
version returned via the kubectl CLI is checked.
Running 'kubectl version --output=json' will return both client
and server information.
2019-10-11 23:46:02 +11:00
96edacc0a9
Changed command runner
...
Fixed test
Print error message
Change minikube running check to after check if exists
Updates Set and adds test for disabling
Fix action for minikube not running
Fix import order
2019-10-11 00:09:28 -07:00
6c5e432b14
Merge pull request #4999 from bhanu011/master
...
Warn when a user tries to set a profile name that is unlikely to be valid
2019-10-10 12:46:22 -07:00
ae731d4393
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-10 21:22:45 +02:00
268ac04f00
Don't try curl with localhost proxies
2019-10-10 12:17:56 -07:00
76471ffda5
Improve error messages, add container registry check
2019-10-10 12:14:27 -07:00
5e71eba5f7
Remove unused enableUpdateNotification variable
2019-10-10 11:30:08 -07:00
79efa5452d
More comprehensive network checks
2019-10-10 11:26:09 -07:00
958c886f8a
Remove duplicate setting field in config
2019-10-10 13:24:02 -04:00
64f1e73a25
Addon heaspter is not in use
...
Fixes #5017 . As per discussion, needed a rebase and this PR is rebased
to latest master.
2019-10-10 21:38:14 +05:30
f111f09526
Modify shortlived variable name and improve --addons flag help message
2019-10-10 11:29:13 +09:00
76e5f7b4cd
remove repetitive addon list from command help and add --addons flag explanation to documents
2019-10-10 11:29:13 +09:00
1e11576c9a
Add addons flag to 'minikube start' in order to enable specified addons
2019-10-10 11:29:13 +09:00
fb0d042710
Attempt a better error message
2019-10-09 15:24:42 -07:00
bc74f960b0
Merge branch 'master' into sshcheck
2019-10-09 13:48:18 -07:00
cd592172f0
Validate TCP connectivity to the VM
2019-10-09 13:48:05 -07:00
e63ecbe3b1
switch pkgConfig to config
2019-10-09 11:45:00 -07:00
57e9592270
Merge branch 'master' into master
2019-10-09 11:35:46 -07:00
e15c72565c
revert unrelated changes
2019-10-09 10:17:47 -07:00
946afc584d
pointless import
2019-10-09 10:13:19 -07:00
dc0240ab75
remove unnecessary call
2019-10-09 10:01:12 -07:00
994606cdf4
Add libmachine debug logs back
2019-10-08 17:08:18 -07:00
fdf5345616
Fix addons list output format option
2019-10-07 09:18:43 -05:00
c4107aeece
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-06 14:22:05 +02:00
cb5055ef19
Fixed linting error
2019-10-06 16:32:24 +05:30
0945ed881b
Added flags to purge configuration
2019-10-06 16:17:30 +05:30
63497aa383
Merge pull request #5507 from woodcockjosh/add-dns-ingress-addon
...
Add ingress-dns addon
2019-10-05 19:49:59 -07:00
1efdf11abb
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-03 12:02:59 +02:00
22cfacee29
Add ingress-dns addon
2019-10-01 04:55:16 -05:00
3396f5b8ab
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-28 14:46:36 +02:00
630dba3af1
Merge remote-tracking branch 'origin/master' into crio-containerd-image-repo
2019-09-28 12:23:20 +08:00
90bf0f8ec5
Merge pull request #5439 from afbjorklund/current-context
...
Fix order of parameters to CurrentContext funcs
2019-09-27 16:32:23 -07:00
4551a17178
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-27 18:28:07 +02:00
291b60b4b7
move DefaultWait,DefaultInterval to service #5375
2019-09-27 07:59:46 +09:00
ea60470a6c
Move ConfigFile var into localpath #5375
2019-09-27 07:59:46 +09:00
32cae3b739
Add copyrights new file #5375
2019-09-27 07:59:46 +09:00
8bae58695b
Move GithubMinikubeReleasesURL into notify #5375
2019-09-27 07:59:46 +09:00
cf6e104f5c
Inline default flag values directly to where the flag is defined #5375
2019-09-27 07:59:46 +09:00
d023ac779e
Rename cacheImageConfigKey from cache #5375
2019-09-27 07:59:46 +09:00
878c3ca2b6
WIP: Remove all single-package constants from constants package #5375
2019-09-27 07:59:46 +09:00
7d0de97935
Merge pull request #5468 from yuxiaobo96/minikube-update3
...
fix-up typo
2019-09-26 11:18:52 -07:00
e8c997d573
Merge branch 'master' into DELETE_ALL_PROFILES
...
# Conflicts:
# cmd/minikube/cmd/delete.go
2019-09-26 19:27:33 +02:00
6d58c180da
Merge pull request #5422 from afbjorklund/reportcard-1.4
...
Improve reportcard
2019-09-26 09:59:50 -07:00
aefa95d137
fix-up typo
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-09-26 14:04:35 +08:00
47ec8d3431
Merge branch 'master' into DELETE_ALL_PROFILES
2019-09-25 20:43:03 +02:00
3ec82dd00d
Merge branch 'master' into DELETE_ALL_PROFILES
...
# Conflicts:
# cmd/minikube/cmd/delete.go
2019-09-25 20:42:33 +02:00
e6986aa943
Do not pass all the kubernetes config to runtime
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-25 08:13:04 +08:00
08161722b0
Adds PauseImage to get pause image names
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-25 08:12:32 +08:00
0306a8bd6f
Fixes CRI-O runtime not working with image repository flags
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-09-24 23:31:36 +08:00
8e138a7eea
Merge pull request #5441 from hwdef/fix-typo
...
Fix a variety of spelling mistakes and typos
2019-09-24 06:42:36 -07:00
b75d4abc16
Merge pull request #5363 from woodcockjosh/add-helm-addon
...
Add helm-tiller addon
2019-09-24 06:37:29 -07:00
bfc26bbdf0
fix spelling mistake
2019-09-24 11:18:53 +08:00
Thomas Stromberg
Priya Wadhwa
Kim Bao Long
Medya Gh
Sharif Elgamal
Medya Ghazizadeh
Anders F Björklund
Zhongcheng Lao
Nanik T
Dao Cong Tien
fenglixa
andylibrian
Kenta Iso
Curtis Carter
David Newman
Adam Crowder
Igor Zibarev
Josh Woodcock
cueo
Pranav Jituri
Marek Schwarz
RickyRajinder
Rob Bruce
Ruslan Gustomiasov
Y.Horie
yuxiaobo
hwdef