Commit Graph

2860 Commits (6f463931239d419b94b37e53f7304bdab5a64f2f)

Author SHA1 Message Date
Sharif Elgamal 8db7f59b1e
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-01-24 16:08:22 -08:00
Sharif Elgamal de0573784e
ok it builds again 2020-01-24 16:01:14 -08:00
Sharif Elgamal 9a49c587d5
Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-24 15:54:04 -08:00
Thomas Strömberg 892cfb8514
Merge pull request #6385 from tstromberg/faster-docker
Batch file manipulation calls to reduce number of redundant commands
2020-01-24 15:47:44 -08:00
Thomas Strömberg d8a5714b00
Merge pull request #6392 from tstromberg/v1.17.2-simple-bump
Update DefaultKubernetesVersion to v1.17.2
2020-01-24 15:46:21 -08:00
Thomas Strömberg 82e096a7a1
Merge pull request #6390 from medyagh/kic_bindip
kic driver: add multiple profiles and ssh
2020-01-24 15:45:51 -08:00
Sharif Elgamal 5c906d33f3
fix unit tests 2020-01-24 15:03:27 -08:00
Medya Gh 7cf8ed1edc lint 2020-01-24 14:52:27 -08:00
Medya Gh ba3965b076 specify SSH username 2020-01-24 14:42:28 -08:00
Medya Gh 83dd9fc4ff Bump kic base image for ssh 2020-01-24 14:20:49 -08:00
Medya Gh c6c0046c57 let docker/podman choose hostbind port 2020-01-24 14:15:48 -08:00
tstromberg 9aeae2df65 Fix tests 2020-01-24 13:57:07 -08:00
Sharif Elgamal 58ba813a9c
controlplane and worker are bools now magiiiiic 2020-01-24 13:54:41 -08:00
Sharif Elgamal 0b460e6cb7
master is no longer a thing 2020-01-24 13:24:38 -08:00
tstromberg dd4a089fa1 Merge branch 'faster-docker' of github.com:tstromberg/minikube into faster-docker 2020-01-24 13:21:04 -08:00
Thomas Stromberg 41709d2bb8 Merge branch 'master' into faster-docker 2020-01-24 13:20:33 -08:00
tstromberg 2e24d7a123 Combine error conditions 2020-01-24 13:08:26 -08:00
tstromberg 817da0e884 Merge branch 'master' into faster-docker 2020-01-24 11:59:26 -08:00
tstromberg c43aea690d Update DefaultKubernetesVersion to v1.17.2 2020-01-24 11:58:23 -08:00
Sharif Elgamal 0681830be4
io.ReadSeeker for all the Assets readers 2020-01-24 11:55:59 -08:00
Sharif Elgamal ad03309ab6 Adding the initial node cmd and pkg files 2020-01-24 11:40:27 -08:00
Sharif Elgamal 9953cc2250
GetMasterNode -> MasterNode 2020-01-24 11:14:55 -08:00
Sharif Elgamal 77d838d3d2
Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-24 10:50:57 -08:00
tstromberg 35f1e58583 Merge conflict 2020-01-24 10:40:26 -08:00
Medya Gh 2bd169f508 add config fields for kic SSH and API ports 2020-01-23 23:51:41 -08:00
Medya Gh ca0f4c7e20 generate ssh keys for kic container 2020-01-23 19:20:44 -08:00
Medya Gh 09d9d05c6b generate ssh certs for kic during creation 2020-01-23 18:43:26 -08:00
Medya Gh 3d5c9ae870 implement SSHPortName for kic 2020-01-23 18:28:32 -08:00
Medya Gh 1e05b11703 Add ssh to kic image 2020-01-23 18:24:51 -08:00
Medya Gh 773510b9c1 Add ssh to kic container image 2020-01-23 17:45:50 -08:00
Medya Gh 5191659ff2 bind ip use const instead of string 2020-01-23 17:28:30 -08:00
Thomas Stromberg a9bc13b403 Address pause code review feedback 2020-01-23 15:44:30 -08:00
Thomas Stromberg a8d3ef580b Merge branch 'pause' of github.com:tstromberg/minikube into pause 2020-01-23 15:06:37 -08:00
Sharif Elgamal fa4322e89a remove all references to MachineConfig.ContainerRuntime 2020-01-23 13:50:31 -08:00
Sharif Elgamal 6a01d6b25b prefer getting master node over calling Nodes[0] 2020-01-23 13:26:50 -08:00
Sharif Elgamal de3caceccb Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-23 13:21:38 -08:00
Sharif Elgamal 791f28ff4c things work now 2020-01-23 13:21:21 -08:00
Thomas Stromberg e9f6aa106f test fixing 2020-01-23 12:53:33 -08:00
Thomas Stromberg 412e78e54c minimize the number of commands executed 2020-01-23 11:11:28 -08:00
Thomas Stromberg a20942ff2d Merge branch 'master' into pause 2020-01-23 07:46:44 -08:00
Sharif Elgamal d7ea60d610 fix up tests for new config format 2020-01-22 18:49:58 -08:00
Sharif Elgamal 8b2a05a565 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-22 17:18:30 -08:00
Thomas Strömberg 5fa7935571
Merge pull request #6376 from priyawadhwa/fix-dashboard
Fix dashboard by using kubectl apply/delete instead of prune for addons
2020-01-22 16:03:18 -08:00
tstromberg 1a13055d00 Add integration tests 2020-01-22 15:50:09 -08:00
Priya Wadhwa 49b0cb1c9c create dashboard ns first so that everything else can be created after 2020-01-22 15:16:56 -08:00
Priya Wadhwa 8d8ea98378 check cmd.Remove error for linting 2020-01-22 15:11:33 -08:00
tstromberg 22de8c110a Return the number of containers paused 2020-01-22 15:07:44 -08:00
tstromberg b81960e37c Fix none driver 2020-01-22 14:28:18 -08:00
Priya Wadhwa 15a5209841 Update unit tests 2020-01-22 14:23:32 -08:00
tstromberg dccc41748b Merge branch 'master' into pause 2020-01-22 14:18:32 -08:00
Priya Wadhwa 7247a7dee6 Switched to using kubectl apply and kubectl delete for addons
kubectl apply with --prune wasn't working because it requires the
--namespace flag to be passed in and we have multiple namespaces for
addons.

We tried to split up addons within /etc/kubernetes/addons by
namespace, but this didn't work when disabling dashboard addon because
there were no files left in the kubernetes-dashboard subdirectory. So,
kubectl apply complained when trying to prune dashboard because no files
were being passed in.

So, I ended up removing all dependencies on prune and instead running
`kubectl apply` when enabling an addon and running `kubectl delete` when
disabling an addon.
2020-01-22 14:18:20 -08:00
tstromberg c83ee09417 Update Kubernetes libraries to v1.17.2 2020-01-22 14:10:53 -08:00
tstromberg 50cd0dbfba First stab at freezer checks 2020-01-22 13:55:01 -08:00
Medya Ghazizadeh 98ff78a762
Merge pull request #6266 from sshukun/improve-doc
Fix typo and improve documents
2020-01-22 13:15:51 -08:00
Priya Wadhwa de4ecb9706 Rebased on master 2020-01-22 13:10:50 -08:00
Priya Wadhwa 180b23f2c8 Save addons in subdirectories, separated by namespace
This way we can pass the correct --namespace flag into 'kubectl apply'
such that it works with '--prune' for kubectl >=v.17.0
2020-01-22 13:09:37 -08:00
Thomas Strömberg 1af9d83cd1
Merge pull request #6369 from priyawadhwa/refactor-crio
Remove unnecessary crio restart to improve start latency
2020-01-22 12:19:30 -08:00
Thomas Strömberg 6753c71b37
Merge pull request #6334 from priyawadhwa/remove-addon-manager
Remove addon manager
2020-01-22 12:19:17 -08:00
Medya Ghazizadeh abfcf79dfd
Merge pull request #6236 from tstromberg/image-panic
Check for nil ref and img before passing them into go-containerregistry
2020-01-22 12:06:36 -08:00
Priya Wadhwa 43259cc363 Reorganize buildroot.go by container runtime and remove unnecessary "sudo systemctl restart crio" to save time on 'minikube start' 2020-01-22 11:00:10 -08:00
Thomas Stromberg 5f0420f72e Merge branch 'master' into pause 2020-01-22 09:48:26 -08:00
Thomas Stromberg e6999caea3 Add paused state to apiserver status 2020-01-22 09:48:16 -08:00
Thomas Strömberg 8562d1c82d
Merge pull request #6362 from medyagh/kic_del
implement remove file for kic runner
2020-01-22 06:04:21 -08:00
Thomas Stromberg 09b2780fb2 Add support for pausing/unpausing specific namespaces 2020-01-21 22:06:05 -08:00
Medya Ghazizadeh 875c4b2d76
Merge pull request #6338 from medyagh/unify_boots
unify bootstrappers for both VM and contianer
2020-01-21 20:34:17 -08:00
Thomas Stromberg 0f40eef9a7 Merge conflicts 2020-01-21 20:06:03 -08:00
Thomas Stromberg a4add4ccbc Merge conflicts 2020-01-21 20:02:38 -08:00
Thomas Stromberg 7e2e9eb15b Merge conflicts 2020-01-21 20:00:21 -08:00
Thomas Stromberg be65e4c2ad Merge upstream 2020-01-21 19:46:42 -08:00
Thomas Stromberg 7fe786aca4 Merge upstream 2020-01-21 19:46:05 -08:00
Medya Gh 6ca7b74f8a implement reomve file for kic runner 2020-01-21 17:39:06 -08:00
Medya Gh 5a3c13815e network overlay only for kic 2020-01-21 15:14:51 -08:00
Zhongcheng Lao 6b0c69986f
Merge remote-tracking branch 'origin' into node-name 2020-01-18 08:09:51 +08:00
Medya Gh 7d07d0d61b ignore iptables for kic 2020-01-17 15:44:22 -08:00
Medya Gh 0b2d8051bb remove kicbs 2020-01-17 15:44:22 -08:00
Anders F Björklund 1c3e309c7a Merge branch 'master' into crio-conf 2020-01-17 23:46:48 +01:00
Medya Gh b63212eacf patch cgroup pr 2020-01-17 14:04:48 -08:00
Ruben 31fd6d9369 remove kubelet conf label 2020-01-17 07:43:50 -05:00
Ruben 076d855c12 Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-01-17 06:57:19 -05:00
Priya Wadhwa 28148c5f3d Remove addon manager 2020-01-16 11:47:01 -08:00
Sharif Elgamal e520566ec7 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-16 11:39:56 -08:00
priyawadhwa d310331b9d
Merge pull request #6046 from priyawadhwa/remove-addon-manager
Remove polling from addon manager
2020-01-16 11:32:30 -08:00
Sharif Elgamal b225e8ec86
Merge pull request #6326 from sharifelgamal/exp
add the ability to mark drivers as experimental
2020-01-15 17:29:13 -08:00
Nanik T 9b455aafc4 Customizing host path for dynamically provisioned PersistentVolumes
This fix contains few things:

* Used k8s.gcr.io/debian-base-amd64:v2.0.0 as base image to build storage-provisioner
* Modify RBAC permission used to cluster-admin
* Build storage-provisioner as static binary
2020-01-16 12:23:26 +11:00
Sharif Elgamal d0fb749842
add displaysupporteddrivers func 2020-01-15 16:03:37 -08:00
Sharif Elgamal a13ea9bea0
add the ability to mark drivers as experimental and mark the docker driver as such 2020-01-15 15:21:47 -08:00
Medya Ghazizadeh 6c45d66d84
Merge pull request #6287 from afbjorklund/cgroup-driver
Use CGroupDriver function from cruntime for kubelet
2020-01-15 14:46:31 -08:00
Chance Zibolski ca007f414b pkg/minikube: Update test fixtures to contain updated metrics listen addresses 2020-01-15 14:02:28 -08:00
Chance Zibolski 44c7c48d3e pkg/minikube: Configure etcd and kube-proxy metrics to listen on minikube node IP 2020-01-15 11:52:43 -08:00
Sharif Elgamal 804ee14a95 removing node surface stuff for a different PR 2020-01-15 11:36:36 -08:00
Sharif Elgamal f0372edff6
ok at least things build now 2020-01-15 10:59:30 -08:00
Priya Wadhwa 342b52b8cd Merge branch 'master' of github.com:kubernetes/minikube into remove-addon-manager 2020-01-14 16:16:42 -08:00
Sharif Elgamal 2c301bd4ef
more node changes yay 2020-01-14 14:25:20 -08:00
Sharif Elgamal 2813cf4120
Merge branch 'master' of github.com:sharifelgamal/minikube into m2 2020-01-14 13:44:40 -08:00
Priya Wadhwa f5be457399 fix unit tests 2020-01-14 12:12:47 -08:00
Medya Gh 577a04b02e disable istio provisioner by default 2020-01-14 12:05:32 -08:00
Priya Wadhwa 9a2de2ae7f Hook up new addon manager logic to existing addons code 2020-01-14 10:52:27 -08:00
Priya Wadhwa 2029d6012c Rebased on master 2020-01-14 10:27:39 -08:00
Anders F Björklund c017dc986c Merge branch 'master' into crio-conf 2020-01-14 18:10:14 +01:00
Anders F Björklund 708bf5c6d5 Revert unnecessary change to the extra flags order 2020-01-14 17:49:09 +01:00
Ruben c3bb3802e9 Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-01-13 21:12:07 -05:00
Medya Ghazizadeh 2d97a0d3b7
Merge pull request #6220 from afbjorklund/crictl-local
Use absolute path, when calling the crictl command
2020-01-13 14:31:01 -08:00
Medya Ghazizadeh 8718a54d91
Merge pull request #6256 from tstromberg/dry-run
Add --dry-run option to start
2020-01-13 13:37:15 -08:00
Anders F Björklund 9e317ac2bd Do not use an arch suffix for the coredns name
They are using multi-arch images instead...
So don't append something like -arm64 to it.

Just use e.g. "k8s.gcr.io/coredns:1.6.5",
and Docker will pull the right platform image.
2020-01-13 22:34:19 +01:00
Medya Ghazizadeh b665640421
Merge pull request #6277 from medyagh/kic_addon
add addons for kic
2020-01-13 12:56:06 -08:00
Thomas Stromberg 13873028ae Merge master 2020-01-13 12:46:47 -08:00
Anders F Björklund d265162fe2 Fix some minor issues from gofmt and golint 2020-01-13 21:38:59 +01:00
Medya Ghazizadeh 13e2a3e601
Merge pull request #6276 from tstromberg/qemu-system
Pass --kvm-qemu-uri value into kvm2 health check
2020-01-13 11:16:07 -08:00
Anders F Björklund f959a21d87 Make sure to pass runner to UpdateCluster runtime 2020-01-12 22:19:50 +01:00
Anders F Björklund 0e83dd4b4e Use the cgroup-driver from runtime for kubelet 2020-01-12 19:29:07 +01:00
Anders F Björklund 27f8adf912 Add CGroupDriver function to cruntime interface 2020-01-12 18:46:47 +01:00
Ruben eef0e52827 add more test files to 1.18 & 1.19 versions 2020-01-11 20:57:12 -05:00
Ruben e2c254fc74 change template name to 1.17 test files 2020-01-11 20:55:58 -05:00
Ruben f1557f2065 add more versions for testing 2020-01-11 20:54:28 -05:00
Ruben 453fb9fedb fix code format 2020-01-11 19:21:07 -05:00
Ruben 5fd6beacf9 Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-01-11 11:08:01 -05:00
Ruben ebecf33723 add podSubnet & certSANs from v1beta1 2020-01-11 10:09:01 -05:00
Medya Gh 62e3bc4b72 add addons for kic 2020-01-10 17:14:47 -08:00
tstromberg 1085d47a24 Pass in the value of *kvmQemuURI for behavioral consistency 2020-01-10 16:07:07 -08:00
tstromberg 5008d4cdc9 Explicitly set LIBVIRT_DEFAULT_URI default for health checking 2020-01-10 15:49:01 -08:00
tstromberg 0c07e80821 Remove unused import from merge 2020-01-10 09:55:50 -08:00
Thomas Strömberg 5568ab005a
Merge branch 'master' into unthread-start 2020-01-10 09:54:02 -08:00
Ruben 805f117765 fix imports 2020-01-10 07:28:41 -05:00
Ruben c7ded84576 resolving conflicts 2020-01-10 07:17:34 -05:00
Medya Ghazizadeh 19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
Experimental verison of kic
2020-01-10 00:42:01 -08:00
sshukun f98b5b85c7 Fix some typos and improve documents 2020-01-10 17:35:07 +09:00
Medya Gh 59ecf3fd06 rename verify pkg to kverify 2020-01-09 16:28:23 -08:00
Thomas Strömberg ef7469f3f3
Merge pull request #6261 from tstromberg/ssh_mock_race
ssh_mock: Copy buffer to avoid data race
2020-01-09 16:27:46 -08:00
Medya Gh b92c22ee5b remove debugging message 2020-01-09 16:16:53 -08:00
Thomas Stromberg 851d1d5d3a ssh_mock: Copy buffer to avoid data race 2020-01-09 16:04:54 -08:00
Medya Gh 9eb855a9c0 lint code 2020-01-09 15:58:31 -08:00
Medya Gh 7198566db7 fix test data for crio for new tmpl 2020-01-09 15:49:07 -08:00
Medya Gh 381187f339 fix test data for default 2020-01-09 15:43:58 -08:00
Thomas Stromberg 8895dacd1a De-parallelize GetServiceURL tests: the mocks are not thread safe 2020-01-09 15:42:05 -08:00
Medya Gh 2ed25c72af fix dns test data and also add tests for v17 2020-01-09 15:38:37 -08:00
Medya Gh 70f8b96d1f fix test data for options for new tmpl 2020-01-09 15:31:29 -08:00
Medya Gh aea63baa70 fix crio-options test data for new tmpl 2020-01-09 15:25:25 -08:00
Medya Gh 2f3ad44d78 fix test data for containerd tmpl 2020-01-09 15:14:58 -08:00
Medya Gh b4fa45fe39 fix testdata for cidr tmpl 2020-01-09 15:08:47 -08:00
Medya Gh 9a16a52e2f fix containerd tmplate unittest 2020-01-09 15:01:22 -08:00
Medya Gh 8403350a17 fix image unittest 2020-01-09 14:52:01 -08:00
Thomas Stromberg 4f3afcd1fa Merge branch 'master' into unthread-start 2020-01-09 14:50:17 -08:00
Thomas Stromberg 418082e368 Log machine name and how long we held the lock for 2020-01-09 14:46:56 -08:00
Medya Ghazizadeh 727beb50c7
Merge pull request #6240 from tstromberg/bitflip
Fix inverted logic for showing issue link
2020-01-09 14:10:11 -08:00
Thomas Stromberg e5fd7a6a81 Replace integration-test specific hacks with actual protection against racey events 2020-01-09 12:58:10 -08:00
Thomas Stromberg 7acf688f7a Merge master 2020-01-09 11:13:25 -08:00
Thomas Stromberg c5e917366f Add --dry-run option to start 2020-01-09 11:10:23 -08:00
Ruben 716abbb61a refactor template && change validation 2020-01-09 08:16:02 -05:00
Zhongcheng Lao 4a1f33e282
Adds cluster name to kubenetes config
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 20:00:40 +08:00
Zhongcheng Lao 0512882520
Do not set host-override for kubelet by default
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 19:52:30 +08:00
Zhou Hao 29deded5f4 proxy_test: improve TestIsValidEnv unit test
Add test under the ture case to complete this unit test.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-09 13:33:41 +08:00
Medya Gh b9f5afa8f9 fix unit tests kudebadm template crio 2020-01-08 17:21:49 -08:00
Medya Gh 890878b469 Fix unit tests and go tempalte block 2020-01-08 17:08:11 -08:00
Medya Gh 40a011c49a use api port for host binding port 2020-01-08 16:09:24 -08:00
Medya Gh 867f62a9e9 move more funcs to bsutil 2020-01-08 15:47:48 -08:00
Medya Gh b1242e29e3 unexport funcs in images package 2020-01-08 15:33:47 -08:00
Medya Gh cf9e6e512f fix ineffectual assignment 2020-01-08 15:21:57 -08:00
Medya Gh de0d603c7f convert base image to a const 2020-01-08 13:56:23 -08:00
Medya Gh 8a0c840e52 move kic docker image to minikube gcr 2020-01-08 13:52:07 -08:00
tstromberg f908468bec Fix inverted logic for showing issue link 2020-01-08 13:32:34 -08:00
Medya Gh 88bef295c8 remove debugging msgs and add sysverification ignore 2020-01-08 13:19:34 -08:00
Medya Gh ddf5ab027a add extra option fail swap for kic 2020-01-08 12:53:29 -08:00
Medya Ghazizadeh 6da07be75d
Merge pull request #6175 from q384566678/oci-remove-todo
pkg/drivers/kic/oci: delete TODO info
2020-01-08 10:40:32 -08:00
tstromberg 4a06fde1cf Check for nil ref and img before passing them into go-containerregistry 2020-01-08 10:02:11 -08:00
Zhou Hao 7e0b89cc9d code optimization
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-08 16:25:11 +08:00
Zhongcheng Lao 96398c73ad
Merge remote-tracking branch 'origin/master' into node-name 2020-01-08 14:45:21 +08:00
Medya Ghazizadeh 444b36161b
Merge pull request #6193 from q384566678/oci-status
kic/oci: parse all kind of states
2020-01-07 14:54:42 -08:00
Medya Gh 5a23d635d5 package comment 2020-01-07 14:49:05 -08:00
Medya Gh 4013158328 rename package to ktmpl 2020-01-07 14:16:16 -08:00
Medya Gh f80572bb4c code review 2020-01-07 13:59:41 -08:00
Medya Gh 07c0e32954 improve kic image 2020-01-07 13:54:00 -08:00
Medya Gh 77394db9aa add Dockerfile for kic images 2020-01-07 13:54:00 -08:00
Medya Gh 618b150bcd fix setup kubeconfig for kic 2020-01-07 13:54:00 -08:00
Medya Gh d76eb6d28c use net join for kubeconfig port 2020-01-07 13:54:00 -08:00
Medya Gh a64a2721d5 Add localhost to ca cert 2020-01-07 13:54:00 -08:00
Medya Gh d298593d8a refactor api server verification 2020-01-07 13:54:00 -08:00
Medya Gh e9b7451278 auto set podsubnet for kic improve none auto set 2020-01-07 13:54:00 -08:00
Medya Gh ae45bb75e3 add podsubnet to all tempaltes 2020-01-07 13:54:00 -08:00
Medya Gh 860ce25bf2 Add podSubnet to templates 2020-01-07 13:54:00 -08:00
Medya Gh 4dd9866e9d Add addons to kic too 2020-01-07 13:54:00 -08:00
Medya Gh c7bc61af2c Add overlay network for kic 2020-01-07 13:54:00 -08:00
Medya Gh 6cf2554877 add flag for kic host binding port 2020-01-07 13:54:00 -08:00
Medya Gh 35c47b9dc4 Ignore iptables for kic and fix chmod +x permission 2020-01-07 13:53:19 -08:00
Medya Gh ea207b34a1 add output to logs kubeadm init 2020-01-07 13:53:19 -08:00
Medya Gh 0b85aa9daf Add start restart to kic bs 2020-01-07 13:53:19 -08:00
Medya Gh 08c715af8b move verify clusters to its own package 2020-01-07 13:53:19 -08:00
Medya Gh af1b77a164 implement pull images for kicbs 2020-01-07 13:52:47 -08:00
Medya Gh 1de4adf273 Implement images list for kic 2020-01-07 13:52:47 -08:00
Medya Gh ac97b51058 implement setup certs for kicbs 2020-01-07 13:52:47 -08:00
Medya Gh a358aff093 fix ocibinary 2020-01-07 13:52:47 -08:00
Medya Ghazizadeh be79843f75
Merge pull request #6214 from laozc/hostport-join
Fixes IPv6 address handling in kubeadm
2020-01-07 11:45:32 -08:00
Medya Ghazizadeh d23b446d2e
Merge pull request #6218 from afbjorklund/reportcard-minor
Improve reportcard by refactoring and commenting
2020-01-07 11:42:55 -08:00
Thomas Strömberg af4ee5cf1f
Merge pull request #6124 from priyawadhwa/addon-per-profile-refactor
Enable or disable addons per profile
2020-01-06 16:33:01 -08:00
Priya Wadhwa 6ad7e4a9a0 address code review comments
add better error handling and remove duplication in enableOrDisableAddonsInternal
2020-01-06 13:42:09 -08:00
Anders F Björklund 655da9091c Make helper function less generic, to please lint
`getCommandPath` - `cmd` always receives `"crictl"` (unparam)
2020-01-06 18:33:07 +01:00
Anders F Björklund 4d0446afa5 Use absolute path, when calling the crictl command
To work on CentOS, which has a weird path in sudo
2020-01-06 16:55:05 +01:00
Anders F Björklund 118451f4b2 Refactor: move usage of crictl to cruntime package
We don't want the crictl or docker commands outside
2020-01-06 15:55:10 +01:00
Anders F Björklund 723f1f941b Update the crio.conf instead of overwriting it
We are only changing one config value, anyway
2020-01-06 15:19:57 +01:00
Anders F Björklund 024dfe18dc Refactor: move the crio config to the crio runtime
For some reason it was left with the generic CRI
2020-01-06 14:55:18 +01:00
Anders F Björklund ea7a2d7e33 Improve reportcard by refactoring and commenting
golint: 99%
	pkg/minikube/localpath/localpath.go
		Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
	pkg/minikube/cluster/cluster.go
		Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
	cmd/minikube/cmd/start.go
		Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
		Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
Kim Bao Long f388f69220 Remove duplicated words
Although it is spelling mistakes, it might make an affects while reading.

Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-06 15:54:27 +07:00
Zhongcheng Lao 5f8a4503eb
Fixes IPv6 address handling in kubeadm
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-05 23:37:00 +08:00
Zhou Hao 62bfc39404 Fix comment
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-03 09:31:55 +08:00
Zhou Hao c1859c44e3 kic/oci: parse all kind of states
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-02 14:16:54 +08:00
Zhongcheng Lao f9ed4a6460
Allow user to override node name
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-01 13:45:03 +08:00
Medya Ghazizadeh e5f5abda89
Merge pull request #6179 from q384566678/fix-pause
pkg/drivers/kic: fix wrong command in Unpause
2019-12-30 18:42:28 -08:00
Priya Wadhwa e47cde6ae4 Rebased on master, moved istio addon into new package 2019-12-30 10:10:05 -05:00
Zhou Hao 9c4e3fbd3c pkg/drivers/kic: fix wrong command in Unpause
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:54:48 +08:00
Zhou Hao ae61e56594 pkg/drivers/kic/oci: fix Status info
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:21:03 +08:00
Zhou Hao aa52255be0 pkg/drivers/kic/oci: delete TODO info
When the docker exit status is 125, it is not entirely certain that it is caused by duplicate names.There may also be other errors.
e.g:
➜  minikube git:(oci-remove-todo) ✗ docker run -itzz
unknown shorthand flag: 'z' in -zz
See 'docker run --help'.
➜  minikube git:(oci-remove-todo) ✗ echo $?
125

So delete this TODO info.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 14:43:11 +08:00
Medya Ghazizadeh df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
fenglixa c2ba574f2e generate istio document page and layout 2019-12-26 14:35:13 +08:00
Medya Ghazizadeh ce4b9503ae
Merge pull request #6137 from q384566678/add-constants-test
Add constants_test
2019-12-23 01:13:50 -08:00
Ruben 3bedd60e1c add v1beta2 condition 2019-12-22 15:47:16 -05:00
Ruben 0ce6a0303a add v1beta2 template 2019-12-22 15:46:55 -05:00
Medya Gh d5f56477bc code review resolve 2019-12-20 17:14:14 -08:00
Medya Gh 3b2cfa6c32 rename funcs 2019-12-20 16:53:35 -08:00
Medya Gh 83cd426436 refactor more 2019-12-20 16:11:05 -08:00
Medya Gh cf6bde8eaf refactor image specific funcs to image package 2019-12-20 16:05:08 -08:00
Medya Gh cde5503d3e add two mechanism to find local image digest 2019-12-20 14:09:18 -08:00
Medya Gh 9d03e56ece resolve merge conflict 2019-12-20 12:44:09 -08:00
Medya Gh be8a1ad107 resolve code reviews 2019-12-20 12:43:13 -08:00
Priya Wadhwa 6c25cd3848 Rebased on master 2019-12-20 12:34:48 -08:00
Medya Gh 5eb384cf7d check error and fix logging msg 2019-12-20 12:24:05 -08:00
Medya Gh 502f3b7f8f use docker cli lib to get image id 2019-12-20 12:18:55 -08:00
Medya Gh 4d9e53389a improve logging 2019-12-20 12:12:48 -08:00
Medya Gh 2d1fffe1d1 better names 2019-12-20 12:06:26 -08:00
Medya Gh 679a9c114b more clear func names 2019-12-20 12:06:26 -08:00
Medya Gh 71a896fc0a unexport func cacheImage 2019-12-20 12:06:25 -08:00
Medya Ghazizadeh 031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
kic-xmas edition
2019-12-20 11:40:46 -08:00
Zhou Hao 2167655006 add unit test for GetDNSIP
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-20 17:32:50 +08:00
Zhou Hao 6a5497510a add unit test for GetServiceClusterIP
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-20 17:27:24 +08:00
Medya Gh f9e7a54eb8 rename kicdocker to docker 2019-12-20 01:26:38 -08:00
Medya Gh f39ba0deb0 add unit test for feature gate supports 2019-12-20 01:17:33 -08:00
Medya Gh 1014a57ea8 better names for bs type 2019-12-20 01:01:10 -08:00
tstromberg cae166e74c Merge branch 'master' into advice-refresh 2019-12-19 16:23:25 -08:00
tstromberg f438bb7ec8 Merge branch 'master' into less-catastrophic 2019-12-19 16:15:47 -08:00
tstromberg 512b3cb314 Refresh advice, flip hide vs show default for links 2019-12-19 16:04:34 -08:00
Medya Gh 7360edc8e0 add kic cni 2019-12-19 15:11:22 -08:00
Priya Wadhwa 4fd929deeb Merge branch 'master' of github.com:kubernetes/minikube into compare 2019-12-19 14:03:20 -08:00
Priya Wadhwa 4ce8d7dc0c fix boilerplate 2019-12-19 13:58:13 -08:00
Priya Wadhwa 83aca57dd4 Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor 2019-12-19 13:20:12 -08:00
Priya Wadhwa 859420c083 Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor 2019-12-19 13:06:07 -08:00
tstromberg 6cc860e911 Add build tags so that the test only runs on Darwin 2019-12-19 13:05:47 -08:00
tstromberg 0796d866df Further clarification 2019-12-19 12:51:02 -08:00
Priya Wadhwa 624d47b781 Update unit tests 2019-12-19 12:47:20 -08:00
Thomas Strömberg 4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
Thomas Strömberg 28c4c82bd7
Merge pull request #5833 from govargo/fix-without-hyperkit-errormsg
Add hyperkit version check whether user's hyperkit is newer
2019-12-19 11:44:58 -08:00
Priya Wadhwa 48b5a1e493 Merge branch 'master' of github.com:kubernetes/minikube into compare 2019-12-19 11:28:11 -08:00
Priya Wadhwa 1e5aeb6aa9 Addressed review comments 2019-12-19 11:27:53 -08:00
Medya Gh cce503033d rename CreateParam to CreateConfig 2019-12-19 11:12:49 -08:00
Medya Gh e1d5704170 get rid of default oci 2019-12-19 11:08:05 -08:00
Medya Gh 6cbdfe3961 remove more codefrom node 2019-12-19 10:47:07 -08:00
Priya Wadhwa 4c7b94971c Address review comments
Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
2019-12-19 10:41:01 -08:00
Medya Gh 310cef80de get rid of node cache 2019-12-19 10:37:15 -08:00
Medya Gh f001dd703a convert kic restart to case switch 2019-12-19 10:01:18 -08:00
Medya Gh 80b15e8e6c Add comment for config structs 2019-12-19 09:52:53 -08:00
Zhou Hao d864ac3f04 pkg/util: add CalculateSizeInMB test
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
2019-12-19 18:36:05 +08:00
Medya Gh 6e87872fa1 make ConfigFileAssets more reusable 2019-12-19 01:19:32 -08:00
Medya Gh 62cd3102c0 move funcs to related files 2019-12-19 00:28:39 -08:00
Medya Gh 33523677bc unexport extraConfig 2019-12-19 00:28:39 -08:00
Medya Gh 5c445dcca2 unexport funcs and move to better place 2019-12-19 00:28:39 -08:00
Medya Gh 79657f904b unexport func 2019-12-19 00:28:39 -08:00
Medya Gh c4c87ef6e2 move test data 2019-12-18 23:20:42 -08:00
Priya Wadhwa 43a7267079 make public methods that aren't used outside of the package private 2019-12-18 22:33:00 -08:00
Priya Wadhwa ceb4938c7a Add more unit tests 2019-12-18 22:27:32 -08:00
Priya Wadhwa 921fee7432 Moved unit tests to addons package and refactored them 2019-12-18 22:02:10 -08:00
Priya Wadhwa e72cb80cbf Enable/disable addons works per profile
However, this means that addon information won't persist beyond a 'minikube delete'
2019-12-18 21:35:46 -08:00
Medya Gh 04c7e561db moving kubernetes config templates to a package 2019-12-18 17:30:19 -08:00
Medya Gh b8d07daef3 move reusabe parts of kubeadm to a package 2019-12-18 17:22:42 -08:00
tstromberg 36893766c4 Not a crash, but an error 2019-12-18 16:12:20 -08:00
Medya Gh 31ad90d3cb Add place holder bootstrapper for kicbs 2019-12-18 16:11:50 -08:00
Medya Gh 19560a631b Add kic specific machine creation message 2019-12-18 15:53:34 -08:00
Medya Gh 2243847f98 add kic command runner to machine 2019-12-18 13:57:32 -08:00
Medya Gh c627f58fbb add default image 2019-12-18 13:04:09 -08:00
Priya Wadhwa ba8b723978 Move addon related logic to pkg/addons for better organization 2019-12-18 11:31:29 -08:00
Medya Gh b6dbf3bd0d add auto-set container-runtime for kic 2019-12-17 22:19:39 -08:00
Medya Gh 2bf1289bf3 adding place holder for kicbs 2019-12-17 22:06:45 -08:00
Medya Gh 71b260292c remove more code 2019-12-17 21:53:36 -08:00
Medya Gh 12df013810 simplify overlaping structs 2019-12-17 21:36:37 -08:00
Medya Gh ca68beae6a remove not needed code 2019-12-17 19:33:54 -08:00
Medya Gh 0f77b9d7f2 change variable name 2019-12-17 19:03:49 -08:00
Medya Gh 5ae0c4d41b added docker to supported drivers 2019-12-17 18:45:10 -08:00
Medya Gh 7a433cc6a9 Add kic specifc fields to machine config 2019-12-17 17:47:37 -08:00
Kenta Iso b6506007b8 refactor: remove warning log to avoid duplicate logging and remove useless getter func 2019-12-18 10:36:50 +09:00
Kenta Iso 39f71346a6 rename constant name and shorten warining message of version old 2019-12-18 10:36:50 +09:00
Kenta Iso f9d4762765 Improve hyperkit specific version check 2019-12-18 10:36:50 +09:00
Kenta Iso fcbf4d1b4d Add hyperkit version checker: whether user's hyperkit is new 2019-12-18 10:36:50 +09:00
Medya Gh 379bf2ac0c fix boilerplate formats 2019-12-17 16:38:56 -08:00
Medya Gh 46df68ca4b move cri to oci package 2019-12-17 16:04:03 -08:00
Sharif Elgamal e46c586764 more refactor fun 2019-12-17 15:53:37 -08:00
Medya Gh 5c1145bcd8 add kic command runner 2019-12-17 15:32:06 -08:00
Medya Gh d7273d36c9 Add kic driver 2019-12-17 15:18:31 -08:00
tstromberg 04486049d2 Always transfer images when local reference lookups fail 2019-12-17 13:21:34 -08:00
Priya Wadhwa 84ce2dbd62 Fixed bug, using version when should use profile 2019-12-17 12:09:42 -08:00
Priya Wadhwa d21db02c76 Apply addons to all profiles 2019-12-17 11:58:26 -08:00
Priya Wadhwa 5003684b5b rebased on master 2019-12-16 10:49:55 -08:00
Sharif Elgamal 9f2217d803 sketches of the node commands 2019-12-12 17:38:29 -08:00
Sharif Elgamal 47d918f1b3
making more arbitrary node changes 2019-12-12 10:35:33 -08:00
Sharif Elgamal 6c8bcf0aa4
Merge branch 'm2' of github.com:sharifelgamal/minikube into m2 2019-12-11 13:07:47 -08:00
Sharif Elgamal de0fbca8b3 initial commit 2019-12-11 12:21:31 -08:00
Thomas Stromberg d811f6e428 Remove unused forceID var 2019-12-11 12:10:28 -08:00
Thomas Stromberg 3171493e51 Rename to PathMutexSpec 2019-12-11 12:01:32 -08:00
Thomas Stromberg c5f65baf61 Remove uid from hash name, as it is not necessary now that we lock on filenames rather than descriptive names 2019-12-11 11:52:36 -08:00
Thomas Stromberg 129b6a870b Update log messages 2019-12-11 09:54:44 -08:00
Thomas Stromberg af4e690837 Use sha1 for a larger hash, truncated to 40 chars 2019-12-11 09:14:20 -08:00
Thomas Stromberg cfe0f5a5b7 Use md5 to generate unique lock names 2019-12-11 08:13:12 -08:00
Thomas Stromberg bef508d461 Remove high-ASCII characters from comment 2019-12-10 15:23:47 -08:00
Thomas Stromberg a1ddd283fe Check errors, remove docker.io prefix used by crio 2019-12-10 14:28:40 -08:00
Priya Wadhwa e0b6a1eb49 Address review comments
Address nits and remove integration test to make sure addon manager pod
is up and running since we will no longer enable it by default.
2019-12-10 14:16:28 -08:00
Thomas Stromberg 661ebf843f Merge master 2019-12-10 14:07:02 -08:00
Thomas Stromberg 32e0732e15 Add integration test 2019-12-10 14:02:12 -08:00
Thomas Strömberg 349f414dee
Merge pull request #5987 from medyagh/cache_fix2
cache add: load images to all profiles & skip previously cached images
2019-12-10 13:58:57 -08:00
Thomas Strömberg 1592eef8f4
Merge pull request #5935 from tstromberg/up-add2
Pre-cache the latest kube-addon-manager
2019-12-10 13:53:12 -08:00
Priya Wadhwa 3a20cd75bf Add unit tests 2019-12-10 13:06:22 -08:00
Priya Wadhwa 686b0a68fa Use kubectl v1.13.2 as in the addon manager image for correct functionality 2019-12-10 12:46:54 -08:00
Medya Gh 7b8cfe167c lint 2019-12-10 11:23:02 -08:00
Thomas Strömberg ef51dfe8bb
Merge branch 'master' into up-add2 2019-12-10 10:45:53 -08:00
Medya Gh b7176b91fd Use a faster way to get image sha 2019-12-10 10:29:59 -08:00
Priya Wadhwa 4a45956178 Add unit tests 2019-12-10 10:08:23 -08:00
Thomas Stromberg 650c26309c Add missing files 2019-12-10 09:29:45 -08:00
Thomas Stromberg 14b805d494 Remove unused vars 2019-12-10 08:17:08 -08:00
Thomas Stromberg 8b7aaba627 Sync correct Kubernetes versions from kubeadm constants 2019-12-10 08:12:15 -08:00
Karuppiah Natarajan fc09dd4814
Update default Kubernetes version to v1.17.0
Signed-off-by: Karuppiah Natarajan <karuppiah7890@gmail.com>
2019-12-10 19:57:16 +05:30
Medya Gh 60346821d6 move machine path to localpath package 2019-12-09 14:51:10 -08:00
Medya Gh 35ad8e2915 make profile name mandatory for config.Load 2019-12-09 14:47:20 -08:00
Medya Gh 2895971182 Skip loading image if already cached based on sha 2019-12-09 14:30:55 -08:00
Thomas Stromberg df3ee00481 Update dashboard image and pre-cache it again 2019-12-09 14:13:50 -08:00
Thomas Stromberg a84db18fd7 Merge 2019-12-09 13:55:28 -08:00
Thomas Strömberg 1f36a42203
Merge pull request #5912 from tstromberg/user-mutex2
Make lock names uid and path specific to avoid conflicts
2019-12-09 13:34:56 -08:00
Thomas Strömberg 66d7124305
Merge pull request #5954 from olivierlemasle/storageclassannot
Remove depreacted annotation storageclass.beta.kubernetes.io
2019-12-09 10:50:32 -08:00
Thomas Strömberg 45c945f477
Merge pull request #5988 from medyagh/profile_status
show status in profile list
2019-12-09 10:43:11 -08:00
Priya Wadhwa 7477050192 Turn addon manager off by default
Add run kubectl apply command directly if addons are changed by the user if the addon manager is disabled.
2019-12-05 10:46:28 -08:00
Guilherme Pellizzetti 672b9de015
typo: Fix typo in err_map key
Change "MACHINE_DOES_NOT_EXST" to "MACHINE_DOES_NOT_EXIST".

Please disregard if not valid.
2019-12-03 20:42:18 -03:00
Wietse Muizelaar 2cc277af73
Use newer gvisor version
The current gvisor version used is quite old, this PR bumps the version to a more recent one.
2019-11-29 20:36:54 +01:00
Medya Gh d7b6e66038 fix unit tests and improve naming 2019-11-26 20:07:56 -08:00
Medya Gh 95717c4793 add status to profile list 2019-11-26 19:53:27 -08:00
Medya Gh d8d7849d21 fix typo and remove debugging logs 2019-11-26 19:20:38 -08:00
Medya Gh cdb68a139e refactor config to allow load profile config 2019-11-26 18:32:59 -08:00
Medya Gh 6c08fedf97 remove cyclic depdenecy and make cluster pkg smaller 2019-11-26 17:48:37 -08:00
Medya Gh 72b17439bd clean up temp files 2019-11-26 16:21:12 -08:00
Priya Wadhwa 3574879fde rebased on master 2019-11-26 10:32:32 -08:00
Priya Wadhwa 0cb99d5fef update boilerplate 2019-11-26 10:31:53 -08:00
Sharif Elgamal 0bfd81baec
Merge pull request #5973 from sharifelgamal/1.17-rc1
Update default k8s version to 1.17.0-rc.1
2019-11-25 18:20:12 -08:00
Medya Ghazizadeh 97b8ee82d1
Merge pull request #5919 from tstromberg/more-logs
Double lookBackwardsCount to 400, to find usage error in new apiserver
2019-11-25 14:13:24 -08:00
Sharif Elgamal bd96b736d3
update test cases for new k8s default 2019-11-25 13:44:10 -08:00
Sharif Elgamal 04eca26c48
Update default k8s version to 1.17.0-rc.1 2019-11-25 13:33:27 -08:00
Medya Ghazizadeh 8a4c7d31f6
Merge pull request #5960 from davidnewman/issue/5959
Add option for virtualbox users to set nat-nic-type
2019-11-25 13:16:20 -08:00
Medya Ghazizadeh b398810a0f
Merge pull request #5917 from tstromberg/include-output-exec-err
SSHRunner: include stdout/stderr with error message
2019-11-25 11:53:13 -08:00
Thomas Stromberg 337db1707d First pass at multi-runtime pause/unpause 2019-11-22 15:11:51 -08:00
David Newman fbb1d97cf1 feat(virtualbox): Users and set nat-nic-type and host-only-nic-type 2019-11-22 13:50:12 -05:00
Thomas Stromberg 7f97b91adf Add newlines before stdout/stderr 2019-11-20 16:08:16 -08:00
Olivier Lemasle 99350b3b7f Remove depreacted annotation storageclass.beta.kubernetes.io/is-default-class
(deprecated since K8s 1.6 - cf https://github.com/kubernetes/kubernetes/pull/40088)
2019-11-20 13:36:06 +01:00
Thomas Stromberg 9ad7fb70b1 Pre-cache the latest kube-addon-manager 2019-11-16 21:20:14 -08:00
Thomas Stromberg 786ffe8e07 Stop pre-caching obsolete dashboard image 2019-11-16 21:16:06 -08:00
Thomas Strömberg cca2acd8a0
Merge pull request #5925 from tstromberg/v1.17.0-beta.1-t2
Update DefaultKubernetesVersion to v1.17.0-beta.1 to prepare for betas
2019-11-15 13:24:29 -08:00
Thomas Strömberg 6c44e09a94
Merge pull request #5916 from tstromberg/recover-ctrlc
Make it possible to recover from a previously aborted StartCluster (Ctrl-C)
2019-11-15 13:23:53 -08:00
tstromberg c02557d975 Update DefaultKubernetesVersion to v1.17.0-beta.1 to prepare for betas 2019-11-15 11:44:48 -08:00
Thomas Stromberg 2223c89555 Check for etcd, but not /etc 2019-11-15 07:02:44 -08:00
Thomas Stromberg 39c0c8be13 Use etcdDataDir() instead 2019-11-14 20:17:31 -08:00
Thomas Stromberg e87214d581 Remove exit code, it was always 0 2019-11-14 20:15:43 -08:00
Thomas Stromberg 4f5877e141 Double lookBackwardsCount to 400, to find usage error in new apiserver 2019-11-14 20:10:58 -08:00
Thomas Stromberg c8c6260887 Remove noisy warning message while apiserver is booting up 2019-11-14 20:06:57 -08:00
Thomas Stromberg 26dbaa8b28 ssh: Log and return stdout/stderr consistency 2019-11-14 20:06:05 -08:00
Thomas Stromberg b04b2ad5ee Log and return stdout/stderr consistency 2019-11-14 20:02:59 -08:00
Thomas Stromberg a586513831 Make sure etcd existence is recoverable too 2019-11-14 19:11:57 -08:00
Thomas Stromberg a6ece0cbe8 Make restartCluster private in preference to idempotent StartCluster 2019-11-14 15:06:05 -08:00
Thomas Stromberg 557339acc2 Recover from aborted kubeadm runs by checking for file existence 2019-11-14 15:00:56 -08:00
Thomas Stromberg bb28d5c346 Make lock names more specific to avoid conflicts 2019-11-14 10:57:11 -08:00
Aresforchina 6e59117b1d fix up typo 2019-11-14 17:16:27 +08:00
Thomas Stromberg aa6070ae89 Remove unused glog import 2019-11-13 17:02:47 -08:00
Thomas Strömberg 72016f1012
Merge pull request #5901 from tstromberg/noisy-windows
Remove noisy error message
2019-11-13 07:32:34 -08:00
Thomas Strömberg d44aa4c9e5
Merge pull request #5894 from tstromberg/wait-nada
Make --wait=false non-blocking, --wait=true blocks on system pods
2019-11-13 07:06:12 -08:00
Thomas Strömberg 484fdccf78
Merge pull request #5864 from priyawadhwa/copy-files
Only copy new or modified files into VM on restart
2019-11-13 07:02:49 -08:00
Thomas Stromberg eac8b00977 Remove noisy error message 2019-11-13 06:48:24 -08:00
Thomas Stromberg 506cd949b9 Lint 2019-11-12 21:48:03 -08:00
Thomas Stromberg 2411895715 Clarify restart code, remove duplicate health check 2019-11-12 21:29:53 -08:00
Thomas Stromberg 7e5ab0417b Split WaitForCluster up into smaller functions, be more conservative 2019-11-12 21:14:37 -08:00
Thomas Stromberg 2128326cf7 Remove unused tests 2019-11-12 14:19:52 -08:00
Thomas Stromberg e142319e1c Wait for any kube-system pod rather than apiserver (much faster) 2019-11-12 14:13:38 -08:00
Thomas Stromberg dc3a50e026 Make --wait=false wait for nothing again, change default to --wait=true 2019-11-12 13:38:48 -08:00
Sharif Elgamal c03aee8322
Refactor config.Config to prepare for multinode (#5889)
* Refactor config.Config to prepare for multinode

* merge conflict
2019-11-11 17:52:15 -08:00
Sharif Elgamal fb5430fd97
Getting rid of GetMachineName() (#5868)
* removing GetMachineName()

* replacing GetMachineName with a config lookup

* fix tests

* making unit tests happy

* fixing concurrent map writes, only right to viper once

* debugging

* one last test fix

* DeleteAlwaysSucceeds should actually always succeed

* prevent panic when deleting nonexistant cluster

* remove last GetMachineName reference
2019-11-11 14:47:47 -08:00
Priya Wadhwa e9d212653d Simplify command to get size and modtime 2019-11-11 14:28:13 -08:00
Thomas Stromberg 82231dc0ee Merge 2019-11-11 08:38:29 -08:00
Priya Wadhwa 006b802e5c Check for file size and mtime at the same time
Also, copy over the mtime correctly in Copy so that we can make sure
they are equal in `sameFileExists`
2019-11-08 13:56:30 -08:00
Priya Wadhwa 38823e9348 Only copy new or modified files into VM on restart
When minikube restarts, we can save time by only copying over files that
have changes or don't exist in the VM. The code in this PR first checks
if the file already exists in the VM, and skips copying it over again if
it does.
2019-11-07 13:46:22 -08:00
Thomas Strömberg f773c4ba45
Merge pull request #5837 from tstromberg/v1.17.0
Update NewestKubernetesVersion to v1.17.0-beta.1
2019-11-06 14:06:27 -08:00
Sharif Elgamal 6ff68709dd
Merge pull request #5243 from rajalokan/remove-heapster
Remove heapster addon
2019-11-06 11:35:35 -08:00
tstromberg 992d4fd04a Add an explicit Unhealthy driver priority (lowest) 2019-11-06 10:05:50 -08:00
tstromberg fb3360da06 Check health of drivers from existing configs 2019-11-05 17:16:23 -08:00
Thomas Strömberg a583cbec13
Merge pull request #5839 from tstromberg/vbox-be-quiet
Silence virtualbox registry check
2019-11-05 14:47:32 -08:00
tstromberg 858fa57f79 Silence virtualbox registry check 2019-11-05 14:22:13 -08:00
Thomas Strömberg fa4b049593
Merge pull request #5805 from priyawadhwa/speedup-apiserver
Store kubernetes clientset when waiting for apiserver
2019-11-05 13:31:48 -08:00
Thomas Stromberg 79c94fba4c Merge go.mod 2019-11-05 13:24:29 -08:00
Thomas Stromberg 187e18d604 Upgrade newest to v1.17.0-beta.1 2019-11-05 13:21:19 -08:00
Anders F Björklund 3ac263f6e3 Simplify the RunCmd test for cruntime 2019-11-01 19:19:10 +01:00
Anders F Björklund df1175f51f Merge branch 'master' into reportcard-again 2019-11-01 18:32:37 +01:00
Priya Wadhwa b9562c5192 Store kubernetes clientset when waiting for apiserver
While looking at pprof data, I noticed that the line:

```go
client, err = k.client(k8s)
```

takes around .9 seconds to complete. Previously, we were calling it on
every iteration of the waitFor loop. Instead, if we store the clienset once
we have it, we should be able to speed up this function.

During local testing, this optimization reduced time spent waiting for
the apiserver by 13 seconds on average.
2019-10-31 13:56:46 -07:00
tstromberg f60764b07f service: fix --url mode, add integration tests 2019-10-30 10:44:54 -07:00
Thomas Strömberg ef398338d6
Merge pull request #5530 from medyagh/NewCmdRunner
Refactor command runner interface, allow stdin writes
2019-10-29 22:26:14 -07:00
Medya Gh 773c525ae7 fix test and remove extra code 2019-10-29 16:36:10 -07:00
Thomas Strömberg 983dc16c83
Merge pull request #5761 from tstromberg/ulimit
Set Docker open-files limit ( 'ulimit -n') to be consistent with other runtimes
2019-10-29 15:41:58 -07:00
tstromberg f6bd4df15c Address feedback 2019-10-29 14:21:53 -07:00
Medya Gh cd9e413852 resolve code review 2019-10-29 14:11:21 -07:00
Thomas Strömberg 74a5d477f2
Merge pull request #5718 from nanikjava/f-fix-test-disable-browser-test
Refactor to remove opening browser and just return url(s)
2019-10-29 13:51:33 -07:00
tstromberg 0b7a54079d Merge branch 'master' into ulimit 2019-10-29 12:04:04 -07:00
Thomas Stromberg f34b51db65 default-ulimit should be an arg, not an environment var 2019-10-29 07:56:31 -07:00
Thomas Stromberg 9bacb6a8e4 Remove test settings from buildroot 2019-10-28 22:33:18 -07:00
Thomas Stromberg 205376fc6d WIP: Consistently set 'ulimit -n' across runtimes 2019-10-28 22:31:57 -07:00
Thomas Strömberg b4ce29d589
Merge pull request #5757 from priyawadhwa/wait_false
Set --wait=false to default but still wait for apiserver
2019-10-28 21:52:15 -07:00
Nanik T 994d093766 Add boolean to disable opening browser during test
The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.

The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
2019-10-29 13:23:41 +11:00
Priya Wadhwa bd5840aacf improve comments 2019-10-28 18:02:45 -07:00
Priya Wadhwa f3b1a09c36 Clean up bootstrapper interface to accept list of pods to wait for
when waiting for the cluster to start up.
2019-10-28 17:34:04 -07:00
Thomas Strömberg 58018eee85
Merge branch 'master' into f-fix-5329 2019-10-28 16:22:18 -07:00
Priya Wadhwa 993967bcc7 make sure we can get api server pod 2019-10-28 15:20:13 -07:00
Medya Gh 29a015b63f remove more bin bash c 2019-10-28 14:10:22 -07:00
Priya Wadhwa f92b308f9a Rebased on master 2019-10-28 10:46:35 -07:00
Priya Wadhwa 7900b63d2b Wait for only apiserver by default
This PR changes --wait=false to be the default, but to still check for the apiserver in this case. If wait=true, we still wait for all pods to be up and running. This change should speed up `minikube start`, since we won't have to wait for other pods which can take a longer time to start up.

Ref #5681
2019-10-28 10:45:57 -07:00
Medya Ghazizadeh e2bbf7111e
Merge branch 'master' into NewCmdRunner 2019-10-27 00:18:00 -07:00
Anders F Björklund 74e7b2c866 Fix compile error introduced by vmrun fix 2019-10-26 20:25:03 +02:00
Anders F Björklund 3c48985477 Make sure to look for vmrun, for vmware
Otherwise you risk trying to run VMware, just because the
docker-machine-driver-vmware driver has been installed...
2019-10-26 18:13:57 +02:00
Anders F Björklund d635b8dfc7 Add comments as requested by golint 2019-10-26 13:16:29 +02:00
Anders F Björklund 2b5663185f Run gofmt 2019-10-26 13:09:25 +02:00
Medya Gh 1b834df3e4 fix unit test 2019-10-25 17:17:27 -07:00
Medya Gh 792de2b0a1 resolve code review 2019-10-25 17:12:55 -07:00
Medya Gh 592ea158ee fix none docker test 2019-10-25 16:00:36 -07:00
Thomas Strömberg d32431efba
Merge pull request #5735 from tstromberg/gvisor-yiso
gvisor: Use chroot instead of LD_LIBRARY_PATH
2019-10-25 15:41:28 -07:00
Medya Gh 291731c5b2 change shellquote to args 2019-10-25 14:43:25 -07:00
tstromberg 9b2ce99723 Use chroot instead of LD_LIBRARY_PATH for containerd restart 2019-10-25 14:03:01 -07:00
Medya Gh 69dba7c052 Fix exec runner and remove some debug logging 2019-10-25 13:57:00 -07:00
Thomas Strömberg 80f0262dfe
Merge pull request #5731 from tstromberg/v1.16.2
Update default Kubernetes version to v1.16.2
2019-10-25 12:45:11 -07:00
tstromberg 416f132ebb Pass --expected-default-driver to the test rather than minikube
Improve VBoxManage detection on Windows

Add missing install_test
2019-10-25 10:43:30 -07:00
tstromberg d83b4e6f6c Update default Kubernetes version to v1.16.2 2019-10-25 10:21:12 -07:00
tstromberg d3618fb94c Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2 2019-10-25 09:58:07 -07:00
tstromberg 04acb598f5 Use virsh domcapabilites instead of virt-host-validate as it behaves more appropriately 2019-10-25 09:57:58 -07:00
Thomas Stromberg c50a849349 Add more debug logs 2019-10-24 20:34:38 -07:00
Thomas Stromberg c153919a56 Mark none driver as Linux only 2019-10-24 20:34:29 -07:00
Medya Gh 01573e4bda removed more bin bash calls 2019-10-24 17:07:52 -07:00
Medya Gh 0d8c894e6e fix unit test and remove more bin bash c 2019-10-24 16:09:41 -07:00
Medya Gh 187dfe29f8 getting rid of some of bin bash -c 2019-10-24 14:13:51 -07:00
Medya Gh 900123bcf2 Fixing pointer and unit test 2019-10-24 13:17:52 -07:00
tstromberg f9b0c77de1 Include output in the error message 2019-10-24 13:16:59 -07:00
Medya Gh 45e5bebdb4 fixing pointer and teeSSH 2019-10-24 13:15:45 -07:00
tstromberg 82cb5a1728 Fix extra comma 2019-10-24 10:57:07 -07:00
Thomas Stromberg 8920a884c3 Minor improvements to the clarity of hypervisor errors 2019-10-24 07:45:40 -07:00
Kenta Iso 01f56844ed Fix lint error: File is not `goimports` -ed 2019-10-24 21:32:41 +09:00
Thomas Stromberg c925f65629 Warn about driver status, add more logging 2019-10-23 22:33:05 -07:00
Thomas Stromberg c4fc450ad4 Add unit tests for driver 2019-10-23 20:24:03 -07:00
Thomas Stromberg 90ac694356 Add tests for new registry methods, split package into two files 2019-10-23 18:13:37 -07:00