Commit Graph

2860 Commits (6f463931239d419b94b37e53f7304bdab5a64f2f)

Author SHA1 Message Date
Thomas Strömberg c9ec946b64
Merge pull request #6494 from tstromberg/filesync
Fix local assets sync broken by addons refactor
2020-02-04 21:40:54 -08:00
Thomas Strömberg 0bd4099cfc
Merge pull request #5678 from priyawadhwa/compare
[mkcmp] add code to time `minikube start` for each binary
2020-02-04 20:49:59 -08:00
Thomas Stromberg 478502a217 Skip ahead if we are running on bare metal 2020-02-04 20:16:40 -08:00
Thomas Stromberg 8a7d8dc715 Add debugging log statements to cluster startup 2020-02-04 18:59:00 -08:00
Sharif Elgamal dc0be4aed6
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-04 17:29:31 -08:00
Medya Gh 435010a3fc pass profilename for testability 2020-02-04 16:35:51 -08:00
Jose Donizetti eda1c76fe5 add kic tunnel (alpha) 2020-02-04 21:33:56 -03:00
Medya Gh 4b9d15a34c point to host docker 2020-02-04 16:09:43 -08:00
Medya Gh 6c13146987 revert some changes 2020-02-04 15:48:20 -08:00
Medya Gh c86b20ade2 add option to exec runner to point to host docker daemon 2020-02-04 15:33:04 -08:00
tstromberg 4f78a3ce88 Use driver.IsMock 2020-02-04 15:28:09 -08:00
tstromberg 93bc050ec3 Merge branch 'master' into filesync 2020-02-04 15:27:25 -08:00
tstromberg 6189e9e6f7 Add unit tests back 2020-02-04 15:20:13 -08:00
tstromberg 6f6663ec77 Make filesync unit tests excellent again 2020-02-04 15:06:43 -08:00
Sharif Elgamal f41a10a98f
Fix up some unit tests 2020-02-04 15:01:40 -08:00
Medya Gh f6c7048392 use constants instead of hardcode 2020-02-04 13:30:23 -08:00
Medya Gh 3937bae269 add new env var for docker-env command 2020-02-04 13:25:22 -08:00
tstromberg 3db7713399 Remove more functions from the util package 2020-02-04 13:20:37 -08:00
tstromberg aea610b510 Add file sync support back to minikube 2020-02-04 13:19:17 -08:00
Thomas Strömberg d35c825a05
Split cluster package into multiple files (#6484)
* Split cluster package into multiple files

* Name restart/ressurect functions fix

* Minor refactor fixes
2020-02-04 11:25:33 -07:00
Thomas Stromberg 42ec2c8d6c Minor refactor fixes 2020-02-04 07:45:09 -08:00
Thomas Stromberg 9ca944934b Merge 2020-02-04 07:44:47 -08:00
Thomas Stromberg bb539cb05e Merge branch 'filesync' of github.com:tstromberg/minikube into filesync 2020-02-04 07:24:40 -08:00
tstromberg 35c572dd07 fixHost refactoring 2020-02-04 07:22:01 -08:00
Thomas Strömberg 62f65662d4
Merge pull request #6471 from tstromberg/addons-startup2
Fix bugs that prevented previously-enabled addons from starting up
2020-02-04 06:58:13 -08:00
Medya Gh 6c95a28c10 remove default crictl setting 2020-02-03 23:25:55 -08:00
Medya Gh 98dbe06758 remove debugging messages 2020-02-03 22:39:12 -08:00
Medya Gh e231e7ae96 rever dockefile changes 2020-02-03 22:32:08 -08:00
Medya Gh 92eeb3c10b refactor provision 2020-02-03 22:29:27 -08:00
Medya Gh a2f2df9f81 add options to docker service for kic 2020-02-03 20:21:41 -08:00
Priya Wadhwa 4f6deaf5dc Rebased on master 2020-02-03 16:31:11 -08:00
tstromberg 286396344c Name restart/ressurect functions fix 2020-02-03 16:24:36 -08:00
tstromberg 16fd9beea3 Split cluster package into multiple files 2020-02-03 16:19:43 -08:00
Thomas Strömberg 3f939af4b4
Merge branch 'master' into addons-startup2 2020-02-03 16:17:33 -08:00
Thomas Strömberg 901cb520b9
Merge pull request #6452 from tstromberg/none-paused
Fix none driver bugs with "pause"
2020-02-03 16:16:34 -08:00
Medya Ghazizadeh 3dd5495d2f
trim kic base image (#6478) 2020-02-03 16:31:52 -07:00
tstromberg e5e47db1c7 Choose the newest apiserver pid, and choose more exactly 2020-02-03 14:21:09 -08:00
tstromberg 4124fbdb69 Consider a paused apiserver to be controlled by a running host 2020-02-03 14:20:57 -08:00
tstromberg 04df96880e Merge branch 'master' into none-paused 2020-02-03 13:49:21 -08:00
tstromberg a8283d8a3c Fix lint issue 2020-02-03 13:48:30 -08:00
tstromberg 2eddd08ae9 Fix test signature 2020-02-03 12:57:52 -08:00
tstromberg 769dd93aa0 Oops, make sure we return the error code 2020-02-03 10:56:53 -08:00
tstromberg bcc186b908 Startup previously enabled addons 2020-02-03 10:49:40 -08:00
tstromberg 6cc2fc8e49 Call createRequiredDirectories when starting pre-existing VM's, add logging 2020-02-03 10:49:06 -08:00
Zhongcheng Lao fc85dd6d45
Handle node info in kubelet config 2020-02-03 22:31:59 +08:00
Zhongcheng Lao c6340c78e7
Fixes merge issue
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-02-03 19:29:45 +08:00
Zhongcheng Lao f59a2891eb
Merge remote-tracking branch 'origin/master' into node-name 2020-02-03 19:16:57 +08:00
Ruben 7e22609904 Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-02-01 23:59:09 -05:00
Thomas Stromberg 1176aa468f More status logging 2020-01-31 19:00:59 -08:00
Thomas Stromberg cee9448fa0 Make none.GetState more intelligent to fix stop issues 2020-01-31 18:54:27 -08:00
Thomas Stromberg 7f0e83508a Add more logging 2020-01-31 18:44:00 -08:00
Thomas Stromberg eee5788ab3 Make deletion output more terse 2020-01-31 17:08:27 -08:00
Thomas Stromberg ae34f00928 Fix 'Failed to delete cluster: load: exit status 1' message if cluster does not exist 2020-01-31 17:00:11 -08:00
Thomas Stromberg ab93b27a70 Merge branch 'master' into none-paused 2020-01-31 16:38:00 -08:00
Thomas Strömberg e206b25da5
Merge pull request #6440 from tstromberg/addons-on-startup
Add addon enablement to start
2020-01-31 16:25:30 -08:00
Thomas Stromberg dd4ad10b83 Improve handling of paused none clusters. 2020-01-31 16:23:25 -08:00
Thomas Stromberg 5c7585a2c8 Lint fix 2020-01-31 14:26:04 -08:00
Thomas Stromberg c3aafaeeb4 Add IsNotExist() method to the config package, so that we can have meaningful error messages and make them comparable 2020-01-31 14:19:08 -08:00
Thomas Stromberg a7ac0339fd Address eview feedback 2020-01-31 13:24:30 -08:00
Thomas Stromberg 02362d8d9c Loosen error message matching for unit test 2020-01-31 12:55:56 -08:00
Thomas Stromberg f6740b37be Run gofmt/goimports 2020-01-31 12:37:23 -08:00
Thomas Stromberg 26cbae2d05 Improve error message when profile does not exist 2020-01-31 12:36:28 -08:00
Thomas Stromberg 78ed12265d Add testing for Start function, make addon enablement testable 2020-01-31 12:19:25 -08:00
Medya Gh 0e5059ddd0 log warning if docker is stuck 2020-01-30 21:36:56 -08:00
Medya Gh a6ec05e35a unexport noderolekey 2020-01-30 21:05:51 -08:00
Medya Gh 968fe86869 unexport more funcs 2020-01-30 21:01:27 -08:00
Medya Gh 006c781fbc remove unused kic code 2020-01-30 20:44:32 -08:00
Medya Gh 7b3fa71dbf fix nil logic 2020-01-30 19:21:55 -08:00
Medya Gh 4f9df4596e fix kic minikube status 2020-01-30 18:30:19 -08:00
Medya Gh be38a021cb fix kic restart use external ip 2020-01-30 18:24:16 -08:00
Medya Gh 23e125649d rename createConfig 2020-01-30 18:13:11 -08:00
Medya Gh b20322a8c2 rename funcs 2020-01-30 18:12:04 -08:00
Medya Gh a709fd5d37 rename funcs 2020-01-30 18:10:36 -08:00
Medya Gh 80b4121c06 delete stale 2020-01-30 17:46:40 -08:00
tstromberg b97124207c Move addon enablement to addons module + lint fixes 2020-01-30 17:46:25 -08:00
Medya Gh e7fa3e0448 remove duplicate profile names 2020-01-30 17:11:11 -08:00
Medya Gh 5b055d7ff8 add comment 2020-01-30 16:57:53 -08:00
Medya Gh 58b637b05f delete all cleans up stale kic profiles 2020-01-30 16:42:14 -08:00
Medya Gh 8e0ffdf1cf resolve conflict 2020-01-30 16:20:55 -08:00
tstromberg d5a83c7b24 Add addon enablement to start 2020-01-30 15:54:04 -08:00
Medya Ghazizadeh 4bf3fc422a
Add docker run-time for kic driver (#6436)
* Add docker container run time for kic
2020-01-30 14:30:04 -08:00
Thomas Strömberg eeb867f387
Merge pull request #6243 from afbjorklund/coredns-arch
Do not use an arch suffix for the coredns name
2020-01-30 14:23:40 -08:00
Thomas Strömberg 50c32d2d08
Merge pull request #6380 from akshaysu12/UpdateRegistryCredsCreateSecret
Prevent registry-creds configure from failing when a secret does not exist.
2020-01-30 14:07:27 -08:00
tstromberg a1d291fd0d Handle cert symlinks that point to a nonexistent file 2020-01-30 11:59:47 -08:00
Sharif Elgamal 3cbe879d7e
node add works 2020-01-30 09:02:01 -08:00
Ruben 7f17203045 fix unittest 2020-01-29 22:58:03 -05:00
Ruben 34bb09c8e0 add beta2 files 2020-01-29 21:35:33 -05:00
Thomas Strömberg 775186b3ef
Add a 2-second timeout to driver detection commands (#6422) 2020-01-29 16:12:18 -08:00
Medya Ghazizadeh e725104e2f
improve checking modprob netfilter (#6427) 2020-01-29 14:47:23 -08:00
Sharif Elgamal a539efc43c Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-01-29 11:03:15 -08:00
Medya Ghazizadeh d99007f201
Merge pull request #6322 from chancez/metrics_listen_addrs
Configure etcd and kube-proxy metrics to listen on minikube node IP
2020-01-28 20:33:02 -08:00
Sharif Elgamal 593d3fc73e moving packages around 2020-01-28 17:09:00 -08:00
akshay 2ba3116254 Update create secret in service so registry creds add on does not fail when a secret does not exist. 2020-01-28 07:15:38 -08:00
Ruben 975f720518 Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-01-28 07:53:13 -05:00
Sharif Elgamal ae8309f1e1
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-01-27 17:59:53 -08:00
Sharif Elgamal 317dd41138
moving node package around 2020-01-27 17:59:35 -08:00
Ruben b365692372 get master changes 2020-01-25 22:27:46 -05:00
Ruben aaff16052f Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-01-25 21:44:56 -05:00
Ruben e8e3a6fe6b delete an empty line 2020-01-25 21:09:08 -05:00
Medya Gh b3404a70e6 patch node refactor for kic 2020-01-24 19:03:50 -08:00
Sharif Elgamal 8db7f59b1e
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-01-24 16:08:22 -08:00
Sharif Elgamal de0573784e
ok it builds again 2020-01-24 16:01:14 -08:00
Sharif Elgamal 9a49c587d5
Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-24 15:54:04 -08:00
Thomas Strömberg 892cfb8514
Merge pull request #6385 from tstromberg/faster-docker
Batch file manipulation calls to reduce number of redundant commands
2020-01-24 15:47:44 -08:00
Thomas Strömberg d8a5714b00
Merge pull request #6392 from tstromberg/v1.17.2-simple-bump
Update DefaultKubernetesVersion to v1.17.2
2020-01-24 15:46:21 -08:00
Thomas Strömberg 82e096a7a1
Merge pull request #6390 from medyagh/kic_bindip
kic driver: add multiple profiles and ssh
2020-01-24 15:45:51 -08:00
Sharif Elgamal 5c906d33f3
fix unit tests 2020-01-24 15:03:27 -08:00
Medya Gh 7cf8ed1edc lint 2020-01-24 14:52:27 -08:00
Medya Gh ba3965b076 specify SSH username 2020-01-24 14:42:28 -08:00
Medya Gh 83dd9fc4ff Bump kic base image for ssh 2020-01-24 14:20:49 -08:00
Medya Gh c6c0046c57 let docker/podman choose hostbind port 2020-01-24 14:15:48 -08:00
tstromberg 9aeae2df65 Fix tests 2020-01-24 13:57:07 -08:00
Sharif Elgamal 58ba813a9c
controlplane and worker are bools now magiiiiic 2020-01-24 13:54:41 -08:00
Sharif Elgamal 0b460e6cb7
master is no longer a thing 2020-01-24 13:24:38 -08:00
tstromberg dd4a089fa1 Merge branch 'faster-docker' of github.com:tstromberg/minikube into faster-docker 2020-01-24 13:21:04 -08:00
Thomas Stromberg 41709d2bb8 Merge branch 'master' into faster-docker 2020-01-24 13:20:33 -08:00
tstromberg 2e24d7a123 Combine error conditions 2020-01-24 13:08:26 -08:00
tstromberg 817da0e884 Merge branch 'master' into faster-docker 2020-01-24 11:59:26 -08:00
tstromberg c43aea690d Update DefaultKubernetesVersion to v1.17.2 2020-01-24 11:58:23 -08:00
Sharif Elgamal 0681830be4
io.ReadSeeker for all the Assets readers 2020-01-24 11:55:59 -08:00
Sharif Elgamal ad03309ab6 Adding the initial node cmd and pkg files 2020-01-24 11:40:27 -08:00
Sharif Elgamal 9953cc2250
GetMasterNode -> MasterNode 2020-01-24 11:14:55 -08:00
Sharif Elgamal 77d838d3d2
Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-24 10:50:57 -08:00
tstromberg 35f1e58583 Merge conflict 2020-01-24 10:40:26 -08:00
Medya Gh 2bd169f508 add config fields for kic SSH and API ports 2020-01-23 23:51:41 -08:00
Medya Gh ca0f4c7e20 generate ssh keys for kic container 2020-01-23 19:20:44 -08:00
Medya Gh 09d9d05c6b generate ssh certs for kic during creation 2020-01-23 18:43:26 -08:00
Medya Gh 3d5c9ae870 implement SSHPortName for kic 2020-01-23 18:28:32 -08:00
Medya Gh 1e05b11703 Add ssh to kic image 2020-01-23 18:24:51 -08:00
Medya Gh 773510b9c1 Add ssh to kic container image 2020-01-23 17:45:50 -08:00
Medya Gh 5191659ff2 bind ip use const instead of string 2020-01-23 17:28:30 -08:00
Thomas Stromberg a9bc13b403 Address pause code review feedback 2020-01-23 15:44:30 -08:00
Thomas Stromberg a8d3ef580b Merge branch 'pause' of github.com:tstromberg/minikube into pause 2020-01-23 15:06:37 -08:00
Sharif Elgamal fa4322e89a remove all references to MachineConfig.ContainerRuntime 2020-01-23 13:50:31 -08:00
Sharif Elgamal 6a01d6b25b prefer getting master node over calling Nodes[0] 2020-01-23 13:26:50 -08:00
Sharif Elgamal de3caceccb Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-23 13:21:38 -08:00
Sharif Elgamal 791f28ff4c things work now 2020-01-23 13:21:21 -08:00
Thomas Stromberg e9f6aa106f test fixing 2020-01-23 12:53:33 -08:00
Thomas Stromberg 412e78e54c minimize the number of commands executed 2020-01-23 11:11:28 -08:00
Thomas Stromberg a20942ff2d Merge branch 'master' into pause 2020-01-23 07:46:44 -08:00
Sharif Elgamal d7ea60d610 fix up tests for new config format 2020-01-22 18:49:58 -08:00
Sharif Elgamal 8b2a05a565 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-22 17:18:30 -08:00
Thomas Strömberg 5fa7935571
Merge pull request #6376 from priyawadhwa/fix-dashboard
Fix dashboard by using kubectl apply/delete instead of prune for addons
2020-01-22 16:03:18 -08:00
tstromberg 1a13055d00 Add integration tests 2020-01-22 15:50:09 -08:00
Priya Wadhwa 49b0cb1c9c create dashboard ns first so that everything else can be created after 2020-01-22 15:16:56 -08:00
Priya Wadhwa 8d8ea98378 check cmd.Remove error for linting 2020-01-22 15:11:33 -08:00
tstromberg 22de8c110a Return the number of containers paused 2020-01-22 15:07:44 -08:00
tstromberg b81960e37c Fix none driver 2020-01-22 14:28:18 -08:00
Priya Wadhwa 15a5209841 Update unit tests 2020-01-22 14:23:32 -08:00
tstromberg dccc41748b Merge branch 'master' into pause 2020-01-22 14:18:32 -08:00
Priya Wadhwa 7247a7dee6 Switched to using kubectl apply and kubectl delete for addons
kubectl apply with --prune wasn't working because it requires the
--namespace flag to be passed in and we have multiple namespaces for
addons.

We tried to split up addons within /etc/kubernetes/addons by
namespace, but this didn't work when disabling dashboard addon because
there were no files left in the kubernetes-dashboard subdirectory. So,
kubectl apply complained when trying to prune dashboard because no files
were being passed in.

So, I ended up removing all dependencies on prune and instead running
`kubectl apply` when enabling an addon and running `kubectl delete` when
disabling an addon.
2020-01-22 14:18:20 -08:00
tstromberg c83ee09417 Update Kubernetes libraries to v1.17.2 2020-01-22 14:10:53 -08:00
tstromberg 50cd0dbfba First stab at freezer checks 2020-01-22 13:55:01 -08:00
Medya Ghazizadeh 98ff78a762
Merge pull request #6266 from sshukun/improve-doc
Fix typo and improve documents
2020-01-22 13:15:51 -08:00
Priya Wadhwa de4ecb9706 Rebased on master 2020-01-22 13:10:50 -08:00
Priya Wadhwa 180b23f2c8 Save addons in subdirectories, separated by namespace
This way we can pass the correct --namespace flag into 'kubectl apply'
such that it works with '--prune' for kubectl >=v.17.0
2020-01-22 13:09:37 -08:00
Thomas Strömberg 1af9d83cd1
Merge pull request #6369 from priyawadhwa/refactor-crio
Remove unnecessary crio restart to improve start latency
2020-01-22 12:19:30 -08:00
Thomas Strömberg 6753c71b37
Merge pull request #6334 from priyawadhwa/remove-addon-manager
Remove addon manager
2020-01-22 12:19:17 -08:00
Medya Ghazizadeh abfcf79dfd
Merge pull request #6236 from tstromberg/image-panic
Check for nil ref and img before passing them into go-containerregistry
2020-01-22 12:06:36 -08:00
Priya Wadhwa 43259cc363 Reorganize buildroot.go by container runtime and remove unnecessary "sudo systemctl restart crio" to save time on 'minikube start' 2020-01-22 11:00:10 -08:00
Thomas Stromberg 5f0420f72e Merge branch 'master' into pause 2020-01-22 09:48:26 -08:00
Thomas Stromberg e6999caea3 Add paused state to apiserver status 2020-01-22 09:48:16 -08:00
Thomas Strömberg 8562d1c82d
Merge pull request #6362 from medyagh/kic_del
implement remove file for kic runner
2020-01-22 06:04:21 -08:00
Thomas Stromberg 09b2780fb2 Add support for pausing/unpausing specific namespaces 2020-01-21 22:06:05 -08:00
Medya Ghazizadeh 875c4b2d76
Merge pull request #6338 from medyagh/unify_boots
unify bootstrappers for both VM and contianer
2020-01-21 20:34:17 -08:00
Thomas Stromberg 0f40eef9a7 Merge conflicts 2020-01-21 20:06:03 -08:00
Thomas Stromberg a4add4ccbc Merge conflicts 2020-01-21 20:02:38 -08:00
Thomas Stromberg 7e2e9eb15b Merge conflicts 2020-01-21 20:00:21 -08:00
Thomas Stromberg be65e4c2ad Merge upstream 2020-01-21 19:46:42 -08:00
Thomas Stromberg 7fe786aca4 Merge upstream 2020-01-21 19:46:05 -08:00
Medya Gh 6ca7b74f8a implement reomve file for kic runner 2020-01-21 17:39:06 -08:00
Medya Gh 5a3c13815e network overlay only for kic 2020-01-21 15:14:51 -08:00
Zhongcheng Lao 6b0c69986f
Merge remote-tracking branch 'origin' into node-name 2020-01-18 08:09:51 +08:00
Medya Gh 7d07d0d61b ignore iptables for kic 2020-01-17 15:44:22 -08:00
Medya Gh 0b2d8051bb remove kicbs 2020-01-17 15:44:22 -08:00
Anders F Björklund 1c3e309c7a Merge branch 'master' into crio-conf 2020-01-17 23:46:48 +01:00
Medya Gh b63212eacf patch cgroup pr 2020-01-17 14:04:48 -08:00
Ruben 31fd6d9369 remove kubelet conf label 2020-01-17 07:43:50 -05:00
Ruben 076d855c12 Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-01-17 06:57:19 -05:00
Priya Wadhwa 28148c5f3d Remove addon manager 2020-01-16 11:47:01 -08:00
Sharif Elgamal e520566ec7 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-16 11:39:56 -08:00
priyawadhwa d310331b9d
Merge pull request #6046 from priyawadhwa/remove-addon-manager
Remove polling from addon manager
2020-01-16 11:32:30 -08:00
Sharif Elgamal b225e8ec86
Merge pull request #6326 from sharifelgamal/exp
add the ability to mark drivers as experimental
2020-01-15 17:29:13 -08:00
Nanik T 9b455aafc4 Customizing host path for dynamically provisioned PersistentVolumes
This fix contains few things:

* Used k8s.gcr.io/debian-base-amd64:v2.0.0 as base image to build storage-provisioner
* Modify RBAC permission used to cluster-admin
* Build storage-provisioner as static binary
2020-01-16 12:23:26 +11:00
Sharif Elgamal d0fb749842
add displaysupporteddrivers func 2020-01-15 16:03:37 -08:00
Sharif Elgamal a13ea9bea0
add the ability to mark drivers as experimental and mark the docker driver as such 2020-01-15 15:21:47 -08:00
Medya Ghazizadeh 6c45d66d84
Merge pull request #6287 from afbjorklund/cgroup-driver
Use CGroupDriver function from cruntime for kubelet
2020-01-15 14:46:31 -08:00
Chance Zibolski ca007f414b pkg/minikube: Update test fixtures to contain updated metrics listen addresses 2020-01-15 14:02:28 -08:00
Chance Zibolski 44c7c48d3e pkg/minikube: Configure etcd and kube-proxy metrics to listen on minikube node IP 2020-01-15 11:52:43 -08:00
Sharif Elgamal 804ee14a95 removing node surface stuff for a different PR 2020-01-15 11:36:36 -08:00
Sharif Elgamal f0372edff6
ok at least things build now 2020-01-15 10:59:30 -08:00
Priya Wadhwa 342b52b8cd Merge branch 'master' of github.com:kubernetes/minikube into remove-addon-manager 2020-01-14 16:16:42 -08:00
Sharif Elgamal 2c301bd4ef
more node changes yay 2020-01-14 14:25:20 -08:00
Sharif Elgamal 2813cf4120
Merge branch 'master' of github.com:sharifelgamal/minikube into m2 2020-01-14 13:44:40 -08:00
Priya Wadhwa f5be457399 fix unit tests 2020-01-14 12:12:47 -08:00
Medya Gh 577a04b02e disable istio provisioner by default 2020-01-14 12:05:32 -08:00
Priya Wadhwa 9a2de2ae7f Hook up new addon manager logic to existing addons code 2020-01-14 10:52:27 -08:00
Priya Wadhwa 2029d6012c Rebased on master 2020-01-14 10:27:39 -08:00
Anders F Björklund c017dc986c Merge branch 'master' into crio-conf 2020-01-14 18:10:14 +01:00
Anders F Björklund 708bf5c6d5 Revert unnecessary change to the extra flags order 2020-01-14 17:49:09 +01:00
Ruben c3bb3802e9 Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-01-13 21:12:07 -05:00
Medya Ghazizadeh 2d97a0d3b7
Merge pull request #6220 from afbjorklund/crictl-local
Use absolute path, when calling the crictl command
2020-01-13 14:31:01 -08:00
Medya Ghazizadeh 8718a54d91
Merge pull request #6256 from tstromberg/dry-run
Add --dry-run option to start
2020-01-13 13:37:15 -08:00
Anders F Björklund 9e317ac2bd Do not use an arch suffix for the coredns name
They are using multi-arch images instead...
So don't append something like -arm64 to it.

Just use e.g. "k8s.gcr.io/coredns:1.6.5",
and Docker will pull the right platform image.
2020-01-13 22:34:19 +01:00
Medya Ghazizadeh b665640421
Merge pull request #6277 from medyagh/kic_addon
add addons for kic
2020-01-13 12:56:06 -08:00
Thomas Stromberg 13873028ae Merge master 2020-01-13 12:46:47 -08:00
Anders F Björklund d265162fe2 Fix some minor issues from gofmt and golint 2020-01-13 21:38:59 +01:00
Medya Ghazizadeh 13e2a3e601
Merge pull request #6276 from tstromberg/qemu-system
Pass --kvm-qemu-uri value into kvm2 health check
2020-01-13 11:16:07 -08:00
Anders F Björklund f959a21d87 Make sure to pass runner to UpdateCluster runtime 2020-01-12 22:19:50 +01:00
Anders F Björklund 0e83dd4b4e Use the cgroup-driver from runtime for kubelet 2020-01-12 19:29:07 +01:00
Anders F Björklund 27f8adf912 Add CGroupDriver function to cruntime interface 2020-01-12 18:46:47 +01:00
Ruben eef0e52827 add more test files to 1.18 & 1.19 versions 2020-01-11 20:57:12 -05:00
Ruben e2c254fc74 change template name to 1.17 test files 2020-01-11 20:55:58 -05:00
Ruben f1557f2065 add more versions for testing 2020-01-11 20:54:28 -05:00
Ruben 453fb9fedb fix code format 2020-01-11 19:21:07 -05:00
Ruben 5fd6beacf9 Merge branch 'master' of https://github.com/kubernetes/minikube into update-kubeadm-v1beta2 2020-01-11 11:08:01 -05:00
Ruben ebecf33723 add podSubnet & certSANs from v1beta1 2020-01-11 10:09:01 -05:00
Medya Gh 62e3bc4b72 add addons for kic 2020-01-10 17:14:47 -08:00
tstromberg 1085d47a24 Pass in the value of *kvmQemuURI for behavioral consistency 2020-01-10 16:07:07 -08:00
tstromberg 5008d4cdc9 Explicitly set LIBVIRT_DEFAULT_URI default for health checking 2020-01-10 15:49:01 -08:00
tstromberg 0c07e80821 Remove unused import from merge 2020-01-10 09:55:50 -08:00
Thomas Strömberg 5568ab005a
Merge branch 'master' into unthread-start 2020-01-10 09:54:02 -08:00
Ruben 805f117765 fix imports 2020-01-10 07:28:41 -05:00
Ruben c7ded84576 resolving conflicts 2020-01-10 07:17:34 -05:00
Medya Ghazizadeh 19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
Experimental verison of kic
2020-01-10 00:42:01 -08:00
sshukun f98b5b85c7 Fix some typos and improve documents 2020-01-10 17:35:07 +09:00
Medya Gh 59ecf3fd06 rename verify pkg to kverify 2020-01-09 16:28:23 -08:00
Thomas Strömberg ef7469f3f3
Merge pull request #6261 from tstromberg/ssh_mock_race
ssh_mock: Copy buffer to avoid data race
2020-01-09 16:27:46 -08:00
Medya Gh b92c22ee5b remove debugging message 2020-01-09 16:16:53 -08:00
Thomas Stromberg 851d1d5d3a ssh_mock: Copy buffer to avoid data race 2020-01-09 16:04:54 -08:00
Medya Gh 9eb855a9c0 lint code 2020-01-09 15:58:31 -08:00
Medya Gh 7198566db7 fix test data for crio for new tmpl 2020-01-09 15:49:07 -08:00
Medya Gh 381187f339 fix test data for default 2020-01-09 15:43:58 -08:00
Thomas Stromberg 8895dacd1a De-parallelize GetServiceURL tests: the mocks are not thread safe 2020-01-09 15:42:05 -08:00
Medya Gh 2ed25c72af fix dns test data and also add tests for v17 2020-01-09 15:38:37 -08:00
Medya Gh 70f8b96d1f fix test data for options for new tmpl 2020-01-09 15:31:29 -08:00
Medya Gh aea63baa70 fix crio-options test data for new tmpl 2020-01-09 15:25:25 -08:00
Medya Gh 2f3ad44d78 fix test data for containerd tmpl 2020-01-09 15:14:58 -08:00
Medya Gh b4fa45fe39 fix testdata for cidr tmpl 2020-01-09 15:08:47 -08:00
Medya Gh 9a16a52e2f fix containerd tmplate unittest 2020-01-09 15:01:22 -08:00
Medya Gh 8403350a17 fix image unittest 2020-01-09 14:52:01 -08:00
Thomas Stromberg 4f3afcd1fa Merge branch 'master' into unthread-start 2020-01-09 14:50:17 -08:00
Thomas Stromberg 418082e368 Log machine name and how long we held the lock for 2020-01-09 14:46:56 -08:00
Medya Ghazizadeh 727beb50c7
Merge pull request #6240 from tstromberg/bitflip
Fix inverted logic for showing issue link
2020-01-09 14:10:11 -08:00
Thomas Stromberg e5fd7a6a81 Replace integration-test specific hacks with actual protection against racey events 2020-01-09 12:58:10 -08:00
Thomas Stromberg 7acf688f7a Merge master 2020-01-09 11:13:25 -08:00
Thomas Stromberg c5e917366f Add --dry-run option to start 2020-01-09 11:10:23 -08:00
Ruben 716abbb61a refactor template && change validation 2020-01-09 08:16:02 -05:00
Zhongcheng Lao 4a1f33e282
Adds cluster name to kubenetes config
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 20:00:40 +08:00
Zhongcheng Lao 0512882520
Do not set host-override for kubelet by default
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 19:52:30 +08:00
Zhou Hao 29deded5f4 proxy_test: improve TestIsValidEnv unit test
Add test under the ture case to complete this unit test.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-09 13:33:41 +08:00
Medya Gh b9f5afa8f9 fix unit tests kudebadm template crio 2020-01-08 17:21:49 -08:00
Medya Gh 890878b469 Fix unit tests and go tempalte block 2020-01-08 17:08:11 -08:00
Medya Gh 40a011c49a use api port for host binding port 2020-01-08 16:09:24 -08:00
Medya Gh 867f62a9e9 move more funcs to bsutil 2020-01-08 15:47:48 -08:00
Medya Gh b1242e29e3 unexport funcs in images package 2020-01-08 15:33:47 -08:00
Medya Gh cf9e6e512f fix ineffectual assignment 2020-01-08 15:21:57 -08:00
Medya Gh de0d603c7f convert base image to a const 2020-01-08 13:56:23 -08:00
Medya Gh 8a0c840e52 move kic docker image to minikube gcr 2020-01-08 13:52:07 -08:00
tstromberg f908468bec Fix inverted logic for showing issue link 2020-01-08 13:32:34 -08:00
Medya Gh 88bef295c8 remove debugging msgs and add sysverification ignore 2020-01-08 13:19:34 -08:00
Medya Gh ddf5ab027a add extra option fail swap for kic 2020-01-08 12:53:29 -08:00
Medya Ghazizadeh 6da07be75d
Merge pull request #6175 from q384566678/oci-remove-todo
pkg/drivers/kic/oci: delete TODO info
2020-01-08 10:40:32 -08:00
tstromberg 4a06fde1cf Check for nil ref and img before passing them into go-containerregistry 2020-01-08 10:02:11 -08:00
Zhou Hao 7e0b89cc9d code optimization
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-08 16:25:11 +08:00
Zhongcheng Lao 96398c73ad
Merge remote-tracking branch 'origin/master' into node-name 2020-01-08 14:45:21 +08:00
Medya Ghazizadeh 444b36161b
Merge pull request #6193 from q384566678/oci-status
kic/oci: parse all kind of states
2020-01-07 14:54:42 -08:00
Medya Gh 5a23d635d5 package comment 2020-01-07 14:49:05 -08:00
Medya Gh 4013158328 rename package to ktmpl 2020-01-07 14:16:16 -08:00
Medya Gh f80572bb4c code review 2020-01-07 13:59:41 -08:00
Medya Gh 07c0e32954 improve kic image 2020-01-07 13:54:00 -08:00
Medya Gh 77394db9aa add Dockerfile for kic images 2020-01-07 13:54:00 -08:00
Medya Gh 618b150bcd fix setup kubeconfig for kic 2020-01-07 13:54:00 -08:00
Medya Gh d76eb6d28c use net join for kubeconfig port 2020-01-07 13:54:00 -08:00
Medya Gh a64a2721d5 Add localhost to ca cert 2020-01-07 13:54:00 -08:00
Medya Gh d298593d8a refactor api server verification 2020-01-07 13:54:00 -08:00
Medya Gh e9b7451278 auto set podsubnet for kic improve none auto set 2020-01-07 13:54:00 -08:00
Medya Gh ae45bb75e3 add podsubnet to all tempaltes 2020-01-07 13:54:00 -08:00
Medya Gh 860ce25bf2 Add podSubnet to templates 2020-01-07 13:54:00 -08:00
Medya Gh 4dd9866e9d Add addons to kic too 2020-01-07 13:54:00 -08:00
Medya Gh c7bc61af2c Add overlay network for kic 2020-01-07 13:54:00 -08:00
Medya Gh 6cf2554877 add flag for kic host binding port 2020-01-07 13:54:00 -08:00
Medya Gh 35c47b9dc4 Ignore iptables for kic and fix chmod +x permission 2020-01-07 13:53:19 -08:00
Medya Gh ea207b34a1 add output to logs kubeadm init 2020-01-07 13:53:19 -08:00
Medya Gh 0b85aa9daf Add start restart to kic bs 2020-01-07 13:53:19 -08:00
Medya Gh 08c715af8b move verify clusters to its own package 2020-01-07 13:53:19 -08:00
Medya Gh af1b77a164 implement pull images for kicbs 2020-01-07 13:52:47 -08:00
Medya Gh 1de4adf273 Implement images list for kic 2020-01-07 13:52:47 -08:00
Medya Gh ac97b51058 implement setup certs for kicbs 2020-01-07 13:52:47 -08:00
Medya Gh a358aff093 fix ocibinary 2020-01-07 13:52:47 -08:00
Medya Ghazizadeh be79843f75
Merge pull request #6214 from laozc/hostport-join
Fixes IPv6 address handling in kubeadm
2020-01-07 11:45:32 -08:00
Medya Ghazizadeh d23b446d2e
Merge pull request #6218 from afbjorklund/reportcard-minor
Improve reportcard by refactoring and commenting
2020-01-07 11:42:55 -08:00
Thomas Strömberg af4ee5cf1f
Merge pull request #6124 from priyawadhwa/addon-per-profile-refactor
Enable or disable addons per profile
2020-01-06 16:33:01 -08:00
Priya Wadhwa 6ad7e4a9a0 address code review comments
add better error handling and remove duplication in enableOrDisableAddonsInternal
2020-01-06 13:42:09 -08:00
Anders F Björklund 655da9091c Make helper function less generic, to please lint
`getCommandPath` - `cmd` always receives `"crictl"` (unparam)
2020-01-06 18:33:07 +01:00
Anders F Björklund 4d0446afa5 Use absolute path, when calling the crictl command
To work on CentOS, which has a weird path in sudo
2020-01-06 16:55:05 +01:00
Anders F Björklund 118451f4b2 Refactor: move usage of crictl to cruntime package
We don't want the crictl or docker commands outside
2020-01-06 15:55:10 +01:00
Anders F Björklund 723f1f941b Update the crio.conf instead of overwriting it
We are only changing one config value, anyway
2020-01-06 15:19:57 +01:00
Anders F Björklund 024dfe18dc Refactor: move the crio config to the crio runtime
For some reason it was left with the generic CRI
2020-01-06 14:55:18 +01:00
Anders F Björklund ea7a2d7e33 Improve reportcard by refactoring and commenting
golint: 99%
	pkg/minikube/localpath/localpath.go
		Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
	pkg/minikube/cluster/cluster.go
		Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
	cmd/minikube/cmd/start.go
		Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
		Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
Kim Bao Long f388f69220 Remove duplicated words
Although it is spelling mistakes, it might make an affects while reading.

Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-06 15:54:27 +07:00
Zhongcheng Lao 5f8a4503eb
Fixes IPv6 address handling in kubeadm
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-05 23:37:00 +08:00
Zhou Hao 62bfc39404 Fix comment
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-03 09:31:55 +08:00
Zhou Hao c1859c44e3 kic/oci: parse all kind of states
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-01-02 14:16:54 +08:00
Zhongcheng Lao f9ed4a6460
Allow user to override node name
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-01 13:45:03 +08:00
Medya Ghazizadeh e5f5abda89
Merge pull request #6179 from q384566678/fix-pause
pkg/drivers/kic: fix wrong command in Unpause
2019-12-30 18:42:28 -08:00
Priya Wadhwa e47cde6ae4 Rebased on master, moved istio addon into new package 2019-12-30 10:10:05 -05:00
Zhou Hao 9c4e3fbd3c pkg/drivers/kic: fix wrong command in Unpause
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:54:48 +08:00
Zhou Hao ae61e56594 pkg/drivers/kic/oci: fix Status info
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 15:21:03 +08:00
Zhou Hao aa52255be0 pkg/drivers/kic/oci: delete TODO info
When the docker exit status is 125, it is not entirely certain that it is caused by duplicate names.There may also be other errors.
e.g:
➜  minikube git:(oci-remove-todo) ✗ docker run -itzz
unknown shorthand flag: 'z' in -zz
See 'docker run --help'.
➜  minikube git:(oci-remove-todo) ✗ echo $?
125

So delete this TODO info.

Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-30 14:43:11 +08:00
Medya Ghazizadeh df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
fenglixa c2ba574f2e generate istio document page and layout 2019-12-26 14:35:13 +08:00
Medya Ghazizadeh ce4b9503ae
Merge pull request #6137 from q384566678/add-constants-test
Add constants_test
2019-12-23 01:13:50 -08:00
Ruben 3bedd60e1c add v1beta2 condition 2019-12-22 15:47:16 -05:00
Ruben 0ce6a0303a add v1beta2 template 2019-12-22 15:46:55 -05:00
Medya Gh d5f56477bc code review resolve 2019-12-20 17:14:14 -08:00
Medya Gh 3b2cfa6c32 rename funcs 2019-12-20 16:53:35 -08:00
Medya Gh 83cd426436 refactor more 2019-12-20 16:11:05 -08:00
Medya Gh cf6bde8eaf refactor image specific funcs to image package 2019-12-20 16:05:08 -08:00
Medya Gh cde5503d3e add two mechanism to find local image digest 2019-12-20 14:09:18 -08:00
Medya Gh 9d03e56ece resolve merge conflict 2019-12-20 12:44:09 -08:00
Medya Gh be8a1ad107 resolve code reviews 2019-12-20 12:43:13 -08:00
Priya Wadhwa 6c25cd3848 Rebased on master 2019-12-20 12:34:48 -08:00
Medya Gh 5eb384cf7d check error and fix logging msg 2019-12-20 12:24:05 -08:00
Medya Gh 502f3b7f8f use docker cli lib to get image id 2019-12-20 12:18:55 -08:00
Medya Gh 4d9e53389a improve logging 2019-12-20 12:12:48 -08:00
Medya Gh 2d1fffe1d1 better names 2019-12-20 12:06:26 -08:00
Medya Gh 679a9c114b more clear func names 2019-12-20 12:06:26 -08:00
Medya Gh 71a896fc0a unexport func cacheImage 2019-12-20 12:06:25 -08:00
Medya Ghazizadeh 031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
kic-xmas edition
2019-12-20 11:40:46 -08:00
Zhou Hao 2167655006 add unit test for GetDNSIP
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-20 17:32:50 +08:00
Zhou Hao 6a5497510a add unit test for GetServiceClusterIP
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2019-12-20 17:27:24 +08:00
Medya Gh f9e7a54eb8 rename kicdocker to docker 2019-12-20 01:26:38 -08:00
Medya Gh f39ba0deb0 add unit test for feature gate supports 2019-12-20 01:17:33 -08:00
Medya Gh 1014a57ea8 better names for bs type 2019-12-20 01:01:10 -08:00
tstromberg cae166e74c Merge branch 'master' into advice-refresh 2019-12-19 16:23:25 -08:00
tstromberg f438bb7ec8 Merge branch 'master' into less-catastrophic 2019-12-19 16:15:47 -08:00
tstromberg 512b3cb314 Refresh advice, flip hide vs show default for links 2019-12-19 16:04:34 -08:00
Medya Gh 7360edc8e0 add kic cni 2019-12-19 15:11:22 -08:00
Priya Wadhwa 4fd929deeb Merge branch 'master' of github.com:kubernetes/minikube into compare 2019-12-19 14:03:20 -08:00
Priya Wadhwa 4ce8d7dc0c fix boilerplate 2019-12-19 13:58:13 -08:00
Priya Wadhwa 83aca57dd4 Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor 2019-12-19 13:20:12 -08:00
Priya Wadhwa 859420c083 Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor 2019-12-19 13:06:07 -08:00
tstromberg 6cc860e911 Add build tags so that the test only runs on Darwin 2019-12-19 13:05:47 -08:00
tstromberg 0796d866df Further clarification 2019-12-19 12:51:02 -08:00
Priya Wadhwa 624d47b781 Update unit tests 2019-12-19 12:47:20 -08:00
Thomas Strömberg 4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
Thomas Strömberg 28c4c82bd7
Merge pull request #5833 from govargo/fix-without-hyperkit-errormsg
Add hyperkit version check whether user's hyperkit is newer
2019-12-19 11:44:58 -08:00
Priya Wadhwa 48b5a1e493 Merge branch 'master' of github.com:kubernetes/minikube into compare 2019-12-19 11:28:11 -08:00
Priya Wadhwa 1e5aeb6aa9 Addressed review comments 2019-12-19 11:27:53 -08:00