Commit Graph

7570 Commits (6467ec9796f9ba344c3286b65abf4586eb7e882e)

Author SHA1 Message Date
Steven Powell 1fad41a69d increase kubectl command timeout 2023-04-26 22:01:25 -07:00
Steven Powell dda802b332 none driver: fix image build 2023-04-26 18:57:16 -07:00
x7upLime 455bcb19ef refactors removePid logic 2023-04-22 13:32:45 +03:00
x7upLime e5b57f8e89 Changes the way in which pid is written to mounts file
The integration test error was due to the fact that
multiple pids were written to the file without spaces
between them, breaking the pid-kill logic
2023-04-22 00:49:30 +03:00
x7upLime e28a1b411b Removes pidfile util 2023-04-22 00:49:30 +03:00
x7upLime 51e46b6d8d Refactors GetPids
Moves GetPids inside cmd/delete.go as a helper function
Adds description
2023-04-22 00:49:30 +03:00
x7upLime 60c3863f87 Changes klog version and adds it to go.sum
uses klog/v2.. hopefully getting rid of the ci error.
2023-04-22 00:48:56 +03:00
x7upLime 3f47e72752 Modularizes killProcess()
adds helper functions for killing one process, given one pid
adds helper function to read pids out of a given pidfile
2023-04-22 00:48:34 +03:00
x7upLime e34548f9ae Adds description to lock.AppendToFile 2023-04-22 00:47:06 +03:00
x7upLime 9d4f296c1f Adjusts mount processes cleaning logic
The delete mechanism called by the --kill flag logic
inside the minikube mount command, relies on a .mount-process file
inside the .minikube dotfolder in home directory.

For this to work, the mount should've been instantiated
by some mechanism that also creates the file; like
k8s.io/minikube/pkg/minikube/node.configureMounts()

To just add the local.WriteFile() logic from configureMounts()
is not enough for the usecase in #15778:
user's consequent "minikube mount" calls would break the cleaning
logic, since the file's content gets overwritten at each new call.
So on subsequent minikube mounts, a call to "minikube mount
--kill=true" would remove just the last pid, leaving the other
mounts unaltered, and no trace of them in any place...(leak?)

For the same mechanism to work here,
we should rely on some local.AppendFile() function, to add
separated pids consequently.
This way only "minikube mount" would use this new append logic,
leaving unaltered the other functions.

We now have a new behaviour for the .mount-process file,
in order to address this, we should modify the delete logic from
cmd/minikube/cmd/delete.go -- killProcess(),
so that we can both kill a single pid, as well as multiple
space-separated pids in the same way.

...

Ah yes..
we're slightly modifying the "minikube mount" RunE anon function,
in order to write the pid into the .mount-process file;
as well as modifying cluster.Mount()'s signature to accept the pid.
That should be more than safe, since cluster.Mount() is used only here
2023-04-22 00:47:06 +03:00
minikube-bot 0797de325c Addon cloud-spanner: Update cloud-spanner-emulator/emulator image from 1.5.3 to 1.5.4 2023-04-20 14:59:06 +00:00
Medya Ghazizadeh 6d7d7652be
Merge pull request #16205 from spowelljr/refactorKubeletOptions
Refactor kubelet options
2023-04-17 10:46:09 -07:00
minikube-bot 222068166e update image constants for kubeadm images 2023-04-17 06:01:16 +00:00
Steven Powell 245c1bf2f9
Merge pull request #16301 from kubernetes/dependabot/go_modules/k8s.io/kubectl-0.27.0
Bump k8s.io/kubectl from 0.26.3 to 0.27.0
2023-04-13 07:31:01 -07:00
Steven Powell c30c183dac remove deprecated functions 2023-04-12 15:03:13 -07:00
minikube-bot 1709f75282 update image constants for kubeadm images 2023-04-12 20:24:17 +00:00
Steven Powell e270a59090 improve function name and comment 2023-04-11 16:24:46 -07:00
minikube-bot 1c709e8d54 update image constants for kubeadm images 2023-04-11 20:20:44 +00:00
Steven Powell 180b020bde
Merge pull request #16252 from spowelljr/updateDockerBuild
Kicbase: Resolve docker build deprecation
2023-04-11 13:10:47 -07:00
Medya Ghazizadeh 9d9403c50f
Merge pull request #16206 from spowelljr/checkForScannerErrors
cleanup: Check for scanner errors
2023-04-11 10:54:38 -07:00
Medya Ghazizadeh fb2f4f7f04
Merge pull request #16144 from spowelljr/updateCalico
CNI: Update calico from v3.24.5 to v3.25.1
2023-04-11 10:44:25 -07:00
Steven Powell 07f148bb71
Merge pull request #16276 from minikube-bot/auto_bump_k8s_versions
Bump Kubernetes version default: v1.26.3 and latest: v1.27.0-rc.1
2023-04-10 09:00:24 -07:00
minikube-bot 82d7e0f267 bump default/newest kubernetes versions 2023-04-10 08:03:29 +00:00
minikube-bot 889144be5f update image constants for kubeadm images 2023-04-10 06:01:37 +00:00
minikube-bot e79fe85662 Updating kicbase image to v0.0.39-1680813808-16252 2023-04-06 21:00:11 +00:00
minikube-bot 4cd9c1b2d2 Addon cloud-spanner: Update cloud-spanner-emulator/emulator image from 1.5.2 to 1.5.3 2023-04-05 14:58:03 +00:00
Steven Powell c2a5360d5a
Merge pull request #16233 from spowelljr/fixISOAndVMware
Mark VMware driver as unsupported
2023-04-04 12:43:42 -07:00
Steven Powell 2f17549d79 add exit message if user tries to use virtualbox driver 2023-04-04 09:29:36 -07:00
Steven Powell 3948811c76 don't auto suggest the VMware driver 2023-04-04 08:45:24 -07:00
minikube-bot 54d37e6146 Update kicbase to v0.0.39 2023-04-03 21:50:59 +00:00
Medya Ghazizadeh 7e8444aab1
Merge pull request #16215 from afbjorklund/none-crictl
Require crictl to be installed for none driver
2023-04-02 19:14:22 -07:00
Anders F Björklund 8e56b813d7 Don't suggest building cri-dockerd from source
Most people want to use the pre-built binaries of cri-dockerd,
rather than installing go and building it from the source code.

So don't link to the #build-and-install, but to the Releases.
Once it has real documentation URL, that could be used instead.
2023-04-02 22:17:28 +02:00
Anders F Björklund ae7b5dc362 Require crictl to be installed for none driver
Before Kubernetes 1.24, it was possible to use the Docker runtime
without installing the "crictl" debugging tool (from cri-tools).
2023-04-02 22:05:57 +02:00
Medya Ghazizadeh 69a13aba7c
Merge pull request #16207 from spowelljr/updateKindnetd
CNI: Update kindnetd from `v20230227-15197099` to `v20230330-48f316cd`
2023-04-02 12:44:06 -07:00
minikube-bot 388a7f7f56 Updating kicbase image to v0.0.38-1680381266-16207 2023-04-01 20:51:00 +00:00
Medya Ghazizadeh f1c02b5400
Merge pull request #16208 from spowelljr/qemuExxperimentalWindows
QEMU: Mark as experimental on Windows
2023-03-31 17:01:47 -07:00
minikube-bot 821e985d1d Update ISO to v1.30.0 2023-03-31 20:04:43 +00:00
Steven Powell 92a5eee443 QEMU: Mark as experimental on Windows 2023-03-31 12:19:09 -07:00
Steven Powell 7558e6a8d8 CNI: Update kindnetd from v20230227-15197099 to v20230330-48f316cd 2023-03-31 11:31:53 -07:00
Steven Powell 5dd0f26cd7 cleanup: Check for scanner errors 2023-03-31 11:15:34 -07:00
Steven Powell 5a8f8cb541 bump calico to v3.25.1 2023-03-31 10:01:52 -07:00
Steven Powell 1b97cbfbc1 refactor kubelet options 2023-03-31 09:42:43 -07:00
minikube-bot b03365f1b8 Update kicbase to v0.0.38 2023-03-30 21:03:44 +00:00
Steven Powell 9e661c8cf9
Merge pull request #16200 from spowelljr/removeOldRegistry
Remove remaining references to k8s.gcr.io
2023-03-30 13:36:17 -07:00
Steven Powell 10bd017f66
Merge pull request #16191 from minikube-bot/auto_bump_runc_version-85a91eb
bump runc version to 1.1.5
2023-03-30 13:32:56 -07:00
Steven Powell 34cedd2e1e
Merge pull request #16199 from spowelljr/updateGCPAuthWebhook
GCP-Auth: update kube-webhook-certgen image
2023-03-30 12:23:47 -07:00
Medya Ghazizadeh d6162ecf12
Merge pull request #16029 from afbjorklund/kubeadm-registry-flag
Always use the new registry.k8s.io repository
2023-03-30 10:28:06 -07:00
Steven Powell 44c4657e4f remove remaining references to k8s.gcr.io 2023-03-30 09:45:52 -07:00
Steven Powell f372fef9a5 GCP-Auth: update kube-webhook-certgen image 2023-03-30 08:11:14 -07:00
minikube-bot c3e4342648 Updating ISO to v1.29.0-1680115329-16191 2023-03-30 00:38:27 +00:00
minikube-bot 207cff4d07 Updating kicbase image to v0.0.37-1680126204-16191 2023-03-29 22:01:35 +00:00
Medya Ghazizadeh 40fd98c31d
Merge pull request #16179 from spowelljr/updateIngressNginx
addons: Update ingress addon images
2023-03-29 11:24:53 -07:00
Steven Powell 2010622039 remove duplicate test cases 2023-03-29 10:02:46 -07:00
Steven Powell 77f207e01b small clean and fix tests with old k8s versions 2023-03-29 09:58:47 -07:00
Steven Powell da9065fce4 remove setting ImageRepository 2023-03-29 07:18:19 -07:00
Anders F Björklund c6c90abb14 Change conditional syntax to pass the linter 2023-03-29 07:18:19 -07:00
Anders F Björklund 773fa66d3c Always use the new registry.k8s.io repository
This will break air-gapped versions using old releases,
since they will first try to contact the new registry.

But for other installations, it should still work with
older preloads after downloading new image manifests.
2023-03-29 07:18:19 -07:00
minikube-bot 7a4ca6afce bump default/newest kubernetes versions 2023-03-28 17:43:56 +00:00
Steven Powell 45f4d5214d addons: Update ingress addon images 2023-03-28 09:12:32 -07:00
Medya Ghazizadeh 2ee03aa170
Merge pull request #16120 from spowelljr/fixMessage
Add provided message to output
2023-03-27 16:34:31 -07:00
Medya Ghazizadeh 862efeecff
Merge pull request #16168 from minikube-bot/auto_bump_containerd_version-3b00a4c
bump containerd version
2023-03-27 16:33:04 -07:00
Steven Powell 764c5c3b86
Merge pull request #16149 from maxbrunet/fix/cri-docker-system-logs
cruntime/docker: Include system logs from cri-docker
2023-03-27 08:56:40 -07:00
minikube-bot a6b0f9925e Updating ISO to v1.29.0-1679912107-16168 2023-03-27 15:34:03 +00:00
minikube-bot dd756b7043 update image constants for kubeadm images 2023-03-27 06:01:34 +00:00
Steven Powell b00041d7f3
Merge pull request #16142 from minikube-bot/auto_bump_cloud_spanner_emulator_version
bump cloud-spanner-emulator version
2023-03-24 13:18:00 -07:00
Steven Powell 427338a724
Merge pull request #16136 from minikube-bot/auto_bump_metrics_server_version
bump metrics-server version
2023-03-24 13:16:50 -07:00
Maxime Brunet 120e1bce37
cruntime/docker: Include system logs from cri-docker 2023-03-24 10:48:40 -07:00
Steven Powell 10145a2381
Merge pull request #15834 from OmSaran/tunnel
Ensure only one instance of tunnel process runs
2023-03-24 10:03:15 -07:00
Steven Powell 5d78d061bf update calico from v3.24.5 to v3.25.0 2023-03-23 14:28:07 -07:00
minikube-bot 116ba2cab4 bump cloud-spanner-emulator version 2023-03-23 18:27:24 +00:00
minikube-bot a36767a621 bump metrics-server version 2023-03-22 21:12:19 +00:00
minikube-bot 0559aa672b bump default/newest kubernetes versions 2023-03-22 18:23:57 +00:00
Medya Ghazizadeh 5a072f066e
Merge pull request #16124 from afbjorklund/runtime-endpoint
Remove container-runtime flag from later versions
2023-03-22 11:21:45 -07:00
Medya Ghazizadeh 519e2aaf59
Merge pull request #14703 from afbjorklund/cri-config
Handle CRI config of NetworkPlugin and PauseImage
2023-03-22 09:52:02 -07:00
Anders F Björklund eeac85fe47 Remove redundant image-service endpoint
The default ep is the same as for container-runtime

Remove the extra config since it doesn't do anything
2023-03-21 21:39:55 +01:00
Anders F Björklund aa4097288d Remove container-runtime flag from later versions
Since k8s 1.24, the only available option is remote.

It also now needs a socket URL, and not just a path.
2023-03-21 21:39:43 +01:00
Steven Powell 98eb1a737c add provided message to output 2023-03-21 12:03:54 -07:00
Steven Powell 9c5983c9df
Merge pull request #16113 from kinvolk/headlamp-maintainer
Add maintainer for Headlamp addon
2023-03-21 11:46:48 -07:00
Medya Ghazizadeh 2cd5e023e9
Merge pull request #16109 from spowelljr/fixUnitTest
tests: Fix unit test failing if docker not running
2023-03-21 11:02:14 -07:00
Medya Ghazizadeh 856e7063fc
Merge pull request #16095 from minikube-bot/auto_bump_golint_version
bump golint version
2023-03-21 10:34:00 -07:00
S Santhosh Nagaraj 67cb5484ee
Add maintainer for Headlamp addon 2023-03-21 18:10:08 +05:30
Steven Powell c72584ab5f
Merge pull request #16079 from minikube-bot/auto_bump_buildkit_version-d6ae12f
bump buildkit version
2023-03-20 17:09:46 -07:00
Steven Powell 35b0b56e9e tests: fix unit test failing if docker not running 2023-03-20 16:59:47 -07:00
Steven Powell 86778e3b72
Merge pull request #16081 from spowelljr/solutionMessage
Add solution message for cpu controller delegation
2023-03-20 14:03:47 -07:00
Steven Powell 50e9147e4e fix lint errors 2023-03-20 12:43:07 -07:00
minikube-bot 6323f7619d Updating ISO to v1.29.0-1679074930-16079 2023-03-17 22:58:35 +00:00
minikube-bot 8be33f885c update image constants for kubeadm images 2023-03-17 20:10:38 +00:00
minikube-bot cc014b5c25 Updating kicbase image to v0.0.37-1679075007-16079 2023-03-17 18:02:47 +00:00
Steven Powell 632b881052 add solution message for cpu controller delegation 2023-03-17 10:56:56 -07:00
Medya Ghazizadeh ef22f3d970
Merge pull request #16068 from spowelljr/updateUbuntu
kicbase: Update Ubuntu base image
2023-03-17 10:22:58 -07:00
minikube-bot 41e9a233cf Updating kicbase image to v0.0.37-1678988071-16068 2023-03-16 17:53:18 +00:00
joaquimrocha 800e15b174 Update Headlamp container version to 0.16.0
Signed-off-by: joaquimrocha <joaquimrocha@users.noreply.github.com>
2023-03-16 15:36:32 +00:00
Bart Van Bos f0e0e69dc1 [issue #16053] fix metallb docker.io dependency and move to quay.io 2023-03-15 20:19:08 +01:00
Medya Ghazizadeh 0cdd5894f2
Merge pull request #15991 from spowelljr/updateUbuntu
kicbase: update Ubuntu base image
2023-03-13 11:45:17 -07:00
Medya Ghazizadeh 282c4ef83a
Merge pull request #15685 from ComradeProgrammer/json_progress_kicbase
feat: Add kicbase download progress to JSON output
2023-03-13 11:41:42 -07:00
Medya Ghazizadeh 75851c0e6a
Merge pull request #15985 from spowelljr/kubectlContext
GCP-Auth: Add fixes and timeouts
2023-03-13 11:40:26 -07:00
Medya Ghazizadeh 53882ffbf4
Merge pull request #16025 from spowelljr/updateAutoPause
Addons: Update auto-pause from v0.0.3 to v0.0.4
2023-03-10 16:24:55 -08:00
Steven Powell a74960db49 Addons: Update auto-pause from v0.0.3 to v0.0.4 2023-03-10 11:19:31 -08:00
Steven Powell 50b0730e5d
Merge pull request #15984 from spowelljr/fixAddons
Fix image related bugs when enabling addons
2023-03-10 11:11:41 -08:00
minikube-bot a6ed40104a Updating kicbase image to v0.0.37-1678473806-15991 2023-03-10 19:03:21 +00:00
Steven Powell def064752e
Merge pull request #15973 from minikube-bot/auto_bump_containerd_version
bump containerd version
2023-03-10 10:30:05 -08:00
Steven Powell 5fc72f6c26 update gcp-auth addon 2023-03-09 12:23:59 -08:00
Steven Powell e96a30e871
Merge pull request #15995 from kinvolk/update_headlamp_0.15.1
Upgrade Headlamp version to 0.15.1
2023-03-09 11:18:03 -08:00
minikube-bot c1079b345b Updating ISO to v1.29.0-1678210391-15973 2023-03-07 22:44:33 +00:00
Om Saran e8625a3ba0 Add test to ensure no two tunnels can run simultaneously.
Add new error reason to disallow simultaneously running two tunnel processes
When tunnel fails to acquire lock due to contention, exit gracefully
2023-03-07 11:11:40 -08:00
Steven Powell 2b41e1d4db create config.json file for test 2023-03-07 10:12:03 -08:00
minikube-bot 51165e4403 Updating kicbase image to v0.0.37-1678210470-15973 2023-03-07 18:00:45 +00:00
Steven Powell 93a8607044 fix image related bugs when enabling addons 2023-03-06 14:19:18 -08:00
Steven Powell 49d57361cb add timeout for refreshing pods 2023-03-06 14:15:28 -08:00
Steven Powell fac2ca0a09
Merge pull request #15974 from minikube-bot/auto_bump_cloud_spanner_emulator_version
bump cloud-spanner-emulator version
2023-03-06 07:52:33 -08:00
minikube-bot f41ca99cbb bump cloud-spanner-emulator version 2023-03-06 10:06:39 +00:00
minikube-bot 5465f48d3a update image constants for kubeadm images 2023-03-06 06:01:52 +00:00
Medya Ghazizadeh ddd77635b4
Merge pull request #15923 from spowelljr/updateContainerd
ISO/Kicbase: Update containerd from 1.6.15 to 1.6.18
2023-03-03 15:28:03 -08:00
Товарищ программист 07431a413d feat: Add kicbase download progress to JSON output 2023-03-02 15:19:39 +08:00
Medya Ghazizadeh 8c665cf08c
Merge pull request #15943 from minikube-bot/auto_bump_k8s_versions
Bump Kubernetes version default: v1.26.2 and latest: v1.26.2
2023-03-01 13:26:02 -08:00
Medya Ghazizadeh 76e716ac4c
Merge pull request #15940 from spowelljr/updateKindnet
Update kindnetd image and entrypoint
2023-03-01 13:18:46 -08:00
Steven Powell 4e33f96173 add timeout and force to kubectl command 2023-03-01 13:07:46 -08:00
minikube-bot bdecd80d9d bump default/newest kubernetes versions 2023-03-01 15:55:20 +00:00
minikube-bot d355ac86d5 update image constants for kubeadm images 2023-03-01 15:02:42 +00:00
Steven Powell 57656be49c update kindnetd image and entrypoint 2023-02-28 11:17:53 -08:00
Anders F Björklund 2624a19c72 Handle CRI config of NetworkPlugin and PauseImage
These have been removed from the kubelet, and are supposed to be
handled by the CRI config. Remove the earlier Docker-only hacks.
2023-02-26 13:58:10 +01:00
minikube-bot ef4c5dd519 Updating ISO to v1.29.0-1677261626-15923 2023-02-25 00:03:58 +00:00
minikube-bot 43cc15ac49 Updating kicbase image to v0.0.37-1677262057-15923 2023-02-24 18:29:56 +00:00
Medya Ghazizadeh e9ad3cc97e
Update pkg/minikube/logs/logs.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-23 12:05:04 -08:00
Medya Gh e35e2c770e add storage provisioner to minikube logs 2023-02-22 13:48:39 -08:00
Medya Ghazizadeh 707562b735
Merge pull request #15866 from swastik959/json
added detail json for addons
2023-02-22 13:12:19 -08:00
Medya Ghazizadeh e59f4f4be9
Merge pull request #15882 from spowelljr/updateIngressController
Addons: Update ingress controller from v1.5.1 to v1.6.4
2023-02-21 09:09:27 -08:00
minikube-bot bbd0c379aa update image constants for kubeadm images 2023-02-20 06:01:51 +00:00
swastik959 14b32a040b added linting and fixed ubit test 2023-02-18 10:30:32 +05:30
Steven Powell e066375fe1
Merge pull request #15762 from shubhbapna/issue-15710
Fix `minikube addons list` output for default addons
2023-02-17 15:28:11 -08:00
Medya Ghazizadeh 7d2c71bf60
Merge pull request #15872 from medyagh/skipauditflag
new flag --skip-audit and skip profile cmd from audit by default
2023-02-17 10:26:35 -08:00
Medya Ghazizadeh 616f4491fa
Merge pull request #15849 from medyagh/isonopass
Disable plain text login for ISO
2023-02-17 09:56:22 -08:00
Medya Ghazizadeh d8b4a2d0f1
Merge pull request #15784 from afbjorklund/cri-dockerd-path
Look for cri-dockerd instead of hardcoding
2023-02-17 09:55:33 -08:00
Steven Powell 419a693b0a update ingress controller from v1.5.1 to v1.6.4 2023-02-17 09:41:14 -08:00
Shubh Bapna f88c6ad3cd added isEnabledOrDefault 2023-02-17 11:00:22 -05:00
Shubh Bapna 2ac143527f Revert "persist whether install-addons was true or false"
This reverts commit 0f334dbc0f.
2023-02-17 10:40:48 -05:00
yolossn c13a64b66a Upgrade Headlamp version to 0.15.1
Signed-off-by: yolossn <sannagaraj@microsoft.com>
2023-02-17 16:19:56 +05:30
Medya Ghazizadeh c0b8440f6e
Update pkg/minikube/config/config.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-16 14:43:43 -08:00
Medya Ghazizadeh 3719f06afb
Merge pull request #15768 from spowelljr/updateUbuntu
Kicbase: Update Ubuntu base image
2023-02-16 14:43:13 -08:00
Medya Ghazizadeh 0ffc25385d
Merge pull request #15720 from p2c2e/master
Infer HyperKit HostIP as Gateway rather than hardcode to 192.168.64.1
2023-02-16 13:32:33 -08:00
Medya Gh fbce562099 add a new flag called --skip-aduit 2023-02-16 12:56:03 -08:00
minikube-bot 68f5c76278 Updating ISO to v1.29.0-1676526122-15849 2023-02-16 11:26:14 +00:00
minikube-bot 816c4f7dc1 Updating kicbase image to v0.0.37-1676506612-15768 2023-02-16 00:39:21 +00:00
Steven Powell 8d12bf3d19
Merge pull request #15752 from spowelljr/updateCriDockerd
ISO/Kicbase: Update cri-dockerd from 0.3.0 to 0.3.1
2023-02-15 15:46:39 -08:00
Medya Ghazizadeh 906f30c9de
Merge pull request #15851 from spowelljr/fixDockerVersionPanic
Prevent panic if docker version returns exit code 0 with unexpected output
2023-02-15 09:10:51 -08:00
minikube-bot 197ca21b77 Updating ISO to v1.29.0-1676397967-15752 2023-02-14 22:39:19 +00:00
Steven Powell a93baae9d8 refactor and add unit tests 2023-02-14 12:55:31 -08:00
Medya Ghazizadeh 5ea80d0b84
Merge pull request #15829 from denisok/master
update CSI driver, enable multi-node
2023-02-14 10:51:52 -08:00
Medya Ghazizadeh 8848aad3c7
Merge pull request #15781 from spowelljr/windows
Implement basic QEMU on Windows code
2023-02-14 10:25:03 -08:00
Shubh Bapna 0f334dbc0f persist whether install-addons was true or false 2023-02-14 12:42:04 -05:00
Steven Powell 20473addf4 prevent panic if docker version returns exit code 0 with unexpected output 2023-02-13 16:50:20 -08:00
Denys Kondratenko 76ccf5c3ba
Merge branch 'kubernetes:master' into master 2023-02-13 21:30:11 +01:00
Anders F Björklund 99bff1ec78 Download binaries from dl.k8s.io instead of GCS
Need to add the -L to curl, to follow HTTP 302

Don't change the path for the current GCS mirror
2023-02-13 19:57:44 +01:00
Denys Kondratenko 0ba0122e6f update CSI driver, enable multi-node 2023-02-10 23:56:20 +01:00
Medya Ghazizadeh 5c0c9e8e7c
Merge pull request #15735 from elizabeth-dev/fix/wait-cli-command
fix: service CLI command not honoring --wait arg
2023-02-10 11:21:43 -08:00
Medya Ghazizadeh 3a9c9a83cc
Merge pull request #15775 from spowelljr/addIngressAddonToLogs
Add ingress pod to logs output
2023-02-10 11:20:15 -08:00
Medya Ghazizadeh fc644b8453
Merge pull request #15793 from spowelljr/tabbedVView
QEMU: Rename `user` network to `builtin` and update documentation
2023-02-10 10:33:29 -08:00
minikube-bot e3dce2bb46 Updating kicbase image to v0.0.37-1675980448-15752 2023-02-09 22:25:53 +00:00
minikube-bot 5e0a054570 Updating kicbase image to v0.0.37-1675975957-15752 2023-02-09 21:15:24 +00:00
Steven Powell 0046eba5c3 rename IsBuiltin to IsBuiltinQEMU 2023-02-09 12:07:17 -08:00
Steven Powell 0b7c0810c9 add support to new builtin value on existing cluster 2023-02-09 10:27:16 -08:00
Steven Powell c417258f9c change user network to builtin 2023-02-09 09:48:43 -08:00
Steven Powell 7ad68725b4
Merge pull request #15770 from nickmancari/new-last-start-only-flag
add new flag --last-start-only to only show last start logs
2023-02-08 13:36:52 -08:00
Anders F Björklund 90bc8a99b1 Look for cri-dockerd instead of hardcoding
Some people install the daemon in /usr/local/bin,
rather than under /usr/bin as the unit expects.
2023-02-05 12:32:22 +01:00
Steven Powell 62b5c51a96 fix linting 2023-02-03 15:04:39 -08:00
Steven Powell f5eacdf2a5 qemu on windows 2023-02-03 10:37:06 -08:00
Steven Powell 5759d115d7 fix comment typo 2023-02-02 09:43:34 -08:00
Steven Powell b7f13c05b3 add func comment 2023-02-02 09:34:55 -08:00
Elizabeth Martin Campos 3f9c7f3eb4 fix: service command not honoring --wait arg
The minikube service <service> CLI command has a --wait argument documented that enabled the user to wait the given seconds for a service to be available in the cluster, but this was being ignored.

The logic for waiting was already implemented, but was being overriden by an unneeded early return. I removed that, and added a test case that verifies this feature is working as intended, since it was untested.
2023-02-02 18:29:27 +01:00
Steven Powell a9378cd149 add TestEnabledAddonPods 2023-02-02 09:27:26 -08:00
Steven Powell e2fbb2d321 add ingress pod to logs output 2023-02-01 13:51:23 -08:00
nickmancari 1db52e77b4 added flag 2023-02-01 15:34:37 -06:00
minikube-bot e058085c1f Updating kicbase image to v0.0.37-1675280603-15763 2023-02-01 20:03:31 +00:00
Medya Ghazizadeh 46e23cef59
Merge pull request #15728 from spowelljr/updateBuildkit
Kicbase/ISO: Update buildkit to v0.11.2
2023-02-01 11:32:28 -08:00
Shubh Bapna 2d7df77bcb
Fix test error message
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-02-01 14:19:59 -05:00
Steven Powell 972db8adbd
Merge pull request #15743 from spowelljr/pdateCloudSpannerSHA
Update cloud-spanner SHA
2023-02-01 10:36:34 -08:00
minikube-bot 5159845608 Updating ISO to v1.29.0-1675184411-15728 2023-01-31 21:25:55 +00:00
Shubh Bapna b0513bcbc8 disabled addons while starting node if existing addons in nil 2023-01-31 14:19:28 -05:00
Shubh Bapna e0016e6ed1 added function to disable all addons in config. updated test cases 2023-01-31 14:18:48 -05:00
Steven Powell acd773e4c2
Merge pull request #15738 from minikube-bot/auto_bump_kubeadm_constants
Bump kubeadm constants for kubernetes images
2023-01-30 09:02:26 -08:00
Steven Powell c80c8852a8 update cloud-spanner SHA 2023-01-30 08:57:33 -08:00
minikube-bot afd31a1d08 Updating kicbase image to v0.0.37-1675094849-15728 2023-01-30 16:30:52 +00:00
minikube-bot db2e04f69b update image constants for kubeadm images 2023-01-30 06:01:35 +00:00
minikube-bot 1d3af1f8d8 Updating ISO to v1.29.0-1674856271-15565 2023-01-28 19:16:06 +01:00
Sudharsan Rangarajan 5ddae1494f Infer HyperKit HostIP as Gateway rather than hardcode to 192.168.64.1 2023-01-27 15:32:29 +05:30
minikube-bot de8c791982 Update kicbase to v0.0.37 2023-01-27 00:26:24 +00:00
Steven Powell 18d1d2e5ea
Merge pull request #15713 from minikube-bot/kicbase-release-v0.0.37
Update kicbase to v0.0.37
2023-01-26 11:06:20 -08:00
minikube-bot f9b2cd2fba Update kicbase to v0.0.37 2023-01-26 18:16:16 +00:00
minikube-bot 618eac68a3 Update ISO to v1.29.0 2023-01-26 18:16:16 +00:00
Medya Ghazizadeh 625c53787e
Merge pull request #15686 from spowelljr/addMEssage
Add solution message for socket_vmnet permission denied
2023-01-26 10:09:51 -08:00
Steven Powell 4041bb8042
Merge pull request #15707 from spowelljr/updateCloudSpanner
Update cloud-spanner-emulator from 1.4.9 to 1.5.0
2023-01-25 15:00:13 -08:00
Steven Powell 7cddc7e5d5
Merge pull request #15703 from spowelljr/updateDocker
ISO: update Docker from 20.10.22 to 20.10.23
2023-01-25 14:56:56 -08:00
Steven Powell d5422a33fc
Merge pull request #15706 from prezha/fix-addons-map-race-condition
fix addons map race condition
2023-01-25 14:47:21 -08:00
Steven Powell 7c1f8491bd typo 2023-01-25 10:47:30 -08:00
Steven Powell 0fbb9a6a31 update comments and store socket_vmnet paths in machine config 2023-01-25 10:45:20 -08:00
Steven Powell 6331666c36 update cloud-spanner-emulator from 1.4.9 to 1.5.0 2023-01-25 09:08:44 -08:00
Predrag Rogic 9edc995811
fix addons map race condition 2023-01-25 16:05:35 +00:00
minikube-bot 53cebc3700 Updating ISO to v1.28.0-1674600669-15703 2023-01-25 04:28:35 +00:00
minikube-bot f1058d1df1 Updating kicbase image to v0.0.36-1674600772-15703 2023-01-24 23:16:12 +00:00
Steven Powell c248182197 fix typo 2023-01-24 12:03:40 -08:00
Steven Powell 46e9cc24ee check brew install paths for socket_vmnet 2023-01-24 11:51:17 -08:00
Medya Ghazizadeh a777c22409
Merge pull request #15695 from spowelljr/fixTestYAMLs
Fix unit test yamls for kubernetes 1.26
2023-01-24 10:13:40 -08:00
Steven Powell 10c9ba2add
Merge pull request #15624 from spowelljr/warnVirtualBoxMacOS
Warn users if using VirtualBox on macOS 13+
2023-01-24 09:47:51 -08:00
Steven Powell f289f766c3 fix test yamls 2023-01-23 17:24:12 -08:00
Medya Ghazizadeh e7de6202d9
Merge pull request #15682 from minikube-bot/auto_bump_kubeadm_constants
Bump kubeadm constants for kubernetes images
2023-01-23 16:47:27 -08:00
Medya Ghazizadeh d27a234f93
Merge pull request #15541 from spowelljr/updateDocker
ISO: Update docker, containerd, and cri-dockerd
2023-01-23 16:45:29 -08:00
Medya Ghazizadeh 349eda8baf
Merge pull request #15683 from minikube-bot/auto_bump_k8s_versions
Bump Kubernetes version default: v1.26.1 and latest: v1.26.1
2023-01-23 16:44:56 -08:00
Steven Powell bd38eaf59f remove forcing cgroup on containerd 2023-01-23 15:08:24 -08:00
Steven Powell 99b4e45b1e
Revert "Special case port mapping publish on macOS" 2023-01-23 13:19:49 -08:00
Steven Powell 27e7050844 add solution message for socket_vmnet permission denied 2023-01-23 08:04:42 -08:00
minikube-bot ecb1f7a052 bump default/newest kubernetes versions 2023-01-23 08:03:24 +00:00
minikube-bot 0c6001eab9 update image constants for kubeadm images 2023-01-23 06:01:20 +00:00
Steven Powell cba0057691 removed temp funcs 2023-01-20 11:19:45 -08:00
Steven Powell eb884228a4 warn users if using VirtualBox on macOS 13+ 2023-01-19 15:08:01 -08:00
minikube-bot 6b0d72651d Updating kicbase image to v0.0.36-1674164627-15541 2023-01-19 22:06:53 +00:00
Steven Powell a3d4863cf4 update containerd to 1.6.15 and cri-dockerd to 0.3.0 2023-01-19 13:34:09 -08:00
minikube-bot 74385986c2 Updating ISO to v1.28.0-1671646515-15541 2023-01-19 13:14:20 -08:00
Steven Powell 0e7aefca1b
Merge pull request #15463 from prezha/fix-TestNetworkPlugins-Linux_Docker
improve how CRs and k8s work with CNI plugins and cgroup drivers
2023-01-19 13:04:52 -08:00
Steven Powell 8ffa1f9723
Merge pull request #15667 from spowelljr/updateCloudSpanner
Update cloud-spanner-emulator from 1.4.8 to 1.4.9
2023-01-19 09:53:07 -08:00
Medya Ghazizadeh ae7cb58bbf
Merge pull request #15642 from afbjorklund/crictl-version-path
Use absolute path when calling crictl version
2023-01-19 08:44:58 -08:00
Medya Ghazizadeh 881d72bb22
Merge pull request #15646 from spowelljr/warnDockerVersion
Add check for Docker Desktop 4.16.0
2023-01-19 08:42:31 -08:00
Predrag Rogic 1eb68e8f8a
fix cri-o: ignore disabled cnis 2023-01-19 03:37:39 +00:00
Steven Powell 092e799e6e update cloud-spanner-emulator from 1.4.8 to 1.4.9 2023-01-18 16:02:10 -08:00
Steven Powell fdec92c6bf add gcp-auth to logs output if enabled 2023-01-18 11:00:56 -08:00
Predrag Rogic 15bb620ca1
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker 2023-01-18 02:43:47 +00:00
Predrag Rogic 4c18f9d264
fix cri-o: work with selected cni and detected cgroup driver 2023-01-18 02:41:24 +00:00
Medya Ghazizadeh 1b124462b1
Merge pull request #15611 from afbjorklund/numcpu-docker
Allow running docker driver with force on 1 CPU
2023-01-17 10:30:31 -08:00
Medya Ghazizadeh e793aee1f4
Merge pull request #15610 from afbjorklund/numcpu-kubeadm
Allow running none driver with force on 1 CPU
2023-01-17 10:28:48 -08:00
Medya Ghazizadeh c3f8090586
Merge pull request #15556 from spowelljr/qemuRemovevExperimental
Remove experimental markings from QEMU driver
2023-01-17 10:23:13 -08:00
Steven Powell 833d632991
Merge pull request #15630 from kushmansingh/kmansingh/buildkit11
Update buildkit to v0.11.0
2023-01-17 10:15:21 -08:00
Steven Powell c27da1c443 call docker version once and testing 2023-01-13 15:00:27 -08:00
Steven Powell 4bd288c4bf add check for Docker Desktop 4.16.0 2023-01-13 14:09:56 -08:00
Anders F Björklund 4cf467cecc Use absolute path when calling crictl version
Some legacy systems don't have /usr/local/bin in secure_path

So they are not able to find any locally installed tools...
2023-01-13 17:43:10 +01:00
Predrag Rogic e2f2bc923a
fix none driver 2023-01-13 02:35:09 +00:00
Predrag Rogic 4fbcdfc2ae
reference follow up issue 2023-01-12 21:26:05 +00:00
Predrag Rogic 470e7b6fa0
Update pkg/minikube/cruntime/cri.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-01-12 21:19:44 +00:00
Predrag Rogic 23351ba30d
Update pkg/kapi/kapi.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-01-12 21:18:49 +00:00
minikube-bot a7f681f610 Updating kicbase image to v0.0.36-1673540226-15630 2023-01-12 16:41:07 +00:00
Predrag Rogic a573330a00
fix updateContainerdBinary 2023-01-12 13:48:00 +00:00
Akihiro Suda 98d5467d9f
minikube image load: print more debug logs
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-01-12 08:12:59 +09:00
Steven Powell 22db818811
Merge pull request #15482 from spowelljr/fixProgressBars
Remove progress bar for kic download when JSON output
2023-01-10 16:34:30 -08:00
Predrag Rogic 805f7b2da3
lint 2023-01-10 23:04:57 +00:00
Predrag Rogic 24226c5f5a
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker 2023-01-10 22:44:50 +00:00
Predrag Rogic 4a8e7ad85a
address comments 2023-01-10 22:43:05 +00:00
Predrag Rogic da3af5aca7
Update pkg/minikube/node/start.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-01-10 22:17:35 +00:00
Predrag Rogic 7703fee08e
Update pkg/network/network.go
Co-authored-by: Steven Powell <44844360+spowelljr@users.noreply.github.com>
2023-01-10 22:16:51 +00:00
Steven Powell 6b96d92f7d remove progress bar for kic download when JSON output 2023-01-10 09:21:43 -08:00
Shubh Bapna f802744c46 updated test cases, restore mocks 2023-01-10 03:02:23 -05:00
Shubh Bapna 7557b8167e removed custom isSubnetPrivate func and used the default one provided by go net pkg 2023-01-10 03:01:55 -05:00
Predrag Rogic f1b1724128
address comments 2023-01-10 05:37:25 +00:00
Medya Ghazizadeh 0fee35b5c0
Merge pull request #15553 from spowelljr/addStaticIP
Implement --static-ip flag
2023-01-09 11:20:16 -08:00
Predrag Rogic 6c98afcdbd
cleanup and containerd systemd cgroup issue workaround 2023-01-09 02:23:07 +00:00
Anders F Björklund 83d4219fee Allow running docker driver with force on 1 CPU 2023-01-08 18:19:11 +01:00
Anders F Björklund b45c13b3eb Allow running none driver with force on 1 CPU 2023-01-08 18:17:24 +01:00
Predrag Rogic faa909d429
Merge branch 'kubernetes:master' into fix-TestNetworkPlugins-Linux_Docker 2023-01-05 19:19:16 +00:00
Steven Powell afe0f18b28
Merge pull request #15571 from axrav/master
refactor: avoiding repetitive code
2023-01-04 13:35:30 -08:00
Predrag Rogic 149e9a01b6
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker 2023-01-04 21:10:29 +00:00
Predrag Rogic 818a7d9b33
fix remaining tests and ready for k8s-1.26.0 2023-01-04 21:02:48 +00:00
Steven Powell e6d95b8230 implement --static-ip flag 2023-01-04 10:27:00 -08:00
Steven Powell 80dbe4c5b7
Merge pull request #15530 from shubhbapna/validate-subnet
Added `--subnet` validation
2023-01-04 10:22:50 -08:00
Steven Powell f4e0de7c26 change priority to default 2023-01-04 08:30:09 -08:00
Medya Ghazizadeh c781e431a7
Merge pull request #15560 from spowelljr/fixDockerTunnel
Fix Docker tunnel failing
2023-01-03 14:57:31 -08:00
Medya Ghazizadeh a670a214f5
Merge pull request #15528 from spowelljr/fixDoubleKicDownload
Don't redownload kicbase when already loaded
2023-01-03 14:51:07 -08:00
Steven Powell ba56f3c78c update CacheToDaemon comment 2023-01-03 14:50:33 -08:00
Aarav Arora 3573ff8887
refactor: avoiding needless status results 2023-01-04 03:53:18 +05:30
Aarav Arora 289b98ee6a
refactor: better code practice 2023-01-03 22:52:55 +05:30
Steven Powell e386db276c fix another path 2022-12-29 10:27:11 -08:00
Steven Powell 3ff8798094 fix Docker tunnel failing 2022-12-29 07:58:42 -08:00
Predrag Rogic 1274f31179
fix TestBinaryUpgrade on Docker_Linux_containerd and skip GCPAuth on GCE 2022-12-28 19:47:34 +00:00
Steven Powell 649b8ef5b1 remove experimental markings from QEMU driver 2022-12-28 08:42:01 -08:00
Predrag Rogic fd549f396d
fix default cni selection for cri-docker(d) 2022-12-28 00:51:45 +00:00
Predrag Rogic f3b3d4e07c
try to fix couple of more things 2022-12-27 04:27:48 +00:00
Predrag Rogic 51464691f7
gotcha 2022-12-26 14:39:51 +00:00
Predrag Rogic 2a00282410
work around non-linux builds for cgroups detection 2022-12-26 07:28:33 +00:00
Predrag Rogic 5d13061ca9
Merge branch 'master' into fix-TestNetworkPlugins-Linux_Docker 2022-12-26 06:11:52 +00:00
Predrag Rogic e59d6217a8
autoconfigure cni and cri with proper cgroup driver 2022-12-26 06:06:31 +00:00
Medya Ghazizadeh f80c39ccd5
Merge pull request #15513 from kaylendog/master
Add groups check to SSH driver
2022-12-21 13:59:12 -08:00
Predrag Rogic 735ac02aac
get container logs 2022-12-19 20:32:23 +00:00
Predrag Rogic 9531b37973
fix subnet reservation 2022-12-19 02:58:31 +00:00
Predrag Rogic 167d90f548
improve log collection and update flannel manifest 2022-12-18 04:35:22 +00:00
Shubh Bapna ac0c094df7 added ParseAddr function and its test cases 2022-12-17 14:39:45 -05:00
Predrag Rogic 4e0994c43e
Merge remote-tracking branch 'upstream/master' into fix-TestNetworkPlugins-Linux_Docker 2022-12-17 17:57:34 +00:00
Steven Powell ebb3904683 fix kicbase image not being updated 2022-12-16 14:47:46 -08:00
Steven Powell 05671a18da fix download only 2022-12-16 13:49:53 -08:00
Steven Powell c7a3707486 use image.Tag 2022-12-16 13:14:07 -08:00
Steven Powell c2165d04d2 remove ImageToDaemon 2022-12-16 13:05:26 -08:00
Steven Powell ffc3f40ed8 stop downloading kicbase when already cached 2022-12-16 12:28:51 -08:00
Predrag Rogic e51fef3118
prevent overlapping network segments 2022-12-14 23:38:45 +00:00
joaquimrocha f174c973fa Update Headlamp container version to 0.14.1
Signed-off-by: joaquimrocha <joaquimrocha@users.noreply.github.com>
2022-12-14 22:41:12 +00:00
Steven Powell 455e334fbe
Merge pull request #15403 from iastewar/gcp-auth-watch-namespaces
gcp-auth addon now adds the image registry pull secret to newly created namespaces
2022-12-14 13:50:24 -08:00
Kaylen Dart 24428fdbd1
correct groups check output from stderr to stdout 2022-12-14 18:11:01 +00:00
Kaylen Dart 0be72ee60b
add groups check to ssh driver 2022-12-14 18:09:26 +00:00
Predrag Rogic d3bdac0379
fix containerd when bound to docker 2022-12-13 21:16:25 +00:00
Predrag Rogic 7e20c16886
collect debug logs 2022-12-13 14:41:30 +00:00
Predrag Rogic 72c8acc370
fix Docker_Linux and multinode 2022-12-13 03:35:16 +00:00
Predrag Rogic 788a9d6bd7
wait and log 2022-12-12 11:45:52 +00:00
minikube-bot 54c58a2a02 update image constants for kubeadm images 2022-12-12 06:01:25 +00:00
Predrag Rogic 4cd9a94637
use systemd 2022-12-12 00:49:23 +00:00
Predrag Rogic 0fa75ce152
use systemd 2022-12-11 18:12:41 +00:00
Predrag Rogic 19812b0cc1
debug 2022-12-11 06:06:11 +00:00