4ce2f784f1
Fix failure issues with integration testing for service command
2019-10-30 13:57:08 -07:00
2c0f2a42dd
Append newline to --url output
2019-10-30 12:35:25 -07:00
f60764b07f
service: fix --url mode, add integration tests
2019-10-30 10:44:54 -07:00
ef398338d6
Merge pull request #5530 from medyagh/NewCmdRunner
...
Refactor command runner interface, allow stdin writes
2019-10-29 22:26:14 -07:00
169c3e7479
Add skeleton for performance scanning service
...
This service runs in a VM and is responsible for:
1. Determining which PRs need to be analyzed
2. Running mkcmp against each PR
3. Commenting the results on the PR via minikube-bot
This PR also moves the mkcmp code into its own directory.
2019-10-29 13:53:49 -07:00
74a5d477f2
Merge pull request #5718 from nanikjava/f-fix-test-disable-browser-test
...
Refactor to remove opening browser and just return url(s)
2019-10-29 13:51:33 -07:00
b4ce29d589
Merge pull request #5757 from priyawadhwa/wait_false
...
Set --wait=false to default but still wait for apiserver
2019-10-28 21:52:15 -07:00
994d093766
Add boolean to disable opening browser during test
...
The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.
The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
2019-10-29 13:23:41 +11:00
bd5840aacf
improve comments
2019-10-28 18:02:45 -07:00
f3b1a09c36
Clean up bootstrapper interface to accept list of pods to wait for
...
when waiting for the cluster to start up.
2019-10-28 17:34:04 -07:00
5f12e9afa1
Update docs and add error message to generate-docs
2019-10-28 17:12:03 -07:00
29a015b63f
remove more bin bash c
2019-10-28 14:10:22 -07:00
f5ad9014ae
Merge pull request #5758 from tstromberg/inverted-ssh
...
Do not check sshd for the none driver
2019-10-28 10:56:30 -07:00
f92b308f9a
Rebased on master
2019-10-28 10:46:35 -07:00
cf62ff62b2
Remove extra log
2019-10-28 10:46:14 -07:00
7900b63d2b
Wait for only apiserver by default
...
This PR changes --wait=false to be the default, but to still check for the apiserver in this case. If wait=true, we still wait for all pods to be up and running. This change should speed up `minikube start`, since we won't have to wait for other pods which can take a longer time to start up.
Ref #5681
2019-10-28 10:45:57 -07:00
b1fd21e118
Do not check sshd for the none driver
2019-10-28 10:35:20 -07:00
e2bbf7111e
Merge branch 'master' into NewCmdRunner
2019-10-27 00:18:00 -07:00
d635b8dfc7
Add comments as requested by golint
2019-10-26 13:16:29 +02:00
c3498c593b
Decrease cyclomatic complexity
...
Mostly by using the "extract method" pattern.
Here is the report (from gocyclo), before:
21 cmd runStart cmd/minikube/cmd/start.go:272:1
18 cmd validateNetwork cmd/minikube/cmd/start.go:982:1
16 cmd runDelete cmd/minikube/cmd/delete.go:90:1
16 cmd deleteProfile cmd/minikube/cmd/delete.go:177:1
2019-10-26 13:08:23 +02:00
991d84e9f5
Merge pull request #5732 from tstromberg/config-avail
...
Hide innocuous viper ConfigFileNotFoundError
2019-10-25 12:45:20 -07:00
e46502cfed
Add automatic selection message even when there is only one choice
2019-10-25 10:53:20 -07:00
416f132ebb
Pass --expected-default-driver to the test rather than minikube
...
Improve VBoxManage detection on Windows
Add missing install_test
2019-10-25 10:43:30 -07:00
a7a692d717
Hide viper ConfigFileNotFoundError
2019-10-25 10:37:33 -07:00
ddabc9ef47
remove extra error word
2019-10-24 14:20:07 -07:00
187dfe29f8
getting rid of some of bin bash -c
2019-10-24 14:13:51 -07:00
b0045275a9
Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2
2019-10-24 10:55:40 -07:00
8920a884c3
Minor improvements to the clarity of hypervisor errors
2019-10-24 07:45:40 -07:00
c925f65629
Warn about driver status, add more logging
2019-10-23 22:33:05 -07:00
bdd0f3831f
Merge branch 'drv-select2' of github.com:tstromberg/minikube into drv-select2
2019-10-23 22:15:27 -07:00
dcdac36e98
Add integration tests
2019-10-23 21:45:23 -07:00
5d4bf0848f
Merge branch 'master' into drv-select2
2019-10-23 14:09:03 -07:00
98b3aefcac
Merge pull request #5520 from theVDude/config-cleaup
...
Remove duplicate setting field in config
2019-10-23 11:44:53 -07:00
443ae74719
Make unit tests pass again
2019-10-23 09:34:32 -07:00
1fc11f56f1
Add logic for picking the default driver on a host
2019-10-22 20:38:30 -07:00
fbc1630fc5
Merge pull request #5611 from woodcockjosh/json-output-for-status
...
Add json output for status
2019-10-21 18:37:34 -07:00
64edf25cd5
Merge pull request #5658 from tstromberg/drv-reorg
...
Consolidate driver handling code in pkg/minikube/driver
2019-10-21 14:12:20 -07:00
6faf9cdbe7
lint and code review
2019-10-21 13:01:06 -07:00
342397ab46
convert more to exec.Command
2019-10-21 11:40:10 -07:00
026120ab71
Merge pull request #5655 from tstromberg/simpler-kubectl-check
...
Improve kubectl skew check logic
2019-10-21 11:38:29 -07:00
6bd5d9b157
Merge remote-tracking branch 'upstream/master' into NewCmdRunner
2019-10-21 11:17:28 -07:00
7581cf3e0c
Address merge conflicts
2019-10-21 11:12:06 -07:00
ca7d378aaa
Change default status output to not include the ip. Simplify json output
2019-10-21 12:50:00 -05:00
6aaed92496
Add json output for status
2019-10-21 12:50:00 -05:00
cd9a6526d3
Merge pull request #5548 from blueelvis/5358-purge-flag-for-delete
...
Added flags to purge configuration with minikube delete
2019-10-21 10:26:36 -07:00
723e77ed62
Merge pull request #5601 from woodcockjosh/json-output-for-addons-list
...
Add JSON output for addons list
2019-10-21 10:25:24 -07:00
c8833827c1
Merge pull request #5624 from nanikjava/f-fix-4883
...
Add validation checking for minikube profile
2019-10-21 10:17:26 -07:00
523db2099c
Merge pull request #5640 from sharifelgamal/auto-download-off
...
add ability to override autoupdating drivers
2019-10-21 10:16:49 -07:00
fd5e1d30a1
Merge branch 'master' into simpler-kubectl-check
2019-10-21 10:09:36 -07:00
35f7c9f38a
Merge branch 'master' into drv-reorg
2019-10-21 09:50:08 -07:00
9f38ddff39
Merge pull request #5656 from tstromberg/driver-tests
...
Rewrite cmd/delete_test to run without side effects
2019-10-21 09:49:41 -07:00
667b8b9b5d
Merge pull request #5659 from priyawadhwa/skeleton
...
[performance] add Makefile rule and code skeleton for mkcmp
2019-10-21 09:45:49 -07:00
967ce4867d
Merge pull request #5663 from afbjorklund/lint-again
...
Pick some lint from the recent master commits
2019-10-21 09:44:14 -07:00
d411617f9c
Use opposite operator
2019-10-20 19:11:26 +05:30
b3ccd9ae46
Refactored Delete and fixed linting issues
2019-10-20 13:13:35 +05:30
88fd869a81
Merge branch 'master' into 5358-purge-flag-for-delete
...
# Conflicts:
# cmd/minikube/cmd/delete.go
# pkg/minikube/cluster/cluster.go
2019-10-20 12:14:44 +05:30
2ba9cb4c1a
refactoring for delete
2019-10-20 02:19:18 +05:30
96c39bf050
Pick some lint from the recent master commits
2019-10-19 09:37:20 +02:00
f2900c613e
fix linting error
2019-10-18 17:07:56 -07:00
91b744095d
Fix boilerplate
2019-10-18 17:06:06 -07:00
484a66e082
Add skeleton for mkcmp
...
This PR adds a skeleton for mkcmp, a binary to compare the performance
of two versions of minikube. It adds a Makefile rule out/mkcmp which
builds the binary.
2019-10-18 16:55:58 -07:00
56a23cab4a
Merge pull request #5654 from tstromberg/delete-anyways
...
Ensure that delete succeeds even if cluster is unavailable
2019-10-18 16:06:12 -07:00
13cba07ec8
Fix broken cluster_test
2019-10-18 15:48:26 -07:00
cedab9e0fb
Revert delete_test.go changes, moving to another PR
2019-10-18 15:22:01 -07:00
b9bd1ba8d6
Rewrite delete_test to run without side effects
2019-10-18 15:17:51 -07:00
7cb0cfdf79
Pass lint checks
2019-10-18 13:53:57 -07:00
15daa48ed7
Merge branch 'master' into drv-reorg
2019-10-18 13:01:10 -07:00
6d7d589a52
Consolidate driver-interaction code into pkg/minikube/driver
2019-10-18 13:00:07 -07:00
9db86d91fa
Merge pull request #5592 from tstromberg/sshcheck
...
Add networking validation to validateNetwork
2019-10-18 07:24:09 -07:00
489713b6a8
run goimports
2019-10-17 16:56:38 -07:00
b0109c094d
comparing uints are complicated
2019-10-17 16:56:03 -07:00
235f94c7da
Improve kubectl skew check logic
2019-10-17 16:29:15 -07:00
2180c1405b
Ensure that delete succeeds even if cluster is unavailable
2019-10-17 16:23:21 -07:00
dc94405a34
Merge branch 'master' of github.com:kubernetes/minikube into auto-download-off
2019-10-17 15:32:09 -07:00
a84b3a9c95
Merge pull request #5596 from nanikjava/f-fix-3329
...
Warn if incompatible kubectl version is in use
2019-10-17 15:23:13 -07:00
dd266c751f
Merge pull request #5554 from woodcockjosh/json-output-for-profile-lists
...
Add json output for profile list
2019-10-17 15:21:24 -07:00
ccc2042861
Merge branch 'master' into remove-heapster
2019-10-17 15:14:49 -07:00
b132b04809
Add json output for addons list
2019-10-17 16:47:43 -05:00
6d63e43caf
Merge pull request #5555 from woodcockjosh/fix-addons-output-format-option
...
Fix addons list output format option
2019-10-17 14:46:02 -07:00
824c911c42
Add validation checking for minikube profile
...
Fixes : #4883
New function ProfileNameInReservedKeywords(..) has been added inside
pkg/minikube/config/profile.go
The new function perform validation to make sure the profile name is not
in the list of keywords.
Following are the keywords that are used:
start, stop, status, delete, config, open, profile, addons, cache, logs
The checking is case insensitive to cover combo of upper and lower case
2019-10-18 08:40:18 +11:00
f74ac2095c
Merge pull request #5565 from RickyRajinder/enable-addons-when-minikube-not-running
...
Allow addon enabling and disabling when minikube is not running
2019-10-17 14:38:36 -07:00
acec7e5971
Merge pull request #5626 from govargo/fix-update-context
...
fix "minikube update-context" command fail
2019-10-17 14:29:07 -07:00
d758672c8b
Remove function exports for profile list output types
2019-10-17 16:15:15 -05:00
4b2f962f0c
Add json output for profile list
2019-10-17 16:15:15 -05:00
789cc7a55a
Restructure code based on PR comments.
...
* When nil is returned from function just return back
* Restructure the output so that it will make more sense
for the user
2019-10-18 08:07:09 +11:00
a6d7989bfc
add ability to override autoupdating drivers
2019-10-16 14:51:13 -07:00
8ca74ef186
Use the value of --image-repository for connectivity check
2019-10-16 13:38:47 -07:00
22f2fa7730
Merge branch 'master' into sshcheck
2019-10-16 13:25:45 -07:00
d2557e688c
fix kubeconfig.UpdateIP() argument order
2019-10-15 22:41:59 +09:00
749c34ae6c
adding a logging to make sure jenkins is running right thing
2019-10-12 10:30:54 -07:00
d13f58fc3b
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-11 23:04:23 +02:00
f39ecda4cb
Add tests for addons custom output format
2019-10-11 09:43:00 -05:00
9bf904141c
Warn if incompatible kubectl version is in use
...
Fixes : #3329
Modification is done inside start.go where additional checking on the
version returned via the kubectl CLI is checked.
Running 'kubectl version --output=json' will return both client
and server information.
2019-10-11 23:46:02 +11:00
96edacc0a9
Changed command runner
...
Fixed test
Print error message
Change minikube running check to after check if exists
Updates Set and adds test for disabling
Fix action for minikube not running
Fix import order
2019-10-11 00:09:28 -07:00
6c5e432b14
Merge pull request #4999 from bhanu011/master
...
Warn when a user tries to set a profile name that is unlikely to be valid
2019-10-10 12:46:22 -07:00
ae731d4393
Merge branch 'master' into DELETE_ALL_PROFILES
2019-10-10 21:22:45 +02:00
268ac04f00
Don't try curl with localhost proxies
2019-10-10 12:17:56 -07:00
76471ffda5
Improve error messages, add container registry check
2019-10-10 12:14:27 -07:00
5e71eba5f7
Remove unused enableUpdateNotification variable
2019-10-10 11:30:08 -07:00
79efa5452d
More comprehensive network checks
2019-10-10 11:26:09 -07:00
tstromberg
Priya Wadhwa
Nanik T
Medya Gh
Medya Ghazizadeh
Anders F Björklund
Josh Woodcock
cueo
Pranav Jituri
Sharif Elgamal
Kenta Iso
Marek Schwarz
RickyRajinder