kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
5,568 Commits
22 Branches
152 Tags
433 MiB
Commit Graph

905 Commits (4b484bdbff1f37e3a535529afeffc6df2b43f59e)

Author SHA1 Message Date
fang duan 389cb018da
Merge branch 'master' into feature/registry_mirror_env 2019-07-27 20:01:14 +08:00
Jose Donizetti fe00076341
Revert "Fix flag.Parse error logging" 2019-07-25 23:03:04 -03:00
Medya Ghazizadeh 288024fd53
Merge pull request #4867 from josedonizetti/fix-flag-parse-error-logging 
Fix flag.Parse error logging
 2019-07-25 14:41:58 -07:00
Jose Donizetti 4ea0250a43 Validate driver is supported on current OS (#4720) 
* Validate None driver is supported on current OS

* Add Virtualbox tests to validateOSSupportVMDriver

* Add Hyperv driver OS validation

* Add Hyperkit driver OS validation

* Add Kvm2 driver OS validation

* Refactor driver validation to use IsValidDriver
 2019-07-25 11:14:57 -07:00
josedonizetti d7f755d67a Fix flag.Parse error logging 2019-07-25 10:31:30 -03:00
fang duan 3261b7d019
Merge branch 'master' into feature/registry_mirror_env 2019-07-23 15:43:30 +08:00
RA489 81144395ba [FEATURE] allow to set container-runtime via config 2019-07-23 08:29:27 +05:30
RA489 043c45ddf4 [FEATURE] allow to set container-runtime via config 2019-07-23 07:30:31 +05:30
Jose Donizetti 6a5fbbac34 Warn if hyperkit version is old (#4691) 
* Add warn if hyperkit driver version is old

* Add hyperkit upgrade documentation

* Improve kvm/hyperkit upgrade warn message

* Move validateDriverVersion to before downloading ISO

* Change executable to use constants
 2019-07-22 15:35:42 -07:00
Jituri, Pranav d3974b53fc Fixed the linting error 2019-07-23 01:47:30 +05:30
Jituri, Pranav f97451e0f2 Added command to generate the documentation 2019-07-23 01:31:41 +05:30
fang duan 05ee40fc28
Minikube start respects MINIKUBE_ prefixed env now 2019-07-22 11:26:38 +08:00
Jituri, Pranav c96a3bf1db Add conditional to poweroff on Hyper-V using SSH 2019-07-20 23:05:45 +05:30
Sharif Elgamal 6552436311
Console output cleanup (#4825) 
* Console output cleanup

* comment fix

* Fixing out.Out stutter

* Fix invalid template

* Change profile_list.go to new console functions

* more merge stuff
 2019-07-19 17:00:51 -07:00
Thomas Strömberg 784717c007
Merge pull request #4813 from tstromberg/cluster_test 
Make cluster_test and utils_test run in isolation
 2019-07-19 16:48:26 -07:00
Medya Gh 5d5c193743 Fix profile list error handling 2019-07-19 16:24:23 -07:00
Medya Gh 605a549de4 Improve usage message when there is no profile found 2019-07-19 16:15:11 -07:00
Medya Gh 7ef6b80a16 Add usage message when no profile found and avoid showing empty table 2019-07-19 16:10:03 -07:00
Medya Ghazizadeh 9f42df6209
Merge pull request #4811 from medyagh/add_profile_list_cmd 
Add a new command (profile list)
 2019-07-19 15:43:50 -07:00
Medya Gh 51a19625bc Lint and add optional arg to other loaders 2019-07-19 10:45:56 -07:00
Medya Gh b17376cccf Refactor profile, detect invalid profiles 2019-07-18 18:23:26 -07:00
tstromberg a3d32758f8 Add mock.Logf functions to avoid panics 2019-07-18 18:12:48 -07:00
Medya Gh 0d16ab38b9 boilerplate format 2019-07-18 14:50:37 -07:00
Medya Gh a0e515a770 Added cobra command for profile list 2019-07-18 14:29:47 -07:00
Medya Gh 8730c02c93 Use Out instead OutT for ip 2019-07-18 13:01:05 -07:00
Medya Gh 453b8630f4 merge upstream 2019-07-18 11:50:55 -07:00
Thomas Strömberg b992c4542a
Merge pull request #4744 from tstromberg/faster-kubelet 
Allow users to skip pod health checks with --wait=false
 2019-07-18 11:00:21 -07:00
Medya Gh ed11f3ab0c merge upstream 2019-07-18 10:39:28 -07:00
Medya Ghazizadeh 5178c0b300
Merge branch 'master' into translation_outstyle 2019-07-17 18:12:45 -07:00
Sharif Elgamal 93263bc2bc
Templatizing more calls to console 2019-07-17 18:06:06 -07:00
Sharif Elgamal b4feb7e842
Merge branch 'master' of github.com:kubernetes/minikube into TEMPLATES 2019-07-17 17:46:08 -07:00
Medya Gh 97ba8854a6 more translation formatting 2019-07-17 17:37:39 -07:00
Thomas Stromberg 054fc946f1 Pass most tests 2019-07-17 17:13:12 -07:00
Thomas Stromberg cbd7d702ef Merge remote-tracking branch 'upstream/master' 2019-07-17 16:55:06 -07:00
Thomas Stromberg 3d7c657eaf Templated output migration 2019-07-17 16:54:56 -07:00
Medya Gh 4e4eccad30 Added more translation formatting 2019-07-17 16:54:29 -07:00
Medya Gh f57f6d724c linting 2019-07-17 16:28:49 -07:00
Sharif Elgamal 67f0e8e3f4 initial commit 2019-07-17 15:42:08 -07:00
Medya Gh f1d55de97c Added translation fomratting for disable,profile,start 2019-07-17 15:34:14 -07:00
Sharif Elgamal b40011b2e3
Add T versions of the console convenience functions (#4796) 
* Add T versions of the console convenience functions

* more changes

* Make OutT and ErrT more convenient and add WithCodeT:

* add UsageT

* make extract

* translate messages in displayError
 2019-07-17 15:19:49 -07:00
tstromberg 0b7bdad891 Merge conflicts 2019-07-17 09:22:05 -07:00
tstromberg 1b83a89df3 Settle merge conflicts 2019-07-17 09:00:54 -07:00
tstromberg 7a81b7cf68 Remove hardcoded driver list from help docs 2019-07-17 08:58:59 -07:00
Medya Ghazizadeh d15eb12900
Merge pull request #4737 from medyagh/simplify_start 
refactoring and simplifying start command
 2019-07-16 15:34:22 -07:00
tstromberg d0ae6e9d3b Obsolete driver lint issues 2019-07-16 15:16:51 -07:00
tstromberg 9896386d03 Fix docker-machine-driver-kvm2 build 2019-07-16 14:42:56 -07:00
tstromberg 914713f388 Remove deprrecated drivers: kvm-old and xhyve 2019-07-16 13:40:00 -07:00
Medya Gh 78789d8d80 spelling 2019-07-16 09:33:35 -07:00
Sharif Elgamal 941c7d5fb2
moving checks to their relevant stops so unit tests work 2019-07-15 13:38:12 -07:00
serhatcetinkaya deead301f2 start: compare specified kubernetes version with oldest supported version 2019-07-14 19:29:08 +03:00
Thomas Strömberg b50aa37407
Revert "Refactor status command" 2019-07-12 14:23:38 -07:00
tstromberg 44c8dd52a8 Add --wait flag to allow users to skip pod health checks 2019-07-12 14:18:43 -07:00
Medya Gh 3dce194cd9 Move options for better groupiong 2019-07-11 17:26:36 -07:00
Medya Gh 089bacc58f group init flags 2019-07-11 17:16:22 -07:00
Medya Gh 944d33e4e4 Fix config pointer 2019-07-11 16:41:07 -07:00
Medya Gh 641c9c4bbd remove extra logging 2019-07-11 13:09:40 -07:00
Kubernetes Prow Robot 65c6f9e5a3
Merge pull request #4686 from josedonizetti/refactor-status-cmd 
Refactor status command
 2019-07-11 11:54:10 -07:00
Thomas Strömberg 82d4c7dd2c
Merge pull request #4688 from kairen/better-comment 
Add space after // comments
 2019-07-11 11:53:15 -07:00
Thomas Strömberg b0b13e1a7c
Merge pull request #4545 from marcosdiez/dont_disable_container_engines_when_vmdriver_is_none 
Don't disable other container engines when --vm_driver=none
 2019-07-11 11:17:57 -07:00
Medya Gh 3e9077dd2a added comment 2019-07-10 23:42:23 -07:00
Medya Gh ff969e693b Simplifying start cmd 2019-07-10 23:14:15 -07:00
Sharif Elgamal c92e65ec28
Add templating for proper localization (#4677) 
* Add templating for proper localization

* Fixing tests for new translation style

* checking errors is important

* fixing more console tests

* good function names make for happy developers

* add test for OutTemplateStyle

* short function names make for happy developers

* better formatting

* more better variable names
 2019-07-10 10:17:28 -07:00
josedonizetti 120ce27845 Refacator status command 2019-07-09 15:58:01 -03:00
Medya Ghazizadeh 8e0596d2b1
Merge pull request #4692 from josedonizetti/add-kubectl-flag-examples 
Add kubectl help examples
 2019-07-09 11:02:48 -07:00
josedonizetti cf468bfe63 Add kubectl examples 2019-07-09 05:11:33 -03:00
Medya Ghazizadeh c8b0b41a6b
Merge pull request #4675 from superbrothers/fix-minikube-service 
Fix `minikube service` to show error message if service has no node ports
 2019-07-08 21:22:58 -07:00
Anders F Björklund dfbf8013ec Reduce complexity of the delete command 2019-07-06 10:14:58 +02:00
Kazuki Suda 6f96fbaa93 Print information of a service as a table 2019-07-05 15:32:19 +09:00
Medya Ghazizadeh 4e5f173a9c
Merge pull request #4687 from medyagh/move_command_runner 
moving command runner to its own package
 2019-07-04 23:30:21 -07:00
Medya Ghazizadeh cc9960200f
Merge pull request #4676 from josedonizetti/warn-if-kvm2-version-is-old 
Add warn if kvm driver version is old
 2019-07-04 22:22:13 -07:00
Kyle Bai c5f695e8a0 Better comment syntax 2019-07-05 11:17:10 +08:00
Medya Gh 99ac1a81e7 moving command runner to its own package 2019-07-04 16:31:07 -07:00
josedonizetti 9210b96ee8 Add upgrade documentation to kvm version warn 2019-07-04 17:25:56 -03:00
josedonizetti 5f84ae3cd2 Add extractVMDriverVersion documentation 2019-07-04 17:25:56 -03:00
josedonizetti d7a30e118f Fix start_test.go copyright 2019-07-04 17:25:56 -03:00
josedonizetti f61d62647a Add comment about kvm2 force upgrade 2019-07-04 17:25:56 -03:00
josedonizetti dabf272f33 Add warn if kvm driver version is old 2019-07-04 17:25:56 -03:00
Kyle Bai 6505dfad62 Delete kubeconfig when a machine has been deleted 2019-07-04 14:47:41 +08:00
Medya Ghazizadeh 68c546ff1d
Merge pull request #4645 from josedonizetti/fix-profile-flag-indentation 
Fix profile flag documentation indentation
 2019-07-02 19:06:13 -07:00
Medya Gh d269afef16 better format message 2019-07-01 18:27:00 -07:00
Medya Gh c8876b4675 Exit if none is run without sudo 2019-07-01 18:24:17 -07:00
josedonizetti 18d8ecf519 Simplify `-p` documentation 2019-07-01 18:46:38 -03:00
Medya Ghazizadeh 124b845b60
Merge pull request #4644 from josedonizetti/prefix-kvm-only-flags 
Add kvm prefix to flags only used by kvm
 2019-07-01 14:43:05 -07:00
Medya Ghazizadeh 2aac268ba6
Merge pull request #4593 from josedonizetti/add-hyperkit-version 
Add version to hyperkit driver
 2019-07-01 14:38:30 -07:00
Medya Ghazizadeh 449c8781e1
Merge pull request #4595 from blueelvis/memory-size-sanity-check 
Added validation for start memory size
 2019-06-30 15:17:28 -07:00
josedonizetti a7feb232a1 Fix profile flag documentation indentation 2019-06-29 12:38:32 -03:00
josedonizetti fe3620020a Add kvm prefix to flags only used by kvm 2019-06-29 12:25:36 -03:00
Jose Donizetti 4812761f05 Add gitCommitID to hyperkit version 2019-06-29 09:32:21 -03:00
josedonizetti 931a0a557b Add hyperkit version 2019-06-29 09:22:51 -03:00
Christophe VILA 8cd38956f2 Make virtualbox DNS settings configurable 2019-06-28 16:38:16 -07:00
Jose Donizetti 9dfe660c64 Add support to custom qemu uri on kvm2 driver 2019-06-28 14:12:58 -07:00
Jose Donizetti 8acf4824df Add commit id to docker-machine-driver-kvm2 version 2019-06-28 13:45:54 -07:00
Jituri, Pranav 0305c9d0fa Fixed repeating of messages 2019-06-28 15:30:46 +05:30
Medya Ghazizadeh 886d159a5b
Proxy: handle lower case proxy env vars 2019-06-26 10:33:50 -07:00
Himanshu Pandey 904bc49f71 Added validation for --registry-mirror flag 2019-06-26 10:19:03 -07:00
Francis 6bc977ad04 better service retry logic 2019-06-25 17:28:10 -07:00
Pranav Jituri 6ba1725c08 Added Memory Size Checking 2019-06-26 00:22:41 +05:30
Sharif Elgamal 37239ba83d
Merge pull request #4581 from sharifelgamal/translation-bindata 
Add translation files into the minikube binary
 2019-06-25 10:19:34 -07:00
Deepjyoti Mondal 8be917f0a5 Display commit id for minikube version 2019-06-25 10:12:55 -07:00
Marcos Diez d58e727512 Merge remote-tracking branch 'origin/master' into dont_disable_container_engines_when_vmdriver_is_none 2019-06-25 13:37:30 -03:00
Medya Gh e35f96d9e0 check error before defer close 2019-06-24 21:09:23 -07:00
Medya Gh 129e2fdb18 Improve readability, defer close api 2019-06-24 20:48:52 -07:00
Sharif Elgamal cab5d30900
outDir is clearer I suppose 2019-06-24 16:19:32 -07:00
Medya Gh 34fda98f4e Improve typecheck for driver options 2019-06-24 15:23:57 -07:00
Sharif Elgamal 8a4776b250
Fixing top level extract call for new translations directory location 2019-06-24 15:18:31 -07:00
Medya Gh c7bf1ce7cd type check for drivers 2019-06-24 14:39:21 -07:00
Medya Ghazizadeh e0c20a4202
Merge pull request #4558 from afbjorklund/reportcard-new 
Fix the reportcard: gofmt, golint and gocyclo
 2019-06-24 11:44:42 -07:00
Francis 467d8c975f Clean up profile folder after minikube delete 2019-06-24 09:48:25 -07:00
Marcos Diez 820f7984da go fmt 2019-06-24 11:54:20 -03:00
Marcos Diez f802c19eeb making code more readable 2019-06-24 09:31:35 -03:00
Marcos Diez ba20534107 we don't disable other container engines when vmdriver==none 2019-06-24 09:31:35 -03:00
Thomas Strömberg e851619553
Merge pull request #4568 from kubernetes/allow-naked-version 
Allow --kubernetes-version to be specified without the leading v
 2019-06-24 13:03:34 +08:00
Thomas Strömberg ce74af2d08
Merge pull request #4455 from djmgit/sudo_message 
Provide warning message for unnecessary sudo
 2019-06-24 12:58:41 +08:00
Thomas Stromberg a9ec145bcb Allow --kubernetes-version to be specified without the leading v 2019-06-24 10:29:09 +08:00
Thomas Stromberg 31354884a5 run goimports 2019-06-23 21:11:42 +08:00
Thomas Stromberg 742dee9e4c Turn console output message into less noisy info message 2019-06-23 21:03:42 +08:00
Thomas Stromberg abff28db7e Universally redirect stdlog messages to glog 2019-06-23 20:58:11 +08:00
Anders F Björklund f20f223c02 Decrease cyclomatic complexity 
Here is the report (from gocyclo), before:

21 tests (*SSHServer).Start pkg/minikube/tests/ssh_mock.go:76:1
19 cmd runStart cmd/minikube/cmd/start.go:173:1
18 integration testTunnel test/integration/tunnel_test.go:40:1
17 extract checkCallExpression pkg/minikube/extract/extract.go:198:1
17 kubeadm TestGenerateConfig pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go:133:1
16 kvm (*Driver).deleteNetwork pkg/drivers/kvm/network.go:153:1
 2019-06-22 17:21:42 +02:00
Sharif Elgamal 3be580c97c add comment for top level command and add chinese transkations 2019-06-20 09:55:29 -07:00
Deepjyoti Mondal 2cee972804 Provide warning message for unnecessary sudo 
If minikube is started with root privilege and vm-driver is
not hyperV or none, then a warning message is displayed.
 2019-06-20 07:43:16 +05:30
Sharif Elgamal e8329f6380
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc 2019-06-19 17:59:17 -07:00
Sharif Elgamal 97e2cd1153
Simplifying and correcting the extract code. Test passes now. 2019-06-19 17:44:34 -07:00
Thomas Strömberg 4610663674
Merge pull request #4398 from josedonizetti/add-kvm-version-flag 
Add kvm2 --version
 2019-06-20 07:41:18 +08:00
Anders Björklund 2a6b2ad543 Disable unnecessary load image from cache for none driver 
since we are not are not saving the images in the cache, there is not much trying to load from the cache either.
 2019-06-19 08:35:05 -07:00
Sharif Elgamal 6cd86b7ca7
don't make extract an end-user command 2019-06-17 11:43:05 -07:00
Medya Gh c10878a8f0 better error handling 2019-06-15 23:51:56 -07:00
Medya Gh a01e6dd569 notify user of skipping 2019-06-15 23:10:06 -07:00
Medya Gh 4fd29be51c lint and comment 2019-06-15 22:55:57 -07:00
Medya Gh 5176806eb2 set context on profile 2019-06-15 22:18:23 -07:00
Francis 31ab527da5 Improve enable/disable add-on 
Closes https://github.com/kubernetes/minikube/issues/4417
 2019-06-14 10:47:11 -07:00
Sharif Elgamal dae9425aa0 small changes 2019-06-14 10:17:05 -07:00
Medya Ghazizadeh 6ecc1055b3
Automatically add extra options for none driver on ubuntu 
Automatically add extra options for none driver on ubuntu
 2019-06-13 15:13:55 -07:00
Sharif Elgamal b573cb8a21
adding extract cmd file 2019-06-13 11:18:23 -07:00
Sharif Elgamal f452f0cded
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc 2019-06-10 12:00:39 -07:00
Sharif Elgamal 610e4f1159
More extractor work 2019-06-06 14:10:32 -07:00
Pradip-Khakurel bb78d3eb31 fix ShowDriverDeprecationNotification config setting 2019-06-05 23:30:13 +02:00
josedonizetti a024c6d22a Add kvm2 --version 2019-06-04 16:45:14 -03:00
Medya Gh 6d57b28fdd changing string driver name to checked type 2019-06-03 20:27:26 -07:00
fenglixa bbc679be0e modify to exit.Unavailable and align the code 2019-06-02 13:26:42 +08:00
fenglixa d40751ff38 Fix nonexistent profile 2019-05-31 21:36:49 +08:00
Sharif Elgamal 483f9fb19e
Merge branch 'master' of github.com:kubernetes/minikube into localization-poc 2019-05-30 15:26:20 -07:00
Sharif Elgamal 6d507fbcd1
Fixing variable style 2019-05-29 19:19:33 -07:00
Sharif Elgamal 34ccd2ad41
Change console style string to enum 2019-05-29 18:45:55 -07:00
Thomas Strömberg db37c03063
Merge pull request #4364 from tstromberg/no-docker-version 
docker-env: Remove DOCKER_API_VERSION
 2019-05-29 10:27:43 -07:00
Thomas Stromberg a3f557d870 Remove dangling references to DockerAPIVersion 2019-05-28 17:21:26 -07:00
Thomas Stromberg 2a590682bf Remove DOCKER_API_VERSION 2019-05-28 17:16:21 -07:00
Anders F Björklund e809cbd977 Pass minikube stdin to the kubectl command 
This is needed for doing e.g. "apply -f -"
 2019-05-25 09:57:03 +02:00
Mike Lewis 7dac217a41 Remove whitespace on empty lines 2019-05-23 17:54:52 -04:00
Mike Lewis 79c52bf1f0 Address style comment 2019-05-23 17:34:00 -04:00
Mike Lewis 955932b606 Get current profile if no arguments given 2019-05-23 17:04:59 -04:00