Commit Graph

298 Commits (48feb9ba4e27cd7824910901ea3f740a37193343)

Author SHA1 Message Date
Medya Gh db00506d67 dont allow enabling ingress addon for docker on mac and windows 2020-04-02 17:00:06 -07:00
Zhongcheng Lao 9adb1bc399
Merge remote-tracking branch 'origin/master' into metallb 2020-03-29 11:31:56 +08:00
Zhongcheng Lao d9fe5afa86
Adds MetalLB addon 2020-03-29 11:20:59 +08:00
Thomas Stromberg ea9aa72984 Retry addon application 2020-03-25 13:44:28 -07:00
Thomas Strömberg 8d1f4552c0
Merge pull request #6657 from kameshsampath/registry-aliases
New addon: registry-aliases
2020-03-19 11:31:00 -07:00
Thomas Stromberg 196a8d7b82 Delete: output underlying status failure, refactor wordy code 2020-03-13 15:51:03 -07:00
Thomas Stromberg c911b9f433 UsingContainerd -> IsRuntimeContainerd 2020-03-10 19:27:49 -07:00
Thomas Stromberg 176c6551a8 IsContainerdRuntime -> IsRuntimeContainerd 2020-03-10 19:08:27 -07:00
Thomas Stromberg bd627f13e4 Plumb config.ClusterConfig throughout addon validation code 2020-03-10 17:49:47 -07:00
Sharif Elgamal 424b5170f7
Allow backwards compatibility with 1.6 and earlier configs 2020-03-09 12:01:07 -07:00
Kamesh Sampath 70ca2de554 (fix) Create addon to configure registry helper
- Service Account and binding to run the job
- Registry aliases ConfigMap
- Registry aliases daemonset to update the node etc/hosts

fixes: 4604

Signed-off-by: Kamesh Sampath <ksampath@redhat.com>
2020-03-08 09:31:07 +05:30
Sharif Elgamal 3bb111a6fc
make sure machine name is properly backwards compatible 2020-03-03 13:49:01 -08:00
Sharif Elgamal 28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-03 12:16:47 -08:00
Sharif Elgamal 31a42ce672
address comments 2020-03-02 17:30:08 -08:00
Sharif Elgamal 4b902f7e9f
more changes 2020-02-28 15:58:05 -08:00
Song Shukun 884c30a5f6 Fix: disable a disabled addon cause error 2020-02-27 19:21:08 +09:00
Sharif Elgamal 6e9cf2de2f Change MachineConfig to ClusterConfig 2020-02-21 16:09:05 -08:00
Sharif Elgamal 2785d292f5 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-13 10:15:04 -08:00
Sharif Elgamal 8c55c9ca60 holy crap cyclical import hell sucks 2020-02-12 18:34:44 -08:00
Medya Ghazizadeh 398c7ef00b
Add podman driver (#6515) 2020-02-12 19:11:44 -07:00
Thomas Strömberg 950fc79544
Merge pull request #6512 from tstromberg/gvisor-fixes
gvisor fixes for v1.7.0
2020-02-05 15:37:05 -08:00
tstromberg 77f74d82d7 Remove unused files var 2020-02-05 14:53:02 -08:00
tstromberg d66bcad56c Only run kubectl apply on YAML files 2020-02-05 14:41:05 -08:00
Vijay Katam cf8e247ae3 Use cluster-dns IP setup by kubeadm
Removed hardcoded `cluster-dns` IP 10.96.0.10, this allows kubelet to use `clusterDNS` configured by kubeadm in `/var/lib/kubelet/config.yaml`

Tested by starting minikube with `--service-cluster-ip-range=100.64.0.0/13` and verifying DNS resolution works.

/etc/systemd/system/kubelet.service.d/10-kubeadm.conf
```
[Unit]
Wants=docker.socket

[Service]
ExecStart=
ExecStart=/var/lib/minikube/binaries/v1.17.0/kubelet --authorization-mode=Webhook --bootstrap-kubeconfig=/etc/kubernetes/bootstrap-kubelet.conf --cgroup-driver='cgroupfs' --client-ca-file=/v
ar/lib/minikube/certs/ca.crt --cluster-domain=cluster.local --config=/var/lib/kubelet/config.yaml --container-runtime=docker --fail-swap-on=false --hostname-override=minikube --kubeconfig=/e
tc/kubernetes/kubelet.conf --node-ip=192.168.64.7 --pod-manifest-path=/etc/kubernetes/manifests

[Install]
```

DNS resolution test
```
kubectl run -i --tty --rm busybox --image=busybox --restart=Never -- sh
If you don't see a command prompt, try pressing enter.
/ # nslookup kubernetes.io
Server:		100.64.0.10
Address:	100.64.0.10:53

Non-authoritative answer:
Name:	kubernetes.io
Address: 147.75.40.148
```

Fixes: https://github.com/kubernetes/minikube/issues/5727

fix lint errors
2020-02-05 10:28:16 -08:00
tstromberg 2eddd08ae9 Fix test signature 2020-02-03 12:57:52 -08:00
tstromberg bcc186b908 Startup previously enabled addons 2020-02-03 10:49:40 -08:00
Thomas Stromberg c3aafaeeb4 Add IsNotExist() method to the config package, so that we can have meaningful error messages and make them comparable 2020-01-31 14:19:08 -08:00
Thomas Stromberg a7ac0339fd Address eview feedback 2020-01-31 13:24:30 -08:00
Thomas Stromberg 78ed12265d Add testing for Start function, make addon enablement testable 2020-01-31 12:19:25 -08:00
tstromberg b97124207c Move addon enablement to addons module + lint fixes 2020-01-30 17:46:25 -08:00
tstromberg d5a83c7b24 Add addon enablement to start 2020-01-30 15:54:04 -08:00
Priya Wadhwa 8d8ea98378 check cmd.Remove error for linting 2020-01-22 15:11:33 -08:00
Priya Wadhwa 15a5209841 Update unit tests 2020-01-22 14:23:32 -08:00
Priya Wadhwa 7247a7dee6 Switched to using kubectl apply and kubectl delete for addons
kubectl apply with --prune wasn't working because it requires the
--namespace flag to be passed in and we have multiple namespaces for
addons.

We tried to split up addons within /etc/kubernetes/addons by
namespace, but this didn't work when disabling dashboard addon because
there were no files left in the kubernetes-dashboard subdirectory. So,
kubectl apply complained when trying to prune dashboard because no files
were being passed in.

So, I ended up removing all dependencies on prune and instead running
`kubectl apply` when enabling an addon and running `kubectl delete` when
disabling an addon.
2020-01-22 14:18:20 -08:00
Priya Wadhwa de4ecb9706 Rebased on master 2020-01-22 13:10:50 -08:00
Priya Wadhwa 180b23f2c8 Save addons in subdirectories, separated by namespace
This way we can pass the correct --namespace flag into 'kubectl apply'
such that it works with '--prune' for kubectl >=v.17.0
2020-01-22 13:09:37 -08:00
Priya Wadhwa 28148c5f3d Remove addon manager 2020-01-16 11:47:01 -08:00
Priya Wadhwa f5be457399 fix unit tests 2020-01-14 12:12:47 -08:00
Priya Wadhwa 9a2de2ae7f Hook up new addon manager logic to existing addons code 2020-01-14 10:52:27 -08:00
Anders F Björklund d265162fe2 Fix some minor issues from gofmt and golint 2020-01-13 21:38:59 +01:00
Priya Wadhwa 6ad7e4a9a0 address code review comments
add better error handling and remove duplication in enableOrDisableAddonsInternal
2020-01-06 13:42:09 -08:00
Priya Wadhwa e47cde6ae4 Rebased on master, moved istio addon into new package 2019-12-30 10:10:05 -05:00
Priya Wadhwa 4c7b94971c Address review comments
Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
2019-12-19 10:41:01 -08:00
Priya Wadhwa 43a7267079 make public methods that aren't used outside of the package private 2019-12-18 22:33:00 -08:00
Priya Wadhwa ceb4938c7a Add more unit tests 2019-12-18 22:27:32 -08:00
Priya Wadhwa 921fee7432 Moved unit tests to addons package and refactored them 2019-12-18 22:02:10 -08:00
Priya Wadhwa e72cb80cbf Enable/disable addons works per profile
However, this means that addon information won't persist beyond a 'minikube delete'
2019-12-18 21:35:46 -08:00
Priya Wadhwa ba8b723978 Move addon related logic to pkg/addons for better organization 2019-12-18 11:31:29 -08:00