Commit Graph

4212 Commits (3dfb0c3986764792de14a0b7b2ef8da23dd4a596)

Author SHA1 Message Date
Medya Gh 11674e830f spell 2020-07-10 13:13:45 -07:00
Medya Gh c240fa97bc add timeout for node label too 2020-07-10 13:06:43 -07:00
Medya Gh f805be635a add timeout for node label too 2020-07-10 13:04:11 -07:00
Medya Gh f36da5f044 add timeout for node label too 2020-07-10 13:03:50 -07:00
Medya Gh 770f7aeeb4 adjust itmeout 2020-07-10 13:02:06 -07:00
Medya Gh 7088653d33 max 13 min for kubeadm 2020-07-10 13:01:08 -07:00
Medya Gh 6c702e1d29 add timeout for kubeadm init 2020-07-10 12:49:29 -07:00
Medya Ghazizadeh 87e540305c
Merge pull request #8648 from jlucktay/update/profile-name-validation
disallow setting profile names with underscore
2020-07-10 10:43:32 -07:00
Priya Wadhwa 3d105ef98f Download and DownloadProgress implemented 2020-07-10 12:31:08 -04:00
Priya Wadhwa d29a9dca67 Add Download and DownloadProgress types implementations 2020-07-10 11:58:23 -04:00
Prasad Katti 7bc10bb308 Set cgroupDriver and clientCAFile (for 1.16+) via kubelet config 2020-07-09 15:21:26 -07:00
Prasad Katti c483714cbc Move kubelet params to config file 2020-07-09 15:21:25 -07:00
Prasad Katti 332c3bd14f Add unit tests for Exists in extra_options.go 2020-07-09 15:17:00 -07:00
Thomas Strömberg ca9040b42b
Merge pull request #8664 from tstromberg/none-timeout
none: Fix 'minikube delete' issues when the apiserver is down
2020-07-09 14:16:14 -07:00
Sharif Elgamal d0d3973a13 restrict apparmor security opt to docker 2020-07-09 12:58:01 -07:00
Thomas Stromberg 0b3e2ae79b none CNI: error if portmap plug-in is required but unavailable. Make testable 2020-07-08 14:30:48 -07:00
Thomas Stromberg f8068d06f7 Merge branch 'master' into none-timeout 2020-07-08 13:48:34 -07:00
Priya Wadhwa b9cd0caa7c only out.T should be used to convert steps to JSON 2020-07-08 16:30:48 -04:00
Priya Wadhwa 6d95edda7b remove empty test 2020-07-08 16:28:51 -04:00
priyawadhwa b6f0829d7d
Merge pull request #8505 from zhijianli88/cleanup-tempfiles
Cleanup tempfiles
2020-07-08 14:53:51 -04:00
priyawadhwa 7367c72a3e
Merge pull request #8490 from zhijianli88/cleanup
A few cleanup
2020-07-08 14:52:28 -04:00
Priya Wadhwa 3e6ef0b37a fix unit test 2020-07-08 11:10:47 -04:00
Priya Wadhwa 290f48f98e Add Infof function to out package 2020-07-08 11:00:32 -04:00
Medya Ghazizadeh 1bcb375f93
Merge pull request #8147 from nezorflame/fix-error-msg
add new --extra-config option "scheduler"
2020-07-07 15:55:08 -07:00
Medya Ghazizadeh d8106f7d06
Merge pull request #8454 from colvin/addon-podsecuritypolicies
Include a podsecuritypolicies addon
2020-07-07 15:52:03 -07:00
Thomas Stromberg 7df4075297 Don't propagate stopped as an error, so that 'delete' works on stopped none clusters 2020-07-07 15:23:26 -07:00
Thomas Stromberg 53ce804cff retry.Local should respect the maxTime argument 2020-07-07 15:10:30 -07:00
Thomas Stromberg f82d5c6bb2 Reduce apiserver health timeout from 8s to 5s 2020-07-07 15:10:05 -07:00
Priya Wadhwa 1980e066dd fix lint and generate-docs 2020-07-07 15:57:07 -04:00
Priya Wadhwa 6367f71867 Make sure each step is unique 2020-07-07 15:39:47 -04:00
Priya Wadhwa bd94872a10 add additional steps 2020-07-07 14:25:27 -04:00
Priya Wadhwa ddecfd77e7 Include Ln as a Step 2020-07-07 13:24:53 -04:00
Priya Wadhwa 1ac2f6ddc0 cleanup 2020-07-07 13:19:33 -04:00
Priya Wadhwa dd60fa85cc Remove emojis from json output 2020-07-06 15:28:51 -04:00
Priya Wadhwa f68716e2da Set up logic for steps 2020-07-06 15:12:13 -04:00
Priya Wadhwa 10ba39cd3c Add --output=json flag and hook it up to out package 2020-07-06 12:32:34 -04:00
Priya Wadhwa 515616d1aa Add register of steps for 'minikube start' 2020-07-06 12:24:10 -04:00
Priya Wadhwa b72b1239ba Add function to print data in cloud events format 2020-07-06 12:23:59 -04:00
James Lucktaylor 85a641177e
Resequence test cases for better readability. 2020-07-06 13:07:14 +01:00
James Lucktaylor 2cf72f7ca8
Update profile name validation pattern. #8493
- prevents some incompatible characters from making their way into
profile names and causing DNS/hostnames issues
2020-07-05 12:16:31 +01:00
James Lucktaylor 2660b92109
Update test coverage around ProfileNameValid func.
- preparing to update the ProfileNameValid func
- adding some more test cases to check against new profile name limits
2020-07-05 12:06:14 +01:00
Medya Ghazizadeh a4b647f19b
Merge pull request #8629 from medyagh/sol_msg_docker_ssh_port
add solution message when container create is stuck
2020-07-01 13:41:21 -07:00
Medya Ghazizadeh 084df67df1
Merge pull request #8628 from sharifelgamal/del-on-failure
ensure deleting failed hosts if --delete-on-failure is specified
2020-07-01 13:40:43 -07:00
Medya Gh fd2912340a improve wording 2020-07-01 13:33:51 -07:00
Medya Gh 881ed1df1c add link 2020-07-01 13:28:52 -07:00
Medya Gh 4a321a6b1e add solution message when docker container create is stuck 2020-07-01 13:26:56 -07:00
Sharif Elgamal 84eea2f487 recreate hosts on failed provisioning if delete-on-failure is specified 2020-07-01 12:57:59 -07:00
Medya Gh 7564651d50 make docker driver highly prefered 2020-07-01 10:09:18 -07:00
Anders F Björklund 4968ff5e75 Run gofmt on pkg/minikube/shell/shell.go 2020-06-30 19:19:44 +02:00
Anders F Björklund b0b3a1ac8c Change indentation from gofmt to goimports 2020-06-30 19:12:11 +02:00
Johannes M. Scheuermann 73fccf04f8 Update external-provisioner for storage provisioner 2020-06-30 18:31:06 +02:00
Medya Ghazizadeh 9e35037ed9
Merge pull request #8593 from sunny-b/gracefully-fail-misspelled-runtime
Gracefully exit if container runtime is misspelled
2020-06-29 22:07:57 -07:00
Medya Ghazizadeh 2b5254cf91
Merge pull request #8598 from afbjorklund/modprobe-br_netfilter
Don't verify nf_conntrack for br_netfilter
2020-06-29 21:13:13 -07:00
Sunny Beatteay 28238150f5 ensure that 'crio' is used for k8s config 2020-06-29 19:52:30 -04:00
Medya Gh 3bc3ce95de refactor maybeExitWithAdvice 2020-06-29 14:38:37 -07:00
Anders F Björklund a9273beec7 Don't verify nf_conntrack for br_netfilter
We need to make sure that the br_netfilter kernel module
has been loaded, when using non-Docker container runtimes.

But the code was verifying the nf_conntrack kernel module
instead, so it could still cause the "not loaded" error.

[ERROR FileContent--proc-sys-net-bridge-bridge-nf-call-iptables]
2020-06-29 22:30:13 +02:00
Medya Gh 08df5e2de3 add solution message if kbueadm is not executble on linux 2020-06-29 12:50:32 -07:00
Sunny Beatteay 9bcc587def update crio to cri-o in docs and help text 2020-06-29 14:11:20 -04:00
Sunny Beatteay 5da2fdd922 enable graceful exit if container runtime is misspelled 2020-06-28 18:57:03 -04:00
Ilya Danilkin e1f443e121
bsutil: add 'etcd' to the KubeadmExtraConfigOpts 2020-06-28 23:29:25 +03:00
Ilya Danilkin 83bb1e32d2
reoder extra-config consts 2020-06-28 22:51:29 +03:00
Ilya Danilkin b470860a5a
fix condition check for extraOpts validation 2020-06-28 22:35:40 +03:00
Ilya Danilkin ccffa40cfe
bsutil: extra-opts validation 2020-06-28 22:35:40 +03:00
Ilya Danilkin d1ab5312d5
bsutil: list valid keys as slice instead of a map 2020-06-28 22:33:36 +03:00
Ilya Danilkin 79eaa8778a
bsutil: fix error msg for `--extra-config` parsing 2020-06-28 22:33:36 +03:00
Anders F Björklund eaeb5f6060 Use preloaded tarball for cri-o container runtime
Pretty much the same as containerd, minus Restart

(cherry picked from commit d9fb2e05420c8f3526d1b1079ee129842ea5522c)
2020-06-28 16:46:54 +02:00
Anders F Björklund f23bbea995 Support more error messages for container inspect
The messages are different between "inspect" and "container inspect",
and also changed a bit in format between Podman v1 and Podman v2.

Support all of them, for compatibility with different versions of
Docker and Podman. Was causing restarts and failures, with KIC.
2020-06-28 14:19:09 +02:00
Anders F Björklund 51b4d2eb24 Normalize name of the container runtime param 2020-06-28 13:45:22 +02:00
Anders F Björklund b87a837f2e Use the actual storage driver name for cri-o 2020-06-28 09:49:50 +02:00
Prasad Katti 42af47b909 Do not auto-set extra config that user wishes to override 2020-06-27 16:26:07 -07:00
Thomas Strömberg cdc456a19b
Merge pull request #8570 from tstromberg/cni-split2
CNI: Update CRIO netconfig with matching subnet
2020-06-26 17:13:49 -07:00
Medya Gh e829341b9d improve logging 2020-06-26 15:12:15 -07:00
Medya Gh 64553e281b revert debugging 2020-06-26 15:11:03 -07:00
Medya Gh 742dcd6b00 add addon status verification for 3 addons 2020-06-26 15:08:38 -07:00
Medya Gh 66421a6492 wait for ingress pod be running 2020-06-26 14:22:17 -07:00
Medya Gh 52f4e130b5 lint 2020-06-26 13:20:31 -07:00
Medya Gh 5fbf197b18 remove unrelated changes 2020-06-26 13:20:31 -07:00
Medya Gh 96781c61a2 remove unrelated changes 2020-06-26 13:20:30 -07:00
Medya Gh 058a732909 ingress addon validate deployment after enable 2020-06-26 13:20:30 -07:00
Medya Gh c47854b8fd add validate ingress 2020-06-26 13:20:30 -07:00
Medya Gh a0c33f82c1 ingress addon wait for it 2020-06-26 13:20:30 -07:00
Anders F Björklund a1991e596d Only use docker client for docker runtime
Previously _always_ asking the docker daemon

Including for other runtimes, such as podman
2020-06-26 22:12:43 +02:00
Medya Ghazizadeh e8cebe0330
Merge pull request #8575 from afbjorklund/podman-dev
Support prerelease versions of podman binary
2020-06-26 12:49:50 -07:00
Anders F Björklund 9d98e858a3 Support prerelease versions of podman binary
It was trying to parse the newline character
2020-06-26 21:37:44 +02:00
Priya Wadhwa 7c2cac612d Fix bug in FailFastError and add unit test
Since FailFastError was just another `error`, all errors were technically `FailFastErrors`.

This code makes `FailFastError` a struct which implements the error interface, so that now errors can be distinctly identified as `FailFastError`'

Also added a unit test to prove that this works now.
2020-06-26 11:58:34 -07:00
Thomas Stromberg ffcb14a6b2 Add support for Cilium CNI (--cni=cilium) 2020-06-26 11:55:30 -07:00
priyawadhwa 7d79241ea5
Merge pull request #8565 from priyawadhwa/update-alternatives
Check for iptables file before determining container is running
2020-06-26 11:29:52 -07:00
Thomas Stromberg f901e638f2 Add support for Calico CNI (--cni=calico) 2020-06-26 11:21:15 -07:00
Thomas Stromberg f192df8ec5 Update podman/crio CNI netconf files to match CNI subnet 2020-06-26 11:01:13 -07:00
Medya Ghazizadeh 7fb09bb63b
Merge pull request #8562 from tstromberg/patient-status
apiserverHealthz: wait up to 8s before declaring failure
2020-06-26 10:10:48 -07:00
Thomas Strömberg ee18d3b03a
Merge pull request #8545 from tstromberg/cni-split2
Add --cni flag (replaces --enable-default-cni), fix --network-plugin handling
2020-06-26 09:53:53 -07:00
Priya Wadhwa e32e2135ed review comments 2020-06-25 19:39:59 -07:00
Priya Wadhwa 903686172d Check for iptables file before determining container is running 2020-06-25 17:58:22 -07:00
Medya Ghazizadeh 0b53e9054a
Merge pull request #8541 from medyagh/modprob_overlay
docker driver on linux: Give warning if overlay module is not enabled
2020-06-25 15:39:39 -07:00
Thomas Stromberg fb8e4950a1 Improve comment 2020-06-25 15:23:39 -07:00
Thomas Stromberg a43d18ef9a Update Bridge docstring 2020-06-25 15:21:25 -07:00
Thomas Stromberg 8c5f6a2132 apiserverHealthz: wait up to 8s before declaring failure 2020-06-25 15:14:51 -07:00
Thomas Stromberg 2f3094d32c simplify string output 2020-06-25 14:43:29 -07:00
Thomas Stromberg d16e7d4924 Use new kapi.KubectlBinary API 2020-06-25 14:43:19 -07:00
Thomas Stromberg 2a39d993ea Address lint comments, remove confusing multi-runner API 2020-06-25 14:36:39 -07:00
Thomas Stromberg 521d334b6a Apply CNI on restarts, remove .rej file 2020-06-25 14:23:18 -07:00
Thomas Stromberg 3968631b05 Merge to master 2020-06-25 10:54:42 -07:00
Thomas Strömberg 72e13c1eb8
Merge pull request #8543 from tstromberg/syspods-logging
Improve error and logging emitted by WaitForAppsRunning
2020-06-25 10:53:36 -07:00
priyawadhwa a115db6da8
Merge pull request #8552 from priyawadhwa/coredns
Reduce coredns replicas from 2 to 1
2020-06-25 10:51:18 -07:00
Priya Wadhwa 1769750b7d fix log level 2020-06-25 10:11:29 -07:00
Thomas Stromberg 3fb1cded91 Add retry.Local + retry logging 2020-06-25 09:43:45 -07:00
Priya Wadhwa 1b8eaaf76c Move kubectl binary function to kapi package to prevent future cyclic import dependencies 2020-06-25 09:40:14 -07:00
priyawadhwa d368674457
Merge pull request #8551 from priyawadhwa/etcd-extra-args
Allow passing in extra args to etcd via command line
2020-06-25 09:37:41 -07:00
Priya Wadhwa 6d3a0c4eca Reduce coredns replicas from 2 to 1
This is an easy way to improve overhead, and users can always scale this back up if they need to.
2020-06-24 17:42:12 -07:00
Priya Wadhwa 1b0de27d3d fix spelling 2020-06-24 16:43:32 -07:00
Priya Wadhwa 9d9d512cd8 fix function so we don't get an index out of bounds error 2020-06-24 16:34:58 -07:00
Priya Wadhwa 57574e3b6d fix space bug in unit test 2020-06-24 16:19:33 -07:00
Priya Wadhwa b32487adb1 Only include etcd extra args if they exist 2020-06-24 15:54:19 -07:00
Priya Wadhwa c1e2751ea6 Allow passing in extra args to etcd 2020-06-24 15:41:13 -07:00
priyawadhwa 84365fe57b
Merge pull request #8294 from maciaszczykm/dashboard-v2.0.1
Bump Dashboard to v2.0.1
2020-06-24 11:35:28 -07:00
Medya Ghazizadeh 977411bf75
Merge pull request #8544 from tstromberg/WaitForNode
Skip node pressure check if other checks failed, add retry
2020-06-24 10:26:25 -07:00
Thomas Stromberg a0817b6221 Remove debug statement 2020-06-24 07:53:18 -07:00
Thomas Stromberg af1798728b virtualbox: double health check timeout, add better errors 2020-06-24 07:51:50 -07:00
Thomas Stromberg 9e95435e00 Add --cni flag, fix --network-plugin=kubenet 2020-06-23 20:10:25 -07:00
Thomas Stromberg c38995d22d Skip node pressure check if other checks failed, add retry 2020-06-23 19:58:27 -07:00
Thomas Stromberg 54e70c9826 Improve error and logging emitted by WaitForAppsRunning 2020-06-23 19:36:28 -07:00
Medya Ghazizadeh 4f6a9f6518
Merge pull request #8518 from afbjorklund/docker-containerd
Make sure to use internal containerd for docker
2020-06-23 16:49:14 -07:00
Medya Gh 0121b44175 add NeedsImprovement warnning for overlay kernel 2020-06-23 13:17:59 -07:00
Medya Gh 1101f543d0 add check for mod prob 2020-06-23 12:15:57 -07:00
Anders F Björklund 4027ba4979 Add test case restarting docker after containerd
If we stopped containerd, we restart dockerd.
2020-06-23 20:26:34 +02:00
Anders F Björklund e25ab786ff Only restart dockerd if containerd was running
If starting minikube a second time, do nothing.
2020-06-23 20:17:01 +02:00
Thomas Strömberg f52a682a7e
Merge pull request #8531 from jtzwu/master
Do not output usage hint when shell=none.
2020-06-23 10:57:42 -07:00
Thomas Stromberg 852da00c03 Remove trailing spaces after leader-elect: false 2020-06-23 07:55:30 -07:00
Jeff Wu e1a7b225b3 Format code 2020-06-22 22:00:31 -07:00
Jeff Wu 33d4ecbcc1 Fix shell test to reflect the fact that shell=none no longer has a usage msg. 2020-06-22 21:36:08 -07:00
Jeff Wu f19ca53f34 Do not output usage hint when shell=none. Since there is no shell,
there is no clear way to expect how a usage hint will be interpretted.
2020-06-22 21:22:43 -07:00
Anders F Björklund 63270ad3d6 Restore newline that was removed by mistake 2020-06-20 13:17:29 +02:00
Anders F Björklund 5021c2f2fa Handle the empty SHELL special case ourselves 2020-06-20 13:13:09 +02:00
Anders F Björklund 8fc6dac9c5 Don't return error when SHELL has not been set 2020-06-20 13:00:22 +02:00
Anders F Björklund 22e1a41899 Adjust unit test results when docker not bound
When docker.service is *not* bound to containerd.service,
that means that it will be restarted to not try to use it.
2020-06-20 10:26:11 +02:00
Anders F Björklund f2ea21ab23 Make sure to use internal containerd for docker
When not using the containerd.service, we should make
sure that dockerd does not use the stopped containerd.
2020-06-20 10:01:52 +02:00
colvin 3d2ae5423c Rename podsecuritypolicies addon to pod-security-policy 2020-06-18 17:00:08 -04:00
Marcin Maciaszczyk d02b4b0df4 Bump preload version 2020-06-18 10:37:40 +02:00
Medya Gh e91e11eeba address review comments 2020-06-17 18:32:11 -07:00
Medya Gh 29e01d5dcb fix comment 2020-06-17 15:17:45 -07:00
Medya Gh dacd980fe7 add err type for start too 2020-06-17 15:15:23 -07:00
Medya Gh ca2d0f97ec move advice to its own file 2020-06-17 15:07:17 -07:00
Medya Gh 543b0b5bfa add post mortem logs when container not running 2020-06-17 13:27:17 -07:00
Medya Gh 736f5219e0 add error type for check running 2020-06-17 12:13:12 -07:00
Medya Ghazizadeh 18e89bbca2
Merge pull request #8499 from medyagh/sol_msg_cpucount
docker/podman: add advice for cpu count error
2020-06-17 11:52:01 -07:00
Li Zhijian e6b905608d kubeconfig_test: cleanup temp kubeconfig file
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-17 18:37:05 +08:00
Medya Gh 56b5524c8e address review comments 2020-06-16 14:57:19 -07:00
Medya Ghazizadeh 16c3e95260
Merge pull request #8475 from 11janci/jjanik-fix-hostip-vbox
Fix host network interface for VBox
2020-06-16 13:40:34 -07:00
Medya Gh 4caf260279 add cpu count limit error type for kic drivers 2020-06-16 13:21:56 -07:00
Medya Gh 6e08caa4cf add timed out log 2020-06-16 11:59:17 -07:00