Commit Graph

2114 Commits (3a20cd75bf2ce846ff974b92c9cc0ea4e95d1a91)

Author SHA1 Message Date
tstromberg 027e2ea39b Add more logging for test failures 2019-09-16 13:25:20 -07:00
Pranav Jituri bb2d0a05d9
Fix merge conflict 2019-09-15 19:27:38 +05:30
Marcin Niemira 0af8e241a9
Merge branch 'master' of https://github.com/kubernetes/minikube into improve-storageclass-test-coverage 2019-09-15 12:37:22 +10:00
Marcin Niemira c62576b73c
Refactor soome storageclass.go and add new tests 2019-09-15 11:41:08 +10:00
Marcin Niemira 9b5640cd33
Add tests to storageclass pkg 2019-09-14 22:25:06 +10:00
Jose Donizetti fb43666d7d Add installOrUpdate hyperkit support 2019-09-14 00:37:08 -03:00
Thomas Strömberg f9b8039697
Merge pull request #5348 from tstromberg/ncontext
Integration de-flake: expand lock scopes, sync clock at creation
2019-09-13 15:14:42 -07:00
Thomas Stromberg 1d346a01e6 Double the apiserver timeout for slow CI runs 2019-09-13 14:24:07 -07:00
Thomas Stromberg a075afac1b Only sync time during create for non-local Drivers 2019-09-13 13:35:10 -07:00
Thomas Strömberg df9d811e8f
Merge pull request #5320 from tstromberg/v1.16.rc
Update default Kubernetes release to v1.16.0-rc.2
2019-09-13 12:01:21 -07:00
Thomas Stromberg 773cfb7f28 Expand lock scope for kubeconfig and certificate update ops 2019-09-13 11:51:22 -07:00
Thomas Strömberg c376994b78
Merge pull request #5344 from tstromberg/outspam2
Move update notification out of PersistentPreRun, improve update UI
2019-09-13 10:20:09 -07:00
Thomas Stromberg a8d243972d Update Kubernetes default version to v1.16.0-rc.2 2019-09-13 10:18:24 -07:00
Thomas Strömberg 9df43318fa
Merge pull request #5335 from tstromberg/norunner2
Fine-tune integration test logging
2019-09-13 10:16:55 -07:00
Thomas Stromberg b6d878c417 Move update notification out of PersistentPreRun, improve update UI 2019-09-13 09:53:04 -07:00
Thomas Stromberg 357880a134 Retire Kubernetes v1.10 support, update OldestKubernetesVersion to v1.11 2019-09-13 09:06:04 -07:00
Thomas Stromberg 625a4f8c05 Minor tuning of test log verbosity 2019-09-13 07:42:30 -07:00
Thomas Stromberg 046391db69 Reduce log noise 2019-09-13 07:14:13 -07:00
Thomas Stromberg 55a3b9f8a2 kubeadm does not support --alsologtostderr after all 2019-09-13 06:18:08 -07:00
Thomas Stromberg 05a3279929 Add more logging for solving tricky bugs 2019-09-12 22:06:18 -07:00
Thomas Strömberg f5c232f461
Merge pull request #5324 from RA489/constupdate
Sync default service versions for kubeadm v1.16
2019-09-12 22:01:24 -07:00
tstromberg 46387d35ec ClientConfig requires context/cluster name, not node name 2019-09-12 15:19:47 -07:00
tstromberg 70ea1ff22a Fix ineff error 2019-09-12 10:35:32 -07:00
Thomas Stromberg 221eaa74ec Merge branch 'master' into norunner2 2019-09-12 09:45:37 -07:00
Thomas Stromberg e3d23d89f1 kube-proxy/WaitCluster fix: don't bootstrap from a stale context 2019-09-12 09:43:34 -07:00
RA489 b9333e6fa4 Sync default service versions for kubeadm v1.16 2019-09-12 10:52:36 +05:30
Thomas Strömberg 38123cd49d
Merge pull request #5016 from RA489/ignorevmdriver
Remove "Ignoring --vm-driver" warning
2019-09-11 22:05:47 -07:00
Thomas Stromberg 71f0ae9bc2 Revert OldestKubernetesVersion back to v1.10.13 now that the kube-proxy issue is sorted out 2019-09-11 21:58:58 -07:00
Thomas Stromberg 40b89a1052 kube-proxy/WaitCluster fix: kapi could point to the incorrect context 2019-09-11 21:36:37 -07:00
Thomas Stromberg 2362025efd Merge branch 'master' into norunner2 2019-09-11 20:28:17 -07:00
Thomas Stromberg 722cdea602 TestVersionUpgrade reliability: bump OldestKubernetesVersion, retry release startup 2019-09-11 20:28:13 -07:00
Thomas Strömberg d4a620372b
Merge pull request #5300 from n0npax/improve-problem-test-coverage
improve problem test coverage
2019-09-11 16:11:00 -07:00
Thomas Stromberg c3c13b5e6e Update default Kubernetes release to v1.16.0-rc.1 2019-09-11 15:42:45 -07:00
Thomas Stromberg 3b394df815 Add mutex around generateCerts to avoid TOCTOU race 2019-09-11 13:10:21 -07:00
Thomas Stromberg 7a5042793b Merge branch 'master' into norunner2 2019-09-11 11:54:24 -07:00
Thomas Stromberg 3e2d91ca17 Always force unmount on exit so that mountpoint can be re-used 2019-09-11 09:59:10 -07:00
Thomas Stromberg d26d96e051 Remove pre-flag init log spam 2019-09-11 09:58:26 -07:00
josedonizetti c434797f59 Remove debug logs 2019-09-11 11:34:29 -03:00
josedonizetti 219109c98e Add log lines to debug test 2019-09-11 11:34:29 -03:00
josedonizetti 85778d36a4 Remove deggubing information 2019-09-11 11:34:29 -03:00
josedonizetti e30fe10737 Add debugging information 2019-09-11 11:34:29 -03:00
josedonizetti 0cf4921c14 Add drivers.InstallOrUpdate acceptance tests 2019-09-11 11:34:29 -03:00
josedonizetti 30e75c3c39 Download kvm2 driver 2019-09-11 11:34:29 -03:00
Marcin Niemira bd8946f316
Fix api passing to test 2019-09-11 21:07:10 +10:00
Marcin Niemira dde5777543
Merge branch 'master' of https://github.com/kubernetes/minikube into improve-service-test-coverage 2019-09-11 20:36:59 +10:00
Marcin Niemira 64569b9c11
Refactor tests due to CR hints 2019-09-10 18:58:18 +10:00
Marcin Niemira 2e8de954d1
CR fixes 2019-09-10 18:42:02 +10:00
RA489 1972f1c428 Remove "Ignoring --vm-driver" warning 2019-09-09 19:05:09 +05:30
Marcin Niemira bb5f1e167c
improve problem test coverage 2019-09-09 20:07:41 +10:00
Jan Janik 9d16f7ef0d Include port names in the service cmd's output 2019-09-07 23:17:44 +12:00
Marcin Niemira aac8b37c26
improve test coverage fot sshutil package 2019-09-06 22:35:49 +10:00
Marcin Niemira 7d46c96dac
typofix 2019-09-06 17:27:38 +10:00
Marcin Niemira 1c967c519c
fix TestGetCoreClient in CI 2019-09-06 17:16:57 +10:00
Sharif Elgamal 8a92d78285
Merge pull request #5232 from n0npax/improve-registry-test-coverage
improve test coverage for registry package
2019-09-05 11:52:32 -07:00
Sharif Elgamal ba2f93106f
Merge pull request #5086 from MaxKam/checkCPUCount
Minimum CPUs check
2019-09-05 11:49:54 -07:00
Sharif Elgamal cb5ebed001
Merge pull request #4494 from ianlewis/gvisor-containerd-shim_v0.0.2
Update gvisor runsc version
2019-09-05 11:26:37 -07:00
Marcin Niemira e644d154bd
fix linting issue 2019-09-05 18:05:51 +10:00
Marek Schwarz 5b1528bdc9 Merge branch 'master' into DELETE_ALL_PROFILES 2019-09-04 17:42:22 +02:00
Marcin Niemira c2366dcb91
improve test coverage in service pkg
fix some potential panics
2019-09-04 23:17:12 +10:00
Thomas Strömberg c74a59e6d6
Merge pull request #5228 from n0npax/improve-proxy-test-coverage
Improve test coverage for proxy package
2019-09-03 22:17:22 -07:00
Ian Lewis d8c380da85
Merge branch 'master' into gvisor-containerd-shim_v0.0.2 2019-09-03 22:20:12 -04:00
Thomas Strömberg 9cf158d2a1
Merge pull request #5250 from tstromberg/v1.16.beta-default
Upgrade default Kubernetes version to v1.16.0-beta1
2019-09-03 16:17:03 -07:00
Thomas Strömberg 2635734849
Merge pull request #5249 from tstromberg/mologs
More logs: exited containers, controller manager, double line count
2019-09-03 16:16:38 -07:00
tstromberg cbf443c467 Upgrade default to v1.16.0-beta1 for more test coverage 2019-09-03 10:41:35 -07:00
tstromberg c32cb098b0 More logs: exited containers, controller manager, double line count 2019-09-03 10:34:44 -07:00
Max K 5ec324e2d2 Added check to exit app and show error message if number of cpus
is less than the minimum required.
2019-09-02 13:04:27 -07:00
bpopovschi 8b17253d22 Moved warning to minikube start command and print it to stderr 2019-09-02 11:39:38 +03:00
Marcin Niemira 1a105f8995
additional refactor 2019-08-30 23:00:15 +10:00
Marcin Niemira 6aaa5d243f
refactor to use subtests 2019-08-30 22:18:41 +10:00
Marcin Niemira aa79d39625
improve test coverage for registry package 2019-08-30 22:11:02 +10:00
Thomas Strömberg b0204cd315
Merge pull request #5224 from tstromberg/filepath
Windows: Use path.Join for VM paths, fall-back to anon image downloads
2019-08-29 16:49:29 -07:00
Marcin Niemira fa9ddcd7f1
typofix in comment 2019-08-30 07:54:32 +10:00
Marcin Niemira 6dac0467c7
improve function comment and move env var restoration to main test 2019-08-30 00:07:13 +10:00
Marcin Niemira 8a02235668
Improve subtests names 2019-08-30 00:02:23 +10:00
Marcin Niemira d4ac66eac5
fix variable name 2019-08-29 23:57:20 +10:00
AllenZMC a08e295d9f
cleanup: fix mis-spelling in kapi.go 2019-08-29 21:51:38 +08:00
Marcin Niemira ef912eaec3
Improve test coverage for proxy package 2019-08-29 23:27:16 +10:00
tstromberg cbbba12b6a Fix comparison 2019-08-28 14:56:48 -07:00
tstromberg 73d7526800 Add retrieveImage logging 2019-08-28 14:46:24 -07:00
tstromberg 79d7f8a737 Log caching errors 2019-08-28 14:17:03 -07:00
tstromberg 3b198d19d6 More logging to debug path issues 2019-08-28 13:47:26 -07:00
tstromberg 50f132be0a Remove path/filepath call 2019-08-28 13:16:12 -07:00
tstromberg b08de8e0f5 More filepath -> path 2019-08-28 13:13:52 -07:00
tstromberg f4db16ff6e Fix confusing log message which used the wrong filepath.Join 2019-08-28 13:03:59 -07:00
tstromberg 001c4fc7b0 Use path.Join instead of filepath.Join to avoid generating bad paths in Windows 2019-08-28 12:35:43 -07:00
Marek Schwarz 24d4eda27d Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
#	translations/fr-FR.json
#	translations/zh-CN.json
2019-08-27 17:04:01 +02:00
AllenZMC e2e8d74205
cleanup: fix mis-spelling in profile.go 2019-08-27 20:50:06 +08:00
Sharif Elgamal 14f3aa9244
Merge pull request #5165 from sharifelgamal/cfg
Replace file lock with mutex
2019-08-26 15:25:47 -07:00
Marek Schwarz 0dc7f8d03b Merge branch 'master' into DELETE_ALL_PROFILES 2019-08-26 21:28:29 +02:00
Thomas Strömberg b59a8b8e44
Merge pull request #5133 from afbjorklund/tmpfs
Move root filesystem from rootfs to tmpfs
2019-08-26 07:17:58 -07:00
AllenZMC b73c8505b4
cleanup: fix mis-spelling in retry.go 2019-08-26 20:26:35 +08:00
Ian Lewis d14bdbced7 Update gvisor runsc version
- Updates the gvisor addon to use containerd shim v2
- Updates the version of runsc
- Auto-installs a gvisor RuntimeClass

Issue #4482
2019-08-26 05:02:22 +00:00
Anders F Björklund eec1a06921 Add warning that using --no-pivot is not secure
It is only intended for compatibility with the old
rootfs ISO, and not needed with the new tmpfs ISO.
2019-08-24 16:18:48 +02:00
Anders F Björklund edea8f93a5 Only use DOCKER_RAMDISK on fstype rootfs
The docker configuration is determined at runtime,
so make it work with both old rootfs and new tmpfs.
2019-08-24 16:12:52 +02:00
Marek Schwarz ea20ba3edb Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	pkg/minikube/constants/constants.go
2019-08-23 20:09:55 +02:00
Marek Schwarz 808477ae1e Moved GetMachinePath to machine.go and renamed it to MachinePath
Added comments to public functions
2019-08-23 19:47:41 +02:00
Sharif Elgamal 172d5933f1 Merge branch 'master' of github.com:kubernetes/minikube into cfg 2019-08-22 16:29:25 -07:00
Sharif Elgamal 4733ebd1c3 formatting 2019-08-22 13:19:56 -07:00
Sharif Elgamal 534b2e9ec4 add test for getMutexName 2019-08-22 12:45:04 -07:00
Thomas Stromberg 48d2ace5cc Remove broken default disk size test that didn't make sense 2019-08-22 11:41:41 -07:00
Thomas Strömberg 695f8beb89
Merge pull request #5172 from ethan-daocloud/typo-terminator
Cleanup: fix some typos in code comment
2019-08-22 09:54:17 -07:00
Medya Ghazizadeh 73c0d9c386
Merge pull request #5150 from medyagh/intg_avoid_retry_start
Remove retry start from integration tests
2019-08-22 09:41:33 -07:00
AllenZMC b22f59f320 fix mis-spelling in ssh_runner.go (#5171) 2019-08-22 07:54:58 -07:00
Guangming Wang 206522dee8 Cleanup: fix some typos in code comment
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-08-22 22:54:23 +08:00
Sharif Elgamal 8b4365e51d change confusing variable name 2019-08-21 18:55:35 -07:00
Thomas Stromberg a7af253eaa Merge in v1.16 test updates 2019-08-21 18:49:25 -07:00
Thomas Stromberg 864aef157d Merge branch 'master' into persistent 2019-08-21 18:45:37 -07:00
Thomas Stromberg 4e9d4bd00f Remove unused constant function brought in by a bad merge 2019-08-21 17:41:58 -07:00
Thomas Stromberg 45c3219470 none reliability: --force does not work in v1.10, allow failed kubelet 2019-08-21 17:31:39 -07:00
Thomas Stromberg 5d325c745c Create symlink for legacy etcd directory, make apiserver check more robust 2019-08-21 17:20:47 -07:00
Medya Gh fc7c904642 add back test data from master 2019-08-21 16:02:03 -07:00
Medya Gh 9d0654f59e remove mistake file checked in 2019-08-21 15:58:57 -07:00
Medya Gh 5f0b0c1b90 Added duration metric for elevate priv 2019-08-21 15:56:46 -07:00
Sharif Elgamal 0cd49b8a32 more massaging around mutex name 2019-08-21 15:42:57 -07:00
Sharif Elgamal 020167617a add comments for clarity 2019-08-21 15:21:10 -07:00
Sharif Elgamal f02b698ae5 Merge branch 'master' of github.com:kubernetes/minikube into cfg 2019-08-21 15:17:42 -07:00
Sharif Elgamal 43e39618a2 Replace file lock with mutex 2019-08-21 15:17:32 -07:00
Thomas Strömberg 97dd433702
Merge pull request #5069 from tstromberg/v1.16.beta
Set NewestKubernetesVersion to v1.16.0-beta.1
2019-08-21 12:21:16 -07:00
Thomas Stromberg 72d9b80334 Merge branch 'master' into persistent 2019-08-21 11:45:00 -07:00
Thomas Stromberg 1c7a281d47 Run gofmt -w -s 2019-08-21 11:35:59 -07:00
Thomas Stromberg 580ffd6462 v1.16.0-beta.1 2019-08-21 10:33:37 -07:00
Thomas Stromberg 62a452edab Merge master 2019-08-21 10:26:10 -07:00
Thomas Strömberg 1d57563a86
Merge pull request #5103 from afbjorklund/buildroot-provisioner
Only provision buildroot with BuildrootProvisioner
2019-08-21 10:16:36 -07:00
Thomas Strömberg b9a88eb52b
Merge pull request #5116 from josedonizetti/refactor-read-config
Refactor config.ReadConfig to accept a file
2019-08-21 10:16:08 -07:00
Marek Schwarz 2c6f659725 Merge branch 'master' into DELETE_ALL_PROFILES 2019-08-21 18:49:37 +02:00
AllenZMC 03615ab411 fix wrong spells in kapi.go (#5160) 2019-08-21 06:46:50 -07:00
Sharif Elgamal 404d0ff255 remove duplicate import 2019-08-20 12:00:30 -07:00
AllenZMC a96b6438e8 fix wrong spells in containerd.go (#5143) 2019-08-20 09:32:35 -07:00
Medya Ghazizadeh c3cfedff79
Merge pull request #5121 from medyagh/refactor_util_kube
Add wait-timeout flag to start command and refactor util/kubernetes
2019-08-19 22:11:36 -07:00
Medya Gh f75b558ac2 rename kube pkg to kapi 2019-08-19 16:11:38 -07:00
Marek Schwarz ba67c8516a Merge branch 'master' into DELETE_ALL_PROFILES
# Conflicts:
#	cmd/minikube/cmd/delete.go
#	pkg/minikube/constants/constants.go
#	test/integration/z_proxy_test.go
#	translations/fr-FR.json
#	translations/zh-CN.json
2019-08-19 21:26:14 +02:00
Medya Ghazizadeh 86e158e2cf
Merge pull request #5104 from afbjorklund/engine-install
Provide default InstallURL in EngineOptions for libmachine
2019-08-18 01:55:08 -07:00
Medya Gh 5464a7c9e2 adding a new flag wait-timeout and reduce default wait from 5 to 3 2019-08-18 01:14:02 -07:00
Medya Gh a85db2ddb4 use kubeadm consts and add duration metrics logs 2019-08-17 23:18:13 -07:00
Medya Gh 5811610697 refactor util/kuberentes and ExtraOptions 2019-08-17 19:05:54 -07:00
josedonizetti 4738d1a80f Refactor config.ReadConfig to accept a file 2019-08-17 12:08:38 -04:00
Guangming Wang 8fb12d3a61
cleanup: lock.go error message typo fix
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-08-17 23:29:21 +08:00
Thomas Strömberg 3eaec49499
Merge pull request #5109 from tstromberg/wrongurl
Update URL should be concatenated without a /
2019-08-17 07:56:07 -07:00
Thomas Strömberg 96fcb917f8
Merge pull request #5106 from tstromberg/just-delete
delete: Clean up machine directory if DeleteHost fails to
2019-08-16 16:46:53 -07:00
Thomas Stromberg d11804e83f Fix certs_test merge conflict 2019-08-16 16:45:59 -07:00
Thomas Stromberg 282dcc9503 Merge branch 'master' into persistent 2019-08-16 16:38:56 -07:00
Thomas Stromberg 95173decc6 Update URL should be concatenated without a / 2019-08-16 16:18:22 -07:00
Thomas Stromberg e654eebf67 Merge branch 'master' into v1.16.beta 2019-08-16 15:31:43 -07:00
Thomas Stromberg fcd665fe11 Add kubeadm tests for v1.16 2019-08-16 15:31:21 -07:00
Thomas Stromberg b17d377d68 Detect when the addon-manager isn't able to process 2019-08-16 15:22:27 -07:00
Thomas Stromberg 1d6699f0da kubeconfig needs to live persistently 2019-08-16 15:21:58 -07:00
Thomas Stromberg 9a8275b83a Make delete resilient against corrupt configs 2019-08-16 14:39:40 -07:00
Medya Ghazizadeh 021ca860df
Merge pull request #4717 from priyawadhwa/gvisor-image
Rebuild gvisor image for integration tests
2019-08-16 12:25:10 -07:00
Anders F Björklund 8800bede50 Provide default InstallURL in EngineOptions 2019-08-16 18:09:37 +02:00
Anders F Björklund aa121cdce0 Only provision buildroot with BuildrootProvisioner 2019-08-16 18:07:44 +02:00
Guangming Wang 39d055431d
cleanup: fix error message in crypto.go
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-08-16 23:23:21 +08:00
Priya Wadhwa c611cf806d updated cache_image 2019-08-15 14:30:59 -07:00
Priya Wadhwa 198d6397f9 Merge branch 'master' of github.com:kubernetes/minikube into gvisor-image 2019-08-15 13:56:37 -07:00
Thomas Strömberg b0e9a23458
Merge pull request #5015 from laozc/populate-ca
Support adding untrusted root CA certificates (corp certs)
2019-08-15 12:05:54 -07:00
Guangming Wang 84242bf2c1
cleanup: fix words in logging message
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-08-15 20:53:28 +08:00
Zhongcheng Lao d26937dd8e
Merge remote-tracking branch 'origin/master' into populate-ca
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-08-15 20:38:12 +08:00
Medya Ghazizadeh 99f5771f78
Merge pull request #4896 from RA489/profilesm
Advice user does command ssh on non existing profile
2019-08-14 15:40:54 -07:00
Medya Ghazizadeh 14db2d7f1a
Merge pull request #5075 from medyagh/file_lock_write
Improve parallel run reliability by putting lock on files before writing
2019-08-14 12:37:47 -07:00
Medya Gh 9fad24aa37 defer release the lock 2019-08-14 11:05:03 -07:00
Thomas Stromberg 03ebad25ab merge conflict 2019-08-14 08:14:03 -07:00
Thomas Stromberg b983c47145 Merge branch 'master' into persistent 2019-08-14 08:12:25 -07:00
Medya Gh fb24d04fef remove unused code 2019-08-14 00:35:39 -07:00
Medya Gh c8e6f61bc1 convert all util.Retry to retry.Expo 2019-08-14 00:24:51 -07:00
Carlos Sanchez 58de23fee4 Fix error when KUBECONFIG has empty entries (#4100)
Signed-off-by: Carlos Sanchez <carlos@apache.org>
2019-08-14 08:57:59 +02:00
Medya Gh f17f3408a8 convert all RetryAfter to retry.Expo 2019-08-13 23:48:30 -07:00
Medya Gh 998d305af3 Adding lock to most ioutil.WriteFile 2019-08-13 21:12:34 -07:00
Medya Gh 9d44601ede Addeed file lock for kubeconfig 2019-08-13 20:56:28 -07:00
Medya Gh d264d7d553 adding retry subpackage 2019-08-13 19:59:21 -07:00
Medya Gh c340675e9d lint 2019-08-13 15:51:12 -07:00
Medya Gh cd11b0c41c Adding separate test data for create_delete profile 2019-08-13 15:51:12 -07:00
Medya Gh 36048225c0 Added more unit tests 2019-08-13 15:51:12 -07:00
Medya Gh 6ddb93d442 Added more unit tests 2019-08-13 15:51:12 -07:00
Medya Gh f969754106 Added unit test for Profile Exists 2019-08-13 15:51:12 -07:00
Medya Gh 010b29c178 lint and TODO comment 2019-08-13 15:51:12 -07:00
Medya Gh f712dd62f3 rename funcs, add new func DeleteProfile 2019-08-13 15:51:12 -07:00
Medya Gh 6a694ffa6f Add create profile, move funcs out of constants 2019-08-13 15:51:12 -07:00
tstromberg 152e877927 Set NewestKubernetesVersion to v1.16.0-beta.0 2019-08-13 15:49:57 -07:00
Medya Ghazizadeh 7bb085ad24
Merge pull request #5003 from medyagh/kubeconfig
Refactor Kubeconfig
2019-08-13 14:57:49 -07:00
Thomas Strömberg e8824b76b2
Merge pull request #5052 from tstromberg/doc-redirect
Update code references to new documentation URL's
2019-08-12 18:26:01 -07:00
Thomas Stromberg f2acb4a33e Update code references to new documentation URL's 2019-08-12 14:51:41 -07:00
Sharif Elgamal a817bffab1
Remove all minikube dependencies from drivers (#4933)
* Remove all minikube dependencies in driver code

* removing all default config

* okay we need some defaults

* code comments

* hyperkit builds now

* sleep for an appropriate amount of time

* remove constant in favor of string

* try goproxy for travis

* try goproxy for travis

* try goproxy for travis

* let's not try goproxy for now

* let's try goproxy once again

* maybe use the correct url for the proxy

* fix go mod
2019-08-12 14:42:11 -07:00
Sharif Elgamal 294f880106
Localization support for help text (#4814)
* Translating help text

* explicity set usage template so we can localize it

* cleaning up extract and translation files

* Add extraction for flags help text

* some comments for extract

* refactor to account for new behavior

* Make usage template translations more palatable.

* remove commented code

* fix go mod

* pin to proper version in go.mod

* translate command grouping headers
2019-08-12 11:16:20 -07:00
Thomas Strömberg 345ed1b85d
Merge pull request #5025 from blueelvis/4996-fix-download-progress-bars
Upgrade cheggaaa/pb from v1.0.27 to v3.0.1
2019-08-12 08:31:20 -07:00
Pranav Jituri 42f5b11fb3
Fixed as per review comments 2019-08-10 12:48:49 +05:30
Medya Gh e696d33206 renamed funky name to Settings 2019-08-09 17:51:51 -07:00
Thomas Stromberg 3d17976062 lint and change detector test updates 2019-08-09 16:24:49 -07:00
Thomas Stromberg 7c865c27cf Merge DefaultMinikubeDirectory with GuestPersistentDir 2019-08-09 15:19:23 -07:00
Thomas Stromberg 2f1a11d8d3 Move reusable files (images, binaries, certs) to /data 2019-08-09 15:04:07 -07:00
Medya Gh 362f5eaf7b fix bilerplate 2019-08-09 13:46:14 -07:00
Medya Gh d60664df78 refactor fix tests 2019-08-09 12:23:05 -07:00
Medya Gh d3e4e78caa remove redudnent arugment 2019-08-09 12:22:37 -07:00
Medya Gh c064d50881 more clearn func names and move var closer where used 2019-08-09 12:22:10 -07:00
Medya Gh 08e3e14263 add embeded-certs flag to config, decouple kubeconfig from viper 2019-08-09 12:21:48 -07:00
Medya Gh 1e8961f385 rename file 2019-08-09 12:21:48 -07:00
Medya Gh a15201b131 remove exit from kubeconfig update lib 2019-08-09 12:21:48 -07:00
Medya Gh 733ba21a36 decouple kubeconfig update from Host 2019-08-09 12:21:48 -07:00
Medya Gh 8899900889 fix the wrong import 2019-08-09 12:21:48 -07:00
Medya Gh 5a2a849bd2 use file path 2019-08-09 12:21:48 -07:00
Medya Gh 70a1d3b55d chanfges 2019-08-09 12:21:48 -07:00
Medya Gh 5621355004 ranem DeleteContext func 2019-08-09 12:19:58 -07:00
Medya Gh f41a937f5e rename funcs 2019-08-09 12:19:58 -07:00
Medya Gh ac79541826 rename test name 2019-08-09 12:19:58 -07:00
Medya Gh 9ab4892806 move test data 2019-08-09 12:19:58 -07:00
Medya Gh 5a9fb439ab rename funcs 2019-08-09 12:19:58 -07:00
Medya Gh a54b9629cd unexport and rename funcs 2019-08-09 12:19:58 -07:00
Medya Gh fd628eb8db statisfy lint interfacer 2019-08-09 12:19:57 -07:00
Medya Gh ffe573ec48 fixed stutter 2019-08-09 12:18:33 -07:00
Medya Gh df624349c3 created kubeconfig package 2019-08-09 12:18:33 -07:00
Zhongcheng Lao 253d658ad3
Fixes test case failure due to moving constants
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-08-10 00:22:36 +08:00
Zhongcheng Lao 63fdde280f
Move nested functions out
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-08-09 23:30:24 +08:00
Sharif Elgamal 1f48364487
Fix prepareNone and add integration test for it (#5023)
* Fix prepareNone and add integration test for it

* add test file

* only compile none test on linux

* build tags are confusing

* build tags are quite confusing

* build tags are very confusing
2019-08-08 15:47:44 -07:00
Pranav Jituri 7fa4e054f3
Fixed the progress bars ^_^ 2019-08-09 04:02:29 +05:30
Marek Schwarz 229c9b7ee9 Fixed lint errors 2019-08-08 23:21:05 +02:00
Priya Wadhwa bd17652481 Merge branch 'master' of https://github.com/kubernetes/minikube into gvisor-image 2019-08-08 13:10:04 -07:00
Priya Wadhwa 94638de7fd Remove error in gvisor image since it works now 2019-08-08 12:52:40 -07:00
Marek Schwarz 6ed4262849 Resolved import cycle
Added unit test for machine.go
2019-08-08 21:41:58 +02:00
Priya Wadhwa ee4cbbbf00 Run "sudo ctr -n=k8s.io images import" instead of "ctr images import" which doesn't load the image into the runtime 2019-08-08 11:11:30 -07:00
Zhongcheng Lao 49a91fe7ac
Do not fail start command when openssl does not exist
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-08-08 21:51:43 +08:00
Zhongcheng Lao aec9406c62
Populates CA certificates
This PR allows users to add root CA certificates in minikube
VM. CA certificates in $HOME/.minikube/certs will be populated
to system certificate store.

Note: This requires a change to minikube ISO so you may need to
delete and start a brand new minikube VM.

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2019-08-08 08:26:36 +08:00
Marek Schwarz 50329ed870 Added machine.go to Load and Validate machines
Added empty machine_test.go
Added testdata for machine.go
2019-08-07 21:48:46 +02:00
tstromberg 08d97cf025 Use a temp dest to atomically download the iso 2019-08-06 16:01:06 -07:00
Medya Ghazizadeh 551b164017
Merge pull request #4941 from josedonizetti/add-kubeconfig-tests
wip: Improve coverage: add kubeconfig tests
2019-08-06 10:38:04 -07:00
Thomas Strömberg 7ea0fbc93a
Merge pull request #4986 from tstromberg/v1.15.2
Update latest kubernetes version to v1.15.2
2019-08-05 18:13:30 -07:00
Thomas Stromberg 38410704ed Document 78 2019-08-05 16:32:54 -07:00
Thomas Stromberg 2042cd9ac7 Update latest kubernetes version to v1.15.2 2019-08-05 16:30:09 -07:00
Thomas Stromberg 2540253bcb Indent progress bar & set width to 78 columns 2019-08-05 15:40:14 -07:00
Priya Wadhwa cdbb2dd572 Updated gvisor test 2019-08-05 15:21:09 -07:00
Priya Wadhwa 24a2748af8 rebased, fixed merge conflicts 2019-08-05 13:53:23 -07:00
Priya Wadhwa f216fe68ad Check local daemon for cached image before checking remote repo 2019-08-05 13:07:47 -07:00
tstromberg 23491b68b6 Add boilerplate 2019-08-05 12:47:11 -07:00
tstromberg 22e55c70b8 Switch ISO download impl from go-download to go-getter 2019-08-05 11:46:38 -07:00
Pranav Jituri bf4f77a780
Fix crash when the cluster doesn't exist 2019-08-05 01:22:18 +05:30
Medya Ghazizadeh 45e5265c35
Merge pull request #4944 from josedonizetti/refactor-extract-writeconfig
Refactor extract writeconfig
2019-08-04 00:41:25 -07:00
Thomas Stromberg e9ecc59392 logs: fallback to docker ps if crictl ps fails (none driver) 2019-08-02 19:55:04 -07:00
josedonizetti 8b42e28d44 Refactor WriteConfig to accept a path 2019-08-02 21:45:01 -03:00
josedonizetti e14c7d9b1f Fix TestSetCurrentContext to use tmpfile 2019-08-02 21:28:16 -03:00
Thomas Strömberg be61eb7bb1
Merge branch 'master' into cherry-3a96b 2019-08-02 15:04:10 -07:00
Thomas Strömberg aabe45b184
Merge pull request #4959 from tstromberg/distro
UI: Add profile name & distro version to intro, clarify other messages
2019-08-02 15:03:08 -07:00
Thomas Strömberg 6a97242f29
Merge pull request #4958 from tstromberg/style-err
Log the underlying template error
2019-08-02 14:56:29 -07:00
tstromberg 6ac5fe2197 Fix merge conflict 2019-08-02 14:48:21 -07:00
tstromberg e717d46030 Decrease ReasonableStartTime from 10 minutes to 5 minutes 2019-08-02 14:42:57 -07:00
tstromberg 2dd3445176 Add container status and container runtime logs 2019-08-02 14:39:56 -07:00
tstromberg ee6b3da231 Remove 'pods' word 2019-08-02 13:47:34 -07:00
tstromberg 45e9cfba8f Opt for shorter output strings 2019-08-02 11:38:37 -07:00
tstromberg 4b9402fc82 Add host distro to minikube start & guest distro to logs 2019-08-02 11:17:52 -07:00
tstromberg 90b75bbab9 Log the underlying template error 2019-08-02 11:08:42 -07:00
Medya Ghazizadeh f872767afe
Merge pull request #4948 from medyagh/paralell_integration_tests4
refactor integration tests to run in parallel
2019-08-02 00:19:46 -07:00
Medya Ghazizadeh ce98918d8b
Merge pull request #4950 from medyagh/none_stop_improve
Improve driver none stop to work on older systems
2019-08-01 20:17:11 -07:00
Medya Gh fdc3b39e49 lower case errors 2019-08-01 13:52:46 -07:00
Medya Gh 1c8a655154 make none stop work on old systemd 2019-08-01 13:52:16 -07:00
Thomas Strömberg e1c485b1e6
Merge pull request #4898 from RA489/ps
hyperv: Powershell was not found in the path
2019-08-01 12:11:30 -07:00
josedonizetti 760707a5fb Fix lint 2019-08-01 15:08:27 -03:00
josedonizetti 021eaa723d Extract writeConfig 2019-08-01 14:54:47 -03:00
josedonizetti 487c104ab9 Rename test to Test_encode 2019-08-01 14:48:45 -03:00
josedonizetti 4a4ae87e9e refactor: Move WriteConfig to pkg/minikube/config 2019-08-01 14:37:30 -03:00
josedonizetti 358750e2e4 Add UnsetCurrentContext tests 2019-08-01 14:32:26 -03:00
Zoltán Reegn de27472759 Remove ingress-nginx default backend
It's not needed since nginx 0.20.0.

See the following pull-requests for context:
* https://github.com/kubernetes/ingress-nginx/pull/3126
* https://github.com/kubernetes/ingress-nginx/pull/3156
2019-08-01 09:51:30 -07:00
josedonizetti 2614069b43 rename TestGet to Test_get 2019-08-01 09:50:31 -07:00
josedonizetti 6d8e33097c rename TestReadConfig to Test_decode 2019-08-01 09:50:31 -07:00
josedonizetti 02c333084a Add closures_and_goroutines documentation 2019-08-01 09:50:31 -07:00
josedonizetti 58288cfbc2 Add test to config ReadConfig 2019-08-01 09:50:31 -07:00
josedonizetti 27664fe134 Improve UnsetTest 2019-08-01 09:50:31 -07:00
Sharif Elgamal 043ebfe397 Update latest kubernetes version to v1.15.1 2019-08-01 09:50:31 -07:00
josedonizetti 8cc1242601 Add TestSetCurrentContext 2019-08-01 13:20:01 -03:00
RA489 0c7d81c9d1 UI: Advice user when minikube profile is deleted 2019-08-01 07:08:28 +05:30
Medya Ghazizadeh 9916d7a438
Merge pull request #4786 from reegnz/remove-nginx-ingress-default-backend
Remove ingress-nginx default backend.
2019-07-30 14:06:14 -07:00
Medya Ghazizadeh 5add11bb59
Merge pull request #4924 from josedonizetti/rename-config-tests
Improve code readability: rename config unit tests
2019-07-30 14:02:33 -07:00
Medya Ghazizadeh db7d7c87da
Merge pull request #4926 from josedonizetti/add-closures-documentation
Add comment for better clarity of closures_and_goroutines documentation
2019-07-30 13:40:22 -07:00
Medya Ghazizadeh feb7231634
Merge pull request #4925 from josedonizetti/add-readconfig-test
Add test to config.ReadConfig
2019-07-30 13:38:28 -07:00
Medya Ghazizadeh 3a718d9e79
Merge pull request #4922 from josedonizetti/deletes-unset-profile
Unset profile when it is deleted
2019-07-30 13:36:21 -07:00
josedonizetti 190830b827 Add closures_and_goroutines documentation 2019-07-30 16:52:42 -03:00
josedonizetti b436a90db5 Add test to config ReadConfig 2019-07-30 15:53:33 -03:00
josedonizetti a531baa25a rename TestGet to Test_get 2019-07-30 15:23:35 -03:00
josedonizetti f9e00f4195 rename TestReadConfig to Test_decode 2019-07-30 15:22:57 -03:00
Medya Gh 9b3f72024a list vms after clean up 2019-07-30 10:42:55 -07:00
Medya Gh d1a41e0015 Added default profile 2019-07-30 10:40:11 -07:00
josedonizetti 483fe644eb Improve UnsetTest 2019-07-30 14:16:51 -03:00
Thomas Strömberg b309750496
Merge pull request #4915 from sharifelgamal/k8s-1.15.1
Update latest kubernetes version to v1.15.1
2019-07-30 10:03:47 -07:00
Zoltán Reegn d1436b40fe Remove ingress-nginx default backend
It's not needed since nginx 0.20.0.

See the following pull-requests for context:
* https://github.com/kubernetes/ingress-nginx/pull/3126
* https://github.com/kubernetes/ingress-nginx/pull/3156
2019-07-30 09:32:02 +02:00
Marek Schwarz a1d73a7a34 Added method to delete invalid profiles
Added unit tests for DeleteProfiles
deleteProfile for not part of api anymore
Added more validation for profiles
2019-07-29 23:19:13 +02:00
Sharif Elgamal 98e8dd3921
Update latest kubernetes version to v1.15.1 2019-07-29 13:40:35 -07:00
Medya Ghazizadeh 743aeaa859
Merge pull request #4887 from josedonizetti/fix-glog-parse-error
Fix glog parse error
2019-07-29 13:24:19 -07:00
Thomas Strömberg 128bdfbe27
Merge pull request #4674 from kubernetes/docsy2
Switch documentation site to docsy theme, add sample content
2019-07-29 11:51:48 -07:00
Thomas Strömberg a05a26e039
Merge pull request #4758 from blueelvis/4661-force-poweroff-in-hyperv
hyperv: Run "sudo poweroff" before stopping VM
2019-07-29 10:16:23 -07:00
RA489 23391893e8 hyperv: Powershell was not found in the path 2019-07-29 07:36:19 +05:30
josedonizetti 08c86b4010 Add comment explaining pkg/initflag 2019-07-27 11:05:49 -03:00
josedonizetti 7ece838d28 Add license to pkg/initflag 2019-07-27 11:03:56 -03:00
josedonizetti 42a69a9a27 Add pkg/initflag 2019-07-27 10:40:21 -03:00
Jose Donizetti fe00076341
Revert "Fix flag.Parse error logging" 2019-07-25 23:03:04 -03:00
Medya Ghazizadeh 288024fd53
Merge pull request #4867 from josedonizetti/fix-flag-parse-error-logging
Fix flag.Parse error logging
2019-07-25 14:41:58 -07:00
Marek Schwarz 342584ab93 Fixed testdata 2019-07-25 23:31:25 +02:00
Marek Schwarz fa0cdbf64b Fixed testdata 2019-07-25 22:46:35 +02:00
Marek Schwarz 59eb974088 Fixed testdata 2019-07-25 22:44:37 +02:00
Medya Ghazizadeh c603300781 more reliable stop for none driver (#4871)
* more reliable stop for none driver

* print stop error

* better error logging

* misspell

* error formatting

* Passing lint interfacer nag
2019-07-25 13:19:21 -07:00
Marek Schwarz 1d9a61f31e Changed username 2019-07-25 18:54:19 +02:00
josedonizetti 1480ed224d Add package license 2019-07-25 12:05:11 -03:00
Marek Schwarz d7d05b7494 Added more testdata 2019-07-25 16:33:46 +02:00
josedonizetti cbefe9936e Fix lint 2019-07-25 11:09:46 -03:00
josedonizetti d7f755d67a Fix flag.Parse error logging 2019-07-25 10:31:30 -03:00
Marek Schwarz a4fd88514b Added valid configs for delete_test 2019-07-25 13:15:27 +02:00
josedonizetti 65ac1e3103 Fix tests 2019-07-24 20:35:53 -03:00
josedonizetti 3ec9b1ed2a Bump k8s.io/kubernetes to 1.15.0 2019-07-24 19:51:40 -03:00
Anders Björklund e22b605e72
Merge pull request #4525 from afbjorklund/distro
Show info about the minikube linux distribution
2019-07-23 12:50:00 +02:00
Marek Schwarz cb589740c3 Added testdata for unit tests
Reorganized testdata file structure
2019-07-23 09:08:16 +02:00
Jose Donizetti 6a5fbbac34 Warn if hyperkit version is old (#4691)
* Add warn if hyperkit driver version is old

* Add hyperkit upgrade documentation

* Improve kvm/hyperkit upgrade warn message

* Move validateDriverVersion to before downloading ISO

* Change executable to use constants
2019-07-22 15:35:42 -07:00
Jituri, Pranav ed94288ac7 Fixed the code as per review comments 2019-07-20 23:05:46 +05:30
Jituri, Pranav c96a3bf1db Add conditional to poweroff on Hyper-V using SSH 2019-07-20 23:05:45 +05:30
Marek Schwarz 48bd69c895 Integrated ListProfiles()
Removed GetAllProfiles()
Made LoadProfile public
2019-07-20 18:57:27 +02:00
Anders F Björklund d1cca9544c Return empty struct instead of nil pointer
Not very friendly to return nil without error
2019-07-20 12:29:02 +02:00
Anders F Björklund f11fc22d9c Use "OS release" instead of "distribution"
Makes it more clear that it is os-release(5)
2019-07-20 12:28:01 +02:00
Anders F Björklund 60ff459cde Show information about the linux distribution
Taking from /etc/os-release, via libmachine provision

Failure to show it is not fatal, just log an error...
2019-07-20 09:47:31 +02:00
Thomas Stromberg 1ba2cd865f merge conflict 2019-07-19 19:25:32 -07:00
Thomas Stromberg 774832b22f Address boilerplate and mixed content linter issues 2019-07-19 19:23:41 -07:00
Sharif Elgamal 6552436311
Console output cleanup (#4825)
* Console output cleanup

* comment fix

* Fixing out.Out stutter

* Fix invalid template

* Change profile_list.go to new console functions

* more merge stuff
2019-07-19 17:00:51 -07:00
Thomas Strömberg 784717c007
Merge pull request #4813 from tstromberg/cluster_test
Make cluster_test and utils_test run in isolation
2019-07-19 16:48:26 -07:00
Thomas Stromberg 4076eb15d6 Remove unused imports 2019-07-19 16:40:34 -07:00
Thomas Stromberg a9309c3237 Remove unused ParseSHAFromURL function 2019-07-19 16:36:26 -07:00
Thomas Strömberg 042af2a0dc
Merge pull request #4823 from tstromberg/sshutil_test2
Make TestNewSSHClient and ssh_mock race-proof
2019-07-19 16:17:49 -07:00
Medya Ghazizadeh 9f42df6209
Merge pull request #4811 from medyagh/add_profile_list_cmd
Add a new command (profile list)
2019-07-19 15:43:50 -07:00
Thomas Stromberg 251a2147b8 Lint issues 2019-07-19 14:11:16 -07:00
Thomas Stromberg e958850a32 ssh mock: Raise errors rather than log them 2019-07-19 14:04:35 -07:00
Thomas Stromberg 6b3eb21be1 Add cleanup to TestNewSSHClient so that it can survive -race -count=100 2019-07-19 12:57:58 -07:00
Medya Gh a2d4c9e14e using ReadDir instead of walk 2019-07-19 11:16:20 -07:00
Medya Gh 51a19625bc Lint and add optional arg to other loaders 2019-07-19 10:45:56 -07:00
Medya Gh 14fcdaa98b make constant profile funcs more testable 2019-07-19 10:21:47 -07:00
Medya Gh cd80371aad Addded unit test for profile list 2019-07-18 22:13:32 -07:00
tstromberg 6f27d77748 Log command, pass T 2019-07-18 18:26:46 -07:00
Medya Gh b17376cccf Refactor profile, detect invalid profiles 2019-07-18 18:23:26 -07:00
tstromberg 22ae10c267 Remove unused getTestArgs struct 2019-07-18 18:17:19 -07:00
tstromberg a3d32758f8 Add mock.Logf functions to avoid panics 2019-07-18 18:12:48 -07:00
tstromberg 14c67d46a5 Remove TestParseSHAFromURL (not well isolated, takes 30 seconds) 2019-07-18 18:12:28 -07:00
tstromberg 172fa046cf Merge 2019-07-18 17:43:00 -07:00
tstromberg 2b49a8d8d9 Segregate cluster_test from existing profiles 2019-07-18 17:28:17 -07:00
Thomas Strömberg 186d2416be
Merge branch 'master' into translation2 2019-07-18 16:27:52 -07:00
Thomas Strömberg e373639d13
Merge pull request #4809 from tstromberg/template2
Add LowPrefix to Empty style, move to beginning of list
2019-07-18 16:27:16 -07:00
Medya Gh 63a6754f9d Add testdata for profile 2019-07-18 16:17:26 -07:00
Medya Gh 5b22779d99 Add comments 2019-07-18 14:31:11 -07:00
Medya Gh 9efc2f579d Added all profile funcs 2019-07-18 14:29:13 -07:00
Medya Gh 6a08732179 Added profile type 2019-07-18 14:27:35 -07:00
Sharif Elgamal 45974d911d
remove test checking for up to date translation files (#4808) 2019-07-18 13:15:09 -07:00
tstromberg 10d4b295f3 Add LowPrefix to Empty style, move to beginning of list 2019-07-18 13:01:00 -07:00
Medya Gh 7d4532fd1f Remove duplicate style 2019-07-18 11:22:46 -07:00
Medya Gh ed11f3ab0c merge upstream 2019-07-18 10:39:28 -07:00
Medya Ghazizadeh 5178c0b300
Merge branch 'master' into translation_outstyle 2019-07-17 18:12:45 -07:00
Sharif Elgamal 93263bc2bc
Templatizing more calls to console 2019-07-17 18:06:06 -07:00
Medya Gh e49d193cd7 Move up nil check the chain 2019-07-17 17:42:20 -07:00
Medya Gh 4fd0f757af Fix OutT 2019-07-17 17:38:25 -07:00
Medya Gh 97ba8854a6 more translation formatting 2019-07-17 17:37:39 -07:00
Thomas Stromberg 054fc946f1 Pass most tests 2019-07-17 17:13:12 -07:00
Thomas Stromberg cbd7d702ef Merge remote-tracking branch 'upstream/master' 2019-07-17 16:55:06 -07:00
Thomas Stromberg 3d7c657eaf Templated output migration 2019-07-17 16:54:56 -07:00
Medya Gh 4e4eccad30 Added more translation formatting 2019-07-17 16:54:29 -07:00
Medya Gh f57f6d724c linting 2019-07-17 16:28:49 -07:00
Sharif Elgamal b40011b2e3
Add T versions of the console convenience functions (#4796)
* Add T versions of the console convenience functions

* more changes

* Make OutT and ErrT more convenient and add WithCodeT:

* add UsageT

* make extract

* translate messages in displayError
2019-07-17 15:19:49 -07:00
Sharif Elgamal 24ad1d82b9
Add test to make sure translations files are up to date. (#4777)
* Add test to make sure translations files are up to date.

* Fix file path sadness so tests work as expected

* make sure we reset the working dir

* switching from bytes.Compare to cmp.Diff

* add better error message

* extract new localized strings

* fix tests
2019-07-17 13:49:39 -07:00
Medya Ghazizadeh 4178c4486d
Merge pull request #4794 from medyagh/hyperkit_errmap
Add advice if crash on hyperkit not installed
2019-07-17 13:03:27 -07:00
Medya Gh f68764cbc3 Add advice for hyperkit install instead of crash 2019-07-17 12:58:58 -07:00
Thomas Strömberg 3555ae5fb4
Merge branch 'master' into not-an-err 2019-07-17 11:14:32 -07:00
Thomas Strömberg 03fb063281
Merge pull request #4790 from tstromberg/issue-url-chooser
Update github issues URL now that we have issue templates
2019-07-17 11:08:09 -07:00
Anders F Björklund df7922881c Add missing ErrMapFile docs, to make golint happy 2019-07-17 19:40:19 +02:00
Jose Donizetti 6ded92edbe Fix darwin constants 2019-07-17 14:19:40 -03:00
tstromberg 1d3cea757b Update github issues URL to chooser 2019-07-17 09:58:31 -07:00
tstromberg 80fc10167f Merge conflicts 2019-07-17 09:41:53 -07:00
Thomas Strömberg bed7b8eb3e
Merge pull request #4729 from afbjorklund/none-info
Show more relevant information, when using none driver
2019-07-17 09:34:48 -07:00
tstromberg 1dc2afc748 Address more merge conflicts 2019-07-17 09:05:47 -07:00
Thomas Strömberg fe6e2b15e2
Merge pull request #4738 from josedonizetti/move-supported-drivers-per-platform
Move supported drivers per platform
2019-07-17 09:02:37 -07:00
tstromberg d0ae6e9d3b Obsolete driver lint issues 2019-07-16 15:16:51 -07:00
tstromberg 6729f6cfe4 Remove remaining DriverXhyve and DriverKvmOld references 2019-07-16 13:54:24 -07:00
tstromberg 914713f388 Remove deprrecated drivers: kvm-old and xhyve 2019-07-16 13:40:00 -07:00
josedonizetti 2ed16a1198 Move supported drivers per platform 2019-07-16 15:06:55 -03:00
Priya Wadhwa 6f65e3f822 Merge branch 'master' of github.com:kubernetes/minikube into gvisor-image 2019-07-15 17:01:24 -07:00
Sharif Elgamal 941c7d5fb2
moving checks to their relevant stops so unit tests work 2019-07-15 13:38:12 -07:00
Sharif Elgamal 77931fb4e2
Merge branch 'master' of github.com:kubernetes/minikube into extract-advice 2019-07-15 13:36:48 -07:00
Sharif Elgamal a7d5309f8e
fix lint 2019-07-15 11:17:08 -07:00
Anders F Björklund 7584d6aa08 Move hostInfo into function, add error checking 2019-07-14 10:19:54 +02:00
Sharif Elgamal 92bb35137b
Make sure err_map.go exists 2019-07-12 15:28:26 -07:00
Thomas Strömberg 76c456b998
Merge pull request #4739 from sharifelgamal/tmo-extract-test
Use tempfile for extract test
2019-07-12 15:14:53 -07:00
Thomas Strömberg b50aa37407
Revert "Refactor status command" 2019-07-12 14:23:38 -07:00
tstromberg 71ab89dfc2 Reduce kubectl restart time from 10 seconds to 600ms 2019-07-12 09:55:15 -07:00
Priya Wadhwa f55b38ec21 Merge branch 'master' of github.com:kubernetes/minikube into gvisor-image 2019-07-11 16:21:39 -07:00
Anders F Björklund 2b986ef638 Fix golint complaint about new OutT/ErrT functions 2019-07-11 22:03:22 +02:00
Priya Wadhwa 1ec4012052 Merge branch 'master' of github.com:kubernetes/minikube into gvisor-image 2019-07-11 12:43:42 -07:00
Sharif Elgamal f16ae95724 check error value 2019-07-11 12:19:41 -07:00
Kubernetes Prow Robot 65c6f9e5a3
Merge pull request #4686 from josedonizetti/refactor-status-cmd
Refactor status command
2019-07-11 11:54:10 -07:00
Sharif Elgamal c8f9562555 Use tempfile for extract test 2019-07-11 11:53:18 -07:00
Thomas Strömberg 82d4c7dd2c
Merge pull request #4688 from kairen/better-comment
Add space after // comments
2019-07-11 11:53:15 -07:00
Thomas Strömberg b0b13e1a7c
Merge pull request #4545 from marcosdiez/dont_disable_container_engines_when_vmdriver_is_none
Don't disable other container engines when --vm_driver=none
2019-07-11 11:17:57 -07:00
Priya Wadhwa e6653b78eb Build and push the gvisor image, setting an environment variable
which can be picked up during integration testing.

I opted to do it this way because the locally built gvisor image wasn't
being picked up by minikube, because the docker daemon wasn't
configured, since minikube isn't up and running yet. Even if the docker daemon was configured to point to
minikube, we wouldn't be able to build the gvisor-image from the test
itself.
2019-07-10 14:13:17 -07:00
Sharif Elgamal 6c2c00b754
fixing lint 2019-07-10 11:44:49 -07:00
Sharif Elgamal ad4d55f0ad
Merge branch 'master' of github.com:kubernetes/minikube into extract-advice 2019-07-10 10:24:36 -07:00
Sharif Elgamal c92e65ec28
Add templating for proper localization (#4677)
* Add templating for proper localization

* Fixing tests for new translation style

* checking errors is important

* fixing more console tests

* good function names make for happy developers

* add test for OutTemplateStyle

* short function names make for happy developers

* better formatting

* more better variable names
2019-07-10 10:17:28 -07:00
Anders F Björklund fdb4f9b167 Show "localhost" information for none driver 2019-07-10 17:27:55 +02:00
Anders F Björklund 4642b66ebc Don't lie about creating a VM with none driver 2019-07-10 13:47:24 +02:00
Sharif Elgamal 1940547c37
better variable name 2019-07-09 16:20:03 -07:00
Sharif Elgamal 392b51e3b8
refactored for clarity 2019-07-09 16:01:23 -07:00
Sharif Elgamal fc9fc7eecd
initial commit for extracting advice strings 2019-07-09 15:48:26 -07:00
Medya Ghazizadeh 57f6d877ed
Merge pull request #4689 from palnabarun/4664-fix
Fixes the issue which caused all containers to be deleted on minikube delete
2019-07-09 15:23:39 -07:00
Priya Wadhwa d2e5a4b052 build gvisor image locally in integration tests; add temporary error to make sure that image is used 2019-07-09 12:46:57 -07:00
josedonizetti 120ce27845 Refacator status command 2019-07-09 15:58:01 -03:00
Medya Ghazizadeh c8b0b41a6b
Merge pull request #4675 from superbrothers/fix-minikube-service
Fix `minikube service` to show error message if service has no node ports
2019-07-08 21:22:58 -07:00