Commit Graph

1688 Commits (38843d97b488c28bf45afed4bb564551c440bf9e)

Author SHA1 Message Date
Sharif Elgamal c1a3e4348d fix unit tests and fix merge conflicts 2020-02-13 10:30:12 -08:00
Sharif Elgamal 2785d292f5 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-13 10:15:04 -08:00
Medya Ghazizadeh 25167e1b75
Fix docker-env and add unit and integration tests (#6604)
* Fix docker cert env in docker-env for docker driver

* add unit tests

* add integration tests for docker-env cmd

* lint

* fix lint

* merge conflict

* improve docker-env integraiton test

* linting
2020-02-13 02:17:11 -07:00
Sharif Elgamal 8c55c9ca60 holy crap cyclical import hell sucks 2020-02-12 18:34:44 -08:00
Medya Ghazizadeh 398c7ef00b
Add podman driver (#6515) 2020-02-12 19:11:44 -07:00
priyawadhwa af353314e0
Separate cached kubernetes binaries by OS on host machine (#6586)
* Separate cached kubernetes binaries by OS on host machine

This way, all kubernetes binaries stored in ~/.minikube/cache/linux will be copied over to the VM and used for `minikube kubectl` on linux machines. kubectl will be stored in `~/.minikube/cache/{windows or darwin}` on windows/darwin so that `minikube kubectl` still works.

* Review comment

* Update integration test

* Make sure --download-only includes OS specific kubectl

Update integration test to make sure we download
OS specific kubectl on darwin/windows when using --download-only flag
2020-02-11 23:23:37 -07:00
Sharif Elgamal b427dc5663 fixed commands, they mostly work now 2020-02-11 21:11:22 -08:00
Sharif Elgamal 9830d91c09 linting nonsense 2020-02-11 18:39:59 -08:00
Sharif Elgamal 744efaa330 REFACTOR COMPLETE? 2020-02-11 17:06:59 -08:00
Sharif Elgamal b6a429dc9d hey did you want more files? good 2020-02-11 15:45:49 -08:00
Sharif Elgamal f2ebbb9c67 Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-11 09:44:10 -08:00
Sharif Elgamal 69aa54ff82
begin start refactor 2020-02-11 09:38:15 -08:00
Anders Björklund ff763db1e7
Add podman-env for connecting with podman-remote (#6351)
* Refactor: add the docker vars after the shell vars

* Move shell handling functions to separate package

* Rename env source file to docker-env like command

* Add podman-env for connecting with podman-remote

* Remove leading Shell prefix from the shell package

* Add some documentation describing podman service

* Address some podman-env issues pointed out by lint
2020-02-10 22:59:37 -07:00
anencore94 a283fd695a
Fix to kubeConfigPath could be set from env (#6568)
* Fix to kubeConfigPath could be set from env

Fix to use kubeConfigPath by using kubeconfig.PathFromEnv
function not from just $HOME/.kube/config

Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>

* Delete redundant logic to get kubeConfigPath

- change to use already present util function
 to set up kubeConfigPath

Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>

Co-authored-by: SOPHAL HONG <hongsophal.hsp@gmail.com>
Co-authored-by: Woohyung Han <woohhan@gmail.com>
2020-02-10 16:08:07 -07:00
go_vargo e18e4d083b
Fix `minikube start` in order to be able to start VM even if machine does not exist (#5730)
* fix startHost in order to be able to  start VM even if machine does not exist

* Update func StartHost() and its unit test no to use config.GetMachineName()

* Add handle case when the kic image isn't pulled
2020-02-10 11:37:30 -07:00
Zhongcheng Lao 239be7ed94 Create Hyper-V External Switch (#6264)
* Create and manager Hyper-V switch
* Adds new flag for Hyper-V driver
* Move switch creation out of chooseSwitch
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-02-07 21:22:19 -07:00
Sharif Elgamal e1fc3ce734
let's rearrange some stuff 2020-02-07 17:00:24 -08:00
Thomas Strömberg 8762c48921
Merge pull request #6541 from anencore94/deleteContext
Fix to delete context when delete minikube
2020-02-07 16:15:56 -08:00
Thomas Strömberg 2c08f62ed2
Let DeleteContext determine the KUBECONFIG path 2020-02-07 15:34:31 -08:00
priyawadhwa 914e7de860
Merge pull request #6536 from tstromberg/wait-nada2
Add --install-addons toggle for users who don't want them
2020-02-07 11:47:24 -08:00
anencore94 460f8d0187 Fix bug to delete context when delete minikube
- when `minikube delete`, minikube must delete its config which
  are set when `minikube start`.
- But, there was some mistakes in the function that does this
  logic

Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2020-02-07 20:00:08 +09:00
Thomas Stromberg c195d5a55f Merge branch 'master' into powershell-env-bugfixes 2020-02-06 23:17:26 -08:00
Thomas Strömberg 10ef863f7d
Merge pull request #6527 from tstromberg/powershell-env
Bug-compatible refactor of docker-env + output tests
2020-02-06 21:57:25 -08:00
Thomas Stromberg 63954700d7 Address review comments 2020-02-06 17:32:08 -08:00
Thomas Stromberg 4ba0f52f57 Add flag to toggle installation of addons 2020-02-06 17:29:19 -08:00
Thomas Stromberg 5d59e83b64 Rewrite unsetScript to fix a variety of bugs 2020-02-06 17:01:05 -08:00
Thomas Stromberg 0cac457126 Transition TestGetNodeDockerEnvIPv6 to env_test 2020-02-06 16:05:05 -08:00
Thomas Stromberg 6e19c62896 Update tests to include all current output quirks 2020-02-06 15:54:57 -08:00
Thomas Stromberg b478fbaa1a Minimize changes 2020-02-06 15:40:24 -08:00
Thomas Stromberg 32bc0ff76a Refactor docker-env for testability 2020-02-06 15:32:00 -08:00
Sharif Elgamal f6f8b503c4 fill in cmd code 2020-02-06 13:38:42 -08:00
Priya Wadhwa 6ef60c1964 Add warnings back in 2020-02-06 13:27:49 -08:00
Priya Wadhwa 59ab0ba89e Fix lint errors 2020-02-06 10:11:38 -08:00
Thomas Stromberg 9c70693e40 Revert whitespace change in docker-env output 2020-02-06 07:04:51 -08:00
Sharif Elgamal eded9a17e1
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-05 17:39:54 -08:00
Sharif Elgamal 8d365fcb03
shuffling stuff around for import purposes 2020-02-05 17:39:47 -08:00
Priya Wadhwa 091db5ddb6 Remove kubeadm pull images 2020-02-05 16:23:19 -08:00
Thomas Strömberg 2ecc120b2b
Merge pull request #6503 from tstromberg/faster-dryrun
Skip driver autodetection if driver is already set
2020-02-05 13:48:42 -08:00
tstromberg 7c301ec27b Merge branch 'master' into faster-dryrun 2020-02-05 12:05:43 -08:00
Thomas Strömberg 0d29a2ac7b
Merge branch 'master' into f-fix-5144 2020-02-05 11:32:32 -08:00
Sharif Elgamal 6d59d9d7df
Merge pull request #6200 from laozc/node-name
Use profile name as cluster/node name
2020-02-05 11:27:35 -08:00
Thomas Stromberg 80c0183f3d Skip driver autodetect if driver is already set 2020-02-05 10:48:04 -08:00
Thomas Strömberg 8eb91989a9
Merge pull request #6492 from medyagh/obvious_denv
improve "docker-env" command to point to correct docker
2020-02-05 10:02:35 -08:00
Thomas Strömberg 4dda226e86
Merge pull request #6483 from karolz-ms/dev/karolz/azure-cr
Add Azure Container Registry support
2020-02-05 10:01:59 -08:00
Thomas Strömberg 5795b7f312
Merge branch 'master' into obvious_denv 2020-02-05 08:14:56 -08:00
Thomas Strömberg 0bd4099cfc
Merge pull request #5678 from priyawadhwa/compare
[mkcmp] add code to time `minikube start` for each binary
2020-02-04 20:49:59 -08:00
Thomas Strömberg 37fb10415b
Merge pull request #6237 from tstromberg/ssh-verify
Support --force for overriding the ssh check
2020-02-04 20:49:07 -08:00
Sharif Elgamal dc0be4aed6
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-02-04 17:29:31 -08:00
Medya Gh 12e53f4d1f fix unit tests 2020-02-04 16:45:27 -08:00
Medya Gh 435010a3fc pass profilename for testability 2020-02-04 16:35:51 -08:00
Jose Donizetti eda1c76fe5 add kic tunnel (alpha) 2020-02-04 21:33:56 -03:00
Medya Gh c86b20ade2 add option to exec runner to point to host docker daemon 2020-02-04 15:33:04 -08:00
Sharif Elgamal 2d2b60f95b
fix lint 2020-02-04 15:12:55 -08:00
Sharif Elgamal f41a10a98f
Fix up some unit tests 2020-02-04 15:01:40 -08:00
Medya Gh f6c7048392 use constants instead of hardcode 2020-02-04 13:30:23 -08:00
Medya Gh 3937bae269 add new env var for docker-env command 2020-02-04 13:25:22 -08:00
Thomas Strömberg a50ebb8c03
Merge pull request #6481 from medyagh/k_nslookup
try nslookup both ways
2020-02-04 06:59:48 -08:00
Medya Gh 718ab997d5 spell 2020-02-03 17:11:35 -08:00
Priya Wadhwa 4f6deaf5dc Rebased on master 2020-02-03 16:31:11 -08:00
Thomas Strömberg 3f939af4b4
Merge branch 'master' into addons-startup2 2020-02-03 16:17:33 -08:00
Karol Zadora-Przylecki 4a4e7b7859 Add Azure Container Registry support 2020-02-03 16:10:18 -08:00
Medya Gh b4c1db6e14 change wording VM to node 2020-02-03 15:11:12 -08:00
Medya Gh 38a4a4ab8b more inclusive nslookup 2020-02-03 15:09:25 -08:00
tstromberg 04df96880e Merge branch 'master' into none-paused 2020-02-03 13:49:21 -08:00
tstromberg bcc186b908 Startup previously enabled addons 2020-02-03 10:49:40 -08:00
Zhongcheng Lao f59a2891eb
Merge remote-tracking branch 'origin/master' into node-name 2020-02-03 19:16:57 +08:00
Thomas Stromberg af2060a858 Move kubeconfig down as we cannot get an IP if host is down 2020-01-31 19:24:30 -08:00
Thomas Stromberg edbe92fb01 Re-arrange status calls to extract maximum information without being confusing 2020-01-31 19:15:58 -08:00
Thomas Stromberg 1176aa468f More status logging 2020-01-31 19:00:59 -08:00
Thomas Stromberg 6760929a72 Add logging of non-nil errors 2020-01-31 18:36:38 -08:00
Thomas Stromberg eee5788ab3 Make deletion output more terse 2020-01-31 17:08:27 -08:00
Thomas Stromberg ab93b27a70 Merge branch 'master' into none-paused 2020-01-31 16:38:00 -08:00
Thomas Strömberg e206b25da5
Merge pull request #6440 from tstromberg/addons-on-startup
Add addon enablement to start
2020-01-31 16:25:30 -08:00
Thomas Stromberg dd4ad10b83 Improve handling of paused none clusters. 2020-01-31 16:23:25 -08:00
Thomas Stromberg 40f2f7c28d Promote Infofs to errors/warnings 2020-01-31 16:23:07 -08:00
Thomas Stromberg b3149a1031 Allow 'profiles list' to work even if a profile has no control plane 2020-01-31 16:23:07 -08:00
Thomas Stromberg 7ebd01e113 Remove extra } 2020-01-31 14:55:24 -08:00
Thomas Stromberg 65fec571a5 Merge branch 'master' into ssh-verify 2020-01-31 14:53:13 -08:00
Thomas Stromberg 9b5044bfb2 Skip trySSH entirely if --force is set 2020-01-31 14:53:04 -08:00
Thomas Strömberg 15c6a8a028
Merge pull request #6450 from tstromberg/control-plane-err
Allow 'profiles list' to work even if a profile has no control plane
2020-01-31 14:43:12 -08:00
Thomas Strömberg 02902f7f4f
Merge pull request #6438 from tstromberg/nonexistent-status
status: Explicitly state that the cluster does not exist
2020-01-31 14:38:49 -08:00
Thomas Strömberg 723b074f65
Merge pull request #6409 from medyagh/plist_cr_info
add container runtime info to profile list
2020-01-31 14:38:25 -08:00
Thomas Stromberg 7d65ca31de Promote Infofs to errors/warnings 2020-01-31 14:35:03 -08:00
Thomas Stromberg 3ebbe4f1fc Allow 'profiles list' to work even if a profile has no control plane 2020-01-31 14:32:54 -08:00
Thomas Stromberg c3aafaeeb4 Add IsNotExist() method to the config package, so that we can have meaningful error messages and make them comparable 2020-01-31 14:19:08 -08:00
Priya Wadhwa d9860b1eb7 Update spacing 2020-01-31 12:58:53 -08:00
Thomas Stromberg c8f5679986 Run gofmt/goimports on cmd/ 2020-01-31 12:38:06 -08:00
Thomas Stromberg 78ed12265d Add testing for Start function, make addon enablement testable 2020-01-31 12:19:25 -08:00
Priya Wadhwa 6cd3b41bc8 Fix spacing in vm driver selection log 2020-01-31 11:43:18 -08:00
Thomas Stromberg ce68dd19b6 Merge branch 'master' into addons-on-startup 2020-01-31 08:23:21 -08:00
tstromberg b97124207c Move addon enablement to addons module + lint fixes 2020-01-30 17:46:25 -08:00
Kim Bao Long fefa13e9da Remove some redundance words
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-31 08:25:27 +07:00
Medya Gh 41687346e3 make it less than 80 2020-01-30 16:06:27 -08:00
tstromberg d5a83c7b24 Add addon enablement to start 2020-01-30 15:54:04 -08:00
tstromberg 6bd48a86c9 Explicitly say that a cluster is nonexistent 2020-01-30 14:41:45 -08:00
Thomas Strömberg 4309de6e8e
Merge pull request #6431 from tstromberg/missing-status-test
Add missing status test
2020-01-30 13:05:39 -08:00
Thomas Stromberg d454148990 Add missing status test 2020-01-30 10:16:43 -08:00
Sharif Elgamal 3cbe879d7e
node add works 2020-01-30 09:02:01 -08:00
Sharif Elgamal 593d3fc73e moving packages around 2020-01-28 17:09:00 -08:00
Medya Gh 178a3a256f add container runtime info to profile list 2020-01-28 16:40:53 -08:00
Sharif Elgamal 317dd41138
moving node package around 2020-01-27 17:59:35 -08:00
Sharif Elgamal 8db7f59b1e
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg 2020-01-24 16:08:22 -08:00
Sharif Elgamal 9a49c587d5
Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-24 15:54:04 -08:00
Thomas Strömberg 82e096a7a1
Merge pull request #6390 from medyagh/kic_bindip
kic driver: add multiple profiles and ssh
2020-01-24 15:45:51 -08:00
Medya Gh c6c0046c57 let docker/podman choose hostbind port 2020-01-24 14:15:48 -08:00
Sharif Elgamal c4e390f95c
missed one file 2020-01-24 13:57:47 -08:00
Sharif Elgamal 58ba813a9c
controlplane and worker are bools now magiiiiic 2020-01-24 13:54:41 -08:00
Sharif Elgamal 0b460e6cb7
master is no longer a thing 2020-01-24 13:24:38 -08:00
Sharif Elgamal ad03309ab6 Adding the initial node cmd and pkg files 2020-01-24 11:40:27 -08:00
Sharif Elgamal 9953cc2250
GetMasterNode -> MasterNode 2020-01-24 11:14:55 -08:00
Sharif Elgamal dbeac1b08c
KubernetesConfig.ContainerRuntime 2020-01-24 10:53:18 -08:00
Sharif Elgamal 77d838d3d2
Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-24 10:50:57 -08:00
Thomas Stromberg a9bc13b403 Address pause code review feedback 2020-01-23 15:44:30 -08:00
Sharif Elgamal 6a01d6b25b prefer getting master node over calling Nodes[0] 2020-01-23 13:26:50 -08:00
Sharif Elgamal 791f28ff4c things work now 2020-01-23 13:21:21 -08:00
Sharif Elgamal 8b2a05a565 Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-22 17:18:30 -08:00
tstromberg 1a13055d00 Add integration tests 2020-01-22 15:50:09 -08:00
tstromberg 22de8c110a Return the number of containers paused 2020-01-22 15:07:44 -08:00
tstromberg 62a72f44e8 Address feedback 2020-01-22 14:21:34 -08:00
Thomas Stromberg 5f0420f72e Merge branch 'master' into pause 2020-01-22 09:48:26 -08:00
Thomas Stromberg e6999caea3 Add paused state to apiserver status 2020-01-22 09:48:16 -08:00
Thomas Stromberg 09b2780fb2 Add support for pausing/unpausing specific namespaces 2020-01-21 22:06:05 -08:00
Medya Ghazizadeh 875c4b2d76
Merge pull request #6338 from medyagh/unify_boots
unify bootstrappers for both VM and contianer
2020-01-21 20:34:17 -08:00
Thomas Stromberg 7e2e9eb15b Merge conflicts 2020-01-21 20:00:21 -08:00
Thomas Stromberg 7f3351476c Merge upstream 2020-01-21 19:50:49 -08:00
Thomas Stromberg be65e4c2ad Merge upstream 2020-01-21 19:46:42 -08:00
Medya Gh 5a3c13815e network overlay only for kic 2020-01-21 15:14:51 -08:00
Medya Ghazizadeh e3bd383d64
Merge pull request #6255 from afbjorklund/kubectl-examples
Fix syntax of minikube kubectl example command
2020-01-20 19:36:05 -08:00
Medya Ghazizadeh e0a8b7dba8
Merge pull request #6325 from afbjorklund/dashboard-crash
Stop minikube dashboard from crashing at start
2020-01-20 19:34:18 -08:00
Anders F Björklund a681f1f00f Remove stray space from driver selection message 2020-01-20 21:18:34 +01:00
Zhongcheng Lao 6b0c69986f
Merge remote-tracking branch 'origin' into node-name 2020-01-18 08:09:51 +08:00
Sharif Elgamal 774bd5f174
Merge branch 'm2' of github.com:sharifelgamal/minikube into m2 2020-01-17 15:45:11 -08:00
Sharif Elgamal df3dc976b0
let's actually save the node config 2020-01-17 15:44:56 -08:00
Medya Gh 0b2d8051bb remove kicbs 2020-01-17 15:44:22 -08:00
Sharif Elgamal 01f6cefd2a
Merge branch 'master' of github.com:kubernetes/minikube into m2 2020-01-17 13:28:53 -08:00
Nanik T 9b455aafc4 Customizing host path for dynamically provisioned PersistentVolumes
This fix contains few things:

* Used k8s.gcr.io/debian-base-amd64:v2.0.0 as base image to build storage-provisioner
* Modify RBAC permission used to cluster-admin
* Build storage-provisioner as static binary
2020-01-16 12:23:26 +11:00
Sharif Elgamal 010d0d4091
adding experimental string to driver detection string 2020-01-15 16:22:48 -08:00
Sharif Elgamal d0fb749842
add displaysupporteddrivers func 2020-01-15 16:03:37 -08:00
Sharif Elgamal a13ea9bea0
add the ability to mark drivers as experimental and mark the docker driver as such 2020-01-15 15:21:47 -08:00
Anders F Björklund b7f3ff7ead Stop minikube dashboard from crashing at start
If the profile does not exist, it cannot load
2020-01-15 21:32:40 +01:00
Sharif Elgamal 804ee14a95 removing node surface stuff for a different PR 2020-01-15 11:36:36 -08:00
Sharif Elgamal dc6c9d7d75
cfg config fun 2020-01-14 16:49:13 -08:00
Sharif Elgamal 2c301bd4ef
more node changes yay 2020-01-14 14:25:20 -08:00
Sharif Elgamal 2813cf4120
Merge branch 'master' of github.com:sharifelgamal/minikube into m2 2020-01-14 13:44:40 -08:00
Anders F Björklund 71b561e344 Add note to remember to end the minikube flags
And add some whitespace before the next section
2020-01-14 18:22:45 +01:00
Medya Gh f645850842 add example to tunnel help 2020-01-13 16:16:36 -08:00
Medya Ghazizadeh 8718a54d91
Merge pull request #6256 from tstromberg/dry-run
Add --dry-run option to start
2020-01-13 13:37:15 -08:00
Medya Ghazizadeh 2e3d3e0add
Merge pull request #6274 from medyagh/add_table
Improve "addon list" by viewing as a table
2020-01-13 12:54:51 -08:00
Medya Ghazizadeh f5ce7d9e74
Merge pull request #6292 from afbjorklund/profile-version
Handle empty k8s version in existing profile
2020-01-13 12:50:14 -08:00
Medya Ghazizadeh 13e2a3e601
Merge pull request #6276 from tstromberg/qemu-system
Pass --kvm-qemu-uri value into kvm2 health check
2020-01-13 11:16:07 -08:00
Anders F Björklund 94b03ff881 Handle empty k8s version in existing profile 2020-01-13 18:33:59 +01:00
tstromberg 1085d47a24 Pass in the value of *kvmQemuURI for behavioral consistency 2020-01-10 16:07:07 -08:00
Medya Gh 6c7cadb371 make minikube addons list tabular 2020-01-10 15:39:22 -08:00
Medya Ghazizadeh 75082b6f7e
Merge pull request #6242 from afbjorklund/platform-arch
Only print the virtualization system if it exists
2020-01-10 10:39:26 -08:00
Medya Ghazizadeh 19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
Experimental verison of kic
2020-01-10 00:42:01 -08:00
Thomas Stromberg b840d1ced0 Call goimports 2020-01-09 11:58:15 -08:00
Thomas Stromberg 7acf688f7a Merge master 2020-01-09 11:13:25 -08:00
Thomas Stromberg c5e917366f Add --dry-run option to start 2020-01-09 11:10:23 -08:00
Anders F Björklund 3207b27c11 Fix syntax of minikube kubectl example command
Need to terminate the minikube flags with --,
before starting with the kubectl command flags.
2020-01-09 19:52:58 +01:00
Zhongcheng Lao 4a1f33e282
Adds cluster name to kubenetes config
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 20:00:40 +08:00
Zhongcheng Lao 0512882520
Do not set host-override for kubelet by default
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 19:52:30 +08:00
Medya Gh 40a011c49a use api port for host binding port 2020-01-08 16:09:24 -08:00
Medya Gh cf9e6e512f fix ineffectual assignment 2020-01-08 15:21:57 -08:00
Anders F Björklund 039f53144a Only print the virtualization system if it exists
Avoids output like (/arm64), with an extra slash
2020-01-08 23:06:59 +01:00
Medya Gh ddf5ab027a add extra option fail swap for kic 2020-01-08 12:53:29 -08:00
tstromberg 5d8e9dbfc5 Support --force for overriding the ssh check 2020-01-08 11:23:15 -08:00
Zhongcheng Lao f46e11f14a
Fixes busybox nslookup does not support queryt type
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 22:31:45 +08:00
Zhongcheng Lao be7b52791a
Remove unused var
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 15:41:07 +08:00
Zhongcheng Lao 96398c73ad
Merge remote-tracking branch 'origin/master' into node-name 2020-01-08 14:45:21 +08:00
Zhongcheng Lao d3ff888743
Use profile name as the node name
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 14:42:17 +08:00
Medya Gh f80572bb4c code review 2020-01-07 13:59:41 -08:00
Medya Gh 618b150bcd fix setup kubeconfig for kic 2020-01-07 13:54:00 -08:00
Medya Gh d298593d8a refactor api server verification 2020-01-07 13:54:00 -08:00
Medya Gh e9b7451278 auto set podsubnet for kic improve none auto set 2020-01-07 13:54:00 -08:00
Medya Gh 860ce25bf2 Add podSubnet to templates 2020-01-07 13:54:00 -08:00
Medya Gh c7bc61af2c Add overlay network for kic 2020-01-07 13:54:00 -08:00
Medya Gh 6cf2554877 add flag for kic host binding port 2020-01-07 13:54:00 -08:00
Medya Gh a358aff093 fix ocibinary 2020-01-07 13:52:47 -08:00
Medya Ghazizadeh 19e7ea4c40
Merge pull request #6217 from tiendc/unit_test_config_get
Add unit test for cmd/minikube/cmd/config/get.go
2020-01-07 11:48:11 -08:00
Medya Ghazizadeh d23b446d2e
Merge pull request #6218 from afbjorklund/reportcard-minor
Improve reportcard by refactoring and commenting
2020-01-07 11:42:55 -08:00
Dao Cong Tien 60f514c0a5 Add unit test for cmd/minikube/cmd/config/set.go
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
2020-01-07 14:02:05 +07:00
Thomas Strömberg af4ee5cf1f
Merge pull request #6124 from priyawadhwa/addon-per-profile-refactor
Enable or disable addons per profile
2020-01-06 16:33:01 -08:00
Anders F Björklund ea7a2d7e33 Improve reportcard by refactoring and commenting
golint: 99%
	pkg/minikube/localpath/localpath.go
		Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
	pkg/minikube/cluster/cluster.go
		Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
	cmd/minikube/cmd/start.go
		Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
		Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
Dao Cong Tien 743c67d40e Add unit test for cmd/minikube/cmd/config/get.go
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
2020-01-06 18:49:31 +07:00
Anders F Björklund 81622e2a00 Minor: change assignment to declaration
"warning: ineffectual assignment to updated (ineffassign)"
2020-01-04 10:23:16 +01:00
Zhongcheng Lao 73608d60e4
Set node name the same as host name by default for none driver
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-03 00:32:05 +08:00
Zhongcheng Lao 914c34cc2a
Set node name in non-default profile
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-01 13:45:05 +08:00
Zhongcheng Lao f9ed4a6460
Allow user to override node name
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-01 13:45:03 +08:00
Priya Wadhwa e47cde6ae4 Rebased on master, moved istio addon into new package 2019-12-30 10:10:05 -05:00
Medya Ghazizadeh df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
fenglixa c2ba574f2e generate istio document page and layout 2019-12-26 14:35:13 +08:00
andylibrian f42c8a49fb fixed comment 2019-12-21 18:34:40 +07:00
andylibrian 76714aca84 implemented options command #5036
This is to fix help command showing invalid "minikube <command> options".
It happened because minikube reuses kubectl templates which expects
options cmd to be there.
2019-12-21 11:09:36 +07:00
Medya Gh d5f56477bc code review resolve 2019-12-20 17:14:14 -08:00
Medya Gh 3b2cfa6c32 rename funcs 2019-12-20 16:53:35 -08:00
Medya Gh 83cd426436 refactor more 2019-12-20 16:11:05 -08:00
Medya Gh cf6bde8eaf refactor image specific funcs to image package 2019-12-20 16:05:08 -08:00
Medya Gh be8a1ad107 resolve code reviews 2019-12-20 12:43:13 -08:00
Priya Wadhwa 6c25cd3848 Rebased on master 2019-12-20 12:34:48 -08:00
Medya Gh 5eb384cf7d check error and fix logging msg 2019-12-20 12:24:05 -08:00
Medya Gh a3e16fae72 add reload command 2019-12-20 12:06:26 -08:00
Medya Gh 2d1fffe1d1 better names 2019-12-20 12:06:26 -08:00
Medya Gh 679a9c114b more clear func names 2019-12-20 12:06:26 -08:00
Medya Gh 71a896fc0a unexport func cacheImage 2019-12-20 12:06:25 -08:00
Medya Gh 193d16dd0c rename funcs for more clarity 2019-12-20 12:06:25 -08:00
Medya Gh 03c717c7b0 unexport cacheImagesInConfigFile func 2019-12-20 12:06:25 -08:00
Medya Ghazizadeh 031126b358
Merge pull request #6112 from medyagh/kic_start_xmas
kic-xmas edition
2019-12-20 11:40:46 -08:00
Medya Gh 1014a57ea8 better names for bs type 2019-12-20 01:01:10 -08:00
tstromberg bf183603c5 Disable StartHost retry. It caused more problems than it solved 2019-12-19 16:10:44 -08:00
Priya Wadhwa b64a33a6e9 updated dashboard command to use new addons library 2019-12-19 15:39:29 -08:00
Priya Wadhwa 4fd929deeb Merge branch 'master' of github.com:kubernetes/minikube into compare 2019-12-19 14:03:20 -08:00
Priya Wadhwa fa08e18e8d goimports 2019-12-19 13:33:19 -08:00
Priya Wadhwa 859420c083 Merge branch 'master' of github.com:kubernetes/minikube into addon-per-profile-refactor 2019-12-19 13:06:07 -08:00
Priya Wadhwa f6c61b7a80 Make sure minikube start --addons works 2019-12-19 12:44:32 -08:00
Thomas Strömberg 4e0454d6b4
Merge pull request #6111 from tstromberg/awful-offl
Offline: always transfer image if lookup fails, always download drivers
2019-12-19 11:52:28 -08:00
Thomas Strömberg aca49067fa
Merge pull request #6110 from digitalcoyote/master
Fixed IPv6 format for SSH
2019-12-19 11:51:55 -08:00
Priya Wadhwa 48b5a1e493 Merge branch 'master' of github.com:kubernetes/minikube into compare 2019-12-19 11:28:11 -08:00
Priya Wadhwa 1e5aeb6aa9 Addressed review comments 2019-12-19 11:27:53 -08:00
Priya Wadhwa 4c7b94971c Address review comments
Remove old TODO and remove function to get current profile as it can
create errors when trying to get multiple profiles.
2019-12-19 10:41:01 -08:00
Sharif Elgamal 3f20aa4e82
fix config import nonsense in start.go 2019-12-19 09:45:00 -08:00
Kenta Iso 6316959739 Fix update-context to use KUBECONFIG when the env is set and add integration test 2019-12-19 00:28:39 -08:00
Priya Wadhwa 921fee7432 Moved unit tests to addons package and refactored them 2019-12-18 22:02:10 -08:00
Priya Wadhwa e72cb80cbf Enable/disable addons works per profile
However, this means that addon information won't persist beyond a 'minikube delete'
2019-12-18 21:35:46 -08:00
Medya Gh b8d07daef3 move reusabe parts of kubeadm to a package 2019-12-18 17:22:42 -08:00
Medya Gh 31ad90d3cb Add place holder bootstrapper for kicbs 2019-12-18 16:11:50 -08:00
Medya Gh 83374f4371 add querytype to nslookup 2019-12-18 15:54:36 -08:00
Medya Gh 19560a631b Add kic specific machine creation message 2019-12-18 15:53:34 -08:00
Medya Gh 2243847f98 add kic command runner to machine 2019-12-18 13:57:32 -08:00
Medya Gh c627f58fbb add default image 2019-12-18 13:04:09 -08:00
Priya Wadhwa ba8b723978 Move addon related logic to pkg/addons for better organization 2019-12-18 11:31:29 -08:00
tstromberg 98508253a5 --download-only should download drivers 2019-12-18 09:46:36 -08:00
Medya Gh b6dbf3bd0d add auto-set container-runtime for kic 2019-12-17 22:19:39 -08:00
Sharif Elgamal e46c586764 more refactor fun 2019-12-17 15:53:37 -08:00
Curtis Carter 119d95cb31 Fixed format of IPV6 address and port 2019-12-17 13:23:30 -06:00
Sharif Elgamal c295dfd25c
more node crud stuff 2019-12-17 09:00:48 -08:00
Kenta Iso a840cb7289 Fix update-context to use KUBECONFIG when the env is set and add integration test 2019-12-17 00:58:45 +09:00
Sharif Elgamal 9f2217d803 sketches of the node commands 2019-12-12 17:38:29 -08:00
Sharif Elgamal 47d918f1b3
making more arbitrary node changes 2019-12-12 10:35:33 -08:00
Thomas Stromberg 661ebf843f Merge master 2019-12-10 14:07:02 -08:00
Thomas Strömberg 349f414dee
Merge pull request #5987 from medyagh/cache_fix2
cache add: load images to all profiles & skip previously cached images
2019-12-10 13:58:57 -08:00
Thomas Stromberg 14b805d494 Remove unused vars 2019-12-10 08:17:08 -08:00
Thomas Stromberg 8b7aaba627 Sync correct Kubernetes versions from kubeadm constants 2019-12-10 08:12:15 -08:00
priyawadhwa 434648c6fc
Merge pull request #5773 from priyawadhwa/pr-bot
Add skeleton for performance analysis service
2019-12-09 18:26:45 -08:00
Medya Gh 60346821d6 move machine path to localpath package 2019-12-09 14:51:10 -08:00
Medya Gh 35ad8e2915 make profile name mandatory for config.Load 2019-12-09 14:47:20 -08:00
Thomas Strömberg a6c749f905
Merge pull request #5798 from nanikjava/f-fix-2570
Make Kubernetes version sticky for a cluster instead of auto-upgrading
2019-12-09 13:47:44 -08:00
Thomas Strömberg 1f36a42203
Merge pull request #5912 from tstromberg/user-mutex2
Make lock names uid and path specific to avoid conflicts
2019-12-09 13:34:56 -08:00
Priya Wadhwa 4b78f7bd48 Rebased on head, resolved merge conflict 2019-12-09 12:03:37 -08:00
Medya Gh d7b6e66038 fix unit tests and improve naming 2019-11-26 20:07:56 -08:00
Medya Gh 95717c4793 add status to profile list 2019-11-26 19:53:27 -08:00
Medya Gh cdb68a139e refactor config to allow load profile config 2019-11-26 18:32:59 -08:00
Medya Gh 6c08fedf97 remove cyclic depdenecy and make cluster pkg smaller 2019-11-26 17:48:37 -08:00
Priya Wadhwa 3574879fde rebased on master 2019-11-26 10:32:32 -08:00
Medya Ghazizadeh 72e973027d
Merge pull request #5955 from cheeseandcereal/fix_profile_list_json
Fix profile list json command output
2019-11-25 14:59:11 -08:00
Medya Ghazizadeh c462862a38
Merge pull request #5964 from afbjorklund/config-runtime
Fix validation of container-runtime config
2019-11-25 13:19:23 -08:00
Anders F Björklund 3451320ad2 Fix validation of container-runtime config
It was trying to load (non-existing) config,
and also confusingly looking for containerd.

Add a unit test as well.
2019-11-23 10:35:12 +01:00
Thomas Stromberg 64ee657c49 Fix some bugs, add some logging, have a turkey 2019-11-22 16:12:24 -08:00
Thomas Stromberg 337db1707d First pass at multi-runtime pause/unpause 2019-11-22 15:11:51 -08:00
David Newman fbb1d97cf1 feat(virtualbox): Users and set nat-nic-type and host-only-nic-type 2019-11-22 13:50:12 -05:00
Adam Crowder f8a2d1da07
fix profile list json command output
Signed-off-by: Adam Crowder <adam@adamcrowder.net>
2019-11-20 13:58:05 -08:00
Nanik T f680d1b1fc Fix --kubernetes-version for upgrading cluster to correct version
This PR fix the issue of checking kubernetes-version and upgrading it. The fix now
will do the following

* Not specifying the --kubernetes-version flag means just use the currently deployed version.
* If an update is available inform the user that they may use --kubernetes-version=<version>.
* When --kubernetes-version is specifically set, upgrade the cluster.

Also add integration testing to test upgrading and downgrading
2019-11-16 21:12:54 +11:00
Thomas Stromberg 557339acc2 Recover from aborted kubeadm runs by checking for file existence 2019-11-14 15:00:56 -08:00
Thomas Strömberg 1c46502f35
Merge pull request #5848 from hypnoglow/try-ssh-retry
Add retry to SSH connectivity check
2019-11-14 14:08:41 -08:00
Thomas Stromberg a750524774 Fix test that made assumption that minikube was valid 2019-11-14 10:56:44 -08:00
Igor Zibarev 33293ed689 Retry on SSH connectivity check 2019-11-13 22:23:50 +03:00
Thomas Stromberg 2411895715 Clarify restart code, remove duplicate health check 2019-11-12 21:29:53 -08:00
Thomas Stromberg 4ae939244c Clarify help text for --wait, take #2 2019-11-12 14:23:39 -08:00
Thomas Stromberg 55a7002ed7 Clarify help text for --wait 2019-11-12 14:22:53 -08:00
Thomas Stromberg dc3a50e026 Make --wait=false wait for nothing again, change default to --wait=true 2019-11-12 13:38:48 -08:00
Sharif Elgamal c03aee8322
Refactor config.Config to prepare for multinode (#5889)
* Refactor config.Config to prepare for multinode

* merge conflict
2019-11-11 17:52:15 -08:00
Sharif Elgamal fb5430fd97
Getting rid of GetMachineName() (#5868)
* removing GetMachineName()

* replacing GetMachineName with a config lookup

* fix tests

* making unit tests happy

* fixing concurrent map writes, only right to viper once

* debugging

* one last test fix

* DeleteAlwaysSucceeds should actually always succeed

* prevent panic when deleting nonexistant cluster

* remove last GetMachineName reference
2019-11-11 14:47:47 -08:00
Thomas Stromberg 3f98e12fa9 Remove redundant return 2019-11-11 12:16:13 -08:00
Thomas Stromberg 82231dc0ee Merge 2019-11-11 08:38:29 -08:00
Thomas Strömberg 1d0ca6cd68
Merge pull request #5854 from tstromberg/driver-compat-msg
Improve message when selected driver is incompatible with existing cluster
2019-11-11 08:22:57 -08:00
Priya Wadhwa 108fd082b5 change name monitor to pr-bot 2019-11-07 10:48:55 -08:00
Thomas Strömberg 79fcf7172d
Merge pull request #5845 from tstromberg/none-memory
none driver: Warn about --cpus, --memory, and --container-runtime settings
2019-11-07 06:54:45 -08:00
tstromberg 9d0c3eda8e Remove extra word 2019-11-06 15:56:11 -08:00
tstromberg 1b9955f3d6 Improve message when selected driver is incompatible with existing cluster 2019-11-06 15:53:42 -08:00
tstromberg b02b4e158a Avoid panic and output correct driver name 2019-11-06 14:18:28 -08:00
Sharif Elgamal 6ff68709dd
Merge pull request #5243 from rajalokan/remove-heapster
Remove heapster addon
2019-11-06 11:35:35 -08:00
tstromberg 0af762e51f none driver: Add warnings about --cpus, --memory, and --container-runtime 2019-11-06 10:29:02 -08:00
tstromberg fb3360da06 Check health of drivers from existing configs 2019-11-05 17:16:23 -08:00
tstromberg 9c2b554ce7 Merge branch 'master' into better-existing-start 2019-11-05 15:04:22 -08:00
tstromberg 8809ab113a Validate existing drivers too 2019-11-05 14:59:12 -08:00
Anders F Björklund 47fe5b2822 Remove ping, was added in merge conflict
Supposed to be removed in 361222f, along with
some other random changes to comments and such.
2019-11-02 08:59:19 +01:00
Anders F Björklund df1175f51f Merge branch 'master' into reportcard-again 2019-11-01 18:32:37 +01:00
Thomas Strömberg d7569b375c
Merge pull request #5803 from tstromberg/allow-force
Allow CPU count check to be disabled using --force
2019-10-31 12:03:13 -07:00
tstromberg 9cfd2073ba Allow CPU count check to be disabled using --force 2019-10-31 11:28:34 -07:00
Thomas Stromberg 361222f606 Make network validation friendlier, especially to corp networks 2019-10-31 09:49:41 -07:00
tstromberg c34e865ab6 Improve warning message 2019-10-30 14:06:39 -07:00
tstromberg e8be75c74a Warning -> Warningf 2019-10-30 14:06:05 -07:00
tstromberg 4ce2f784f1 Fix failure issues with integration testing for service command 2019-10-30 13:57:08 -07:00
tstromberg 2c0f2a42dd Append newline to --url output 2019-10-30 12:35:25 -07:00
tstromberg f60764b07f service: fix --url mode, add integration tests 2019-10-30 10:44:54 -07:00
Thomas Strömberg ef398338d6
Merge pull request #5530 from medyagh/NewCmdRunner
Refactor command runner interface, allow stdin writes
2019-10-29 22:26:14 -07:00
Priya Wadhwa 169c3e7479 Add skeleton for performance scanning service
This service runs in a VM and is responsible for:

1. Determining which PRs need to be analyzed
2. Running mkcmp against each PR
3. Commenting the results on the PR via minikube-bot

This PR also moves the mkcmp code into its own directory.
2019-10-29 13:53:49 -07:00
Thomas Strömberg 74a5d477f2
Merge pull request #5718 from nanikjava/f-fix-test-disable-browser-test
Refactor to remove opening browser and just return url(s)
2019-10-29 13:51:33 -07:00
Thomas Strömberg b4ce29d589
Merge pull request #5757 from priyawadhwa/wait_false
Set --wait=false to default but still wait for apiserver
2019-10-28 21:52:15 -07:00
Nanik T 994d093766 Add boolean to disable opening browser during test
The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.

The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window
2019-10-29 13:23:41 +11:00
Priya Wadhwa bd5840aacf improve comments 2019-10-28 18:02:45 -07:00