3d72152953
fixing lint and other random incorrect stuff
2020-02-24 17:28:10 -08:00
be9c5f4761
pass in the node object into add
2020-02-24 15:58:35 -08:00
7596b39607
addres PR review
2020-02-24 15:10:34 -08:00
9a3ecab61a
fixed more stuff
2020-02-24 15:09:04 -08:00
850169764c
improve message
2020-02-24 14:51:45 -08:00
2e261d3d00
add not implemented messages for docker on mac service
2020-02-24 14:41:34 -08:00
d7ee8bfd37
patch
2020-02-24 11:31:53 -08:00
5fe81c806d
Merge pull request #6460 from josedonizetti/kic-darwin-tunnel
...
WIP: kic darwin tunnel
2020-02-24 11:28:00 -08:00
8cfc825641
fixes profile switch to non-existing one
2020-02-24 17:49:25 +05:30
f22efd871a
mostly moving code around and adding UpdateNode
2020-02-23 22:41:08 -08:00
4af82913e1
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-02-23 09:31:00 -08:00
727beb6893
Merge pull request #6744 from kppullin/docker-env-fish-fix
...
Generate fish compatible docker-env hint
2020-02-22 18:42:08 -08:00
fa9f7f9794
Add comments to avoid warnings from go lint
2020-02-22 16:12:42 +01:00
8d78c95aea
Generate fish compatible docker-env hint
...
`fish`'s eval handling does not properly process multiple lines.
Instead the recommendation is to pipe the output to `source`.
This PR updates the usage hint of the `docker-env` command
when running on `fish`:
```
eval (minikube -p fish docker-env) => (minikube -p fish docker-env) | source
```
Ref: https://github.com/fish-shell/fish-shell/issues/3993
Signed-off-by: Kevin Pullin <kevin.pullin@gmail.com>
2020-02-21 17:11:43 -08:00
6e9cf2de2f
Change MachineConfig to ClusterConfig
2020-02-21 16:09:05 -08:00
ec191119df
let's move some start code around
2020-02-21 15:46:02 -08:00
bc2a7aec8b
Adjust assert statements
2020-02-22 07:31:49 +11:00
1d0267f23c
Fix unit test
2020-02-22 07:18:16 +11:00
4d9730137f
improve logging
2020-02-20 21:56:23 -08:00
7c1c0ebb02
more error logging
2020-02-20 21:41:21 -08:00
67e9c9ab85
log errors in unit test
2020-02-20 21:41:21 -08:00
e6d70210af
add error wrpaps for config set
2020-02-20 21:41:21 -08:00
7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
...
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
c6313bb7ff
better error message
2020-02-20 09:47:45 -08:00
31cf3f2d79
missing err check
2020-02-20 09:47:10 -08:00
78c192cb40
lint
2020-02-20 00:07:36 -08:00
dcff758753
lint
2020-02-20 00:07:36 -08:00
4fe9ca5f05
break done delete and prune into two funcs better error handling
2020-02-20 00:07:36 -08:00
8d45b236de
less ambigous error log
2020-02-20 00:07:36 -08:00
d84aa9f447
lint
2020-02-20 00:07:36 -08:00
b1d139c24b
code review comments
2020-02-20 00:07:35 -08:00
d3b86cfeb9
improve logging
2020-02-20 00:07:35 -08:00
efd4aabde4
clean up containers first then delete volume
2020-02-20 00:07:35 -08:00
b235255196
fix volume clean up
2020-02-20 00:07:35 -08:00
8700f8a1e0
Merge pull request #6700 from medyagh/resource_limit
...
fix inverted logic for resource logic
2020-02-19 23:57:16 -08:00
0af5734bc9
Merge pull request #6696 from priyawadhwa/install-addons
...
Fix bug in --install-addons flag
2020-02-19 22:33:50 -08:00
cc0caac415
mount display bind address to user
2020-02-19 22:08:50 -08:00
b65c2fef09
fix typo
2020-02-19 22:01:46 -08:00
ce89a04278
specify localhost mount for binding for docker on mac
2020-02-19 22:01:46 -08:00
ec7c6ba4fa
fix inverted logic
2020-02-19 21:33:24 -08:00
5ad4d6ebf5
Fix bug in --install-addons flag
...
Respect --install-addons flag, don't install anything if it is false
2020-02-19 14:56:09 -08:00
8536fb7641
changes and things
2020-02-19 12:53:59 -08:00
089deef706
Do not create profiles that do not exist
2020-02-18 05:59:37 -05:00
1da0a370ff
code review comments
2020-02-17 10:55:53 -08:00
2bfcb72b96
Remove not used code
2020-02-17 10:22:11 -03:00
23ef3f6d16
lint
2020-02-16 19:51:59 -08:00
b0d19e51b5
Refactor kic ssh tunnel
2020-02-14 21:01:32 -03:00
0d11e4e348
Add error checking to kic cmd/tunnel
2020-02-14 13:22:56 -03:00
c421e156b6
Fix tunnel cmd to pass context to kic tunnel
2020-02-14 12:51:04 -03:00
a007c0790c
Delete volumes created by kic
2020-02-14 01:39:16 -08:00
c1a3e4348d
fix unit tests and fix merge conflicts
2020-02-13 10:30:12 -08:00
2785d292f5
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-02-13 10:15:04 -08:00
25167e1b75
Fix docker-env and add unit and integration tests ( #6604 )
...
* Fix docker cert env in docker-env for docker driver
* add unit tests
* add integration tests for docker-env cmd
* lint
* fix lint
* merge conflict
* improve docker-env integraiton test
* linting
2020-02-13 02:17:11 -07:00
8c55c9ca60
holy crap cyclical import hell sucks
2020-02-12 18:34:44 -08:00
398c7ef00b
Add podman driver ( #6515 )
2020-02-12 19:11:44 -07:00
af353314e0
Separate cached kubernetes binaries by OS on host machine ( #6586 )
...
* Separate cached kubernetes binaries by OS on host machine
This way, all kubernetes binaries stored in ~/.minikube/cache/linux will be copied over to the VM and used for `minikube kubectl` on linux machines. kubectl will be stored in `~/.minikube/cache/{windows or darwin}` on windows/darwin so that `minikube kubectl` still works.
* Review comment
* Update integration test
* Make sure --download-only includes OS specific kubectl
Update integration test to make sure we download
OS specific kubectl on darwin/windows when using --download-only flag
2020-02-11 23:23:37 -07:00
b427dc5663
fixed commands, they mostly work now
2020-02-11 21:11:22 -08:00
9830d91c09
linting nonsense
2020-02-11 18:39:59 -08:00
744efaa330
REFACTOR COMPLETE?
2020-02-11 17:06:59 -08:00
b6a429dc9d
hey did you want more files? good
2020-02-11 15:45:49 -08:00
f2ebbb9c67
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-02-11 09:44:10 -08:00
69aa54ff82
begin start refactor
2020-02-11 09:38:15 -08:00
ff763db1e7
Add podman-env for connecting with podman-remote ( #6351 )
...
* Refactor: add the docker vars after the shell vars
* Move shell handling functions to separate package
* Rename env source file to docker-env like command
* Add podman-env for connecting with podman-remote
* Remove leading Shell prefix from the shell package
* Add some documentation describing podman service
* Address some podman-env issues pointed out by lint
2020-02-10 22:59:37 -07:00
a283fd695a
Fix to kubeConfigPath could be set from env ( #6568 )
...
* Fix to kubeConfigPath could be set from env
Fix to use kubeConfigPath by using kubeconfig.PathFromEnv
function not from just $HOME/.kube/config
Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
* Delete redundant logic to get kubeConfigPath
- change to use already present util function
to set up kubeConfigPath
Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
Co-authored-by: SOPHAL HONG <hongsophal.hsp@gmail.com>
Co-authored-by: Woohyung Han <woohhan@gmail.com>
2020-02-10 16:08:07 -07:00
e18e4d083b
Fix `minikube start` in order to be able to start VM even if machine does not exist ( #5730 )
...
* fix startHost in order to be able to start VM even if machine does not exist
* Update func StartHost() and its unit test no to use config.GetMachineName()
* Add handle case when the kic image isn't pulled
2020-02-10 11:37:30 -07:00
239be7ed94
Create Hyper-V External Switch ( #6264 )
...
* Create and manager Hyper-V switch
* Adds new flag for Hyper-V driver
* Move switch creation out of chooseSwitch
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-02-07 21:22:19 -07:00
e1fc3ce734
let's rearrange some stuff
2020-02-07 17:00:24 -08:00
8762c48921
Merge pull request #6541 from anencore94/deleteContext
...
Fix to delete context when delete minikube
2020-02-07 16:15:56 -08:00
2c08f62ed2
Let DeleteContext determine the KUBECONFIG path
2020-02-07 15:34:31 -08:00
914e7de860
Merge pull request #6536 from tstromberg/wait-nada2
...
Add --install-addons toggle for users who don't want them
2020-02-07 11:47:24 -08:00
460f8d0187
Fix bug to delete context when delete minikube
...
- when `minikube delete`, minikube must delete its config which
are set when `minikube start`.
- But, there was some mistakes in the function that does this
logic
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2020-02-07 20:00:08 +09:00
c195d5a55f
Merge branch 'master' into powershell-env-bugfixes
2020-02-06 23:17:26 -08:00
10ef863f7d
Merge pull request #6527 from tstromberg/powershell-env
...
Bug-compatible refactor of docker-env + output tests
2020-02-06 21:57:25 -08:00
63954700d7
Address review comments
2020-02-06 17:32:08 -08:00
4ba0f52f57
Add flag to toggle installation of addons
2020-02-06 17:29:19 -08:00
5d59e83b64
Rewrite unsetScript to fix a variety of bugs
2020-02-06 17:01:05 -08:00
0cac457126
Transition TestGetNodeDockerEnvIPv6 to env_test
2020-02-06 16:05:05 -08:00
6e19c62896
Update tests to include all current output quirks
2020-02-06 15:54:57 -08:00
b478fbaa1a
Minimize changes
2020-02-06 15:40:24 -08:00
32bc0ff76a
Refactor docker-env for testability
2020-02-06 15:32:00 -08:00
f6f8b503c4
fill in cmd code
2020-02-06 13:38:42 -08:00
6ef60c1964
Add warnings back in
2020-02-06 13:27:49 -08:00
59ab0ba89e
Fix lint errors
2020-02-06 10:11:38 -08:00
9c70693e40
Revert whitespace change in docker-env output
2020-02-06 07:04:51 -08:00
eded9a17e1
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-02-05 17:39:54 -08:00
8d365fcb03
shuffling stuff around for import purposes
2020-02-05 17:39:47 -08:00
091db5ddb6
Remove kubeadm pull images
2020-02-05 16:23:19 -08:00
2ecc120b2b
Merge pull request #6503 from tstromberg/faster-dryrun
...
Skip driver autodetection if driver is already set
2020-02-05 13:48:42 -08:00
7c301ec27b
Merge branch 'master' into faster-dryrun
2020-02-05 12:05:43 -08:00
0d29a2ac7b
Merge branch 'master' into f-fix-5144
2020-02-05 11:32:32 -08:00
6d59d9d7df
Merge pull request #6200 from laozc/node-name
...
Use profile name as cluster/node name
2020-02-05 11:27:35 -08:00
80c0183f3d
Skip driver autodetect if driver is already set
2020-02-05 10:48:04 -08:00
8eb91989a9
Merge pull request #6492 from medyagh/obvious_denv
...
improve "docker-env" command to point to correct docker
2020-02-05 10:02:35 -08:00
4dda226e86
Merge pull request #6483 from karolz-ms/dev/karolz/azure-cr
...
Add Azure Container Registry support
2020-02-05 10:01:59 -08:00
5795b7f312
Merge branch 'master' into obvious_denv
2020-02-05 08:14:56 -08:00
0bd4099cfc
Merge pull request #5678 from priyawadhwa/compare
...
[mkcmp] add code to time `minikube start` for each binary
2020-02-04 20:49:59 -08:00
37fb10415b
Merge pull request #6237 from tstromberg/ssh-verify
...
Support --force for overriding the ssh check
2020-02-04 20:49:07 -08:00
dc0be4aed6
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-02-04 17:29:31 -08:00
12e53f4d1f
fix unit tests
2020-02-04 16:45:27 -08:00
435010a3fc
pass profilename for testability
2020-02-04 16:35:51 -08:00
eda1c76fe5
add kic tunnel (alpha)
2020-02-04 21:33:56 -03:00
c86b20ade2
add option to exec runner to point to host docker daemon
2020-02-04 15:33:04 -08:00
2d2b60f95b
fix lint
2020-02-04 15:12:55 -08:00
f41a10a98f
Fix up some unit tests
2020-02-04 15:01:40 -08:00
f6c7048392
use constants instead of hardcode
2020-02-04 13:30:23 -08:00
3937bae269
add new env var for docker-env command
2020-02-04 13:25:22 -08:00
a50ebb8c03
Merge pull request #6481 from medyagh/k_nslookup
...
try nslookup both ways
2020-02-04 06:59:48 -08:00
718ab997d5
spell
2020-02-03 17:11:35 -08:00
4f6deaf5dc
Rebased on master
2020-02-03 16:31:11 -08:00
3f939af4b4
Merge branch 'master' into addons-startup2
2020-02-03 16:17:33 -08:00
4a4e7b7859
Add Azure Container Registry support
2020-02-03 16:10:18 -08:00
b4c1db6e14
change wording VM to node
2020-02-03 15:11:12 -08:00
38a4a4ab8b
more inclusive nslookup
2020-02-03 15:09:25 -08:00
04df96880e
Merge branch 'master' into none-paused
2020-02-03 13:49:21 -08:00
bcc186b908
Startup previously enabled addons
2020-02-03 10:49:40 -08:00
f59a2891eb
Merge remote-tracking branch 'origin/master' into node-name
2020-02-03 19:16:57 +08:00
af2060a858
Move kubeconfig down as we cannot get an IP if host is down
2020-01-31 19:24:30 -08:00
edbe92fb01
Re-arrange status calls to extract maximum information without being confusing
2020-01-31 19:15:58 -08:00
1176aa468f
More status logging
2020-01-31 19:00:59 -08:00
6760929a72
Add logging of non-nil errors
2020-01-31 18:36:38 -08:00
eee5788ab3
Make deletion output more terse
2020-01-31 17:08:27 -08:00
ab93b27a70
Merge branch 'master' into none-paused
2020-01-31 16:38:00 -08:00
e206b25da5
Merge pull request #6440 from tstromberg/addons-on-startup
...
Add addon enablement to start
2020-01-31 16:25:30 -08:00
dd4ad10b83
Improve handling of paused none clusters.
2020-01-31 16:23:25 -08:00
40f2f7c28d
Promote Infofs to errors/warnings
2020-01-31 16:23:07 -08:00
b3149a1031
Allow 'profiles list' to work even if a profile has no control plane
2020-01-31 16:23:07 -08:00
7ebd01e113
Remove extra }
2020-01-31 14:55:24 -08:00
65fec571a5
Merge branch 'master' into ssh-verify
2020-01-31 14:53:13 -08:00
9b5044bfb2
Skip trySSH entirely if --force is set
2020-01-31 14:53:04 -08:00
15c6a8a028
Merge pull request #6450 from tstromberg/control-plane-err
...
Allow 'profiles list' to work even if a profile has no control plane
2020-01-31 14:43:12 -08:00
02902f7f4f
Merge pull request #6438 from tstromberg/nonexistent-status
...
status: Explicitly state that the cluster does not exist
2020-01-31 14:38:49 -08:00
723b074f65
Merge pull request #6409 from medyagh/plist_cr_info
...
add container runtime info to profile list
2020-01-31 14:38:25 -08:00
7d65ca31de
Promote Infofs to errors/warnings
2020-01-31 14:35:03 -08:00
3ebbe4f1fc
Allow 'profiles list' to work even if a profile has no control plane
2020-01-31 14:32:54 -08:00
c3aafaeeb4
Add IsNotExist() method to the config package, so that we can have meaningful error messages and make them comparable
2020-01-31 14:19:08 -08:00
d9860b1eb7
Update spacing
2020-01-31 12:58:53 -08:00
c8f5679986
Run gofmt/goimports on cmd/
2020-01-31 12:38:06 -08:00
78ed12265d
Add testing for Start function, make addon enablement testable
2020-01-31 12:19:25 -08:00
6cd3b41bc8
Fix spacing in vm driver selection log
2020-01-31 11:43:18 -08:00
ce68dd19b6
Merge branch 'master' into addons-on-startup
2020-01-31 08:23:21 -08:00
b97124207c
Move addon enablement to addons module + lint fixes
2020-01-30 17:46:25 -08:00
fefa13e9da
Remove some redundance words
...
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2020-01-31 08:25:27 +07:00
41687346e3
make it less than 80
2020-01-30 16:06:27 -08:00
d5a83c7b24
Add addon enablement to start
2020-01-30 15:54:04 -08:00
6bd48a86c9
Explicitly say that a cluster is nonexistent
2020-01-30 14:41:45 -08:00
4309de6e8e
Merge pull request #6431 from tstromberg/missing-status-test
...
Add missing status test
2020-01-30 13:05:39 -08:00
d454148990
Add missing status test
2020-01-30 10:16:43 -08:00
3cbe879d7e
node add works
2020-01-30 09:02:01 -08:00
593d3fc73e
moving packages around
2020-01-28 17:09:00 -08:00
178a3a256f
add container runtime info to profile list
2020-01-28 16:40:53 -08:00
317dd41138
moving node package around
2020-01-27 17:59:35 -08:00
8db7f59b1e
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-01-24 16:08:22 -08:00
9a49c587d5
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-01-24 15:54:04 -08:00
82e096a7a1
Merge pull request #6390 from medyagh/kic_bindip
...
kic driver: add multiple profiles and ssh
2020-01-24 15:45:51 -08:00
c6c0046c57
let docker/podman choose hostbind port
2020-01-24 14:15:48 -08:00
c4e390f95c
missed one file
2020-01-24 13:57:47 -08:00
58ba813a9c
controlplane and worker are bools now magiiiiic
2020-01-24 13:54:41 -08:00
0b460e6cb7
master is no longer a thing
2020-01-24 13:24:38 -08:00
ad03309ab6
Adding the initial node cmd and pkg files
2020-01-24 11:40:27 -08:00
9953cc2250
GetMasterNode -> MasterNode
2020-01-24 11:14:55 -08:00
dbeac1b08c
KubernetesConfig.ContainerRuntime
2020-01-24 10:53:18 -08:00
77d838d3d2
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-01-24 10:50:57 -08:00
a9bc13b403
Address pause code review feedback
2020-01-23 15:44:30 -08:00
6a01d6b25b
prefer getting master node over calling Nodes[0]
2020-01-23 13:26:50 -08:00
791f28ff4c
things work now
2020-01-23 13:21:21 -08:00
8b2a05a565
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-01-22 17:18:30 -08:00
1a13055d00
Add integration tests
2020-01-22 15:50:09 -08:00
22de8c110a
Return the number of containers paused
2020-01-22 15:07:44 -08:00
62a72f44e8
Address feedback
2020-01-22 14:21:34 -08:00
5f0420f72e
Merge branch 'master' into pause
2020-01-22 09:48:26 -08:00
e6999caea3
Add paused state to apiserver status
2020-01-22 09:48:16 -08:00
09b2780fb2
Add support for pausing/unpausing specific namespaces
2020-01-21 22:06:05 -08:00
875c4b2d76
Merge pull request #6338 from medyagh/unify_boots
...
unify bootstrappers for both VM and contianer
2020-01-21 20:34:17 -08:00
7e2e9eb15b
Merge conflicts
2020-01-21 20:00:21 -08:00
7f3351476c
Merge upstream
2020-01-21 19:50:49 -08:00
be65e4c2ad
Merge upstream
2020-01-21 19:46:42 -08:00
5a3c13815e
network overlay only for kic
2020-01-21 15:14:51 -08:00
e3bd383d64
Merge pull request #6255 from afbjorklund/kubectl-examples
...
Fix syntax of minikube kubectl example command
2020-01-20 19:36:05 -08:00
e0a8b7dba8
Merge pull request #6325 from afbjorklund/dashboard-crash
...
Stop minikube dashboard from crashing at start
2020-01-20 19:34:18 -08:00
a681f1f00f
Remove stray space from driver selection message
2020-01-20 21:18:34 +01:00
6b0c69986f
Merge remote-tracking branch 'origin' into node-name
2020-01-18 08:09:51 +08:00
774bd5f174
Merge branch 'm2' of github.com:sharifelgamal/minikube into m2
2020-01-17 15:45:11 -08:00
df3dc976b0
let's actually save the node config
2020-01-17 15:44:56 -08:00
0b2d8051bb
remove kicbs
2020-01-17 15:44:22 -08:00
01f6cefd2a
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-01-17 13:28:53 -08:00
9b455aafc4
Customizing host path for dynamically provisioned PersistentVolumes
...
This fix contains few things:
* Used k8s.gcr.io/debian-base-amd64:v2.0.0 as base image to build storage-provisioner
* Modify RBAC permission used to cluster-admin
* Build storage-provisioner as static binary
2020-01-16 12:23:26 +11:00
010d0d4091
adding experimental string to driver detection string
2020-01-15 16:22:48 -08:00
d0fb749842
add displaysupporteddrivers func
2020-01-15 16:03:37 -08:00
a13ea9bea0
add the ability to mark drivers as experimental and mark the docker driver as such
2020-01-15 15:21:47 -08:00
b7f3ff7ead
Stop minikube dashboard from crashing at start
...
If the profile does not exist, it cannot load
2020-01-15 21:32:40 +01:00
804ee14a95
removing node surface stuff for a different PR
2020-01-15 11:36:36 -08:00
dc6c9d7d75
cfg config fun
2020-01-14 16:49:13 -08:00
2c301bd4ef
more node changes yay
2020-01-14 14:25:20 -08:00
2813cf4120
Merge branch 'master' of github.com:sharifelgamal/minikube into m2
2020-01-14 13:44:40 -08:00
71b561e344
Add note to remember to end the minikube flags
...
And add some whitespace before the next section
2020-01-14 18:22:45 +01:00
f645850842
add example to tunnel help
2020-01-13 16:16:36 -08:00
8718a54d91
Merge pull request #6256 from tstromberg/dry-run
...
Add --dry-run option to start
2020-01-13 13:37:15 -08:00
2e3d3e0add
Merge pull request #6274 from medyagh/add_table
...
Improve "addon list" by viewing as a table
2020-01-13 12:54:51 -08:00
f5ce7d9e74
Merge pull request #6292 from afbjorklund/profile-version
...
Handle empty k8s version in existing profile
2020-01-13 12:50:14 -08:00
13e2a3e601
Merge pull request #6276 from tstromberg/qemu-system
...
Pass --kvm-qemu-uri value into kvm2 health check
2020-01-13 11:16:07 -08:00
94b03ff881
Handle empty k8s version in existing profile
2020-01-13 18:33:59 +01:00
1085d47a24
Pass in the value of *kvmQemuURI for behavioral consistency
2020-01-10 16:07:07 -08:00
6c7cadb371
make minikube addons list tabular
2020-01-10 15:39:22 -08:00
75082b6f7e
Merge pull request #6242 from afbjorklund/platform-arch
...
Only print the virtualization system if it exists
2020-01-10 10:39:26 -08:00
19c8ddee9f
Merge pull request #6151 from medyagh/kic_exp
...
Experimental verison of kic
2020-01-10 00:42:01 -08:00
b840d1ced0
Call goimports
2020-01-09 11:58:15 -08:00
7acf688f7a
Merge master
2020-01-09 11:13:25 -08:00
c5e917366f
Add --dry-run option to start
2020-01-09 11:10:23 -08:00
3207b27c11
Fix syntax of minikube kubectl example command
...
Need to terminate the minikube flags with --,
before starting with the kubectl command flags.
2020-01-09 19:52:58 +01:00
4a1f33e282
Adds cluster name to kubenetes config
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 20:00:40 +08:00
0512882520
Do not set host-override for kubelet by default
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-09 19:52:30 +08:00
40a011c49a
use api port for host binding port
2020-01-08 16:09:24 -08:00
cf9e6e512f
fix ineffectual assignment
2020-01-08 15:21:57 -08:00
039f53144a
Only print the virtualization system if it exists
...
Avoids output like (/arm64), with an extra slash
2020-01-08 23:06:59 +01:00
ddf5ab027a
add extra option fail swap for kic
2020-01-08 12:53:29 -08:00
5d8e9dbfc5
Support --force for overriding the ssh check
2020-01-08 11:23:15 -08:00
f46e11f14a
Fixes busybox nslookup does not support queryt type
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 22:31:45 +08:00
be7b52791a
Remove unused var
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 15:41:07 +08:00
96398c73ad
Merge remote-tracking branch 'origin/master' into node-name
2020-01-08 14:45:21 +08:00
d3ff888743
Use profile name as the node name
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-08 14:42:17 +08:00
f80572bb4c
code review
2020-01-07 13:59:41 -08:00
618b150bcd
fix setup kubeconfig for kic
2020-01-07 13:54:00 -08:00
d298593d8a
refactor api server verification
2020-01-07 13:54:00 -08:00
e9b7451278
auto set podsubnet for kic improve none auto set
2020-01-07 13:54:00 -08:00
860ce25bf2
Add podSubnet to templates
2020-01-07 13:54:00 -08:00
c7bc61af2c
Add overlay network for kic
2020-01-07 13:54:00 -08:00
6cf2554877
add flag for kic host binding port
2020-01-07 13:54:00 -08:00
a358aff093
fix ocibinary
2020-01-07 13:52:47 -08:00
19e7ea4c40
Merge pull request #6217 from tiendc/unit_test_config_get
...
Add unit test for cmd/minikube/cmd/config/get.go
2020-01-07 11:48:11 -08:00
d23b446d2e
Merge pull request #6218 from afbjorklund/reportcard-minor
...
Improve reportcard by refactoring and commenting
2020-01-07 11:42:55 -08:00
60f514c0a5
Add unit test for cmd/minikube/cmd/config/set.go
...
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
2020-01-07 14:02:05 +07:00
af4ee5cf1f
Merge pull request #6124 from priyawadhwa/addon-per-profile-refactor
...
Enable or disable addons per profile
2020-01-06 16:33:01 -08:00
ea7a2d7e33
Improve reportcard by refactoring and commenting
...
golint: 99%
pkg/minikube/localpath/localpath.go
Line 64: warning: comment on exported function SanitizeCacheDir should be of the form "SanitizeCacheDir ..." (golint)
gocyclo: 99%
pkg/minikube/cluster/cluster.go
Line 422: warning: cyclomatic complexity 16 of function createHost() is high (> 15) (gocyclo)
cmd/minikube/cmd/start.go
Line 276: warning: cyclomatic complexity 18 of function runStart() is high (> 15) (gocyclo)
Line 742: warning: cyclomatic complexity 18 of function validateFlags() is high (> 15) (gocyclo)
2020-01-06 13:39:55 +01:00
743c67d40e
Add unit test for cmd/minikube/cmd/config/get.go
...
Signed-off-by: Dao Cong Tien <tiendc@vn.fujitsu.com>
2020-01-06 18:49:31 +07:00
81622e2a00
Minor: change assignment to declaration
...
"warning: ineffectual assignment to updated (ineffassign)"
2020-01-04 10:23:16 +01:00
73608d60e4
Set node name the same as host name by default for none driver
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-03 00:32:05 +08:00
914c34cc2a
Set node name in non-default profile
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-01 13:45:05 +08:00
f9ed4a6460
Allow user to override node name
...
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-01-01 13:45:03 +08:00
e47cde6ae4
Rebased on master, moved istio addon into new package
2019-12-30 10:10:05 -05:00
df9cac8f94
Merge pull request #6154 from fenglixa/add-istio
...
Add istio addon for minikube
2019-12-27 11:54:44 -08:00
c2ba574f2e
generate istio document page and layout
2019-12-26 14:35:13 +08:00
f42c8a49fb
fixed comment
2019-12-21 18:34:40 +07:00
76714aca84
implemented options command #5036
...
This is to fix help command showing invalid "minikube <command> options".
It happened because minikube reuses kubectl templates which expects
options cmd to be there.
2019-12-21 11:09:36 +07:00
d5f56477bc
code review resolve
2019-12-20 17:14:14 -08:00
3b2cfa6c32
rename funcs
2019-12-20 16:53:35 -08:00
83cd426436
refactor more
2019-12-20 16:11:05 -08:00
cf6bde8eaf
refactor image specific funcs to image package
2019-12-20 16:05:08 -08:00
be8a1ad107
resolve code reviews
2019-12-20 12:43:13 -08:00
6c25cd3848
Rebased on master
2019-12-20 12:34:48 -08:00
5eb384cf7d
check error and fix logging msg
2019-12-20 12:24:05 -08:00
Sharif Elgamal
Medya Gh
Medya Ghazizadeh
vikkyomkar
Anders F Björklund
Kevin Pullin
sayboras
Priya Wadhwa
aallbright
Jose Donizetti
anencore94
go_vargo
Zhongcheng Lao
Thomas Strömberg
anencore94
Karol Zadora-Przylecki
Kim Bao Long
Nanik T
Dao Cong Tien
fenglixa
andylibrian