3d0f486d84
add integration test for --no-kubernetes
2021-11-03 14:08:01 -07:00
f0f1819123
output empty addons objects on JSON
2021-11-03 10:12:41 -07:00
79f1b8c55c
add --no-kubernetes flag to start minikube without kubernetes
2021-11-02 15:41:40 -07:00
3342d3aa34
Merge pull request #12811 from nbusseneau/pr/fix-virtualbox-ip
...
virtualbox: change default `host-only-cidr`
2021-11-02 13:38:16 -07:00
9dde4cb9c1
Merge pull request #12841 from Keyhoh/issue/refix-11348
...
fix zsh completion
2021-11-02 11:41:23 -07:00
02a43c52e2
virtualbox: change default `host-only-cidr`
...
We change the default `--host-only-cidr` to `192.168.59.1/24` in order
to be compatible with the new default host-only networking restrictions
implemented in VirtualBox 6.1.28.
This fixes access denied errors on `minikube start` when using
VirtualBox >= 6.1.28:
```
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
```
More details:
VirtualBox 6.1.28 introduced new restrictions on host-only networking:
https://www.virtualbox.org/wiki/Changelog-6.1#v28
Manual: https://www.virtualbox.org/manual/ch06.html#network_hostonly
> On Linux, Mac OS X and Solaris Oracle VM VirtualBox will only allow IP
> addresses in 192.68.56.0/21 range to be assigned to host-only
> adapters. For IPv6 only link-local addresses are allowed. If other
> ranges are desired, they can be enabled by creating
> /etc/vbox/networks.conf and specifying allowed ranges there. For
> example, to allow 10.0.0.0/8 and 192.168.0.0/16 IPv4 ranges as well as
> 2001::/64 range put the following lines into /etc/vbox/networks.conf:
>
> * 10.0.0.0/8 192.168.0.0/16
> * 2001::/64
>
> Lines starting with the hash # are ignored. Next example allows any
> addresses, effectively disabling range control:
>
> * 0.0.0.0/0 ::/0
These new restrictions manifest in the form of the following issue on
`minikube start` due to the default `--host-only-cidr` used by the
VirtualBox driver being `192.168.99.1/24`:
```console
😄 minikube v1.23.2 on Ubuntu 18.04
✨ Using the virtualbox driver based on user configuration
👍 Starting control plane node minikube in cluster minikube
🔥 Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🔥 Deleting "minikube" in virtualbox ...
🤦 StartHost failed, but will try again: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet0 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
🔥 Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
😿 Failed to start virtualbox VM. Running "minikube delete" may fix it: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet1 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
❌ Exiting due to GUEST_PROVISION: Failed to start host: creating host: create: creating: Error setting up host only network on machine start: /usr/bin/VBoxManage hostonlyif ipconfig vboxnet1 --ip 192.168.99.1 --netmask 255.255.255.0 failed:
VBoxManage: error: Code E_ACCESSDENIED (0x80070005) - Access denied (extended info not available)
VBoxManage: error: Context: "EnableStaticIPConfig(Bstr(pszIp).raw(), Bstr(pszNetmask).raw())" at line 242 of file VBoxManageHostonly.cpp
╭───────────────────────────────────────────────────────────────────────────────────────────╮
│ │
│ 😿 If the above advice does not help, please let us know: │
│ 👉 https://github.com/kubernetes/minikube/issues/new/choose │
│ │
│ Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue. │
│ │
╰───────────────────────────────────────────────────────────────────────────────────────────╯
```
While the above is the primary error, other errors will be reported if
the adapter already exists (this happens when the adapter was created
before updating to VirtualBox 6.1.28, on a version of VirtualBox without
the new restrictions). Some examples:
```
❌ Exiting due to IF_VBOX_NOT_VISIBLE: Failed to start host: creating host: create: creating: Error setting up host only network on machine start: The host-only adapter we just created is not visible. This is a well known VirtualBox bug. You might want to uninstall it and reinstall at least version 5.0.12 that is is supposed to fix this issue
```
```
❌ minikube is unable to connect to the VM: dial tcp 192.168.99.112:22: i/o timeout
This is likely due to one of two reasons:
- VPN or firewall interference
- virtualbox network configuration issue
Suggested workarounds:
- Disable your local VPN or firewall software
- Configure your local VPN or firewall to allow access to 192.168.99.112
- Restart or reinstall virtualbox
- Use an alternative --vm-driver
- Use --force to override this connectivity check
❌ Exiting due to GUEST_PROVISION: Failed to validate network: dial tcp 192.168.99.112:22: i/o timeout
```
When switching to a valid CIDR, `minikube start` works as usual:
```console
😄 minikube v1.23.2 on Ubuntu 18.04
✨ Using the virtualbox driver based on user configuration
👍 Starting control plane node minikube in cluster minikube
🔥 Creating virtualbox VM (CPUs=2, Memory=6000MB, Disk=20000MB) ...
🐳 Preparing Kubernetes v1.22.2 on Docker 20.10.8 ...
▪ Generating certificates and keys ...
▪ Booting up control plane ...
▪ Configuring RBAC rules ...
▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎 Verifying Kubernetes components...
🌟 Enabled addons: storage-provisioner, default-storageclass
🏄 Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
```
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
2021-11-02 15:30:46 +01:00
ca928b43ed
fix: revert wrong fix and re-fix zsh completion
2021-11-02 22:57:43 +09:00
4c4adff43a
add tests
2021-11-01 17:39:46 -07:00
389ea688ff
`minikube addons list` shows addons if cluster does not running
2021-11-01 12:44:44 -07:00
6f72fc9a25
Merge pull request #12578 from AliyunContainerService/aliyun-mirror
...
Initial support for adding Aliyun mirror for preload images and K8s release binaries
2021-10-26 13:22:30 -07:00
c8cb7a3c2d
delete older minikube version preload files on start tup
2021-10-21 14:54:14 -07:00
d7decc2a8d
persist mount settings after stop
2021-10-18 15:40:48 -07:00
c073e65c6d
Merge pull request #12716 from spowelljr/fixHyperVStop
...
Kill mount process before stopping nodes
2021-10-18 14:33:09 -07:00
21d08dd0ed
remove duplicated update of MinikubeISO
2021-10-16 13:34:06 +02:00
99661e64a3
Merge pull request #12711 from spowelljr/fixMount
...
Fix mounting on non-default profile
2021-10-15 12:57:24 -07:00
645b739d88
kill mount before stopping nodes
2021-10-15 10:52:39 -07:00
0fcf1eddec
remove unnecessary join
2021-10-15 09:14:18 -07:00
9a89855997
add backwards compatible mount-process delete
2021-10-14 16:01:59 -07:00
2a489bf7e1
fix mounting on non-default profile & make mounting processes cluster independent
2021-10-14 14:44:51 -07:00
2f0e883e60
make options command discoverable in minikube help
2021-10-14 13:15:06 -04:00
4535640b63
Support changing apiserver-ips when restarting minikube
...
After commit bee6815Fixes #9818
2021-10-11 05:28:30 -04:00
70022d9b2e
Move from deprecated ioutil to os and io packages
2021-10-08 08:57:19 +08:00
7f827f93b3
Merge pull request #11752 from RA489/fix_ui
...
Minikube stop - correct the number of stopped nodes
2021-10-06 12:59:18 -04:00
ce2602c157
Minikube stop - correct the number of stopped nodes
2021-10-06 09:35:34 +05:30
4c6f03c376
Merge pull request #12246 from spowelljr/fixMinikubeLogsWindows
...
Don't error if we can't retrieve logs from a pod during `minikube logs`
2021-10-01 09:58:32 -07:00
a502d3e2e1
Merge pull request #12420 from Keyhoh/issue/11348
...
fix issue #11348 zsh completion broken
2021-09-28 18:41:58 -07:00
1976f71548
fix: zsh completion broken
2021-09-29 06:21:33 +09:00
25b73c79f9
add back warning output
2021-09-28 10:20:10 -07:00
2fd09e11a8
Merge pull request #12149 from afbjorklund/build-cp
...
Build images on the primary control plane
2021-09-27 19:11:04 -07:00
f85e7db048
Merge pull request #12233 from kadern0/issue-10495
...
Added port validation
2021-09-27 15:56:03 -07:00
4e1bcc06ce
Fixed error exit. Added docs
2021-09-28 08:43:19 +10:00
eb66c6797e
Initial support for adding Aliyun mirror for preload images and Kubernetes binaries
...
Signed-off-by: Li Yi <denverdino@gmail.com>
2021-09-26 15:36:36 +08:00
4307e834df
address review comments
2021-09-24 11:47:10 -07:00
e7723c79dd
return 0 exit code if failed to get container logs
2021-09-23 13:22:31 -07:00
77051a35df
make sure to set expiration if not in existing config
2021-09-22 11:22:08 -07:00
1212848649
make cert expiration configurable and add test
2021-09-21 16:17:52 -07:00
f21263390c
add warning for ambassador addon
2021-09-14 14:01:07 -07:00
9f96701d8f
Merge pull request #12458 from minikube-bot/auto_bump_golint_version
...
bump golint version
2021-09-13 16:30:45 -07:00
145f9fc9ab
run `go fmt`
2021-09-13 11:58:43 -07:00
96923883e7
fixes for ingress
2021-09-09 13:47:01 -07:00
3e25ee3dfe
Merge pull request #12381 from jayesh-srivastava/master
...
Updated version.go with crun version
2021-09-09 10:51:33 -07:00
9d940e234f
ask user for config values even if already set
2021-09-08 12:19:48 -07:00
738eb5177c
Merge pull request #12231 from sharifelgamal/gcp-cs
...
gcp-auth: improve flow for GCE/Cloud Shell
2021-09-01 13:20:06 -07:00
3469c77ffa
Merge pull request #12351 from raghavendra-talur/rtalur-add-disks-kvm2
...
Add `--extra-disks` capability to kvm2 driver
2021-08-30 16:50:58 -07:00
69a5a9383c
Refactored code into functions. Added tests
2021-08-31 09:16:37 +10:00
eb78bb7602
Update version.go
2021-08-30 23:23:30 +05:30
323225483e
Support Rootless Docker
...
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/
Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.
Closes issue 10836 ("add support for rootless Docker").
Support for rootless Podman (issue 8719) is not covered in this commit.
---
Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
instead of `overlayfs` snapshotter
- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint
2021-08-27 17:21:53 +09:00
55c40f8220
Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs
2021-08-26 13:32:10 -07:00
527a3d920f
Merge pull request #12265 from prezha/fix-image-save-cmd
...
fix image save cmd
2021-08-25 10:45:08 -07:00
dceb676527
Add extra disks capability to kvm2 driver
...
Having additional disks on the nodes is a requirement for developers
working on the storage components in Kubernetes. This commit adds the
extra-disks feature to the kvm2 driver.
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
2021-08-25 00:15:02 -04:00
01155b1537
Merge pull request #12319 from andriyDev/UseWSLIP
...
Select WSL VM IP when performing mounting
2021-08-24 10:40:32 -07:00
6efbd1ce13
merge
2021-08-24 04:20:52 +01:00
42d3f3b92f
Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs
2021-08-23 15:40:30 -07:00
8470a955db
error handling\!
2021-08-23 14:06:23 -07:00
32577cc801
Merge branch 'master' of github.com:kubernetes/minikube into cs-start-stop
2021-08-23 14:02:24 -07:00
4bc5cb77d1
Merge branch 'master' of github.com:sharifelgamal/minikube into gcp-cs
2021-08-23 11:11:16 -07:00
817f8b4b70
Add also stand-alone image push matching pull
...
Normally this is done as part of image build
2021-08-22 20:11:19 +02:00
380b846715
Add stand-alone image pull and image tag commands
...
Needed for testing, but maybe elsewhere as well
2021-08-22 19:52:07 +02:00
fe6cbc4e42
add extra options to minikube start directly
2021-08-20 15:34:53 -07:00
69d5d34eeb
Merge pull request #12089 from zhan9san/feature/ingress-mac
...
Support Ingress on MacOS, driver docker
2021-08-20 15:16:13 -07:00
405235908d
Fix lint.
2021-08-20 15:06:24 -07:00
47afdc87df
Add logging message incase someone tries to debug.
2021-08-20 11:42:17 -07:00
2f094d117d
Use WSL VM IP for mounting in WSL.
2021-08-20 11:41:44 -07:00
def3f067a8
Support Ingress on MacOS, driver docker
2021-08-17 10:27:21 +08:00
9e588e6ba1
Add stand-alone image pull and image tag commands
...
Needed for testing, but maybe elsewhere as well
2021-08-15 20:22:24 +02:00
1f83aa3ac2
Added port validation
2021-08-14 15:48:56 +10:00
68197de861
Add command to save images from the cluster
...
This is the opposite command of "minikube image load",
and can be used after doing a "minikube image build".
The default is to save images in the cache, but it is
also possible to save to files or to standard output.
2021-08-13 23:28:25 +01:00
5bd3f9a79c
Add tests for the new docker-env output formats
2021-08-13 23:32:03 +02:00
4f8adb6f6d
Add output parameter to the docker-env none shell
...
Allows structured output as json and yaml, in addition to the
previous text output format. Note that keys might not be sorted.
2021-08-13 23:31:05 +02:00
235d7e8280
Merge branch 'master' of github.com:kubernetes/minikube into gcp-cs
2021-08-13 14:15:31 -07:00
371becaf73
tMerge branch 'master' of github.com:kubernetes/minikube into gcp-cs
2021-08-13 14:08:23 -07:00
0bd906077f
Revert "new `image save` command"
2021-08-13 14:06:42 -07:00
06ed3378b9
create special error to skip addons without erroring out
2021-08-13 13:42:02 -07:00
41ba49d597
Merge pull request #12162 from afbjorklund/image-save-cmd
...
Image save command
2021-08-13 13:02:58 -07:00
6aa7abc24a
fix lint issues on master
2021-08-12 17:38:24 -07:00
b75bf27942
Add command to save images from the cluster
...
This is the opposite command of "minikube image load",
and can be used after doing a "minikube image build".
The default is to save images in the cache, but it is
also possible to save to files or to standard output.
2021-08-10 09:49:23 +02:00
2ab5c86a88
Build images on the primary control plane
...
Allow selecting another node using --node
Or continue build on all nodes with --all
2021-08-06 19:04:51 +02:00
6e571d830f
Show data with keys sorted instead of random
2021-08-01 10:23:46 +02:00
4f6ee47f28
Remove extra output lines after the version
...
Some commands, like crio and runc, dump extra line noise
after the --version even though they have a long version.
2021-08-01 10:23:42 +02:00
46c3797169
Show cli versions instead of daemon versions
...
Since the server daemon might not be running
This affects docker and containerd runtimes
2021-08-01 10:22:05 +02:00
8f05ee00e1
Add ability to create extra disks on hyperkit vms
...
Add the ability to create and attach extra disks to hyperkit vms.
Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
2021-07-28 09:57:20 -06:00
3375c39c76
Merge pull request #11981 from de-sh/vb-warn
...
Add message to discourage the use of the virtualbox driver
2021-07-26 17:30:38 -07:00
7cda4bb986
Fix lint error.
2021-07-25 15:27:05 -07:00
5caf53c004
Cleanup ticker allocations.
2021-07-25 15:14:21 -07:00
36cc7e0a70
Have cluster.Mount return an error which is checked in advice.go.
2021-07-22 10:38:57 -07:00
49cd3840d3
Create advice for mount command timing out.
2021-07-14 15:38:04 -07:00
354fedb073
Add command-line argument port for mount cmd.
2021-07-14 15:00:03 -07:00
0e665930e8
Add message to discourage the use of virtualbox driver
2021-07-14 15:00:22 +05:30
0c721cbacd
remove whitespace
2021-07-12 20:23:07 +02:00
a60b337237
fix an issue with hasPorts variable - further simplification
2021-07-12 20:15:21 +02:00
6ccc6e7659
Merge branch 'master' into mytests
2021-07-12 19:57:21 +02:00
961bbbe0aa
Merge pull request #11553 from zigarn/dashboard-set-port
...
Allow to set the dashboard proxyfied port
2021-07-12 16:53:32 +00:00
cabf73ed59
Merge pull request #11800 from mahalrs/simplify-error-codes-11786
...
Simplify, and remove all un-used minikube error codes
2021-07-06 19:48:12 -04:00
12f2d69259
Merge remote-tracking branch 'upstream' into mytests
2021-07-06 12:13:06 +02:00
e63b223be9
Add dashboard port validation
2021-07-03 15:59:59 +02:00
f76b0795d8
Allow to set the dashboard proxyfied port
2021-07-03 15:59:59 +02:00
f684ae4c5e
Merge pull request #11875 from mahalrs/flag-typo
...
Fix typo in pause command
2021-07-02 17:14:42 +00:00
cd1db56f87
Fix typo in unpause command
2021-07-01 22:19:37 -07:00
75422a844c
Fix typo in pause command
2021-07-01 16:23:07 -07:00
494a24abcc
Merge pull request #11834 from andriyDev/AutoPause
...
Add support for other container runtimes for auto-pause
2021-07-01 16:01:27 -07:00
659e8c2785
Replace InternalEnable and InternalDisable with InternalAddonEnable and InternalAddonDisable
2021-07-01 14:52:24 -07:00
85e27c5820
Merge pull request #11773 from sharmarajdaksh/add-error-code-explanations
...
Adds explanations for all minikube error codes
2021-07-01 14:33:15 -07:00
574cdb9587
Add --container-runtime flag to auto-pause.
2021-07-01 13:11:12 -07:00
61e06d77bd
fix boilerplate
2021-07-01 15:21:32 -04:00
f35d99a2bb
add --components flag for verion command
2021-07-01 15:21:30 -04:00
99ba231b50
Merge pull request #11819 from spowelljr/fixKubectlDirectCall
...
windows: support renaming binary to `kubectl.exe` and running as kubectl
2021-07-01 11:03:04 -07:00
d8adc48463
Adds explanations for minikube error codes
2021-07-01 23:22:23 +05:30
fdca7d6844
support renaming binary to kubectl.exe and running as kubectl
2021-06-30 20:41:11 +00:00
89c7853601
bump go mod libs manually
2021-06-29 15:24:59 -04:00
e8b3db9485
Merge pull request #11692 from spowelljr/addNoLimit
...
Add ability to pass 'max' value to memory and cpus flags
2021-06-28 17:09:32 +00:00
512ae30449
Merge pull request #11753 from andriyDev/AddonMaintainers
...
Add maintainer column to addons list
2021-06-25 18:42:51 -04:00
cae8f40eaf
fixed validation for cpus
2021-06-25 10:49:29 -07:00
68cd71aea7
fix --cpus=max for non-KIC drivers
2021-06-25 10:49:28 -07:00
6799b19972
use constant for flag description
2021-06-25 10:49:28 -07:00
a2ae86cb7c
renamed flag value from nolimit to max
2021-06-25 10:49:28 -07:00
c2e2546f9b
fixed linting issues
2021-06-25 10:49:28 -07:00
4871d68d8c
add ability to pass nolimit value to memory and cpus flags
2021-06-25 10:49:28 -07:00
b5df84a707
Add maintainer column to addons list.
2021-06-24 10:11:38 -07:00
b2d46e51a1
Update message about running amd64 binary on M1
2021-06-21 18:38:47 -07:00
b10a7a1b9e
Merge branch 'master' into ilyaz/m1_amd64
2021-06-21 18:35:00 -07:00
cf4078ad1a
Merge pull request #11576 from JacekDuszenko/fix-embed-certs-from-config
...
Fix embed-certs global config
2021-06-21 11:33:11 -07:00
b9c363001d
Merge pull request #11668 from daehyeok/remove_config_options
...
Remove unused config options
2021-06-21 12:42:23 -04:00
c7c06e84f4
Merge pull request #11678 from RA489/regis_mirror
...
change registery_mirror to registery-mirror
2021-06-21 11:55:19 -04:00
811ff18161
Merge pull request #11677 from sharifelgamal/auto-gen-docs
...
Automatically run `make generate-docs` after every PR merge
2021-06-18 14:30:08 -07:00
cd1adcf35d
Remove unused config options
2021-06-18 11:54:47 -04:00
54d825068c
Merge pull request #11423 from vishjain/user/vishal/delete-profiles/main
...
Added Mock of Minikube Delete Profiles Test portion.
2021-06-17 13:02:18 -04:00
48709efc4d
change registery_mirror to registery-mirror
2021-06-17 15:15:04 +05:30
f7cb9286f6
only test for missing docs string
2021-06-16 10:06:11 -07:00
7b5381b697
add generate-docs script
2021-06-16 09:23:54 -07:00
32cd4cb12b
Allow running amd64 bianry on M1
2021-06-15 15:30:12 -07:00
4eb3c6332d
Fix a download link to use arm64 instead of amd64
2021-06-14 15:11:49 -07:00
b7a6dd0b5e
implement embed certs global config as EmbedCerts
2021-06-05 23:59:45 +01:00
8badb789e8
smaller documentation fix
2021-06-05 20:59:52 +02:00
445684d44d
fix(start): minikube start with --image-repository: add new test for URLs with ports, fixing fix validation logic
2021-06-05 20:50:00 +02:00
03b793c7d0
Fix names.
2021-06-05 11:18:07 -07:00
ebe03d7687
Added Mock to DeleteProfile Test.
2021-06-02 19:45:41 -07:00
36a6f87600
Added Mock of Minikube Delete Profiles Test portion.
2021-06-02 19:45:41 -07:00
d76259e86f
Merge pull request #11528 from andriyDev/FixDownloadOnlyTest2
...
Change PreloadExists to report no preload for BareMetal drivers
2021-06-02 12:59:15 -07:00
343015001a
Merge pull request #11504 from ilya-zuyev/ilyaz/fix_delete_paused
...
Fix delete command for paused kic driver with containerd/crio runtime
2021-06-01 13:14:05 -07:00
31417806b7
Merge pull request #11486 from sharifelgamal/gcp-auth-restart
...
gcp-auth addon: do not reapply gcp-auth yamls on minikube restart
2021-05-27 15:05:34 -07:00
a8136ec322
Move InstallOrUpdate to its own package.
2021-05-27 15:01:58 -07:00
eff0bc7161
trigger build to update github status
2021-05-26 22:02:41 -07:00
1b562da2b0
apply to crio as well
2021-05-26 17:09:13 -07:00
2244e26fe4
Merge branch 'master' into ilyaz/fix_delete_paused
2021-05-26 16:58:40 -07:00
2628f8bb04
fix quoting
2021-05-26 15:27:31 -07:00
2a7f0dca85
simplify the code
2021-05-26 13:41:10 -07:00
773500bc74
do not unapuse for docker/crio
2021-05-26 12:49:08 -07:00
b1ce37b7b5
Merge pull request #11469 from utkarsh-pro/utkarsh-pro/fix/11171
...
Support setting addons from environmental variables
2021-05-26 10:19:22 -07:00
6db4a51cbb
swap to --refresh
2021-05-26 09:26:10 -07:00
4567aaa72f
trigger bulid
2021-05-25 18:03:35 -07:00
08a7f20dea
Merge pull request #11481 from medyagh/guest_pro_docker
...
Unique exit code for when container exists prematurely
2021-05-25 12:40:04 -07:00
017bd42e17
update logs
2021-05-24 22:52:47 -07:00
4265887fa9
unpause before delete
2021-05-24 18:54:57 -07:00
b3541115b2
Merge pull request #11478 from sharifelgamal/error-codes
...
Add list of error codes to documentation
2021-05-24 15:25:58 -07:00
6d8c001a00
spell
2021-05-21 13:57:37 -07:00
9c9934879c
break guest provision when container exists prematurely
2021-05-21 13:34:34 -07:00
3f2170bb51
Merge pull request #11472 from andriyDev/ErrorCodes
...
Use DRV_NOT_HEALTHY when at least one driver is installed but unhealthy
2021-05-21 11:33:23 -07:00
e89aca810a
Add list of error codes to documentation
2021-05-21 11:07:59 -07:00
d59570c1f0
Add DRV_DOCKER_NOT_RUNNING error for cases where specifically docker fails.
2021-05-21 09:43:04 -07:00
d0d62a90e5
Merge pull request #11334 from daehyeok/close_asset
...
Add `Close() error` function into assets.CopyableFile
2021-05-21 09:23:41 -07:00
aa99526399
change variable name from addonList to addonListFlag
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-21 13:39:05 +05:30
d6691e796c
Add `Close() error` function into assets.CopyableFile
...
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
b5499b4c2a
Merge pull request #11394 from ilya-zuyev/ilyaz/gh_11335_test_net_plugins_false_start
...
Skip network tests with disabled CNI for containerd/crio runtimes
2021-05-20 16:20:04 -07:00
a60a6e215b
Merge pull request #11387 from vigothehacker/issue-11382
...
Use the first non flag argument for the log file name instead of the first argument
2021-05-20 15:51:33 -07:00
5600ee6755
Reorganize functional tests
2021-05-20 14:43:51 -07:00
b2d771cd89
Use unhealthy error code if no driver is picked and any driver is installed but unhealthy.
2021-05-20 14:03:53 -07:00
69b30c06df
change variable name from addonListName to addonList
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 22:25:38 +05:30
5a3843b074
replace addonList variable with viper provided data
...
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
2021-05-20 21:39:07 +05:30
d185d765a1
update tests
2021-05-19 15:13:21 -07:00
72e8341536
Merge pull request #11431 from briandealwis/resume
...
Add "resume" as an alias for "unpause"
2021-05-19 15:04:35 -07:00
03600d9afc
Add integration test
2021-05-19 13:25:42 -07:00
039b727cb9
check if cni is not disabled for containerd/crio
2021-05-18 22:48:14 -07:00
e05cad71c4
Merge pull request #11355 from afbjorklund/driver-order
...
Sort rejected drivers by their preference order
2021-05-17 20:31:34 -07:00
cd73e832dd
Merge pull request #11371 from afbjorklund/driver-alternate
...
Fix error picking non-default alternate drivers
2021-05-17 18:54:43 -07:00
f6a89cea06
goimport
2021-05-17 18:39:09 -07:00
49fb17d9fc
Add "resume" as an alias for "unpause"
2021-05-17 18:34:11 -07:00
6d0763648e
Keep original preference, for identical priority
...
Unhealthy drivers have their priority lowered
2021-05-16 09:31:37 +02:00
dedfdfbfcf
Sort rejected drivers by their preference order
...
Don't show drivers not being selected by default
2021-05-15 09:41:12 +02:00
2a2ffeb380
Merge pull request #11304 from daehyeok/copy_node
...
Implement target node option for cp command
2021-05-14 15:59:11 -07:00
eca8a2d540
fix typo in flag documentation: sytemd -> systemd
...
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2021-05-14 17:00:03 -05:00
33e26502dd
Merge pull request #11366 from spowelljr/fixImageLoad
...
`image load`: overwrite same image unless `--overwrite=false`
2021-05-13 21:18:29 -07:00
7c2e963392
Implement target node option for cp command
2021-05-13 10:47:09 -07:00
a086536f38
Merge branch 'kubernetes:master' into issue-11382
2021-05-13 15:15:12 +05:30
7b98243ea3
Add missing apiserver-names config update
2021-05-13 02:02:34 -04:00
d156e5cbed
Fix TestKubernetesUpgrade
...
Signed-off-by: Peixuan Ding <pding@freewheel.com>
2021-05-12 21:35:22 -04:00
5246729910
use global variables in logFileName
2021-05-13 06:44:57 +05:30
9d3ee7e2e1
use overwrite flag for local images
2021-05-12 14:26:34 -07:00
e59ced9029
updated flag description and renamed force arg to overwrite and made it non-optional
2021-05-12 14:26:34 -07:00
826f1852ab
replace over-write with overwrite
2021-05-12 14:26:34 -07:00
83366b7929
added over-write flag for image load
2021-05-12 14:26:32 -07:00
32a91d6eb2
image load loads image even if name:tag already exists
2021-05-12 14:24:49 -07:00
eca1d9e4f2
change the funnction param value from a global variable to a locally set variable
2021-05-12 23:58:35 +05:30
6ea3ffee1f
Show suggestion for rejected unhealthy drivers
...
Normally how to add root permissions for the user, to be able to
run the "docker" or "podman" driver (through group or through sudo)
2021-05-12 07:15:26 +02:00
5f3b63fb30
read the first non flag argument for the lag file name
2021-05-12 08:50:16 +05:30
c214b040e6
Merge pull request #11381 from sharifelgamal/test-doc
...
Make sure all tests have comments
2021-05-11 18:05:36 -07:00
8b67bf15e5
fix error message
2021-05-11 15:26:23 -07:00
971c74f381
fix spelling
2021-05-11 15:23:07 -07:00
972dae8133
Make sure all tests have comments
2021-05-11 15:17:43 -07:00
c136fe3cfd
Merge pull request #11060 from afbjorklund/retro-arch
...
Allow building minikube for outdated architectures
2021-05-11 12:22:03 -07:00
1f2d50f297
Merge pull request #11247 from hex0punk/goroutine-leak-fix
...
Goroutine leak fix
2021-05-11 12:02:54 -07:00
97b152f9a8
Fix error picking non-default alternate drivers
...
We should not select drivers like "ssh" or "none",
unless explicitly requested by the user. Wrong var...
2021-05-11 18:00:39 +02:00
fb728a8893
Switch place of minikube image ls and list
...
Just to make it more similar to the docker image commands.
Both ls/list and rm/remove are equivalent commands, though.
2021-05-09 09:37:02 +02:00
8f167f4213
Merge pull request #10899 from daehyeok/overwrite_flag
...
Refactoring generate/update config file code.
2021-05-07 16:30:15 -07:00
a2d62511d2
Merge pull request #11191 from zhijianli88/shell-completion
...
completion: add specific shell completion
2021-05-07 16:16:54 -07:00
50637dd149
clean up `updateExistingConfigFromFlags` function.
...
Add missing flags to overwrite.
Reuse validate/set function from `generateNewClusterConfig`
2021-05-06 14:07:43 -07:00
afc9ed5222
Clean up `generateNewConfigFromFlags` function
...
split validate/set code with helper function to reuse later.
2021-05-06 14:07:43 -07:00
65692f3181
Merge pull request #11294 from andriyDev/UsernameMixin
...
Add the current user's name to log file hashes to prevent collision.
2021-05-06 10:22:46 -07:00
5776597eb3
Move deferred close to before error exit.
2021-05-05 16:18:15 -07:00
98f4d4706b
Add --file flag to 'minikube logs' to automatically put logs into a file.
2021-05-05 16:18:15 -07:00
65c0f0ff35
Add the current user's name to log file hashes to prevent collision.
2021-05-05 12:38:47 -07:00
e27e9a1e1b
return pointer to k8sissue
2021-05-03 12:25:17 -07:00
9dbe957234
Merge branch 'master' of github.com:kubernetes/minikube into warn-k8s
2021-05-03 12:22:34 -07:00
2474931ab3
prevents a goroutine from being leaked in call to readByteWithTimeout
2021-04-29 22:48:05 -07:00
f0226e50a9
Revert "prevents a goroutine from being leaked in call to readByteWithTimeout"
...
This reverts commit 8810120de6
2021-04-29 22:45:39 -07:00
8810120de6
prevents a goroutine from being leaked in call to readByteWithTimeout
2021-04-29 22:42:33 -07:00
394def7a74
identify appropriate cni then configure cruntime accordingly
2021-04-29 23:36:46 +01:00
9947c61a83
Merge pull request #11185 from prezha/workout-cni-and-cruntimes
...
improve how cni and cruntimes work together
2021-04-29 15:01:18 -07:00
ac2b98d744
Merge pull request #11169 from spowelljr/addBetaNotifications
...
Add opt-in notifications for beta releases
2021-04-29 14:03:59 -07:00
5943260780
completion: add specific shell completion
...
Previously, `minikube completion` is unable to auto-complete the
specific shell as other go-lang applications. For example, when user
type below command:
```
minikube$ minikube completion <tab> <tab>
```
In minikube, there is no candidate shells coming up, which is different
from kubectl:
```
$ kubectl completion <tab> <tab>
bash zsh
```
After this patch, as following, the candidata shell appears:
```
minikube$ minikube completion <tab> <tab>
bash fish zsh
```
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2021-04-29 18:30:27 +08:00
8657b72645
address comments
2021-04-28 17:29:28 -07:00
fb5f275baa
abstract kubernetes issues away
2021-04-28 16:01:59 -07:00
c9ccfece9b
removed get prefix from funcs
2021-04-28 15:34:48 -07:00
7afe98b855
add 1.21.0
2021-04-28 08:59:15 -07:00
661e62aacd
warn about performance for certain versions of kubernetes
2021-04-27 13:54:06 -07:00
ae450f6c7b
Correct typo in start_flags.go
...
Steps to reproduce the issue:
minikube start --memory=2G
Current Output (truncated):
smile minikube v1.14.1 on Linuxmint 19.3
sparkles Using the docker driver based on existing profile
exclamation You cannot change the memory size for an exiting minikube cluster. Please first delete the cluster.
Correction:
"exiting" to "existing" in output:
Expected output:
exclamation You cannot change the memory size for an existing minikube cluster. Please first delete the cluster.
2021-04-26 11:59:17 -07:00
cbe11ca8ff
Merge pull request #11003 from tklauser/x-term
...
Use golang.org/x/term
2021-04-25 22:56:14 -07:00
d6e011bf77
Merge pull request #10918 from afbjorklund/kicbase-cache
...
Add code for downloading kicbase image to cache
2021-04-25 22:25:06 -07:00
e3b45667a6
improve how cni and cruntimes work together
2021-04-25 17:40:34 +01:00
41bbb4f6c5
Merge pull request #11164 from afbjorklund/build-rebase
...
Add re-implementation of the build command
2021-04-24 21:03:30 -07:00
974268092f
Merge branch 'master' into kicbase-cache
2021-04-24 08:36:45 +02:00
d50845903f
url.Parse treats DOS volumes as URL schemes
...
So need to be on the lookout for "C:\\path"
2021-04-23 23:04:30 +02:00
29745438da
add opt-in notifications for beta releases
2021-04-22 14:35:19 -07:00
810f7ab108
Change 'minikube version --short' to only print the version without a prompt.
2021-04-21 19:01:55 -07:00
943561b24d
Clean up the order of the image commands
2021-04-21 20:26:28 +02:00
f7e07770c0
Clean up duplicated function etc after merge
2021-04-21 20:26:28 +02:00
9516122d70
Add example parameters to the usage help text
2021-04-21 20:26:28 +02:00
c961190ed8
Allow passing environ and options to build
2021-04-21 20:26:28 +02:00
db203cd0e2
Allow building tarball from stdin stream
2021-04-21 20:26:28 +02:00
9f9958f7ea
Allow building image from an url as well
2021-04-21 20:26:28 +02:00
40cbe652ea
Improve comments and remove docker daemon
2021-04-21 20:26:28 +02:00
02b4267fd0
Add option for pushing image to registry
2021-04-21 20:26:28 +02:00
c94a6d7968
Make sure to pass any file param to build
2021-04-21 20:26:28 +02:00
6cfbf2cc3d
Move minikube build cmd to minikube image build
...
Use the long name also for examples and usage
2021-04-21 20:26:28 +02:00
9ef5d255d2
Add support for build directory and Dockerfile
...
Will create a temporary tarball, if given a dir
Some code from github.com/fsouza/go-dockerclient
(but not exported as a library, for some reason)
Upgrade docker client and cherry-pick windows
From v18.09.0 to v19.03.15, plus c3a0a37446
Update go-dockerclient and remove internal deps
2021-04-21 20:26:06 +02:00
a2744827c3
Add some basic support for setting the image tag
2021-04-21 19:56:58 +02:00
af5828dff9
Add initial re-implementation of the build command
...
Currently only handles tarballs, not directories
2021-04-21 19:56:55 +02:00
112792fba0
Use golang.org/x/term
...
The golang.org/x/crypto/ssh/terminal package is deprecated and merely a
wrapper around golang.org/x/term. Thus, use the latter directly.
2021-04-21 12:50:48 +02:00
ef036e9297
Mock the docker call when calling it from tests
2021-04-20 22:13:26 +02:00
f5035b5c28
Merge pull request #11122 from lilongfeng0902/minikube-lilf
...
Better to use "0777" than "0o777",instead of only in Go
2021-04-20 10:07:21 -07:00
84e7ea6d14
0777 better than 0o777
2021-04-20 15:04:44 +08:00
a618655bb3
Make golint clean again by adding comments
2021-04-20 08:23:26 +02:00
0c093da67f
revert because of IDE bug
2021-04-20 08:56:17 +08:00
1207de734b
bump golang lint ci to latest
2021-04-19 15:16:31 -07:00
d4c1c2a79f
Merge pull request #11127 from afbjorklund/image-pull
...
new command "image pull: allow to load remote images directly without cache
2021-04-19 14:57:48 -07:00
d8050ee03c
Add documentation to the public image functions
2021-04-19 21:55:43 +02:00
19ea60f843
Merge pull request #11120 from sharifelgamal/gen-test-docs
...
site: Automatically generate integration test documentation
2021-04-19 12:40:40 -07:00
9c1a4f4fc0
Allow to load remote images directly without cache
2021-04-19 20:24:06 +02:00
fbef53209a
Add helper for runtime OS as well as for Arch
2021-04-18 12:51:30 +02:00
9cbfb9b841
filemode is not correct,0o777 to 0777
2021-04-17 10:08:28 +08:00
245f44da66
write to a file and move code around for clarity
2021-04-16 15:33:50 -07:00
1319b6e398
refactor checkRepository to make mocking easier
2021-04-14 12:51:16 -07:00
f95c0eb709
avoid network calls for mirror unit tests
2021-04-12 15:24:46 -07:00
0d22fe24ae
Make lint happy by not using else statement
2021-04-10 16:00:00 +02:00
bc62a9f1bd
Check for supported kubectl architecture too
2021-04-10 15:40:55 +02:00
623b1a8639
Check for supported runtime architecture too
2021-04-10 15:30:17 +02:00
1e3e8c9587
Only show the guest system, not the host system
2021-04-10 14:40:24 +02:00
193e4d5497
fix error message
2021-04-09 16:35:44 -07:00
6aa7e11923
fix imports
2021-04-08 11:50:03 -07:00
8d8f95305b
Merge branch 'master' into ilyaz/do_not_run_amd64_on_m1
2021-04-08 11:44:52 -07:00
b2aa1e56aa
make linter happy
2021-04-08 11:14:03 -07:00
9a3157950f
add download link
2021-04-08 10:25:12 -07:00
78288f87f3
Merge pull request #10976 from wangchenglong01/wangchl01
...
define a variable instead of duplicating "kube-system"
2021-04-07 18:05:27 -07:00
d1431f67a6
exit if run amd64 binary on M1 cpu
2021-04-07 15:44:03 -07:00
40d0f5ef06
Merge pull request #11014 from afbjorklund/config-memory
...
Respect memory being set in the minikube config
2021-04-07 15:27:14 -07:00
848a28db5f
Merge pull request #11007 from afbjorklund/list-images
...
Add ListImages function and image list command
2021-04-07 15:26:22 -07:00
cc553bfb00
Fix broken unit tests encoding wrong result
2021-04-07 20:28:05 +02:00
a757877392
Add new config generation to reduce complexity
2021-04-07 20:24:08 +02:00
f672afe1d4
Fix wrong error message on memory validation
2021-04-07 20:02:46 +02:00
25a98a2ebf
Respect memory being set in the minikube config
2021-04-07 19:58:09 +02:00
35d8d4aa52
Add ListImages function and image list command
2021-04-06 22:57:34 +02:00
18dacff70f
Merge pull request #10958 from azhao155/yzhao/feature/AddAutoPauseInitiliazedStatus
...
auto-pause: initialize the pause state from the current state
2021-04-05 13:46:23 -07:00
387ad774bb
multinode: fix kindnet and dns issues
2021-04-05 16:18:37 +01:00
006adc0530
define a variable instead of duplicating "kube-system"
2021-04-02 14:32:37 +08:00
2df898a50a
Merge pull request #10968 from MadhavJivrajani/master
...
Avoid logging 'kubeconfig endpoint' error when cluster is 'starting'
2021-04-01 09:57:30 -07:00
14cde713bd
Fix unit test failing boilerplate, TestGenerateDocs
2021-04-01 21:22:05 +09:00
7f1a33b6d0
avoid logging 'kubeconfig endpoint' error when cluster is 'starting'
...
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2021-04-01 10:24:34 +05:30
ff23ccf318
Add constant for the ISO cache directory
2021-03-30 20:19:33 +02:00
93dad50a94
fix lint
2021-03-30 16:27:50 +00:00
837ff51c4a
Add initialization logic for auto-pause
2021-03-30 08:26:11 +00:00
0de446dc9e
Merge pull request #10792 from prezha/kvm-network
...
kvm2 driver: add dedicated network & static ip
2021-03-29 17:17:50 -07:00
fc7195cbe5
Replace glog with klog
2021-03-29 21:58:40 +00:00
5f942518f5
lint master
2021-03-29 13:42:20 -07:00
660cc42e88
Merge pull request #10823 from azhao155/yzhao/feature/auto-hook
...
Add auto-pause webhook to inject env into pods for redirecting in-cluster kubectl request to reverse proxy of api server.
2021-03-29 09:53:14 -07:00
29f0aec44a
Merge pull request #10920 from anencore94/cp_window
...
Fix to minikube cp functional test work on windows os
2021-03-29 09:33:18 -07:00
f022babe1e
refractored image command removeImages function
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-29 10:56:13 +05:30
06d4313f3f
kvm2 driver: add static ip
2021-03-27 23:33:24 +00:00
fcc6283859
kvm2 driver: add dedicated network
2021-03-26 23:34:04 +00:00
e37f8bc1a2
add unload as an alias and fixed parent command usage
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-27 02:30:15 +05:30
4f9aac3aa5
Fix to minikube cp functional test work on windows os
...
- use filpath lib to represent local path depends on host os
- write within-minikube-path as function to represent what
the path means
2021-03-26 15:26:03 +09:00
82d7fcc65f
address log and docs feedback
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2021-03-25 19:32:13 +05:30
Medya Gh
Steven Powell
Sharif Elgamal
Medya Ghazizadeh
Nicolas Busseneau
Keyhoh
Steven Powell
Piotr Resztak
Carlos Santana
Dimitris Aragiorgis
KallyDev
RA489
Pablo Caderno
Li Yi
Jayesh Srivastava
Akihiro Suda
Raghavendra Talur
Predrag Rogic
Anders F Björklund
Andriy Dzikh
Jack Zhang
Blaine Gardner
Vishal Jain
Devdutt Shenoi
dmpe
Alexandre Garnier
Rajwinder Mahal
Dakshraj Sharma
Ilya Zuyev
Daehyeok Mun
Ilya Zuyev
Dongjoon Hyun
JacekDuszenko
Utkarsh Srivastava
Brian de Alwis
ilya-zuyev
Evan Baker
VigoTheHacker
Peixuan Ding
VigoTheHacker
hex0punk
Li Zhijian
csiepka
Tobias Klauser
李龙峰
Cookie Wang
Kent Iso
Madhav Jivrajani
Yanshu Zhao
Tharun
anencore94