b99304eac3
WarningType -> Warning
2020-03-10 09:07:42 -07:00
4f5c882ca4
Merge pull request #6969 from sharifelgamal/cp-bc
...
Allow backwards compatibility with 1.6 and earlier configs
2020-03-10 07:19:03 -07:00
05116abb1f
more fallout for the merge-pocalypse
2020-03-09 19:29:29 -07:00
64ca925d6c
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-09 16:32:54 -07:00
3b900cb308
minor fix
2020-03-09 12:39:58 -07:00
424b5170f7
Allow backwards compatibility with 1.6 and earlier configs
2020-03-09 12:01:07 -07:00
5ee6f77f72
make the stopped node output clarify
2020-03-09 21:55:49 +09:00
bdbc7c00a5
Improve the go reportcard for minikube
...
Fix gofmt, golint, and most of gocyclo
(but not the integration tests just yet)
2020-03-08 21:48:26 +01:00
3ffdaf3c1c
Deleted unnecessary comments
2020-03-07 23:48:13 +05:30
40c1c80b42
Created new error type & made corresponding changes
2020-03-07 23:48:13 +05:30
8b2289836a
Modified the previous commit using Erros.New() function
2020-03-07 23:47:18 +05:30
061b159991
Formatted the error output
2020-03-07 23:47:18 +05:30
5a32eb7c4c
Updated error handling when service or namespace doesn't exist
2020-03-07 23:47:18 +05:30
c17e998923
Merge pull request #6915 from tstromberg/fish-2x
...
docker-env: Add semicolons back for fish, required for fish 2.x users
2020-03-06 13:41:02 -08:00
882d1aeab3
Universally point to the host docker daemon
2020-03-06 12:04:32 -08:00
13da35ced2
Add semicolons back to fish env, required for fish 2.x users
2020-03-06 11:44:30 -08:00
1f61f39bae
Merge conflict
2020-03-05 15:33:46 -08:00
f702821c9d
Merge pull request #6903 from tstromberg/downgrade-spacing
...
Improve downgrade messaging
2020-03-05 14:30:47 -08:00
b6c96eef30
Skip ISO checksum validation if custom URL is specified
2020-03-05 13:49:48 -08:00
a336bc9f76
Improve downgrade messaging
2020-03-05 13:30:07 -08:00
044ff571e6
Merge master
2020-03-05 12:05:49 -08:00
c2c1807c93
Automatically scale the default memory allocation
2020-03-05 11:59:22 -08:00
d96edd4e8e
Merge pull request #6892 from tstromberg/iso-fallback
...
Unify downloaders, add GitHub and Alibaba ISO fallbacks
2020-03-05 11:07:35 -08:00
1f7ae5b35b
Merge to master
2020-03-05 09:57:46 -08:00
625592920e
fallback to vm-driver
2020-03-05 09:41:51 -08:00
1327f9d3a5
Merge pull request #6836 from sharifelgamal/machinename
...
Decouple machine name from profile/cluster name
2020-03-04 21:06:28 -08:00
3e772d0048
Merge master
2020-03-04 20:18:16 -08:00
d5bc3fdc65
Merge pull request #6888 from sharifelgamal/driver
...
Switch --vm-driver paramter to --driver
2020-03-04 19:04:43 -08:00
a1ebcbd031
Merge conflicts
2020-03-04 18:01:41 -08:00
39670fc06f
Add download package & support URL fallback
2020-03-04 17:07:49 -08:00
0ff12cafac
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 16:37:54 -08:00
2db0b8cea2
fix search/replace errors
2020-03-04 14:10:39 -08:00
ac0c1bad42
missing files
2020-03-04 13:48:21 -08:00
e2ce45c6f0
Switch --vm-driver paramter to --driver
2020-03-04 13:32:43 -08:00
7fbabd4798
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 09:24:17 -08:00
f183a79a2d
profile_list: Do not throw error for unready clusters
2020-03-04 11:13:51 -06:00
9f41fd42e1
populate target port in service list
2020-03-03 22:50:58 -08:00
aa02c106c3
Merge pull request #6875 from josedonizetti/fix-delete-all-cmd
...
Fix delete --all if using non default profile
2020-03-03 17:59:07 -08:00
a269de762f
Fix delete --all if using non default profile
2020-03-03 20:41:24 -03:00
daf8363961
fix logs and delete command
2020-03-03 14:23:35 -08:00
3bb111a6fc
make sure machine name is properly backwards compatible
2020-03-03 13:49:01 -08:00
95dd21d115
unit tests pass holy cow
2020-03-03 13:20:21 -08:00
28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-03 12:16:47 -08:00
2618c32b27
fixing unit tests
2020-03-03 12:14:22 -08:00
6affbc3209
Merge pull request #6867 from josedonizetti/fix-kic-service-warn-message
...
kic: Fix service warn message on docker/osx
2020-03-03 10:16:19 -08:00
f679db1d09
kic: Fix service warn message on docker/osx
2020-03-03 10:03:52 -03:00
31a42ce672
address comments
2020-03-02 17:30:08 -08:00
4cd3ef81a5
more changes
2020-03-02 15:21:37 -08:00
fd99260ae7
Fix native-ssh flag for the ssh command
2020-03-02 19:12:04 +01:00
4b902f7e9f
more changes
2020-02-28 15:58:05 -08:00
954f5a6b74
kic: fix service list for docker on osx
2020-02-28 14:57:53 -03:00
3b04a8d85e
initial machine name refactor
2020-02-28 09:50:55 -08:00
3f34e68404
Merge pull request #6774 from vikkyomkar/issue-6767
...
Fix: do not change the profile to a none existing profile
2020-02-28 09:21:32 -08:00
c412a8ae44
Fix start for existing profile
2020-02-28 12:53:51 -03:00
a349b865d8
correct machine name for selectDriver
2020-02-27 15:09:05 -08:00
0cc0a25c28
passing correct machine name around
2020-02-27 14:37:15 -08:00
2bf3b9a9f9
move caching code to cluster
2020-02-27 11:40:51 -08:00
5e30d2f8c9
Fix linter
2020-02-26 22:29:28 -03:00
5d8f2541f6
kic on mac: add service warn
2020-02-26 22:16:50 -03:00
9f82d6855b
actually cache images on cluster startup
2020-02-26 15:51:14 -08:00
f390d4bf30
kic on mac: add service cmd support
2020-02-26 20:49:58 -03:00
d7df027fb8
fix delete and stop
2020-02-26 15:26:05 -08:00
4709af55df
resolve review comments
2020-02-26 12:44:25 -08:00
676588f6b6
refactor machine name creation into a function
2020-02-25 23:47:08 -08:00
e3826a5e47
fix ip command
2020-02-25 17:18:25 -08:00
0fadf91d2c
i think it works?
2020-02-25 16:36:53 -08:00
9d87d64441
added suggestion message
2020-02-25 11:24:25 +05:30
3d72152953
fixing lint and other random incorrect stuff
2020-02-24 17:28:10 -08:00
be9c5f4761
pass in the node object into add
2020-02-24 15:58:35 -08:00
7596b39607
addres PR review
2020-02-24 15:10:34 -08:00
9a3ecab61a
fixed more stuff
2020-02-24 15:09:04 -08:00
850169764c
improve message
2020-02-24 14:51:45 -08:00
2e261d3d00
add not implemented messages for docker on mac service
2020-02-24 14:41:34 -08:00
d7ee8bfd37
patch
2020-02-24 11:31:53 -08:00
5fe81c806d
Merge pull request #6460 from josedonizetti/kic-darwin-tunnel
...
WIP: kic darwin tunnel
2020-02-24 11:28:00 -08:00
8cfc825641
fixes profile switch to non-existing one
2020-02-24 17:49:25 +05:30
f22efd871a
mostly moving code around and adding UpdateNode
2020-02-23 22:41:08 -08:00
4af82913e1
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-02-23 09:31:00 -08:00
727beb6893
Merge pull request #6744 from kppullin/docker-env-fish-fix
...
Generate fish compatible docker-env hint
2020-02-22 18:42:08 -08:00
fa9f7f9794
Add comments to avoid warnings from go lint
2020-02-22 16:12:42 +01:00
8d78c95aea
Generate fish compatible docker-env hint
...
`fish`'s eval handling does not properly process multiple lines.
Instead the recommendation is to pipe the output to `source`.
This PR updates the usage hint of the `docker-env` command
when running on `fish`:
```
eval (minikube -p fish docker-env) => (minikube -p fish docker-env) | source
```
Ref: https://github.com/fish-shell/fish-shell/issues/3993
Signed-off-by: Kevin Pullin <kevin.pullin@gmail.com>
2020-02-21 17:11:43 -08:00
6e9cf2de2f
Change MachineConfig to ClusterConfig
2020-02-21 16:09:05 -08:00
ec191119df
let's move some start code around
2020-02-21 15:46:02 -08:00
bc2a7aec8b
Adjust assert statements
2020-02-22 07:31:49 +11:00
1d0267f23c
Fix unit test
2020-02-22 07:18:16 +11:00
4d9730137f
improve logging
2020-02-20 21:56:23 -08:00
7c1c0ebb02
more error logging
2020-02-20 21:41:21 -08:00
67e9c9ab85
log errors in unit test
2020-02-20 21:41:21 -08:00
e6d70210af
add error wrpaps for config set
2020-02-20 21:41:21 -08:00
7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
...
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
c6313bb7ff
better error message
2020-02-20 09:47:45 -08:00
31cf3f2d79
missing err check
2020-02-20 09:47:10 -08:00
78c192cb40
lint
2020-02-20 00:07:36 -08:00
dcff758753
lint
2020-02-20 00:07:36 -08:00
4fe9ca5f05
break done delete and prune into two funcs better error handling
2020-02-20 00:07:36 -08:00
8d45b236de
less ambigous error log
2020-02-20 00:07:36 -08:00
d84aa9f447
lint
2020-02-20 00:07:36 -08:00
b1d139c24b
code review comments
2020-02-20 00:07:35 -08:00
d3b86cfeb9
improve logging
2020-02-20 00:07:35 -08:00
efd4aabde4
clean up containers first then delete volume
2020-02-20 00:07:35 -08:00
b235255196
fix volume clean up
2020-02-20 00:07:35 -08:00
8700f8a1e0
Merge pull request #6700 from medyagh/resource_limit
...
fix inverted logic for resource logic
2020-02-19 23:57:16 -08:00
0af5734bc9
Merge pull request #6696 from priyawadhwa/install-addons
...
Fix bug in --install-addons flag
2020-02-19 22:33:50 -08:00
cc0caac415
mount display bind address to user
2020-02-19 22:08:50 -08:00
b65c2fef09
fix typo
2020-02-19 22:01:46 -08:00
ce89a04278
specify localhost mount for binding for docker on mac
2020-02-19 22:01:46 -08:00
ec7c6ba4fa
fix inverted logic
2020-02-19 21:33:24 -08:00
5ad4d6ebf5
Fix bug in --install-addons flag
...
Respect --install-addons flag, don't install anything if it is false
2020-02-19 14:56:09 -08:00
8536fb7641
changes and things
2020-02-19 12:53:59 -08:00
089deef706
Do not create profiles that do not exist
2020-02-18 05:59:37 -05:00
1da0a370ff
code review comments
2020-02-17 10:55:53 -08:00
2bfcb72b96
Remove not used code
2020-02-17 10:22:11 -03:00
23ef3f6d16
lint
2020-02-16 19:51:59 -08:00
b0d19e51b5
Refactor kic ssh tunnel
2020-02-14 21:01:32 -03:00
0d11e4e348
Add error checking to kic cmd/tunnel
2020-02-14 13:22:56 -03:00
c421e156b6
Fix tunnel cmd to pass context to kic tunnel
2020-02-14 12:51:04 -03:00
a007c0790c
Delete volumes created by kic
2020-02-14 01:39:16 -08:00
c1a3e4348d
fix unit tests and fix merge conflicts
2020-02-13 10:30:12 -08:00
2785d292f5
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-02-13 10:15:04 -08:00
25167e1b75
Fix docker-env and add unit and integration tests ( #6604 )
...
* Fix docker cert env in docker-env for docker driver
* add unit tests
* add integration tests for docker-env cmd
* lint
* fix lint
* merge conflict
* improve docker-env integraiton test
* linting
2020-02-13 02:17:11 -07:00
8c55c9ca60
holy crap cyclical import hell sucks
2020-02-12 18:34:44 -08:00
398c7ef00b
Add podman driver ( #6515 )
2020-02-12 19:11:44 -07:00
af353314e0
Separate cached kubernetes binaries by OS on host machine ( #6586 )
...
* Separate cached kubernetes binaries by OS on host machine
This way, all kubernetes binaries stored in ~/.minikube/cache/linux will be copied over to the VM and used for `minikube kubectl` on linux machines. kubectl will be stored in `~/.minikube/cache/{windows or darwin}` on windows/darwin so that `minikube kubectl` still works.
* Review comment
* Update integration test
* Make sure --download-only includes OS specific kubectl
Update integration test to make sure we download
OS specific kubectl on darwin/windows when using --download-only flag
2020-02-11 23:23:37 -07:00
b427dc5663
fixed commands, they mostly work now
2020-02-11 21:11:22 -08:00
9830d91c09
linting nonsense
2020-02-11 18:39:59 -08:00
744efaa330
REFACTOR COMPLETE?
2020-02-11 17:06:59 -08:00
b6a429dc9d
hey did you want more files? good
2020-02-11 15:45:49 -08:00
f2ebbb9c67
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-02-11 09:44:10 -08:00
69aa54ff82
begin start refactor
2020-02-11 09:38:15 -08:00
ff763db1e7
Add podman-env for connecting with podman-remote ( #6351 )
...
* Refactor: add the docker vars after the shell vars
* Move shell handling functions to separate package
* Rename env source file to docker-env like command
* Add podman-env for connecting with podman-remote
* Remove leading Shell prefix from the shell package
* Add some documentation describing podman service
* Address some podman-env issues pointed out by lint
2020-02-10 22:59:37 -07:00
a283fd695a
Fix to kubeConfigPath could be set from env ( #6568 )
...
* Fix to kubeConfigPath could be set from env
Fix to use kubeConfigPath by using kubeconfig.PathFromEnv
function not from just $HOME/.kube/config
Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
* Delete redundant logic to get kubeConfigPath
- change to use already present util function
to set up kubeConfigPath
Co-authored-by: sopahlHong <hongsophal.hsp@gmail.com>
Co-authored-by: woohhan <woohhan@gmail.com>
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
Co-authored-by: SOPHAL HONG <hongsophal.hsp@gmail.com>
Co-authored-by: Woohyung Han <woohhan@gmail.com>
2020-02-10 16:08:07 -07:00
e18e4d083b
Fix `minikube start` in order to be able to start VM even if machine does not exist ( #5730 )
...
* fix startHost in order to be able to start VM even if machine does not exist
* Update func StartHost() and its unit test no to use config.GetMachineName()
* Add handle case when the kic image isn't pulled
2020-02-10 11:37:30 -07:00
239be7ed94
Create Hyper-V External Switch ( #6264 )
...
* Create and manager Hyper-V switch
* Adds new flag for Hyper-V driver
* Move switch creation out of chooseSwitch
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
2020-02-07 21:22:19 -07:00
e1fc3ce734
let's rearrange some stuff
2020-02-07 17:00:24 -08:00
8762c48921
Merge pull request #6541 from anencore94/deleteContext
...
Fix to delete context when delete minikube
2020-02-07 16:15:56 -08:00
2c08f62ed2
Let DeleteContext determine the KUBECONFIG path
2020-02-07 15:34:31 -08:00
914e7de860
Merge pull request #6536 from tstromberg/wait-nada2
...
Add --install-addons toggle for users who don't want them
2020-02-07 11:47:24 -08:00
460f8d0187
Fix bug to delete context when delete minikube
...
- when `minikube delete`, minikube must delete its config which
are set when `minikube start`.
- But, there was some mistakes in the function that does this
logic
Signed-off-by: anencore94 <anencore94@kaist.ac.kr>
2020-02-07 20:00:08 +09:00
c195d5a55f
Merge branch 'master' into powershell-env-bugfixes
2020-02-06 23:17:26 -08:00
10ef863f7d
Merge pull request #6527 from tstromberg/powershell-env
...
Bug-compatible refactor of docker-env + output tests
2020-02-06 21:57:25 -08:00
63954700d7
Address review comments
2020-02-06 17:32:08 -08:00
4ba0f52f57
Add flag to toggle installation of addons
2020-02-06 17:29:19 -08:00
5d59e83b64
Rewrite unsetScript to fix a variety of bugs
2020-02-06 17:01:05 -08:00
0cac457126
Transition TestGetNodeDockerEnvIPv6 to env_test
2020-02-06 16:05:05 -08:00
6e19c62896
Update tests to include all current output quirks
2020-02-06 15:54:57 -08:00
b478fbaa1a
Minimize changes
2020-02-06 15:40:24 -08:00
32bc0ff76a
Refactor docker-env for testability
2020-02-06 15:32:00 -08:00
f6f8b503c4
fill in cmd code
2020-02-06 13:38:42 -08:00
6ef60c1964
Add warnings back in
2020-02-06 13:27:49 -08:00
59ab0ba89e
Fix lint errors
2020-02-06 10:11:38 -08:00
9c70693e40
Revert whitespace change in docker-env output
2020-02-06 07:04:51 -08:00
eded9a17e1
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-02-05 17:39:54 -08:00
8d365fcb03
shuffling stuff around for import purposes
2020-02-05 17:39:47 -08:00
091db5ddb6
Remove kubeadm pull images
2020-02-05 16:23:19 -08:00
2ecc120b2b
Merge pull request #6503 from tstromberg/faster-dryrun
...
Skip driver autodetection if driver is already set
2020-02-05 13:48:42 -08:00
7c301ec27b
Merge branch 'master' into faster-dryrun
2020-02-05 12:05:43 -08:00
0d29a2ac7b
Merge branch 'master' into f-fix-5144
2020-02-05 11:32:32 -08:00
6d59d9d7df
Merge pull request #6200 from laozc/node-name
...
Use profile name as cluster/node name
2020-02-05 11:27:35 -08:00
80c0183f3d
Skip driver autodetect if driver is already set
2020-02-05 10:48:04 -08:00
8eb91989a9
Merge pull request #6492 from medyagh/obvious_denv
...
improve "docker-env" command to point to correct docker
2020-02-05 10:02:35 -08:00
4dda226e86
Merge pull request #6483 from karolz-ms/dev/karolz/azure-cr
...
Add Azure Container Registry support
2020-02-05 10:01:59 -08:00
5795b7f312
Merge branch 'master' into obvious_denv
2020-02-05 08:14:56 -08:00
0bd4099cfc
Merge pull request #5678 from priyawadhwa/compare
...
[mkcmp] add code to time `minikube start` for each binary
2020-02-04 20:49:59 -08:00
37fb10415b
Merge pull request #6237 from tstromberg/ssh-verify
...
Support --force for overriding the ssh check
2020-02-04 20:49:07 -08:00
dc0be4aed6
Merge branch 'master' of github.com:kubernetes/minikube into node-pkg
2020-02-04 17:29:31 -08:00
12e53f4d1f
fix unit tests
2020-02-04 16:45:27 -08:00
435010a3fc
pass profilename for testability
2020-02-04 16:35:51 -08:00
eda1c76fe5
add kic tunnel (alpha)
2020-02-04 21:33:56 -03:00
c86b20ade2
add option to exec runner to point to host docker daemon
2020-02-04 15:33:04 -08:00
2d2b60f95b
fix lint
2020-02-04 15:12:55 -08:00
f41a10a98f
Fix up some unit tests
2020-02-04 15:01:40 -08:00
f6c7048392
use constants instead of hardcode
2020-02-04 13:30:23 -08:00
3937bae269
add new env var for docker-env command
2020-02-04 13:25:22 -08:00
a50ebb8c03
Merge pull request #6481 from medyagh/k_nslookup
...
try nslookup both ways
2020-02-04 06:59:48 -08:00
718ab997d5
spell
2020-02-03 17:11:35 -08:00
4f6deaf5dc
Rebased on master
2020-02-03 16:31:11 -08:00
3f939af4b4
Merge branch 'master' into addons-startup2
2020-02-03 16:17:33 -08:00
4a4e7b7859
Add Azure Container Registry support
2020-02-03 16:10:18 -08:00
b4c1db6e14
change wording VM to node
2020-02-03 15:11:12 -08:00
38a4a4ab8b
more inclusive nslookup
2020-02-03 15:09:25 -08:00
04df96880e
Merge branch 'master' into none-paused
2020-02-03 13:49:21 -08:00
bcc186b908
Startup previously enabled addons
2020-02-03 10:49:40 -08:00
f59a2891eb
Merge remote-tracking branch 'origin/master' into node-name
2020-02-03 19:16:57 +08:00
af2060a858
Move kubeconfig down as we cannot get an IP if host is down
2020-01-31 19:24:30 -08:00
edbe92fb01
Re-arrange status calls to extract maximum information without being confusing
2020-01-31 19:15:58 -08:00
1176aa468f
More status logging
2020-01-31 19:00:59 -08:00
6760929a72
Add logging of non-nil errors
2020-01-31 18:36:38 -08:00
eee5788ab3
Make deletion output more terse
2020-01-31 17:08:27 -08:00
ab93b27a70
Merge branch 'master' into none-paused
2020-01-31 16:38:00 -08:00
e206b25da5
Merge pull request #6440 from tstromberg/addons-on-startup
...
Add addon enablement to start
2020-01-31 16:25:30 -08:00
dd4ad10b83
Improve handling of paused none clusters.
2020-01-31 16:23:25 -08:00
40f2f7c28d
Promote Infofs to errors/warnings
2020-01-31 16:23:07 -08:00
b3149a1031
Allow 'profiles list' to work even if a profile has no control plane
2020-01-31 16:23:07 -08:00
7ebd01e113
Remove extra }
2020-01-31 14:55:24 -08:00
65fec571a5
Merge branch 'master' into ssh-verify
2020-01-31 14:53:13 -08:00
9b5044bfb2
Skip trySSH entirely if --force is set
2020-01-31 14:53:04 -08:00
15c6a8a028
Merge pull request #6450 from tstromberg/control-plane-err
...
Allow 'profiles list' to work even if a profile has no control plane
2020-01-31 14:43:12 -08:00
02902f7f4f
Merge pull request #6438 from tstromberg/nonexistent-status
...
status: Explicitly state that the cluster does not exist
2020-01-31 14:38:49 -08:00
723b074f65
Merge pull request #6409 from medyagh/plist_cr_info
...
add container runtime info to profile list
2020-01-31 14:38:25 -08:00
7d65ca31de
Promote Infofs to errors/warnings
2020-01-31 14:35:03 -08:00
Thomas Stromberg
Sharif Elgamal
Kenta Iso
Anders F Björklund
rajula96reddy
Medya Ghazizadeh
Naveen Kumar Sangi
Prasad Katti
Jose Donizetti
Medya Gh
vikkyomkar
Kevin Pullin
sayboras
Priya Wadhwa
aallbright
anencore94
go_vargo
Zhongcheng Lao
anencore94
Karol Zadora-Przylecki