6de56d3a7a
Merge branch 'master' into better-fixhost
2020-03-20 15:37:07 -07:00
4faa31ebcf
Add logic to get desc node output in bootstrapper LogCommands func
2020-03-20 14:56:04 -07:00
35aec77fe4
code comments
2020-03-20 14:07:43 -07:00
4c00ae01ed
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-20 12:43:11 -07:00
bb387039d1
move panic out of library
2020-03-20 11:29:36 -07:00
bb0511c5c8
Merge branch 'master' into better-fixhost
2020-03-20 07:30:48 -07:00
729642ef33
Merge pull request #7112 from tstromberg/apiserver-always
...
Improve error when docker-env is used with non-docker runtime
2020-03-19 20:24:31 -07:00
6a6b77a161
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-19 18:18:03 -07:00
5cd7660d1e
fixHost: only reprovision if necessary, and only once
2020-03-19 17:44:21 -07:00
dadf4bd35d
Improve error message when docker-env is used with an incompatible runtime
2020-03-19 14:04:40 -07:00
39b5c534ab
Add warning if both vm-driver and driver are specified
2020-03-19 12:08:34 -07:00
f9b38dc04e
clean up status output and have multinode survive cluster restarts
2020-03-18 21:28:03 -07:00
9420a941f9
Remove false positives
2020-03-18 16:22:23 -07:00
a24aa5dff7
dramatically simplify start code path
2020-03-18 15:04:56 -07:00
ff8ae7311c
If user doesn't specify driver, don't validate against existing cluster
2020-03-18 12:27:17 -07:00
ce1cc8d34c
Merge pull request #7054 from afbjorklund/image-mirror-version-parse
...
Strip the version prefix before calling semver
2020-03-18 08:10:38 -07:00
3f6d32aff8
Merge pull request #7080 from priyawadhwa/ignores-driver
...
Move some of the driver validation before driver selection
2020-03-18 07:56:25 -07:00
dd707820fc
If memory is specified in config, suggest that for memory allocation
2020-03-17 18:07:48 -07:00
d5490a8fb8
Move driver validation before driver selection
...
If a user passes in a driver via --vm-driver or --driver, then we should make sure it matches the preexisting cluster (if one exists) before we try and get information about the driver. This avoids confusing logs where we tell the user we're using the preexisting driver but then error out because they specified a different driver.
2020-03-17 16:04:43 -07:00
66a6f4e906
fix docker status
2020-03-17 12:28:44 -07:00
e053e4f235
Add --vm flag for users who want to autoselect only VM's
2020-03-17 13:21:05 +05:30
f99d335fed
fix docker driver
2020-03-16 15:36:05 -07:00
74b1f34715
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-16 10:01:38 -07:00
dc6b9bae2b
Add basic unit test for image mirror country
2020-03-15 13:47:56 +01:00
e7af223d72
Strip the version prefix before calling semver
2020-03-15 12:31:14 +01:00
bf1b6d799c
Merge pull request #7048 from afbjorklund/reportcard-1.8.2
...
Improve reportcard for the v1.8.2 release
2020-03-14 19:22:24 -07:00
f54af5d684
function name HostPortBinding changed to ForwardedPort
2020-03-14 21:28:12 +05:30
5987a390e7
Improve reportcard for the v1.8.2 release
...
gofmt: 99%
pkg/minikube/docker/store_test.go
Line 1: warning: file is not gofmted with -s (gofmt)
golint: 99%
pkg/minikube/cruntime/docker.go
Line 40: warning: exported type ErrISOFeature should have comment or be unexported (golint)
Line 44: warning: exported function NewErrISOFeature should have comment or be unexported (golint)
gocyclo: 99%
cmd/minikube/cmd/start.go
Line 801: warning: cyclomatic complexity 18 of function generateCfgFromFlags() is high (> 15) (gocyclo)
2020-03-14 14:25:50 +01:00
75ba4c27df
Merge pull request #7043 from tstromberg/lz4-missing
...
Delete: output underlying status failure, better machine function names
2020-03-13 18:38:24 -07:00
c3b56b6466
let's rearrange a bunch of code
2020-03-13 18:08:10 -07:00
b0e4b32805
Correct name variable
2020-03-13 16:00:30 -07:00
9fa98a834b
status: properly state if cluster does not exist
2020-03-13 15:58:14 -07:00
196a8d7b82
Delete: output underlying status failure, refactor wordy code
2020-03-13 15:51:03 -07:00
d98ebcfb68
lint
2020-03-13 15:32:14 -07:00
36089037d9
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-13 15:24:07 -07:00
a9b73b8ba3
fixing up minikube start path
2020-03-13 15:03:19 -07:00
d81ba5b5cb
Don't skip the check for too old versions for new
...
Even when starting a new profile, we still need to check the
k8s version parameter against the oldest supported version...
This helps guard against accidental errors like confusing the
kubernetes version (v1.17.3) with the minikube version (v1.8.1)
2020-03-13 12:39:32 +01:00
3ed818c488
cosmetic fixes
2020-03-12 15:40:13 -07:00
a29c5739ab
Merge pull request #6988 from tstromberg/v1.18.0-beta
...
Update NewestKubernetesVersion to 1.18.0-beta.2
2020-03-11 17:00:35 -07:00
2412dd5331
Merge pull request #6998 from tstromberg/kubectl-mismatch
...
Improve kubectl mismatch UI for clarity
2020-03-11 15:42:12 -07:00
aaf115b592
Use a more specific output example!
2020-03-11 12:47:54 -07:00
db32326873
Improve kubectl mismatch representation
2020-03-10 20:55:22 -07:00
12fd0b007e
Revert kubectl mismatch UI change
2020-03-10 20:52:54 -07:00
71a22787c3
Update Kubernetes image mapping to match v1.18
2020-03-10 20:48:38 -07:00
d98bddac15
Set viper default in a better place
2020-03-10 17:45:43 -07:00
c6333b95aa
Test fixes: Add viper.SetDefault back, and make CalculateSizeInMB return an error instead of exit early
2020-03-10 17:43:56 -07:00
f1d2127498
Only parse memory if set
2020-03-10 16:44:50 -07:00
4788b75fcf
Round suggested memory alloc by 100MB for VM's
2020-03-10 16:06:11 -07:00
ec5dfbb17f
Merge pull request #6959 from afbjorklund/reportcard-cleanup
...
Improve the go reportcard for minikube
2020-03-10 15:11:00 -07:00
e3227a2ded
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-10 15:02:38 -07:00
b99304eac3
WarningType -> Warning
2020-03-10 09:07:42 -07:00
4f5c882ca4
Merge pull request #6969 from sharifelgamal/cp-bc
...
Allow backwards compatibility with 1.6 and earlier configs
2020-03-10 07:19:03 -07:00
05116abb1f
more fallout for the merge-pocalypse
2020-03-09 19:29:29 -07:00
64ca925d6c
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-03-09 16:32:54 -07:00
3b900cb308
minor fix
2020-03-09 12:39:58 -07:00
424b5170f7
Allow backwards compatibility with 1.6 and earlier configs
2020-03-09 12:01:07 -07:00
5ee6f77f72
make the stopped node output clarify
2020-03-09 21:55:49 +09:00
bdbc7c00a5
Improve the go reportcard for minikube
...
Fix gofmt, golint, and most of gocyclo
(but not the integration tests just yet)
2020-03-08 21:48:26 +01:00
3ffdaf3c1c
Deleted unnecessary comments
2020-03-07 23:48:13 +05:30
40c1c80b42
Created new error type & made corresponding changes
2020-03-07 23:48:13 +05:30
8b2289836a
Modified the previous commit using Erros.New() function
2020-03-07 23:47:18 +05:30
061b159991
Formatted the error output
2020-03-07 23:47:18 +05:30
5a32eb7c4c
Updated error handling when service or namespace doesn't exist
2020-03-07 23:47:18 +05:30
c17e998923
Merge pull request #6915 from tstromberg/fish-2x
...
docker-env: Add semicolons back for fish, required for fish 2.x users
2020-03-06 13:41:02 -08:00
882d1aeab3
Universally point to the host docker daemon
2020-03-06 12:04:32 -08:00
13da35ced2
Add semicolons back to fish env, required for fish 2.x users
2020-03-06 11:44:30 -08:00
1f61f39bae
Merge conflict
2020-03-05 15:33:46 -08:00
f702821c9d
Merge pull request #6903 from tstromberg/downgrade-spacing
...
Improve downgrade messaging
2020-03-05 14:30:47 -08:00
b6c96eef30
Skip ISO checksum validation if custom URL is specified
2020-03-05 13:49:48 -08:00
a336bc9f76
Improve downgrade messaging
2020-03-05 13:30:07 -08:00
044ff571e6
Merge master
2020-03-05 12:05:49 -08:00
c2c1807c93
Automatically scale the default memory allocation
2020-03-05 11:59:22 -08:00
d96edd4e8e
Merge pull request #6892 from tstromberg/iso-fallback
...
Unify downloaders, add GitHub and Alibaba ISO fallbacks
2020-03-05 11:07:35 -08:00
1f7ae5b35b
Merge to master
2020-03-05 09:57:46 -08:00
625592920e
fallback to vm-driver
2020-03-05 09:41:51 -08:00
1327f9d3a5
Merge pull request #6836 from sharifelgamal/machinename
...
Decouple machine name from profile/cluster name
2020-03-04 21:06:28 -08:00
3e772d0048
Merge master
2020-03-04 20:18:16 -08:00
d5bc3fdc65
Merge pull request #6888 from sharifelgamal/driver
...
Switch --vm-driver paramter to --driver
2020-03-04 19:04:43 -08:00
a1ebcbd031
Merge conflicts
2020-03-04 18:01:41 -08:00
39670fc06f
Add download package & support URL fallback
2020-03-04 17:07:49 -08:00
0ff12cafac
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 16:37:54 -08:00
2db0b8cea2
fix search/replace errors
2020-03-04 14:10:39 -08:00
ac0c1bad42
missing files
2020-03-04 13:48:21 -08:00
e2ce45c6f0
Switch --vm-driver paramter to --driver
2020-03-04 13:32:43 -08:00
7fbabd4798
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 09:24:17 -08:00
f183a79a2d
profile_list: Do not throw error for unready clusters
2020-03-04 11:13:51 -06:00
9f41fd42e1
populate target port in service list
2020-03-03 22:50:58 -08:00
aa02c106c3
Merge pull request #6875 from josedonizetti/fix-delete-all-cmd
...
Fix delete --all if using non default profile
2020-03-03 17:59:07 -08:00
a269de762f
Fix delete --all if using non default profile
2020-03-03 20:41:24 -03:00
daf8363961
fix logs and delete command
2020-03-03 14:23:35 -08:00
3bb111a6fc
make sure machine name is properly backwards compatible
2020-03-03 13:49:01 -08:00
95dd21d115
unit tests pass holy cow
2020-03-03 13:20:21 -08:00
28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-03 12:16:47 -08:00
2618c32b27
fixing unit tests
2020-03-03 12:14:22 -08:00
6affbc3209
Merge pull request #6867 from josedonizetti/fix-kic-service-warn-message
...
kic: Fix service warn message on docker/osx
2020-03-03 10:16:19 -08:00
f679db1d09
kic: Fix service warn message on docker/osx
2020-03-03 10:03:52 -03:00
31a42ce672
address comments
2020-03-02 17:30:08 -08:00
4cd3ef81a5
more changes
2020-03-02 15:21:37 -08:00
fd99260ae7
Fix native-ssh flag for the ssh command
2020-03-02 19:12:04 +01:00
4b902f7e9f
more changes
2020-02-28 15:58:05 -08:00
954f5a6b74
kic: fix service list for docker on osx
2020-02-28 14:57:53 -03:00
3b04a8d85e
initial machine name refactor
2020-02-28 09:50:55 -08:00
3f34e68404
Merge pull request #6774 from vikkyomkar/issue-6767
...
Fix: do not change the profile to a none existing profile
2020-02-28 09:21:32 -08:00
c412a8ae44
Fix start for existing profile
2020-02-28 12:53:51 -03:00
a349b865d8
correct machine name for selectDriver
2020-02-27 15:09:05 -08:00
0cc0a25c28
passing correct machine name around
2020-02-27 14:37:15 -08:00
2bf3b9a9f9
move caching code to cluster
2020-02-27 11:40:51 -08:00
5e30d2f8c9
Fix linter
2020-02-26 22:29:28 -03:00
5d8f2541f6
kic on mac: add service warn
2020-02-26 22:16:50 -03:00
9f82d6855b
actually cache images on cluster startup
2020-02-26 15:51:14 -08:00
f390d4bf30
kic on mac: add service cmd support
2020-02-26 20:49:58 -03:00
d7df027fb8
fix delete and stop
2020-02-26 15:26:05 -08:00
4709af55df
resolve review comments
2020-02-26 12:44:25 -08:00
676588f6b6
refactor machine name creation into a function
2020-02-25 23:47:08 -08:00
e3826a5e47
fix ip command
2020-02-25 17:18:25 -08:00
0fadf91d2c
i think it works?
2020-02-25 16:36:53 -08:00
9d87d64441
added suggestion message
2020-02-25 11:24:25 +05:30
3d72152953
fixing lint and other random incorrect stuff
2020-02-24 17:28:10 -08:00
be9c5f4761
pass in the node object into add
2020-02-24 15:58:35 -08:00
7596b39607
addres PR review
2020-02-24 15:10:34 -08:00
9a3ecab61a
fixed more stuff
2020-02-24 15:09:04 -08:00
850169764c
improve message
2020-02-24 14:51:45 -08:00
2e261d3d00
add not implemented messages for docker on mac service
2020-02-24 14:41:34 -08:00
d7ee8bfd37
patch
2020-02-24 11:31:53 -08:00
5fe81c806d
Merge pull request #6460 from josedonizetti/kic-darwin-tunnel
...
WIP: kic darwin tunnel
2020-02-24 11:28:00 -08:00
8cfc825641
fixes profile switch to non-existing one
2020-02-24 17:49:25 +05:30
f22efd871a
mostly moving code around and adding UpdateNode
2020-02-23 22:41:08 -08:00
4af82913e1
Merge branch 'master' of github.com:kubernetes/minikube into m2
2020-02-23 09:31:00 -08:00
727beb6893
Merge pull request #6744 from kppullin/docker-env-fish-fix
...
Generate fish compatible docker-env hint
2020-02-22 18:42:08 -08:00
fa9f7f9794
Add comments to avoid warnings from go lint
2020-02-22 16:12:42 +01:00
8d78c95aea
Generate fish compatible docker-env hint
...
`fish`'s eval handling does not properly process multiple lines.
Instead the recommendation is to pipe the output to `source`.
This PR updates the usage hint of the `docker-env` command
when running on `fish`:
```
eval (minikube -p fish docker-env) => (minikube -p fish docker-env) | source
```
Ref: https://github.com/fish-shell/fish-shell/issues/3993
Signed-off-by: Kevin Pullin <kevin.pullin@gmail.com>
2020-02-21 17:11:43 -08:00
6e9cf2de2f
Change MachineConfig to ClusterConfig
2020-02-21 16:09:05 -08:00
ec191119df
let's move some start code around
2020-02-21 15:46:02 -08:00
bc2a7aec8b
Adjust assert statements
2020-02-22 07:31:49 +11:00
1d0267f23c
Fix unit test
2020-02-22 07:18:16 +11:00
4d9730137f
improve logging
2020-02-20 21:56:23 -08:00
7c1c0ebb02
more error logging
2020-02-20 21:41:21 -08:00
67e9c9ab85
log errors in unit test
2020-02-20 21:41:21 -08:00
e6d70210af
add error wrpaps for config set
2020-02-20 21:41:21 -08:00
7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
...
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
c6313bb7ff
better error message
2020-02-20 09:47:45 -08:00
31cf3f2d79
missing err check
2020-02-20 09:47:10 -08:00
78c192cb40
lint
2020-02-20 00:07:36 -08:00
dcff758753
lint
2020-02-20 00:07:36 -08:00
4fe9ca5f05
break done delete and prune into two funcs better error handling
2020-02-20 00:07:36 -08:00
8d45b236de
less ambigous error log
2020-02-20 00:07:36 -08:00
d84aa9f447
lint
2020-02-20 00:07:36 -08:00
b1d139c24b
code review comments
2020-02-20 00:07:35 -08:00
d3b86cfeb9
improve logging
2020-02-20 00:07:35 -08:00
efd4aabde4
clean up containers first then delete volume
2020-02-20 00:07:35 -08:00
Thomas Stromberg
Prasad Katti
Sharif Elgamal
Priya Wadhwa
vikkyomkar
Anders F Björklund
Medya Ghazizadeh
Kenta Iso
rajula96reddy
Naveen Kumar Sangi
Jose Donizetti
Medya Gh
Kevin Pullin
sayboras