Commit Graph

4117 Commits (196789f965f46f706966b4edb652658b7193e247)

Author SHA1 Message Date
Thomas Stromberg a43d18ef9a Update Bridge docstring 2020-06-25 15:21:25 -07:00
Thomas Stromberg 8c5f6a2132 apiserverHealthz: wait up to 8s before declaring failure 2020-06-25 15:14:51 -07:00
Thomas Stromberg 2f3094d32c simplify string output 2020-06-25 14:43:29 -07:00
Thomas Stromberg d16e7d4924 Use new kapi.KubectlBinary API 2020-06-25 14:43:19 -07:00
Thomas Stromberg 2a39d993ea Address lint comments, remove confusing multi-runner API 2020-06-25 14:36:39 -07:00
Thomas Stromberg 521d334b6a Apply CNI on restarts, remove .rej file 2020-06-25 14:23:18 -07:00
Thomas Stromberg 3968631b05 Merge to master 2020-06-25 10:54:42 -07:00
Thomas Strömberg 72e13c1eb8
Merge pull request #8543 from tstromberg/syspods-logging
Improve error and logging emitted by WaitForAppsRunning
2020-06-25 10:53:36 -07:00
priyawadhwa a115db6da8
Merge pull request #8552 from priyawadhwa/coredns
Reduce coredns replicas from 2 to 1
2020-06-25 10:51:18 -07:00
Priya Wadhwa 1769750b7d fix log level 2020-06-25 10:11:29 -07:00
Thomas Stromberg 3fb1cded91 Add retry.Local + retry logging 2020-06-25 09:43:45 -07:00
Priya Wadhwa 1b8eaaf76c Move kubectl binary function to kapi package to prevent future cyclic import dependencies 2020-06-25 09:40:14 -07:00
priyawadhwa d368674457
Merge pull request #8551 from priyawadhwa/etcd-extra-args
Allow passing in extra args to etcd via command line
2020-06-25 09:37:41 -07:00
Priya Wadhwa 6d3a0c4eca Reduce coredns replicas from 2 to 1
This is an easy way to improve overhead, and users can always scale this back up if they need to.
2020-06-24 17:42:12 -07:00
Priya Wadhwa 1b0de27d3d fix spelling 2020-06-24 16:43:32 -07:00
Priya Wadhwa 9d9d512cd8 fix function so we don't get an index out of bounds error 2020-06-24 16:34:58 -07:00
Priya Wadhwa 57574e3b6d fix space bug in unit test 2020-06-24 16:19:33 -07:00
Priya Wadhwa b32487adb1 Only include etcd extra args if they exist 2020-06-24 15:54:19 -07:00
Priya Wadhwa c1e2751ea6 Allow passing in extra args to etcd 2020-06-24 15:41:13 -07:00
priyawadhwa 84365fe57b
Merge pull request #8294 from maciaszczykm/dashboard-v2.0.1
Bump Dashboard to v2.0.1
2020-06-24 11:35:28 -07:00
Medya Ghazizadeh 977411bf75
Merge pull request #8544 from tstromberg/WaitForNode
Skip node pressure check if other checks failed, add retry
2020-06-24 10:26:25 -07:00
Thomas Stromberg a0817b6221 Remove debug statement 2020-06-24 07:53:18 -07:00
Thomas Stromberg af1798728b virtualbox: double health check timeout, add better errors 2020-06-24 07:51:50 -07:00
Thomas Stromberg 9e95435e00 Add --cni flag, fix --network-plugin=kubenet 2020-06-23 20:10:25 -07:00
Thomas Stromberg c38995d22d Skip node pressure check if other checks failed, add retry 2020-06-23 19:58:27 -07:00
Thomas Stromberg 54e70c9826 Improve error and logging emitted by WaitForAppsRunning 2020-06-23 19:36:28 -07:00
Medya Ghazizadeh 4f6a9f6518
Merge pull request #8518 from afbjorklund/docker-containerd
Make sure to use internal containerd for docker
2020-06-23 16:49:14 -07:00
Medya Gh 0121b44175 add NeedsImprovement warnning for overlay kernel 2020-06-23 13:17:59 -07:00
Medya Gh 1101f543d0 add check for mod prob 2020-06-23 12:15:57 -07:00
Anders F Björklund 4027ba4979 Add test case restarting docker after containerd
If we stopped containerd, we restart dockerd.
2020-06-23 20:26:34 +02:00
Anders F Björklund e25ab786ff Only restart dockerd if containerd was running
If starting minikube a second time, do nothing.
2020-06-23 20:17:01 +02:00
Thomas Strömberg f52a682a7e
Merge pull request #8531 from jtzwu/master
Do not output usage hint when shell=none.
2020-06-23 10:57:42 -07:00
Thomas Stromberg 852da00c03 Remove trailing spaces after leader-elect: false 2020-06-23 07:55:30 -07:00
Jeff Wu e1a7b225b3 Format code 2020-06-22 22:00:31 -07:00
Jeff Wu 33d4ecbcc1 Fix shell test to reflect the fact that shell=none no longer has a usage msg. 2020-06-22 21:36:08 -07:00
Jeff Wu f19ca53f34 Do not output usage hint when shell=none. Since there is no shell,
there is no clear way to expect how a usage hint will be interpretted.
2020-06-22 21:22:43 -07:00
Anders F Björklund 63270ad3d6 Restore newline that was removed by mistake 2020-06-20 13:17:29 +02:00
Anders F Björklund 5021c2f2fa Handle the empty SHELL special case ourselves 2020-06-20 13:13:09 +02:00
Anders F Björklund 8fc6dac9c5 Don't return error when SHELL has not been set 2020-06-20 13:00:22 +02:00
Anders F Björklund 22e1a41899 Adjust unit test results when docker not bound
When docker.service is *not* bound to containerd.service,
that means that it will be restarted to not try to use it.
2020-06-20 10:26:11 +02:00
Anders F Björklund f2ea21ab23 Make sure to use internal containerd for docker
When not using the containerd.service, we should make
sure that dockerd does not use the stopped containerd.
2020-06-20 10:01:52 +02:00
colvin 3d2ae5423c Rename podsecuritypolicies addon to pod-security-policy 2020-06-18 17:00:08 -04:00
Marcin Maciaszczyk d02b4b0df4 Bump preload version 2020-06-18 10:37:40 +02:00
Medya Gh e91e11eeba address review comments 2020-06-17 18:32:11 -07:00
Medya Gh 29e01d5dcb fix comment 2020-06-17 15:17:45 -07:00
Medya Gh dacd980fe7 add err type for start too 2020-06-17 15:15:23 -07:00
Medya Gh ca2d0f97ec move advice to its own file 2020-06-17 15:07:17 -07:00
Medya Gh 543b0b5bfa add post mortem logs when container not running 2020-06-17 13:27:17 -07:00
Medya Gh 736f5219e0 add error type for check running 2020-06-17 12:13:12 -07:00
Medya Ghazizadeh 18e89bbca2
Merge pull request #8499 from medyagh/sol_msg_cpucount
docker/podman: add advice for cpu count error
2020-06-17 11:52:01 -07:00
Li Zhijian e6b905608d kubeconfig_test: cleanup temp kubeconfig file
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-17 18:37:05 +08:00
Medya Gh 56b5524c8e address review comments 2020-06-16 14:57:19 -07:00
Medya Ghazizadeh 16c3e95260
Merge pull request #8475 from 11janci/jjanik-fix-hostip-vbox
Fix host network interface for VBox
2020-06-16 13:40:34 -07:00
Medya Gh 4caf260279 add cpu count limit error type for kic drivers 2020-06-16 13:21:56 -07:00
Medya Gh 6e08caa4cf add timed out log 2020-06-16 11:59:17 -07:00
Medya Gh e07446a498 address review comments 2020-06-16 11:56:18 -07:00
Medya Gh 0aa313581f address review comments 2020-06-16 11:27:02 -07:00
Li Zhijian e7121b7290 unify TempDir for testing
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:53:58 +08:00
Li Zhijian 24c9ce079d cleanup TempDir properly
a TempDir is like /tmp/minipath255070191/.minikube

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
Medya Gh a64038dfd0 better wording 2020-06-15 14:59:52 -07:00
Medya Gh 0e96154fc2 add better solution message when docker needs factory reset 2020-06-15 14:59:17 -07:00
Medya Gh bb6c84f7ad provide better solution message 2020-06-15 14:52:31 -07:00
Medya Ghazizadeh 804e772efd
Merge pull request #8455 from govargo/add-heapster-alias
Add heapster alias to metrics-server addon
2020-06-14 16:46:55 -07:00
jjanik bf59d39587 fix host IP for virtualbox 2020-06-14 15:28:08 +02:00
Priya Wadhwa 6ef48499b4 Code review comments 2020-06-12 11:00:46 -07:00
Kenta Iso ab58dca23d replace to metrics-server in case of `minikube start --addons heapster` 2020-06-13 01:07:16 +09:00
Kenta Iso 803461ddcf if the specified addon doesn't exist, skip enabling 2020-06-13 00:46:12 +09:00
Kenta Iso 9d71fc635b remove unneccesary config 2020-06-13 00:46:12 +09:00
Kenta Iso d76b58c3ae Add heapster alias to metrics-server addon 2020-06-13 00:46:12 +09:00
Priya Wadhwa b750ab4964 fix lint 2020-06-11 13:00:46 -07:00
Priya Wadhwa 330224f36a Warn user to restart daemon if context deadline is exceeded 2020-06-11 12:50:11 -07:00
Priya Wadhwa 0ec839186d Change glog.Errorf to glog.Infof so that we don't get an ugly log to stdout 2020-06-11 11:14:04 -07:00
Thomas Strömberg db116c2689
Merge pull request #8428 from tstromberg/minikube-blacklist
Replace whitelist/blacklist with allow/deny
2020-06-11 07:18:02 -07:00
colvin b32cb5e6ba Create a podsecuritypolicies addon
Create a new addon, `podsecuritypolicies` that applies the
PodSecurityPolicy and related RBAC configuration from the
https://minikube.sigs.k8s.io/docs/tutorials/using_psp/ tutorial.
Apparently, recent work on the addons system has invalidated the
procedure shown in that tutorial, as the configuration is no longer
automatically applied. The last known working version is `1.6.2`.

This allows clusters started with
`--extra-configs=apiserver.enable-admission-plugins=PodSecurityPolicy`
to succeed, so long as they also include `--addons=podsecuritypolicies`.
2020-06-11 09:51:13 -04:00
Medya Ghazizadeh ae555bf393
Merge pull request #8342 from prasadkatti/kubelet_flag_to_config
Set `failSwapOn` and `clusterDomain` via kubelet config file
2020-06-10 16:53:38 -07:00
Thomas Stromberg bd1bdb3696 Use 'Allowed' instead of 'Allow' 2020-06-10 14:56:22 -07:00
Priya Wadhwa 6fcc987cc4 Add v1alpha3 2020-06-10 11:21:26 -07:00
Priya Wadhwa 69387a3937 Add in extra args for v1beta1 2020-06-10 10:58:37 -07:00
Marcin Maciaszczyk 424e158856 Fix unit tests 2020-06-10 10:41:19 +02:00
Thomas Stromberg 09672520ea Merge branch 'master' into minikube-blacklist 2020-06-09 16:49:39 -07:00
Priya Wadhwa cbd56c53d7 fix unit tests 2020-06-09 14:17:22 -07:00
Priya Wadhwa 07b04841ce RebaseD 2020-06-09 13:49:22 -07:00
Thomas Stromberg a60c7d3d1d Replace whitelist/blacklist withallow/deny 2020-06-09 13:19:18 -07:00
Priya Wadhwa 11096160fe improve warning message so it fits on one line 2020-06-09 10:25:18 -07:00
Priya Wadhwa e37da349fb pass in driver to load from tarball 2020-06-09 10:18:53 -07:00
Priya Wadhwa 5e1966ea4b Set leader-elect=false for scheduler and controller manager
both the scheduler and controller manager constantly ping the apiserver to ensure leader election. From the docs:

```
Enable this when running replicated components for high availability.
```

which we don't really need in minikube. This should reduce overall overhead by ~12%
2020-06-08 14:39:52 -07:00
Priya Wadhwa 94da5201a6 Add TODO 2020-06-08 14:10:11 -07:00
Priya Wadhwa 173666d203 Use go-containerregistry library instead of docker CLI 2020-06-08 14:01:06 -07:00
Priya Wadhwa 0033381049 rebased on master 2020-06-08 11:24:25 -07:00
Priya Wadhwa 99d75c6b5b WIP 2020-06-08 10:53:47 -07:00
gashirar a85b5aa984 fix logviewer config. 2020-06-05 04:55:18 -07:00
Medya Ghazizadeh 21b7cebaf9
Merge pull request #8335 from sakshamkhanna/bugfix/sakshamkhanna/ssh_runner_race_condition
added mutex lock over teePrefix()
2020-06-04 14:00:08 -07:00
Medya Ghazizadeh ffe6c73812
Merge pull request #8373 from priyawadhwa/refactor
Refactor downloading kic base image
2020-06-04 13:21:38 -07:00
Medya Ghazizadeh 2011306793
Merge pull request #8368 from medyagh/detect_wsl
add support for microsoft wsl for docker driver
2020-06-04 13:21:22 -07:00
Priya Wadhwa c629b9b81c load from tarball if cached kic image exists 2020-06-04 12:40:19 -07:00
Priya Wadhwa 1f6e140e00 try to save image as tarball on download-only 2020-06-04 12:24:07 -07:00
Priya Wadhwa d7297b5b1d Merge branch 'master' of https://github.com/kubernetes/minikube into cloudshell 2020-06-04 12:18:00 -07:00
Priya Wadhwa de81670130 make warning output prettier by including tags 2020-06-04 12:11:54 -07:00
Medya Ghazizadeh c8bcdf9d72
Merge pull request #8355 from afbjorklund/image-ref2
Add digest to image in daemon after pulling it
2020-06-04 11:47:33 -07:00
Medya Gh 6b29b784f2 address review comments 2020-06-04 11:39:28 -07:00
Priya Wadhwa 15088526cd clean up comments 2020-06-04 11:05:52 -07:00
Priya Wadhwa 7dfea631d4 Refactor downloading kic base image 2020-06-04 10:48:38 -07:00
Marcin Maciaszczyk 5f6391783a Update versions in the other files 2020-06-04 09:20:32 +02:00
Marcin Maciaszczyk 57c6340982 Update dashboardFrontend and dashboardMetrics functions 2020-06-04 09:08:05 +02:00
Medya Ghazizadeh 4eb09e760b
Merge pull request #8275 from ashleyschuett/add-kubevirt-addon
Add KubeVirt addon
2020-06-03 22:23:09 +00:00
Medya Gh 7b01b2aef5 update comment 2020-06-03 14:50:03 -07:00
Medya Gh 98d577d229 add more checks for wsl 2020-06-03 14:47:43 -07:00
Medya Gh 276f99b551 improve comment 2020-06-03 14:40:43 -07:00
Medya Gh 02749de984 detect wsl and add port forward 2020-06-03 14:39:34 -07:00
Marcin Niemira 66bb306060
minor refactor 2020-06-02 15:00:19 +10:00
Anders F Björklund 05459a2e42 Add digest to image in daemon after pulling it
The image was added with digest "none", which caused it to be
written to daemon again next time since reference didn't match.
2020-06-01 23:16:32 +02:00
Prasad Katti c061113553 Move some kubelet config to the config file instead of command line 2020-05-31 18:54:39 -07:00
Marcin Niemira 08773015d5
Unify code 2020-05-31 19:06:57 +10:00
Marcin Niemira 366d6c370c
mock shell in test 2020-05-31 15:58:56 +10:00
Marcin Niemira ae2ceee8e4
minor cleanup 2020-05-31 15:32:57 +10:00
Marcin Niemira 168f67bf39
setup fallback to default everywhere 2020-05-31 13:55:44 +10:00
Marcin Niemira 666cd20b51
Merge branch 'master' of github.com:kubernetes/minikube into add-tests-to-minikube-shell 2020-05-31 13:40:29 +10:00
Marcin Niemira d1032515ce
usage hint as function 2020-05-31 13:39:41 +10:00
Marcin Niemira 54a9b35a82
fix bug intruduced by refactor 2020-05-31 13:20:48 +10:00
Marcin Niemira a678b0fb19
ensure all shells set/unset are gren with orginal code 2020-05-31 13:14:25 +10:00
sakshamkhanna 5baa8b7d3f fix import 2020-05-31 02:44:31 +05:30
sakshamkhanna 030f38e9f7 added mutex lock over teePrefix() 2020-05-31 02:02:47 +05:30
Marcin Niemira 81073a0561
use struct instead of map
remove gosec warnings
2020-05-30 20:34:53 +10:00
Priya Wadhwa fae412b703 Fix floating point 2020-05-29 15:14:01 -07:00
Priya Wadhwa d87ca2c217 Add support for docker driver to mkcmp 2020-05-29 14:18:28 -07:00
priyawadhwa abba4b3db5
Merge pull request #8091 from priyawadhwa/open
Add support for timing per log and printing out timings per log to mkcmp
2020-05-29 13:52:47 -07:00
Medya Gh 488e2003f4 fix image digest 2020-05-29 12:19:59 -07:00
Medya Gh bc8c3faf86 add docker hub fall back image 2020-05-29 11:55:21 -07:00
Marcin Niemira 49c3a73563
Add tests to minikube shell
Refactor shell.go to use nested structure for shell - prefix/suffix mapping
2020-05-30 01:34:07 +10:00
Ashley Schuett 5dafe6bc84
Add KubeVirt addon 2020-05-29 09:52:18 +02:00
Medya Ghazizadeh 77419ee925
Merge pull request #8154 from priyawadhwa/kvm-flake
Upgrade oldest k8s version supported to 1.13
2020-05-28 21:18:01 +00:00
Medya Gh 4b280ab362 bump default kubernetes version 2020-05-28 13:44:57 -07:00
Medya Ghazizadeh ea20609a3a
Merge pull request #8161 from concaf/concaf/addons/ambassador
Add Ambassador Ingress controller as an addon
2020-05-28 18:08:41 +00:00
Priya Wadhwa fa6c446374 Bump up major version to 13 2020-05-28 11:08:07 -07:00
Sharif Elgamal 4f0613929f
Merge pull request #7973 from sharifelgamal/restart
Make sure multinode clusters can survive restarts
2020-05-27 17:41:57 -07:00
Sharif Elgamal 96f34ea063 fix tests 2020-05-27 15:54:07 -07:00
Sharif Elgamal 7224064b23 respect native-ssh param properly 2020-05-27 15:19:32 -07:00
Sharif Elgamal a7e483a8a4 let's simplify kubeadm again 2020-05-27 10:17:01 -07:00
Sharif Elgamal d0753347b5 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-27 09:58:22 -07:00
Sharif Elgamal b5167834d0 it works! and simpler 2020-05-27 09:58:03 -07:00
Medya Ghazizadeh 1bfdc4b0d1
Merge pull request #8129 from blues-man/master
Addons: add OLM support
2020-05-26 23:26:20 +00:00
Mikhail Zholobov 2b8bac695e
Apply code review changes
Rename "cmd*" var to "bin*" in the parallels-specific block
2020-05-23 23:08:10 +02:00
Mikhail Zholobov c22a92f9bf
Add HostIP implementation for parallels driver 2020-05-23 20:35:55 +02:00
Mikhail Zholobov 49905d8fea
Remove Parallels from the list of supported drivers for Linux
Parallels Desktop works only on macOS (Darwin)
2020-05-23 16:32:28 +02:00
Sharif Elgamal e225968194 Merge branch 'master' of github.com:kubernetes/minikube into restart 2020-05-21 15:44:31 -07:00
Medya Ghazizadeh ad437c2c9c
Merge pull request #8229 from afbjorklund/docker-inspect
kic: explicitly provide the type in inspect commands
2020-05-21 22:44:20 +00:00
Sharif Elgamal bde6624365 Merge branch 'postmortem' of github.com:sharifelgamal/minikube into restart 2020-05-21 14:54:21 -07:00
Sharif Elgamal 39f6806626 add info log for retrieving node by machine name 2020-05-21 14:35:46 -07:00
Sharif Elgamal a7c49e47c1 allow minikube status to display for one node 2020-05-21 12:46:13 -07:00
Anders F Björklund 14937e4677 Never use docker inspect, always provide the type
Should avoid errors like: map has no entry for key "State"

When inspecting a volume, rather than a container or image
2020-05-21 17:20:53 +02:00