Commit Graph

10862 Commits (0be0781cd4d09780d7d2191909472675d81ae758)

Author SHA1 Message Date
Anders F Björklund e25ab786ff Only restart dockerd if containerd was running
If starting minikube a second time, do nothing.
2020-06-23 20:17:01 +02:00
Thomas Strömberg f52a682a7e
Merge pull request #8531 from jtzwu/master
Do not output usage hint when shell=none.
2020-06-23 10:57:42 -07:00
Thomas Stromberg 25001d7715 Add _test.go suffix everywhere to avoid symbol resolution issues 2020-06-23 10:05:29 -07:00
Thomas Strömberg 126b8cf35e
Merge pull request #8536 from tstromberg/leader-elect-trailing-space
Remove trailing spaces after leader-elect: false
2020-06-23 09:56:11 -07:00
Thomas Stromberg c5f59b1ede Make the calculation easier to understand 2020-06-23 09:51:08 -07:00
Thomas Stromberg 3659fd5203 Use 0.6 CPU count by default 2020-06-23 09:30:24 -07:00
Thomas Stromberg 0fd4f17c0a Automatically limit integration test parallelism 2020-06-23 09:12:00 -07:00
Thomas Stromberg 852da00c03 Remove trailing spaces after leader-elect: false 2020-06-23 07:55:30 -07:00
Medya Ghazizadeh f994b702f6
Merge pull request #8529 from medyagh/cache_test_remove
integration: add delete  to cache test
2020-06-22 23:55:41 -07:00
Jeff Wu e1a7b225b3 Format code 2020-06-22 22:00:31 -07:00
Jeff Wu 33d4ecbcc1 Fix shell test to reflect the fact that shell=none no longer has a usage msg. 2020-06-22 21:36:08 -07:00
Jeff Wu f19ca53f34 Do not output usage hint when shell=none. Since there is no shell,
there is no clear way to expect how a usage hint will be interpretted.
2020-06-22 21:22:43 -07:00
Medya Ghazizadeh ce33161eef
Merge pull request #8528 from tstromberg/docker-not-required
docker-env: Avoid container suicide if Docker is not installed locally
2020-06-22 17:45:47 -07:00
Medya Ghazizadeh 3d09d8e6ae
Merge pull request #8521 from afbjorklund/kubectl-path-log
The logging of the kubectl path was broken
2020-06-22 14:37:39 -07:00
Medya Gh 6c50eac48f add delete test to cache test 2020-06-22 13:29:41 -07:00
Thomas Stromberg 47942be198 docker-env: Avoid container suicide if docker is not in $PATH 2020-06-22 12:27:18 -07:00
Medya Ghazizadeh c609b3fd48
Merge pull request #8519 from Harkishen-Singh/tip-for-minikube-based-kubectl-usage
Adds better information for using kubectl inside minikube
2020-06-22 12:01:06 -07:00
Medya Ghazizadeh a142e43ae6
Merge pull request #8520 from afbjorklund/env-shell
Don't return error when SHELL has not been set
2020-06-22 11:59:08 -07:00
Harkishen-Singh 30e6660925 Better informaation for using kubectl inside minikube
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>

add kubectl install link

Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>

add alias tip to the minikube docs

Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>

remove debug statements

Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-06-20 18:20:28 +05:30
Anders F Björklund fe6687386d The logging of the kubectl path was broken
After introducing the exec.Cmd parameter previously
2020-06-20 14:31:35 +02:00
Anders F Björklund 63270ad3d6 Restore newline that was removed by mistake 2020-06-20 13:17:29 +02:00
Anders F Björklund 5021c2f2fa Handle the empty SHELL special case ourselves 2020-06-20 13:13:09 +02:00
Anders F Björklund 8fc6dac9c5 Don't return error when SHELL has not been set 2020-06-20 13:00:22 +02:00
Anders F Björklund 22e1a41899 Adjust unit test results when docker not bound
When docker.service is *not* bound to containerd.service,
that means that it will be restarted to not try to use it.
2020-06-20 10:26:11 +02:00
Anders F Björklund f2ea21ab23 Make sure to use internal containerd for docker
When not using the containerd.service, we should make
sure that dockerd does not use the stopped containerd.
2020-06-20 10:01:52 +02:00
priyawadhwa 275d827088
Merge pull request #8513 from priyawadhwa/release
Release v1.12.0-beta.0
2020-06-18 15:49:52 -07:00
Priya Wadhwa bf2d09d10a Release v1.12.0-beta.0 2020-06-18 13:22:52 -07:00
Medya Ghazizadeh fe9e0e8950
Merge pull request #8506 from Harkishen-Singh/unset-docker-podman-env-vars-without-machine-running
Adds support for unsetting of env vars
2020-06-18 11:57:29 -07:00
Medya Ghazizadeh d131078bf7
Merge pull request #8501 from medyagh/sol_msg_check_running
docker/podman: add solution message when container exits after start/create
2020-06-18 11:28:15 -07:00
Marcin Maciaszczyk d02b4b0df4 Bump preload version 2020-06-18 10:37:40 +02:00
Medya Gh e91e11eeba address review comments 2020-06-17 18:32:11 -07:00
Medya Gh 29e01d5dcb fix comment 2020-06-17 15:17:45 -07:00
Medya Gh dacd980fe7 add err type for start too 2020-06-17 15:15:23 -07:00
Medya Gh ca2d0f97ec move advice to its own file 2020-06-17 15:07:17 -07:00
Medya Gh d32b8d81fe improve solution message 2020-06-17 14:26:31 -07:00
Medya Gh bdf7c196a1 add detailed suggestions when created container exists 2020-06-17 14:09:51 -07:00
Medya Gh 543b0b5bfa add post mortem logs when container not running 2020-06-17 13:27:17 -07:00
Medya Ghazizadeh 0a7d66a647
Merge pull request #8489 from TrishaChetani/master
docs: fix broken links
2020-06-17 12:17:58 -07:00
Medya Gh 736f5219e0 add error type for check running 2020-06-17 12:13:12 -07:00
Medya Ghazizadeh c8b6ceaffc
Merge pull request #8502 from medyagh/err_spam_ignore
fix test err spam skip logic
2020-06-17 11:58:50 -07:00
Medya Ghazizadeh 18e89bbca2
Merge pull request #8499 from medyagh/sol_msg_cpucount
docker/podman: add advice for cpu count error
2020-06-17 11:52:01 -07:00
Medya Gh e25445dea9 capitalize the Desktop word 2020-06-17 11:51:43 -07:00
Harkishen-Singh 8d1e4e2d26 adds support for unsetting of environment variables without the need of running container-machine
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
2020-06-17 23:54:00 +05:30
TrishaChetani 0a309f9c53 Able to run sucessfully 2020-06-17 17:44:16 +02:00
TrishaChetani 16ccaf95f6 Improved on accepting comment 2020-06-17 17:14:37 +02:00
TrishaChetani ca2a2500cb Incoperated changes to use ref link 2020-06-17 16:36:07 +02:00
Medya Gh 652446b8de fix err spam skip logic 2020-06-16 17:26:27 -07:00
Medya Gh e3ef5f9a95 address review comments 2020-06-16 15:03:56 -07:00
Medya Gh 56b5524c8e address review comments 2020-06-16 14:57:19 -07:00
Medya Ghazizadeh 16c3e95260
Merge pull request #8475 from 11janci/jjanik-fix-hostip-vbox
Fix host network interface for VBox
2020-06-16 13:40:34 -07:00