Commit Graph

713 Commits (0a0a47c2ba901b6f860a5c58a99b745f44301f90)

Author SHA1 Message Date
Anders F Björklund f23bbea995 Support more error messages for container inspect
The messages are different between "inspect" and "container inspect",
and also changed a bit in format between Podman v1 and Podman v2.

Support all of them, for compatibility with different versions of
Docker and Podman. Was causing restarts and failures, with KIC.
2020-06-28 14:19:09 +02:00
Priya Wadhwa 7c2cac612d Fix bug in FailFastError and add unit test
Since FailFastError was just another `error`, all errors were technically `FailFastErrors`.

This code makes `FailFastError` a struct which implements the error interface, so that now errors can be distinctly identified as `FailFastError`'

Also added a unit test to prove that this works now.
2020-06-26 11:58:34 -07:00
priyawadhwa 7d79241ea5
Merge pull request #8565 from priyawadhwa/update-alternatives
Check for iptables file before determining container is running
2020-06-26 11:29:52 -07:00
Priya Wadhwa e32e2135ed review comments 2020-06-25 19:39:59 -07:00
Priya Wadhwa 903686172d Check for iptables file before determining container is running 2020-06-25 17:58:22 -07:00
Thomas Stromberg 9e95435e00 Add --cni flag, fix --network-plugin=kubenet 2020-06-23 20:10:25 -07:00
Medya Gh e91e11eeba address review comments 2020-06-17 18:32:11 -07:00
Medya Gh 29e01d5dcb fix comment 2020-06-17 15:17:45 -07:00
Medya Gh dacd980fe7 add err type for start too 2020-06-17 15:15:23 -07:00
Medya Gh ca2d0f97ec move advice to its own file 2020-06-17 15:07:17 -07:00
Medya Gh 543b0b5bfa add post mortem logs when container not running 2020-06-17 13:27:17 -07:00
Medya Gh 736f5219e0 add error type for check running 2020-06-17 12:13:12 -07:00
Medya Gh 56b5524c8e address review comments 2020-06-16 14:57:19 -07:00
Medya Gh 4caf260279 add cpu count limit error type for kic drivers 2020-06-16 13:21:56 -07:00
Li Zhijian 24c9ce079d cleanup TempDir properly
a TempDir is like /tmp/minipath255070191/.minikube

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-06-16 09:34:25 +08:00
Priya Wadhwa 6ef48499b4 Code review comments 2020-06-12 11:00:46 -07:00
Priya Wadhwa b750ab4964 fix lint 2020-06-11 13:00:46 -07:00
Priya Wadhwa 330224f36a Warn user to restart daemon if context deadline is exceeded 2020-06-11 12:50:11 -07:00
Priya Wadhwa 0ec839186d Change glog.Errorf to glog.Infof so that we don't get an ugly log to stdout 2020-06-11 11:14:04 -07:00
Priya Wadhwa 15088526cd clean up comments 2020-06-04 11:05:52 -07:00
Priya Wadhwa 7dfea631d4 Refactor downloading kic base image 2020-06-04 10:48:38 -07:00
Medya Gh 488e2003f4 fix image digest 2020-05-29 12:19:59 -07:00
Medya Gh bc8c3faf86 add docker hub fall back image 2020-05-29 11:55:21 -07:00
Anders F Björklund 14937e4677 Never use docker inspect, always provide the type
Should avoid errors like: map has no entry for key "State"

When inspecting a volume, rather than a container or image
2020-05-21 17:20:53 +02:00
Asare Worae 59de926bf1 updated --docker-volume flag description and ran docs generator 2020-05-15 12:03:56 +02:00
Asare Worae 1909c4bb7c add support for `--docker-volume` command line flag to mount host volumes on start 2020-05-15 11:44:24 +02:00
Medya Ghazizadeh afab7c87c6
Merge pull request #7959 from afbjorklund/podman-prompt
Use noninteractive sudo when running podman
2020-05-11 21:02:22 +00:00
Medya Ghazizadeh d2ae2b35a0
Merge pull request #8057 from afbjorklund/podman-tar
Don't run the extraction tar container for podman
2020-05-11 19:22:48 +00:00
Medya Ghazizadeh 6b97ee8ee2
Merge pull request #8001 from afbjorklund/podman-start
podman: Wrap the start command with cgroup manager too
2020-05-11 17:59:39 +00:00
Anders F Björklund c578a7aa1e Add a PointToHost function for podman as well
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
Medya Ghazizadeh 7e3da0f8b0
Merge pull request #8017 from elegos/podman-volumes-extract-tarball-to-volume
Podman: disable selinux labels when extracting the tarball (permissions error)
2020-05-09 21:35:43 +00:00
Anders F Björklund cac41495cf Don't run the extraction tar container for podman
The preloaded images will be extracted anyway, using ssh.

But if creating them on the volume before the container is
booted, means that /var will not be fully copied over to it.
And without /var/lib/dpkg and others, kicbase will not boot.
So skip the parallel extraction for podman, do it afterwards.

Probably shouldn't mount all of /var, but just a sub-set...
2020-05-09 18:36:56 +02:00
Anders F Björklund 46025eccf5 Use the runCmd wrapper for start to not miss error 2020-05-09 14:07:18 +02:00
Anders F Björklund ac01e92012 Add comment about why podman looks at runtime.GOOS 2020-05-09 14:05:57 +02:00
Anders F Björklund a7a5148ff6 Don't add cgroup manager param for podman-remote
Since it doesn't work for either "run" or "start"

	Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
Anders F Björklund 85fae62d4a Wrap the start command with cgroup manager too
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
Anders F Björklund 934ad06a82 Use noninteractive sudo when running podman
To avoid asking for a password in the middle of minikube commands.

The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
Priya Wadhwa ba267702af Merge branch 'master' of https://github.com/kubernetes/minikube into embed-certs 2020-05-08 12:38:02 -07:00
Thomas Stromberg 436cee2d84 Fix minikube/kubernetes capitalization, make short help consistent 2020-05-07 14:12:10 -07:00
Priya Wadhwa 163ab88408 Restart kubelet in a function that is called on soft start 2020-05-07 13:22:09 -07:00
Priya Wadhwa a353d564dd Add comments 2020-05-07 13:03:07 -07:00
Priya Wadhwa c037a97392 Restart kubeadm on soft `minikube start`
This should resolve a race condition in which the expected node IP and the ip passed into kubelet are different.

This should fix the embed-certs integration test which has been flaky for a while.
2020-05-07 12:59:55 -07:00
Giacomo Mr. Wolf Furlan 9c43c47b06 Podman: disable selinux labels when extracting the tarball to prevent permission errors 2020-05-07 02:09:09 +02:00
Medya Gh 7914d057d1 fall back to github if gcr.io is not available 2020-05-04 13:12:50 -07:00
Medya Ghazizadeh 6eeb929b3d
Merge pull request #7962 from afbjorklund/podman-gateway
Get the gateway by inspecting container network
2020-05-04 20:05:56 +00:00
Medya Ghazizadeh 1da92a1c84
Merge pull request #7961 from afbjorklund/podman-preload
Use the correct binary for unpacking the preload
2020-05-04 20:04:19 +00:00
Medya Ghazizadeh e0685c8f5d
Merge pull request #7984 from medyagh/detect_windows_container
Detect windows container and exit with instructions
2020-05-04 20:01:17 +00:00
Anders F Björklund cc6506d2c9 Remove logging statement from containerGateway 2020-05-03 09:42:32 +02:00
Medya Gh bcecda8e20 add comment for error type 2020-05-02 18:48:52 -07:00
Medya Gh 2102a20605 wrap errors 2020-05-02 18:38:23 -07:00
Medya Gh 4572d0634f exit with usage if container type is windows 2020-05-02 18:29:33 -07:00
Medya Gh ee9004f93b add os type to DaemonInfo 2020-05-02 17:02:19 -07:00
Anders F Björklund 743f9f7efc Don't show any podman hint about restarting sudo 2020-05-01 22:21:32 +02:00
Anders F Björklund e2d7d94dfc Use the correct binary for unpacking the preload
Previously hardcoded to *always* use a Docker volume,
even if using a different container driver (podman).
2020-05-01 22:11:28 +02:00
Anders F Björklund 3531efda7b Get the gateway by inspecting container network 2020-05-01 15:05:21 +02:00
Thomas Strömberg 7b39b102d6
Merge pull request #7930 from sharifelgamal/cni
Automatically apply CNI on multinode clusters
2020-04-29 09:14:38 -07:00
Thomas Strömberg dee6d518ce
Merge pull request #7631 from afbjorklund/podman-sudo
Add "sudo" to podman calls
2020-04-29 08:53:41 -07:00
Thomas Strömberg 2f78bff4ed
Merge pull request #7858 from priyawadhwa/upgrade-kic
Upgrade docker driver base image to v0.0.10
2020-04-29 08:48:45 -07:00
Anders F Björklund 78a22f5056 Remove prefix parameter and add prefix command
Move the "sudo" prefix to a central location, instead of
having it all over the place. Assume only needed on Linux.
2020-04-28 13:52:52 +02:00
Sharif Elgamal 5848bbe011 Merge branch 'master' of github.com:kubernetes/minikube into cni 2020-04-27 14:15:19 -07:00
Sharif Elgamal 228c1b092c automatically apply kic overlay when detecting multinode clusters 2020-04-27 14:15:12 -07:00
Anders F Björklund 1744ffe773 Restore the configured state added for podman
Reverted 22aa1aff22 by accident
2020-04-27 22:27:53 +02:00
Priya Wadhwa 2459caea75 update SHA 2020-04-27 10:47:10 -07:00
Anders F Björklund 998ab840fb Use simple version of podman info format parameter
So that it works with the older versions of podman
2020-04-26 22:54:45 +02:00
Anders F Björklund 795128131f Remove old Copy function added in merge conflict 2020-04-26 22:52:10 +02:00
Anders F Björklund 28106fa2d7 Use constants instead of the KIC prefix strings 2020-04-26 15:22:57 +02:00
Anders F Björklund 88c8a24d55 Pass the container implementation on to systemd 2020-04-25 22:43:40 +02:00
Anders F Björklund 7185140c57 Remove extra quotes added in conflict resolution
Reverted f264ac171e by accident
2020-04-25 22:09:52 +02:00
Anders F Björklund 7647b1f998 Don't try to limit podman memory without cgroup
Podman requires both memcg and memcg_swap for it (--memory).

Docker will still limit memory, without swap limit support.
2020-04-25 22:01:51 +02:00
Anders F Björklund 6644c5cc64 Merge branch 'master' into podman-sudo 2020-04-25 18:05:33 +02:00
Medya Gh 63f9bfbb61
addres review comments 2020-04-24 14:07:54 -07:00
Medya Gh ef01ed481c
get rid of global CliRunner 2020-04-23 14:37:03 -07:00
Medya Gh 17f420cc71
warn slow part of cli runner 2020-04-23 01:23:49 -07:00
Medya Gh d9f1b532d0
unexport warnIfSlow func 2020-04-23 00:33:59 -07:00
Medya Gh 038aef6b48
unexport warnIfSlow func 2020-04-23 00:33:40 -07:00
Medya Gh 8a0a210763
convert more funcs to use cli runner 2020-04-23 00:29:37 -07:00
Medya Gh c6e1445ccb
convert more to cli runner 2020-04-23 00:12:41 -07:00
Medya Gh 29df4260ef
make all oci volume calls go through runner 2020-04-22 23:27:54 -07:00
Medya Gh 915058ef8e
lint 2020-04-22 23:01:04 -07:00
Medya Gh 72baa1dad2
convert execs to cliRunner 2020-04-22 22:49:48 -07:00
Medya Gh c6895c2058
add cli runner to info 2020-04-22 22:34:11 -07:00
Medya Gh fad745f607
adding runner for oci package 2020-04-22 22:16:18 -07:00
Priya Wadhwa d39b822a3c upgrade to v0.0.10 2020-04-22 14:44:24 -07:00
Medya Gh b639c6112d
fix delete and add integeration test 2020-04-20 20:38:31 -07:00
Medya Gh 366dc8d127
add helper for img plull command 2020-04-20 13:13:37 -07:00
Medya Gh d2415d778e
add json parser for critcl images 2020-04-19 20:36:22 -07:00
Medya Gh ac66bf2f90
first working version 2020-04-19 19:59:50 -07:00
Medya Gh c017c98e81
add preload funcs for containerd 2020-04-19 19:33:11 -07:00
Anders F Björklund 19be5619d6 Resource limits seem to work ok when not rootless 2020-04-19 09:45:16 +02:00
Anders F Björklund 024cd6b108 Use the same kind of named /var mount for podman
The internal anonymous mounts do not seem to have the same
issues as the external path mounts, so we can do all of /var
2020-04-19 09:45:16 +02:00
Anders F Björklund 8987b1067a Also persist the kubelet and the cni state dirs 2020-04-19 09:45:16 +02:00
Anders F Björklund 223424652c Also create and mount the container runtime dirs 2020-04-19 09:45:16 +02:00
Anders F Björklund df3aec6b0a Missed to wrap one podman inspect in sudo proper 2020-04-19 09:45:16 +02:00
Anders F Björklund f57faf8036 Only remount the /var/lib/minikube directory 2020-04-19 09:45:16 +02:00
Anders F Björklund 22aa1aff22 Handle more state and status for the podman driver 2020-04-19 09:45:16 +02:00
Anders F Björklund f264ac171e Remove extra single-quotes from format parameter
podman
	Error: template parsing error: template: image:1: function "json" not defined
2020-04-19 09:42:17 +02:00
Anders F Björklund d7dc7bf7b2 The podman driver should not be run as root
Use sudo for the podman commands instead

Wrap the docker commands with env prefix
2020-04-19 09:42:17 +02:00
Medya Ghazizadeh 825ba532d1
Merge pull request #7603 from alonyb/w/add-registery-addon
Add registry addon feature for docker on mac/windows
2020-04-17 19:50:43 -07:00
Alonyb bfa45ef79a delete unnecesary func 2020-04-16 19:49:26 -05:00
Medya Gh 891e7a6520 spell 2020-04-16 16:53:04 -07:00
Medya Gh bf15f9a00c fix build err 2020-04-16 16:20:04 -07:00
Medya Gh 934f900f16 improve kic start and kill 2020-04-16 16:10:44 -07:00
Medya Gh 1c125e78da address review comments 2020-04-15 10:17:23 -07:00
Alonyb 62904e5dcc fix lint 2020-04-15 09:30:10 -05:00
Medya Gh 34fafc783f fine tune 2020-04-14 22:20:28 -07:00
Medya Gh 29280ceff6 lint 2020-04-14 21:33:21 -07:00
Medya Gh 7303ccf07d lint 2020-04-14 21:31:12 -07:00
Medya Gh 54aa958f01 use oci to delete 2020-04-14 20:51:18 -07:00
Medya Gh b2bcd9a5cb allow SSH commands to run in kic driver 2020-04-14 20:26:10 -07:00
Medya Gh f22a36332e add shut down to stop 2020-04-14 20:21:40 -07:00
Medya Ghazizadeh b913981fd9
Merge pull request #7658 from medyagh/kic_apparmor
unconfine apparmor for kic
2020-04-14 19:39:35 -07:00
Medya Gh d4b48e1e05 clean up after test dirs 2020-04-14 19:33:26 -07:00
Medya Gh b7f0bfc369 unconfine apparmor for kic 2020-04-13 16:44:17 -07:00
Ruben Baez d372027b03
Merge pull request #4 from alonyb/patch-1
documentation
2020-04-10 20:11:42 -05:00
Alonyb 201a2bbc62 remove driver and use clusterConfig 2020-04-10 18:50:57 -05:00
Alonyb c4ef1b3798 add return port logic 2020-04-10 14:46:31 -05:00
Alonyb 50c2ec4eaf add oci port mapping of registery 2020-04-10 08:20:12 -05:00
Medya Gh 4dd2152fae update crio version in kicbase 2020-04-10 01:42:58 -07:00
Medya Gh 1eb6ce1710 build error 2020-04-09 21:56:00 -07:00
Medya Gh e7e9f3ca1c address review comments 2020-04-09 21:50:09 -07:00
Medya Gh 983808f956 lint 2020-04-09 21:01:49 -07:00
Medya Gh f7f04a83c2 add killing apiserver proc to both kic and none 2020-04-09 20:53:15 -07:00
Medya Gh ded8273a2e add kill containers to kic stop 2020-04-09 20:01:11 -07:00
Priya Wadhwa 3a12fbd1f5 Fix spelling 2020-04-09 10:50:20 -07:00
Thomas Strömberg 6d05265a2e
Merge pull request #7539 from tstromberg/openrc
none: Add support for OpenRC init (Google CloudShell)
2020-04-09 04:55:57 -07:00
Thomas Strömberg a37ec2ecd7
Merge pull request #7189 from Hellcatlk/UnitTest
add unit test for pkg/drivers/hyperkit/iso.go
2020-04-09 04:22:58 -07:00
Thomas Stromberg 16a8c38682 none: Add support for OpenRC init (Google CloudShell) 2020-04-08 18:20:30 -07:00
Priya Wadhwa 70329bf51d Code review comments 2020-04-08 13:44:04 -07:00
Priya Wadhwa accba6aa7f code review comments 2020-04-07 15:00:28 -07:00
Priya Wadhwa b509d69182 Extract preloaded tarball as soon as minikube volume is created
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallell with creating the container node and setting up SSH.

This shaves 2-3 secnods off of `node.StartHost`
2020-04-07 14:19:20 -07:00
Medya Gh a0263c2513 adjust more 2020-04-03 20:59:03 -07:00
Medya Gh a62d611e0b adjust kill time 2020-04-03 20:59:03 -07:00
Medya Gh 8f51d7de58 adjust warn if slow for ps and volume 2020-04-03 20:59:03 -07:00
Thomas Strömberg 37a98106c4
Merge pull request #7382 from tstromberg/stderr-fix3
Move errors and warnings to output to stderr
2020-04-02 14:36:16 -07:00
Thomas Stromberg 5307145802 Move errors and warnings to output to stderr 2020-04-02 09:58:13 -07:00
Thomas Stromberg c76fac7d74 Standardize port-forwarding and kubeconfig hostname logic, fix Docker Linux IP 2020-04-01 11:57:32 -07:00
Thomas Stromberg 2f2dccd30c Remove test values 2020-03-26 14:05:02 -07:00
Thomas Stromberg 46f31480df Make slow command detection consistent across kic/oci 2020-03-26 14:03:22 -07:00
Priya Wadhwa 9d75c7c35a Rebased, resolved merge conflicts 2020-03-25 10:07:58 -07:00
Medya Ghazizadeh 5689d3b8e1
Merge pull request #7210 from priyawadhwa/issue-7184
Fix TestStartStopWithPreload bug
2020-03-24 22:42:33 -07:00
ZouYu 2e9054f495 add unit test for pkg/drivers/hyperkit/iso.go
Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>
2020-03-25 11:08:27 +08:00
Priya Wadhwa d2171be291 rebased' 2020-03-24 16:39:54 -07:00
Priya Wadhwa 1d72a1c826 don't extract volume if tarball doesn't exist 2020-03-24 15:01:31 -07:00
Medya Ghazizadeh f00f5ff600
remove extra if 2020-03-24 10:21:32 -07:00
Medya Gh 940baa09ea fix comment 2020-03-24 07:31:22 -07:00
Medya Gh 41b16b1568 fail if container is not running 2020-03-24 07:27:07 -07:00
Medya Gh 83cc28e082 add logging for when container status is running 2020-03-24 07:11:22 -07:00
Medya Ghazizadeh 587154196e
Merge pull request #7173 from medyagh/stop_kic
stop kubernetes containers on stopping docker/podman driver
2020-03-24 05:42:49 -07:00
Medya Gh 67bd258465 remove extra line 2020-03-23 23:02:27 -07:00
Medya Gh aec6fdc25a initialize kic runner in stop 2020-03-23 21:01:12 -07:00
Medya Gh 7619a5075a fix logging 2020-03-23 21:01:12 -07:00
Medya Gh 36f3f657af force stop if cant stop for none 2020-03-23 21:01:12 -07:00
Medya Gh 545348341a for none let it stop all containers 2020-03-23 21:01:12 -07:00
Medya Gh 47c8e9c87b dont return on error kic sto 2020-03-23 21:01:12 -07:00
Medya Gh 5f90a319bd stop k8s in kic and none 2020-03-23 21:01:12 -07:00
Medya Gh fae3e34319 add stop force stop 2020-03-23 20:59:21 -07:00
Medya Gh 298be78e5f remove duplicate code 2020-03-23 20:59:21 -07:00
Medya Gh beec3b1ce1 stop kubelet on docker stop 2020-03-23 20:59:21 -07:00
Priya Wadhwa abf35cfbc1 Upgrade podman and add libglib2.0-0 to kicbase image
The `TestOffline/group/crio` integration test was failing with the error:

```
crio load image: sudo podman load -i /var/lib/minikube/images/storage-provisioner_v1.8.1: exit status 125
```

I tried SSH'ing into minikube and running the command myself, and got the error:

```
Error: could not get runtime: please update to v2.0.1 or later: outdated conmon version
```

I then tried updating conmon, but got the error:

```
conmon: error while loading shared libraries: libglib-2.0.so.0: cannot open shared object file: No such file or directory
```

I then tried adding the libglib2.0-0 library to the kic base image and upgrading podman, which seems to have resolved the issue.
2020-03-23 17:41:06 -07:00
Priya Wadhwa bfe8aee3b5 Pass in container runtime to preload tarball name
This way we don't have to individually check if we support a container runtime
2020-03-23 12:29:49 -07:00
Priya Wadhwa 0e5974367f rebased on master' 2020-03-23 10:59:02 -07:00
vikkyomkar f54af5d684 function name HostPortBinding changed to ForwardedPort 2020-03-14 21:28:12 +05:30
Priya Wadhwa 89c6c72adb Skip preload if not running on amd64
Also make sure that preload is available before attempting to run preload.
2020-03-13 16:24:28 -07:00
Thomas Stromberg 895967235a Improve error message output 2020-03-13 16:18:14 -07:00
Thomas Stromberg 196a8d7b82 Delete: output underlying status failure, refactor wordy code 2020-03-13 15:51:03 -07:00
Medya Gh 70c9304724 code review comments 2020-03-13 10:37:29 -07:00
Medya Gh 99ba89c2dd ip 2020-03-12 16:01:49 -07:00
Medya Gh 084da0c46a fix maybe 2020-03-12 15:31:38 -07:00
Thomas Stromberg 43ce409e79 Extra debugging for preload generation process 2020-03-11 13:09:55 -07:00
Medya Gh b5681d52c5 lint 2020-03-10 18:45:56 -07:00
Medya Gh 9ff0dc0ebc pass api server port to kic create container 2020-03-10 18:33:59 -07:00
Thomas Stromberg 9ac1ad2a7e Merge master 2020-03-06 16:13:54 -08:00
Thomas Stromberg e027dfc4d2 More unused code cleanup 2020-03-06 15:57:12 -08:00
Thomas Stromberg 3fee641a13 Remove remaining PointToHostDockerDaemon calls 2020-03-06 15:15:05 -08:00
Medya Gh a58a9f0176 tweak 2020-03-06 15:13:56 -08:00
Medya Gh cb14468b44 english 2020-03-06 15:11:42 -08:00
Medya Gh cdb8f9c3f6 make sure container is running after create 2020-03-06 15:08:39 -08:00
Thomas Stromberg 6f46393123 Remove blank line 2020-03-06 12:15:58 -08:00
Thomas Stromberg 120dce7b56 Remove extraneous calls to oci.PointToHostDockerDaemon 2020-03-06 12:13:51 -08:00
Medya Gh 38ccb88e3f address code review 2020-03-06 10:25:48 -08:00
Medya Gh 1c37fc5505 lint 2020-03-05 22:45:38 -08:00
Medya Gh 0335fb1ad7 change names 2020-03-05 22:38:47 -08:00
Medya Gh 2a37317a72 improve comment 2020-03-05 22:34:10 -08:00
Medya Gh 1e8dd94a77 fix logic 2020-03-05 22:31:44 -08:00
Medya Gh e1f6820335 fix already in use 2020-03-05 16:42:56 -08:00
Thomas Stromberg 1f7ae5b35b Merge to master 2020-03-05 09:57:46 -08:00
Thomas Stromberg a1ebcbd031 Merge conflicts 2020-03-04 18:01:41 -08:00
Sharif Elgamal 0ff12cafac Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-04 16:37:54 -08:00
Sharif Elgamal a3e000d850 addressing comments 2020-03-04 14:09:15 -08:00
Medya Gh f40c5a7b30 move funcs arround 2020-03-04 12:50:01 -08:00
Medya Gh db5903d3ed lint 2020-03-04 10:40:32 -08:00
Medya Gh 54df61d677 point to host daemon more places 2020-03-04 10:37:10 -08:00
Medya Gh 6a62046e62 add warning and point to right docker 2020-03-04 10:22:20 -08:00
Sharif Elgamal 28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename 2020-03-03 12:16:47 -08:00
Sharif Elgamal 31a42ce672
address comments 2020-03-02 17:30:08 -08:00
Priya Wadhwa 05a46f6526 remove unnecessary PreloadedVolume 2020-03-02 16:17:35 -08:00
Sharif Elgamal 4cd3ef81a5
more changes 2020-03-02 15:21:37 -08:00
Priya Wadhwa 481010d8dc added overlay2 to preloaded images tarball name 2020-03-02 14:10:41 -08:00
Priya Wadhwa d6e94c1ee4 remove unused functions 2020-03-02 13:54:35 -08:00
Priya Wadhwa 474561d082 remove unused functions 2020-03-02 13:48:18 -08:00
Priya Wadhwa 697359b4f3 Fixed lint 2020-03-02 13:37:22 -08:00
Priya Wadhwa 6b0e942e7e Rebased on master 2020-03-02 13:33:27 -08:00
Medya Ghazizadeh 3cf2c9bbe3
Merge pull request #6807 from medyagh/delete_hang
warn about "stuck docker"  in minikube delete
2020-02-26 14:32:18 -08:00
Medya Gh 8d0c41392b continue instead of nest 2020-02-26 13:50:42 -08:00
Medya Gh 4709af55df resolve review comments 2020-02-26 12:44:25 -08:00
Medya Gh e8c85543f7 limit time waiting for delete 2020-02-26 10:57:46 -08:00
Medya Gh 6651e0b5a5 docker podman sysinfo 2020-02-26 09:15:25 -08:00
Medya Gh f3c171eaa3 show info for docker damemon 2020-02-25 17:34:03 -08:00
Medya Gh e60b034c84 Add Daemon Info func to oci 2020-02-25 17:16:49 -08:00
Priya Wadhwa aefbf2cd18 Rebased on master 2020-02-24 13:41:06 -08:00
Medya Gh 5f8740a15e update kic sha 2020-02-22 15:41:12 -08:00
Medya Gh 988a1b983a fix sha format 2020-02-22 14:23:43 -08:00
Medya Gh 73c4c4c323 bump kic version to 7 2020-02-22 14:07:43 -08:00
Medya Gh 95402af363 bump kic version 2020-02-22 13:51:42 -08:00
Medya Gh 9b91ef7590 Add CIO-o runtime to kic drivers and improve kic image 2020-02-22 13:46:17 -08:00
Anders F Björklund fa9f7f9794 Add comments to avoid warnings from go lint 2020-02-22 16:12:42 +01:00
Priya Wadhwa 97bf128703 only use preloaded volumes for docker runtime 2020-02-21 12:53:24 -08:00
Priya Wadhwa 328466f1e1 Check if preloaded volume is attached before skipping binary transfer 2020-02-21 12:41:33 -08:00
Priya Wadhwa cc1a6f11f0 Delete volume if it isn't extracted properly so future runs don't try to use it 2020-02-21 12:13:34 -08:00
Priya Wadhwa c99bf76ee4 Add checksum verification 2020-02-21 12:03:31 -08:00
sayboras 4201bbcfe3 Address one simple linter error 2020-02-21 14:55:22 +11:00
Priya Wadhwa 86df9ffb2c Rebased on master 2020-02-20 16:20:54 -08:00
Priya Wadhwa dcbf242192 Add SHA as constant 2020-02-20 15:56:00 -08:00
Priya Wadhwa 94737b4a14 Add lz4 to kic base image and upgrade to v0.0.6 2020-02-20 15:53:09 -08:00
Priya Wadhwa 55dd40efc5 Debugging 2020-02-20 15:05:07 -08:00
Priya Wadhwa 5ac8520ab8 skip transferring binaries and transferring imagse if using preloaded volume 2020-02-20 14:59:43 -08:00
Priya Wadhwa b0f685c072 Move all preloading code into preload package 2020-02-20 14:43:24 -08:00
Medya Ghazizadeh 7fddd05bf5
Merge pull request #6630 from medyagh/mount_kic
add mount feature to kic drivers
2020-02-20 14:11:15 -08:00
Priya Wadhwa 19fa296625 Compress with lz4 2020-02-20 14:07:03 -08:00
Priya Wadhwa 0e88697f16 Delete container once it has finished executing 2020-02-20 10:06:15 -08:00
Priya Wadhwa 055e4bb618 Add run to docker command 2020-02-20 09:57:19 -08:00
Priya Wadhwa 335637f4a3 Name tarball by k8s version name 2020-02-20 09:42:04 -08:00
Priya Wadhwa b8bc461157 Rebased on master 2020-02-20 09:18:12 -08:00
Medya Gh 30a38e5a9d wrap error 2020-02-20 00:07:36 -08:00
Medya Gh 4fe9ca5f05 break done delete and prune into two funcs better error handling 2020-02-20 00:07:36 -08:00
Medya Gh e1ffa5fb0f return error instead of logging 2020-02-20 00:07:36 -08:00
Medya Gh 354ff6256d improve comments 2020-02-20 00:07:36 -08:00
Medya Gh 6c94880149 dont list empty ones 2020-02-20 00:07:36 -08:00
Medya Gh d84aa9f447 lint 2020-02-20 00:07:36 -08:00
Medya Gh b1d139c24b code review comments 2020-02-20 00:07:35 -08:00
Medya Gh efd4aabde4 clean up containers first then delete volume 2020-02-20 00:07:35 -08:00
Medya Gh b235255196 fix volume clean up 2020-02-20 00:07:35 -08:00
Priya Wadhwa bb11bc666b Create volume of preloaded images and mount it in 2020-02-19 23:02:36 -08:00
Medya Gh 597798395f lint 2020-02-19 22:01:45 -08:00
Medya Gh 3a7041c3b2 add logging 2020-02-19 22:01:45 -08:00
Medya Gh d548eabdc6 added kic mount 2020-02-19 22:01:45 -08:00
Medya Gh 1ee08c7517 add funcs to get routable host ip from inside container 2020-02-19 22:01:45 -08:00
Priya Wadhwa d506aa18b4 Download preloaded images tarball with --download-only flag 2020-02-19 21:53:44 -08:00
Medya Gh 1da0a370ff code review comments 2020-02-17 10:55:53 -08:00
Medya Gh 3ce0164281 add logging for prune 2020-02-16 11:54:56 -08:00