cb116e4c1c
Add --listen-address for docker driver
2021-02-28 23:14:08 +01:00
fd506460b3
Add README for mkcmp
2021-02-26 13:00:19 -08:00
abb403645e
Merge pull request #10617 from ariesliuwei/logche
...
migrate some logs to structured logging
2021-02-25 11:32:10 -08:00
80219cfa70
Merge pull request #10616 from ariesliuwei/logmod
...
Migrate kubectl logs to structured logging
2021-02-25 11:31:30 -08:00
33146eac8e
Merge pull request #10615 from ariesliuwei/ari-logfix
...
Migrate kubectl logs to structured logging
2021-02-25 11:30:50 -08:00
5788d43116
Migrate some logs to structured logging
2021-02-25 18:59:21 +08:00
6ea237047b
Migrate kubectl logs to structured logging
2021-02-25 18:47:40 +08:00
f939910a94
Migrate kubectl logs to structured logging
2021-02-25 17:41:38 +08:00
828769b816
Merge pull request #10606 from spowelljr/fixOutOfRange
...
Check for args length to prevent out of bounds panic
2021-02-24 16:33:09 -08:00
c50bdaabfe
Check for args length to prevent out of bounds panic
2021-02-24 16:45:24 -07:00
4a6f00ba4b
add todo with issue numbers
2021-02-24 13:15:36 -08:00
73772286eb
address review comments
2021-02-24 13:07:25 -08:00
1bd0b6daae
add final touch
2021-02-24 12:30:06 -08:00
a162f26f4a
spell
2021-02-24 12:30:06 -08:00
8739e20fef
update addon name
2021-02-24 12:30:06 -08:00
21d9f50e9c
adding channels
2021-02-24 12:30:06 -08:00
191e116d04
autopause prototype
2021-02-24 12:30:06 -08:00
44a256bc53
add auto-pause binary
2021-02-24 12:30:06 -08:00
460342a5f2
Merge pull request #10575 from hetong07/issue_10519
...
Improve the error message of setting cgroup memory limit.
2021-02-24 11:53:54 -08:00
34db47e956
Merge pull request #10465 from spowelljr/addLastStart
...
Add last start logs to minikube logs output
2021-02-24 10:52:26 -07:00
57d33de86a
Merge pull request #10554 from afbjorklund/drivers-default
...
Don't select Discouraged or Obsolete by default
2021-02-23 17:21:23 -08:00
2ef49ae05c
Merge pull request #10321 from BLasan/issue-8040
...
Move DeletePossibleKicLeftOver function to delete pkg
2021-02-23 17:15:50 -08:00
56cf965a7b
Rename validateMemoryFlags() -> validateChangedMemoryFlags().
2021-02-23 16:16:22 -08:00
f0902d4ba5
improved func comment
2021-02-23 16:54:00 -07:00
7098409bdc
optimized file/dir creation logic
2021-02-23 16:51:40 -07:00
48652fa952
moved import comment
2021-02-23 15:12:21 -07:00
6794f2055d
removed duplicate flag check
2021-02-23 15:04:56 -07:00
b42f8f6af2
Create logs directory if it does not exist
2021-02-23 15:03:04 -07:00
abe7d71aee
Only validate cgroup memory setting when using container as driver.
2021-02-22 23:14:17 -08:00
9a30756d38
Improve the error message of setting cgroup memory limit.
2021-02-22 20:18:22 -08:00
4e4a59901c
Don't select Discouraged or Obsolete by default
...
These drivers require either an active choice (opt-in),
or a previous configuratio (for the warning message).
2021-02-21 18:18:43 +01:00
03ae2d2aa3
Fix Rsrc Insufficient System memory issue
2021-02-21 22:46:23 +05:30
9d9aeccf23
Merge pull request #10535 from BLasan/issue-10143
...
Fix minikube kubectl context switching
2021-02-20 10:06:05 -08:00
01d47d6141
Fix minikube kubectl context switching
2021-02-20 16:37:15 +05:30
77e9751229
Merge pull request #10493 from kadern0/issue-8790
...
Improved insecure registry validation function
2021-02-19 16:22:00 -08:00
610a97067f
Fixed failing if lastStart.txt file does not exist
2021-02-19 13:54:10 -07:00
f390d1ef0b
Output last start logs during minikube logs
2021-02-19 13:54:02 -07:00
91e8c0980b
Save start logs to lastStart.txt in minikube dir
2021-02-19 13:51:44 -07:00
6934c85451
Improved insecure registry validation function
2021-02-17 18:06:00 +11:00
27d86a421f
Merge pull request #10388 from BLasan/issue-10386
...
Add condition to check --cpus count with available cpu count
2021-02-12 12:48:33 -08:00
350f8a2494
Merge pull request #10452 from ilya-zuyev/ilyaz/disable_hyperv_on_m1
...
Disable all drivers except "docker" and "ssh" on darwin/arm64
2021-02-11 17:10:10 -08:00
5c5c2169bc
Rename profile.go file as delete.go
2021-02-12 00:13:41 +05:30
bb80fe355a
Rebase changes in PR #10332
2021-02-12 00:13:41 +05:30
707e2e969b
Move DeletePossibleKicLeftOver function to profile pkg
2021-02-12 00:10:52 +05:30
3512e88020
Merge pull request #10435 from afbjorklund/podman-cleanup
...
Explicitly remove podman volume and network
2021-02-11 10:27:50 -08:00
a99d545a54
Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message
2021-02-10 17:06:20 -08:00
3caf9c0f05
Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message
2021-02-10 17:05:16 -08:00
a3609d3778
Merge pull request #10380 from daehyeok/profile_list_light
...
Add -l/--light option for profile list command.
2021-02-10 17:04:39 -08:00
af5b44df12
Fix "The driver {{.driver}} is not supported on {{.os}}/{{.arch}}" message
2021-02-10 17:03:53 -08:00
984b079821
Merge pull request #10412 from sharifelgamal/crio
...
remove crio restart hack
2021-02-10 16:55:44 -08:00
7536f4436c
Fix build constraints
2021-02-10 16:15:28 -08:00
d7beb72025
disable hyperkit driver on arm64
2021-02-10 13:47:46 -08:00
b7de621033
Explicitly remove podman volume and network
...
The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)
2021-02-10 20:57:20 +01:00
09de7ff62f
Merge pull request #10332 from priyawadhwa/delete-timeout
...
Add 5 minute timeout to deleting a profile
2021-02-10 10:40:32 -08:00
f457bde02d
Add -l/--light option for profile list command.
...
If option is true, Doens't try to get profiles from container and read
current status.
2021-02-09 16:06:09 -08:00
51ec098b05
Merge pull request #10366 from priyawadhwa/mk-image-load
...
Implement minikube image load command
2021-02-09 14:42:31 -08:00
e8945f2934
Add warning for cache add
2021-02-09 13:36:40 -08:00
6ed56d842e
Rename to delCtx
2021-02-09 10:51:51 -08:00
57ffa272c9
remove crio restart hack
2021-02-08 16:28:05 -08:00
53dad6a4ae
fix log
2021-02-08 15:26:04 -08:00
8f02a5851e
Time everything via context
2021-02-08 15:24:41 -08:00
51169d68ea
Add context to remaining necessary functions
2021-02-08 15:19:01 -08:00
a6372b35a3
Add 5 minute timeout to deleting leftover cvolumes and containers
2021-02-08 15:15:08 -08:00
9b147f788d
Merge branch 'master' of https://github.com/kubernetes/minikube into delete-timeout
2021-02-08 14:56:13 -08:00
948178711b
Add advice message to increase cpus
2021-02-08 23:22:48 +05:30
1c8944f790
Merge pull request #10395 from govargo/fix-metallb-addon
...
Fix configuration of the metallb with empty load balancing IP range
2021-02-08 09:12:48 -08:00
262d102ceb
Merge pull request #10354 from hetong07/issue_10311
...
Provide advice when running windows binary (.exe) inside WSL
2021-02-08 09:05:54 -08:00
bdac73d2fd
Put the environment check as a separate if-else clause, and make this check as early as possible.
2021-02-07 17:37:01 -08:00
b1030dc28a
Fix configuration of the metallb with empty load balancing IP range
2021-02-07 23:43:05 +09:00
cc2bf6aa15
Add condition to check --cpus count with available cpu count
2021-02-07 01:08:08 +05:30
9a9c160b3f
Move load test into functional test
2021-02-05 14:28:25 -08:00
22a65a0c12
Add --all flag to
2021-02-05 10:48:08 -08:00
0061d72be6
Merge branch 'master' of https://github.com/kubernetes/minikube into mk-image-load
2021-02-05 10:24:23 -08:00
1d63f085e4
Add command
2021-02-04 14:45:27 -08:00
6d8804e10e
Use the 'ExProgramUnsupported' as the error code for MK_WRONG_BINARY_WSL error.
2021-02-03 18:29:13 -08:00
547f506701
Rephrase the adivce, use the runtime.GOOS to check whether it is .exe binary and modify the error name to address comments in pull request.
2021-02-03 18:06:05 -08:00
289bf2fe84
Merge branch 'master' into issue_10311
2021-02-03 17:41:15 -08:00
a7489c1bba
Merge pull request #10309 from afbjorklund/ssh-address
...
Make sure that ssh driver gets an ip address
2021-02-03 11:17:07 -08:00
ad08087b44
Allow user to use --force to run windows binary inside WSL.
2021-02-02 23:48:14 -08:00
0a0f39a112
Implement minikube image load command
2021-02-02 15:47:07 -08:00
d97418828d
Merge pull request #10119 from daehyeok/profile_name
...
Don't allow profile names that conflict with a multi-node name
2021-02-02 15:12:57 -08:00
21206402a9
Check that the ssh-ip-address is a valid IP
2021-02-02 08:36:05 +01:00
4bda151a62
Fix delete var
2021-02-01 12:47:46 -08:00
d02eabb835
Add 2 minute timeout to deleting a profile
2021-02-01 12:44:43 -08:00
276ad6c7c7
First step to address #10311 : disallow running minikube.exe insided WSL.
2021-01-31 12:34:05 -08:00
f94cb815cf
Make sure that ssh driver gets an ip address
2021-01-29 17:12:23 +01:00
a00d632930
Check profile, node name to prevent duplication
...
Check profile and node name before add to prevent conflict with
machine name on multinode cluster.
2021-01-28 14:42:40 -08:00
101d39fc51
Addon custom registry:
...
* fix missing suffix when using global image repo
* support override global image repo
* change all imagePullPolicy to IfNotPresent
* fix empty global image repo suffix
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:08 +08:00
52f0e49a1e
Fix docker.io/ prefix
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:07 +08:00
de3c901c18
Implement all addons
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:07 +08:00
b949034e1a
Manage addon images in code, support custom addon images
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-27 10:33:00 +08:00
597091d84b
Merge pull request #10106 from spowelljr/userFlag
...
Add new flag --user and to log executed commands
2021-01-26 15:44:58 -08:00
24aefaebb6
Unhide --schedule flag for scheduled stop
2021-01-26 13:05:30 -08:00
7e9d58c468
The gopsutil cpu implementation changed in v3
...
Was supposed to return the number of vCPU (i.e. nproc)
Before, both "physical" and "logical" returned the same.
The returned information should match cpuinfo and lscpu:
CPU(s) = Socket(s) x Core(s) each x Thread(s) each
2021-01-26 17:48:52 +01:00
5058ef3e71
moved username validation to cmd
2021-01-25 10:57:52 -07:00
81ac8a1677
fixed user name warning possibly not matching what was checked
2021-01-25 09:45:49 -07:00
14bcd9ddec
added user flag validation and improved some test messages
2021-01-22 15:39:15 -07:00
b2623d4d4e
make a default container runtime constant so that it is easy to change in the future
2021-01-22 14:00:47 -08:00
38b74f1910
Merge branch 'master' into docker-info-err
2021-01-21 18:25:59 -08:00
6b8469e971
Split PROVIDER_DOCKER_NOT_RUNNING into more specific reason codes
2021-01-21 18:25:45 -08:00
82f7df5b56
Add user flag and log executed commands
2021-01-20 17:30:48 -07:00
fc8ef79c37
Avoid warning about the suggested memory size
...
The recommendation is to use (at least) 2048 MB *for the VM*,
which means that you will end up something like 1992 MB total.
We should not issue warnings when using the recommended size,
so lower the limit to 1900 MB (kubeadm will validate 1700 MB).
The reason it is broken is because it uses different values
for different drivers, if running a VM or on Bare Metal...
There is also no difference anymore between the "usable"
and the "recommended", so this will need revisiting later.
2021-01-20 20:20:13 +01:00
541193c945
Address review comments, rename to ssh-ip-address
2021-01-16 14:44:56 +01:00
4611e2fe76
Merge branch 'master' into generic
2021-01-16 14:34:04 +01:00
8b76fa2c46
Merge pull request #10126 from medyagh/extension_context
...
add annotation to kubeconfig to identify contexts/clusters created by minikube
2021-01-14 17:23:17 -08:00
c6a27bd9ea
Merge to master
2021-01-14 14:22:55 -08:00
5ddf54b32f
refactor to make testable
2021-01-14 10:01:35 -08:00
abb556f7f5
Merge branch 'master' into generic
2021-01-13 20:15:17 +01:00
787591a6a2
Merge pull request #10109 from lingsamuel/fix-docker-env
...
Ignore non-socks5 ALL_PROXY env var when checking docker status
2021-01-12 13:50:46 -08:00
b2121eae39
Rename the generic driver to the ssh driver
...
Now that we have forked the machine driver
2021-01-09 14:36:32 +01:00
6ec94aa064
Merge to master
2021-01-08 15:40:24 -08:00
66a671fc86
Experimental macOS/arm64 work
2021-01-08 15:38:31 -08:00
36d94a2d88
Migrate MachineName function.
...
Migrate MachineName function from driver package to config package.
2021-01-08 11:26:10 -08:00
d51443bee1
Show remote host info and proper progress
2021-01-08 16:38:27 +01:00
39218369c0
Improve help text for generic driver flags
2021-01-08 07:55:28 +01:00
749843248e
Merge branch 'master' into generic
2021-01-08 07:53:49 +01:00
e127bc23fe
Ignore non-socks5 ALL_PROXY env var when checking docker status
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2021-01-08 12:04:36 +08:00
857e0a2089
Merge pull request #10100 from priyawadhwa/force-systemd-containerd
...
Add support for systemd cgroup to containerd runtime
2021-01-07 11:26:50 -08:00
0b522445ad
update flag and documentation
2021-01-06 14:38:15 -08:00
72a0fd6642
Move the constants for flag defaults from drivers
...
Not using the default libmachine drivers anymore
2021-01-06 20:24:50 +01:00
a3b3b55ac0
Add helper for checking the generic driver name
2021-01-06 18:18:00 +01:00
2b5c5b9202
Try to uninstall kubernetes on delete, for generic
2021-01-06 18:03:46 +01:00
c07666957a
Don't download ISO for the generic VM driver
2021-01-06 18:03:46 +01:00
00763352b6
Add minikube support for the "generic" VM driver
...
This driver connects to an already existing virtual machine,
using the provided IP address and SSH user/key/port parameters.
On this machine, libmachine will provision the docker daemon
and minikube will bootstrap the kubernetes cluster (as usual).
2021-01-06 18:03:43 +01:00
7fa6d545d7
Change warning
2021-01-04 07:31:41 +00:00
58dedbbb18
Delete the existing cluster if guest driver mismatch
2021-01-02 08:35:02 +00:00
6d763a1cc7
Merge pull request #9955 from daehyeok/delete_machine_dirs
...
Delete subnode's machine directories
2020-12-30 22:23:20 -08:00
3dac483db9
Merge pull request #10028 from azhao155/yzhao/fix/dockerEnvLog
...
Change exit to warning if can't restart docker in docker-env cmd
2020-12-23 18:00:19 -08:00
b11190c64e
Delete subnode's machine directories
2020-12-23 14:06:26 -08:00
e210a72bfa
update warning
2020-12-23 14:03:10 -08:00
322efcb406
Merge branch 'master' of https://github.com/kubernetes/minikube into network-flag
2020-12-23 14:02:22 -08:00
9a0be2e2d2
Merge pull request #10037 from afbjorklund/kubeadm-memory2
...
The kubernetes memory requirement is for the total
2020-12-23 13:53:05 -08:00
402d31b195
The kubernetes memory requirement is for the total
...
The kernel will reserve some memory for itself, so if you want
1700 MB free you need to allocate 1800 MB for the VM hardware.
The recommendation is still 2048 (or 2000), with an even 2.0 GiB.
So let's increase the old values with +100, for ~60 overhead.
2020-12-23 22:32:56 +01:00
68181145bd
Add error in the log
2020-12-23 21:05:43 +00:00
f68005724c
Merge pull request #9958 from tstromberg/vmwarefusion
...
Remove obsolete 'vmwarefusion' driver, add friendly message
2020-12-23 12:56:05 -08:00
1413d267b2
The kubeadm bootstrapper now requires 1700M mem
...
The node requirement is 2 vCPU and 2.0 GiB RAM
You can use --force to bypass the requirement
2020-12-23 21:09:30 +01:00
6460b61b75
Change exit to warning if can't restart docker in docker-env cmd
2020-12-23 01:48:26 +00:00
81f00fc3e3
update description
2020-12-21 16:58:49 -08:00
167b6c4399
Merge pull request #10021 from azhao155/yzhao/feature/dockerEnvWaitForApiServerFixCommits
...
Replace fixed time wait with wait function for docker-env cmd
2020-12-21 16:18:14 -08:00
c300a0545a
Merge pull request #9977 from kadern0/issue-8790
...
Added validation for --insecure-registry values
2020-12-21 16:17:14 -08:00
3172a6ddfc
change log level and change wait function to private
2020-12-21 23:19:41 +00:00
f698ccb52d
Increase time out to 30 s
2020-12-21 20:36:34 +00:00
96104205af
fix lint
2020-12-21 20:35:49 +00:00
bb83ce154e
Fix lint
2020-12-21 20:34:33 +00:00
a31b851b31
docker-env cmd wait for api server to be up
2020-12-21 20:32:03 +00:00
dbbe06664c
Added validation for --insecure-registry values
...
Fixes 8790
2020-12-20 10:00:17 +11:00
53d59d2c82
remove experimental warning for multinode
2020-12-17 11:13:46 -08:00
78163cfb90
Merge pull request #9630 from afbjorklund/ssh-host
...
Add ssh-host command for getting the ssh host keys
2020-12-17 08:09:29 -08:00
55f496492c
fix merge conflict
2020-12-16 10:37:51 -08:00
fdab252f4f
Merge pull request #9873 from lingsamuel/node-param-for-ip-and-ssh-key
...
Add --node option for command `ip` and `ssh-key`
2020-12-16 08:17:24 -08:00
e5f06a1f13
Remove the vmwarefusion driver
2020-12-14 11:10:43 -08:00
375d25db07
Update start_flags.go
...
Using slicing technique in the place of an Array for line 141.
2020-12-14 15:12:12 +05:30
7822a4e36e
Add option to add the ssh-host key to known_hosts
...
This matches the ssh-add command for identity keys,
it will add the host key to the ssh known_hosts file.
If a ssh key for the host already exists in the file,
it will not be added again so can be run multiple times.
2020-12-12 18:54:33 +01:00
a387989c72
Add ssh-host command for getting the ssh host keys
...
This is similar to the existing minikube "ssh-key" command, but gets
the content of the host key instead of the path to the identity key.
The output of this command can be added to the ~/.ssh/known_hosts,
for strict host key authentication. For instance when using Docker.
2020-12-12 18:54:33 +01:00
dbdbad6e69
Remove obsolete mention of kvm driver, fixes generate-docs issue
2020-12-11 12:43:18 -08:00
86b9397910
Merge pull request #9888 from tharun208/feat/kubeconfig_status_name
...
added statusName for kubeconfig
2020-12-11 10:20:33 -08:00
e96b05e45e
Merge pull request #9875 from sadlil/kindnet-podcidr
...
Fix multi node two pods getting same IP and nodespec not having PodCIDR
2020-12-10 16:53:29 -08:00
fc10bca4ae
Enable KindNet CNI only if multi node is specified
2020-12-10 18:40:20 +00:00
48c5d2a03d
Merge pull request #9833 from lingsamuel/fix-node-start-master
...
Fix `node start` master node
2020-12-09 14:08:14 -08:00
877f1553d8
Merge pull request #9548 from afbjorklund/docker-env-ssh
...
Optionally use ssh for docker-env instead of tcp
2020-12-09 12:22:17 -08:00
6be118fc29
Merge pull request #9634 from dekkers/saving-extra-config
...
Fix --extra-config when starting an existing cluster
2020-12-09 11:27:03 -08:00
c0a092e6af
Merge pull request #9379 from Git-Jiro/none_driver_nonroot
...
Make none driver work as regular user (use sudo on demand)
2020-12-09 10:21:49 -08:00
af3f1cfe38
added statusName for kubeconfig
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-09 11:08:15 +05:30
83f9bd1df3
Merge pull request #9793 from tharun208/feat/show_scheduled_stop_status
...
feat(minikube) display scheduledstop status in minikube status
2020-12-08 11:42:06 -08:00
3e670f24e0
Merge pull request #9789 from tharun208/fix/config_memory
...
fix unable to set memory in config
2020-12-08 10:29:11 -08:00
0898ca21e4
Merge pull request #9801 from afbjorklund/podman-env-existing
...
Add support for restoring existing podman env
2020-12-08 10:25:50 -08:00
b9eedce002
Add -n, --node option for `ip` and `ssh-key`
2020-12-07 15:59:49 +08:00
278f44899e
Fix `node start` master node
2020-12-07 09:30:35 +08:00
45befa0c1d
Merge branch 'master' into docker-env-ssh
2020-12-05 13:07:29 +01:00
4ca4491124
fixed review feedbacks on clusterstate field and tests
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:34:14 +05:30
3f57033c60
added timetostop status in cluster layout
2020-12-05 14:33:39 +05:30
81e27dd7b4
fixed review feedbacks
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:33:39 +05:30
1b2076122e
feat(minikube) display scheduledstop status in minikube status
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-12-05 14:33:39 +05:30
cd683b3ab5
Fix whitespace issues for goimports
2020-12-05 09:47:29 +01:00
114faa7d97
Merge pull request #9797 from msedzins/issue_9335
...
Ability to use a custom TLS certificate with the Ingress
2020-12-04 12:45:51 -08:00
f373155d55
merge conflict
2020-12-03 10:56:41 -08:00
8c2e03b2a7
Fix missing InitialSetup in `node start`
...
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
2020-12-03 11:22:44 +08:00
8fc54b430b
Merge pull request #9716 from afbjorklund/podman-network
...
Add private network implementation for podman
2020-12-02 14:16:41 -08:00
e1aa07feb2
Ability to use a custom TLS certificate with the Ingress
...
Tutorial added
2020-11-30 22:53:27 +00:00
d83b868b4f
Merge pull request #9774 from priyawadhwa/cancel-stop
...
Add --cancel-scheduled flag to cancel all existing scheduled stops
2020-11-30 10:03:48 -08:00
dae980a355
Add support for restoring existing podman env
...
If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)
2020-11-29 22:56:47 +01:00
1490562c2a
Fix --extra-config when starting an existing cluster
2020-11-29 12:44:15 +01:00
5b8670c4e9
fix unable to set memory in config
...
Signed-off-by: Tharun <rajendrantharun@live.com>
2020-11-27 01:22:02 +05:30
64729fb03a
Remove function 'NeedsRoot'
2020-11-26 19:54:13 +01:00
2a5289cd00
reintroduce crio hack for testing
2020-11-25 15:42:55 -08:00
70cb886a39
shorten flag name to --cancel-scheduled
2020-11-24 17:29:46 -08:00
ad3e4a98d0
Add --cancel-scheduled-stop flag and add to integration test to make sure it works
2020-11-24 11:36:34 -08:00
91890693ee
Merge branch 'master' into docker-env-ssh
2020-11-24 20:21:21 +01:00
63e5021065
Merge branch 'master' of https://github.com/kubernetes/minikube into add-tracing
2020-11-24 10:29:06 -08:00
2dc88c58ea
Merge pull request #9756 from medyagh/docker_env_restart
...
docker-env: "reload" dockerd service first before "restart" to avoid restarting apiserver container
2020-11-24 10:03:55 -08:00
02511f1c70
Merge pull request #9702 from daehyeok/print_node
...
Add number of nodes for cluster in `minikube profile list`
2020-11-24 09:57:03 -08:00
ee9b5b4d49
remove restart hack for crio now that iso is fixed
2020-11-23 11:39:43 -08:00
807bec0034
Merge branch 'master' into docker-env-ssh
2020-11-22 21:58:08 +01:00
fee0f5310a
Add private network implementation for podman
...
Most of it the same as docker, except for the options.
i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
97db8b5f4c
Add number of nodes for cluster in `minikube profile list`
...
fixes \#6780
Add the Nodes column with the number of nodes the cluster has into
`minikube profile list` output.
2020-11-21 20:45:08 -08:00
659e4ce1bd
lint
2020-11-20 15:47:02 -08:00
301b24ab2e
lint
2020-11-20 15:45:39 -08:00
b498e6b288
typo
2020-11-20 15:35:04 -08:00
5a443f09fb
try reload dockerd first before restart
2020-11-20 15:31:05 -08:00
bf73bcc4fe
Merge tag 'v1.15.1' into docker-env-ssh
...
1.15.1 Release
2020-11-19 17:11:02 +01:00
5a0ab905ed
fix merge conflict
2020-11-17 15:11:23 -08:00
8b39f56a60
Merge pull request #9510 from ilya-zuyev/gh_9463_non_dev_dockerhost
...
Support non-default docker endpoints
2020-11-17 10:17:33 -08:00
c4dd42a1d8
add --trace flag
2020-11-16 21:39:50 -08:00
0f23913f1b
Tracing compiles
2020-11-16 20:31:13 -08:00
05427245cd
Merge tag 'v1.15.0' into docker-env-ssh
...
1.15.0 Release
2020-11-15 09:59:49 +01:00
1c682c6449
Merge branch 'master' of https://github.com/kubernetes/minikube into ss-windows
2020-11-13 16:34:45 -08:00
9b964853a9
Merge pull request #9672 from sadlil/driver-alias
...
Add Support for driver name alias
2020-11-13 16:18:05 -08:00
9438167b60
Merge pull request #9671 from Evalle/ISSUE-9664
...
Rename `out.T` to `out.Step`
2020-11-13 10:16:23 -08:00
d6c0256b3e
Add Support for driver name alias
2020-11-13 10:52:10 +00:00
21d5c01fc5
warn that this only works with docker right now
2020-11-12 14:32:23 -08:00
518ac7de56
Merge pull request #9503 from priyawadhwa/schedule-stop-unix
...
Implement schedule stop for unix
2020-11-12 14:20:20 -08:00
572e22d5a3
Merge branch 'master' of https://github.com/kubernetes/minikube into network-flag
2020-11-12 14:13:26 -08:00
ad85a7a57e
rename containernetwork to network
2020-11-12 10:36:41 -08:00
f88040aad9
Merge branch 'master' into ISSUE-9664
2020-11-12 13:47:12 +01:00
db93039f9c
Addressing comments
2020-11-12 13:45:33 +01:00
8731ff9f23
Merge pull request #9621 from priyawadhwa/json-int-test
...
Fix failing TestJSONOutput/start test
2020-11-11 14:14:57 -08:00
9bb9355b50
fix merge conflict
2020-11-11 11:57:27 -08:00
eb17495e5b
Merge pull request #9487 from prezha/status-add-watch-flag
...
add --watch flag for minikube status with optional interval duration
2020-11-11 11:50:43 -08:00
0f408d9d44
Merge pull request #9385 from bluestealth/8990
...
Improve parsing of start flag apiserver-names
2020-11-11 11:14:58 -08:00
7cc4676d4a
move write statuses logic to a separate func
2020-11-11 00:29:25 +00:00
95e6afb1b9
move write statuses logic to a separate func
2020-11-11 00:29:25 +00:00
f57d9bfa73
add --watch flag for minikube status
2020-11-11 00:25:32 +00:00
5569817c26
Address code review comments
2020-11-10 10:58:31 -08:00
291e5b6927
fix merge conflict
2020-11-10 10:49:37 -08:00
b9615bf220
Merge pull request #9390 from prezha/json-output-cleanup
...
reword error message when cluster state exit code is not found
2020-11-10 10:27:25 -08:00
ea74ac9c1b
Merge pull request #9534 from vinu2003/fix_invalid_profile_creation
...
stop: removed setEventLogPath for stop process
2020-11-10 10:24:10 -08:00
253b0bafb1
Merge branch 'master' of https://github.com/kubernetes/minikube into json-int-test
2020-11-09 17:53:52 -08:00
76c62afddb
Fix unit tests for "podman-env --unset"
2020-11-09 14:21:42 -08:00
0f2c63881a
Merge branch 'master' into gh_9463_non_dev_dockerhost
2020-11-09 14:11:20 -08:00
7570cbd904
fix merge
2020-11-09 13:53:05 -08:00
635f2a71b5
fix lint
2020-11-09 13:52:51 -08:00
aa6a693142
Fix unit tests for "[docker|podman]-env --unset"
2020-11-09 13:44:52 -08:00
cf1ee6b072
Address review comments
2020-11-09 13:33:18 -08:00
88b884378e
Show result from running the ssh-add command
2020-11-08 15:28:27 +01:00
d2e2ecaf40
Add option to add the ssh key to the ssh agent
2020-11-08 15:23:41 +01:00
432762f9e3
Update generate-docs test to include --help flag
2020-11-07 23:40:41 +00:00
1a9a54e458
Update generate-docs test to include --help flag
2020-11-07 23:07:35 +00:00
0c3843bfc6
call 'strings.ToLower(output)' only once
2020-11-06 22:28:26 +00:00
e050e8c9bd
Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix
2020-11-06 13:41:53 -08:00
ab98bbf858
Fix failing TestJSONOutput/start test
2020-11-06 13:34:50 -08:00
3bb967a0b4
Merge pull request #9506 from prezha/add-namespace-support
...
new flag --namespace
2020-11-06 12:20:09 -08:00
7747655476
Merge pull request #9535 from afbjorklund/podman2-env
...
Add support for podman v2 to podman-env command
2020-11-06 12:17:52 -08:00
cca624698e
switch exit to warning
2020-11-06 12:17:48 -08:00
a00b7a38e2
Use DurationVar instead of StringVar for flag
2020-11-06 11:58:21 -08:00
7788cb93d8
Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix
2020-11-06 11:38:26 -08:00
7d99c66efa
fix help flag 'pflag: help requested' error
2020-11-06 02:42:52 +00:00
19b2be23bc
fix merge conflict
2020-11-05 14:31:39 -08:00
f869ca5e91
fix merge conflict
2020-11-05 09:44:47 -08:00
d49f4173b3
update --namespace flag description
2020-11-04 22:14:00 +00:00
3427f078c3
add support for namespace
2020-11-04 22:13:45 +00:00
7a133bd17e
improve parsing of start flag apiserver-names
2020-11-03 10:59:26 -08:00
ec8e2a4f9c
Added check to verify profile path exists
2020-11-03 23:25:32 +11:00
274be7f52d
Split template for docker tcp and ssh in two vars
2020-11-01 15:15:06 +01:00
bfefa72815
Split template for podman v1 and v2 into two vars
2020-11-01 15:14:20 +01:00
b57bf9abcf
Refactor dockerUnsetScript with a helper function
2020-11-01 15:07:02 +01:00
4da751f5d7
Make none driver work as regular user (use sudo on demand)
2020-11-01 14:54:20 +01:00
9f983a8f99
Refactor podmanUnsetScript with a helper function
2020-11-01 14:46:13 +01:00
20a1274c7c
implement "--log_file" and "--log_dir" for klog
2020-10-31 19:57:25 +00:00
bfd2da1b65
removed setEventLogPath for stop process
2020-10-31 18:12:39 +11:00
69c2b01660
Fix shell arg parsing
2020-10-30 14:39:59 -07:00
3c8d3cad7c
Merge branch 'master' of https://github.com/kubernetes/minikube into json-output-stop
2020-10-29 13:44:32 -07:00
39ab9ffc5b
Add --output flags to pause and unpause as well
2020-10-28 13:16:17 -07:00
5c5a8e160a
account for not setting context, remove debugging
2020-10-28 12:44:58 -07:00
4a1c9583bd
initial attempt to account for profile in directly kubectl case
2020-10-28 12:16:02 -07:00
473120648f
Add JSON output to minikube stop
2020-10-28 11:30:11 -07:00
e0b4957fcc
Fix docker-env -u shell detection
2020-10-27 16:48:20 -07:00
02f03af101
exit if using --schedule with windows as it is not yet supported
2020-10-26 15:17:24 -07:00
055de4edf8
return stopped profile status quickly
2020-10-26 13:20:03 -07:00
ea6ca08d67
Change flag name to --network and exit if used without docker driver
2020-10-26 11:52:26 -07:00
7841aea2db
Optionally use ssh for docker-env instead of tcp
...
Since Docker 18.09, it supports ssh: as well as tcp:
for connecting to the docker daemon (in $DOCKER_HOST).
This avoids setting up certificates, but leaves key
handling (host keys and identity keys) to ssh config.
2020-10-25 14:16:28 +01:00
865d3a4a34
Merge branch 'master' of https://github.com/kubernetes/minikube into schedule-stop-unix
2020-10-23 18:15:07 -07:00
fe2710705e
Add --docker-network flag
2020-10-23 09:31:33 -07:00
716d793990
Add support for podman v2 to podman-env command
...
Podman v1 (like 1.9.3) uses the varlink bridge,
while podman v2 (like 2.1.x) uses a REST API.
Both are using ssh for their transport, but the
environment variables exported are different.
2020-10-23 11:46:45 +02:00
d0c0d8b54c
revert suppression of emitting errors to stderr
2020-10-22 09:28:31 +01:00
dedf38b61f
Merge pull request #9368 from kadern0/issue-8445
...
Added deprecation warning for --network-plugin=cni
2020-10-21 08:53:50 -07:00
85d45be207
Fix docker-env command
2020-10-20 23:10:08 -07:00
a54ea82e3b
Implement schedule stop for unix
2020-10-20 13:45:59 -07:00
e7f9b3e954
don't pollute json output with errors
...
additionally:
- issue warning insted of error if 'exitCode' is not found
- rebase: use klog instead of glog
don't pollute status json output with errors
2020-10-18 19:56:28 +01:00
29f00628f5
Merge pull request #9459 from medyagh/stopped_kubelet
...
new --wait component "kubelet"
2020-10-15 12:25:11 -05:00
06a64de853
Merge pull request #9417 from joshmue/fix_ssh_native_toggle
...
Fix "--native-ssh" flag of "minikube ssh"
2020-10-14 10:30:51 -07:00
63c4468fd5
address review comments
2020-10-13 16:01:59 -07:00
1d85d6e123
Add warning for --network-plugin=cni (CNI has to be provided, see --cni)
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-10-12 19:27:25 +11:00
59548194bd
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-09 17:45:35 -07:00
8cfe5c1a7b
Fix "--native-ssh" flag of "minikube ssh"
...
In the previous state, the flag was discarded. This commit fixes
that and also makes sure that the SSH client is created after the
default client type is configured according to the flag.
2020-10-09 09:41:19 +02:00
2985e8a21e
Updating unit tests.
2020-10-08 15:10:50 -07:00
c459fea74d
Merge pull request #9414 from prezha/delete-context-when-stopped
...
Delete context when stopped
2020-10-08 15:12:50 -05:00
ab4a0ab558
Cleaning up flags parsing.
2020-10-08 11:18:50 -07:00
32922f4184
Merge pull request #9412 from Asarew/fix-panic-on-updating-mount-after-creation
...
fix panic when updating mount-string with KiC driver after cluster creation without mount configuration
2020-10-08 13:07:31 -05:00
ef2090ac31
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-08 10:27:04 -07:00
c63de60aba
add HostKubeconfigDeleteCtx Reason Exit
2020-10-07 22:58:20 +01:00
85b722c7b6
Setting klog default flag values.
2020-10-07 14:19:35 -07:00
65a2618485
delete context when minikube is stopped
2020-10-07 22:00:26 +01:00
e573b928d5
Merge pull request #9404 from ToonvanStrijp/master
...
Add new flag "--ports" to expose ports for docker & podman drivers
2020-10-07 15:56:29 -05:00
96d7fc4bc0
fix lint tabs
2020-10-07 19:40:59 +02:00
50c37577fd
update flag to ports
2020-10-07 18:08:08 +02:00
93bbf4c399
little bit of clean up
2020-10-07 10:22:53 +02:00
e8a0487e11
fix panic when updating mount-string with docker driver after cluster creation without mount configuration
2020-10-07 09:53:06 +02:00
615f233c77
Remove reference to Virtualbox in "stop" help
2020-10-06 21:07:02 -07:00
d7c517471d
Merge pull request #9316 from priyawadhwa/preload-disk-full
...
preload: print solution message when there is no space left on device
2020-10-06 19:10:53 -05:00
3703f69c25
Applying klogFlags set via cobra.
2020-10-06 11:20:51 -07:00
aae7784309
Merge pull request #9383 from priyawadhwa/status-bg
...
Fix minikube status bug when cluster is paused
2020-10-06 11:22:13 -04:00
dcf9dd10c6
add docker-ports flag
2020-10-06 13:37:03 +02:00
5614ed0edc
Merge pull request #9367 from medyagh/pname_length
...
don't allow profile name to be less than 2 characters
2020-10-05 18:14:15 -05:00
dc0918e6ba
review comments
2020-10-05 16:13:21 -07:00
4cff79008c
fixed merge conflict
2020-10-05 11:47:53 -04:00
e36c937a34
Do some simple cleanup of the golint complaints
...
The "magic strings" and enums still needs another approach
Simply echoing everything twice doesn't seem very useful ?
2020-10-04 13:40:33 +02:00
7d62ce1c1c
convert from exit codes to http codes if appropriate
2020-10-03 15:29:15 -04:00
7046998831
If insufficient storage is the issue, then show that in status
2020-10-02 17:48:52 -04:00
4c6af8812f
Added error handler.
2020-10-02 14:28:50 -07:00
43cc1a2581
Resolved merg conflicts.
2020-10-02 14:10:55 -07:00
8809387628
Adjusting klog initialization to not emit INFO logs by default.
2020-10-02 10:52:57 -07:00
af5fbf7880
Backup snapshot of changes.
2020-10-02 10:44:24 -07:00
0fc0c82337
Merge pull request #9294 from medyagh/docker_network
...
add dedicated network for docker driver
2020-10-01 14:11:42 -05:00
bebad76bd0
Merge pull request #8978 from taciomcosta/master
...
fix: "profile list" shows paused clusters as "Running"
2020-10-01 14:09:30 -05:00
f71272ca79
don't allow profile name to be less than 2 characters
2020-09-30 17:22:45 -07:00
6538306d14
move exit into separate function
2020-09-30 15:31:44 -04:00
db23825bfc
Move exit.Message function so that we aren't exiting from a library
2020-09-30 15:19:06 -04:00
6e91d719dd
Revert status code cmd
2020-09-29 19:38:12 -04:00
43ea47f4e0
Fixed merge conflicts.
2020-09-29 16:17:31 -07:00
97d96bf925
Switching from glob library to klog library.
2020-09-29 15:49:41 -07:00
b84dedc652
address review comments
2020-09-29 15:07:06 -07:00
b7780ec815
address review comments
2020-09-29 14:14:25 -07:00
f0f10d6135
first version
2020-09-29 14:14:24 -07:00
a05dc6516b
Revert bug in `minikube status`
...
When the cluster is Paused, `minikube status` currently says that it is `Running`. Reverting a change I made in a previous PR to take the status of the apiserver should fix this.
2020-09-29 16:56:15 -04:00
e6b510543e
Don't trim whitespace while extracting strings
...
Remove some leading and trailing whitespace from non-string
constructs like description and automatic extraction filters.
But don't change all the translations or the translations here,
since that would make this code change impossible to review.
2020-09-27 17:59:06 +02:00
11cad2b3e6
Merge pull request #9321 from loftkun/removing-duplicate-command-additions
...
Remove duplicate command additions
2020-09-25 14:03:48 -07:00
75332f7c89
Merge pull request #8901 from bluestealth/MiB
...
Use mebibytes instead of megabytes
2020-09-25 11:28:41 -07:00
ed6b756da0
Merge pull request #9308 from priyawadhwa/performance-monit
...
Add PR bot code to repo
2020-09-25 10:34:36 -07:00
7a2cd0f459
Removing Duplicate Command Additions
2020-09-25 17:45:51 +09:00
3ee1eb029c
Update test to use new exit code for insufficient storage
2020-09-24 14:09:46 -04:00
fd44e0d8fb
Force dependency on exp to prevent dirty commit release binaries ( #9309 )
...
* force dependency for release purposes
* revert original idea and add loads of debugging
* hey more debugging cool
* fix debugging
* drilling down debugging
* revert to original solution
* fix comment
2020-09-23 15:00:03 -07:00
183bdb2354
Merge pull request #9302 from dominikbraun/#9297-reason-for-missing-config-permissions
...
Return ExHostPermission for insufficient config file permissions
2020-09-23 14:20:41 -05:00
07642cd7ef
Merge pull request #9300 from ilya-zuyev/gh8891_forbid_base_image_for_vm_drivers
...
Disable base image flag for vm drivers
2020-09-23 14:10:38 -05:00
887390194e
Add more unit tests
2020-09-22 14:19:38 -07:00
bf8ec63ca9
Simplify base-image flag validation
2020-09-22 14:10:47 -07:00
76d3c9d7bb
Fix variable name (avoid collision with imported package)
2020-09-22 13:09:58 -07:00
3d547a937f
Fix Makefile rule to build bot
2020-09-22 14:00:27 -04:00
3f44d470eb
Add performance monitor code
2020-09-22 13:54:23 -04:00
8f4127b202
Use HOST_HOME_PERMISSION kind for insufficient permissions
2020-09-22 18:04:24 +02:00
603ae8fc6d
Return ExHostPermission for insufficient config file permissions
2020-09-22 10:16:27 +02:00
6a60983679
Show invalid flag diagnostic message to user
2020-09-21 23:28:34 -07:00
6bf7ca3dd2
Validate --base-image flag and active driver combo
2020-09-21 23:06:54 -07:00
9fbd2e94bd
update-context: Automatically set the context as current/active in kubeconfig
2020-09-21 00:06:15 +01:00
b9f3638f2a
Merge pull request #9233 from afbjorklund/nic-type
...
Fix copy/paste error in virtualbox nic-type help
2020-09-15 16:05:52 -07:00
48d44221a9
Don't validate Docker storage driver for Podman
...
For podman, "overlay" and "overlay2" are the same
2020-09-13 22:28:17 +02:00
37e521272c
Fix copy/paste error in virtualbox nic-type help
...
It used type "host only" twice, instead of "nat".
2020-09-13 17:25:02 +02:00
ee5b8f130f
Merge pull request #8831 from priyawadhwa/overlay
...
Set preload=false if not using overlay2 as docker storage driver
2020-09-09 11:45:52 -07:00
c4663b8417
Merge pull request #9181 from tstromberg/m1
...
Add Docker Desktop instructions if memory is >minimum but <recommended
2020-09-08 14:25:13 -07:00
b4400ad70a
Merge pull request #8904 from Xcalizorz/master
...
fixes(#8301 ): --help: bool flags which default to 'false' yield confusing output
2020-09-08 13:50:10 -04:00
4708f6215c
fix: profile list shows paused clusters as Running
2020-09-05 18:37:24 -03:00
f15fd81333
Add Docker Desktop instructions if memory is >minimum but <recommended
2020-09-03 11:39:14 -07:00
54443bd337
Update min*Mem constants to use MiB instead of MB
2020-09-03 11:34:40 -07:00
e20223d598
quote variables in GuestMountConflict warning
2020-09-03 18:39:31 +02:00
4e772347d4
exit on existing cluster start with KiC driver mount configuration change
2020-09-03 18:25:10 +02:00
229969aa54
fix grammer
2020-09-03 10:02:07 +02:00
5ae5be7141
fixed misuse of template variable
2020-09-03 10:01:19 +02:00
2b2220ac8b
added warning for changing mount configuration with KiC dirver on existing cluster
2020-09-03 09:51:11 +02:00
dab20a2e12
Merge pull request #9163 from tstromberg/driver-advice
...
docker: Improve overlay module check (behavior & UX)
2020-09-02 14:56:04 -07:00
d1431fe0e5
Merge pull request #9167 from tstromberg/kubectl-advice
...
Simplify kubectl advice messaging
2020-09-02 14:12:17 -07:00
830af29223
Merge pull request #9144 from tstromberg/confusing-warning
...
Remove conflicting & inaccurate Docker Desktop memory warning
2020-09-02 14:01:33 -07:00
4e9a3975df
Simplify kubectl advice messaging
2020-09-02 13:35:40 -07:00
0d4ef00210
Use out.T for a simpler layout
2020-09-02 10:56:06 -07:00
08d874a4a2
Reduce performance-advice message to a single line
2020-09-02 10:38:45 -07:00
ea5af644ec
fix merge conflict
2020-09-02 09:31:42 -04:00
2b8c48cc59
start: fixed the type value for kubectl version mismatch to warning
2020-09-02 21:17:13 +10:00
eff63d7382
chore( #8301 ): Changes https-flag description
2020-09-02 10:24:12 +02:00
dc5951451b
Merge pull request #8872 from kadern0/issue-8857
...
Running internal kubectl command when minikube is called as 'kubectl'
2020-09-01 22:44:44 -07:00
d66a8e68c9
Merge pull request #8907 from sharifelgamal/external-ssh
...
respect native-ssh flag
2020-09-01 22:37:37 -07:00
1859274e8a
refactor conversion functions into util
2020-09-01 21:21:07 -07:00
ad1e2e2de5
Use same conversion logic for bytes -> MiB everywhere
2020-09-01 21:20:09 -07:00
8a26881552
Merge pull request #8159 from Asarew/docker-host-volumes
...
Support for mounting host volumes on start with docker driver
2020-09-01 16:30:45 -07:00
f69c6c5773
Remove conflicting & possibly inaccurate Docker Desktop specific memory warning
2020-09-01 08:40:00 -07:00
8ef7410066
Shorten Docker memory warning
2020-08-30 21:04:10 -07:00
cd91fb8470
Unwrap unnecessary level of error annotation for improved messages
2020-08-30 20:48:20 -07:00
2c5e8fdaee
Add detailed JSON & status codes for all error paths
2020-08-30 17:25:11 -07:00
ac604f25a1
feature: added shorthand for start command output option
2020-08-27 10:07:25 +10:00
d634a85ff9
use daemon info so this works for docker and podman
2020-08-24 17:50:09 -04:00
535294e523
fixed merge conflict
2020-08-24 17:35:03 -04:00
a767b64b41
fix merge conflict
2020-08-21 21:40:32 -04:00
88aece40d2
change name
2020-08-21 15:05:37 -04:00
97acf408e0
fix error wording
2020-08-21 13:34:06 -04:00
e9cfbd0098
add an new flag to stop command --keep-context-active
2020-08-21 10:27:28 -07:00
acd6589c5d
Remove debugging
2020-08-21 09:56:03 -04:00
44b93f4776
Change MemoryCapacity to StorageCapacity to be more accurate
2020-08-21 09:49:48 -04:00
482b2bf624
additional debugging
2020-08-20 17:23:04 -04:00
344a5be6d5
Merge pull request #9033 from vixus0/fix-start-memory-flag
...
Fix --memory flag parsing in minikube start
2020-08-20 14:05:42 -07:00
7eda3a7711
Create new exit code for InsufficientStorage
2020-08-20 15:27:06 -04:00
83eba00d47
add deubgging
2020-08-20 14:42:55 -04:00
6e8f596eac
Fix --memory flag parsing in minikube start
...
Due to the way Go handles variable scope, `mem` was being
redeclared inside the conditional. Outside, we were stuck with the value
provided by `suggestMemoryAllocation`, therefore ignoring the value
passed through the `--memory` flag.
2020-08-20 10:29:26 +02:00
906bcb9cab
fix typo miniube
...
$ sed -i 's/miniube start/minikube start/g' $(git grep -l 'miniube start')
Fixes : #9018
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-08-20 13:43:59 +08:00
1783cc2939
Make sure minikube status shows status name and details
2020-08-19 13:32:36 -04:00
3dba974535
Make sure 'minikube status' displays InsufficientStorage for cluster and nodes
...
if there is insufficient storage. Output now looks like:
```
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"StatusDetail": "/var is almost out of disk space",
"Step": "Starting Node",
"StepDetail": "Updating the running docker \"minikube\" container ...",
"BinaryVersion": "v1.12.3",
"Components": {
"kubeconfig": {
"Name": "kubeconfig",
"StatusCode": 500,
"StatusName": ""
}
},
"Nodes": [
{
"Name": "minikube",
"StatusCode": 507,
"StatusName": "InsufficientStorage",
"Components": {
"apiserver": {
"Name": "apiserver",
"StatusCode": 405,
"StatusName": "Stopped"
},
"kubelet": {
"Name": "kubelet",
"StatusCode": 405,
"StatusName": "Stopped"
}
}
}
]
}
```
2020-08-19 13:25:48 -04:00
9708036592
Updated default cmd string when minikube is run as kubectl
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 21:20:50 +10:00
10a3f2e2a8
Running internal kubectl command when minikube is called as 'kubectl'
...
Fixes issue #8857
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-08-17 20:52:58 +10:00
51110dbbe8
Merge pull request #8969 from priyawadhwa/cpu-limit
...
skip validations if --force is supplied
2020-08-11 18:16:13 -04:00
f122deeaf3
suggest --force for k8s version
2020-08-11 15:42:05 -04:00
506279c585
change function name
2020-08-11 15:38:42 -04:00
a69b41932c
improve error handling
2020-08-11 14:56:19 -04:00
74309a83e6
include memory check
2020-08-11 14:22:10 -04:00
789dfca804
skip vaildations if --force is supplied
2020-08-11 14:16:40 -04:00
Patrik Freij
Priya Wadhwa
Medya Ghazizadeh
liuwei10
Steven Powell
Medya Gh
Steven Powell
hetong07
Anders F Björklund
BLasan
Pablo Caderno
Ilya Zuyev
Daehyeok Mun
Sharif Elgamal
Kent Iso
ilya-zuyev
Ling Samuel
Thomas Stromberg
Yanshu Zhao
Thomas Strömberg
AUT0R3V
Sadlil
Tharun
msedzins
Jeroen Dekkers
Martin Schimandl
Evgeny Shmarnev
Predrag Rogic
Michael Ryan Dempsey
vinu2003
Priya Modali
Joshua Mühlfort
ToonvanStrijp
Asare Worae
loftkun
Dominik Braun
Predrag Rogic
Tacio Costa
Zadjad Rezai
Anshul Sirur
Li Zhijian