145f9fc9ab
run `go fmt`
2021-09-13 11:58:43 -07:00
67b82f3fe1
Update kicbase to v0.0.26
2021-09-03 02:18:31 +00:00
703324b7c7
Updating kicbase image to v0.0.25-1630631232-12398
2021-09-03 01:36:51 +00:00
323225483e
Support Rootless Docker
...
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/
Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.
Closes issue 10836 ("add support for rootless Docker").
Support for rootless Podman (issue 8719) is not covered in this commit.
---
Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
instead of `overlayfs` snapshotter
- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint
2021-08-27 17:21:53 +09:00
6cecbf6fe5
Updating kicbase image to v0.0.25-1628619379-12032
2021-08-10 18:33:49 +00:00
4040311f1e
Use fully qualified image name for docker hub fallback image
2021-07-13 16:09:55 -07:00
81c2bb2796
Merge pull request #11708 from afbjorklund/info-klog
...
Make sure to log errors from DaemonInfo
2021-07-07 13:29:05 -04:00
4db717a5eb
Update kicbase to v0.0.25
2021-07-01 23:38:36 +00:00
202e2fa36f
Updating kicbase image to v0.0.24-1625170572-11834
2021-07-01 20:31:45 +00:00
05b64d1a74
Merge pull request #11824 from andriyDev/fix-auto-pause
...
Make kicbase copy auto-pause binary instead of auto-pause folder
2021-07-01 16:10:33 -04:00
2bf9076527
Updating kicbase image to v0.0.24-1625086337-11824
2021-06-30 21:07:40 +00:00
89c7853601
bump go mod libs manually
2021-06-29 15:24:59 -04:00
bce90e5037
Update kicbase to v0.0.24
2021-06-25 23:41:39 +00:00
3b533a07cb
Make sure to log errors from DaemonInfo
2021-06-22 07:56:11 +02:00
64a41824c5
Update kicbase to v0.0.23
2021-06-09 00:28:52 +00:00
d76259e86f
Merge pull request #11528 from andriyDev/FixDownloadOnlyTest2
...
Change PreloadExists to report no preload for BareMetal drivers
2021-06-02 12:59:15 -07:00
853f1cb4db
first try gcr
2021-06-01 15:16:17 -07:00
2f4b7985c0
try image without sha before failing
2021-06-01 15:11:01 -07:00
f9f3ef9a09
Pass driverName into Preload and PreloadExists to report no preload for BareMetal.
2021-05-27 15:02:00 -07:00
6cb7c2166c
spell
2021-05-21 14:09:42 -07:00
9c9934879c
break guest provision when container exists prematurely
2021-05-21 13:34:34 -07:00
d6691e796c
Add `Close() error` function into assets.CopyableFile
...
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
707af502f3
Merge pull request #11300 from ilya-zuyev/ilyaz/gh_11293
...
Fix getting of gateway IP for podman driver
2021-05-14 17:04:24 -07:00
dcadd32624
Add comment, improve template
2021-05-14 14:38:29 -07:00
e8b16a5247
Updating kicbase image to v0.0.22-1620785771-11384
2021-05-12 02:25:58 +00:00
a1ae930d2f
Simplify the code
2021-05-06 11:17:43 -07:00
6e2eae0d0a
Simplify the code
2021-05-06 11:13:10 -07:00
f4e142d442
Simplify the code
2021-05-06 10:35:22 -07:00
8d2b811fcf
Remove debug logs
2021-05-05 22:01:21 -07:00
6cf6ba2ff2
Fix network settings parsing
2021-05-05 19:31:12 -07:00
829cc42a65
Fix network settings parsing
2021-05-05 19:11:56 -07:00
618d09ab76
Fix network settings parsing
2021-05-05 17:14:33 -07:00
01f76f7d4f
Add debug logs
2021-05-05 16:29:11 -07:00
adc53aa677
Fix error handling
2021-05-05 15:58:16 -07:00
61c1b301be
Fix linter errors
2021-05-05 15:31:11 -07:00
fe392b4233
When getting a gateway IP for podman container inspect per-network data as well
2021-05-05 15:09:46 -07:00
625a06ce6d
Update kicbase to v0.0.22
2021-05-05 21:18:37 +00:00
c5b65cab51
Update kicbase to v0.0.21
2021-04-30 18:08:55 +00:00
fff23925e0
Updating kicbase image to v0.0.20-1619543236-11212
2021-04-27 17:16:43 +00:00
30d659c635
Merge pull request #11055 from afbjorklund/kic-os-update
...
Update kicbase base image
2021-04-24 21:09:32 -07:00
60d8401f59
Merge pull request #11086 from sharifelgamal/mock-mirror
...
avoid network calls for mirror unit tests
2021-04-16 13:46:31 -07:00
1319b6e398
refactor checkRepository to make mocking easier
2021-04-14 12:51:16 -07:00
0e1fd72042
Updating kicbase image to v0.0.20-1618262794-11055
2021-04-12 21:36:41 +00:00
f527fb675a
Address security concerns with the go code
...
As flagged by the github code scanning
2021-04-12 20:38:21 +02:00
f7c204d907
Update kicbase to v0.0.20
2021-04-09 19:23:04 +00:00
831c3dfdbd
Updating kicbase image to v0.0.19-1617905290-11019
2021-04-08 18:17:37 +00:00
1e3370298a
Merge pull request #11001 from lilongfeng0902/minikube-lilf
...
minor spelling errors
2021-04-07 17:35:39 -07:00
db3fd51194
Rename ListOptions to ListContainersOptions
2021-04-06 22:39:43 +02:00
7ae82c573b
Propagation not Propogation
2021-04-06 14:52:52 +08:00
53babcc152
Update kicbase to v0.0.19
2021-04-05 22:22:23 +00:00
894ca125cb
Merge pull request #10858 from prezha/fix-create-network-race
...
create network: use locks and reservations to solve race condition
2021-03-24 17:47:21 -07:00
9b23841ee3
Add solution message if Docker is rootless
2021-03-20 13:20:30 -07:00
f4a375181a
create network: use locks and reservations to solve race condition
2021-03-18 18:38:06 +00:00
223792b993
create network: use locks to solve race conditions
2021-03-17 14:32:39 +00:00
3110bd15fc
Lowercase minikube in information message
2021-03-05 15:50:52 +01:00
0d1d169bf6
Set non-local traffic message as a Tip message
...
To stay consistent with other messages. Also moved it above the warning
message regarding what IP is set as listen-address to make more sense in
the message flow.
2021-03-03 17:07:23 +01:00
bb5bf9546c
Add info message about not using it for production
...
To add more context to the warning message for --listen-address
2021-03-02 20:21:39 +01:00
9b5a96e76d
Make warning more informative for --listen-address
2021-03-01 23:10:58 +01:00
bad8561d0d
Skip custom listenAddress if equal to default
2021-03-01 23:06:13 +01:00
cb116e4c1c
Add --listen-address for docker driver
2021-02-28 23:14:08 +01:00
2c292cca75
Update kicbase to v0.0.18
2021-02-25 23:14:51 +00:00
f272822d15
bump kic base
2021-02-24 13:45:53 -08:00
e9e81cef25
bump kicbase
2021-02-24 13:29:10 -08:00
549bb10a52
update kicbase with pause
2021-02-24 12:30:06 -08:00
72135d70d9
add auto pause proxy
2021-02-24 12:30:06 -08:00
460342a5f2
Merge pull request #10575 from hetong07/issue_10519
...
Improve the error message of setting cgroup memory limit.
2021-02-24 11:53:54 -08:00
7f75dfffda
drop support for github packages for kicbase
2021-02-23 14:16:02 -08:00
9a30756d38
Improve the error message of setting cgroup memory limit.
2021-02-22 20:18:22 -08:00
d6e9174435
update new tag, SHA, and doc due to new kicbase image
2021-02-21 17:27:24 -08:00
d120656161
update image
2021-02-20 10:55:56 -08:00
712ab628a6
update kicbase
2021-02-20 10:11:35 -08:00
5c6c20f68e
Merge pull request #10528 from sharifelgamal/crio-storage
...
fix crio by hardcoding mountopt
2021-02-19 22:54:33 -08:00
9abb3bed51
update kicbase image
2021-02-19 18:08:41 -08:00
fb27ab7e7f
Merge pull request #10439 from prezha/prevent-oci-overlapping-net
...
prevent oci try to create overlapping network
2021-02-19 16:23:18 -08:00
629926a2bd
Merge pull request #10418 from afbjorklund/kicbase-210119
...
Update kicbase base image and sync with kind
2021-02-19 11:33:11 -08:00
17af0f999b
update kicbase image for testing
2021-02-18 19:20:17 -08:00
0edb126f13
Merge pull request #10512 from hetong07/cgroup_memory_fix
...
cgroup v2: skip setting --memory limits when not configurable.
2021-02-18 18:56:57 -08:00
96c5b6a0d4
Merge pull request #10408 from sharifelgamal/kic-test
...
populate kic.txt properly in kicbase
2021-02-18 18:42:17 -08:00
74e2127a87
update kicbase image for the last time
2021-02-18 18:28:02 -08:00
556a8d7930
Move the user facing warning inside hasMemoryCgroup().
2021-02-18 16:43:19 -08:00
114364409d
add github packages to script
2021-02-18 16:17:09 -08:00
e8c2a23398
Provide an advice for users on how to modify Grub setting.
2021-02-18 16:09:51 -08:00
7b0bf57f4c
Stop using --memory for cgroup v2.
2021-02-18 15:43:26 -08:00
31ea98ca50
update kicbase to newest build
2021-02-18 15:04:34 -08:00
369f93f393
Merge pull request #10468 from afbjorklund/cgroups-warning
...
Make sure to show debian warning also for cgroup 2
2021-02-18 14:25:59 -08:00
f11498046b
messed up boilerplate
2021-02-18 11:52:38 -08:00
3f04535045
add dockerhub to autopush
2021-02-18 11:47:59 -08:00
75be14d2ce
Merge pull request #10507 from afbjorklund/docker-memswap
...
Stop using --memory-swap if it is not available
2021-02-18 11:15:32 -08:00
eabc02d3c4
Stop using --memory-swap if it is not available
...
With Debian and Ubuntu kernels, it needs to be configured.
And now with cgroups v2, it starts throwing errors at run.
2021-02-18 18:54:36 +01:00
fd897f4f23
fix up repo stuff
2021-02-17 10:32:48 -08:00
ea16737271
syntax
2021-02-17 09:37:34 -08:00
9aeb4a75fa
update kicbase image
2021-02-17 09:35:32 -08:00
6d61795352
simplify free subnet query for oci net create
2021-02-17 03:04:47 +00:00
4018ee3682
move to separate network package and fix naming
2021-02-17 03:04:47 +00:00
d48b0a58e8
add ip conflict auto-resolution also to kvm and consolidate
2021-02-17 03:04:47 +00:00
c6446e5fbd
prevent oci try to create overlapping network
2021-02-17 03:04:47 +00:00
5bffb823b2
Add ProfileLableKey to make sure that preload side car will be target of deletion. minikube delete doesn't check CreatedByLabelKey
2021-02-17 10:27:54 +09:00
fd58d0fc90
Add CreatedByLabelKey to make sure that preload side car will be target of deletion
2021-02-17 10:06:12 +09:00
e3cd93aa1a
Change prepareVolume func to add container name for preload side car
2021-02-17 10:06:12 +09:00
2c87f6e1ad
Make sure to show debian warning also for cgroup 2
...
Move check to function, to cut down on complexity
2021-02-13 18:37:54 +01:00
b7de621033
Explicitly remove podman volume and network
...
The --filter and --label functionality was broken,
in earlier versions of podman (before version 3.0)
2021-02-10 20:57:20 +01:00
51169d68ea
Add context to remaining necessary functions
2021-02-08 15:19:01 -08:00
a6372b35a3
Add 5 minute timeout to deleting leftover cvolumes and containers
2021-02-08 15:15:08 -08:00
f519ec50cc
support ancient versions of docker again (template parsing issue)
2021-02-05 01:54:09 +00:00
67458418ca
Change test naming
2021-02-02 21:39:34 +00:00
84e7c47e8a
reduce lock scope
2021-02-02 21:20:31 +00:00
8009a5b3a8
change naming
2021-02-02 20:59:29 +00:00
4665993109
Add header file for the test
2021-02-02 16:57:47 +00:00
397b7b2286
Use global flag and only print one warning for the same cmd per binaray
...
run
2021-02-02 16:28:04 +00:00
4500be129f
Validate minimum docker version
2021-02-01 13:54:20 -08:00
70253a9c87
update kicbase and iso to last build
2021-01-20 16:41:10 -08:00
91a7436617
bump kicbase version
2021-01-20 15:46:14 -08:00
7ca15031e8
fix kicbase sha1
2021-01-11 18:30:39 -08:00
2622e9583c
bump kicbase version to v0.0.16-snapshot1
2021-01-08 13:49:27 -08:00
921306d88a
fix fallback kicbaseimages list
2021-01-08 13:31:13 -08:00
65cf998d6f
Merge branch 'master' into ilyaz/multiarch_kicbase
2021-01-05 16:30:26 -08:00
6335658103
Revert single-arch kicbase fallback support
2021-01-05 16:29:48 -08:00
f22a3802c7
Handle podman installations without default bridge
2021-01-05 17:06:52 +01:00
0f734e6339
Change function name
2020-12-31 00:03:34 +00:00
f94b1674b1
Change tests into a loop
2020-12-30 23:27:37 +00:00
f044b1fa91
Add unit test for docker network inspect
2020-12-30 02:28:44 +00:00
4a940d0079
Fix docker inspect network go template
2020-12-27 08:38:39 +00:00
a3b80e1fff
add log
2020-12-22 14:57:04 -08:00
bd413794c2
Avoid creating network if it is the default
2020-12-22 14:56:27 -08:00
55f496492c
fix merge conflict
2020-12-16 10:37:51 -08:00
f85bed1150
Merge pull request #9753 from blueelvis/'bug/9078-tunnel-windows-docker'
...
Fix minikube tunnel for Docker on Windows
2020-12-15 07:59:44 -08:00
a8463f3453
fix linting errors
2020-12-15 18:25:10 +05:30
ce17200bd8
address review comment
2020-12-15 18:09:43 +05:30
6044006afe
add multi-arch images to kic driver list
2020-12-13 22:29:17 -08:00
b4bf2bde33
Merge pull request #9866 from afbjorklund/podman-network-fix
...
Fix podman network inspect format and error
2020-12-11 10:20:46 -08:00
442a9cf2d3
Merge pull request #9911 from medyagh/update_kicbase_16_1
...
Update kicbase 15 snapshot4 on head
2020-12-10 16:55:28 -08:00
6b079476c6
Merge pull request #9918 from lingsamuel/remove-verbose-options
...
Remove verbose options
2020-12-10 15:58:01 -08:00
c3d0621d97
Only use sudo with the none driver when on linux
2020-12-10 21:07:10 +01:00
a6941f21ca
Fix podman network inspect format and error
...
Somehow this ended up with the docker network inspect format,
instead of the CNI based one used by podman network inspect ?
2020-12-10 07:32:34 +01:00
634f0ae0a9
Remove verbose options
2020-12-10 14:29:38 +08:00
d3c375420e
bump kicbase on head v0.0.15-snapshot4
2020-12-09 17:32:46 -08:00
a55a0b0286
bump kicbase on head
2020-12-09 17:20:09 -08:00
6eadee30b8
Merge pull request #9802 from afbjorklund/podman-host-cleanup
...
Some more cleanup of missing code for podman-env
2020-12-09 15:00:37 -08:00
74cdda9e9a
Resolve review comments
2020-12-09 16:54:19 +05:30
0e85b1819a
bump kic base on head
2020-12-08 13:49:17 -08:00
0898ca21e4
Merge pull request #9801 from afbjorklund/podman-env-existing
...
Add support for restoring existing podman env
2020-12-08 10:25:50 -08:00
f373155d55
merge conflict
2020-12-03 10:56:41 -08:00
8fc54b430b
Merge pull request #9716 from afbjorklund/podman-network
...
Add private network implementation for podman
2020-12-02 14:16:41 -08:00
da778ea870
Some more cleanup of missing code for podman-env
...
There is a lot of code duplication from docker-env
Most of it also applies for podman (CONTAINER_HOST)
2020-11-29 23:35:37 +01:00
dae980a355
Add support for restoring existing podman env
...
If user had a podman environment configured before podman-env,
restore it on unset (similar to existing code for docker-env)
2020-11-29 22:56:47 +01:00
7bc81b1cbd
add imagesha
2020-11-25 14:22:29 -08:00
8639a067e6
bump kic image on head
2020-11-25 14:07:24 -08:00
5d5a12c60f
Merge pull request #9734 from priyawadhwa/updae-iso-kic
...
Update ISO and kicbase to include scheduled stop
2020-11-24 10:10:59 -08:00
fee0f5310a
Add private network implementation for podman
...
Most of it the same as docker, except for the options.
i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin
2020-11-22 13:58:12 +01:00
131d7248c4
Merge pull request #9710 from valaparthvi/issue9690
...
convert dockerNetworkInspect to a struct
2020-11-20 14:16:01 -08:00
197f2a25ae
Removed unused debugging lines
2020-11-21 00:30:05 +05:30
bf7b09f484
Fix permissions for key file on Windows
2020-11-21 00:27:19 +05:30
63c186bb05
convert dockerNetworkInspect to a struct
2020-11-20 12:29:37 +05:30
e83ba9df9c
Update ISO and kicbase to include scheduled stop so we can test them
2020-11-18 10:54:41 -08:00
14db0debef
review comments
2020-11-17 12:15:42 -08:00
8b39f56a60
Merge pull request #9510 from ilya-zuyev/gh_9463_non_dev_dockerhost
...
Support non-default docker endpoints
2020-11-17 10:17:33 -08:00
7955a891cb
bump kicbase
2020-11-12 16:04:26 -08:00
9bb9355b50
fix merge conflict
2020-11-11 11:57:27 -08:00
37914938e5
bump kicbase to include crio changes
2020-11-09 17:39:19 -08:00
c2bfd58be3
bump snapshot
2020-11-09 17:16:47 -08:00
0f2c63881a
Merge branch 'master' into gh_9463_non_dev_dockerhost
2020-11-09 14:11:20 -08:00
e58d538903
Fix linter warning
2020-11-09 12:52:27 -08:00
80566956d6
bump kicbase
2020-11-05 12:36:40 -08:00
d5a092c3c7
Add unit tests for oci.DaemonHost()
2020-10-30 14:00:52 -07:00
c97cd912f1
Rename oci.RuntimeHost() -> oci.DaemonHost()
2020-10-30 13:44:34 -07:00
72b710af03
Fix warning about listening to 0.0.0.0
2020-10-30 13:41:06 -07:00
43a4b62b68
Remove excessive logging
2020-10-30 13:27:29 -07:00
acbdafa4e1
Fix func naming
2020-10-27 16:07:50 -07:00
ea6ca08d67
Change flag name to --network and exit if used without docker driver
2020-10-26 11:52:26 -07:00
ebf612254c
Fix merge conflict
2020-10-26 09:31:59 -07:00
9f729ac041
readability
2020-10-23 15:04:13 -07:00
43c2a5cd0c
dont pass mtu if 0
2020-10-23 14:54:49 -07:00
4993dc6ed7
log
2020-10-23 14:25:00 -07:00
1dd5583ce3
template
2020-10-23 14:07:20 -07:00
aa97aca2ff
make struct for netinfo
2020-10-23 13:45:25 -07:00
20db128cb8
add warning
2020-10-23 13:10:01 -07:00
94485d5a19
lint
2020-10-23 12:47:51 -07:00
cde546ed80
detect MTU from docker brdige
2020-10-23 12:41:29 -07:00
8b4c48143b
implement --docker-network flag
2020-10-23 09:50:23 -07:00
fe2710705e
Add --docker-network flag
2020-10-23 09:31:33 -07:00
6e02753204
Forward ports for docker machine on Linux
2020-10-22 22:41:58 -07:00
89bf9ac01c
Update certs and API endpoints
2020-10-22 22:10:07 -07:00
50a04a49d4
try
2020-10-22 17:33:33 -07:00
bfa83ff602
fix option
2020-10-22 16:56:13 -07:00
a6e5fb89d5
lower mtu for cloud shell
2020-10-22 16:05:06 -07:00
eaa9ecfd31
Experiments
2020-10-22 13:41:01 -07:00
34a2dc7686
Delete test file
2020-10-22 13:37:05 -07:00
85d45be207
Fix docker-env command
2020-10-20 23:10:08 -07:00
d384343c39
When configuring docker environment, use MINIKUBE_EXISTING_* variables if set
2020-10-19 22:02:42 -07:00
fd15e50dbe
Fix typo (cointainer -> container)
2020-10-13 14:20:35 -07:00
59548194bd
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-09 17:45:35 -07:00
567d2f2f65
Merge pull request #9426 from priyawadhwa/drv-cp-endpoint
...
Add further debugging for DRV_CP_ENDPOINT failure
2020-10-09 16:55:38 -05:00
acd5a7a4c8
address review comments
2020-10-09 14:16:35 -04:00
0985957032
Add further debugging for DRV_CP_ENDPOINT failure
2020-10-08 18:00:11 -04:00
4d743b2f3d
bump kicbase imge
2020-10-08 13:45:54 -07:00
ef2090ac31
Merge branch 'master' of https://github.com/kubernetes/minikube into klog
2020-10-08 10:27:04 -07:00
e573b928d5
Merge pull request #9404 from ToonvanStrijp/master
...
Add new flag "--ports" to expose ports for docker & podman drivers
2020-10-07 15:56:29 -05:00
61048eedbe
fix typo
2020-10-07 19:41:57 +02:00
3703f69c25
Applying klogFlags set via cobra.
2020-10-06 11:20:51 -07:00
b538bc0f56
add extra args
2020-10-06 13:34:20 +02:00
Steven Powell
minikube-bot
Akihiro Suda
なつき
Medya Ghazizadeh
Medya Gh
Anders F Björklund
Sharif Elgamal
Andriy Dzikh
Daehyeok Mun
Ilya Zuyev
李龙峰
Predrag Rogic
Patrik Freij
hetong07
Jiefeng He
Kent Iso
Priya Wadhwa
Yanshu Zhao
Thomas Strömberg
Jituri, Pranav
Ling Samuel
Parthvi Vala
Nick Kubala
Priya Modali
ToonvanStrijp