288f5ef815
more lint fixes
2022-05-16 12:59:25 -07:00
cd4428dfdd
fix: removed unused code
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2022-05-13 09:17:31 +10:00
8daa86141a
Update kicbase to v0.0.31
2022-05-12 22:38:29 +00:00
c664d91fd3
Updating kicbase image to v0.0.30-1652309540-13791
2022-05-12 00:45:32 +00:00
484c27d840
Merge pull request #14115 from kadern0/issue-12842
...
Fix: "Your cgroup does not allow setting memory"
2022-05-11 12:58:01 -07:00
abf8508d82
Updating kicbase image to v0.0.30-1652251400-14138
2022-05-11 08:37:31 +00:00
f31a1d5020
fix: conditional compiling for cgroups code
2022-05-09 19:41:28 +10:00
947ff0435b
fix: small code refactor
2022-05-08 19:46:17 +10:00
7d9eca5eff
fix: improved memory cgroup checks
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2022-05-08 19:46:17 +10:00
92ab555928
Support rootless Podman driver, take 2
...
Usage:
```
minikube config set rootless true
minikube start --driver=podman --container-runtime=(cri-o|containerd)`
```
Tested on Podman 4.0.2, Ubuntu 21.10.
Needs cgroup v2 (as in Rootless Docker): https://rootlesscontaine.rs/getting-started/common/cgroup2/
See also `site/content/en/docs/drivers/includes/podman_usage.inc`
Fix issue 8719
Fix issue 12460
Replace PR 12901
Changes from PR 12901: `rootless` is now a config property.
In the previous PR, `--rootless` was implemented as a flag for `minikube start`
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-04-05 18:49:40 +09:00
070e5335e0
remove unecessary icacls check
2022-03-31 15:46:37 -07:00
ad4d80e955
Merge pull request #13881 from AkihiroSuda/fix-podman-v4-network-inspect
...
Podman: fix `minikube delete` for Podman v4
2022-03-31 14:15:06 -07:00
1aa1f04e9b
remove old build tags
2022-03-30 16:43:29 -07:00
31d1fdae3b
Merge pull request #13730 from presztak/subnet_flag
...
Add 'subnet' flag for docker/podman driver
2022-03-30 16:02:54 -07:00
28fdc99086
Podman: fix `minikube delete` for Podman v4
...
The "minikube" network was not deleted due to the breaking change of
`podman network inspect` in Podman v4.
Fix issue 13861
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-03-30 18:29:14 +09:00
7204b1db3e
KIC rootless: drop fuse-overlayfs; bump kernel requirement to 5.11
...
minikube 1.23 (PR 12359) added fuse-overlayfs snapshotter for rootless Docker driver,
but got broken in minikube 1.25 (issue 13534).
We can drop fuse-overlayfs for kernel >= 5.11.
Fix issue 13534
We may add back fuse-overlayfs later if there is a huge demand to
support kernel < 5.11.
That will require packing preloadable tarballs for fuse-overlayfs
snapshotter.
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2022-03-22 18:08:14 +09:00
100852bbf8
Updating kicbase image to v0.0.30-1647797120-13815
2022-03-20 19:06:44 +00:00
535cd5201e
improve icacls error messaging
2022-03-16 11:48:41 -07:00
f3c9198134
add support for 'subnet' flag
2022-03-15 21:42:09 +01:00
4046a967b9
Update kicbase to v0.0.30
2022-02-23 19:46:44 +00:00
c9290bd8c0
Updating kicbase image to v0.0.29-1644344181-13531
2022-02-08 19:53:09 +00:00
d696170374
Updating kicbase image to v0.0.29-1644071658-13563
2022-02-05 16:09:05 +00:00
3a923b245e
Merge pull request #13302 from afbjorklund/cri-dockerd-rel
...
KIC: Upgrade cri-dockerd
2022-02-03 11:23:27 -08:00
429347e99c
Updating kicbase image to v0.0.29-1643823806-13302
2022-02-02 19:23:02 +00:00
c24818d9b7
lint
2022-02-01 13:21:53 -08:00
8c6f9f64c7
lint
2022-01-31 15:18:04 -08:00
c5b1c56f57
Merge pull request #12835 from presztak/remove_kicbase_image_info
...
Print a message about preserving kicbase image when `minkube delete --purge --all` used
2022-01-27 21:23:27 -08:00
bfd94658fb
Update kicbase to v0.0.29
2022-01-18 21:29:55 +00:00
2bd63b55aa
Updating kicbase image to v0.0.28-1640212998-13227
2021-12-23 00:19:12 +00:00
e43ead0043
add quote to Windows env
2021-12-16 10:02:59 -08:00
9200267c04
Merge pull request #13168 from spowelljr/supressDockerPerformance
...
Added env to suppress Docker performance messages
2021-12-15 16:41:28 -08:00
5a66196a20
update message
2021-12-15 15:58:00 -08:00
5de765023a
Merge pull request #13124 from sharifelgamal/kicbase-arch
...
fix kicbase dockerfile to allow ppc64le and armv7 archs
2021-12-15 14:08:07 -08:00
a6ef730eb7
Updating kicbase image to v0.0.28-1639515145-13124
2021-12-14 21:54:37 +00:00
b17834c96b
added env to suppress Docker performance messages
2021-12-14 13:46:52 -08:00
efe0dd71b4
Updating kicbase image to v0.0.28-1639444036-13124
2021-12-14 02:08:03 +00:00
8d7a636bfe
don't output Docker performance issues when user wants JSON
2021-12-09 14:38:18 -08:00
41546a03e5
Merge pull request #13104 from klaases/kic1
...
Update BUILD KIT version to latest, 0.9.3.
2021-12-07 11:02:40 -08:00
3e901caf92
Updating kicbase image to v0.0.28-1638824847-13104
2021-12-06 21:36:10 +00:00
7b3860388c
Print a message about preserving kicbase image
...
Print additional info about preserving kicbase image and generates
image deletion command for user when running `minikube delete`.
Message is printed only when `--purge` option is used.
2021-11-25 23:36:59 +01:00
54be390bba
fix: check err before preload
2021-11-03 15:27:15 +08:00
3bc369459b
Update kicbase to v0.0.28
2021-10-27 19:53:03 +00:00
016b3ac40a
trim space earlier
2021-10-21 13:28:52 -07:00
fbd4d27582
fix podman network inspect index check
2021-10-21 10:01:10 -07:00
75804c43ad
Match the lower case of the podman error message
...
Turns out that Docker says "No such network",
but Podman says "no such network". Little nuances.
2021-10-10 12:25:18 +02:00
1a4160e60d
Merge pull request #12081 from spowelljr/buildkitSocket
...
buildkit socket: Add systemd unit
2021-10-01 20:49:41 -04:00
39eb5cb53c
Updating kicbase image to v0.0.27-1633027942-12081
2021-09-30 19:21:11 +00:00
dafbe6aac3
add created by label for podman
2021-09-29 13:47:59 -07:00
1976e1b296
Update kicbase to v0.0.27
2021-09-16 18:55:00 +00:00
030b3837ab
Updating kicbase image to v0.0.26-1631295795-12425
2021-09-14 09:50:53 -07:00
145f9fc9ab
run `go fmt`
2021-09-13 11:58:43 -07:00
67b82f3fe1
Update kicbase to v0.0.26
2021-09-03 02:18:31 +00:00
703324b7c7
Updating kicbase image to v0.0.25-1630631232-12398
2021-09-03 01:36:51 +00:00
323225483e
Support Rootless Docker
...
Requirements:
- Install rootless Docker 20.10 or later, see https://rootlesscontaine.rs/getting-started/docker/
- Enable cgroup v2 delegation, see https://rootlesscontaine.rs/getting-started/common/cgroup2/
Usage: `minikube start --driver=docker --container-runtime=containerd`.
The `--container-runtime` flag needs to be set to "containerd".
CRI-O can be also supported later.
Closes issue 10836 ("add support for rootless Docker").
Support for rootless Podman (issue 8719) is not covered in this commit.
---
Code reading guide:
- `deploy/kicbase/Dockerfile`: updated to install fuse-overlayfs and containerd-fuse-overlayfs, which is used
instead of `overlayfs` snapshotter
- `deploy/kicbase/entrypoint`: updated to verify cgroup v2 delegation.
Mostly from 8a83ee46b2/images/base/files/usr/local/bin/entrypoint
2021-08-27 17:21:53 +09:00
6cecbf6fe5
Updating kicbase image to v0.0.25-1628619379-12032
2021-08-10 18:33:49 +00:00
4040311f1e
Use fully qualified image name for docker hub fallback image
2021-07-13 16:09:55 -07:00
81c2bb2796
Merge pull request #11708 from afbjorklund/info-klog
...
Make sure to log errors from DaemonInfo
2021-07-07 13:29:05 -04:00
4db717a5eb
Update kicbase to v0.0.25
2021-07-01 23:38:36 +00:00
202e2fa36f
Updating kicbase image to v0.0.24-1625170572-11834
2021-07-01 20:31:45 +00:00
05b64d1a74
Merge pull request #11824 from andriyDev/fix-auto-pause
...
Make kicbase copy auto-pause binary instead of auto-pause folder
2021-07-01 16:10:33 -04:00
2bf9076527
Updating kicbase image to v0.0.24-1625086337-11824
2021-06-30 21:07:40 +00:00
89c7853601
bump go mod libs manually
2021-06-29 15:24:59 -04:00
bce90e5037
Update kicbase to v0.0.24
2021-06-25 23:41:39 +00:00
3b533a07cb
Make sure to log errors from DaemonInfo
2021-06-22 07:56:11 +02:00
64a41824c5
Update kicbase to v0.0.23
2021-06-09 00:28:52 +00:00
d76259e86f
Merge pull request #11528 from andriyDev/FixDownloadOnlyTest2
...
Change PreloadExists to report no preload for BareMetal drivers
2021-06-02 12:59:15 -07:00
853f1cb4db
first try gcr
2021-06-01 15:16:17 -07:00
2f4b7985c0
try image without sha before failing
2021-06-01 15:11:01 -07:00
f9f3ef9a09
Pass driverName into Preload and PreloadExists to report no preload for BareMetal.
2021-05-27 15:02:00 -07:00
6cb7c2166c
spell
2021-05-21 14:09:42 -07:00
9c9934879c
break guest provision when container exists prematurely
2021-05-21 13:34:34 -07:00
d6691e796c
Add `Close() error` function into assets.CopyableFile
...
Add `Close` function and implemetions to explicitly close os.File which opend by
NewFileAsset.
2021-05-20 21:05:09 -07:00
707af502f3
Merge pull request #11300 from ilya-zuyev/ilyaz/gh_11293
...
Fix getting of gateway IP for podman driver
2021-05-14 17:04:24 -07:00
dcadd32624
Add comment, improve template
2021-05-14 14:38:29 -07:00
e8b16a5247
Updating kicbase image to v0.0.22-1620785771-11384
2021-05-12 02:25:58 +00:00
a1ae930d2f
Simplify the code
2021-05-06 11:17:43 -07:00
6e2eae0d0a
Simplify the code
2021-05-06 11:13:10 -07:00
f4e142d442
Simplify the code
2021-05-06 10:35:22 -07:00
8d2b811fcf
Remove debug logs
2021-05-05 22:01:21 -07:00
6cf6ba2ff2
Fix network settings parsing
2021-05-05 19:31:12 -07:00
829cc42a65
Fix network settings parsing
2021-05-05 19:11:56 -07:00
618d09ab76
Fix network settings parsing
2021-05-05 17:14:33 -07:00
01f76f7d4f
Add debug logs
2021-05-05 16:29:11 -07:00
adc53aa677
Fix error handling
2021-05-05 15:58:16 -07:00
61c1b301be
Fix linter errors
2021-05-05 15:31:11 -07:00
fe392b4233
When getting a gateway IP for podman container inspect per-network data as well
2021-05-05 15:09:46 -07:00
625a06ce6d
Update kicbase to v0.0.22
2021-05-05 21:18:37 +00:00
c5b65cab51
Update kicbase to v0.0.21
2021-04-30 18:08:55 +00:00
fff23925e0
Updating kicbase image to v0.0.20-1619543236-11212
2021-04-27 17:16:43 +00:00
30d659c635
Merge pull request #11055 from afbjorklund/kic-os-update
...
Update kicbase base image
2021-04-24 21:09:32 -07:00
60d8401f59
Merge pull request #11086 from sharifelgamal/mock-mirror
...
avoid network calls for mirror unit tests
2021-04-16 13:46:31 -07:00
1319b6e398
refactor checkRepository to make mocking easier
2021-04-14 12:51:16 -07:00
0e1fd72042
Updating kicbase image to v0.0.20-1618262794-11055
2021-04-12 21:36:41 +00:00
f527fb675a
Address security concerns with the go code
...
As flagged by the github code scanning
2021-04-12 20:38:21 +02:00
f7c204d907
Update kicbase to v0.0.20
2021-04-09 19:23:04 +00:00
831c3dfdbd
Updating kicbase image to v0.0.19-1617905290-11019
2021-04-08 18:17:37 +00:00
1e3370298a
Merge pull request #11001 from lilongfeng0902/minikube-lilf
...
minor spelling errors
2021-04-07 17:35:39 -07:00
db3fd51194
Rename ListOptions to ListContainersOptions
2021-04-06 22:39:43 +02:00
7ae82c573b
Propagation not Propogation
2021-04-06 14:52:52 +08:00
53babcc152
Update kicbase to v0.0.19
2021-04-05 22:22:23 +00:00
894ca125cb
Merge pull request #10858 from prezha/fix-create-network-race
...
create network: use locks and reservations to solve race condition
2021-03-24 17:47:21 -07:00
9b23841ee3
Add solution message if Docker is rootless
2021-03-20 13:20:30 -07:00
f4a375181a
create network: use locks and reservations to solve race condition
2021-03-18 18:38:06 +00:00
223792b993
create network: use locks to solve race conditions
2021-03-17 14:32:39 +00:00
3110bd15fc
Lowercase minikube in information message
2021-03-05 15:50:52 +01:00
0d1d169bf6
Set non-local traffic message as a Tip message
...
To stay consistent with other messages. Also moved it above the warning
message regarding what IP is set as listen-address to make more sense in
the message flow.
2021-03-03 17:07:23 +01:00
bb5bf9546c
Add info message about not using it for production
...
To add more context to the warning message for --listen-address
2021-03-02 20:21:39 +01:00
9b5a96e76d
Make warning more informative for --listen-address
2021-03-01 23:10:58 +01:00
bad8561d0d
Skip custom listenAddress if equal to default
2021-03-01 23:06:13 +01:00
cb116e4c1c
Add --listen-address for docker driver
2021-02-28 23:14:08 +01:00
2c292cca75
Update kicbase to v0.0.18
2021-02-25 23:14:51 +00:00
f272822d15
bump kic base
2021-02-24 13:45:53 -08:00
e9e81cef25
bump kicbase
2021-02-24 13:29:10 -08:00
549bb10a52
update kicbase with pause
2021-02-24 12:30:06 -08:00
72135d70d9
add auto pause proxy
2021-02-24 12:30:06 -08:00
460342a5f2
Merge pull request #10575 from hetong07/issue_10519
...
Improve the error message of setting cgroup memory limit.
2021-02-24 11:53:54 -08:00
7f75dfffda
drop support for github packages for kicbase
2021-02-23 14:16:02 -08:00
9a30756d38
Improve the error message of setting cgroup memory limit.
2021-02-22 20:18:22 -08:00
d6e9174435
update new tag, SHA, and doc due to new kicbase image
2021-02-21 17:27:24 -08:00
d120656161
update image
2021-02-20 10:55:56 -08:00
712ab628a6
update kicbase
2021-02-20 10:11:35 -08:00
5c6c20f68e
Merge pull request #10528 from sharifelgamal/crio-storage
...
fix crio by hardcoding mountopt
2021-02-19 22:54:33 -08:00
9abb3bed51
update kicbase image
2021-02-19 18:08:41 -08:00
fb27ab7e7f
Merge pull request #10439 from prezha/prevent-oci-overlapping-net
...
prevent oci try to create overlapping network
2021-02-19 16:23:18 -08:00
629926a2bd
Merge pull request #10418 from afbjorklund/kicbase-210119
...
Update kicbase base image and sync with kind
2021-02-19 11:33:11 -08:00
17af0f999b
update kicbase image for testing
2021-02-18 19:20:17 -08:00
0edb126f13
Merge pull request #10512 from hetong07/cgroup_memory_fix
...
cgroup v2: skip setting --memory limits when not configurable.
2021-02-18 18:56:57 -08:00
96c5b6a0d4
Merge pull request #10408 from sharifelgamal/kic-test
...
populate kic.txt properly in kicbase
2021-02-18 18:42:17 -08:00
74e2127a87
update kicbase image for the last time
2021-02-18 18:28:02 -08:00
556a8d7930
Move the user facing warning inside hasMemoryCgroup().
2021-02-18 16:43:19 -08:00
114364409d
add github packages to script
2021-02-18 16:17:09 -08:00
e8c2a23398
Provide an advice for users on how to modify Grub setting.
2021-02-18 16:09:51 -08:00
7b0bf57f4c
Stop using --memory for cgroup v2.
2021-02-18 15:43:26 -08:00
31ea98ca50
update kicbase to newest build
2021-02-18 15:04:34 -08:00
369f93f393
Merge pull request #10468 from afbjorklund/cgroups-warning
...
Make sure to show debian warning also for cgroup 2
2021-02-18 14:25:59 -08:00
f11498046b
messed up boilerplate
2021-02-18 11:52:38 -08:00
3f04535045
add dockerhub to autopush
2021-02-18 11:47:59 -08:00
75be14d2ce
Merge pull request #10507 from afbjorklund/docker-memswap
...
Stop using --memory-swap if it is not available
2021-02-18 11:15:32 -08:00
eabc02d3c4
Stop using --memory-swap if it is not available
...
With Debian and Ubuntu kernels, it needs to be configured.
And now with cgroups v2, it starts throwing errors at run.
2021-02-18 18:54:36 +01:00
fd897f4f23
fix up repo stuff
2021-02-17 10:32:48 -08:00
ea16737271
syntax
2021-02-17 09:37:34 -08:00
9aeb4a75fa
update kicbase image
2021-02-17 09:35:32 -08:00
6d61795352
simplify free subnet query for oci net create
2021-02-17 03:04:47 +00:00
4018ee3682
move to separate network package and fix naming
2021-02-17 03:04:47 +00:00
d48b0a58e8
add ip conflict auto-resolution also to kvm and consolidate
2021-02-17 03:04:47 +00:00
c6446e5fbd
prevent oci try to create overlapping network
2021-02-17 03:04:47 +00:00
5bffb823b2
Add ProfileLableKey to make sure that preload side car will be target of deletion. minikube delete doesn't check CreatedByLabelKey
2021-02-17 10:27:54 +09:00
fd58d0fc90
Add CreatedByLabelKey to make sure that preload side car will be target of deletion
2021-02-17 10:06:12 +09:00
e3cd93aa1a
Change prepareVolume func to add container name for preload side car
2021-02-17 10:06:12 +09:00
2c87f6e1ad
Make sure to show debian warning also for cgroup 2
...
Move check to function, to cut down on complexity
2021-02-13 18:37:54 +01:00
Steven Powell
Pablo Caderno
minikube-bot
Medya Ghazizadeh
Akihiro Suda
Steven Powell
Sharif Elgamal
Piotr Resztak
Medya Gh
James Yin
Anders F Björklund
なつき
Andriy Dzikh
Daehyeok Mun
Ilya Zuyev
李龙峰
Predrag Rogic
Patrik Freij
hetong07
Jiefeng He
Kent Iso