97d96bf925
Switching from glob library to klog library.
2020-09-29 15:49:41 -07:00
b84dedc652
address review comments
2020-09-29 15:07:06 -07:00
82f39d1387
clarify comment
2020-09-29 14:29:34 -07:00
058adb775c
address review comments
2020-09-29 14:14:25 -07:00
b7780ec815
address review comments
2020-09-29 14:14:25 -07:00
f163cf9e15
update with new logic
2020-09-29 14:14:25 -07:00
2766235a5c
try alternate if no network
2020-09-29 14:14:25 -07:00
fa0afb220d
lint
2020-09-29 14:14:25 -07:00
f0f10d6135
first version
2020-09-29 14:14:24 -07:00
9cd42163b1
add network create funcs
2020-09-29 14:14:24 -07:00
91a32541e8
Use %d for exit code
2020-09-29 09:49:30 -07:00
8eaa3ee4f3
Use oci.CachedDaemonInfo for status check
2020-09-29 09:19:14 -07:00
f097a0de12
dates, take two
2020-09-17 13:20:35 -07:00
775e047517
dates
2020-09-17 13:18:53 -07:00
3cb6ba0f75
actually add unit tests
2020-09-17 13:16:07 -07:00
84ee6d351b
unit tests
2020-09-17 13:11:01 -07:00
39ae4fbdd2
check for windows style pathing with a regex
2020-09-17 12:15:54 -07:00
23e7989c07
Merge branch 'master' of github.com:kubernetes/minikube into windows-mount
2020-09-17 11:12:35 -07:00
b98580c820
fix up if statement
2020-09-17 10:31:10 -07:00
eab92dc455
Reduce cyclotomic complexity of CreateContainerNode to fix lint
2020-09-17 10:22:28 -07:00
4a004dd58e
simplify more
2020-09-16 16:39:03 -07:00
14a5b0b264
simplify append
2020-09-16 16:04:10 -07:00
6e9b1b7bc0
fix mounting for docker driver in windows
2020-09-16 14:55:40 -07:00
44c6f36362
Merge pull request #9255 from afbjorklund/cpus-cfs
...
Make sure CFS_BANDWIDTH is available for --cpus
2020-09-15 16:07:12 -07:00
f718e39ab9
Make sure CFS_BANDWIDTH is available for --cpus
2020-09-15 12:54:39 +02:00
af5d6d060b
Fix ForwardedPort for podman version 2.0.1 and up
...
Increasing Docker compatibility broke Podman v1
2020-09-13 22:17:36 +02:00
ee5b8f130f
Merge pull request #8831 from priyawadhwa/overlay
...
Set preload=false if not using overlay2 as docker storage driver
2020-09-09 11:45:52 -07:00
3c86db01f4
Merge pull request #9166 from priyawadhwa/revert-static-ip
...
Revert static IP for docker
2020-09-02 15:49:40 -07:00
914f10b458
Merge pull request #9149 from tstromberg/docker-no-swap
...
Disable swap in Docker & podman containers
2020-09-02 14:55:44 -07:00
22b40e215a
revert static IP
2020-09-02 16:33:38 -04:00
ea5af644ec
fix merge conflict
2020-09-02 09:31:42 -04:00
2dac55abf4
Merge pull request #9062 from kadern0/issue-8131
...
docker: Choose the appropriate bridge interface when multiple exist
2020-09-01 16:46:01 -07:00
8a26881552
Merge pull request #8159 from Asarew/docker-host-volumes
...
Support for mounting host volumes on start with docker driver
2020-09-01 16:30:45 -07:00
0408d3ba1a
Added code to inspect docker networks to get the bridgeID correctly
...
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
2020-09-02 08:44:07 +10:00
7fc0299c6f
Disable swap in Docker/podman by setting --memory-swap to --memory
2020-09-01 13:57:52 -07:00
2c5e8fdaee
Add detailed JSON & status codes for all error paths
2020-08-30 17:25:11 -07:00
d634a85ff9
use daemon info so this works for docker and podman
2020-08-24 17:50:09 -04:00
535294e523
fixed merge conflict
2020-08-24 17:35:03 -04:00
56691f839c
add swarm and storage driver to DaemonInfo
2020-08-19 15:38:56 -07:00
52953bac93
Merge branch 'master' of github.com:kubernetes/minikube into kic-add-static-ip
2020-08-12 14:03:43 -07:00
a949f9ca7b
improvement
2020-08-12 12:58:21 -07:00
bdb59c2598
lint
2020-08-12 12:56:07 -07:00
dfa05d714e
include gateway when creating custom network
2020-08-12 12:54:06 -07:00
af94e0a0c5
add logging
2020-08-12 10:57:48 -07:00
2400d1b850
remove network correctly
2020-08-12 10:08:46 -07:00
69d21df7c5
make sure we use custom network if it exists
2020-08-12 12:45:49 -04:00
3b5f973459
make sure we delete networks correctly
2020-08-12 12:36:57 -04:00
51bbba9bdc
Merge pull request #8973 from medyagh/daemon_info_unittest
...
add unit test for daemon info
2020-08-11 15:50:02 -07:00
f20d3bddf0
add boilerplate
2020-08-11 15:13:16 -07:00
25dc0cd0f7
lint
2020-08-11 15:03:10 -07:00
f8d932e697
use mock funcs
2020-08-11 14:55:30 -07:00
4c0334d91f
add one more case
2020-08-11 13:10:17 -07:00
a9eec3ca7b
add unit test for daemon info
2020-08-11 13:06:50 -07:00
7463eda122
remvoe comment
2020-08-11 10:40:40 -07:00
1d94fa911a
ensure nil error is returned
2020-08-11 10:40:40 -07:00
bbc58fa194
refresh daemon info cache if there is error
2020-08-11 10:40:40 -07:00
21789d8c4e
compile
2020-08-10 17:18:42 -04:00
dfcfd6f2f0
cleanup
2020-08-10 17:15:26 -04:00
9dcb0c5478
fix merge conflict
2020-08-10 17:12:56 -04:00
5799b47ddb
Implement some checks and reorganize code
2020-08-10 17:04:41 -04:00
9680237277
WIP
2020-07-27 14:24:40 -04:00
9c0618f102
Merge to master
2020-07-24 11:22:59 -07:00
bd713ffd45
Increase maximum container startup wait from 13 seconds to 25 seconds
2020-07-24 09:02:32 -07:00
dee9c0b427
Show 'docker logs' excerpt if container dies
2020-07-24 08:58:09 -07:00
f04a6a061f
Merge pull request #8586 from afbjorklund/container-id
...
Support more error messages for container inspect
2020-07-21 12:22:31 -07:00
2086bcb2b1
Merge pull request #8718 from medyagh/check_docker_deskop
...
docker/podman: warn if allocated memory is below limit
2020-07-20 15:26:41 -07:00
13357d91a4
avoid nil pointer
2020-07-20 12:56:03 -07:00
22585c3a17
Use the preload container run for podman as well
...
Now that there is no more race between the containers for
preparing the volume, we can use it for podman as well...
Previously we risked ending up with not copying the contents
of /var from the container image, which made it not work.
2020-07-20 21:54:28 +02:00
2a9e9b2425
Make sure to prepare the kic volume after creation
...
The volume is created as empty, so make sure that we run a
container to do the initial copy of /var from the image.
This is to avoid race conditions later on, where the preload
starts to use the created volume for packing up the tarball.
2020-07-20 21:50:13 +02:00
c2175abcba
Add static ip to kic/docker
2020-07-18 18:19:53 -03:00
3aac9a3fff
remove duplicate return statement
2020-07-15 14:24:42 -07:00
8ecb483cb7
use cached error
2020-07-15 14:23:25 -07:00
7bbb0b6250
spell
2020-07-15 14:09:35 -07:00
de6c10526b
move cacheDaemoninfo to oci package
2020-07-15 14:07:50 -07:00
d0d3973a13
restrict apparmor security opt to docker
2020-07-09 12:58:01 -07:00
7bcae732bf
resolved merge conflicts
2020-06-30 10:00:52 +02:00
f23bbea995
Support more error messages for container inspect
...
The messages are different between "inspect" and "container inspect",
and also changed a bit in format between Podman v1 and Podman v2.
Support all of them, for compatibility with different versions of
Docker and Podman. Was causing restarts and failures, with KIC.
2020-06-28 14:19:09 +02:00
7c2cac612d
Fix bug in FailFastError and add unit test
...
Since FailFastError was just another `error`, all errors were technically `FailFastErrors`.
This code makes `FailFastError` a struct which implements the error interface, so that now errors can be distinctly identified as `FailFastError`'
Also added a unit test to prove that this works now.
2020-06-26 11:58:34 -07:00
e32e2135ed
review comments
2020-06-25 19:39:59 -07:00
903686172d
Check for iptables file before determining container is running
2020-06-25 17:58:22 -07:00
e91e11eeba
address review comments
2020-06-17 18:32:11 -07:00
29e01d5dcb
fix comment
2020-06-17 15:17:45 -07:00
ca2d0f97ec
move advice to its own file
2020-06-17 15:07:17 -07:00
543b0b5bfa
add post mortem logs when container not running
2020-06-17 13:27:17 -07:00
736f5219e0
add error type for check running
2020-06-17 12:13:12 -07:00
56b5524c8e
address review comments
2020-06-16 14:57:19 -07:00
4caf260279
add cpu count limit error type for kic drivers
2020-06-16 13:21:56 -07:00
6ef48499b4
Code review comments
2020-06-12 11:00:46 -07:00
b750ab4964
fix lint
2020-06-11 13:00:46 -07:00
330224f36a
Warn user to restart daemon if context deadline is exceeded
2020-06-11 12:50:11 -07:00
0ec839186d
Change glog.Errorf to glog.Infof so that we don't get an ugly log to stdout
2020-06-11 11:14:04 -07:00
14937e4677
Never use docker inspect, always provide the type
...
Should avoid errors like: map has no entry for key "State"
When inspecting a volume, rather than a container or image
2020-05-21 17:20:53 +02:00
59de926bf1
updated --docker-volume flag description and ran docs generator
2020-05-15 12:03:56 +02:00
1909c4bb7c
add support for `--docker-volume` command line flag to mount host volumes on start
2020-05-15 11:44:24 +02:00
afab7c87c6
Merge pull request #7959 from afbjorklund/podman-prompt
...
Use noninteractive sudo when running podman
2020-05-11 21:02:22 +00:00
6b97ee8ee2
Merge pull request #8001 from afbjorklund/podman-start
...
podman: Wrap the start command with cgroup manager too
2020-05-11 17:59:39 +00:00
c578a7aa1e
Add a PointToHost function for podman as well
...
And add an active variable, similiar to docker
2020-05-10 23:07:12 +02:00
7e3da0f8b0
Merge pull request #8017 from elegos/podman-volumes-extract-tarball-to-volume
...
Podman: disable selinux labels when extracting the tarball (permissions error)
2020-05-09 21:35:43 +00:00
46025eccf5
Use the runCmd wrapper for start to not miss error
2020-05-09 14:07:18 +02:00
ac01e92012
Add comment about why podman looks at runtime.GOOS
2020-05-09 14:05:57 +02:00
a7a5148ff6
Don't add cgroup manager param for podman-remote
...
Since it doesn't work for either "run" or "start"
Error: unknown flag: --cgroup-manager
2020-05-09 14:04:04 +02:00
85fae62d4a
Wrap the start command with cgroup manager too
...
When running with podman, to match the run cmd
2020-05-09 14:04:04 +02:00
934ad06a82
Use noninteractive sudo when running podman
...
To avoid asking for a password in the middle of minikube commands.
The setup process is supposed to involve adding podman to sudoers...
2020-05-09 13:23:46 +02:00
436cee2d84
Fix minikube/kubernetes capitalization, make short help consistent
2020-05-07 14:12:10 -07:00
9c43c47b06
Podman: disable selinux labels when extracting the tarball to prevent permission errors
2020-05-07 02:09:09 +02:00
6eeb929b3d
Merge pull request #7962 from afbjorklund/podman-gateway
...
Get the gateway by inspecting container network
2020-05-04 20:05:56 +00:00
1da92a1c84
Merge pull request #7961 from afbjorklund/podman-preload
...
Use the correct binary for unpacking the preload
2020-05-04 20:04:19 +00:00
e0685c8f5d
Merge pull request #7984 from medyagh/detect_windows_container
...
Detect windows container and exit with instructions
2020-05-04 20:01:17 +00:00
cc6506d2c9
Remove logging statement from containerGateway
2020-05-03 09:42:32 +02:00
bcecda8e20
add comment for error type
2020-05-02 18:48:52 -07:00
2102a20605
wrap errors
2020-05-02 18:38:23 -07:00
4572d0634f
exit with usage if container type is windows
2020-05-02 18:29:33 -07:00
ee9004f93b
add os type to DaemonInfo
2020-05-02 17:02:19 -07:00
743f9f7efc
Don't show any podman hint about restarting sudo
2020-05-01 22:21:32 +02:00
e2d7d94dfc
Use the correct binary for unpacking the preload
...
Previously hardcoded to *always* use a Docker volume,
even if using a different container driver (podman).
2020-05-01 22:11:28 +02:00
3531efda7b
Get the gateway by inspecting container network
2020-05-01 15:05:21 +02:00
78a22f5056
Remove prefix parameter and add prefix command
...
Move the "sudo" prefix to a central location, instead of
having it all over the place. Assume only needed on Linux.
2020-04-28 13:52:52 +02:00
1744ffe773
Restore the configured state added for podman
...
Reverted 22aa1aff22
2020-04-27 22:27:53 +02:00
998ab840fb
Use simple version of podman info format parameter
...
So that it works with the older versions of podman
2020-04-26 22:54:45 +02:00
795128131f
Remove old Copy function added in merge conflict
2020-04-26 22:52:10 +02:00
28106fa2d7
Use constants instead of the KIC prefix strings
2020-04-26 15:22:57 +02:00
88c8a24d55
Pass the container implementation on to systemd
2020-04-25 22:43:40 +02:00
7185140c57
Remove extra quotes added in conflict resolution
...
Reverted f264ac171e
2020-04-25 22:09:52 +02:00
7647b1f998
Don't try to limit podman memory without cgroup
...
Podman requires both memcg and memcg_swap for it (--memory).
Docker will still limit memory, without swap limit support.
2020-04-25 22:01:51 +02:00
6644c5cc64
Merge branch 'master' into podman-sudo
2020-04-25 18:05:33 +02:00
63f9bfbb61
addres review comments
2020-04-24 14:07:54 -07:00
ef01ed481c
get rid of global CliRunner
2020-04-23 14:37:03 -07:00
17f420cc71
warn slow part of cli runner
2020-04-23 01:23:49 -07:00
d9f1b532d0
unexport warnIfSlow func
2020-04-23 00:33:59 -07:00
038aef6b48
unexport warnIfSlow func
2020-04-23 00:33:40 -07:00
8a0a210763
convert more funcs to use cli runner
2020-04-23 00:29:37 -07:00
c6e1445ccb
convert more to cli runner
2020-04-23 00:12:41 -07:00
29df4260ef
make all oci volume calls go through runner
2020-04-22 23:27:54 -07:00
915058ef8e
lint
2020-04-22 23:01:04 -07:00
72baa1dad2
convert execs to cliRunner
2020-04-22 22:49:48 -07:00
c6895c2058
add cli runner to info
2020-04-22 22:34:11 -07:00
fad745f607
adding runner for oci package
2020-04-22 22:16:18 -07:00
b639c6112d
fix delete and add integeration test
2020-04-20 20:38:31 -07:00
19be5619d6
Resource limits seem to work ok when not rootless
2020-04-19 09:45:16 +02:00
024cd6b108
Use the same kind of named /var mount for podman
...
The internal anonymous mounts do not seem to have the same
issues as the external path mounts, so we can do all of /var
2020-04-19 09:45:16 +02:00
8987b1067a
Also persist the kubelet and the cni state dirs
2020-04-19 09:45:16 +02:00
223424652c
Also create and mount the container runtime dirs
2020-04-19 09:45:16 +02:00
df3aec6b0a
Missed to wrap one podman inspect in sudo proper
2020-04-19 09:45:16 +02:00
f57faf8036
Only remount the /var/lib/minikube directory
2020-04-19 09:45:16 +02:00
22aa1aff22
Handle more state and status for the podman driver
2020-04-19 09:45:16 +02:00
f264ac171e
Remove extra single-quotes from format parameter
...
podman
Error: template parsing error: template: image:1: function "json" not defined
2020-04-19 09:42:17 +02:00
d7dc7bf7b2
The podman driver should not be run as root
...
Use sudo for the podman commands instead
Wrap the docker commands with env prefix
2020-04-19 09:42:17 +02:00
bf15f9a00c
fix build err
2020-04-16 16:20:04 -07:00
934f900f16
improve kic start and kill
2020-04-16 16:10:44 -07:00
34fafc783f
fine tune
2020-04-14 22:20:28 -07:00
7303ccf07d
lint
2020-04-14 21:31:12 -07:00
54aa958f01
use oci to delete
2020-04-14 20:51:18 -07:00
f22a36332e
add shut down to stop
2020-04-14 20:21:40 -07:00
b7f0bfc369
unconfine apparmor for kic
2020-04-13 16:44:17 -07:00
3a12fbd1f5
Fix spelling
2020-04-09 10:50:20 -07:00
70329bf51d
Code review comments
2020-04-08 13:44:04 -07:00
b509d69182
Extract preloaded tarball as soon as minikube volume is created
...
Extracting preload currently takes 6 seconds. This PR begins preload extraction as soon as the minikube volume is created, and runs it in parallell with creating the container node and setting up SSH.
This shaves 2-3 secnods off of `node.StartHost`
2020-04-07 14:19:20 -07:00
a0263c2513
adjust more
2020-04-03 20:59:03 -07:00
a62d611e0b
adjust kill time
2020-04-03 20:59:03 -07:00
8f51d7de58
adjust warn if slow for ps and volume
2020-04-03 20:59:03 -07:00
5307145802
Move errors and warnings to output to stderr
2020-04-02 09:58:13 -07:00
2f2dccd30c
Remove test values
2020-03-26 14:05:02 -07:00
46f31480df
Make slow command detection consistent across kic/oci
2020-03-26 14:03:22 -07:00
f00f5ff600
remove extra if
2020-03-24 10:21:32 -07:00
940baa09ea
fix comment
2020-03-24 07:31:22 -07:00
41b16b1568
fail if container is not running
2020-03-24 07:27:07 -07:00
83cc28e082
add logging for when container status is running
2020-03-24 07:11:22 -07:00
f54af5d684
function name HostPortBinding changed to ForwardedPort
2020-03-14 21:28:12 +05:30
43ce409e79
Extra debugging for preload generation process
2020-03-11 13:09:55 -07:00
9ac1ad2a7e
Merge master
2020-03-06 16:13:54 -08:00
e027dfc4d2
More unused code cleanup
2020-03-06 15:57:12 -08:00
3fee641a13
Remove remaining PointToHostDockerDaemon calls
2020-03-06 15:15:05 -08:00
a58a9f0176
tweak
2020-03-06 15:13:56 -08:00
cb14468b44
english
2020-03-06 15:11:42 -08:00
cdb8f9c3f6
make sure container is running after create
2020-03-06 15:08:39 -08:00
38ccb88e3f
address code review
2020-03-06 10:25:48 -08:00
0335fb1ad7
change names
2020-03-05 22:38:47 -08:00
1e8dd94a77
fix logic
2020-03-05 22:31:44 -08:00
e1f6820335
fix already in use
2020-03-05 16:42:56 -08:00
0ff12cafac
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-04 16:37:54 -08:00
a3e000d850
addressing comments
2020-03-04 14:09:15 -08:00
f40c5a7b30
move funcs arround
2020-03-04 12:50:01 -08:00
6a62046e62
add warning and point to right docker
2020-03-04 10:22:20 -08:00
28e030c728
Merge branch 'master' of github.com:kubernetes/minikube into machinename
2020-03-03 12:16:47 -08:00
31a42ce672
address comments
2020-03-02 17:30:08 -08:00
05a46f6526
remove unnecessary PreloadedVolume
2020-03-02 16:17:35 -08:00
4cd3ef81a5
more changes
2020-03-02 15:21:37 -08:00
d6e94c1ee4
remove unused functions
2020-03-02 13:54:35 -08:00
474561d082
remove unused functions
2020-03-02 13:48:18 -08:00
697359b4f3
Fixed lint
2020-03-02 13:37:22 -08:00
6b0e942e7e
Rebased on master
2020-03-02 13:33:27 -08:00
3cf2c9bbe3
Merge pull request #6807 from medyagh/delete_hang
...
warn about "stuck docker" in minikube delete
2020-02-26 14:32:18 -08:00
8d0c41392b
continue instead of nest
2020-02-26 13:50:42 -08:00
4709af55df
resolve review comments
2020-02-26 12:44:25 -08:00
e8c85543f7
limit time waiting for delete
2020-02-26 10:57:46 -08:00
6651e0b5a5
docker podman sysinfo
2020-02-26 09:15:25 -08:00
f3c171eaa3
show info for docker damemon
2020-02-25 17:34:03 -08:00
e60b034c84
Add Daemon Info func to oci
2020-02-25 17:16:49 -08:00
aefbf2cd18
Rebased on master
2020-02-24 13:41:06 -08:00
fa9f7f9794
Add comments to avoid warnings from go lint
2020-02-22 16:12:42 +01:00
Priya Modali
Medya Gh
Thomas Stromberg
Sharif Elgamal
Medya Ghazizadeh
Anders F Björklund
Priya Wadhwa
Pablo Caderno
Jose Donizetti
Asare Worae
Giacomo Mr. Wolf Furlan
Medya Gh
vikkyomkar