Commit Graph

60 Commits (master)

Author SHA1 Message Date
Victor Ubahakwe 958ecac9d3
Refactor table rendering (#20893)
* Refactored table rendering codes to support updated tablewriter v1.0.7

This commit makes all necessary code changes to maintain compatibility
with the new tablewriter version. The update includes several required modifications across multiple files.

Files modified:
- cmd/minikube/cmd/config/images.go
- cmd/minikube/cmd/config/addons_list.go
- cmd/minikube/cmd/config/profile_list.go
- hack/benchmark/time-to-k8s/chart.go
- hack/benchmark/time-to-k8s/cpu.go
- pkg/minikube/audit/row.go
- pkg/minikube/machine/cache_images.go
- pkg/minikube/perf/result_manager.go
- pkg/minikube/service/service.go

Now #20878 can be merged.
Addresses #20879

* The tablewriter package v1.0.7 renamed SetHeaders to SetHeader

* updated go mod and table.SetColumnAlignment([]int{0, 0, 0, 0})

* Changed syntax and added vendor to gitignore

* simplified version of tablewriter

* removed vendor

* fix addon_list

* fix images tablewrtier

* bump tablewriter for profile list

* go mod tidy

* bump tablewriter for chart

* bump tablewriter for cpu chart

* bump tablewriter for row

* bump tablewriter cache images

* bump tablewriter

* bump tablewriter

* revert file

* bump tablewritter

* fix unit test

* fix lint issues

* fix the integration test pipe char

* convert all tables to new pipe instead of asci pipe

* convert all tables to new pipe instead of asci pipe

* go mod tidy

* go work sync

---------

Co-authored-by: Medya Ghazizadeh <medya@google.com>
2025-07-21 16:20:55 -07:00
Tian 3cf1e63e21
build: address all lint issues by v2 (#20804)
* fix QF1011: could omit type *os.File from declaration; it will be inferred from the right-hand side

* fix QF1012: Use fmt.Fprintf(x, ...) instead of x.Write(fmt.Sprintf(...))

* fix QF1001: could apply De Morgan's law

* fix QF1003: could use tagged switch

* fix weakCond: suspicious ; nil check may not be enough, check for len (gocritic)

* fix docStub: silencing go lint doc-comment warnings is unadvised

* fix builtinShadow: shadowing of predeclared identifier: error

* fix importShadow: shadow of imported package

* fix nestingReduce: invert if cond, replace body with , move old body after the statement

* useless-break: useless break in case clause (revive)

* Clear the redundant content in golangci.yaml file
2025-05-23 17:31:28 -07:00
Steven Powell eea20cd06f fix lint errors 2024-11-12 10:18:20 -05:00
racequite c21dabc8da chore: fix function name in comment
Signed-off-by: racequite <quiterace@gmail.com>
2024-04-19 12:47:50 +08:00
Raiden Shogun 91af678ac6 feat: add docker-env containerd into image benchmark 2024-02-12 02:13:49 +08:00
Raiden Shogun cbe67a2f45 image-bechmark: change s3 bucket 2023-10-21 16:44:37 +02:00
Raiden Shogun 18140ecc1c update minikube-image-benchmark submodule 2023-10-16 19:28:30 +02:00
Товарищ программист 37c0401058 fix: reduce test cases and memory for image benchmark 2023-10-12 20:56:25 +08:00
Raiden Shogun d9ec85583f fix: decrease runs for benchmark 2023-10-01 23:30:17 +02:00
Товарищ программист 0fcd811253 add github action for running minikube-image-benchmark 2023-09-27 22:55:21 +02:00
Steven Powell 50e9147e4e fix lint errors 2023-03-20 12:43:07 -07:00
Steven Powell 6f2971121b update time-to-k8s 2022-11-04 16:02:50 -07:00
Steven Powell 8885a7d101 bump time-to-k8s version to fix Go 1.18 build issue 2022-08-01 12:59:50 -07:00
Steven Powell ab4deec35d undo defer 2022-06-23 13:25:56 -07:00
Steven Powell ef3d645d8a fix time-to-k8s 2022-06-23 13:11:18 -07:00
Kian-Meng Ang bc03821826 Fix typos 2022-06-10 15:26:35 -07:00
Jin Zhang 179e3952a4 [benchmark/cpu] set ymax to prevent the graph go to the legend 2022-03-24 23:26:20 +00:00
Jin Zhang 7bd8639fbc [benchmark] add cpu utilization 2022-03-07 20:15:29 +00:00
Steven Powell ab9770a86c fixed table formatting 2022-01-21 12:09:19 -08:00
Steven Powell d92063cfba fix long table lines auto wrapping 2022-01-20 14:31:35 -08:00
Steven Powell 3b5be829c1 add VirtualBox benchmarks to time-to-k8s daily benchmark 2021-12-16 16:14:16 -08:00
Steven Powell 9746fee865 add table to time-to-k8s release page 2021-11-30 12:18:44 -08:00
Steven Powell 910d84a1a9 generate time-to-k8s weekly average charts 2021-11-29 17:29:50 -08:00
Steven Powell 1ddb0bd09c fix initing as int instead of float64 2021-11-29 14:34:00 -08:00
Steven Powell 8d7871aa30 store chart and json files in AWS 2021-11-29 14:20:42 -08:00
Steven Powell 2a99b2f946 fix out of bound exceptions 2021-11-16 11:40:02 -05:00
Wei Luo fb8711bf4a Don't add CPU time to total 2021-09-29 23:50:45 -07:00
Wei Luo 6e7a4b5863 remember to init plots 2021-09-29 10:22:36 -07:00
Wei Luo 87835362aa Add CPU time to time-to-k8s charts 2021-09-28 22:19:10 -07:00
Medya Gh ccf4af0997 change depricated golint to revive and fix lint issues 2021-08-12 18:11:16 -07:00
Medya Gh 6aa7abc24a fix lint issues on master 2021-08-12 17:38:24 -07:00
Medya Ghazizadeh 5d8d7819bf
Merge pull request #12016 from spowelljr/fixBenchmarkOrdering
Order time-to-k8s benchmarks from newest to oldest
2021-07-19 18:22:05 -07:00
Steven Powell 6e591890ed order benchmarks from newest to oldest 2021-07-19 15:22:17 -07:00
Steven Powell 791c257574 added benchmark for containerd runtime 2021-07-16 16:57:34 -07:00
Steven Powell d7cba4886a fix linting 2021-07-14 10:14:34 -07:00
Steven Powell 2f8ac8c512 change iteration count back to 10 after verifying GitHub Action was successful 2021-07-13 15:32:56 -07:00
Steven Powell 7b50ad492a generate public charts for time-to-k8s benchmark 2021-07-13 15:02:08 -07:00
Steven Powell 71e4495a76 add cleanup 2021-07-08 14:01:09 -07:00
Steven Powell bb1cffe96a remove commands handled by the GitHub Action 2021-07-08 13:42:22 -07:00
Steven Powell 853cc04fd2 update time-to-k8s repo 2021-07-08 10:29:19 -07:00
Steven Powell 3403648ddc update creating PR for time-to-k8s 2021-07-07 16:59:31 -07:00
Steven Powell 8b45846088 make minor changes to time-to-k8s benchmarking 2021-06-28 15:25:58 -07:00
Steven Powell 25c5bec652 change back iterations to 5 2021-06-15 10:30:08 -07:00
Steven Powell 599e7c49e9 create automated time-to-k8s benchmarks on release 2021-06-15 10:17:46 -07:00
Steven Powell 766cfd1e76 add copyright boilerplate 2021-05-26 16:26:45 -07:00
Steven Powell c30dbb0ead clean up var init 2021-05-26 15:59:50 -07:00
Steven Powell 2530048689 removed unused consts 2021-05-26 15:50:36 -07:00
Steven Powell a81761ea4a add make command to auto benchmark time-to-k8s and update website 2021-05-26 15:45:11 -07:00
Steven Powell 2be9109797 fixed CPU benchmarking typos and small formatting 2021-05-04 12:48:04 -07:00
Kenta Iso 43b1dfd433 Change barChart color and add benchmark description to docs of benchmark 2021-04-30 06:41:44 +09:00