Merge pull request #1069 from aaron-prindle/document-godep-windows-issue

Updated ADD_DEPENDENCY.md to include godep issue with vendor/golang.o…
2017-02-06 15:50:20 -08:00 · 2017-02-06 15:50:20 -08:00 · f178979f14
parent 663819295f db02f1fe28
commit f178979f14
1 changed files with 4 additions and 0 deletions
--- a/ADD_DEPENDENCY.md
+++ b/ADD_DEPENDENCY.md
@ -33,6 +33,10 @@ Here is a rough set of steps that usually works to add a new dependency.
  godep save ./...
  ```

+  NOTE:  godep seems to have an issue with not recovering files in `vendor/golang.org/x/sys/windows/`
+  IF you plan on committing your updated dependencies, make sure not to remove these files in your commit
+  
+
  If it is a large dependency, please commit the vendor/ directory changes separately.
  This makes review easier in Github.