From db02f1fe28cb6d25a32fd8cc6b1032e6b107f722 Mon Sep 17 00:00:00 2001 From: Aaron Prindle Date: Wed, 1 Feb 2017 13:25:13 -0800 Subject: [PATCH] Updated ADD_DEPENDENCY.md to include godep issue with vendor/golang.org/x/sys/windows/ dir --- ADD_DEPENDENCY.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ADD_DEPENDENCY.md b/ADD_DEPENDENCY.md index 6903c786a9..c333fa1d38 100644 --- a/ADD_DEPENDENCY.md +++ b/ADD_DEPENDENCY.md @@ -33,6 +33,10 @@ Here is a rough set of steps that usually works to add a new dependency. godep save ./... ``` + NOTE: godep seems to have an issue with not recovering files in `vendor/golang.org/x/sys/windows/` + IF you plan on committing your updated dependencies, make sure not to remove these files in your commit + + If it is a large dependency, please commit the vendor/ directory changes separately. This makes review easier in Github.