kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Better error message if binary does not exist

pull/9162/head
Priya Wadhwa 2020-09-02 13:43:04 -04:00
parent 78deeb5d1b
commit c91e47619b
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/minikube/perf/binary.go
View File

@ -22,6 +22,7 @@ import (
"io" "io"
"os" "os"
"path/filepath" "path/filepath"
"runtime"
"strconv" "strconv"
"strings" "strings"
@ -68,7 +69,14 @@ func (b *Binary) download() error {
return errors.Wrap(err, "getting storage client") return errors.Wrap(err, "getting storage client")
} }
defer client.Close() defer client.Close()
rc, err := client.Bucket(bucket).Object(fmt.Sprintf("%d/minikube-linux-amd64", b.pr)).NewReader(ctx)
// first make sure object exists
obj := client.Bucket(bucket).Object(fmt.Sprintf("%d/minikube-%s-amd64", b.pr, runtime.GOOS))
if _, err := obj.Attrs(ctx); err != nil {
return fmt.Errorf("minikube binary for pr %v does not exist in bucket", b.pr)
}
rc, err := obj.NewReader(ctx)
if err != nil { if err != nil {
return errors.Wrap(err, "getting minikube object from gcs bucket") return errors.Wrap(err, "getting minikube object from gcs bucket")
} }