From c91e47619bf6480b306bc4c2e4f626fe0092f59c Mon Sep 17 00:00:00 2001 From: Priya Wadhwa Date: Wed, 2 Sep 2020 13:43:04 -0400 Subject: [PATCH] Better error message if binary does not exist --- pkg/minikube/perf/binary.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/pkg/minikube/perf/binary.go b/pkg/minikube/perf/binary.go index 83644e9a32..f0b208b317 100644 --- a/pkg/minikube/perf/binary.go +++ b/pkg/minikube/perf/binary.go @@ -22,6 +22,7 @@ import ( "io" "os" "path/filepath" + "runtime" "strconv" "strings" @@ -68,7 +69,14 @@ func (b *Binary) download() error { return errors.Wrap(err, "getting storage client") } defer client.Close() - rc, err := client.Bucket(bucket).Object(fmt.Sprintf("%d/minikube-linux-amd64", b.pr)).NewReader(ctx) + + // first make sure object exists + obj := client.Bucket(bucket).Object(fmt.Sprintf("%d/minikube-%s-amd64", b.pr, runtime.GOOS)) + if _, err := obj.Attrs(ctx); err != nil { + return fmt.Errorf("minikube binary for pr %v does not exist in bucket", b.pr) + } + + rc, err := obj.NewReader(ctx) if err != nil { return errors.Wrap(err, "getting minikube object from gcs bucket") }