kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

add todo comment

pull/7793/head
Medya Gh 2020-04-19 21:13:46 -07:00
parent d2415d778e
commit bc36eb2de9
No known key found for this signature in database
GPG Key ID: 7CF7792C6DF3245C
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/minikube/cruntime/containerd.go
View File

@ -398,7 +398,8 @@ func ContainerdImagesPreloaded(runner command.Runner, images []string) bool {
found := false found := false
for _, ji := range jsonImages.Images { for _, ji := range jsonImages.Images {
for _, rt := range ji.RepoTags { for _, rt := range ji.RepoTags {
// for exmaple kubernetesui/dashboard:v2.0.0-rc6 will show up as docker.io/kubernetesui/dashboard:v2.0.0-rc6 // in crictl docker.io is appened to images without repo organization
// for example "kubernetesui/dashboard:v2.0.0-rc6 will show up as "docker.io/kubernetesui/dashboard:v2.0.0-rc6"
if !strings.Contains(i, ".io/") { if !strings.Contains(i, ".io/") {
i = "docker.io/" + i i = "docker.io/" + i
} }

1
test/integration/aaa_download_only_test.go
View File

@ -154,6 +154,7 @@ func TestDownloadOnlyKic(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), Minutes(15)) ctx, cancel := context.WithTimeout(context.Background(), Minutes(15))
defer Cleanup(t, profile, cancel) defer Cleanup(t, profile, cancel)
// TODO: #7795 add containerd to download only too
cRuntime := "docker" cRuntime := "docker"
args := []string{"start", "--download-only", "-p", profile, "--force", "--alsologtostderr"} args := []string{"start", "--download-only", "-p", profile, "--force", "--alsologtostderr"}