From bc36eb2de9634dbd3dfe252fb897b2cb5910a481 Mon Sep 17 00:00:00 2001 From: Medya Gh Date: Sun, 19 Apr 2020 21:13:46 -0700 Subject: [PATCH] add todo comment --- pkg/minikube/cruntime/containerd.go | 3 ++- test/integration/aaa_download_only_test.go | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/minikube/cruntime/containerd.go b/pkg/minikube/cruntime/containerd.go index 7ccb98ef08..c00a253736 100644 --- a/pkg/minikube/cruntime/containerd.go +++ b/pkg/minikube/cruntime/containerd.go @@ -398,7 +398,8 @@ func ContainerdImagesPreloaded(runner command.Runner, images []string) bool { found := false for _, ji := range jsonImages.Images { for _, rt := range ji.RepoTags { - // for exmaple kubernetesui/dashboard:v2.0.0-rc6 will show up as docker.io/kubernetesui/dashboard:v2.0.0-rc6 + // in crictl docker.io is appened to images without repo organization + // for example "kubernetesui/dashboard:v2.0.0-rc6 will show up as "docker.io/kubernetesui/dashboard:v2.0.0-rc6" if !strings.Contains(i, ".io/") { i = "docker.io/" + i } diff --git a/test/integration/aaa_download_only_test.go b/test/integration/aaa_download_only_test.go index 7d198b7634..9d5ec28443 100644 --- a/test/integration/aaa_download_only_test.go +++ b/test/integration/aaa_download_only_test.go @@ -154,6 +154,7 @@ func TestDownloadOnlyKic(t *testing.T) { ctx, cancel := context.WithTimeout(context.Background(), Minutes(15)) defer Cleanup(t, profile, cancel) + // TODO: #7795 add containerd to download only too cRuntime := "docker" args := []string{"start", "--download-only", "-p", profile, "--force", "--alsologtostderr"}