kubernetes
/
minikube
mirror of https://github.com/kubernetes/minikube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

adress review comments

pull/8718/head
Medya Gh 2020-07-15 14:34:01 -07:00
parent b0e58a3688
commit 13d37ff7aa
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/minikube/cmd/start.go
View File

@ -818,14 +818,16 @@ func validateMemorySize(req int, drvName string) {
} }
if driver.IsDockerDesktop(drvName) { if driver.IsDockerDesktop(drvName) {
// in Docker Desktop if you allocate 2 GB the docker info shows: Total Memory: 1.945GiB which becomes 1991 when we calculate the MBs
// thats why it is not same number as other drivers which is 2 GB
if containerLimit < 1991 { if containerLimit < 1991 {
out.T(out.Tip, `Increase Docker for Desktop memory to at least 2.5 GB or more: out.T(out.Tip, `Increase Docker for Desktop memory to at least 2.5GB or more:
Docker for Desktop > Settings > Resources > Memory Docker for Desktop > Settings > Resources > Memory
`) `)
} else if containerLimit < 2997 && sysLimit > 8000 { // for users with more than 8 GB advice 3 GB } else if containerLimit < 2997 && sysLimit > 8000 { // for users with more than 8 GB advice 3 GB
out.T(out.Tip, `Your system has {{.system_limit}}MB memory but Docker has only {{.container_limit}}MB. For a better performance increase to at least 3 GB. out.T(out.Tip, `Your system has {{.system_limit}}MB memory but Docker has only {{.container_limit}}MB. For a better performance increase to at least 3GB.
Docker for Desktop > Settings > Resources > Memory Docker for Desktop > Settings > Resources > Memory

5
pkg/minikube/driver/driver.go
View File

@ -173,7 +173,7 @@ func NeedsShutdown(name string) bool {
return false return false
} }
// FullName will return the human-known and formatted name for the driver // FullName will return the human-known and title formatted name for the driver based on platform
func FullName(name string) string { func FullName(name string) string {
switch name { switch name {
case oci.Docker: case oci.Docker:
@ -181,9 +181,6 @@ func FullName(name string) string {
return "Docker for Desktop" return "Docker for Desktop"
} }
return "Docker Service" return "Docker Service"
case oci.Podman:
return "Podman Service"
default: default:
return strings.Title(name) return strings.Title(name)
} }