diff --git a/cmd/minikube/cmd/start.go b/cmd/minikube/cmd/start.go index 1d74a396ed..97a6df47ee 100644 --- a/cmd/minikube/cmd/start.go +++ b/cmd/minikube/cmd/start.go @@ -818,14 +818,16 @@ func validateMemorySize(req int, drvName string) { } if driver.IsDockerDesktop(drvName) { + // in Docker Desktop if you allocate 2 GB the docker info shows: Total Memory: 1.945GiB which becomes 1991 when we calculate the MBs + // thats why it is not same number as other drivers which is 2 GB if containerLimit < 1991 { - out.T(out.Tip, `Increase Docker for Desktop memory to at least 2.5 GB or more: + out.T(out.Tip, `Increase Docker for Desktop memory to at least 2.5GB or more: Docker for Desktop > Settings > Resources > Memory `) } else if containerLimit < 2997 && sysLimit > 8000 { // for users with more than 8 GB advice 3 GB - out.T(out.Tip, `Your system has {{.system_limit}}MB memory but Docker has only {{.container_limit}}MB. For a better performance increase to at least 3 GB. + out.T(out.Tip, `Your system has {{.system_limit}}MB memory but Docker has only {{.container_limit}}MB. For a better performance increase to at least 3GB. Docker for Desktop > Settings > Resources > Memory diff --git a/pkg/minikube/driver/driver.go b/pkg/minikube/driver/driver.go index b31b607bfa..4db7cc427c 100644 --- a/pkg/minikube/driver/driver.go +++ b/pkg/minikube/driver/driver.go @@ -173,7 +173,7 @@ func NeedsShutdown(name string) bool { return false } -// FullName will return the human-known and formatted name for the driver +// FullName will return the human-known and title formatted name for the driver based on platform func FullName(name string) string { switch name { case oci.Docker: @@ -181,9 +181,6 @@ func FullName(name string) string { return "Docker for Desktop" } return "Docker Service" - - case oci.Podman: - return "Podman Service" default: return strings.Title(name) }