Commit Graph

43 Commits (89bc396b55f19cd4cf20cb41802c9def2511642a)

Author SHA1 Message Date
Anton Gilgur fab2809c67
fix(argo-workflows): revert `BASE_HREF` change (#2770)
* fix(argo-workflows): revert `BASE_HREF` change

This reverts commit 134cecde58.

Sorry, I screwed up this and caused a regression. Didn't read my own release notes (from 4 months ago to be fair) where `ARGO_BASE_HREF` would not work previously as it was inconsistently `ARGO_BASEHREF`. So there is no forward compatible change to be made here, so just revert this.

Will have to reinstate this change for the 3.6 upgrade

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

* changelog update

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

---------

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
2024-06-18 03:59:29 +09:00
Anton Gilgur 8b02b6d9b8
fix(argo-workflows): `BASE_HREF` -> `ARGO_BASE_HREF` for forward compat (#2756) 2024-06-10 07:18:20 +09:00
yuki.kitakata f9eb0b394c
fix(argo-workflows): Add missing serviceLabels to server service (#2698) 2024-05-19 19:22:17 +09:00
Aikawa 1af4bf5f48
feat(argo-workflows): Add ability to set .Values.namespaceOverride (#2564) 2024-03-03 13:12:41 -06:00
Ilia Lazebnik 9ca3f06dcf
feat(argo-workflows): add hostAliases to server (#2387)
* workflow server hostalises

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* Update Chart.yaml

Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com>

* workflow server hostalises

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

---------

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
2023-12-14 07:56:27 +00:00
qa-florian-wende 7261decaf8
feat(argo-workflows): Make workflow controller ConfigMap optional (#2354) 2023-11-27 17:44:58 +00:00
Matt Dainty 737b9724de
fix(argo-workflows): Add parameters for tuning revisionHistoryLimit and emptyDir volumes (#2346) 2023-11-15 07:17:09 -06:00
Aikawa 9840ebedc6
fix(argo-workflows): Accept multi auth mode for server (#2336)
* fix(argo-workflows): Accept multi auth mode for server

Signed-off-by: yu-croco <yu.croco@gmail.com>

* chore(argo-workflows): improve description of authMode

Signed-off-by: yu-croco <yu.croco@gmail.com>

* chore(argo-workflows): keep the older value valid for now as compatibility.

Signed-off-by: yu-croco <yu.croco@gmail.com>

---------

Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-11-09 01:04:58 +09:00
Aikawa 2730dc24c7
feat(argo-workflows): Configure declarative server auth mode (#2291) 2023-10-12 09:14:41 -05:00
Anton Gilgur a64615414d
fix(argo-workflows): Server only needs `get` Secrets (#2211)
- as of aa366db345, the Server no longer needs `list` or `watch` and only uses `get`
  - this was released as part of [v3.4.0](https://github.com/argoproj/argo-workflows/blob/master/CHANGELOG.md#v340-rc1-2022-08-09), and the current version of the chart uses v3.4.9 (per `Chart.yaml#appVersion`)

- `update` is not needed either for SSO secret
  - manifests RBAC: a68ea0feab/manifests/cluster-install/argo-server-rbac/argo-server-clusterole.yaml (L18)
  - SSO source code only uses [`create`](20d0923611/server/auth/sso/sso.go (L140)) and [`get`](20d0923611/server/auth/sso/sso.go (L151))
    - (also some `get`s above that for [`clientID`](20d0923611/server/auth/sso/sso.go (L127)) and [`clientSecret`](20d0923611/server/auth/sso/sso.go (L106)) as well)

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-08-11 10:14:54 +09:00
frauniki 490ffa574c
fix(argo-workflows): Change argo-workflows-server crb creation conditions (#2124)
Change server's crb creation conditions

Signed-off-by: frauniki <frauniki@sinoa.jp>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-06-23 11:35:01 -05:00
Aikawa 5fb6688bcb
chore(argo-workflows): Declare SSO configuration explicitly on values.yaml (#2089)
Signed-off-by: yu-croco <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-06-03 09:40:50 -05:00
Julien Michaud 5766533626
feat(argo-workflows): support google ManagedCertificate, FrontendConfig & BackendConfig for gce ingress (#2066)
* feat: add gke stuff

Signed-off-by: julien.michaud <julien.michaud@mirakl.com>

* update readme and chart.yaml file

Signed-off-by: julien.michaud <julien.michaud@mirakl.com>

* fix readme

Signed-off-by: julien.michaud <julien.michaud@mirakl.com>

* docs: Apply changes from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

---------

Signed-off-by: julien.michaud <julien.michaud@mirakl.com>
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2023-05-19 11:35:33 +01:00
PidgeyBE f6d44750b8
fix(argo-workflows): Fix templating in several places (#2026)
* Add artifacthub changes

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

* fix templating list of yamls

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

* Bump version and fix templating for gcs and azure as well

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>

---------

Signed-off-by: Peejai <pieterjan.soetaert@robovision.eu>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2023-05-11 09:09:33 +09:00
ryanpark0203 c8b47cf060
fix(argo-workflows): Fix Helm chart to correctly reference Kubernetes version in conditional check for HPA apiVersion (#2029)
* add a fix for argo workflows hpa

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* add description for the fix

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* update readme

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* remove apiVersionOverrides from readme

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* fix linting

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

---------

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
2023-05-09 12:41:54 +09:00
Anton Gilgur aef554340f
feat(argo-workflows): add optional HPA to Server (#1974) 2023-04-24 00:47:18 -05:00
Aikawa 7eeb70f711
fix(argo-workflows): Add namespace field to all namespace scoped resources (#1956)
Reason: `helm template` doesn't add the namespace field automatically

* fix(argo-workflows): Add namespace field to all namespace scoped resources because `helm template` doesn't add the namespace filed automatically
Signed-off-by: yu-croco <yu.croco@gmail.com>

* chore(argo-workflows): bump minor version
Signed-off-by: yu-croco <yu.croco@gmail.com>

* refactor(argo-workflows): reflect review points
Signed-off-by: yu-croco <yu.croco@gmail.com>
2023-04-13 11:25:06 +02:00
Justin Sievenpiper 56136f6518
feat(argo-workflows): add the ability to declare initContainers (#1923)
feat(argo-workflows): add the ability to declare initContainers to server and controller deployments

Signed-off-by: Justin Sievenpiper <justin@sievenpiper.co>
2023-04-07 08:43:01 +09:00
Jonathan Muller f66c40319a
chore(argo-workflows): expose option to control the log format/level (#1855)
* Allow to change the log format to json

Signed-off-by: Jonathan Muller <koren@pukogames.com>

* Documentation, version

Signed-off-by: Jonathan Muller <koren@pukogames.com>

---------

Signed-off-by: Jonathan Muller <koren@pukogames.com>
2023-02-24 15:56:41 -06:00
Vlad Losev c08fc230d7
fix(argo-workflows): clean subresource permissions (#1835) 2023-02-09 23:31:49 -06:00
Jason Meridth 7992b5d04b
feat(argo-workflows): Add helper function to determine image value, minus tag (#1754)
We have a situation where we want to exclude the registry so that images can
be pulled from in-network mirrors. Currently when you exclude the registry,
you get stuck with a prefixing forward slash.

Had to keep the tags in the manifest files because helm template requires
a colon in the image value.  Otherwise I'd move it into the helper function.

image entries changed: server, controller, executor

Signed-off-by: jmeridth <jmeridth@gmail.com>

Signed-off-by: jmeridth <jmeridth@gmail.com>
2023-01-09 18:03:26 -06:00
Aikawa 10e3af1bcf
chore(argo-workflows): Remove legacy API versions for PDBs (#1741)
Signed-off-by: yu-croco <yu.croco@gmail.com>

Co-authored-by: Petr Drastil <petr.drastil@gmail.com>
2022-12-29 17:31:39 +01:00
Pedro 5b15810e2d
fix(argo-workflows): avoid label exceeding maximum length (#1692)
fix(argo-workflows): generated value for app.kubernetes.io/version label for argo-workflows will not exceed maximum length and support image tags with a SHA digest.

Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>

Signed-off-by: Pedro Salgado <steenzout@users.noreply.github.com>
2022-12-09 15:50:05 +09:00
Eugene Lugovtsov 062417e30d
feat(argo-workflows): Add labels for ServiceAccounts (#1665)
* Add labels for ServiceAccounts

Signed-off-by: Eugene Lugovtsov <lug.zhenia@gmail.com>

* fix workflow serviceaccount labels

Signed-off-by: Eugene Lugovtsov <lug.zhenia@gmail.com>

* fix docs

Signed-off-by: Eugene Lugovtsov <lug.zhenia@gmail.com>

Signed-off-by: Eugene Lugovtsov <lug.zhenia@gmail.com>
2022-11-25 09:35:40 +09:00
Nick Fisher 55b8b34d20
fix(argo-workflows): serviceaccount rbac when sso is enabled (#1586)
Signed-off-by: Nick Fisher <nxf5025@gmail.com>

Signed-off-by: Nick Fisher <nxf5025@gmail.com>
2022-10-27 10:04:37 +09:00
Kiyoshi Muranaka 2626b31b69
feat(argo-workflows): Add support for topologySpreadConstraints (#1496)
Signed-off-by: Kiyoshi Muranaka <hxhgkkrgi@gmail.com>

Signed-off-by: Kiyoshi Muranaka <hxhgkkrgi@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
2022-10-22 16:37:31 +09:00
Aikawa 334d8ae728
feat(argo-workflows): Add global tag (#1377)
* feat(argo-workflows): Moved `.Values.images` values to global
Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* Revert "feat(argo-workflows): Moved `.Values.images` values to global"
This reverts commit 67b4294675.
Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* feat(argo-workflows): Add global tag
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
2022-07-27 09:50:42 +09:00
Tadayuki Onishi e01c613046
feat(argo-workflows): Assign common labels to some resources (#1369)
* feat(argo-workflows): Assign common labels to controller resources

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>

* feat(argo-workflows): Assign common labels to the server sa resource

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>

* Update argo-workflows Chart.yaml

Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>
2022-07-13 09:10:34 +09:00
Aikawa 0e090ef854
fix(argo-workflows): adjust api version of pod disruption budget by referring to k8s version (#1288)
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
2022-05-22 09:43:12 +02:00
Aikawa 72d29611b7
fix(argo-workflows): Add missing verbs on argo-workflows-server (#1278)
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
2022-05-20 21:19:07 +02:00
Sean Nguyen 0cf7cad2c2
feat(argo-workflows): add support for Deployment annotations (#1198)
* feat(argo-workflows): add support for Deployment annotations

  bump version and add changelog

  update documentation

Signed-off-by: snooyen <sean@bright.ai>

* Apply suggestions from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2022-05-09 22:45:28 +02:00
John Clark 645f70ff98
fix(argo-workflows): Quick fix for failing deployment when using image digests (#1206)
* Added short tag function and updated templates

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Chart.yaml update (version, changes)

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Removed unnecessary conditional logic

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Final newline to _helpers

Signed-off-by: John Clark <clark.john.d@outlook.com>

* Rework without template function

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2022-05-09 22:24:14 +02:00
Frank Bagherzadeh 86faeec867
fix(argo-workflows): Add missing list verb to secret (#1186)
* Add list

Signed-off-by: Frank Bagherzadeh <frankbzd@gmail.com>

* bump version and add change log

Signed-off-by: Frank Bagherzadeh <frankbzd@gmail.com>

* fix changelog

Signed-off-by: Frank Bagherzadeh <frankbzd@gmail.com>
2022-03-23 13:18:22 +00:00
Raiden Worley a647fbe123
feat(argo-workflows): Add parameter to enable or disable server and controller roles (#1166)
* optional role

Signed-off-by: Carl Raiden Worley <carl.worley@10gen.com>

* match existing setting

Signed-off-by: Carl Raiden Worley <carl.worley@10gen.com>

* fix lint

Signed-off-by: Carl Raiden Worley <carl.worley@10gen.com>
2022-03-12 18:13:42 +01:00
Peter O 735f212f96
feat(argo-workflows): Allow NodePort to be specified for server service (#938)
* Allow NodePort to be specified for server service.

Signed-off-by: Peter Oruba <peter@oruba.de>

* Different version number and different condition in NodePort setting evaluation, both as per PR review suggested.

Signed-off-by: Peter Oruba <peter@oruba.de>
2021-09-27 09:14:34 +02:00
Mike Bryant 07c1cf092c
feat(argo-workflows): Add support for extra containers in server & controller deployment (#841)
* feat: Add support for extra containers in server & controller deployment

Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>

* Update charts/argo-workflows/templates/server/server-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
2021-08-11 09:32:11 +02:00
Thom 8125f928ea
feat(argo-workflow): Add pathType value to ingress (#854)
Signed-off-by: thomascjohnson <thomascjohnson@gmail.com>
2021-08-10 15:45:09 +02:00
Sevan eecc88fbd7
fix(argo-workflows): use template for ingress .Capabilities (#795)
* fix(argo-workflows): use argo-workflows.ingress.apiVersion for ingress (#794)

Signed-off-by: Sevan Murriguian-Watrin <smurriguian@smartadserver.com>

* feat(argo-workflows): Add option to override kubeVersion

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-06-08 15:14:55 +02:00
Marco Kilchhofer f2e530ea7e
fix(argo-workflows): Fix indentation when using extraEnv (#773)
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
2021-05-31 18:31:44 +02:00
Tadayuki Onishi 44c15c834e
fix(argo-workflows): fix server.podAnnotations template (#758)
Signed-off-by: kenchan0130 <tt.tanishi100@gmail.com>
2021-05-26 12:00:10 +02:00
g-linville 7a06415d83
feat(argo-workflows): add value to avoid creating RBAC related to ClusterWorkflowTemplates (#657)
* Argo Workflows: avoid creating ClusterRoles and CRBs if singleNamespace is true

Signed-off-by: g-linville <53102776+g-linville@users.noreply.github.com>

* Argo Workflows: bumped chart version

Signed-off-by: g-linville <53102776+g-linville@users.noreply.github.com>

* Argo: remove clusterworkflowtemplates from WorkflowController role

Signed-off-by: g-linville <53102776+g-linville@users.noreply.github.com>

* feat(argo-workflows): add value to disable creation of RBAC relating to ClusterWorkflowTemplates

Signed-off-by: g-linville <53102776+g-linville@users.noreply.github.com>

* Bumped chart version

Signed-off-by: g-linville <53102776+g-linville@users.noreply.github.com>
2021-05-25 08:06:31 +02:00
Abhinav Khanna 4cb8e058ac
fix(argo-workflows): fixes server sa annotations and ingress (#747)
* fix(argo-workflows): fixed server sa annotations

Signed-off-by: abhinav.khanna <abhinav.khanna@salesforce.com>

* fix(argo-workflows): fixed ingress

Signed-off-by: abhinav.khanna <abhinav.khanna@salesforce.com>

* chore(argo-workflows): version bump

Signed-off-by: abhinav.khanna <abhinav.khanna@salesforce.com>

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
2021-05-21 18:50:05 +02:00
chgl 82b655dadc
feat(argo-workflows): added new argo-workflows chart and deprecated argo chart (#668)
* feat: added new argo-workflows chart and deprecated argo chart

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: removed maintainers from deprecated argo chart

Signed-off-by: chgl <chgl@users.noreply.github.com>

* docs: rm pullPolicy from snippet since the global images.pullPolicy is actually used

Signed-off-by: chgl <chgl@users.noreply.github.com>

* use Chart.AppVersion as the default image tag

Signed-off-by: chgl <chgl@users.noreply.github.com>

* updated various links

Signed-off-by: chgl <chgl@users.noreply.github.com>

* enabled metrics endpoint and liveness probe by default

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: use new-style labels

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: set securitycontext for server to something more secure

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/_helpers.tpl

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* bumped argo chart version

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/controller/workflow-controller-service.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: chgl <chgl@users.noreply.github.com>

* used ingress from argo-cd

Signed-off-by: chgl <chgl@users.noreply.github.com>

* Update charts/argo-workflows/templates/server/server-deployment.yaml

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <mayfield.brandon.a@gmail.com>

* updated argo-wf to v3.0.2

Signed-off-by: chgl <chgl@users.noreply.github.com>

* aligned serviceAccount configuration with argo-cd values

Signed-off-by: chgl <chgl@users.noreply.github.com>

* docs: updated breaking changes in README

Signed-off-by: chgl <chgl@users.noreply.github.com>

* fix: use .Capabilities.APIVersions.Has in Ingress template

Signed-off-by: chgl <chgl@users.noreply.github.com>

Co-authored-by: Brandon Mayfield <563214+bmayfi3ld@users.noreply.github.com>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Co-authored-by: Brandon Mayfield <mayfield.brandon.a@gmail.com>
2021-05-21 14:19:05 +02:00