fix(argo-workflows): `BASE_HREF` -> `ARGO_BASE_HREF` for forward compat

- `BASE_HREF` is redundant and will be removed in a future release, so move to `ARGO_BASE_HREF` for forward compat

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>

charts/argo-workflows/Chart.yaml

@@ -3,7 +3,7 @@ appVersion: v3.5.7
 name: argo-workflows
 description: A Helm chart for Argo Workflows
 type: application
-version: 0.41.7
+version: 0.41.8
 icon: https://argo-workflows.readthedocs.io/en/stable/assets/logo.png
 home: https://github.com/argoproj/argo-helm
 sources:
@@ -16,5 +16,5 @@ annotations:
     fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
     url: https://argoproj.github.io/argo-helm/pgp_keys.asc
   artifacthub.io/changes: |
-    - kind: changed
-      description: Bump argo-workflows to v3.5.7
+    - kind: fixed
+      description: changed BASE_HREF to ARGO_BASE_HREF for forward compat

charts/argo-workflows/templates/server/server-deployment.yaml

@@ -95,7 +95,7 @@ spec:
                 fieldRef:
                   apiVersion: v1
                   fieldPath: metadata.namespace
-            - name: BASE_HREF
+            - name: ARGO_BASE_HREF
               value: {{ .Values.server.baseHref | quote }}
           {{- with .Values.server.extraEnv }}
             {{- toYaml . | nindent 12 }}