Fixes an issue where the configuration of a script action of a
file-based rule (e.g. those created using JSRule or Rule Builder of
openhab-js) was shown as editable, even though the rule is not editable
because it is provisioned from file.
Always show the tag input, even if there are no rule tags. This is more
consistent and avoids confusion, as you can now clearly see that a rule
has no tags.
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
If all model tabs are hidden, the tab bar has only one entry and
therefore there is no need to display it.
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Follow-up for #2088.
Depends on https://github.com/openhab/openhab-docs/pull/2199.
Also add the help sidebar button to the settings and list pages where it
is missing.
---------
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
After an error in the SSE connection, the event source is now
reconnected to the right sitemap page.
Fix one of both problems explained in #1757
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
This cleanup includes:
* Fix deprecations
* Fix JavaDocs
* Remove redundant toString calls
* Remove redundant semicolons
* Simplify boolean expressions
* Use diamond operator
* Use enhanced for loops
* Use instanceof pattern matching
* Use isEmpty instead of 0 comparisons
* Use lambdas
* Use static inner classes
* Use StandardCharsets
Also adds the SA_LOCAL_SELF_COMPARISON suppression similar as used in
other repositories for https://github.com/spotbugs/spotbugs/issues/1992.
Signed-off-by: Wouter Born <github@maindrain.net>
Remove the defaultColor option.
Instead use RGB(0,0,0) black as default color if the Item state holds no
valid color, so that the color picker is accessible.
---------
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Only concerns SVG icons delivered by the openHAB icon servlet and having
"currentColor" as fill color.
Convertion to inline SVG is applied only if the "inline SVG" setting is
enabled.
Fix#2249
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Persistence policies can be configured from the UI. However, it is
difficult to find, and one needs to know where to look. Apart from a
documentation issue, I think persistence is core enough to merrit its
own entry in the settings, so it becomes more prominent.
See for example here:
https://community.openhab.org/t/after-reboot-string-values-are-empty/152064/16
This adds a persistence entry below transformations to the settings menu.
The new persistence config page allows to set the default persistence,
and links to defining the policies for each installed persistence add-on.
There also is a "add" list entry to install more persistence add-ons.
If none is installed, it will explain persistence and link to the docs and the add-on store.
The default persistence settings has been removed from the system
settings, and the link to the persistence policy config from the add-on
settings page has been converted to a button.
---------
Also-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
As described in
https://community.openhab.org/t/openhab-4-1-milestone-discussion/149502/222,
none.png is not found for BasicUI.
This PR replaces it with non.svg, see discussion on forum.
@lolodomo @florian-h05 I was behind my screen when I saw the issue. I
didn't test, but did the replacement based on info provided on the
forum.
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Suggestions are being shown in the add-on store for add-ons that are already installed.
This PR removes suggestions for installed add-ons.
See request here https://github.com/openhab/openhab-core/issues/3868#issuecomment-1859950504.
---------
Also-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Fixes#2196.
Replaces #2211.
The double back navigation was caused by:
31f4c7065e/src/core/utils/history.js (L56-L61)
and `router.updateCurrentUrl()`, unlike the name implies, doesn't update
`router.url` for some reason (maybe a bug?).
-----
Signed-off-by: Yannick Schaus <github@schaus.net>
This updates the tern defs used for autocompletion to the current
library version included in the addon (4.7.0).
Reference https://github.com/openhab/openhab-js/compare/v4.0.0...v4.7.0.
Last update of those was in #1710.
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
When installing rule templates or UI components or blockly libraries
from the marketplace, they get an entry in the add-on settings menu.
There is nothing that can be configured in these types of add-ons.
Therefore limit the list to bundles and features.
---------
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
- Update component docs (follow-up for #2214).
- Avoid sending "Invalid date" to server and do not accept "Invalid
date" as a valid state.
- Fix some errors thrown while configuring component or providing
invalid input.
---------
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Support grids containing from 1 to 12 columns.
Only the first 8 columns are rendered on tablet.
Only the first 4 columns are rendered on phone.
Related to openhab/openhab-core#3441
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Closes#2206
This will replace the auto-opening developer dock with a button on the
empty overview page to open the in-app quick start tutorial. Button will
only appear on pages wide enough to support the developer dock.
---------
Also-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Florian Hotze
lolodomo
openhab-bot
Yannick Schaus
Wouter Born
dependabot[bot]
jimtng
Mark Herwege
Kai Kreuzer
openhab-bot
GiviMAD
JustinGeorgi