[BasicUI] Replace non printable characters (#2284)

Fix #2250

Non printable characters are replaced by the unicode replacement
character.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

bundles/org.openhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/AbstractWidgetRenderer.java

@@ -438,7 +438,9 @@ public abstract class AbstractWidgetRenderer implements WidgetRenderer {
     }
 
     protected String escapeHtml(@Nullable String s) {
-        return StringEscapeUtils.escapeHtml4(s);
+        String result = StringEscapeUtils.escapeHtml4(s);
+        // Also replace non printable characters by the unicode replacement character
+        return result != null ? result.replaceAll("[\\p{C}]", "\uFFFD") : "";
     }
 
     @Override

bundles/org.openhab.ui.basic/web-src/smarthome.js

@@ -2314,10 +2314,13 @@
 		_t.escapeHtml = function(text) {
 			var
 				escapedText = text,
+				nonPrintable = new RegExp(/\p{C}/, "gu"),
 				escapeTable = [
-					[ /&/g, "&" ],
-					[ /</g, "&lt;"  ],
-					[ />/g, "&gt;"  ]
+					[ /&/g,         "&amp;"  ],
+					[ /</g,         "&lt;"   ],
+					[ />/g,         "&gt;"   ],
+					[ /"/g,         "&quot;" ],
+					[ nonPrintable, "\uFFFD" ]
 				];
 
 			for (var i = 0; i < escapeTable.length; i++) {