Cancelling an already canceled task has no effect. IMHO this check is not necesssary and removal would simplify the code. I came to this because I saw this pattern in many bindings during reviewing.
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Need to escape \< and \> in the sign off message format so users see them explicitly in the Contributing to the Documentation section.
Signed-off-by: Mark Theiding <mark.theiding@gmail.com>
Added additional structure around install, run, debug and update steps. Provided more pointers to interactions with Eclipse, Maven and Git.
Signed-off-by: Mark Theiding <mark.theiding@gmail.com>
Hopefully this will lower the hurdle for people to submit documentation contributions. I know from myself that I didn't submit various documentation improvements, because I didn't know git and thought it would be a much more involved process.
Ideally there would be a separate documentation section, but submitting this under the development contribution page for now (as per discussion with @Confectrician in https://github.com/openhab/openhab-docs/pull/1179#issuecomment-605642091).
Note that I am addressing the issue of DCO failures wrt specifying the full name that I ran into myself in https://github.com/openhab/openhab-docs/pull/1197#issuecomment-615597308. I found a good discussion of the issue at https://github.com/probot/dco/issues/43.
Signed-off-by: Mark Theiding <mark.theiding@gmail.com>
* Correct usage of its/it's
"It's" is always a contraction of "it is" or "it has". "Its" is a
possessive. Correct a few places where they were used backwards.
Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com>
* Correct "Z-Wave" spelling
Per https://www.z-wave.com/, the canonical spelling appears to be "Z-Wave".
Most places use "Z-Wave" already; change the remaining references to match.
Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com>
* Correct typos and grammatical errors
Correct some typos and grammatical errors.
Signed-off-by: Bjorn Helgaas <bjorn@helgaas.com>
* Fix start.sh debug command
Signed-off-by: Tim Roberts <troberts@bigfoot.com>
* Added to VSCode settings
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
* Added settings.json and references to it
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
* Fix typos
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
* Added section about "Internationalization of Discovery Services"
- Added section about "Internationalization of Discovery Services"
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Added section about "Discovery Results"
- Added section about "Discovery Results"
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Update developers/utils/i18n.md
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Update developers/utils/i18n.md
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
- Added information about `ItemStatePredictedEvent` and `GroupItemStateChangedEvent`
- Applied some linter
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Because the eclipse launch pom.xml has changed compilation of the bom file is not required anymore to make it work. So this step can be removed from the documentation.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Removed structure from binding page as it's duplicated on the guidelines page.
Updated and improved the description on the guidelines page with the information that was on the bindings page (that information was improved recently).
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Hilbrand Bouwkamp
Andrew Fiddian-Green
Fabian Wolter
Wouter Born
Christoph Weitkamp
Stefan Zabka
Mark Theiding
Bjorn Helgaas
Skinah
cpmeister
Chris Carman
Bob A
tmrobert8
pravussum
Mr_Ronfo
Jerome Luckenbach
Miika Jukka
Daniel Weisser
Arne Seime
tk-innoq
Axel Köhler
Stewart Cossey