The kapacitor client used in the kapacitor endpoints is limited to
fetching whatever limit you provide it. If you provide no limit, it
defaults to a limit of 100. We use this default behavior currently.
Some users have more than 100 tasks, so we need a client that's capable
of continually fetching tasks from Kapacitor until there are none left,
and returning the full response to the frontend.
This introduces a PaginatingKapacitorClient which does exactly that.
Also, test coverage was added around the KapacitorRulesGet endpoint,
since it was previously untested.
Because we are now creating new instances of dashboards when we create a
response, it's critical to copy every element of Dashboards from the
previous to the new instance.
We were not previously copying the Type field of cells, so this was
defaulting to the empty string zero value. This patch adds "Type" to the
tests and ensures that it's properly copied
- [ ] CHANGELOG.md updated with a link to the PR (not the Issue)
- [X] Rebased/mergable
- [X] Tests pass
- [X] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)
Connect #
* When clicking on the upload file button in the write data form, nothing
happens. This is because the div with the outline that says "Drag & Drop a File
to Upload" is positioned in front of the button with opacity 0, so clicks
intended for the button are just clicking on that transparent div instead.
* If you drag a file over the window then cancel the drag (usually by pressing
ESC), the window will not return to its previous state, but stay with the drag
& drop prompt until the page is reloaded.
* Make it so the drag & drop prompt is always present and the button is moved
to be below the outlined prompt. The button label has also been changed to
more closely match that of the drag outline.
Before:
![before screenshot](https://www.dropbox.com/s/t3j76wagracjw99/chronograf-drag-before.png?dl=0)
After:
![after screenshot](https://www.dropbox.com/s/6e68rgba8fq59jw/chronograf-drag-after.png?dl=0)
* Add an `onDragExit` handler to handle the case where the drag is exited
rather than left.
Signed-off-by: Nathan L Smith <smith@nlsmith.com>