Update CONTRIBUTING.md
Added Security Vulnerability Reporting
Updated the text to include the simple changes. This branch still needs updating to reflect 2.0 API etc.
~
fix(contribution): updated the text for V2.
fixes#13370
Update the 'Getting the source' section'
Remove the 'Cloning a fork' seciton
* If they have forked the repo, it should be clear how to clone the fork.
refactor
last refactor
Use # for section headings
Minor grammar edit.
Update CONTRIBUTING.md
Fix tripple backticks
Backticks weren't being picked up by Github's md renderer properly.
Fixed formatting
Made tabs and spaces consistent (went for tabs, since that's what go uses). Made cli commands consistent by including $ at the start of the line. Fixed copy a little bit.
Softened the language
Fixes: https://github.com/influxdata/influxdb/pull/13370#discussion_r359393716
Softened the language a bit.
Update CONTRIBUTING.md
Co-Authored-By: Stuart Carnie <stuart.carnie@gmail.com>
chore: improve CONTRIBUTING.md
* ci: run go race tests in parallel over 8 containers
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: add timing hint for splitting go tests
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: remove spurious grep
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: mod=readonly should ignore unknown internal/promqltests path
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: echo the packages tested
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: remove readonly experiment
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: filter promql internal tests
The promql internal tests has a special go.mod that shows
up in go list. That directory cannot be tested.
Signed-off-by: Chris Goller <goller@gmail.com>
this work is to support pkger, but was able to add back in the
skipped tests. seeing failures upstream, and didn't catch it in
influxdb b/c the tests were being skipped.
closes: #14799
* build: split go linting from tests
Signed-off-by: Chris Goller <goller@gmail.com>
* build: split js linting from tests
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: run go tests without verbose option
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: parallelize eslint with 8 containers
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: cache node modules for eslint
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: lint circle yaml
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: cd into ui directory for node caching
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: note eslint parallelization
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: update yarn cache directory to global
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: cache jstest yarn downloads
Signed-off-by: Chris Goller <goller@gmail.com>
* ci: note parallelization of jest tests
Signed-off-by: Chris Goller <goller@gmail.com>
In the event that findTaskByIDWithAuth cannot find the task ID contained
in the bucket, the outer loop will never terminate.
This ensures that we are calling Next() along-side any calls to continue
while using a Cursor.
the original design made the secrets unable to be reused, a bit to opinionated
to be useful eleswhere. This relaxes that requirement so that secrets can be
referenced here.
this is a blocker for anyone who hits the endpoint services internally. They
had to know that they need to also know of hte secret service then do all that
put/delete alongside the operation. This makes that unified inside the store tx.
one other thing this does is make obvious the dependencies that
notification services has. In this case it is the secrets service it
depends on.
Task runs are stored and retrieved from the `taskRunsv1` bucket, but
when they are canceled they are incorrectly placed in the `tasksv1`
bucket. Once this has been done, further look ups of the task run fail,
because it is located in the wrong bucket.
This addresses the problem by placing them back into the `taskRunsv1`
bucket. An additional test has been added to ensure we are able to
successfully read a canceled run.
timhallinflux
Johnny Steenbergen
Alex Boatwright
Zoe Steinkamp
George
Jade McGough
Chris Goller
Jonathan A. Sternberg
Bucky Schwarz
Ariel Salem
Brett Buddin
Timmy Luong
Greg
Deary Hudson III