Commit Graph

140 Commits (c7a7dde51f5791cc797343f11a361b0926882985)

Author SHA1 Message Date
Carol (Nichols || Goulding) c7a7dde51f fix: Remove redundant clones in tests
As suggested by the redundant_clone clippy lint.

This is a little weird because different constructions of `points`
now need clones in different places, but rustc will tell us when
we need to clone and clippy will tell us when we don't.
2020-02-19 08:37:39 -05:00
Carol (Nichols || Goulding) 196b364a00 fix: Assert on an expected error rather than failing if we get Ok
The clippy lints assertions_on_constants and single_match were pointing
at this spot, so it's as good a time as any to take care of the TODO!
2020-02-19 08:37:39 -05:00
Carol (Nichols || Goulding) cdca82fee5 fix: Remove an unnecessary conversion
As found by the identity_conversion clippy lint. Clippy was warning
about this on master, but warnings didn't fail the build until a commit
I'm adding in this PR.
2020-02-19 08:37:39 -05:00
Carol (Nichols || Goulding) 41ddab1a54 fix: Change an arbitrary test input so that clippy doesn't think it looks like pi
I don't think we actually want to use a precise value for pi, but if we
put 3.14, the approx_constant clippy lint will suggest it.
2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) eabf96a0d7 fix: Test that floats are approximately equal within machine epsilon
As found by the float_cmp clippy lint.

There are crates that provide macros for this, but it's small enough
that I think a test helper function in-tree is fine.
2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) c6eda3a8b5 fix: Allow excessive precision for now
The way these tests are written, any truncation will be made on both the
values used in the test and the values expected in the test, so this is
probably fine.

But we might not be testing with the exact values we think we're testing
with, so we should audit the values clippy warns about at some point.
2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) 7cc871b305 style: Parenthesize potentially confusing expression
As suggested by the clippy precedence lint
2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) dd7d6e838f style: Allow unreadable literals in tests 2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) f81c8764d0 improvement: Fail the build on warnings too 2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) e03b3e9326 fix: Run Clippy on test targets too by using --all-targets instead
It's confusing that `cargo fmt` takes `--all` to format everything but
`cargo clippy` takes `--all-targets` :-/
2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) 96ae7f53f4
Merge pull request #39 from influxdata/grpc
feature: gRPC
2020-02-19 08:35:36 -05:00
Carol (Nichols || Goulding) cc0d830fec test: Exercise gRPC in the end-to-end test 2020-02-17 16:37:43 -05:00
Carol (Nichols || Goulding) 5384d0d3b8 refactor: Switch org_id to primarily be u32 in tests
This will make it easier to have one source of truth for the org id
used in the gRPC and regular requests.
2020-02-17 16:37:43 -05:00
Carol (Nichols || Goulding) fdcef79ae3 improvement: Make end-to-end test async
This doesn't matter very much right now, since we're waiting for each
call to be done before asserting, but tonic client methods are async.
2020-02-17 16:37:43 -05:00
Jake Goulding 3effd368d3 feature: Start gRPC server on a different port from the hyper server 2020-02-17 16:37:43 -05:00
Jake Goulding 3438edd18b feature: Switch from prost to tonic 2020-02-17 16:37:43 -05:00
Carol (Nichols || Goulding) c008cafdcc
Merge pull request #37 from influxdata/update-deps
Update deps
2020-02-17 13:52:39 -05:00
Carol (Nichols || Goulding) 9dc3699466 style: cargo fmt 2020-02-17 10:53:57 -05:00
Jake Goulding 9c7e3b2663 build: `rand` is only a test dependency 2020-02-17 10:48:33 -05:00
Jake Goulding 68970f8ff3 build: Update bytes to latest version 2020-02-17 10:48:33 -05:00
Jake Goulding 155bfcbd4f build: Update prost to latest version 2020-02-17 10:48:33 -05:00
Jake Goulding eb3113b820 build: Update dotenv to latest version 2020-02-17 10:48:32 -05:00
Jake Goulding 31df104996 build: Update env_logger to latest version 2020-02-17 10:48:32 -05:00
Jake Goulding e3bfa0f835 build: Update byteorder to latest version 2020-02-17 10:48:32 -05:00
Jake Goulding 04a7f716e2 build: Update dependencies to latest semver-compatible versions 2020-02-17 10:48:32 -05:00
Carol (Nichols || Goulding) 23a9a800a6 Merge remote-tracking branch 'origin/master' into hyper 2020-02-17 08:54:19 -05:00
Carol (Nichols || Goulding) d70a123356
Merge pull request #36 from influxdata/er-fix-clippy
refactor: please the clippy gods
2020-02-17 08:20:28 -05:00
Carol (Nichols || Goulding) bbbbf8ee07 fix: Remove unnecessary allocation 2020-02-17 08:10:53 -05:00
Edd Robinson 0b3c412cfc chore: make clippy required CI step 2020-02-14 18:27:53 +00:00
Edd Robinson 1ad21b3e90 refactor: apply clippy 2020-02-14 18:19:51 +00:00
Edd Robinson 92baa3d7e8 refactor: apply clippy 2020-02-14 17:13:20 +00:00
Edd Robinson b2cdd299f5 refactor: apply clippy 2020-02-14 17:13:05 +00:00
Carol (Nichols || Goulding) 4dfd4d90ba fix: Use BytesMut directly rather than through actix 2020-02-14 10:56:37 -05:00
Carol (Nichols || Goulding) f7b33d47de fix: Adjust parameter type to avoid double allocation 2020-02-14 10:19:39 -05:00
Carol (Nichols || Goulding) 12fbb23112 fix: Make both query parsing places return bad request on failure 2020-02-14 10:17:48 -05:00
Carol (Nichols || Goulding) dc7a2ec333 fix: Improve parameter type 2020-02-14 10:02:35 -05:00
Carol (Nichols || Goulding) a16c49537f fix: Include limit in size exceeded error 2020-02-14 10:00:35 -05:00
Carol (Nichols || Goulding) 8b1255be9d refactor: Switch to a hyper server 2020-02-14 09:59:09 -05:00
Jake Goulding 49df607e48
Merge pull request #33 from influxdata/format
chore: Apply and enforce standard Rust formatting
2020-02-14 09:57:18 -05:00
Jake Goulding fd76a7394c ci: Enforce standard formatting 2020-02-14 08:02:24 -05:00
Jake Goulding 615e0f6537 style: Apply rustfmt defaults to the entire project 2020-02-14 08:02:11 -05:00
Carol (Nichols || Goulding) 414c5ba871
Merge pull request #32 from influxdata/cn-end-to-end-test
test: Add an end-to-end test
2020-02-13 12:32:34 -05:00
Carol (Nichols || Goulding) 77125bd8e5 improvement: Remove TODO comments that are now done 2020-02-13 10:47:01 -05:00
Carol (Nichols || Goulding) 9cce1e4882 test: Add an end-to-end test
This test:
- Runs the server in a thread
- Writes some data
- Reads some data
- Shuts down the server
2020-02-13 10:40:03 -05:00
Carol (Nichols || Goulding) 28d03c4047
Merge pull request #31 from influxdata/cn-small-piece
Refactoring for generics
2020-02-12 09:49:50 -05:00
Carol (Nichols || Goulding) 5942dd5c8a fix: Remove turbofish that are no longer needed 2020-02-12 09:46:29 -05:00
Carol (Nichols || Goulding) 64223b70a9 refactor: Collapse the read_*_range functions 2020-02-12 09:43:42 -05:00
Carol (Nichols || Goulding) 3399cea18a refactor: Extract a trait to make read_*_range fns more similar 2020-02-12 09:43:42 -05:00
Carol (Nichols || Goulding) 16c8834fbc refactor: Collapse read_*_range functions into a generic function 2020-02-12 09:43:40 -05:00
Carol (Nichols || Goulding) 2b642ffaac refactor: Make read_*_bytes more similar by extracting a trait 2020-02-12 09:42:47 -05:00