This avoids a module error in Go 1.13 from a poorly tagged transitive
test dependency that looks like:
gopkg.in/stretchr/testify.v1/assert: go.mod has non-....v1 module path
"github.com/stretchr/testify" at revision v1.4.0
The `v1.databases()` call did not correctly filter buckets based on
auth. Fortunately, it did not cause any improper permissions such as
allowing a person to see buckets that they had no read access to.
The error instead was that if a user did not have read access to one of
the buckets that was returned, the entire command would fail rather than
filter out the bucket that didn't have permissions.
This changes it so that if the user doesn't gets an unauthorized error
when accessing a bucket, it will filter it from the list instead of
failing. It also changes it so the error message is marked as
`ENotFound` instead of as an internal error.
e2e tests are failing because the fancyscroll bar component hides
the admin step during certain points in onboarding.
We were able to reproduce when the form in the admin step had been
marked as valid.
The use of the scrollbar in the setting seemed unneeded as it could
be rendered in a quite small window.
Therefore, we removed the scrollbar altogether for now.
Co-authored-by: Christopher Henn <chris@chrishenn.net>
* build(webpack): add source maps for @influxdata/giraffe prod builds
We were getting runtime errors in the prod builds via honeybadger.
They were unreadable because we did not have source maps for giraffe.
We were only able to get this working for prod builds but not dev
despite trying putting it in the webpack common file. This is good
'nuff for our purpose now, but maybe we'll need further investigation.
Bonus commit... I added a new make target of influxd so I would not
need to type so much.
Co-authored-by: Andrew Watkins <watts@influxdb.com>
* build(webpack): add clockface source maps to production build
Co-authored-by: Andrew Watkins <watts@influxdb.com>
* refactor(ui): move QuestionMarkTooltip into shared folder
* refactor(ui): delete unused component
* refactor(ui): allow QuestionMarkTooltip to wrap other elements
* refactor(ui): Add question mark tooltips to alerting column headers
* refactor(ui): color code buttons to indicate importance and grouping
* refactor(ui): swap order of endpoints and rules columns
* refactor(ui): show "first time" widget when no alerting resources exist
* refactor(ui): update alerting empty copy
* refactor(ui): ensure onboarding tooltips are using the correct prop names
* refactor(ui): remove tests for tooltips in admin step
These should be handled by Clockface instead
* refactor(ui): fix affected e2e test
* chore(ui): update changelog
* refactor(ui): wrap entire UI in Clockface AppWrapper
* refactor(ui): create utility for ensuring consistent page titles
* refactor(ui): update settings and load data icons in nav
* refcator(ui): simplify templates page
* refactor(ui): ensure unauthenticated pages are wrapped in AppWrapper
* refactor(ui): replace all instances of local Page with clockface Page
* refactor(ui): move control of presentation mode to AppWrapper
* refactor(ui): delete local Page components
* refactor(ui): ensure that onboarding pages are visible
* refactor(ui): remove unused "Account" page
* refactor(ui): appease linter gods
* refactor(ui): ensure alerting index fills height of page
* refactor(ui): fix padding in time machine view
fix(notification/rule): add overlap to windows so that state changes works
Since stateChanges cannot detect a state change for the initial point,
returned, we generate a task that queries for more data than required
and filters out records that are before the every. This way we will not
miss state changes that take place on the initial value.
fix(notification/rule): prevent union of tables for single status rule
fix(testing): add status rules to notifications
When a task is told to execute it can be enqueued waiting for a worker.
This statistic will be superior to the existing delta based on scheduled for,
the current system can be effected by a user having slow queries or a long "delay" on the task.
This new way of measuring the same thing should allow us to accuratly measure when it is the task system's fault.
Previously the TSI partition would panic if a compaction was
started while `Wait()` was waiting. This commit removes the previous
wait group and replaces it with a simple counter. The `Wait()`
function now polls the counter until it reaches zero.
Christopher Henn
kelwang
Kelvin Wang
Russ Savage
Michael Desa
alexpaxton
Mark Rushakoff
Jonathan A. Sternberg
Stuart Carnie
Ben Johnson
Chris Goller
Nathaniel Cook
Edd Robinson
George
Deniz Kusefoglu
Lyon Hill