Commit Graph

5241 Commits (94852f9c441264ca9010b5ebfe3664502de1b20f)

Author SHA1 Message Date
kodiakhq[bot] 94852f9c44
Merge pull request #2786 from influxdata/dependabot/cargo/assert_cmd-2.0.2
chore(deps): bump assert_cmd from 2.0.1 to 2.0.2
2021-10-11 07:59:35 +00:00
dependabot[bot] 01a44899fd
chore(deps): bump assert_cmd from 2.0.1 to 2.0.2
Bumps [assert_cmd](https://github.com/assert-rs/assert_cmd) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/assert-rs/assert_cmd/releases)
- [Changelog](https://github.com/assert-rs/assert_cmd/blob/master/CHANGELOG.md)
- [Commits](https://github.com/assert-rs/assert_cmd/compare/v2.0.1...v2.0.2)

---
updated-dependencies:
- dependency-name: assert_cmd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-11 01:45:35 +00:00
kodiakhq[bot] 0666e0908c
Merge pull request #2773 from influxdata/cn/chunk-addr-smaller
fix: Remove some calls to iox_object_store.database_name
2021-10-08 17:34:58 +00:00
kodiakhq[bot] 559a7e0221
Merge branch 'main' into cn/chunk-addr-smaller 2021-10-08 17:26:20 +00:00
Andrew Lamb 2072b4066e
feat: Implement support for `_measurement` predicate in gRPC plans (#2772)
* feat: Implement filtering for _measurement in general purpose gRPC plans

* docs: fixup docstrings

* fix: fmt

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-08 17:25:33 +00:00
kodiakhq[bot] 7f3fcd99c4
Merge pull request #2770 from influxdata/crepererum/better_chunk_id_dbg
feat: improve `Debug`/`Display` for test `ChunkId`s
2021-10-08 15:41:28 +00:00
kodiakhq[bot] 8b7fd77abe
Merge branch 'main' into crepererum/better_chunk_id_dbg 2021-10-08 15:33:12 +00:00
Andrew Lamb ca38eafe20
refactor: Reduce string comparisons in gRPC expr tests (#2765)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-08 15:03:03 +00:00
kodiakhq[bot] b887a0896c
Merge pull request #2769 from influxdata/er/fix/read_buffer/negation_pred
fix: ensure correct PredicateMatch for columns
2021-10-08 14:07:57 +00:00
Carol (Nichols || Goulding) fbe76935f4 fix: Remove some calls to iox_object_store.database_name 2021-10-08 09:50:14 -04:00
Marco Neumann 64bda1fc08 feat: improve `Debug`/`Display` for test `ChunkId`s 2021-10-08 13:55:56 +02:00
Edd Robinson 5b71a3668a
Merge branch 'main' into er/fix/read_buffer/negation_pred 2021-10-08 12:47:04 +01:00
Edd Robinson 04a7ddd34a fix: ensure correct PredicateMatch for columns 2021-10-08 12:46:24 +01:00
kodiakhq[bot] 222f452a8a
Merge pull request #2768 from influxdata/crepererum/issue2225_b
fix: review comments of #2767
2021-10-08 10:45:50 +00:00
Marco Neumann f8b5c0ee50 fix: remove obsolete TODO 2021-10-08 12:36:23 +02:00
Marco Neumann d3de6bb6e4 refactor: `max_persisted_timestamp` => `flush_timestamp`
There might be data left before this timestamp that wasn't persisted
(e.g. incoming data while the persistence was running).
2021-10-08 12:36:23 +02:00
kodiakhq[bot] f59ee631c1
Merge pull request #2767 from influxdata/crepererum/issue2225
refactor: "min unpersisted ts" => "max persisted ts"
2021-10-08 10:35:43 +00:00
Marco Neumann 63a932fa37 refactor: "min unpersisted ts" => "max persisted ts"
Store the "maximum persisted timestamp" instead of the "minimum
unpersisted timestamp". This avoids the need to calculate the next
timestamp from the current one (which was done via "max TS + 1ns").

The old calculation was prone to overflow panics. Since the
timestamps in this calculation originate from user-provided data (and
not the wall clock), this was an easy DoS vector that could be triggered
via the following line protocol:

```text
table_1 foo=1 <i64::MAX>
```

which is

```text
table_1 foo=1 9223372036854775807
```

Bonus points: the timestamp persisted in the partition
checkpoints is now the very same that was used by the split query during
persistence. Consistence FTW!

Fixes #2225.
2021-10-08 11:52:49 +02:00
kodiakhq[bot] 8817ee8d61
Merge pull request #2759 from influxdata/crepererum/issue2627
fix: interaction of lifecycle actions and delete predicates
2021-10-08 07:43:09 +00:00
kodiakhq[bot] 001ed36da4
Merge branch 'main' into crepererum/issue2627 2021-10-08 07:35:08 +00:00
Andrew Lamb e590ac4da2
fix: remove outdated "supported predicate" check in gRPC planner (#2763) 2021-10-07 20:34:05 +00:00
Andrew Lamb c7727f1b5b
chore: Update datafusion + other deps (#2760)
* chore: Update datafusion and other deps

* fix: fmt

* fix: cleanup workaround

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-07 16:48:11 +00:00
kodiakhq[bot] 4ca9120192
Merge pull request #2682 from influxdata/cn/uuid
feat: Add UUID to databases
2021-10-07 14:41:16 +00:00
kodiakhq[bot] 0b24564309
Merge branch 'main' into cn/uuid 2021-10-07 14:31:48 +00:00
Carol (Nichols || Goulding) 15b396c720 fix: Set a UUID if none was read from object storage on server startup
This enables a smoother transition to this state when this gets
deployed.
2021-10-07 10:19:17 -04:00
Carol (Nichols || Goulding) 169f2499d3 fix: Use bytes for UUID in the protobuf instead of string 2021-10-07 10:19:17 -04:00
Carol (Nichols || Goulding) ae7d893199 feat: Add UUID to databases
Connects to #2675.

When a database is created, assign it a UUID and serialize the UUID to
object storage by wrapping the database rules in a new
`PersistedDatabaseRules` type that also contains the UUID.

All APIs to the end user involving rules should continue using only
`DatabaseRules` so the UUID is an internal implementation detail.
2021-10-07 10:19:14 -04:00
Raphael Taylor-Davies d4bc33b921
refactor: use RWLock instead of TaskTracker for query exec shutdown (#2761) 2021-10-07 14:18:40 +00:00
Carol (Nichols || Goulding) 27e7a1f925 refactor: Organize use statements 2021-10-07 10:17:19 -04:00
Andrew Lamb 0b4fd01d04
fix: Cast count aggregates correctly (#2756)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-07 10:49:15 +00:00
Marco Neumann 81c75eec7e fix: interaction of preservation and delete predicates
This is the second part of #2627.
2021-10-07 11:38:09 +02:00
Marco Neumann 57b3be3b2d fix: interaction of compaction and delete predicates
- predicates that existed before the compaction can be forgotten since
  they are materialized during compaction
- predicates that are added while the compaction is running must be
  included into the new chunk

This is the first half of #2627.
2021-10-07 11:24:58 +02:00
kodiakhq[bot] be60b6c473
Merge pull request #2757 from influxdata/crepererum/issue2748
fix: flaky `delete_predicate_preservation`
2021-10-07 09:12:16 +00:00
kodiakhq[bot] 7d6be3f500
Merge branch 'main' into crepererum/issue2748 2021-10-07 09:04:18 +00:00
Raphael Taylor-Davies fb9119fa4c
feat: remove serde from data types (#2652) 2021-10-07 08:58:06 +00:00
kodiakhq[bot] 4c708ab784
Merge pull request #2747 from influxdata/crepererum/chunk_id_uuid
refactor: make `ChunkId` a UUID
2021-10-07 08:39:39 +00:00
Marco Neumann 8b06d72a58 fix: address review comments 2021-10-07 10:24:19 +02:00
Marco Neumann 63d74be490 refactor: make `ChunkId` a UUID 2021-10-07 10:23:27 +02:00
Marco Neumann 0374ba2284 fix: re-enable no longer flaky part of `delete_predicate_preservation`
Fix #2748.
2021-10-07 10:15:49 +02:00
Marco Neumann 2a52fd90d9 fix: transaction pruning logic for "nothing to do" 2021-10-07 10:14:42 +02:00
Andrew Lamb efa2316626
fix: do not sort the output of read_group with no group keys (#2755) 2021-10-06 18:59:58 +00:00
Raphael Taylor-Davies 39157828b1
feat: remove remaining usages of Instant (#2722) (#2749)
* feat: remove remaining usages of Instant (#2722)

* chore: review feedback

Co-authored-by: Andrew Lamb <alamb@influxdata.com>

Co-authored-by: Andrew Lamb <alamb@influxdata.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-06 16:44:02 +00:00
kodiakhq[bot] 772c7621db
Merge pull request #2746 from influxdata/ntran/no_use_stats
feat: Disable using statistics to query data if there are soft deleted rows
2021-10-06 15:26:49 +00:00
Nga Tran 05387f5a70 test: disable running query after re-create db in delete_predicate_preservation to avoid flaky test 2021-10-06 11:17:02 -04:00
Nga Tran bd93b411c7 chore: cleanup 2021-10-06 10:57:51 -04:00
kodiakhq[bot] 1aee2a49eb
Merge branch 'main' into ntran/no_use_stats 2021-10-06 14:06:01 +00:00
Nga Tran 65a02f7085
refactor: Apply suggestions from code review
Co-authored-by: Edd Robinson <me@edd.io>
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
2021-10-06 10:04:28 -04:00
Raphael Taylor-Davies ce5b24e65d
refactor: use DateTime<Utc> in PersistenceWindows (#2722) (#2743)
* refactor: use DateTime<Utc> in PersistenceWindows (#2722)

* chore: fix benchmark

* chore: fmt

* chore: review feedback
2021-10-06 09:39:32 +00:00
Edd Robinson ea26a77217
Merge branch 'main' into ntran/no_use_stats 2021-10-06 09:30:18 +01:00
kodiakhq[bot] fe61a4a868
Merge pull request #2628 from influxdata/crepererum/move_delete_predicate_persistence
refactor: move delete predicate persistence into background job
2021-10-06 06:14:05 +00:00