Commit Graph

8214 Commits (6413e87030a51cd34020b6dd06aabb4dd63b5a65)

Author SHA1 Message Date
Ben Johnson 6413e87030 revert default engine to bz1 2015-10-23 13:31:30 -06:00
Ben Johnson d35657629f Merge pull request #4553 from benbjohnson/tsm1-decode-buffer
Reuse tsm1 decode buffer
2015-10-23 13:16:13 -06:00
Ben Johnson e9d303531e reuse tsm1 decode buffer
This commit changes `tsm1.DecodeBlock()` to reuse the same
slice of `[]tsm1.Value` instead of reallocating a new one each time.
2015-10-23 12:51:55 -06:00
Jason Wilder 59bb82d25a Merge pull request #4555 from influxdb/jw-4545
Fix issues with removing/renaming files
2015-10-23 12:32:58 -06:00
Jason Wilder 7beb4f7fec Remove Stat+Remove before Rename calls
The Stat+Remove calls are unnecessary because Rename will replace
the destination file if it exist or not.  There is no need to remove
the destination file before calling Rename.
2015-10-23 12:18:49 -06:00
Jason Wilder 61cbb5b6ff Use RemoveAll instead of Remove
Several places use os.Remove and check for os.ErrNotExist.  os.Remove
does not return os.ErrNotExit, it returns a *PathError so these remove
calls will panic if the file does not exist.

Instead use os.RemoveAll that will not return an error if the file does
not exist.

Fixes #4545
2015-10-23 12:06:20 -06:00
Michael Desa f47634ec30 Merge pull request #4540 from influxdb/md-cleanup
Remove unneeded lines
2015-10-23 10:12:00 -07:00
Jason Wilder 827c51384c Merge pull request #4543 from influxdb/jw-wal-tests
Fix WAL Write/Close concurrency issues
2015-10-22 10:23:46 -06:00
Jason Wilder 8dec255b15 Move closing check for flush before cacheLock
Lock does not need to be acquired.
2015-10-22 10:12:07 -06:00
Ben Johnson 52610f5e21 Merge pull request #4531 from benbjohnson/map-series
Refactor tsdb query engine
2015-10-22 09:43:35 -06:00
Ben Johnson 28b585e639 refactor tsdb query engine
This commit refactors the tsdb query engine to use separate aggregate
and raw execution paths, encapsulates cursor functionality, and removes
the TagSetCursor from the aggregate path. By removing the TagSetCursor,
we can pass sets of unordered values to the map functions and bypass
the `container/heap` entirely.
2015-10-22 09:41:12 -06:00
Paul Dix 1233383ccf Merge pull request #4530 from influxdb/pd-tsm-fix-compaction-size
Ensure compactions don't create files much larger than 2GB.
2015-10-22 08:42:32 -04:00
Paul Dix 529985964f Ensure compactions don't create files much larger than 2GB.
* refactor compaction
* rework compaction cleanup logic to work with multiple resulting files
* ensure the uint64 number for a series key doesn't use 0 or MaxInt64 for sentinel values
2015-10-22 08:34:02 -04:00
Jason Wilder f66de17e8a Move closing channel init before first usage
Fix a test that closes and re-opens the same WAL.
2015-10-21 23:47:29 -06:00
Jason Wilder 6db5429d06 Fix deadlock when closing WAL and flush is running
Close acquired the cacheLock and writeLock in a different order than flush.  If addToCache was also
running in a goroutine (acquiring cacheLock), a deadlock could happen.
2015-10-21 23:46:59 -06:00
Jason Wilder 4f31b8fab9 Fix panic: error opening new segment file for wal
panic: error opening new segment file for wal: open /var/folders/lj/vlbynqp52pxdxxlxx64j6bk80000gn/T/tsm1-test709000715/_00002.wal: no such file or directory

goroutine 8 [running]:
github.com/influxdb/influxdb/tsdb/engine/tsm1.(*Log).writeToLog(0xc820098500, 0x1, 0xc8201584b0, 0x1c, 0x45, 0x0, 0x0)
	/Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/wal.go:427 +0xc19
2015-10-21 23:46:09 -06:00
Michael Desa 0035b79a84 Remove unneeded lines 2015-10-21 19:26:58 -07:00
Jason Wilder 3a5044d448 Merge pull request #4537 from influxdb/jw-tsm-tests
TSM test and data race fixes
2015-10-21 16:47:57 -06:00
Jason Wilder 4ac67259f7 Fix data race in filesAndLock/Compact
WARNING: DATA RACE
Write by goroutine 10:
  github.com/influxdb/influxdb/tsdb/engine/tsm1.(*Engine).Compact()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/tsm1.go:716 +0x1a3e
  github.com/influxdb/influxdb/tsdb/engine/tsm1_test.TestEngine_WriteCompaction_Concurrent.func2()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/tsm1_test.go:422 +0xc8

Previous read by goroutine 9:
  github.com/influxdb/influxdb/tsdb/engine/tsm1.(*Engine).filesAndLock()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/tsm1.go:476 +0xe8
  github.com/influxdb/influxdb/tsdb/engine/tsm1.(*Engine).Write()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/tsm1.go:370 +0x216
  github.com/influxdb/influxdb/tsdb/engine/tsm1.(*Log).flush()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/wal.go:604 +0xef4
  github.com/influxdb/influxdb/tsdb/engine/tsm1.(*Log).WritePoints()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/wal.go:243 +0x794
  github.com/influxdb/influxdb/tsdb/engine/tsm1.(*Engine).WritePoints()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/tsm1.go:350 +0xb0
  github.com/influxdb/influxdb/tsdb/engine/tsm1_test.TestEngine_WriteCompaction_Concurrent.func1()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/tsm1_test.go:401 +0x432

Goroutine 10 (running) created at:
  github.com/influxdb/influxdb/tsdb/engine/tsm1_test.TestEngine_WriteCompaction_Concurrent()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/tsm1_test.go:426 +0x225
  testing.tRunner()
      /private/var/folders/q8/bf_4b1ts2zj0l7b0p1dv36lr0000gp/T/workdir/go/src/testing/testing.go:456 +0xdc

Goroutine 9 (running) created at:
  github.com/influxdb/influxdb/tsdb/engine/tsm1_test.TestEngine_WriteCompaction_Concurrent()
      /Users/jason/go/src/github.com/influxdb/influxdb/tsdb/engine/tsm1/tsm1_test.go:406 +0x182
  testing.tRunner()
      /private/var/folders/q8/bf_4b1ts2zj0l7b0p1dv36lr0000gp/T/workdir/go/src/testing/testing.go:456 +0xdc
2015-10-21 16:38:35 -06:00
Jason Wilder cf8a7c6d9a Fix panic: assignment to entry in nil map
WAL.addToCache could if WritePoints call is running when the WAL is
closed.
2015-10-21 16:33:36 -06:00
Jason Wilder 4c4ffda30a Add WAL write/flush concurrently test 2015-10-21 16:33:26 -06:00
Nathaniel Cook 81d90ef43b Merge pull request #4536 from influxdb/nc-fix-subscriptions
fix subscriber logic when closed
2015-10-21 15:21:55 -06:00
Jason Wilder 965827c8e8 Add test for writing/querying series with mixed field numbers 2015-10-21 15:21:28 -06:00
Jason Wilder 1922a4010f Add test for writin/querying point earlier than first stored 2015-10-21 15:21:28 -06:00
Nathaniel Cook 7c71ed53a4 fix subscriber logic when closed 2015-10-21 15:08:55 -06:00
Jason Wilder dda247142f Merge pull request #4533 from influxdb/jw-tsm-races
Add test for data races in tsm1 Write
2015-10-21 12:38:42 -06:00
Jason Wilder 11bcb0f95a Add test for data races in tsm1 Write
Running this test with -race triggers a number of data races.
2015-10-21 12:26:39 -06:00
Jason Wilder 01bae0634c Merge pull request #4529 from influxdb/jw-tsm
Log errors when flushes fail
2015-10-21 11:13:41 -06:00
Jason Wilder e2ada3c59b Log errors when flushes fail
There errors were getting silently dropped which might be hiding
problems.
2015-10-21 09:12:34 -06:00
Philip O'Toole ff997a7726 Merge pull request #4514 from influxdb/cli_token
Display Enterprise message if no token set
2015-10-20 13:18:40 -07:00
Philip O'Toole bb80bf5211 Display Enterprise message if no token set 2015-10-20 12:59:22 -07:00
Philip O'Toole 956efaeb94 Merge pull request #4506 from influxdb/enterprise_stats
Enterprise registration as a service
2015-10-20 08:57:19 -07:00
Mark Bates 3cfe4e8da5 Added JSON tags to the Statistic struct 2015-10-20 11:40:42 -04:00
dgnorton ddca29a87b Merge pull request #4512 from influxdb/revert-database-rename
Revert database rename
2015-10-20 09:36:00 -04:00
David Norton a3d127f797 Revert "add RENAME DATABASE"
This reverts commit 7212bfce83.

Conflicts:
	influxql/parser.go
	influxql/token.go
	meta/internal/meta.pb.go
	meta/internal/meta.proto
2015-10-20 09:01:34 -04:00
David Norton 307d51dad5 Revert "add integration test for RENAME DATABASE"
This reverts commit d2afd881e6.
2015-10-20 08:43:57 -04:00
David Norton 20929c3db2 Revert "change syntax to ALTER DATABASE ... RENAME TO ..."
This reverts commit 668b5b9bfb.
2015-10-20 08:43:45 -04:00
David Norton f198000151 Revert "update changelog"
This reverts commit 218de0acbb.

Conflicts:
	CHANGELOG.md
2015-10-20 08:43:16 -04:00
David Norton 84803a41a1 Revert "update user privileges on database rename"
This reverts commit 1383d964aa.
2015-10-20 08:42:19 -04:00
David Norton 34c9a053dd Revert "improvements from code review"
This reverts commit 37964a032f.

Conflicts:
	meta/internal/meta.proto
2015-10-20 08:41:50 -04:00
David Norton 73a0c0a247 Revert "return error when database rename conflicts with continuous queries"
This reverts commit 60d298936e.
2015-10-20 08:39:03 -04:00
Cameron Sparr 66a31ee9bc Add more public point functions for v2 client
Closes #4505
2015-10-19 17:55:26 -06:00
Philip O'Toole f0c4501135 Add registration info to diagnostic output 2015-10-19 16:54:26 -07:00
Philip O'Toole 83db5cdbf5 Update CHANGELOG 2015-10-19 15:30:40 -07:00
Philip O'Toole 878663e1e3 Periodic upload of stats to Enterprise 2015-10-19 15:25:07 -07:00
Philip O'Toole 667ad3342a Refactor registration as a service
Registration also involves statistics and diagnostics upload, for the
purposes of remote management. This means there will be long-running
goroutines in effect. Therefore move the code to a service model.
2015-10-19 15:01:14 -07:00
Philip O'Toole ef72c3c64d Fix typo in retention service comment
[ci skip]
2015-10-19 14:24:25 -07:00
Philip O'Toole 90cc2cdce2 Export Statistic type 2015-10-19 14:06:14 -07:00
Gunnar f101e98bcb Merge pull request #4500 from influxdb/ga-time-bounds
Handle negative timestamps
2015-10-19 13:51:40 -07:00
gunnaraasen 859d2a46e8 Add test for 1- timestamp 2015-10-19 13:06:13 -07:00